gpr.c
> > @@ -29,7 +29,7 @@
> > #include
> > #include
> > #include
> > -#include
> > +#include
> > #include
> > #include
> > #include
Acked-by: James Hogan
Cheers
James
signature.asc
Description: PGP signature
Hi Arnd,
On Fri, Feb 23, 2018 at 01:26:09PM +0100, Arnd Bergmann wrote:
> On Fri, Feb 23, 2018 at 12:02 PM, James Hogan wrote:
> > I'm happy to put v2 in linux-next now (only patch 4 has changed, I just
> > sent an updated version), and send you a pull request early next week
On Fri, Feb 23, 2018 at 11:26:58AM +0100, Arnd Bergmann wrote:
> On Thu, Feb 22, 2018 at 12:38 AM, James Hogan wrote:
> > So lets call it a day and drop the Meta architecture port from the
> > kernel. RIP Meta.
>
> Since I brought up the architecture removal independently, I
On Thu, Feb 22, 2018 at 10:26:54AM +0100, Peter Zijlstra wrote:
> On Wed, Feb 21, 2018 at 11:38:12PM +0000, James Hogan wrote:
> > So lets call it a day and drop the Meta architecture port from the
> > kernel. RIP Meta.
>
> So long, and thanks for all the fish!
>
>
Carvalho Chehab
Cc: Wolfram Sang
Cc: linux-me...@vger.kernel.org
Cc: linux-...@vger.kernel.org
Cc: linux...@kvack.org
Cc: linux-g...@vger.kernel.org
Cc: linux-watch...@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-...@vger.kernel.org
James Hogan (13):
metag: Remove arch/metag/
doc
Now that arch/metag/ has been removed, remove the METAG dependency from
the IMG IR device driver. The hardware is also present on MIPS SoCs so
the driver still has value.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
Cc: linux-me
c:351: warning: Excess function
> parameter 'timings' description in 'img_ir_decoder_convert'
>
> Signed-off-by: Mauro Carvalho Chehab
Very true.
Acked-by: James Hogan
Thanks
James
> ---
> drivers/media/rc/img-ir/img-ir-hw.c | 2 +-
> 1 file changed, 1 insertion
Hi Sean,
On Tue, Dec 13, 2016 at 07:54:16AM +, Sean Young wrote:
> So that leaves the question open of whether we want to guess the protocol
> variant from the scancode for img-ir or if we can live with having to
> select this using wakeup_protocols. Having to do this does solve the issue
> of
Hi Sean (and Sifan),
On Mon, Dec 12, 2016 at 09:13:43PM +, Sean Young wrote:
> Rather than guessing what variant a scancode is from its length,
> use the new wakeup_protocol.
>
> Signed-off-by: Sean Young
> Cc: James Hogan
> Cc: Sifan Naeem
> ---
> drivers/med
Hi,
On Mon, Mar 07, 2016 at 10:01:09AM +0100, Geert Uytterhoeven wrote:
> On Mon, Mar 7, 2016 at 9:55 AM, Geert Uytterhoeven
> wrote:
> > JFYI, when comparing v4.5-rc7[1] to v4.5-rc6[3], the summaries are:
> > - build errors: +8/-7
> + error: debugfs.c: undefined reference to `clk_round_rate
;)
> Cc: # 3.15+
Thanks for catching this Sifan. It appears to have been introduced while
getting the driver ready for upstream (it used to use the devm_* API to
request the IRQ, but I changed it to avoid the ISR racing with module
removal).
Acked-by: James Hogan
Cheers
James
> ---
>
, so it must not be
> disabled during use or the driver will malfunction.
>
> Signed-off-by: Sifan Naeem
Thanks Sifan, looks good to me, doesn't break tz1090, and seems to still
cope with no clocks provided in DT.
Acked-by: James Hogan
Cheers
James
> ---
> Changes fro
Hi Sifan,
On 03/02/15 17:30, Sifan Naeem wrote:
> Gets a handle to the system clock, already described in the binding
> document, and calls the appropriate common clock
> framework functions to mark it prepared/enabled, the common clock
> framework initially enables the clock and doesn't disable i
On 12/12/14 12:07, James Hogan wrote:
> Hi Sifan,
>
> On 11/12/14 20:06, Sifan Naeem wrote:
>> Biphase decoding in the current img-ir has got a quirk, where multiple
>> Interrupts are generated when an incomplete IR code is received by the
>> decoder.
>>
>>
about. I'll let you
decide whether that needs changing since you have the hardware to verify it.
So for the whole patchset feel free to add my:
Acked-by: James Hogan
Thanks
James
>
> Signed-off-by: Sifan Naeem
> ---
> drivers/media/rc/img-ir/img-ir-hw.c | 60
> ++
Hi Sifan,
On 11/12/14 18:54, Sifan Naeem wrote:
>>> +/*
>>> + * Timer function to re-enable the current protocol after it had been
>>> + * cleared when invalid interrupts were generated due to a quirk in
>>> +the
>>> + * img-ir decoder.
>>> + */
>>> +static void img_ir_suspend_timer(unsigned long
On 04/12/14 15:38, Sifan Naeem wrote:
> Add img-ir module for decoding Philips rc6 protocol.
>
> Signed-off-by: Sifan Naeem
Aside from the "Philips" thing:
Acked-by: James Hogan
(It's unpleasant having unexplained timings for RC-6, but it's better
than no RC-6
nyo,
> Aiwa, Chinon remotes) in the ImgTec infrared decoder block.
> +
> +config IR_IMG_RC5
> + bool "Phillips RC5 protocol support"
I think that should be "Philips" (if wikipedia is anything to go by).
Same elsewhere in this patch and patch 5.
Other th
On 04/12/14 15:38, Sifan Naeem wrote:
> Biphase decoding in the current img-ir has got a quirk, where multiple
> Interrupts are generated when an incomplete IR code is received by the
> decoder.
>
> Patch adds a work around for the quirk and enables biphase decoding.
>
> Signed-off-by: Sifan Naee
therwise:
Acked-by: James Hogan
Cheers
James
>
> Signed-off-by: Sifan Naeem
> ---
> drivers/media/rc/img-ir/img-ir-hw.c |8 +---
> drivers/media/rc/img-ir/img-ir-hw.h |2 ++
> 2 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/r
ows it to be extended more easily without
> touching all the hardware decode callbacks.
>
> Signed-off-by: Sifan Naeem
Acked-by: James Hogan
Cheers
James
> ---
> drivers/media/rc/img-ir/img-ir-hw.c| 16 +---
> drivers/media/rc/img-ir/img-ir-hw.h| 16 ++
a6e162d6a46 ("[media] rc-core: simplify sysfs code")
Reported-by: Sifan Naeem
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: David Härdeman
Cc: # v3.17+
Cc: linux-media@vger.kernel.org
---
Changes in v2:
- Move fix to store_protocols(). Still set filter again even if protoc
Hi Mauro,
On 04/12/14 17:38, Mauro Carvalho Chehab wrote:
> Em Mon, 1 Dec 2014 12:55:09 +
> James Hogan escreveu:
>
>> When the img-ir driver is asked to change protocol, if the chosen
>> decoder is already loaded then don't call img_ir_set_decoder(), so as
&
;(&priv->lock)->rlock#2);
*** DEADLOCK ***
This is fixed by releasing the main spin lock while performing the
del_timer_sync() call. The timer is prevented from restarting before the
lock is reacquired by a new "stopping" flag which img_ir_handle_data()
checks before updati
tocols
$ echo 0x > filter_mask
$ echo nec > protocols
After this, messages which don't match the filter still get received.
Reported-by: Sifan Naeem
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: # v3.15+
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/img-ir/img-ir
t.
I've tagged both for stable (v3.15+).
Cc: Mauro Carvalho Chehab
Cc: Sifan Naeem
Cc: linux-media@vger.kernel.org
James Hogan (2):
img-ir/hw: Avoid clearing filter for no-op protocol change
img-ir/hw: Fix potential deadlock stopping timer
drivers/media/rc/img
Add myself as the maintainer for the Imagination Technologies Infrared
Decoder driver.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index ea4d0058fd1b
is
unchanged since the powerup key data was never read.
This is worked around by always reading the IMG_IR_DATA_x in
img_ir_set_decoder(), rather than only when the IMG_IR_RXDVAL or
IMG_IR_RXDVALD2 bit is set.
Signed-off-by: Dylan Rajaratnam
Signed-off-by: James Hogan
Cc: Mauro Carvalho
Don't bother setting .owner = THIS_MODULE, since it's already handled by
the platform_driver_register macro.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/img-ir/img-ir-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git
allmodconfig builds), to avoid cluttering the Kconfig menu with
drivers for hardware that isn't yet available on other platforms.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/img-ir/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --
igned-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/img-ir/img-ir-hw.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/rc/img-ir/img-ir-hw.h
b/drivers/media/rc/img-ir/img-ir-hw.h
index 8fcc16c32c5b..a8c6a8d40206 100644
Here are a few fixes for the img-ir RC driver.
Patch 1 is the important one. I've tagged it for stable.
The other 4 are minor fixes/improvements that don't need backporting to
stable.
Dylan Rajaratnam (1):
img-ir/hw: Always read data to clear buffer
James Hogan (4):
img-ir/hw
On 22 October 2014 15:12, Hans Verkuil wrote:
> How to submit patches for a stable kernel
> =
>
> The standard method is to add this tag:
>
> Cc: sta...@vger.kernel.org
>
> possibly with a comment saying to which versions it should be applied, like:
ared. Should it be static?
> drivers/media/rc/img-ir/img-ir-sanyo.c:82:23: warning: symbol
> 'img_ir_sanyo' was not declared. Should it be static?
>
> Signed-off-by: Hans Verkuil
Acked-by: James Hogan
Thanks
James
--
To unsubscribe from this list: send the line "unsu
Hi Mauro,
On Wednesday 23 July 2014 16:39:36 Mauro Carvalho Chehab wrote:
> Em Fri, 14 Mar 2014 23:04:10 +
>
> James Hogan escreveu:
> > A recent discussion about proposed interfaces for setting up the
> > hardware wakeup filter lead to the conclusion that it could
Hi Alexander,
Just a few probe error handling suggestions...
On 13/05/14 19:39, Alexander Bersenev wrote:
> +static int sunxi_ir_probe(struct platform_device *pdev)
> +{
> + int ret = 0;
> + unsigned long tmp = 0;
> +
> + struct device *dev = &pdev->dev;
> + struct device_node *dn
On Friday 04 April 2014 01:34:43 David Härdeman wrote:
> Having a mutex named "lock" is a bit misleading.
Why? A mutex is a type of lock so what's the problem?
A little grep'ing and sed'ing reveals that out of the 1578 unique mutex names
in the kernel source I have to hand, 540 contain "lock", a
On Saturday 05 April 2014 00:06:06 David Härdeman wrote:
> The generic scancode filtering has questionable value and makes it
> impossible to determine from userspace if there is an actual
> scancode hw filter present or not.
>
> So revert the generic parts.
>
> Based on a p
and
> make the distinction explicit.
>
> v2: hopefully address James' comments on what should be moved from this to
> the next patch.
>
> Signed-off-by: David Härdeman
Acked-by: James Hogan
Thanks
James
> ---
> drivers/media/rc/img-ir/img-ir-hw.c | 15 +
>
> This patch is in preparation for the next few patches in this series.
>
> v2: make sure img-ir scancodes are bitrev8():ed as well
>
> v3: update comments
>
> Signed-off-by: David Härdeman
Acked-by: James Hogan
Thanks
James
> ---
> drivers/media/rc/img-i
ioned in a different email that reverting the last
two hunks of b8c7d915087c97a21fa415fa0e860e59739da202 should be in
this patch rather than combined into patch 5.
But if you fix that you're welcome to my:
Reviewed-by: James Hogan
Thanks
James
>
> Based on a patch from James Hogan
ask >> 16) & 0xff;
> - data_inv = (in->data >> 8) & 0xff;
> - data_inv_m = (in->mask >> 8) & 0xff;
> + /* scan encoding: AAaaDDdd (LSBit first) */
same here
The actual code looks fin
in to the patch apply here too (sorry I didn't spot that when I
first looked at it!).
But if you fix that you're welcome to my:
Acked-by: James Hogan
Cheers
James
> drivers/media/rc/rc-main.c | 31 +++
> include/media/rc-core.h |
Hi David,
On Saturday 29 March 2014 17:11:11 David Härdeman wrote:
> Overloading dev->s_filter to do two different functions (set wakeup filters
> and generic hardware filters) makes it impossible to tell what the
> hardware actually supports, so create a separate dev->s_wakeup_filter and
> make t
On Monday 31 March 2014 21:38:13 David Härdeman wrote:
> >The rest looks reasonable, though it could easily have been a separate
> >patch (at least as long as the show/store callbacks don't assume the
> >presence of the callbacks they use).
>
> Yes, I wanted to avoid there being more intermediary
On 31/03/14 14:22, David Härdeman wrote:
> On 2014-03-31 12:56, James Hogan wrote:
>> This would mean that if the data is put in the right bit order (first
>> bit received in BIT(0), last bit received in BIT(31)), then the scancode
>> = raw, and if the data is received in
On 31/03/14 11:19, David Härdeman wrote:
> On 2014-03-31 11:44, James Hogan wrote:
>> On 29/03/14 16:11, David Härdeman wrote:
>>> Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core
>>> and the nec decoder without any loss of functionality.
&
On 29/03/14 16:11, David Härdeman wrote:
> Right now the protocol information is not preserved, rc-core gets handed a
> scancode but has no idea which protocol it corresponds to.
>
> This patch (which required reading through the source/keymap for all drivers,
> not fun) makes the protocol informa
On 29/03/14 16:11, David Härdeman wrote:
> Using the full 32 bits for all kinds of NEC scancodes simplifies rc-core
> and the nec decoder without any loss of functionality.
>
> In order to maintain backwards compatibility, some heuristics are added
> in rc-main.c to convert scancodes to NEC32 as n
On 29/03/14 16:11, David Härdeman wrote:
> The generic scancode filtering has questionable value and makes it
> impossible to determine from userspace if there is an actual
> scancode hw filter present or not.
>
> So revert the generic parts.
>
> Based on a patch from J
On 29/03/14 16:11, David Härdeman wrote:
> This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2
>
> The patch ignores the fact that NEC32 scancodes are generated not only in the
> NEC raw decoder but also directly in some drivers. Whichever approach is
> chosen
> it should be consistent across d
On Friday 28 March 2014 01:08:56 David Härdeman wrote:
> On Thu, Mar 27, 2014 at 11:21:23PM +0000, James Hogan wrote:
> >Hi David,
> >
> >On Thursday 27 March 2014 22:00:37 David Härdeman wrote:
> >> This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2
> >>
Hi David,
On Thursday 27 March 2014 22:00:37 David Härdeman wrote:
> This reverts 18bc17448147e93f31cc9b1a83be49f1224657b2
>
> The patch ignores the fact that NEC32 scancodes are generated not only in
> the NEC raw decoder but also directly in some drivers. Whichever approach
> is chosen it shoul
Add the basic GPLv2+ license notice to the copyright headers at the top
of all the source files in the img-ir driver.
Reported-by: David Härdeman
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: David Härdeman
---
drivers/media/rc/img-ir/img-ir-core.c | 5 +
drivers/media/rc/img
n one wakeup protocol
since only a single protocol can usually be used for wakeup at a time,
and doing so with encode based wakeup will result in an arbitrary
protocol being used if multiple are possible.
Reported-by: Antti Seppälä
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Se
r part (i.e. the software
> filtering) should be removed until it has had further discussion.
Reported-by: David Härdeman
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: David Härdeman
Cc: Antti Seppälä
---
drivers/media/rc/rc-main.c | 26 --
1 file c
A few misc fixes for v3.15, all relating to my previous patches.
James Hogan (3):
rc-main: Revert generic scancode filtering support
rc-main: Limit to a single wakeup protocol group
rc: img-ir: Expand copyright headers with GPL notices
drivers/media/rc/img-ir/img-ir-core.c | 5
On 26/03/14 13:44, David Härdeman wrote:
> On 2014-03-26 08:08, Antti Seppälä wrote:
>> On 26 March 2014 01:21, David Härdeman wrote:
>>> On Tue, Mar 25, 2014 at 09:12:11AM +, James Hogan wrote:
>>>> On Tuesday 25 March 2014 00:51:46 David Härdeman wrote:
>>
On 25/03/14 23:53, David Härdeman wrote:
> On Fri, Feb 28, 2014 at 11:28:50PM +0000, James Hogan wrote:
>> Add a driver for the ImgTec Infrared decoder block. Two separate rc
>> input devices are exposed depending on kernel configuration. One uses
>> the hardware decoder
On Tuesday 25 March 2014 00:51:46 David Härdeman wrote:
> On Fri, Feb 28, 2014 at 11:17:02PM +0000, James Hogan wrote:
> >Add generic scancode filtering of RC input events, and fall back to
> >permitting any RC_FILTER_NORMAL scancode filter to be set if no s_filter
> >callbac
On Monday 17 March 2014 19:01:51 Antti Seppälä wrote:
> On 17 March 2014 00:41, James Hogan wrote:
> > Yeh I'm in two minds about this now. It's actually a little awkward since
> > some of the protocols have multiple variants (i.e. "rc-5" = RC5+RC5X),
> &
On Sunday 16 March 2014 10:22:02 Antti Seppälä wrote:
> On 15 March 2014 01:04, James Hogan wrote:
> > A recent discussion about proposed interfaces for setting up the
> > hardware wakeup filter lead to the conclusion that it could help to have
> > the generic capability t
On Sunday 16 March 2014 14:14:58 Antti Seppälä wrote:
> Hi James.
>
> On 16 March 2014 13:50, James Hogan wrote:
> > Hi Antti,
> >
> > On Sunday 16 March 2014 10:34:31 Antti Seppälä wrote:
> >> > +
> >> > + /* all important bits of
On Sunday 16 March 2014 10:39:39 Antti Seppälä wrote:
> > +static int nvt_write_wakeup_codes(struct rc_dev *dev,
> > + const u8 *wakeup_sample_buf, int count)
> > +{
> > + int i = 0;
> > + u8 reg, reg_learn_mode;
> > + unsigned long flags;
> > +
Hi Antti,
On Sunday 16 March 2014 10:34:31 Antti Seppälä wrote:
> > +/**
> > + * ir_rc5_sz_encode() - Encode a scancode as a stream of raw events
> > + *
> > + * @protocols: allowed protocols
> > + * @scancode: scancode filter describing scancode (helps distinguish
> > between + * pro
functionality.
Signed-off-by: Antti Seppälä
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Jarod Wilson
Cc: Wei Yongjun
Cc: Hans Verkuil
---
Please note this patch is only build tested.
Changes in v2 (James Hogan):
- Handle new -ENOBUFS when IR encoding buffer isn't long enoug
Add the s_filter callback to the rc-loopback driver, which instead of
setting the filter just feeds the scancode back through the input device
so that it can be verified.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Seppälä
---
Changes in v2:
- Move img-ir-raw test code to
Add IR encoding helper for pulse-distance modulation as used by the NEC
protocol.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Seppälä
Cc: David Härdeman
---
Changes in v2:
- Alter encode API to return -ENOBUFS when there isn't enough buffer
space. When this occur
From: Antti Seppälä
The encoding in rc5-sz first inserts a pulse and then simply utilizes the
generic Manchester encoder available in rc-core.
Signed-off-by: Antti Seppälä
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: David Härdeman
---
Changes in v2 (James Hogan):
- Turn
the sysfs interface to know which wakeup protocols
are allowed for encode_wakeup drivers, also ensure that the IR
decoders/encoders are loaded when an encode_wakeup driver is registered.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Seppälä
Cc: David Härdeman
---
Changes in v2
Add the capability to encode NEC scancodes as raw events. The
scancode_to_raw is pretty much taken from the img-ir NEC filter()
callback, and modulation uses the pulse distance helper added in a
previous commit.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Seppälä
Cc: David
Add a callback to raw ir handlers for encoding and modulating a scancode
to a set of raw events. This could be used for transmit, or for
converting a wakeup scancode filter to a form that is more suitable for
raw hardware wake up filters.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc
From: Antti Seppälä
Adding a simple Manchester encoder to rc-core.
Manchester coding is used by at least RC-5 protocol and its variants.
Signed-off-by: Antti Seppälä
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: David Härdeman
---
Changes in v2 (James Hogan):
- Alter encode API
in both data and mask is unambiguously RC-5X.
The Manchester modulation helper is used, and for RC-5X it is used twice
with two sets of timings, the first with a short trailer space for the
space in the middle, and the second with no leader so that it can
continue the space.
Signed-off-by: James
rt for writing wakeup samples via sysfs
filter callback
James Hogan (6):
rc: ir-raw: Add scancode encoder callback
rc: ir-raw: Add pulse-distance modulation helper
rc: ir-nec-decoder: Add encode capability
rc: ir-rc5-decoder: Add encode capability
rc: rc-core: Add support for encode_wak
-variable]
Reported-by: Mauro Carvalho Chehab
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
---
I don't object to this patch being squashed into the patch "rc: img-ir:
add hardware decoder driver".
---
drivers/media/rc/img-ir/img-ir-hw.c | 6 +++---
1 file changed, 3 insertions(
Fix a coccicheck warning in img-ir driver:
drivers/media/rc/img-ir/img-ir-hw.c:500:2-3: Unneeded semicolon
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
---
I don't object to this patch being squashed into the patch "rc: img-ir:
add hardware decoder driver".
---
drivers/
These patches fix a few warnings in the img-ir driver, one from
coccinelle and two more from W=1 (thanks Mauro).
James Hogan (3):
rc: img-ir: hw: Remove unnecessary semi-colon
rc: img-ir: hw: Fix min/max bits setup
rc: img-ir: jvc: Remove unused no-leader timings
drivers/media/rc/img-ir
ing: (near initialization for
‘img_ir_jvc.timings.s01’) [-Woverride-init]
Reported-by: Mauro Carvalho Chehab
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
---
I don't object to this patch being squashed into the patch "rc: img-ir:
add JVC decoder module".
---
drivers/med
On 12/03/14 10:57, Mauro Carvalho Chehab wrote:
> Hi James,
>
> Em Fri, 28 Feb 2014 23:29:00 +0000
> James Hogan escreveu:
>
>> Add an img-ir module for decoding the Sanyo infrared protocol.
>
> After applying this series, some new warnings are popping u
Hi Antti,
On Wednesday 05 March 2014 20:12:15 Antti Seppälä wrote:
> After reviewing the series and porting my nuvoton changes to it I
> haven't noticed any errors worth mentioning.
> In fact I think this series is very well written and should be merged.
Thanks for reviewing!
> James, I hope you
device numbers left. The added code
doesn't depend on the device lock, so move it before the lock is taken.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/rc-main.c | 16
1 file changed, 8 insertions(+), 8 dele
filter conversion function
will be provided in separate files for each protocol which this part of
the driver can use. The new generic scan code filter interface is made
use of to reduce interrupts and control wake events.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media
Add an img-ir module for decoding the Sharp infrared protocol.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic struct rc_scancode_filter).
- Remove
Add raw IR remote control input driver for the ImgTec Infrared decoder
block's raw edge interrupts. Generic software protocol decoders are used
to allow multiple protocols to be supported at a time, including those
not supported by the hardware decoder.
Signed-off-by: James Hogan
Cc:
Add an img-ir module for decoding the NEC and extended NEC infrared
protocols.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
v2:
- Update scancode and filter callbacks to handle 32-bit NEC as used by
Apple and TiVo remotes (the new 32-bit NEC
Add an img-ir module for decoding the Sanyo infrared protocol.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic struct rc_scancode_filter).
- Remove
Add an img-ir module for decoding the JVC infrared protocol.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic struct rc_scancode_filter).
- Remove modularity
Add an img-ir module for decoding the Sony infrared protocol.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
v2:
- Update to new scancode interface (32-bit NEC).
- Update to new filtering interface (generic struct rc_scancode_filter).
- Remove
Add device tree binding for ImgTec Consumer Infrared block, specifically
major revision 1 of the hardware.
Signed-off-by: James Hogan
Acked-by: Rob Herring
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Cc: devicet
Add base driver for the ImgTec Infrared decoder block. The driver is
split into separate components for raw (software) decode and hardware
decoder which are in following commits.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
Cc: Grant Likely
Cc: Rob
Add ImgTec IR decoder driver to the build system.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/Kconfig | 2 ++
drivers/media/rc/Makefile| 1 +
drivers/media/rc/img-ir/Kconfig | 26
ypo in logic 1 pulse width comment.
- Set tolerance to 20%, which seemed to be needed for the cases I have.
Cc: Mauro Carvalho Chehab
Cc: Jarod Wilson
Cc: linux-media@vger.kernel.org
Cc: Grant Likely
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
Cc: Rob Landley
Cc: linux-...@vger.kernel.org
C
The allowed and enabled protocol masks need to be expanded to be per
filter type in order to support wakeup filter protocol selection. To
ease that process abstract access to the rc_dev::allowed_protos and
rc_dev::enabled_protocols members with inline functions.
Signed-off-by: James Hogan
Cc
first element
(RC_FILTER_NORMAL), and add a couple more helper functions for drivers
to use for setting the allowed and enabled wakeup protocols.
We also rename allowed_protos to allowed_protocols while we're at it,
which is more consistent with enabled_protocols.
Signed-off-by: James Hoga
callback to be omitted entirely if there is only
a single available wakeup protocol at a time, since selecting no
protocol will automatically clear the wakeup filter, disabling wakeup.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Seppälä
Cc: linux-media@vger.kernel.org
---
drivers
Add a wakeup_protocols sysfs file which controls the new
rc_dev::enabled_protocols[RC_FILTER_WAKEUP], which is the mask of
protocols that are used for the wakeup filter.
A new RC driver callback change_wakeup_protocol() is called to change
the wakeup protocol mask.
Signed-off-by: James Hogan
Cc
Cc: Mauro Carvalho Chehab
Cc: "Bruno Prémont"
Cc: Maxim Levitsky
Cc: Sean Young
Cc: "David Härdeman"
Cc: Jiri Kosina
Cc: "Antti Seppälä"
James Hogan (5):
rc-main: add generic scancode filtering
rc: abstract access to allowed/enabled protocols
rc: add al
filter out the corner cases.
Signed-off-by: James Hogan
Cc: Mauro Carvalho Chehab
Cc: Antti Seppälä
Cc: linux-media@vger.kernel.org
---
drivers/media/rc/rc-main.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers
On 28/02/14 01:28, Rob Herring wrote:
> On Thu, Feb 27, 2014 at 4:52 PM, James Hogan wrote:
>>> v3:
>>> - Rename compatible string to "img,ir-rev1" (Rob Herring).
>>> - Specify ordering of clocks explicitly (Rob Herring).
>>
>> I'd apprec
1 - 100 of 170 matches
Mail list logo
