bruary 15, 2019 9:51:08 PM
> To: Moritz Dötterl; linux-uvc-de...@lists.berlios.de
> Cc: Linux Media Mailing List; Laurent Pinchart; Guennadi Liakhovetski
> Subject: Re: [linux-uvc-devel] metadata device file
>
> Hi Moritz,
>
> On 15/02/2019 08:45, Moritz Dötterl wrote:
> &
Hi Laurent,
On Sat, 25 Aug 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Friday, 3 August 2018 14:07:12 EEST Guennadi Liakhovetski wrote:
> > Hi Laurent,
> >
> > Thanks for the review. A general note: I think you're requesting a rather
> > detailed i
8 14:37:08 EEST Guennadi Liakhovetski wrote:
> > D4M is a mobile model from the D4XX family of Intel RealSense cameras.
> > This patch adds a descriptor for it, which enables reading per-frame
> > metadata from it.
> >
> > Signed-off-by: Guennadi Liakhovetski
> > ---
Hi Laurent,
As far as I understand we've missed the 4.19 cycle. Can we move on with
this please?
Thanks
Guennadi
On Fri, 3 Aug 2018, Guennadi Liakhovetski wrote:
> This macro defines "information about quirks," not "quirks for
> information."
>
>
This macro defines "information about quirks," not "quirks for
information."
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_driver.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c
D4M is a mobile model from the D4XX family of Intel RealSense cameras.
This patch adds a descriptor for it, which enables reading per-frame
metadata from it.
Signed-off-by: Guennadi Liakhovetski
---
Documentation/media/uapi/v4l/meta-formats.rst | 1 +
Documentation/media/uapi/v4l/pixfmt
ul 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thank you for the patch.
>
> On Saturday, 23 December 2017 13:11:00 EEST Guennadi Liakhovetski wrote:
> > From: Guennadi Liakhovetski
> >
> > D4M is a mobile model from the D4XX family of Intel RealSense camer
hart wrote:
> Hi Guennadi,
>
> Thank you for the patch.
>
> On Thursday, 26 July 2018 11:17:53 EEST Guennadi Liakhovetski wrote:
> > From: Guennadi Liakhovetski
> >
> > UVC defines a method of handling asynchronous controls, which sends a
> > USB pack
From: Guennadi Liakhovetski
UVC defines a method of handling asynchronous controls, which sends a
USB packet over the interrupt pipe. This patch implements support for
such packets by sending a control event to the user. Since this can
involve USB traffic and, therefore, scheduling, this has to
as you to make sure to
avoid rejects.
Thanks
Guennaddi
On Wed, 25 Jul 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Wednesday, 25 July 2018 20:21:54 EEST Guennadi Liakhovetski wrote:
> > On Wed, 25 Jul 2018, Laurent Pinchart wrote:
> > > On Wednesday, 1
On Wed, 25 Jul 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Wednesday, 18 July 2018 09:55:27 EEST Guennadi Liakhovetski wrote:
> > On Wed, 18 Jul 2018, Laurent Pinchart wrote:
> > > On Wednesday, 18 July 2018 00:30:45 EEST Guennadi Liakhovetski wrote:
> > &
Hi Laurent,
On Wed, 18 Jul 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Wednesday, 18 July 2018 00:30:45 EEST Guennadi Liakhovetski wrote:
> > On Tue, 17 Jul 2018, Laurent Pinchart wrote:
> > > On Thursday, 12 July 2018 10:30:46 EEST Guennadi Liakhovetski wrot
On Tue, 17 Jul 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Thursday, 12 July 2018 10:30:46 EEST Guennadi Liakhovetski wrote:
> > On Thu, 12 Jul 2018, Laurent Pinchart wrote:
> > > On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote:
> > >&
Hi Laurent,
On Thu, 12 Jul 2018, Guennadi Liakhovetski wrote:
> Hi Laurent,
>
> Thanks for the review.
[snip]
> Once I get your review of patch #3, I'll fix these two issues and
> resubmit, so you can also tell me your "minor concerns," since I'll be
>
Hi Laurent,
Thanks for the review.
On Thu, 12 Jul 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thank you for the patch.
>
> On Tuesday, 8 May 2018 18:07:43 EEST Guennadi Liakhovetski wrote:
> > UVC defines a method of handling asynchronous controls, which sends a
&g
Hi Laurent,
6.5 weeks and counting. Can we please schedule a review of these patches
for the next week? Not much time is left to make it for 4.19.
Thanks
Guennadi
On Thu, 31 May 2018, Guennadi Liakhovetski wrote:
> Hi Laurent,
>
> More than 3 weeks since v8 has been posted. Seems l
Hi Laurent,
More than 3 weeks since v8 has been posted. Seems like we've missed 4.18.
Could you please review them ASAP to make sure we merge them into 4.19?
Thanks
Guennadi
On Tue, 8 May 2018, Guennadi Liakhovetski wrote:
> Added a patch to remove a redundant check, addressed L
.
Signed-off-by: Guennadi Liakhovetski
---
v8:
* avoid losing events by delaying the status URB resubmission until
after completion of the current event
* extract control value calculation into __uvc_ctrl_get_value()
* do not proactively return EBUSY if the previous control hasn't
complete
STALL and then return the "Not ready" status
in response to a UVC_VC_REQUEST_ERROR_CODE_CONTROL command. With this
patch the user would then get an EBUSY error code instead of a
generic EPIPE.
Signed-off-by: Guennadi Liakhovetski
---
v8:
* restrict UVC_VC_REQUEST_ERROR_CODE_CONT
Event subscribers cannot have a NULL file handle. They are only added
at a single location in the code, and the .fh pointer is used without
checking there.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
Added a patch to remove a redundant check, addressed Laurent's
comments.
Guennadi Liakhovetski (3):
uvcvideo: remove a redundant check
uvcvideo: send a control event when a Control Change interrupt arrives
uvcvideo: handle control pipe protocol STALLs
drivers/media/usb/uvc/uvc_c
Hi Laurent,
One more comment-to-comment:
On Mon, 7 May 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote:
> > On Fri, 23 Mar 2018, Laurent Pinchart wrote:
> > > On Friday, 23 March 2018 11:24:00 EE
Hi Laurent,
Thanks for the replies. One follow-up question:
On Mon, 7 May 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote:
> > On Fri, 23 Mar 2018, Laurent Pinchart wrote:
> > > On Friday, 23 March 2
Hi Laurent,
On Tue, 10 Apr 2018, Guennadi Liakhovetski wrote:
[snip]
> > > @@ -1488,6 +1591,25 @@ int uvc_ctrl_set(struct uvc_video_chain *chain,
> > > return -EINVAL;
> > > if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR))
> > > r
Hi Laurent,
I've addressed those your comments, that I had no questions for, but I'm
waiting for your replies to my clarification requests to finalise and post
the next revision of the patches.
Thanks
Guennadi
On Wed, 11 Apr 2018, Guennadi Liakhovetski wrote:
> Hi Laurent,
&g
On Wed, 11 Apr 2018, Kieran Bingham wrote:
> Hi Guennadi,
>
> On 11/04/18 18:06, Guennadi Liakhovetski wrote:
>
>
>
> >>>>
> >>>> Just figured out this commit
> >>>>
> >>>> From: Edgar Thier
> >>>&g
gt; use case, and ensure that the new functionality in uvc_ctrl_get_flags()
> will only set flags based on their reported capability from the GET_INFO
> call.
>
> Fixes: 859086ae3636 ("media: uvcvideo: Apply flags from device to actual
> properties")
>
> Signed-of
Hi Kieran,
On Wed, 11 Apr 2018, Kieran Bingham wrote:
> Hi Guennadi,
>
> On 11/04/18 17:17, Kieran Bingham wrote:
> > Hi Guennadi,
> >
> > On 11/04/18 10:56, Guennadi Liakhovetski wrote:
> >> Hi Laurent,
> >>
> >> Not sure whether th
Hi Laurent,
First just answers to your questions:
On Sat, 7 Apr 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thank you for the patch.
>
> On Friday, 23 March 2018 11:24:01 EEST Laurent Pinchart wrote:
> > From: Guennadi Liakhovetski
> >
> > When a
Hi Laurent,
Not sure whether that's a kernel or a user-space problem, but UVC related
anyway. I've got a UVC 1.5 (!) Logitech camera, that used to work fine
with earlier kernels. I now installed "media 4.16" and saw, that the
kernel log was filling with messages like
uvcvideo: Failed to query
Hi Laurent,
First a couple of replies to your questions.
On Fri, 23 Mar 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thank you for the patch.
>
> On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote:
> > From: Guennadi Liakhovetski
> >
> >
urent Pinchart wrote:
> > From: Guennadi Liakhovetski
> >
> > UVC defines a method of handling asynchronous controls, which sends a
> > USB packet over the interrupt pipe. This patch implements support for
> > such packets by sending a control event to the user. Sin
The soc-camera framework is deprecated, patches for it are very rare
and only contain trivial clean up. Further I haven't got any more
soc-camera systems running modern kernels.
Signed-off-by: Guennadi Liakhovetski
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
When a command ends up in a STALL on the control pipe, use the Request
Error Code control to provide a more precise error information to the
user.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_video.c | 59 +++
1 file changed, 53
.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_ctrl.c | 166 +
drivers/media/usb/uvc/uvc_status.c | 111 ++---
drivers/media/usb/uvc/uvc_v4l2.c | 4 +-
drivers/media/usb/uvc/uvcvideo.h | 15 +++-
include/uapi/linux
This is an update of the two patches, adding asynchronous control
support to the uvcvideo driver. If a control is sent, while the camera
is still processing an earlier control, it will generate a protocol
STALL condition on the control pipe.
Thanks
Guennadi
Guennadi Liakhovetski (2):
uvcvideo
Hi Laurent,
Yes, that's correct.
Thanks
Guennadi
On Wed, 28 Feb 2018, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Wednesday, 28 February 2018 17:07:00 EET Guennadi Liakhovetski wrote:
> > Hi,
> >
> > I know the "development process and responsibiliti
Hi,
I know the "development process and responsibilities" was the main topic
during the last media summit. Unfortunately I haven't attended it, from
the etherpad notes I also cannot quite conclude what decisions have been
made. Have any measures been discussed and agreed upon for cases, when
p
Hi Kieran,
On Mon, 19 Feb 2018, Kieran Bingham wrote:
> Hi Alexandre,
>
> Thankyou for your bug report,
>
> On 17/02/18 20:47, Alexandre-Xavier Labonté-Lamoureux wrote:
> > Hi,
> >
> > I'm running Linux 4.9.0-5-amd64 on Debian. I built the drivers from
> > the latest git and installed the modu
Hi Laurent,
Any update on this?
Thanks
Guennadi
On Wed, 13 Dec 2017, Guennadi Liakhovetski wrote:
> This is an update of the two patches, adding asynchronous control
> support to the uvcvideo driver. If a control is sent, while the camera
> is still processing an earlier control
Hi Kieran,
On Fri, 12 Jan 2018, Kieran Bingham wrote:
> Newer high definition cameras, and cameras with multiple lenses such as
> the range of stereo-vision cameras now available have ever increasing
> data rates.
>
> The inclusion of a variable length packet header in URB packets mean
> that we
On Wed, 3 Jan 2018, Kieran Bingham wrote:
> From: Kieran Bingham
>
> Newer high definition cameras, and cameras with multiple lenses such as
> the range of stereovision cameras now available have ever increasing
> data rates.
>
> The inclusion of a variable length packet header in URB packets m
Hi Kieran,
Just minor suggestions below:
On Wed, 3 Jan 2018, Kieran Bingham wrote:
> From: Kieran Bingham
>
> We currently store three separate arrays for each URB reference we hold.
>
> Objectify the data needed to track URBs into a single uvc_urb structure,
> allowing better object manageme
Hi Kieran,
On Wed, 3 Jan 2018, Kieran Bingham wrote:
> From: Kieran Bingham
>
> The URB completion operation obtains the current buffer by reading
> directly into the queue internal interface.
>
> Protect this queue abstraction by providing a helper
> uvc_queue_get_current_buffer() which can b
Hi Sakari,
On Wed, 27 Dec 2017, Sakari Ailus wrote:
> Hi Guennadi,
>
> Thanks for the patch!
>
> On Sat, Dec 23, 2017 at 12:11:00PM +0100, Guennadi Liakhovetski wrote:
> > From: Guennadi Liakhovetski
> >
> > D4M is a mobile model from the D4XX family of
From: Guennadi Liakhovetski
D4M is a mobile model from the D4XX family of Intel RealSense cameras.
This patch adds a descriptor for it, which enables reading per-frame
metadata from it.
Signed-off-by: Guennadi Liakhovetski
---
Documentation/media/uapi/v4l/pixfmt-meta-d4xx.rst | 202
Sorry, forgot to mention a change from the previous version: now
autoupdate Control Change events are also delivered.
Thanks
Guennadi
On Wed, 13 Dec 2017, Guennadi Liakhovetski wrote:
> UVC defines a method of handling asynchronous controls, which sends a
> USB packet over the interrup
When a command ends up in a STALL on the control pipe, use the Request
Error Code control to provide a more precise error information to the
user.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_video.c | 59 +++
1 file changed, 53
.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_ctrl.c | 166 +
drivers/media/usb/uvc/uvc_status.c | 111 ++---
drivers/media/usb/uvc/uvc_v4l2.c | 4 +-
drivers/media/usb/uvc/uvcvideo.h | 15 +++-
include/uapi/linux
This is an update of the two patches, adding asynchronous control
support to the uvcvideo driver. If a control is sent, while the camera
is still processing an earlier control, it will generate a protocol
STALL condition on the control pipe.
Thanks
Guennadi
Guennadi Liakhovetski (2):
uvcvideo
Hi Laurent,
On Wed, 13 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 12 December 2017 10:30:39 EET Guennadi Liakhovetski wrote:
> > On Mon, 11 Dec 2017, Laurent Pinchart wrote:
> > > On Monday, 11 December 2017 23:44:09 EET Guennadi Liakhovetski wrot
Hi Laurent,
On Mon, 11 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Monday, 11 December 2017 23:44:09 EET Guennadi Liakhovetski wrote:
> > On Mon, 11 Dec 2017, Laurent Pinchart wrote:
> > > On Monday, 11 December 2017 22:16:23 EET Laurent Pinchart wrote
Hi Laurent,
Thanks for the patches. Please feel free to add either or both of
Reviewed-by: Guennadi Liakhovetski
Tested-by: Guennadi Liakhovetski
to both of the patches. Whereas in fact strictly speaking your current
tree has updated improved versions of the patches, at least of the first
Hi Laurent,
On Mon, 11 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Monday, 11 December 2017 22:16:23 EET Laurent Pinchart wrote:
> > On Wednesday, 6 December 2017 17:15:40 EET Guennadi Liakhovetski wrote:
> > > From: Guennadi Liakhovetski
> > >
>
From: Guennadi Liakhovetski
Some UVC video cameras contain metadata in their payload headers. This
patch extracts that data, adding more clock synchronisation information,
on both bulk and isochronous endpoints and makes it available to the user
space on a separate video node, using the
Hi Laurent,
While testing the new patch version, we did introduce a couple of
differences:
1. We cannot (easily) reuse .vidioc_querycap() - the metadata node uses
v4l2_fh_open() directly, so, it has a different struct file::private_data
pointer.
2. After your video device unification, the ord
On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 5 December 2017 15:44:34 EET Guennadi Liakhovetski wrote:
> > On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> > > On Tuesday, 5 December 2017 12:56:53 EET Guennadi Liakhovetski wrote:
> >
On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 5 December 2017 12:56:53 EET Guennadi Liakhovetski wrote:
> > On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> > > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote:
> > >
Hi Laurent,
Thanks for a review.
On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thank you for the patch. We're getting very close, I only have small
> comments,
> please see below.
>
> On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski
On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 5 December 2017 11:14:18 EET Guennadi Liakhovetski wrote:
> > On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> > > The function will then be used to register the video device for metadata
> >
Hi Laurent,
On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> The function will then be used to register the video device for metadata
> capture.
>
> Signed-off-by: Laurent Pinchart
> ---
> drivers/media/usb/uvc/uvc_driver.c | 66
> +++---
> drivers/media/usb/uvc/u
Hi Laurent,
On Tue, 5 Dec 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday, 5 December 2017 02:24:30 EET Laurent Pinchart wrote:
> > On Wednesday, 8 November 2017 18:00:14 EET Guennadi Liakhovetski wrote:
>
> [snip]
>
> > > +static void uvc_video
by: Mauro Carvalho Chehab
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
> ---
> drivers/media/platform/soc_camera/soc_scale_crop.c | 21 +++--
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/soc_camera/soc_scale_c
Hi Laurent,
Thanks for reviewing.
On Tue, 28 Nov 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> Thank you for the patch.
>
> On Wednesday, 8 November 2017 18:00:13 EET Guennadi Liakhovetski wrote:
> > From: Guennadi Liakhovetski
> >
> > Currently the UVC
t; On Wednesday, 8 November 2017 18:00:12 EET Guennadi Liakhovetski wrote:
> > From: Guennadi Liakhovetski
> >
> > Add a pixel format, used by the UVC driver to stream metadata.
> >
> > Signed-off-by: Guennadi Liakhovetski
> > ---
> >
> > v7: alphabet
Hi Laurent,
On Thu, 9 Nov 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Wednesday, 8 November 2017 12:43:46 EET Guennadi Liakhovetski wrote:
[snip]
> > To recall the metadata buffer layout should be
> >
> > struct uvc_meta_buf {
> >
metadata nodes for cameras,
specifying a UVC_QUIRK_METADATA_NODE quirk flag.
Signed-off-by: Guennadi Liakhovetski
---
v7: support up to two metadata formats per camera - the standard one and
an optional private one, if specified in device information
drivers/media/usb/uvc/Makefile | 2
From: Guennadi Liakhovetski
Currently the UVC driver assigns a quirk bitmask to the .driver_info
field of struct usb_device_id. This patch instroduces a struct to store
quirks and possibly other per-device parameters in the future.
Signed-off-by: Guennadi Liakhovetski
---
v7: this is a new
From: Guennadi Liakhovetski
Comments by Laurent and Hans addressed, thanks.
Regards
Guennadi
Guennadi Liakhovetski (3):
V4L: Add a UVC Metadata format
uvcvideo: add extensible device information
uvcvideo: add a metadata device node
Documentation/media/uapi/v4l/meta-formats.rst| 1
From: Guennadi Liakhovetski
Add a pixel format, used by the UVC driver to stream metadata.
Signed-off-by: Guennadi Liakhovetski
---
v7: alphabetic order, update documentation.
Documentation/media/uapi/v4l/meta-formats.rst| 1 +
Documentation/media/uapi/v4l/pixfmt-meta-uvc.rst | 50
Hi Laurent, Hans,
On Tue, 7 Nov 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Monday, 6 November 2017 16:53:10 EET Guennadi Liakhovetski wrote:
> > On Mon, 30 Oct 2017, Hans Verkuil wrote:
> > > On 07/28/2017 02:46 PM, Hans Verkuil wrote:
> > >&
Hi Hans,
Thanks for the comments.
On Mon, 30 Oct 2017, Hans Verkuil wrote:
> Hi Guennadi,
>
> On 07/28/2017 02:46 PM, Hans Verkuil wrote:
> > On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote:
> >> Add a pixel format, used by the UVC driver to stream metadata.
Hi Laurent,
On Mon, 16 Oct 2017, Laurent Pinchart wrote:
> Hi Hans,
>
> (CC'ing Guennadi Liakhovetski)
>
> Thank you for the patch.
>
> On Friday, 15 September 2017 09:27:51 EEST Hans Yang wrote:
> > For bulk-based devices, when disabling the video
metadata nodes for cameras,
specifying a UVC_QUIRK_METADATA_NODE quirk flag.
Signed-off-by: Guennadi Liakhovetski
---
v6:
- remove an unrelated uvc_ctrl.c chunk
- update comments in uvc_meta_register()
- only process metadata buffers when a metadata node is used
drivers/media/usb/uvc/Makefile
Hi Hans,
Thanks for your comment.
On Fri, 28 Jul 2017, Hans Verkuil wrote:
> On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote:
> > Some UVC video cameras contain metadata in their payload headers. This
> > patch extracts that data, adding more clock synchronisation informati
On Mon, 4 Sep 2017, Edgar Thier wrote:
> Hi Guennadi,
>
>
> > But that patch only re-reads the flags. What does that give you? Do those
> > flags change? In which way? As far as I understand the UVC Autoupdate
> > feature, a change in GET_INFO data is only one possibility, (arguably) a
> > mor
Hi Edgar,
Thanks for the explanation.
On Mon, 4 Sep 2017, Edgar Thier wrote:
> Hi Guennadi,
>
> The cameras in question are USB-3.0 industrial cameras from The Imaging
> Source.
> The ones I tested were the DFK UX250 and DFK UX264 models.
> I do not know if there are other devices that have th
Hi Edgar,
I'm adding UVC maintainer to CC, he might have missed this email. Could
you also tell us what cameras have those features? A recent patch from me
extends the UVC driver use of the Interrupt endpoint for asynchronous
control completion notifications. This would be another extension for
Hi Mauro,
On Sun, 27 Aug 2017, Mauro Carvalho Chehab wrote:
> Em Fri, 28 Jul 2017 14:45:37 +0200 (CEST)
> Guennadi Liakhovetski escreveu:
>
> > A number of functions use void * for a struct v4l2_buffer parameter.
> > Avoid that to improve compile-time checking.
>
&
On Sat, 19 Aug 2017, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
> ---
> drivers/media/i
Hi Hans,
On Fri, 28 Jul 2017, Hans Verkuil wrote:
> On 07/28/2017 02:33 PM, Guennadi Liakhovetski wrote:
[snip]
> > +/**
> > + * struct uvc_meta_buf - metadata buffer building block
> > + * @ns - system timestamp of the payload in nanoseconds
> > + *
A number of functions use void * for a struct v4l2_buffer parameter.
Avoid that to improve compile-time checking.
Signed-off-by: Guennadi Liakhovetski
---
This probably was done on purpose, maybe to reuse the video buffers by
other than V4L2 users, but I haven't found any, and the code do
According to documentation of struct vb2_ops the .queue_setup() callback
should return an error if the number of planes parameter contains an
invalid value on input. Fix this instead of ignoring the value.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_queue.c | 2 +-
1 file
metadata nodes for cameras,
specifying a UVC_QUIRK_METADATA_NODE quirk flag.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/Makefile | 2 +-
drivers/media/usb/uvc/uvc_ctrl.c | 3 +
drivers/media/usb/uvc/uvc_driver.c | 12 +++
drivers/media/usb/uvc/uvc_isight.c
The first four patches are for UVC metadata nodes, the last two patches
are for asynchronous controls and control error reporting.
Thanks
Guennadi
Guennadi Liakhovetski (6):
UVC: fix .queue_setup() to check the number of planes
V4L: Add a UVC Metadata format
uvcvideo: convert from using an
When a command ends up in a STALL on the control pipe, use the Request
Error Code control to provide a more precise error information to the
user.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_video.c | 59 +++
1 file changed, 53
Add a pixel format, used by the UVC driver to stream metadata.
Signed-off-by: Guennadi Liakhovetski
---
Documentation/media/uapi/v4l/meta-formats.rst| 1 +
Documentation/media/uapi/v4l/pixfmt-meta-uvc.rst | 39
include/uapi/linux/videodev2.h | 1
When adding support for metadata nodes, we'll have to keep video
devices registered until all metadata nodes are closed too. Since
this has nothing to do with stream counting, replace the nstreams
atomic variable with a reference counter.
Signed-off-by: Guennadi Liakhovetski
---
drivers/
.
Signed-off-by: Guennadi Liakhovetski
---
drivers/media/usb/uvc/uvc_ctrl.c | 147 +
drivers/media/usb/uvc/uvc_status.c | 112 +---
drivers/media/usb/uvc/uvc_v4l2.c | 4 +-
drivers/media/usb/uvc/uvcvideo.h | 14 +++-
include/uapi/linux
Hi Laurent,
On Fri, 28 Jul 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Tuesday 25 Jul 2017 15:27:24 Guennadi Liakhovetski wrote:
> > On Fri, 21 Jul 2017, Laurent Pinchart wrote:
> > > Hi Guennadi,
> > >
> > > Thank you for the patch.
&g
On Tue, 25 Jul 2017, Guennadi Liakhovetski wrote:
[snip]
> > > +struct uvc_meta_buf {
> > > + struct timespec ts;
> >
> > timespec has a different size on 32-bit and 64-bit architectures, so there
> > could be issues on 32-bit userspace running on a 64-bit
rmat :-S
Uhm, add a black list of offending vendors and drop 60% of their frames?
;-)
> > This version of the patch only creates such metadata nodes for cameras,
> > specifying a UVC_QUIRK_METADATA_NODE quirk flag.
> >
> > Signed-off-by: Guennadi Liakhovetski
> >
metadata nodes for cameras,
specifying a UVC_QUIRK_METADATA_NODE quirk flag.
Signed-off-by: Guennadi Liakhovetski
---
v4:
- add support for isochronous cameras. Metadata is now collected from as
many payloads as they fit in the buffer
- add a USB Start Of Frame and a system timestamp to each
On Mon, 13 Mar 2017, Hans Verkuil wrote:
> On 03/12/2017 01:06 PM, Guennadi Liakhovetski wrote:
> > Hi Laurent,
> >
> > Thanks for the patch. I just checked in the current media/master, there
> > are still 2 users of vb1: sh_mobile_ceu_camera.c and atmel-isi.c. I
&g
Hi Mauro,
The following changes since commit 700ea5e0e0dd70420a04e703ff264cc133834cba:
Merge tag 'v4.11-rc1' into patchwork (2017-03-06 06:49:34 -0300)
are available in the git repository at:
git://linuxtv.org/gliakhovetski/v4l-dvb.git for-4.12-1
for you to fetch changes up to c259da29a447
Hi Hans,
Thanks for the patch. Why hasn't this patch been CCed to Josh Wu? Is he
still at Atmel? Adding to CC to check.
A general comment: this patch doesn't only remove soc-camera dependencies,
it also changes the code and the behaviour. I would prefer to break that
down in multiple patches,
esn't break anything. I understand, this patch should better go in as a
part of a series, so
Acked-by: Guennadi Liakhovetski
Thanks
Guennadi
> ---
> drivers/media/i2c/soc_camera/ov2640.c | 23 +++
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> diff --
Hi Laurent,
Thanks for the patch. I just checked in the current media/master, there
are still 2 users of vb1: sh_mobile_ceu_camera.c and atmel-isi.c. I
understand, that they are about to be removed either completely or out of
soc-camera, maybe patches for that have already beed submitted, but t
a bug, which is fixed by this patch.
Signed-off-by: Koji Matsuoka
Signed-off-by: Yoshihiro Kaneko
[g.liakhovet...@gmx.de: dropped supposedly wrong hunks]
Signed-off-by: Guennadi Liakhovetski
---
v2: fix a silly typo, reported by Laurent, thanks! Also renamed the
function, according to his
On Mon, 27 Feb 2017, Laurent Pinchart wrote:
> Hi Guennadi,
>
> On Monday 27 Feb 2017 09:54:19 Guennadi Liakhovetski wrote:
> > On Mon, 27 Feb 2017, Laurent Pinchart wrote:
> > > On Sunday 26 Feb 2017 21:58:16 Guennadi Liakhovetski wrote:
> > >> From: Koji Mat
1 - 100 of 2736 matches
Mail list logo
