On Fri, 26 Aug 2011 00:11:15 +0200
Florian Mickler wrote:
> In my previous change to this driver, I was not aware, that
> dvb_usb_device_init
> calls the frontend_attach routine which needs a transfer
> buffer. So we can not setup anything private in the probe routine beforehand
;t have any overview about the hardware supported by this
driver.
Maybe Patrick has any opinion on this, he wrote this driver after all :)
Regards,
Flo
>8--->8>8->8>8-------
commit fdcb46dd3627683fc82d14488af10d3072e923f5
Author: Flori
buffer mutex to serialize that buffer but instead need to use the
dvb_usb_device's usb_mutex.
Fixes: https://bugzilla.novell.com/show_bug.cgi?id=709440
Tested-by: Markus Stephan
Signed-off-by: Florian Mickler
---
So, someone who could test that driver found me after all.
I renamed the functio
On Wed, 10 Aug 2011 12:05:20 +0200
Florian Mickler wrote:
> dvb_usb_device_init calls the frontend_attach method of this driver which
> uses vp7045_usb_ob. In order to have a buffer ready in vp7045_usb_op, it has
> to
> be allocated before that happens.
>
> Luckily we can use
: Tino Keitel
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp7045.c | 26 --
1 files changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp7045.c
b/drivers/media/dvb/dvb-usb/vp7045.c
index 3db89e3..536c16c 100644
--- a/drivers
To the best of my knowledge, you did. I cc'd Patrick and Olivier who are
involved
with dib ...
On Sun, 10 Jul 2011 09:22:05 +0200
cedric.dew...@telfort.nl wrote:
>
> >-- Oorspronkelijk bericht --
> >Date: Fri, 24 Jun 2011 11:01:37 +0200
> >From: cedric.dew...@telfort.nl
> >To: linux-...@l
On Mon, 11 Jul 2011 12:23:28 +0100
David Waring wrote:
> I'm currently using 3 of these USB sticks on a PC with the videolan.org
> dvblast program to multicast the UK Freeview DVB-T muxes on our local
> network. I'm also using a PCTV nanostick 290e to multicast the DVB-T2
> mux too.
>
> I'm havi
On Thu, 4 Aug 2011 13:29:42 +0300
Dan Carpenter wrote:
> On Thu, Aug 04, 2011 at 12:21:29PM +0200, Florian Mickler wrote:
> > Mauro, what to do?
>
> Apply the fix which Tino tested, perhaps? :P (obviously).
>
> The bug is present in 3.0 so it should be tagged for stable
Hi,
On Wed, 3 Aug 2011 09:39:46 +0200 (CEST)
Patrick Boettcher wrote:
> Hi Florian,
>
>
> I'm not sure whether I still have exactly this box. There were two
> versions and I got rid of at least one of them.
>
> I moved recently into a new house and right now a lot of things are hidden
> in
mutex to serialize that buffer but instead need to use the
dvb_usb_device's usb_mutex.
Note: Compile tested only!
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x-fe.c | 30 -
drivers/media/dvb/dvb-usb/vp702x.c| 220 ++---
drivers/
Hi Mauro! Hi Patrick!
I realized this morning, that I broke vp702x (if it was working before)
with my last patchseries. Sorry. :(
I'm gonna follow up on this mail with a patch to hopefully fix it, but
if nobody can test it, I'd say to rather revert my patchseries
for v3.1 . It will then still use
On Sat, 30 Apr 2011 19:30:52 -0300
Mauro Carvalho Chehab wrote:
> Hi Florian,
>
> Em 30-04-2011 15:54, Florian Mickler escreveu:
> > Hi Mauro!
> >
> > I just saw that you picked up some patches of mine. What about these?
> > These are actually tested...
>
Hi Mauro!
I just saw that you picked up some patches of mine. What about these?
These are actually tested...
Regards,
Flo
On Sun, 20 Mar 2011 22:50:47 +0100
Florian Mickler wrote:
> Hi Mauro!
>
> These are the patches which got tested already and
> should be good to go. [fi
On Fri, 29 Apr 2011 18:32:34 -0300
Mauro Carvalho Chehab wrote:
> As it is a trivial fix, I'll be picking it directly.
Zdenek reported in the bug that it doesn't fix all instances of the
warning.
Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body
On Mon, 4 Apr 2011 09:42:04 +0200 (CEST)
Patrick Boettcher wrote:
> Hi Florian,
>
> For this one we implemented an alternative. See here:
>
> http://git.linuxtv.org/pb/media_tree.git?a=commit;h=16b54de2d8b46e48c5c8bdf9b350eac04e8f6b46
>
> which I pushed, but obviously forgot to send the pull-
he pull-request.
>
> This is done now.
Thanks for the information. I see there is a CC: Florian Mickler in
there, but I didn't get any email... maybe something wrong on your
side?
It helps a lot with closing bug reports in the bugzilla, if people add a
reference to the bugreport - if there is
This variable is never used.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/dib0700_core.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c
b/drivers/media/dvb/dvb-usb/dib0700_core.c
index ca80520..7f6f023 100644
change is tested to compile only, as I don't have the hardware.
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
Reported-by: Zdenek Kabelac
Signed-off-by: Florian Mickler
---
[v2: use preallocated buffer; fix sizeof in one case]
[v3: use seperate kmalloc mapping fo
This patch to dib0700 is a fix for a warning seen and reported by Zdenek
Kabalec in Bug #15977 [4].
Florian Mickler (2):
[media] dib0700: get rid of on-stack dma buffers
[media] dib0700: remove unused variable
Regards,
Flo
References:
[1]: http://www.spinics.net/lists/linux-media/msg30448
2011/3/22 Roedel, Joerg :
> On Mon, Mar 21, 2011 at 05:03:15PM -0400, Florian Mickler wrote:
>> I guess (not verified), that the dma api takes sufficient precautions
>> to abort the dma transfer if a timeout happens. So freeing _should_
>> not be an issue. (At least, I
2011/3/22 James Bottomley :
> On Mon, 2011-03-21 at 22:03 +0100, Florian Mickler wrote:
>> On Mon, 21 Mar 2011 15:26:43 -0400
>> Andy Walls wrote:
>>
>> > Florian Mickler wrote:
>>
>> To be blunt, I'm not shure I fully understand the requirements
On Mon, 21 Mar 2011 15:26:43 -0400
Andy Walls wrote:
> Florian Mickler wrote:
>
> >Hi all!
> >
> >These patches get rid of on-stack dma buffers for some of the dvb-usb
> >drivers.
> >I do not own the hardware, so these are only compile tested. I wou
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
[v2: pulled buffer access under the mutex]
drivers/media/dvb/dvb-usb/vp7045.c | 47 ++--
1 files changed, 34 insertions(+), 13 deletions(-)
diff --git a/dr
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/m920x.c | 33 ++---
1 files changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/m920x.c
b/drivers/media/dv
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/opera1.c | 31 ---
1 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/opera1.c
b/drivers/media/dv
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/friio.c | 23 +++
1 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/friio.c
b/drivers/media/dvb/dv
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/dw2102.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/dw2102.c
b/drivers/media/dvb/dvb-usb/dw2102.c
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/a800.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/a800.c b/drivers/media/dvb/dvb-usb/a800.c
ck
on vp702x.
Please review and test.
Regards,
Flo
Florian Mickler (6):
[media] a800: get rid of on-stack dma buffers
[media v2] vp7045: get rid of on-stack dma buffers
[media] friio: get rid of on-stack dma buffers
[media] dw2102: get rid of on-stack dma buffer
[media] m920x: get rid
struct vp702x_device_state.power_state is nowhere referenced.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x.h
b/drivers/media/dvb/dvb-usb/vp702x.h
index 86960c6
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x-fe.c | 89 +++--
drivers/media/dvb/dvb-usb/vp702x.c| 78 ++--
2 files changed, 124 insertions(+
If we need a bigger buffer, we reallocte a new buffer and free the old
one.
Note: This change is tested to compile only as I don't have the
hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.c | 23 +++
1 files changed, 19 insertions(
Note: This change is tested to compile only as I don't have the
hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.c | 59 +--
1 files changed, 35 insertions(+), 24 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x
Note: This change is tested to compile only as I don't have the
hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x-fe.c | 69 +
1 files changed, 35 insertions(+), 34 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x-fe
Otherwise it is not obvious that vp702x_usb_in_op or vp702x_usb_out_op
will not interfere with any vp702x_usb_inout_op.
Note: This change is tested to compile only, as I don't have the
hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.c |
We need a state struct for the dvb_usb_device.
In order to reduce confusion we rename the vp702x_state struct.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x.c
Some whitespace, one linebreak and one unneded variable
initialization...
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.c | 23 ---
1 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp702x.c
b/drivers/media
This sets up a buffer and a mutex protecting that buffer in
the struct vp702x_device_state.
The definition of struct vp702x_device_state is moved into the header
in order to use the buffer also in the frontend.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp702x.c | 41
, dw2102, friio,
a800 which I did not modify since my first patch submission.
Regards,
Flo
Florian Mickler (9):
[media] vp702x: cleanup: whitespace and indentation
[media] vp702x: rename struct vp702x_state -> vp702x_adapter_state
[media] vp702x: preallocate memory on device probe
[med
-by: Florian Mickler
Acked-by: Antti Palosaari
Reviewed-by: Antti Palosaari
Tested-by: Antti Palosaari
---
drivers/media/dvb/dvb-usb/au6610.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/au6610.c
b/drivers/media/dvb/dvb
-by: Florian Mickler
Acked-by: Antti Palosaari
Reviewed-by: Antti Palosaari
Tested-by: Antti Palosaari
---
drivers/media/dvb/dvb-usb/ec168.c | 18 +++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/ec168.c
b/drivers/media/dvb/dvb-usb
batch are the patches to opera1, m920x, dw2102, friio,
a800 which I left as is, for the time beeing.
Regards,
Flo
Florian Mickler (5):
[media] ec168: get rid of on-stack dma buffers
[media] ce6230: get rid of on-stack dma buffer
[media] au6610: get rid of on-stack dma buffer
[media] lmedm04
: Malcolm Priestley
Signed-off-by: Florian Mickler
---
[v2: fix use after free as noted by Malcom]
drivers/media/dvb/dvb-usb/lmedm04.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c
b/drivers/media/dvb/dvb-usb
-by: Florian Mickler
Acked-by: Antti Palosaari
Reviewed-by: Antti Palosaari
Tested-by: Antti Palosaari
---
drivers/media/dvb/dvb-usb/ce6230.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/ce6230.c
b/drivers/media/dvb/dvb-usb/ce6230.c
This should not change anything except whitespace.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/lmedm04.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c
b/drivers/media/dvb/dvb-usb/lmedm04.c
index
On Fri, 18 Mar 2011 18:36:53 +0200
Antti Palosaari wrote:
> On 03/15/2011 10:43 AM, Florian Mickler wrote:
> > usb_control_msg initiates (and waits for completion of) a dma transfer using
> > the supplied buffer. That buffer thus has to be seperately allocated on
> > the
On Fri, 18 Mar 2011 18:36:11 +0200
Antti Palosaari wrote:
> On 03/15/2011 10:43 AM, Florian Mickler wrote:
> > usb_control_msg initiates (and waits for completion of) a dma transfer using
> > the supplied buffer. That buffer thus has to be seperately allocated on
> > the
On Fri, 18 Mar 2011 18:34:58 +0200
Antti Palosaari wrote:
> On 03/15/2011 10:43 AM, Florian Mickler wrote:
> > usb_control_msg initiates (and waits for completion of) a dma transfer using
> > the supplied buffer. That buffer thus has to be seperately allocated on
> > the
On Tue, 15 Mar 2011 20:54:43 +
Malcolm Priestley wrote:
> The patch failed for the following reason.
>
> On Tue, 2011-03-15 at 09:43 +0100, Florian Mickler wrote:
> > usb_control_msg initiates (and waits for completion of) a dma transfer using
> > the supplied buffer.
On Tue, 15 Mar 2011 09:02:00 -0300
Mauro Carvalho Chehab wrote:
>
> You're allocating a buffer for URB control messages. IMO, this is a good
> idea, as
> this way, allocating/freeing on each urb call is avoided. However, on most
> places,
> you're not using it. The better would be to just use t
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/lmedm04.c | 16 +---
1 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c
b/drivers/media/dvb/dvb-usb/lmed
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/vp7045.c | 41 ++-
1 files changed, 30 insertions(+), 11 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/vp7045.c
b/drivers/medi
change is tested to compile only, as I don't have the hardware.
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
Reported-by: Zdenek Kabelac
Signed-off-by: Florian Mickler
[v2: use preallocated buffer; fix sizeof in one case]
[v3: use seperate kmalloc mapping for the prealloc
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/a800.c | 17 +
1 files changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/a800.c b/drivers/media/dvb/dvb-usb/a800.c
This should not change anything except whitespace.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/lmedm04.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c
b/drivers/media/dvb/dvb-usb/lmedm04.c
index
This variable is never used.
Signed-off-by: Florian Mickler
--
drivers/media/dvb/dvb-usb/dib0700_core.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
---
drivers/media/dvb/dvb-usb/dib0700_core.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/ec168.c | 18 +++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/ec168.c
b/drivers/media/dvb/dvb-usb/ec
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/ce6230.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/ce6230.c
b/drivers/media/dvb/dvb-usb/ce6230.c
change is tested to compile only, as I don't have the hardware.
Signed-off-by: Florian Mickler
---
drivers/media/dvb/dvb-usb/friio.c | 23 +++
1 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/media/dvb/dvb-usb/friio.c
b/drivers/media/dvb/dv
On Sun, 6 Mar 2011 18:57:13 +0100
Florian Mickler wrote:
> On Sun, 6 Mar 2011 18:47:56 +0100
> Florian Mickler wrote:
>
>
> > +static void dib0700_disconnect(struct usb_interface *intf) {
>
>
> That { should go on its own line... sorry ;-)
>
> If that
On Sun, 6 Mar 2011 18:47:56 +0100
Florian Mickler wrote:
> +static void dib0700_disconnect(struct usb_interface *intf) {
That { should go on its own line... sorry ;-)
If that patch is acceptable, I can resend with that fixed.
Regards,
Flo
--
To unsubscribe from this list: send the l
Signed-off-by: Florian Mickler
CC: linux-media@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: Greg Kroah-Hartman
CC: Rafael J. Wysocki
CC: Maciej Rutecki
CC: Oliver Neukum
---
drivers/media/dvb/dvb-usb/dib0700_core.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff
This should fix warnings seen by some:
WARNING: at lib/dma-debug.c:866 check_for_stack
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
Reported-by: Zdenek Kabelac
Signed-off-by: Florian Mickler
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
CC: linux-ker
On Sun, 6 Mar 2011 16:06:38 +0100
Oliver Neukum wrote:
> Am Sonntag, 6. März 2011, 15:38:05 schrieb Florian Mickler:
> > On Sun, 6 Mar 2011 13:06:09 +0100
> > Oliver Neukum wrote:
> >
> > > Am Sonntag, 6. März 2011, 12:16:52 schrieb Florian Mickler:
>
> >
Signed-off-by: Florian Mickler
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: Greg Kroah-Hartman
CC: Rafael J. Wysocki
CC: Maciej Rutecki
CC: Oliver Neukum
CC: Jack Stone
---
drivers/media/dvb/dvb-usb/dib0700_core.c | 13 ++---
1
Signed-off-by: Florian Mickler
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: Greg Kroah-Hartman
CC: Rafael J. Wysocki
CC: Maciej Rutecki
CC: Oliver Neukum
CC: Jack Stone
---
drivers/media/dvb/dvb-usb/dib0700_core.c |2 --
1 files changed
This should fix warnings seen by some:
WARNING: at lib/dma-debug.c:866 check_for_stack
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
Reported-by: Zdenek Kabelac
Signed-off-by: Florian Mickler
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
CC: linux-ker
On Sun, 6 Mar 2011 13:06:09 +0100
Oliver Neukum wrote:
> Am Sonntag, 6. März 2011, 12:16:52 schrieb Florian Mickler:
> > This should fix warnings seen by some:
> > WARNING: at lib/dma-debug.c:866 check_for_stack
> >
> > Fixes: https://bugzilla.kernel.org/show_bug
On Sun, 06 Mar 2011 13:49:56 +
Jack Stone wrote:
> On 06/03/2011 11:16, Florian Mickler wrote:
> > This should fix warnings seen by some:
> > WARNING: at lib/dma-debug.c:866 check_for_stack
> >
> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
>
This should fix warnings seen by some:
WARNING: at lib/dma-debug.c:866 check_for_stack
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=15977.
Reported-by: Zdenek Kabelac
Signed-off-by: Florian Mickler
CC: Mauro Carvalho Chehab
CC: linux-media@vger.kernel.org
CC: linux-ker
70 matches
Mail list logo
