Attendees for this session:
>
> Nicolas Dufresne
> Tomasz Figa
> Ezequiel Garcia
> Dafna Hirschfeld
I beliebe Dafna and I should not be on this list, and instead
Helen Koike and Nicolas Dufresne would be attending.
Thanks,
Ezequiel
> Eugen Hristev
> Jacopo Mondi
> Laurent Pi
(char)((fmt->pixelformat >> 8) & 0x7f),
> - (char)((fmt->pixelformat >> 16) & 0x7f),
> - (char)((fmt->pixelformat >> 24) & 0x7f),
> - (fmt->pixelformat & (1UL << 31)) ?
> "-BE" : "");
> + snprintf(fmt->description, sz, v4l2_fourcc_conv,
> + v4l2_fourcc_args(fmt->pixelformat));
> break;
> }
> }
Nice cleanup!
I think these are the only media drivers that would have to be converted,
in case anyone wants to tackle this.
drivers/media/common/saa7146/saa7146_video.c: vv->ov_fmt->pixelformat,
v4l2_field_names[vv->ov.win.field]);
drivers/media/platform/atmel/atmel-isc-base.c: (char
*)&pixfmt->pixelformat, (char *)&sd_fmt->fourcc);
drivers/media/platform/sti/delta/delta-debug.c: (char
*)&f->pixelformat, f->width, f->height,
drivers/media/platform/vsp1/vsp1_drm.c: cfg->pixelformat, cfg->pitch,
&cfg->mem[0], &cfg->mem[1],
Reviewed-by: Ezequiel Garcia
Thanks,
Ezequiel
side-effects.
> + */
> +#define v4l2_fourcc_args(fourcc) \
> + (fourcc) & 0x7f, ((fourcc) >> 8) & 0x7f, ((fourcc) >> 16) & 0x7f, \
> + ((fourcc) >> 24) & 0x7f, ((fourcc) & (1 << 31) ? "-BE" : "")
> +
> /*
> * E N U M S
> */
Reviewed-by: Ezequiel Garcia
Thanks,
Ezequiel
On Thu, 2019-09-12 at 14:52 +0900, Tomasz Figa wrote:
> On Thu, Sep 12, 2019 at 4:49 AM Nicolas Dufresne wrote:
> > Le mercredi 11 septembre 2019 à 09:27 +0100, Ezequiel Garcia a écrit :
> > > On Mon, 2019-09-09 at 16:07 +0900, Tomasz Figa wrote:
> > > > Hi Ezequiel
Hello Niklas,
On Thu, 2019-09-05 at 23:25 +0200, Niklas Söderlund wrote:
> The image size is doubled for NV16 and is calculated as bytesperline *
> height * 2 to accommodate the split of UV data. When writing the offset
> to hardware width is used instead of bytesperline, fix this.
>
> Signed-off
On Mon, 2019-09-09 at 13:03 +0200, Hans Verkuil wrote:
> On 9/3/19 8:17 PM, Ezequiel Garcia wrote:
> > The Hantro G1 decoder is able to enable a post-processor
> > on the decoding pipeline, which can be used to perform
> > scaling and color conversion.
> >
> > Th
On Mon, 2019-09-09 at 16:07 +0900, Tomasz Figa wrote:
> Hi Ezequiel,
>
> On Wed, Sep 4, 2019 at 3:17 AM Ezequiel Garcia wrote:
> > Hi all,
> >
> > This series enables the post-processor support available
> > on the Hantro G1 VPU. The post-processor block can
On Wed, 2019-09-04 at 12:17 +0200, Philipp Zabel wrote:
> On Tue, 2019-09-03 at 15:17 -0300, Ezequiel Garcia wrote:
> > Introduce a helper to allow easier enablement of the post-processing
> > feature. No functional changes intended.
> >
> > Signed-off-by: Ezequiel G
them.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/Makefile | 1 +
drivers/staging/media/hantro/hantro.h | 23 +-
drivers/staging/media/hantro/hantro_drv.c | 24 +-
.../staging/media/hantro/hantro_g1_h264_dec.c | 2 +-
.../media/hantro/hantro_g1_mpeg2_
and YUV-packed surfaces.
Thanks,
Ezequiel
Ezequiel Garcia (4):
media: hantro: Simplify macroblock macros
media: hantro: Simplify buffer helpers
media: hantro: Add helper for the H264 motion vectors allocation
media: hantro: Support color conversion via post-processing
drivers/staging/media/
Modify hantro_get_ref() and hantro_h264_get_ref_buf() helpers
to return the buffer DMA address, this makes the code simpler
and at the same time will allow easier enablement of the
post-processing feature.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro.h | 2
Introduce a helper to allow easier enablement of the post-processing
feature. No functional changes intended.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro.h | 6 ++
drivers/staging/media/hantro/hantro_v4l2.c | 4 ++--
2 files changed, 8 insertions(+), 2
It seems all codecs are using a 16x16 size macroblock,
and so it's possible to have just one set of macroblock macros.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro.h | 18 +++---
.../staging/media/hantro/hantro_g1_h264_dec.c | 2 +-
.../st
On Mon, 2019-08-19 at 09:44 +0200, Hans Verkuil wrote:
> On 8/16/19 10:06 AM, Hans Verkuil wrote:
> > Rather then discussing topics for a meeting under the subject 'Lisbon'
> > let's start a new thread referring to the right place :-)
> >
> > I will try to organize a room, either during the ELCE o
Update Jacob's address and add myself as co-maintainer.
Signed-off-by: Ezequiel Garcia
---
Note that I have a few minor changes in mind for this driver,
but frst, I'll need to fix whatever is wrong with gstreamer
not probing it anymore.
MAINTAINERS | 3 ++-
1 file changed, 2 insert
: Ezequiel Garcia
---
Changes v2:
* None.
---
drivers/media/v4l2-core/Kconfig | 5 +
drivers/media/v4l2-core/Makefile | 1 +
drivers/media/v4l2-core/v4l2-common.c | 145 -
drivers/media/v4l2-core/v4l2-i2c.c| 147 ++
include/media/v4l2
prepared
for a NULL result.
Signed-off-by: Ezequiel Garcia
---
Changes v2:
* New patch.
---
drivers/media/v4l2-core/v4l2-i2c.c | 3 ++-
drivers/media/v4l2-core/v4l2-spi.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-i2c.c
b/drivers/media
#x27;m not addressing that in this series.
The entire series should not affect any functionality,
but just clean-up the code a bit.
Thanks,
Eze
Ezequiel Garcia (6):
media: v4l2-core: Module re-organization
media: v4l2-core: move spi helpers out of v4l2-common.c
media: v4l2-core: move i2c helpers o
Introduce a new video4linux2 spi helper, to unregister a subdev.
This allows to get rid of some more ifdefs.
Signed-off-by: Ezequiel Garcia
---
Changes v2:
* None.
---
drivers/media/v4l2-core/v4l2-device.c | 14 ++
drivers/media/v4l2-core/v4l2-spi.c| 8
include/media
Introduce a new video4linux2 i2c helper, to unregister a subdev.
This allows to get rid of yet another ifdef.
Signed-off-by: Ezequiel Garcia
---
Changes v2:
* None.
---
drivers/media/v4l2-core/v4l2-device.c | 25 ++---
drivers/media/v4l2-core/v4l2-i2c.c| 20
Separate the spi helpers to v4l2-spi.c, in order to get rid
of the ifdefery. No functional changes intended, this is
just a cosmetic change to organize the code better.
Signed-off-by: Ezequiel Garcia
---
Changes v2:
* None.
---
drivers/media/v4l2-core/Makefile | 1 +
drivers/media/v4l2
s y/m/n.
This commit makes v4l2-common part of our V4L2 core driver (videodev.ko).
Signed-off-by: Ezequiel Garcia
---
Changes v2:
* Fix MODULE_xxx macros, combining all the authors
and amending the description.
---
drivers/media/v4l2-core/Makefile | 3 +--
drivers/media/v4l2-core/v4l2-com
th this commit the sensor is able to enter LP-11 mode during power up,
as expected by some CSI-2 controllers.
Many thanks to Fabio Estevam for his help debugging this issue.
Tested-by: Fabio Estevam
Signed-off-by: Ezequiel Garcia
Reviewed-by: Philipp Zabel
Reviewed-by: Jacopo Mondi
---
Hi Sakari,
Thanks for reviewing the patch.
On Wed, 2019-08-07 at 15:06 +0300, Sakari Ailus wrote:
> On Tue, Jul 30, 2019 at 05:14:24AM -0300, Ezequiel Garcia wrote:
> > Hey Hans,
> >
> > On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote:
> > > On Thu, 20
Hi Hans, Sakari,
On Wed, 2019-07-10 at 15:40 -0300, Ezequiel Garcia wrote:
> This is mostly a port of Jacopo's fix:
>
> commit aa4bb8b8838ffcc776a79f49a4d7476b82405349
> Author: Jacopo Mondi
> Date: Fri Jul 6 05:51:52 2018 -0400
>
> media: ov5640: Re-
Hey Hans,
On Mon, 2019-07-01 at 08:48 +0200, Philipp Zabel wrote:
> On Thu, 2019-06-27 at 19:29 -0300, Fabio Estevam wrote:
> > From: Ezequiel Garcia
> >
> > Not all sensors will be able to guarantee a proper initial state.
> > This may be either because the dri
Hi Mark,
On Fri, 26 Jul 2019 at 17:41, Mark Balantzyan wrote:
>
> Signed-off-by: Mark Balantzyan
> Reported-by: kbuild test robot
> ---
> This patch adds a custom function for releasing the video device for the
> tw686x video device driver.
>
> drivers/media/pci/tw686x/tw686x-video.c | 23 +++
Hi Mark,
On Wed, 24 Jul 2019 at 09:25, Mark Balançian wrote:
>
> Hi Ezequiel,
>
> (sorry didn't include linux-media in first email)
> I'm not sure yet if I have my supervisor's permission to declare our
> tool as open source, but I'll tell you the possible code paths that I
> think may be leading
Hi Hans,
On Wed, 24 Jul 2019 at 10:08, Hans Verkuil wrote:
>
> On 7/24/19 2:25 PM, Mark Balançian wrote:
> > Hi Ezequiel,
> >
> > (sorry didn't include linux-media in first email)
> > I'm not sure yet if I have my supervisor's permission to declare our
> > tool as open source, but I'll tell you t
at it uses the "visible" syntax to hide
the menus.
This is not obvious and it normally takes some time to
figure out.
To fix the problem, add a comment on each of hidden menus,
which should clarify what option is causing menus to be hidden.
Signed-off-by: Ezequiel Garcia
---
d
On Fri, 2019-07-26 at 09:30 +0200, Boris Brezillon wrote:
> On Fri, 26 Jul 2019 08:28:28 +0200
> Boris Brezillon wrote:
>
> > On Thu, 25 Jul 2019 23:39:11 -0300
> > Ezequiel Garcia wrote:
> >
> > > On Thu, 2019-07-25 at 21:36 +0200, Paul Kocialkowski wrot
On Thu, 2019-07-25 at 23:09 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 25 Jul 2019 20:55:13 -0300
> Ezequiel Garcia escreveu:
>
> > On Thu, 2019-07-25 at 15:41 -0300, Mauro Carvalho Chehab wrote:
> > > Em Fri, 26 Jul 2019 01:29:58 +0800
> > > Chen-Yu Tsai
On Thu, 2019-07-25 at 23:09 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 25 Jul 2019 20:55:13 -0300
> Ezequiel Garcia escreveu:
>
> > On Thu, 2019-07-25 at 15:41 -0300, Mauro Carvalho Chehab wrote:
> > > Em Fri, 26 Jul 2019 01:29:58 +0800
> > > Chen-Yu Tsai
On Thu, 2019-07-25 at 21:36 +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Thu 25 Jul 19, 08:42, Boris Brezillon wrote:
> > On Fri, 5 Jul 2019 19:16:18 +0200
> > Boris Brezillon wrote:
> >
> > > On Fri, 05 Jul 2019 13:40:03 -0300
> > > Ezequiel
On Thu, 2019-07-25 at 15:41 -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 26 Jul 2019 01:29:58 +0800
> Chen-Yu Tsai escreveu:
>
> > On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia
> > wrote:
> > > On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote:
On Thu, 2019-07-25 at 14:03 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 25 Jul 2019 13:41:34 -0300
> Ezequiel Garcia escreveu:
>
> > On Thu, 2019-07-25 at 13:31 -0300, Mauro Carvalho Chehab wrote:
> > > Em Mon, 15 Jul 2019 18:06:43 -0300
> &g
On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 15 Jul 2019 18:23:16 -0300
> Ezequiel Garcia escreveu:
>
> > Many users have been complaining about not being able to find
> > certain menu options. One such example are camera sensor drivers
> &g
On Thu, 2019-07-25 at 13:31 -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 15 Jul 2019 18:06:43 -0300
> Ezequiel Garcia escreveu:
>
> > videodev.ko and v4l2-common.ko driver are built under
> > the same conditions. Therefore, it doesn't make much sense
> > to spl
Hi Mark,
On Wed, 24 Jul 2019 at 12:10, Mark Balantzyan wrote:
>
This commit needs to be thoroughly explained in order to make sense.
> Signed-off-by: Mark Balantzyan
> ---
> This patch adds a custom function to release video device in assignment to
> vdev->release member in tw686x driver.
>
>
On Tue, 23 Jul 2019 at 12:55, Mark Balançian wrote:
>
> On Jul 23, 2019, at 8:17 AM, Ezequiel Garcia
> wrote:
>
>
> On Tue, 23 Jul 2019 at 12:02, Mark Balançian wrote:
>
>
> I see. I guess then my issue would be help in seeing how
> tw686x_memcpy_dma_free alo
On Tue, 23 Jul 2019 at 12:02, Mark Balançian wrote:
>
> I see. I guess then my issue would be help in seeing how
> tw686x_memcpy_dma_free alone does any required interrupt handling, since
> there are also functions tw686x_irq and tw686x_audio_irq for interrupt
> handling as well? However, in my
Hey Mark,
I'm glad you are having fun with the driver.
On Tue, 23 Jul 2019 at 11:45, Mark Balançian wrote:
>
> Hello all,
>
> My name is Mark and I am working on contributing to the open-source Linux
> project.
>
> I would please like to know more about the TW686X driver. In particular, when
>
rlace driver in this respect, and that
> v4l2_fh conversion has been properly tested.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Ezequiel Garcia
On Wed, 2019-07-17 at 15:29 +0200, Hans Verkuil wrote:
> This driver is one of the few that is still not using struct
> v4l2_fh. Convert it.
>
> Tested on a Pandaboard.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Ezequiel Garcia
>
> .vidioc_streamon= vidioc_streamon,
> - .vidioc_streamoff = vidioc_streamoff,
> + .vidioc_streamoff = v4l2_m2m_ioctl_streamoff,
> };
>
>
> @@ -831,7 +794,7 @@ static void deinterlace_buf_queue(struct vb2_buffer *vb)
> struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb);
> struct deinterlace_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue);
>
> - v4l2_m2m_buf_queue(ctx->m2m_ctx, vbuf);
> + v4l2_m2m_buf_queue(ctx->fh.m2m_ctx, vbuf);
> }
>
> static const struct vb2_ops deinterlace_qops = {
> @@ -849,7 +812,7 @@ static int queue_init(void *priv, struct vb2_queue
> *src_vq,
> int ret;
>
> src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
> - src_vq->io_modes = VB2_MMAP | VB2_USERPTR;
> + src_vq->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF;
For this and the other patches: is this change related to v4l2_fh usage?
In any case,
Reviewed-by: Ezequiel Garcia
On Wed, 2019-07-17 at 11:03 +0200, Hans Verkuil wrote:
> Modern V4L2 drivers should use struct v4l2_fh to represent a filehandle.
> This driver was one of the few that didn't use it.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Ezequiel Garcia
> ---
> drivers/media/pla
Currently, the v4l2 control code is a bit silent on errors.
Add debug messages on (hopefully) most of the error paths.
Signed-off-by: Ezequiel Garcia
---
Changes from v3:
* Add missing parenthesis around macro argument.
Changes from v3:
* Fix checkpatch.pl warnings about long lines.
Changes
On Sat, 2019-07-20 at 11:36 +0200, Hans Verkuil wrote:
> On 7/19/19 11:53 PM, Ezequiel Garcia wrote:
> > On Thu, 2019-06-27 at 09:38 +0200, Hans Verkuil wrote:
> > > Hi Ezequiel,
> > >
> > > 'checkpatch.pl --strict' finds way too many issues.
>
Currently, the v4l2 control code is a bit silent on errors.
Add debug messages on (hopefully) most of the error paths.
Signed-off-by: Ezequiel Garcia
---
Changes from v3:
* Fix checkpatch.pl warnings about long lines.
Changes from v2:
* Check and noisy-warn if vdev is NULL.
Changes from v1
NULL) {
I believe the dprintk macro is OK as-is. We use printk KERN_DEBUG because
we already have a parameter guarding it. This is consistent
with the v4l2 way.
The NULL comparison warning is valid, but it was already
like this before. I'd rather not change existing code.
I'll post a v4.
be skilled enough to know what (not) to configure anyway.
Signed-off-by: Ezequiel Garcia
---
drivers/media/dvb-frontends/Kconfig | 1 -
drivers/media/i2c/Kconfig | 1 -
drivers/media/spi/Kconfig | 1 -
drivers/media/tuners/Kconfig| 1 -
4 files changed, 4 deletions(-)
ion.
Therefore, drop the default-yes, when the CONFIG_EMBEDDED is chosen.
Signed-off-by: Ezequiel Garcia
---
drivers/media/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 21cd9c02960b..8404e80aa38e 100644
--- a/dr
same trap,
and so decided the problem was common enough it was worth
a try.
Thanks!
Eze
Ezequiel Garcia (2):
media: Don't default-enable "ancillary driver autoselect" if EMBEDDED
media: Don't hide any menu if "ancillary drivers autoselect" is
enabled
drivers/m
Introduce a new video4linux2 I2C helper, to unregister a subdev.
This allows to get rid of yet another ifdefs.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-device.c | 25 ++---
drivers/media/v4l2-core/v4l2-i2c.c| 20
include/media
Introduce a new video4linux2 I2C helper, to unregister a subdev.
This allows to get rid of yet another ifdefs.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-device.c | 25 ++---
drivers/media/v4l2-core/v4l2-i2c.c| 20
include/media
: Ezequiel Garcia
---
drivers/media/v4l2-core/Kconfig | 5 +
drivers/media/v4l2-core/Makefile | 1 +
drivers/media/v4l2-core/v4l2-common.c | 145 -
drivers/media/v4l2-core/v4l2-i2c.c| 147 ++
include/media/v4l2-common.h | 113
Use the videodev-$(CONFIG_FOO) syntax to simplify the Makefile.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/Makefile | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/media/v4l2-core/Makefile b/drivers/media/v4l2-core/Makefile
index
valho Chehab
Date: Tue Jan 29 18:32:35 2008 -0300
V4L/DVB (7115): Fix bug #9833: regression when compiling V4L without I2C
Back then, the subsystem organization was different.
However, With the current organization, there is no issue
compiling V4L2 with I2C as y/m/n.
Signed-off-by: Eze
now if you want me to clean that as well.
The entire series should not affect any functionality,
but just clean-up the code a bit.
Thanks,
Eze
Ezequiel Garcia (6):
media: v4l2-core: Cleanup Makefile
media: v4l2-core: Module re-organization
media: v4l2-core: move spi helpers out of v4l2-common
Separate the spi helpers to v4l2-spi.c, in order to get rid
of the ifdefery. No functional changes intended, this is
just a cosmetic change to organize the code better.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/Makefile | 1 +
drivers/media/v4l2-core/v4l2-common.c | 65
Introduce a new video4linux2 SPI helper, to unregister a subdev.
This allows to get rid of some more ifdefs.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-device.c | 14 ++
drivers/media/v4l2-core/v4l2-spi.c| 8
include/media/v4l2-common.h
Introduce a new video4linux2 SPI helper, to unregister a subdev.
This allows to get rid of some more ifdefs.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-device.c | 14 ++
drivers/media/v4l2-core/v4l2-spi.c| 8
include/media/v4l2-common.h
ting).
- At s_stream time enable/disable the MIPI interface output.
With this commit the sensor is able to enter LP-11 mode during power up,
as expected by some CSI-2 controllers.
Many thanks to Fabio Estevam for his help debugging this issue.
Tested-by: Fabio Estevam
Signed-off-by: Ezequiel
Hi Boris, Paul,
On Wed, 2019-07-03 at 14:28 +0200, Boris Brezillon wrote:
> Looks like some stateless decoders expect slices to be prefixed with
> ANNEX B start codes (they most likely do some kind of bitstream parsing
> and/or need that to delimit slices when doing per frame decoding).
> Since sk
> > for drivers that need this list).
> >
> > Signed-off-by: Boris Brezillon
>
> Those only existed for Rockchip/Hantro anyway.
>
> Reviewed-by: Nicolas Dufresne
>
Reviewed-by: Ezequiel Garcia
Thanks,
Eze
On Sun, 2019-06-30 at 13:44 -0300, Mauro Carvalho Chehab wrote:
> Hi all,
>
> We are organizing a media mini-summit in Lisbon to happen in September,
> at the same week as the Linux Plumber Conference and the Kernel Summit.
>
> We're still discussing the details about that.
>
> In principle, it
ting).
- At s_stream time enable/disable the MIPI interface output.
With this commit the sensor is able to enter LP-11 mode during power up,
as expected by some CSI-2 controllers.
Many thanks to Fabio Estevam for his help debugging this issue.
Signed-off-by: Ezequiel Garcia
---
driver
On Thu, 2019-06-27 at 11:33 +0200, Paul Kocialkowski wrote:
> Hi,
>
> On Wed 13 Feb 19, 18:15, Ezequiel Garcia wrote:
> > From: Pawel Osciak
> >
> > These controls are to be used with the new low-level decoder API for VP8
> > to provide additional parameters f
On Thu, 2019-06-27 at 14:56 +0200, Philipp Zabel wrote:
> Hi Fabio,
>
> On Thu, 2019-06-27 at 09:38 -0300, Fabio Estevam wrote:
> > Hi Philipp,
> >
> > On Thu, Jun 27, 2019 at 5:43 AM Philipp Zabel
> > wrote:
> >
> > > Are there any visual artifacts in the first frame(s) in this case?
> >
> >
On Thu, 2019-06-27 at 10:43 +0200, Philipp Zabel wrote:
> On Wed, 2019-06-26 at 16:29 -0700, Steve Longerbeam wrote:
> > Hi Fabio,
> >
> > On 6/26/19 4:22 PM, Fabio Estevam wrote:
> > > Hi Steve,
> > >
> > > On Wed, Jun 26, 2019 at 6:19 PM Steve Longerbeam
> > > wrote:
> > >
> > > > Did you on
Hi Laurent, Philipp,
Thank you for the prompt review! I was pretty sure this would
raise your wise eyebrows :-)
On Wed, 2019-06-26 at 11:00 +0300, Laurent Pinchart wrote:
> Hi Ezequiel,
>
> Thank you for the patch.
>
> On Tue, Jun 25, 2019 at 05:39:45PM -0300, Ezequiel Garcia
omething is off.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/imx/imx6-mipi-csi2.c | 33 ++
1 file changed, 9 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c
b/drivers/staging/media/imx/imx6-mipi-csi2.c
index f29e28df36ed..1034
Currently, the v4l2 control code is a bit silent on errors.
Add debug messages on (hopefully) most of the error paths.
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Check and noisy-warn if vdev is NULL.
Changes from v1:
* Drop changes in the debug parameter semantics.
* Drop new module
On Sat, 2019-06-22 at 08:53 +0200, Hans Verkuil wrote:
> On 6/22/19 12:50 AM, Ezequiel Garcia wrote:
> > Currently, the v4l2 control code is a bit silent on errors.
> > Add debug messages on (hopefully) most of the error paths.
> >
> > Signed-off-by: Ezequiel Garcia
Currently, the v4l2 control code is a bit silent on errors.
Add debug messages on (hopefully) most of the error paths.
Signed-off-by: Ezequiel Garcia
---
Changes from v1:
* Drop changes in the debug parameter semantics.
* Drop new module debug parameter.
* Add documentation.
* Add a debug error
On Mon, 2019-06-17 at 15:40 +0200, Boris Brezillon wrote:
> On Thu, 13 Jun 2019 12:10:40 -0300
> Ezequiel Garcia wrote:
>
>
> > +static void cfg_parts(struct hantro_ctx *ctx,
> > + const struct v4l2_ctrl_vp8_frame_header *hdr)
> > +{
> > +
Hi Boris,
Thanks for the review.
On Mon, 2019-06-17 at 15:23 +0200, Boris Brezillon wrote:
> On Thu, 13 Jun 2019 12:10:39 -0300
> Ezequiel Garcia wrote:
>
> > From: Pawel Osciak
> >
> > Add the parsed VP8 frame pixel format and controls, to be used
> > with
On Tue, 2019-06-18 at 20:17 -0300, Ezequiel Garcia wrote:
> Rework std_init adding an explicit initialization for
> compound controls.
>
> While here, make sure the control is initialized to zero,
> before providing default values for all its fields.
>
> Reviewed-by: Bori
Rework std_init adding an explicit initialization for
compound controls.
While here, make sure the control is initialized to zero,
before providing default values for all its fields.
Reviewed-by: Boris Brezillon
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Fix missing index usage
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/hantro_drv.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/hantro/hantro_drv.c
b
On Mon, 2019-06-17 at 14:43 +0200, Hans Verkuil wrote:
> Hi Ezequiel,
>
> On 11/2/18 4:52 PM, Ezequiel Garcia wrote:
> > Given the stateful codec specification is still a moving target,
> > it doesn't make any sense to try to comply fully with it.
> >
> >
From: ZhiChao Yu
Introduce VP8 decoding support in RK3288.
Signed-off-by: ZhiChao Yu
Signed-off-by: Tomasz Figa
Signed-off-by: Boris Brezillon
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/hantro/Makefile | 4 +-
drivers/staging/media/hantro/hantro.h | 5
From: Pawel Osciak
Add the parsed VP8 frame pixel format and controls, to be used
with the new stateless decoder API for VP8 to provide parameters
for accelerator (aka stateless) codecs.
Signed-off-by: Pawel Osciak
Signed-off-by: Ezequiel Garcia
--
Changes from RFC:
* Make sure the uAPI has
This patchset adds support for Hantro G1 VP8 stateless decoding,
as available on RK3288 SoC.
In order to support VP8 stateless decoding, a new pixel format
is introduced V4L2_PIX_FMT_VP8_FRAME, to be used with a new control
V4L2_CID_MPEG_VIDEO_VP8_FRAME_HDR.
The VP8 stateless uAPI was submitted a
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/rockchip/vpu
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Rick Chang
Cc: Bin Liu
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Jean-Christophe Trotin
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/sti/hva/hva-v4l2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Tiffany Lin
Cc: Andrew-CT Chen
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Some drivers need to access a vb2 buffer from its
queue index. Introduce an accessor to abstract this,
and avoid drivers from accessing private members.
Reviewed-by: Boris Brezillon
Signed-off-by: Ezequiel Garcia
---
Changes from v1:
* Drop redundant num_buffers > 0 check.
---
include/me
further changes.
Changes from v1:
* Address feedback from Boris, and drop redundant check.
Thanks,
Ezequiel
Ezequiel Garcia (5):
media: vb2: Introduce a vb2_get_buffer accessor
media: mtk-jpeg: Use vb2_get_buffer
media: mtk-vcodec: Use vb2_get_buffer
media: sti: Use vb2_get_buffer
media
On Thu, 2019-06-06 at 19:43 +0200, Boris Brezillon wrote:
> On Thu, 6 Jun 2019 12:44:21 -0300
> Ezequiel Garcia wrote:
>
> > Hi,
> >
> > This patchset introduces a new vb2_get_buffer accessor and then
> > uses it on all the drivers that are accessing videobuf2
These two control types don't really need a default value,
as they are not expected to carry any value.
However, it's slightly clearer to initialize them explicitly
instead of falling back to the switch default.
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Initialize the c
Rework std_init adding an explicit initialization for
compound controls.
While here, make sure the control is initialized to zero,
before providing default values for all its fields.
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Align parameters to parenthesis
* Drop unneeded zero
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/rockchip/vpu
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Jean-Christophe Trotin
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/sti/hva/hva-v4l2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform
Some drivers need to access a vb2 buffer from its
queue index. Introduce an accessor to abstract this,
and avoid drivers from accessing private members.
Signed-off-by: Ezequiel Garcia
---
include/media/videobuf2-core.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Tiffany Lin
Cc: Andrew-CT Chen
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Rick Chang
Cc: Bin Liu
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media
further changes.
`
Thanks,
Ezequiel
Ezequiel Garcia (5):
media: vb2: Introduce a vb2_get_buffer accessor
media: mtk-jpeg: Use vb2_get_buffer
media: mtk-vcodec: Use vb2_get_buffer
media: sti: Use vb2_get_buffer
media: rockchip: Use vb2_get_buffer
.../media/platform/mtk-jpeg/mtk_jpeg
On Mon, 2019-06-03 at 09:16 +0200, Hans Verkuil wrote:
> On 6/1/19 7:57 PM, Ezequiel Garcia wrote:
> > On Mon, 2019-03-11 at 12:36 +0100, Hans Verkuil wrote:
> > > On 2/27/19 6:07 PM, Ezequiel Garcia wrote:
> > > > Currently, the v4l2 control code is a bit silent
1 - 100 of 1062 matches
Mail list logo
