Re: [PATCH 27/28] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412

2013-06-15 Thread Eduardo Valentin
EXYNOS4212 > as the one supporting both SoCs from this series. > > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: Mauro Carvalho Chehab > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Greg Kroah-Hartman > Cc: cpuf...@vger.kernel.org > Cc: linux...@vger.k

[PATCH 4/4] media: radio: add module alias entry for radio-si4713

2013-03-19 Thread Eduardo Valentin
Add MODULE_ALIAS entry for radio-si4713 platform driver. Signed-off-by: Eduardo Valentin --- drivers/media/radio/radio-si4713.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio/radio-si4713.c index ae70930

[PATCH 2/4] media: radio: correct module license (==> GPL v2)

2013-03-19 Thread Eduardo Valentin
As per code header comment, changing the driver license entry to match the correct version. Signed-off-by: Eduardo Valentin --- drivers/media/radio/radio-si4713.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio

[PATCH 3/4] media: radio: add driver owner entry for radio-si4713

2013-03-19 Thread Eduardo Valentin
Simple addition of platform_driver->driver->owner for radio-si4713. Signed-off-by: Eduardo Valentin --- drivers/media/radio/radio-si4713.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio/radio-si4713.c

[PATCH 1/4] media: radio: CodingStyle changes on si4713

2013-03-19 Thread Eduardo Valentin
Minor changes to make alignment match on open parenthesis. Signed-off-by: Eduardo Valentin --- drivers/media/radio/radio-si4713.c | 53 +-- 1 files changed, 26 insertions(+), 27 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media

[PATCH 0/4] media: si4713: minor updates

2013-03-19 Thread Eduardo Valentin
Hello Mauro and Hans, Here are a couple of minor changes for si4713 FM transmitter driver. These changes are also available here: https://git.gitorious.org/si4713/si4713.git All best, Eduardo Valentin (4): media: radio: CodingStyle changes on si4713 media: radio: correct module license

[PATCH 1/1] MAINTAINERS: Add maintainer entry for si4713 FM transmitter driver

2013-02-27 Thread Eduardo Valentin
Add maintainer entry for the files composing si4713 FM transmitter driver. Signed-off-by: Eduardo Valentin --- MAINTAINERS | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 870ba56..fe5583e 100644 --- a/MAINTAINERS +++ b

Re: [PATCH 2/2] V4L/DVB: radio-si4713: Add regulator framework support

2010-09-08 Thread Eduardo Valentin
Hello, On Wed, Sep 08, 2010 at 07:59:38AM +0200, Jarkko Nikula wrote: > Hi > > On Tue, 7 Sep 2010 22:49:49 +0300 > Eduardo Valentin wrote: > > > Hello Jarkko, > > > > On Sun, Jun 13, 2010 at 08:09:28PM +0200, Jarkko Nikula wrote: > > > Convert the dr

Re: [PATCH] Illuminators and status LED controls

2010-09-08 Thread Eduardo Valentin
> > API? > > > > (That question is mostly rhetorical, but I'd still actually be interested > > from video app developers.) > > > > Regards, > > Andy > > > > Eduardo Valentin wrote: > > > >> Hello, > >> > >> On M

Re: [PATCH 1/2] V4L/DVB: radio-si4713: Release i2c adapter in driver cleanup paths

2010-09-07 Thread Eduardo Valentin
Jarkko and Mauro, Apologies for the long delay. On Sun, Jun 13, 2010 at 08:09:27PM +0200, Jarkko Nikula wrote: > Call to i2c_put_adapter was missing in radio_si4713_pdriver_probe and > radio_si4713_pdriver_remove. > > Signed-off-by: Jarkko Nikula > Cc: Eduardo Valentin Ac

Re: [PATCH 2/2] V4L/DVB: radio-si4713: Add regulator framework support

2010-09-07 Thread Eduardo Valentin
; Signed-off-by: Jarkko Nikula > Cc: Eduardo Valentin > --- > I don't have specifications for this chip so I don't know how long the > reset signal must be active after power-up. I used 50 us from Maemo > kernel sources for Nokia N900 and I can successfully enable-disable >

Re: [PATCH] Illuminators and status LED controls

2010-09-07 Thread Eduardo Valentin
| http://moinejf.free.fr/ Apologies if this has been already discussed but, doesn't this patch duplicates the same feature present nowadays under include/linux/leds.h ?? I mean, if you want to control leds, I think we already have that API, no? BR, --- Eduardo Valentin

Re: [PATCH] si4713: Fix oops when si4713_platform_data is marked as __initdata

2010-05-18 Thread Eduardo Valentin
does not apply in this case. Not sure (and not tested the above case). BR, > > Signed-off-by: Jarkko Nikula > Cc: Eduardo Valentin > --- > drivers/media/radio/si4713-i2c.c | 15 +-- > drivers/media/radio/si4713-i2c.h |2 +- > 2 files changed, 10 insert

Re: [PATCH 2/9] V4L/DVB: si4713: remove unused #include

2009-09-20 Thread Eduardo Valentin
Hello, On Wed, Sep 16, 2009 at 03:06:15PM +0200, ext Huang Weiyi wrote: > Remove unused #include ('s) in > drivers/media/radio/radio-si4713.c > > Signed-off-by: Huang Weiyi This might be late, but I'm add my ack here. Acked-by: Eduardo Valentin > --- > driver

Re: [PATCH 1/1] FM TX: si4713: Kconfig: Fixed two typos.

2009-09-11 Thread Eduardo Valentin
On Fri, Sep 11, 2009 at 09:38:04AM +0200, Aaltonen Matti.J (Nokia-D/Tampere) wrote: > Fixed two typos. > > Signed-off-by: Matti J. Aaltonen Acked-by: Eduardo Valentin > > diff -r 5582a6427a41 -r ff80edccfe24 linux/drivers/media/radio/Kconfig > --- a/linux/drivers/m

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-09-01 Thread Eduardo Valentin
ffstat: > linux/drivers/media/radio/si4713-i2c.c | 17 ++--- On si4713-i2c.c behalf: Acked-by: Eduardo Valentin > linux/drivers/media/video/cx25840/cx25840-firmware.c | 35 > +++ > v4l/versions.txt | 19 ++

Re: [PATCHv15 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-08-16 Thread Eduardo Valentin
Hello Hans, > > Hi Eduardo, > > I would like to make some small changes here: the control IDs do not have to > be consecutive so I think it is better to leave some gaps between the various > sections: e.g. let the AUDIO controls start at BASE + 64 (leaving more than > enough room for additional

[PATCH 1/1] si4713-i2c: Fix null pointer reference in probe

2009-08-10 Thread Eduardo Valentin
Remove reference to uninitialized v4l2_subdevice pointer in fail path of probe function. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/si4713-i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux/drivers/media/radio/si4713-i2c.c b/linux/drivers

[PATCHv15 5/8] FM TX: si4713: Add files to add radio interface for si4713

2009-08-08 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio

[PATCHv15 7/8] FM TX: si4713: Add Kconfig and Makefile entries

2009-08-08 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv15 4/8] v4l2-spec: Add documentation description for FM TX extended control class

2009-08-08 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. The vidioc-g-ext-ctrls.sgml file was updated as well. Signed-off-by: Eduardo Valentin --- v4l2-spe

[PATCHv15 8/8] FM TX: si4713: Add document file

2009-08-08 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 176 1 files changed, 176 insertions(+), 0 deletions(-) create mode

[PATCHv15 3/8] v4l2: video device: Add FM TX controls default configurations

2009-08-08 Thread Eduardo Valentin
This patch adds basic configurations for FM TX extended controls. That includes controls names, menu strings, pointer identification, type classification and flags configuration. Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 50

[PATCHv15 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-08-08 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv15 1/8] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-08-08 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 89a39ce..d411345 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

[PATCHv15 0/8] FM Transmitter (si4713) and another changes

2009-08-08 Thread Eduardo Valentin
TX class reference in vidioc-g-ext-ctrls.sgml - Fixed a null pointer reference in I2C driver, in one of its error paths inside probe function. - Propagation of errno is now done properly for s/g_ext_ctrls As usual, comments are wellcome ! Thanks you all for the good reviewing work. BR, Eduardo

Re: [PATCHv14 6/8] FM TX: si4713: Add files to handle si4713 i2c device

2009-08-08 Thread Eduardo Valentin
hould change: > > On Monday 27 July 2009 17:12:08 Eduardo Valentin wrote: > > diff --git a/linux/drivers/media/radio/si4713-i2c.c > > b/linux/drivers/media/radio/si4713-i2c.c > > > > > +/* write string property */ > > +static int si4713_write_econtro

Re: [PATCHv14 6/8] FM TX: si4713: Add files to handle si4713 i2c device

2009-08-08 Thread Eduardo Valentin
e it's pretty good as far as I'm concerned :-) > > I do think one small thing should change: > > On Monday 27 July 2009 17:12:08 Eduardo Valentin wrote: > > diff --git a/linux/drivers/media/radio/si4713-i2c.c > > b/linux/drivers/media/radio/si4713-i2c.

Re: [PATCHv14 6/8] FM TX: si4713: Add files to handle si4713 i2c device

2009-08-08 Thread Eduardo Valentin
rval = -ENOMEM; > > + goto exit; > > + } > > .... > > You shouldn't do sdev->sd if sdev is NULL. Ok! Thanks for pointing this Matti! > > Cheers, > Matti > > > > > > -- Eduardo Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb

2009-08-08 Thread Eduardo Valentin
> will make easier to analyze the required core changes. > > Eduardo, can you make a final patch series against my tree? I'll merge in your > patches and make a new pull request containing everything. Sure. I'll do it today. That will include that ordering change you request. > > Regards, > > Hans > > -- > Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- Eduardo Valentin -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCHv14 8/8] FM TX: si4713: Add document file

2009-07-27 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 176 1 files changed, 176 insertions(+), 0 deletions(-) create mode

[PATCHv14 5/8] FM TX: si4713: Add files to add radio interface for si4713

2009-07-27 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio

[PATCHv14 4/8] v4l2-spec: Add documentation description for FM TX extended control class

2009-07-27 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. Signed-off-by: Eduardo Valentin --- v4l2-spec/Makefile |1 + v4l2-spec/controls.s

[PATCHv14 3/8] v4l2: video device: Add FM TX controls default configurations

2009-07-27 Thread Eduardo Valentin
This patch adds basic configurations for FM TX extended controls. That includes controls names, menu strings, pointer identification, type classification and flags configuration. Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 50

[PATCHv14 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-07-27 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv14 7/8] FM TX: si4713: Add Kconfig and Makefile entries

2009-07-27 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv14 1/8] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-07-27 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 89a39ce..d411345 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

[PATCHv14 0/8] FM Transmitter (si4713) and another changes

2009-07-27 Thread Eduardo Valentin
hello guys, This is version 14 of this series. More polishing this time: removal of few unused variables and some reorganization to reduce stack size. A tiny fix on specs text as well. Code looks nicer. Comments, as usual, are appreciated. BR, Eduardo Valentin (8): v4l2-subdev.h: Add

[PATCHv13 3/8] v4l2: video device: Add FM TX controls default configurations

2009-07-27 Thread Eduardo Valentin
This patch adds basic configurations for FM TX extended controls. That includes controls names, menu strings, pointer identification, type classification and flags configuration. Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 50

[PATCHv13 0/8] FM Transmitter (si4713) and another changes

2009-07-27 Thread Eduardo Valentin
hello guys, This is version 13 of this series. A littler mistake was made on last one: wrong access to user pointers was being performed during string control manipulation. Also I forgot to update v4l2 specs. Comments, as usual, are appreciated. BR, Eduardo Valentin (8): v4l2-subdev.h: Add

[PATCHv13 1/8] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-07-27 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 89a39ce..d411345 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

[PATCHv13 4/8] v4l2-spec: Add documentation description for FM TX extended control class

2009-07-27 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. Signed-off-by: Eduardo Valentin --- v4l2-spec/Makefile |1 + v4l2-spec/controls.s

[PATCHv13 8/8] FM TX: si4713: Add document file

2009-07-27 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 176 1 files changed, 176 insertions(+), 0 deletions(-) create mode

[PATCHv13 5/8] FM TX: si4713: Add files to add radio interface for si4713

2009-07-27 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio

[PATCHv13 7/8] FM TX: si4713: Add Kconfig and Makefile entries

2009-07-27 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv13 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-07-27 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv12 7/8] FM TX: si4713: Add Kconfig and Makefile entries

2009-07-27 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv12 4/8] v4l2-spec: Add documentation description for FM TX extended control class

2009-07-27 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. Signed-off-by: Eduardo Valentin --- v4l2-spec/Makefile |1 + v4l2-spec/controls.s

[PATCHv12 5/8] FM TX: si4713: Add files to add radio interface for si4713

2009-07-27 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio

[PATCHv12 8/8] FM TX: si4713: Add document file

2009-07-27 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 176 1 files changed, 176 insertions(+), 0 deletions(-) create mode

[PATCHv12 0/8] FM Transmitter (si4713) and another changes

2009-07-27 Thread Eduardo Valentin
emphasize here, queryfill is about string length, although the control field is about memory size. Also, I've written a way to clear string controls. That was missing on previous version. I believe it is important to have it. Comments, as usual, are appreciated. BR, Eduardo Valentin (8):

[PATCHv12 3/8] v4l2: video device: Add FM TX controls default configurations

2009-07-27 Thread Eduardo Valentin
This patch adds basic configurations for FM TX extended controls. That includes controls names, menu strings, pointer identification, type classification and flags configuration. Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 50

[PATCHv12 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-07-27 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv12 1/8] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-07-27 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 89a39ce..d411345 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

Re: Changes to the string control handling

2009-07-25 Thread Eduardo Valentin
Hello Hans, On Sat, Jul 25, 2009 at 7:44 PM, Hans Verkuil wrote: > Hi Eduardo, > > On Saturday 25 July 2009 16:41:27 Eduardo Valentin wrote: >> On Sat, Jul 25, 2009 at 04:39:18PM +0200, ext Hans Verkuil wrote: >> > If the string must be exactly 8 x n long, then I

Re: [PATCHv11 0/8] FM Transmitter (si4713) and another changes

2009-07-25 Thread Eduardo Valentin
ntation/video4linux/si4713.txt > create mode 100644 linux/drivers/media/radio/radio-si4713.c > create mode 100644 linux/drivers/media/radio/si4713-i2c.c > create mode 100644 linux/drivers/media/radio/si4713-i2c.h > create mode 100644 linux/include/media/radio-si4713.h > create mode 100644 linux/include/media/si4713.h -- Eduardo Valentin patches-v11.tar.gz Description: Binary data

[PATCHv11 8/8] FM TX: si4713: Add document file

2009-07-25 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 176 1 files changed, 176 insertions(+), 0 deletions(-) create mode

Re: [PATCHv11 8/8] FM TX: si4713: Add document file

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 05:19:29PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 16:57:42 Eduardo Valentin wrote: > > This patch adds a document file for si4713 device driver. > > It describes the driver interfaces and organization. > > > > Sign

[PATCHv11 7/8] FM TX: si4713: Add Kconfig and Makefile entries

2009-07-25 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv11 8/8] FM TX: si4713: Add document file

2009-07-25 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 176 1 files changed, 176 insertions(+), 0 deletions(-) create mode

[PATCHv11 1/8] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-07-25 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 89a39ce..d411345 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

[PATCHv11 5/8] FM TX: si4713: Add files to add radio interface for si4713

2009-07-25 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio

[PATCHv11 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-07-25 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv11 3/8] v4l2: video device: Add FM TX controls default configurations

2009-07-25 Thread Eduardo Valentin
This patch adds basic configurations for FM TX extended controls. That includes controls names, menu strings, pointer identification, type classification and flags configuration. Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 58

[PATCHv11 4/8] v4l2-spec: Add documentation description for FM TX extended control class

2009-07-25 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. Signed-off-by: Eduardo Valentin --- v4l2-spec/Makefile |1 + v4l2-spec/controls.s

[PATCHv11 0/8] FM Transmitter (si4713) and another changes

2009-07-25 Thread Eduardo Valentin
, which contains the string support for our extended control api. The problems with v4l2-ctl were solved by Hans. Now it can properly set/get frequencies for modulators. Also the txsubchannels are properly handled for RDS capable devices. Thanks Hans. BR, Eduardo Valentin (8): v4l2-subdev.h

Re: [PATCH 1/1] v4l2-ctl: Add G_MODULATOR before set/get frequency

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 04:44:27PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 16:23:51 Eduardo Valentin wrote: > > On Sat, Jul 25, 2009 at 04:08:01PM +0200, Valentin Eduardo > > (Nokia-D/Helsinki) wrote: > > > On Sat, Jul 25, 2009 at 04:10:53PM +0200

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 04:39:18PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 15:25:21 Eduardo Valentin wrote: > > On Sat, Jul 25, 2009 at 03:33:55PM +0200, ext Hans Verkuil wrote: > > > On Saturday 25 July 2009 15:29:38 ext-eero.nurkk...@nokia.com wrote: >

Re: [PATCH 1/1] v4l2-ctl: Add G_MODULATOR before set/get frequency

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 04:08:01PM +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: > On Sat, Jul 25, 2009 at 04:10:53PM +0200, ext Hans Verkuil wrote: > > On Friday 24 July 2009 18:42:12 Eduardo Valentin wrote: > > > As there can be modulator devices with get/set frequency >

Re: [PATCH 1/1] v4l2-ctl: Add G_MODULATOR before set/get frequency

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 04:10:53PM +0200, ext Hans Verkuil wrote: > On Friday 24 July 2009 18:42:12 Eduardo Valentin wrote: > > As there can be modulator devices with get/set frequency > > callbacks, this patch adds support to them in v4l2-ctl utility. > > Thanks for

Re: [PATCHv10 8/8] FMTx: si4713: Add document file

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 03:17:05PM +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: > On Sat, Jul 25, 2009 at 03:25:25PM +0200, ext Hans Verkuil wrote: > > On Friday 24 July 2009 18:37:28 Eduardo Valentin wrote: > > > This patch adds a document file for si4713 device driver.

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Eduardo Valentin
wever, this behavior > contradicts the control description in the spec, so that should be clarified. Yes, I'll add a comment explaining this for those defines. > > Regards, > > Hans > > -- > Hans Verkuil - video4linux developer - sponsored by TANDBER

Re: [PATCHv10 6/8] FMTx: si4713: Add files to handle si4713 i2c device

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 03:31:29PM +0200, ext Hans Verkuil wrote: > On Saturday 25 July 2009 15:15:24 Eduardo Valentin wrote: > > On Sat, Jul 25, 2009 at 03:20:53PM +0200, ext Hans Verkuil wrote: > > > > + switch (control->id) { > > > >

Re: [PATCHv10 8/8] FMTx: si4713: Add document file

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 03:25:25PM +0200, ext Hans Verkuil wrote: > On Friday 24 July 2009 18:37:28 Eduardo Valentin wrote: > > This patch adds a document file for si4713 device driver. > > It describes the driver interfaces and organization. > > > > Sign

Re: [PATCHv10 3/8] v4l2: video device: Add FM_TX controls default configurations

2009-07-25 Thread Eduardo Valentin
On Sat, Jul 25, 2009 at 03:03:33PM +0200, ext Hans Verkuil wrote: > On Friday 24 July 2009 18:37:23 Eduardo Valentin wrote: > > Signed-off-by: Eduardo Valentin > > --- > > linux/drivers/media/video/v4l2-common.c | 63 > > ++- > >

[PATCH 1/1] v4l2-ctl: Add G_MODULATOR before set/get frequency

2009-07-24 Thread Eduardo Valentin
As there can be modulator devices with get/set frequency callbacks, this patch adds support to them in v4l2-ctl utility. Signed-off-by: Eduardo Valentin --- v4l2-apps/util/v4l2-ctl.cpp | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/v4l2-apps/util/v4l2-ctl.cpp

[PATCHv10 8/8] FMTx: si4713: Add document file

2009-07-24 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 175 1 files changed, 175 insertions(+), 0 deletions(-) create mode

[PATCHv10 7/8] FMTx: si4713: Add Kconfig and Makefile entries

2009-07-24 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv10 5/8] FMTx: si4713: Add files to add radio interface for si4713

2009-07-24 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio

[PATCHv10 3/8] v4l2: video device: Add FM_TX controls default configurations

2009-07-24 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 63 ++- 1 files changed, 62 insertions(+), 1 deletions(-) diff --git a/linux/drivers/media/video/v4l2-common.c b/linux/drivers/media/video/v4l2-common.c index bd13702..6fc0559 100644

[PATCHv10 4/8] v4l2-spec: Add documentation description for FM TX extended control class

2009-07-24 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. Signed-off-by: Eduardo Valentin --- v4l2-spec/Makefile |1 + v4l2-spec/controls.s

[PATCHv10 2/8] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-07-24 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv10 1/8] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-07-24 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 89a39ce..d411345 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

[PATCHv10 0/8] FM Transmitter (si4713) and another changes

2009-07-24 Thread Eduardo Valentin
send an initial proposal in a separated patch (I believe it is not related to this series anymore). BR, Eduardo Valentin (8): v4l2-subdev.h: Add g_modulator callbacks to subdev api v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls v4l2: video device: Add FM_TX controls default configurations

Re: New tree with final (?) string control implementation

2009-07-24 Thread Eduardo Valentin
ies: subdev changes (i2c), modulator capabilities and ext ctl string support. I recall now that subdev is already merged. I'm not sure about the modulator support. > > Thanks, > > Hans > > -- > Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom

[PATCHv9 3/9] v4l2: video device: Add FM_TX controls default configurations

2009-06-22 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 48 +++ 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/video/v4l2-common.c b/linux/drivers/media/video/v4l2-common.c index 1f0b8ef..e5b3f6e 100644

[PATCHv9 9/9] FMTx: si4713: Add document file

2009-06-22 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 175 1 files changed, 175 insertions(+), 0 deletions(-) create mode

[PATCHv9 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-22 Thread Eduardo Valentin
This patch adds a new class of extended controls. This class is intended to support FM Radio Modulators properties such as: rds, audio limiters, audio compression, pilot tone generation, tuning power levels and preemphasis properties. Signed-off-by: Eduardo Valentin --- linux/include/linux

[PATCHv9 4/9] v4l2-ctl: Add support for FM TX controls

2009-06-22 Thread Eduardo Valentin
This patch adds simple support for FM TX extended controls on v4l2-ctl utility. Signed-off-by: Eduardo Valentin --- v4l2-apps/util/v4l2-ctl.cpp | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/v4l2-apps/util/v4l2-ctl.cpp b/v4l2-apps

[PATCHv9 5/9] v4l2-spec: Add documentation description for FM TX extended control class

2009-06-22 Thread Eduardo Valentin
This single patch adds documentation description for FM Modulator (FM_TX) Extended Control Class and its Control IDs. The text was added under "Extended Controls" section. Signed-off-by: Eduardo Valentin --- v4l2-spec/Makefile |1 + v4l2-spec/controls.s

[PATCHv9 1/9] v4l2-subdev.h: Add g_modulator callbacks to subdev api

2009-06-22 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/include/media/v4l2-subdev.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux/include/media/v4l2-subdev.h b/linux/include/media/v4l2-subdev.h index 5dcb367..4dc3788 100644 --- a/linux/include/media/v4l2-subdev.h +++ b/linux

[PATCHv9 0/9] FM Transmitter (si4713) and another changes

2009-06-22 Thread Eduardo Valentin
ified list of things included in this series: - support for g/s_modulator into subdev api - addition of fm tx extended controls and their proper documentation - addition of fm tx extended controls in v4l2-ctl util - addition of si4713: platform and i2c drivers and its documentation BR, Eduardo

[PATCHv9 8/9] FMTx: si4713: Add Kconfig and Makefile entries

2009-06-22 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

[PATCHv9 6/9] FMTx: si4713: Add files to add radio interface for si4713

2009-06-22 Thread Eduardo Valentin
This patch adds files which creates the radio interface for si4713 FM transmitter (modulator) devices. In order to do the real access to device registers, this driver uses the v4l2 subdev interface exported by si4713 i2c driver. Signed-off-by: "Eduardo Valentin " --- linux/drivers/m

Re: RFC: FM modulator and RDS encoder V4L2 API additions

2009-06-20 Thread Eduardo Valentin
t control ? > > I've made a first implementation of these changes in this tree: > http://linuxtv.org/hg/~hverkuil/v4l-dvb-rds-enc > > This tree also contains the RDS decoder changes from my v4l-dvb-rds tree > since it needs to build on those. > > Comments? > > Reg

Re: [PATCHv8 7/9] FMTx: si4713: Add files to handle si4713 i2c device

2009-06-20 Thread Eduardo Valentin
Hi Hans, On Sat, Jun 20, 2009 at 03:27:09PM +0200, ext Hans Verkuil wrote: > On Thursday 18 June 2009 15:55:49 Eduardo Valentin wrote: > > This patch adds files to control si4713 devices. > > Internal functions to control device properties > > and initialization procedures

[PATCHv8 9/9] FMTx: si4713: Add document file

2009-06-18 Thread Eduardo Valentin
This patch adds a document file for si4713 device driver. It describes the driver interfaces and organization. Signed-off-by: Eduardo Valentin --- linux/Documentation/video4linux/si4713.txt | 169 1 files changed, 169 insertions(+), 0 deletions(-) create mode

[PATCHv8 4/9] v4l2-ctl: Add support for FM TX controls

2009-06-18 Thread Eduardo Valentin
This patch adds simple support for FM TX extended controls on v4l2-ctl utility. Signed-off-by: Eduardo Valentin --- v4l2-apps/util/v4l2-ctl.cpp | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/v4l2-apps/util/v4l2-ctl.cpp b/v4l2-apps

[PATCHv8 3/9] v4l2: video device: Add FM_TX controls default configurations

2009-06-18 Thread Eduardo Valentin
Signed-off-by: Eduardo Valentin --- linux/drivers/media/video/v4l2-common.c | 50 +++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/video/v4l2-common.c b/linux/drivers/media/video/v4l2-common.c index 5cfd727..fc4d7a8 100644

[PATCHv8 8/9] FMTx: si4713: Add Kconfig and Makefile entries

2009-06-18 Thread Eduardo Valentin
Simple add Makefile and Kconfig entries. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/Kconfig | 22 ++ linux/drivers/media/radio/Makefile |2 ++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/linux/drivers/media/radio/Kconfig b/linux

  1   2   >