Fixed si470x_start() disabling the interrupt signal, causing tune
operations to never complete. This does not affect USB radios
because they poll the registers instead of using the IRQ line.
Stylistic and comment changes from v3.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers
Hans,
See comments below. Thank you for the quick response on this and all
your patience and help in general with these patches.
On Mon, 26 Feb 2018 12:57:26 +0100
Hans Verkuil wrote:
> On 02/26/2018 03:27 AM, Douglas Fischer wrote:
> > Fixed si470x_start() disabling the interru
Added the call to v4l2_device_register() required to add a new radio device.
Without this patch, it is impossible for the driver to load. This does not
affect USB devices.
Fixed cleanup order from v2.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio
Fixed si470x_start() disabling the interrupt signal, causing tune
operations to never complete. This does not affect USB radios
because they poll the registers instead of using the IRQ line.
Stylistic and comment changes from v2.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers
Added the call to v4l2_device_register() required to add a new radio
device. Without this patch, it is impossible for the driver to load.
This does not affect USB devices.
Fixed cleanup order from v2.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio
power is off instead
of putting the rest of the function in the conditional.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x-common.c
linux/drivers/media/radio/si470x/radio-si470x-common.c
--- linux.orig/drivers/media/radio/si470x/radio-si470x
18 00:42, Douglas Fischer wrote:
> > Fixed si470x_start() disabling the interrupt signal, causing tune
> > operations to never complete. This does not affect USB radios
> > because they poll the registers instead of using the IRQ line.
> >
> > Signed-off-by: Dougla
Fixed si470x_start() disabling the interrupt signal, causing tune
operations to never complete. This does not affect USB radios
because they poll the registers instead of using the IRQ line.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x
Added the call to v4l2_device_register() required to add a new radio
device. Without this patch, it is impossible for the driver to load.
This does not affect USB devices.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x-i2c.c
linux/drivers/media
Fixed si470x_set_channel() trying to tune before chip is turned
on, which causes warnings in dmesg and when probing, makes driver
wait for 3s for tuning timeout. This issue did not affect USB
devices because they have a different probing sequence.
Signed-off-by: Douglas Fischer
---
diff -uprN
Fixed si470x_start() disabling the interrupt signal, causing tune
operations to never complete. This does not affect USB radios
because they poll the registers instead of using the IRQ line.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x
Added the call to v4l2_device_register() required to add a new radio
device. Without this patch, it is impossible for the driver to load.
This does not affect USB devices.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x-i2c.c
linux/drivers/media
Fixed si470x_set_channel() trying to tune before chip is turned
on, which causes warnings in dmesg and when probing, makes driver
wait for 3s for tuning timeout. This issue did not affect USB
devices because they have a different probing sequence.
Signed-off-by: Douglas Fischer
---
diff -uprN
Fixed si470x_start() disabling the interrupt signal, causing tune
operations to never complete. This does not affect USB radios
because they poll the registers instead of using the IRQ line.
Signed-off-by: Douglas Fischer
---
diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x
14 matches
Mail list logo
