Re: [PATCH 3/5 - v3] DaVinci: platform changes to support vpfe camera capture

2009-08-19 Thread David Brownell
On Monday 17 August 2009, m-kariche...@ti.com wrote: >  static struct i2c_board_info dm355evm_i2c_info[] = { > {   I2C_BOARD_INFO("dm355evm_msp", 0x25), > .platform_data = dm355evm_mmcsd_gpios, > }, > +   { > +   I2C_BOARD_INFO("PCA9543A", 0x73),

Re: [PATCH 3/3 - v0] davinci: platform changes to support vpfe camera capture

2009-06-30 Thread David Brownell
On Tuesday 30 June 2009, Karicheri, Muralidharan wrote: > The code that I am developing is most up to date and is written > against the latest tree. If you insist. Regardless, the $SUBJECT patch had some significant problems (against current code) and should not merge. -- To unsubscribe from th

Re: [PATCH 3/3 - v0] davinci: platform changes to support vpfe camera capture

2009-06-29 Thread David Brownell
On Monday 29 June 2009, Karicheri, Muralidharan wrote: > I think you didn't get my point. We have patches that are in > the pipeline waiting for merge that is neither available in > the upstream nor in the DaVinci tree. The linux-media pipeline. Sure. I'm quite familiar with what it means to hav

Re: [PATCH 3/3 - v0] davinci: platform changes to support vpfe camera capture

2009-06-29 Thread David Brownell
On Monday 29 June 2009, Karicheri, Muralidharan wrote: > > >> > > >> > -static struct tvp514x_platform_data tvp5146_pdata = { > >> > - .clk_polarity = 0, > >> > - .hs_polarity = 1, > >> > - .vs_polarity = 1 > > > >Clearly this patch is against neither mainline nor the > >current DaVinc

Re: [PATCH 3/3 - v0] davinci: platform changes to support vpfe camera capture

2009-06-27 Thread David Brownell
> > --- a/arch/arm/mach-davinci/board-dm355-evm.c > > +++ b/arch/arm/mach-davinci/board-dm355-evm.c > > @@ -136,10 +136,66 @@ static void dm355evm_mmcsd_gpios(unsigned gpio) > >   dm355evm_mmc_gpios = gpio; > >  } > >   > > -static struct tvp514x_platform_data tvp5146_pdata = { > > - .clk_p

Re: [PATCH (V2)] TVP514x: Migration to sub-device framework

2009-06-14 Thread David Brownell
On Sunday 14 June 2009, Hans Verkuil wrote: > > +#define dump_reg(sd, reg, val)   \ > >   do {\ > > - val = tvp514x_read_reg(client, reg);\ > > - v4l_info(client, "Reg(0x%.2X): 0x

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-14 Thread David Brownell
On Sunday 14 June 2009, Hans Verkuil wrote: > >   /* { I2C_BOARD_INFO("tlv320aic3x", 0x1b), }, */ > > Huh? What's this? I only know the tlv320aic23b and that's an audio driver. AIC33 is another audio codec chip: http://focus.ti.com/docs/prod/folders/print/tlv320aic33.html One can't list a

Re: [PATCH 0/10 - v2] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-11 Thread David Brownell
On Thursday 11 June 2009, m-kariche...@ti.com wrote: > VPFE Capture driver for DaVinci Media SOCs :- DM355 and DM6446 > > This is the version v2 of the patch series. This is the reworked > version of the driver based on comments received against the last > version of the patch. I'll be glad to se

Re: [PATCH 7/10 - v2] DM355 platform changes for vpfe capture driver

2009-06-11 Thread David Brownell
On Thursday 11 June 2009, m-kariche...@ti.com wrote: > +   I2C_BOARD_INFO("tvp5146", TVP5146_I2C_ADDR), Minor nit: just use "0x5d" instead of defining TVP5146_I2C_ADDR. Fix in a v3, iff you make one. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the bod

Re: v4l parent for usb device interface or device?

2009-03-26 Thread David Brownell
On Thursday 26 March 2009, Janne Grunau wrote: > > While I generally agree that setting parent to the usb interface is > probably correct for multifunction devices Make that "all" devices. :) > I noticed a problem after > changing the hdpvr driver accordingly. > > With parent set to the usb

Re: [RFC 5/7] ARM: DaVinci: DM646x Video: Makefile and config files modifications for Display

2009-03-13 Thread David Brownell
On Friday 13 March 2009, chaithr...@ti.com wrote: >   > +config DISPLAY_DAVINCI_DM646X_EVM > +        tristate "DM646x EVM Video Display" > +        depends on VIDEO_DEV && MACH_DAVINCI_DM646X_EVM > +        select VIDEOBUF_DMA_CONTIG > +        select VIDEO_DAVINCI_VPIF > +        select VIDEO_ADV

Re: [RFC 0/5] Sensor drivers for OMAP3430SDP and LDP camera

2009-03-04 Thread David Brownell
On Wednesday 04 March 2009, Aguirre Rodriguez, Sergio Alberto wrote: > > > I'd much rather see these drivers just use the regulator > > framework to switch any sensor power rails on/off. > > Hi, > > Sounds interesting. > > Is there any documentation on how to use this? Documentation/DocBook/re

Re: [RFC 0/5] Sensor drivers for OMAP3430SDP and LDP camera

2009-03-03 Thread David Brownell
On Tuesday 03 March 2009, Aguirre Rodriguez, Sergio Alberto wrote: > > > This patch series depends on the following patches: > > > >  - "Add TWL4030 registers", posted by Tuukka Toivonen on March 2nd. > > http://marc.info/?l=linux-omap&m=123597520231668&w=2 I'd much rather see these drivers jus

Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-28 Thread David Brownell
> > > +config MACH_OMAP3EVM_DC > > > +   bool "OMAP 3530 EVM daughter card board" > > > +   depends on ARCH_OMAP3 && ARCH_OMAP34XX && MACH_OMAP3EVM > > > > There can be other daughtercards, so the Kconfig text should > > say which specific card is being configured. And it should > > prob

Re: [REVIEW PATCH 2/2] Added OMAP3EVM Multi-Media Daughter Card Support

2009-01-11 Thread David Brownell
On Tuesday 06 January 2009, hvaib...@ti.com wrote: > +config MACH_OMAP3EVM_DC > +   bool "OMAP 3530 EVM daughter card board" > +   depends on ARCH_OMAP3 && ARCH_OMAP34XX && MACH_OMAP3EVM There can be other daughtercards, so the Kconfig text should say which specific card is being configure