[PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-11-11 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 2 + drivers/media/platform/tegra/Kconfig | 10 + drivers/media/platform/tegra/Makefile| 3 + drivers/media/platform/tegra/tegra-chan

[PATCH 0/3 RFC v5] media: platform: add NVIDIA Tegra VI driver

2015-11-11 Thread Bryan Wu
- other fixes v2: - allocate kthread for each channel instead of workqueue - create tegra-csi as a separated V4L2 subdevice - define all the register bits needed in this driver - add device tree binding document - update things according to Hans and Thierry's review. Bryan Wu (3)

[PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

2015-11-11 Thread Bryan Wu
Signed-off-by: Bryan Wu --- .../display/tegra/nvidia,tegra20-host1x.txt| 211 - 1 file changed, 205 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/display

[PATCH 2/3] ARM64: add tegra-vi support in T210 device-tree

2015-11-11 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64

Re: [Question]: What's right way to use struct media_pipeline?

2015-09-24 Thread Bryan Wu
On 09/24/2015 01:47 AM, Hans Verkuil wrote: On 09/24/2015 02:55 AM, Bryan Wu wrote: Hi Hans, I found struct media_pipeline actually is completely empty and I assume we use that to control all the entities belonging to one media_pipeline. media_pipeline should contains either all the

[Question]: What's right way to use struct media_pipeline?

2015-09-23 Thread Bryan Wu
Hi Hans, I found struct media_pipeline actually is completely empty and I assume we use that to control all the entities belonging to one media_pipeline. media_pipeline should contains either all the media_link or all the media_entity. How come an empty struct can provide those information?

[PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-09-22 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 2 + drivers/media/platform/tegra/Kconfig | 10 + drivers/media/platform/tegra/Makefile| 3 + drivers/media/platform/tegra/tegra-chan

[PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

2015-09-22 Thread Bryan Wu
Signed-off-by: Bryan Wu --- .../bindings/gpu/nvidia,tegra20-host1x.txt | 211 - 1 file changed, 205 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/gpu/nvidia,tegra20

[PATCH 2/3] ARM64: add tegra-vi support in T210 device-tree

2015-09-22 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64

[PATCH 0/3 RFC v3] media: platform: add NVIDIA Tegra VI driver

2015-09-22 Thread Bryan Wu
evice - define all the register bits needed in this driver - add device tree binding document - update things according to Hans and Thierry's review. Bryan Wu (3): [media] v4l: tegra: Add NVIDIA Tegra VI driver ARM64: add tegra-vi support in T210 device-tree Documentation: DT bindings:

Re: [PATCH 2/3] ARM64: add tegra-vi support in T210 device-tree

2015-09-22 Thread Bryan Wu
On 09/22/2015 05:17 AM, Thierry Reding wrote: Hi Bryan, This patchset really needs to be Cc'ed to linux-te...@vger.kernel.org, it's becoming impossible to track it otherwise. My bad, I copied and pasted old git send-email command line. On Mon, Sep 21, 2015 at 11:55:54AM -0700

Re: [PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-09-22 Thread Bryan Wu
On 09/22/2015 04:47 AM, Thierry Reding wrote: On Mon, Sep 21, 2015 at 11:55:53AM -0700, Bryan Wu wrote: [...] +static int tegra_csi_s_stream(struct v4l2_subdev *subdev, int enable) +{ + struct tegra_csi_device *csi = to_csi(subdev); + struct tegra_channel *chan = subdev->host_p

Re: [PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-09-22 Thread Bryan Wu
09-15 20:55, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver to support Tegra VI hardware. It's verified with Tegra built-in test pattern

[PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-09-21 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 2 + drivers/media/platform/tegra/Kconfig | 10 + drivers/media/platform/tegra/Makefile| 3 + drivers/media/platform/tegra/tegra-chan

[PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

2015-09-21 Thread Bryan Wu
Signed-off-by: Bryan Wu --- .../bindings/gpu/nvidia,tegra20-host1x.txt | 211 - 1 file changed, 205 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/gpu/nvidia,tegra20

[PATCH 0/3 RFC v3] media: platform: add NVIDIA Tegra VI driver

2015-09-21 Thread Bryan Wu
hings according to Hans and Thierry's review. Bryan Wu (3): [media] v4l: tegra: Add NVIDIA Tegra VI driver ARM64: add tegra-vi support in T210 device-tree Documentation: DT bindings: add VI and CSI bindings .../bindings/gpu/nvidia,tegra20-host1x.txt | 211 +- arch/arm6

[PATCH 2/3] ARM64: add tegra-vi support in T210 device-tree

2015-09-21 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64

Re: [PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-09-21 Thread Bryan Wu
On 09/16/2015 02:13 AM, Hans Verkuil wrote: Hi Bryan, Thanks for this patch series! The switch to a kthread helps a lot, but I still have a number of comments about it, primarily locking related. On 09/16/2015 03:35 AM, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Video Input

[PATCH 2/3] ARM64: add tegra-vi support in T210 device-tree

2015-09-15 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64

[PATCH 3/3] Documentation: DT bindings: add VI and CSI bindings

2015-09-15 Thread Bryan Wu
Signed-off-by: Bryan Wu --- .../bindings/gpu/nvidia,tegra20-host1x.txt | 211 - 1 file changed, 205 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt b/Documentation/devicetree/bindings/gpu/nvidia,tegra20

[PATCH 1/3] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-09-15 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 2 + drivers/media/platform/tegra/Kconfig | 10 + drivers/media/platform/tegra/Makefile| 3 + drivers/media/platform/tegra/tegra-chan

[PATCH 0/3 RFC v2] media: platform: add NVIDIA Tegra VI driver

2015-09-15 Thread Bryan Wu
ocate kthread for each channel instead of workqueue - create tegra-csi as a separated V4L2 subdevice - define all the register bits needed in this driver - add device tree binding document - update things according to Hans and Thierry's review. Bryan Wu (3): [media] v4l: tegra: Add NVIDI

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Bryan Wu
On 08/25/2015 06:44 AM, Thierry Reding wrote: On Mon, Aug 24, 2015 at 05:26:20PM -0700, Bryan Wu wrote: On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: [...] +{ + if (chan->bypass) + return; I don't see th

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-25 Thread Bryan Wu
On 08/24/2015 11:30 PM, Hans Verkuil wrote: A quick follow-up to Thierry's excellent review: On 08/25/2015 02:26 AM, Bryan Wu wrote: On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: +static void +__tegra_channel_try_format(s

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Bryan Wu
On 08/21/2015 02:28 AM, Hans Verkuil wrote: Hi Bryan, Thanks for contributing this driver, very much appreciated. I do have some comments below, basically about the same things we discussed privately before. On 08/21/2015 02:51 AM, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful

Re: [PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-24 Thread Bryan Wu
On 08/21/2015 06:03 AM, Thierry Reding wrote: On Thu, Aug 20, 2015 at 05:51:39PM -0700, Bryan Wu wrote: NVIDIA Tegra processor contains a powerful Video Input (VI) hardware controller which can support up to 6 MIPI CSI camera sensors. This patch adds a V4L2 media controller and capture driver

[PATCH RFC 0/2] NVIDIA Tegra VI V4L2 driver

2015-08-20 Thread Bryan Wu
work. Currently it's tested with Tegra X1 built-in test pattern generator. Bryan Wu (2): [media] v4l: tegra: Add NVIDIA Tegra VI driver ARM64: add tegra-vi support in T210 device-tree arch/arm64/boot/dts/nvidia/tegra210-p2571-e01.dts |8 + arch/arm64/boot/dts/nvidia/tegra210.dtsi

[PATCH RFC 0/2] NVIDIA Tegra VI V4L2 driver

2015-08-20 Thread Bryan Wu
work. Currently it's tested with Tegra X1 built-in test pattern generator. Bryan Wu (2): [media] v4l: tegra: Add NVIDIA Tegra VI driver ARM64: add tegra-vi support in T210 device-tree arch/arm64/boot/dts/nvidia/tegra210-p2571-e01.dts |8 + arch/arm64/boot/dts/nvidia/tegra210.dtsi

[PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-20 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |2 + drivers/media/platform/tegra/Kconfig |9 + drivers/media/platform/tegra/Makefile|3 + drivers/media/platform/tegra/

[PATCH 1/2] [media] v4l: tegra: Add NVIDIA Tegra VI driver

2015-08-20 Thread Bryan Wu
ff-by: Bryan Wu Reviewed-by: Hans Verkuil --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |2 + drivers/media/platform/tegra/Kconfig |9 + drivers/media/platform/tegra/Makefile|3 + drivers/media/platform/tegra/

[PATCH 2/2] ARM64: add tegra-vi support in T210 device-tree

2015-08-20 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64

[PATCH 2/2] ARM64: add tegra-vi support in T210 device-tree

2015-08-20 Thread Bryan Wu
Following device tree support for Tegra VI now: - "vi" node which might have 6 ports/endpoints - in TPG mode, "vi" node don't need to define any ports/endpoints - ports/endpoints defines the link between VI and external sensors. Signed-off-by: Bryan Wu --- arch/arm64

Re: [PATCH v10.1] leds: aat1290: add support for V4L2 Flash sub-device

2015-06-22 Thread Bryan Wu
an > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Sakari Ailus > --- > - fixed sparse warnings by adding 'static' modifiers to the functions: > * aat1290_intensity_to_brightness > * aat1290_

Re: [PATCH v10.1] media: Add registration helpers for V4L2 flash sub-devices

2015-06-22 Thread Bryan Wu
On Fri, Jun 19, 2015 at 12:31 AM, Jacek Anaszewski wrote: > This patch adds helper functions for registering/unregistering > LED Flash class devices as V4L2 sub-devices. The functions should > be called from the LED subsystem device driver. In case the > support for V4L2 Flash sub-devices is disab

Re: [PATCH v1.3 1/5] v4l: async: Add a pointer to of_node to struct v4l2_subdev, match it

2015-06-15 Thread Bryan Wu
On Thu, Jun 11, 2015 at 11:41 PM, Sakari Ailus wrote: > On Thu, Jun 11, 2015 at 10:27:30PM +0300, Laurent Pinchart wrote: >> Hi Sakari, >> >> Thank you for the patch. >> >> On Thursday 11 June 2015 22:18:01 Sakari Ailus wrote: >> > V4L2 async sub-devices are currently matched (OF case) based on th

Re: [PATCH v10 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-10 Thread Bryan Wu
On Wed, Jun 10, 2015 at 2:34 PM, Sakari Ailus wrote: > Hi Bryan, > > On Wed, Jun 10, 2015 at 11:12:50AM -0700, Bryan Wu wrote: >> On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu wrote: >> > On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu wrote: >> >> On Mon, Jun

Re: [PATCH v10 1/8] Documentation: leds: Add description of v4l2-flash sub-device

2015-06-10 Thread Bryan Wu
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski wrote: > This patch extends LED Flash class documention by > the description of interactions with v4l2-flash sub-device. > Merged into my -devel branch and it won't be merged into 4.2.0 merge window but wait for one more cycle, since now it's quite

Re: [PATCH v10 3/8] leds: max77693: add support for V4L2 Flash sub-device

2015-06-10 Thread Bryan Wu
;t be merged into 4.2.0 merge window but wait for one more cycle, since now it's quite late in 4.1.0 cycle. Thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Sakari Ailus > --

Re: [PATCH v10 4/8] DT: aat1290: Document handling external strobe sources

2015-06-10 Thread Bryan Wu
into 4.2.0 merge window but wait for one more cycle, since now it's quite late in 4.1.0 cycle. Thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Sakari Ailus > Cc: devicet...@vger.kernel.org > --- >

Re: [PATCH v10 8/8] exynos4-is: Add support for v4l2-flash subdevs

2015-06-10 Thread Bryan Wu
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski wrote: > This patch adds support for external v4l2-flash devices. > The support includes parsing "camera-flashes" DT property > and asynchronous sub-device registration. > Please go ahead with my Ack Acked-by: Bryan Wu Th

Re: [PATCH v10 7/8] DT: Add documentation for exynos4-is 'flashes' property

2015-06-10 Thread Bryan Wu
On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski wrote: > This patch adds a description of 'samsung,camera-flashes' > property to the samsung-fimc.txt. > Please go ahead with my Ack Acked-by: Bryan Wu Thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyung

Re: [PATCH v10 6/8] exynos4-is: Improve the mechanism of async subdevs verification

2015-06-10 Thread Bryan Wu
gated in the newly introduced struct fimc_async_subdevs > which allows for categorizing async sub-devices by their type upon > DT node parsing and recognizing the type easily when they're being bound. > Please go ahead with my Ack Acked-by: Bryan Wu Thanks, -Bryan > Signed-off-by:

Re: [PATCH v10 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-10 Thread Bryan Wu
On Wed, Jun 10, 2015 at 11:01 AM, Bryan Wu wrote: > On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu wrote: >> On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski >> wrote: >>> This patch adds helper functions for registering/unregistering >>> LED Flash class devices a

Re: [PATCH v10 5/8] leds: aat1290: add support for V4L2 Flash sub-device

2015-06-10 Thread Bryan Wu
;t be merged into 4.2.0 merge window but wait for one more cycle, since now it's quite late in 4.1.0 cycle. Thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > Cc: Sakari Ailus > --- > drivers/leds/Kconfig

Re: [PATCH v10 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-10 Thread Bryan Wu
On Wed, Jun 10, 2015 at 10:57 AM, Bryan Wu wrote: > On Mon, Jun 8, 2015 at 2:02 AM, Jacek Anaszewski > wrote: >> This patch adds helper functions for registering/unregistering >> LED Flash class devices as V4L2 sub-devices. The functions should >> be called from the LED

Re: [PATCH v10 2/8] media: Add registration helpers for V4L2 flash sub-devices

2015-06-10 Thread Bryan Wu
b-devices is disabled in the kernel > config the functions' empty versions will be used. > Please go ahead with my Ack Acked-by: Bryan Wu > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Sakari Ailus > Cc: Hans Verkuil > --- > drivers/medi

Re: [PATCH v7] Documentation: leds: Add description of v4l2-flash sub-device

2015-05-04 Thread Bryan Wu
On Thu, Apr 30, 2015 at 3:34 AM, Jacek Anaszewski wrote: > This patch extends LED Flash class documention by > the description of interactions with v4l2-flash sub-device. > Thanks, applied -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Acked-by: Sakari

Re: [PATCH v7] leds: Add driver for AAT1290 flash LED controller

2015-05-04 Thread Bryan Wu
acek Anaszewski > Acked-by: Kyungmin Park > Acked-by: Sakari Ailus > Cc: Bryan Wu > Cc: Richard Purdie > --- > Fixed issue reported by 0-DAY kernel test infrastructure: > drivers/leds/leds-aat1290.c:443:3-8: No need to set .owner here. The core > will do it > Fix

Re: [PATCH v7] leds: Add support for max77693 mfd flash cell

2015-05-04 Thread Bryan Wu
leds can be triggered > externally or by software. > > Signed-off-by: Jacek Anaszewski > Signed-off-by: Andrzej Hajda > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie Reapplied. thanks. -Bryan > --- > Fixed issues reported by 0-DAY kernel test infrastructure:

Re: [PATCH v6 05/10] leds: Add driver for AAT1290 flash LED controller

2015-04-28 Thread Bryan Wu
2Cwire serial digital interface. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> Acked-by: Sakari Ailus >> Cc: Bryan Wu >> Cc: Richard Purdie > > Acked-by: Sakari Ailus > Applied, thanks, -Bryan > -- > Sakari Ailus > e-mail:

Re: [PATCH v6 04/10] DT: Add documentation for the Skyworks AAT1290

2015-04-28 Thread Bryan Wu
On Tue, Apr 28, 2015 at 12:18 AM, Jacek Anaszewski wrote: > This patch adds device tree binding documentation for > 1.5A Step-Up Current Regulator for Flash LEDs. > Applied, thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Acked-by: Sakari Ail

Re: [PATCH v6 03/10] leds: Add support for max77693 mfd flash cell

2015-04-28 Thread Bryan Wu
interface. Device supports up to two leds which can >> work in flash and torch mode. The leds can be triggered >> externally or by software. >> >> Signed-off-by: Jacek Anaszewski >> Signed-off-by: Andrzej Hajda >> Acked-by: Kyungmin Park >> Cc: B

Re: [PATCH v6 02/10] DT: Add documentation for the mfd Maxim max77693

2015-04-28 Thread Bryan Wu
gt;> Signed-off-by: Andrzej Hajda >> Acked-by: Kyungmin Park >> Acked-by: Sakari Ailus >> Cc: Lee Jones >> Cc: Chanwoo Choi >> Cc: Bryan Wu >> Cc: Richard Purdie >> Cc: devicet...@vger.kernel.org >> --- >> Documentation/devicetree/b

Re: [PATCH v6 01/10] leds: unify the location of led-trigger API

2015-04-28 Thread Bryan Wu
ggers.c with EXPORT_SYMBOL_GPL macro. The no-op definitions are > changed from macros to inline to match the style of the surrounding code. > > Signed-off-by: Jacek Anaszewski > Cc: Bryan Wu > Cc: Richard Purdie > Acked-by: Sakari Ailus Applied, thanks, -Bryan > -

Re: [PATCH v4 02/12] leds: unify the location of led-trigger API

2015-04-07 Thread Bryan Wu
ggers.c with EXPORT_SYMBOL_GPL macro. > Applied, thanks. -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Acked-by: Sakari Ailus > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/leds.h | 24 > include/linux/leds.h |

Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties

2015-04-07 Thread Bryan Wu
On Fri, Apr 3, 2015 at 1:37 PM, Pavel Machek wrote: > Hi! > >> >>+- flash-timeout-us : Timeout in microseconds after which the flash >> >>+ LED is turned off. If omitted this will default to >> >>the >> >>+maximum timeout allowed by the device. >> >> >> >> >> >

Re: [PATCH/RFC v13 02/13] dt-binding: leds: Add common LED DT bindings macros

2015-03-17 Thread Bryan Wu
On Thu, Mar 12, 2015 at 8:45 AM, Jacek Anaszewski wrote: > Add macros for defining boost mode and trigger type properties > of flash LED devices. > Applied, thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie

Re: [PATCH/RFC v12 04/19] dt-binding: leds: Add common LED DT bindings macros

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 11:56 PM, Jacek Anaszewski wrote: > On 03/04/2015 05:14 PM, Jacek Anaszewski wrote: >> >> Add macros for defining boost mode and trigger type properties >> of flash LED devices. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by

Re: [PATCH/RFC v12 03/19] Documentation: leds: Add description of LED Flash class extension

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > The documentation being added contains overall description of the > LED Flash Class and the related sysfs attributes. > Thanks, merged! -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan

Re: [PATCH/RFC v12 02/19] leds: flash: document sysfs interface

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > Add a documentation of LED Flash class specific sysfs attributes. > Thanks, merged! -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > Documentation

Re: [PATCH/RFC v12 01/19] leds: flash: Remove synchronized flash strobe feature

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > Synchronized flash strobe feature has been considered not fitting > for LED subsystem sysfs interface and thus is being removed. > OK, I will merge this. -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Pa

Re: [PATCH/RFC v10 02/19] Documentation: leds: Add description of LED Flash class extension

2015-01-26 Thread Bryan Wu
ss and the related sysfs attributes. >>> >>> Signed-off-by: Jacek Anaszewski >>> Acked-by: Kyungmin Park >>> Cc: Bryan Wu >>> Cc: Richard Purdie >> >> >>> +In order to enable support for flash LEDs CONFIG_LEDS_CLASS_FL

Re: [PATCH/RFC v10 01/19] leds: Add LED Flash class extension to the LED subsystem

2015-01-26 Thread Bryan Wu
ernel internal interface. When V4L2 Flash sub-device >> file is opened, the LED class device sysfs interface is made >> unavailable. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> Cc: Bryan Wu >> Cc: Richard Purdie > > Acke

Re: [PATCH/RFC v8 03/14] Documentation: leds: Add description of v4l2-flash sub-device

2014-12-05 Thread Bryan Wu
On Fri, Nov 28, 2014 at 1:17 AM, Jacek Anaszewski wrote: > This patch extends LED Flash class documention by > the description of interactions with v4l2-flash sub-device. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie &g

Re: [PATCH/RFC v8 02/14] Documentation: leds: Add description of LED Flash class extension

2014-12-05 Thread Bryan Wu
On Mon, Dec 1, 2014 at 5:58 AM, Jacek Anaszewski wrote: > Hi Pavel, > > On 12/01/2014 02:04 PM, Pavel Machek wrote: >> >> Hi! >> How are faults cleared? Should it be list of strings, instead of bitmask? We may want to add new fault modes in future... >>> >>> >>> Faults are cleared by rea

Re: [PATCH/RFC v7 3/3] Documentation: leds: Add description of LED Flash Class extension

2014-11-13 Thread Bryan Wu
On Wed, Nov 12, 2014 at 8:09 AM, Jacek Anaszewski wrote: > The documentation being added contains overall description of the > LED Flash Class and the related sysfs attributes. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu &g

Re: [PATCH/RFC v7 1/3] leds: Add support for setting brightness in a synchronous way

2014-11-13 Thread Bryan Wu
t_brightness is changed > to led_set_brightness_async and new led_set_brightness_sync API > is added. > Great, I do like this patch and just one pick coding style as below. Thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Rich

Re: [PATCH/RFC v6 0/2] LED / flash API integration - V4L2 Flash

2014-11-07 Thread Bryan Wu
On Mon, Sep 22, 2014 at 8:21 AM, Jacek Anaszewski wrote: > This patch set is the follow-up of the LED / flash API integration > series [1]. For clarity reasons the patchset has been split into > four subsets: > > - LED Flash Class > - V4L2 Flash Hi Jacek, For this series I think you'd better get

Re: [PATCH/RFC v6 1/3] leds: implement sysfs interface locking mechanism

2014-11-03 Thread Bryan Wu
On Mon, Oct 20, 2014 at 6:01 PM, Bryan Wu wrote: > On Mon, Sep 22, 2014 at 8:21 AM, Jacek Anaszewski > wrote: >> Add a mechanism for locking LED subsystem sysfs interface. >> This patch prepares ground for addition of LED Flash Class >> extension, whose API will be integr

Re: [PATCH/RFC v6 3/3] leds: Add LED Flash Class wrapper to LED subsystem

2014-11-03 Thread Bryan Wu
nterface is made > unavailable. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/Kconfig| 11 + > drivers/leds/Makefile |1 + > drivers/leds/led-class-flash.c

Re: [PATCH/RFC v6 2/3] leds: add API for setting torch brightness

2014-10-20 Thread Bryan Wu
Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c |9 +++-- > drivers/leds/led-core.c | 14 ++ > include/linux/leds.h | 21 + > 3 files change

Re: [PATCH/RFC v6 1/3] leds: implement sysfs interface locking mechanism

2014-10-20 Thread Bryan Wu
L2 Flash > sub-device control. > I'm good with this and will merge it soon. Thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c| 19 --- >

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-12 Thread Bryan Wu
On Fri, Sep 5, 2014 at 2:03 PM, Bryan Wu wrote: > On Wed, Aug 20, 2014 at 6:41 AM, Jacek Anaszewski > wrote: >> led_update_brightness helper function used to be exploited only locally >> in the led-class.c module, where its result was being passed to the >> brightness_s

Re: [PATCH/RFC v5 2/4] leds: implement sysfs interface locking mechanism

2014-09-11 Thread Bryan Wu
sh > sub-device control. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c| 23 --- > drivers/leds/led-core.c | 18 ++ > drivers/leds/led

Re: [PATCH/RFC v5 1/4] leds: Improve and export led_update_brightness

2014-09-05 Thread Bryan Wu
-Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > drivers/leds/led-class.c |6 -- > drivers/leds/led-core.c | 16 > include/linux/leds.h | 10 ++ > 3 files changed

Re: [PATCH/RFC v4 00/21] LED / flash API integration

2014-08-08 Thread Bryan Wu
On Thu, Aug 7, 2014 at 11:43 PM, Jacek Anaszewski wrote: > Hi Bryan, > > > On 07/16/2014 07:21 PM, Bryan Wu wrote: >> >> On Wed, Jul 16, 2014 at 10:19 AM, Bryan Wu wrote: >>> >>> On Fri, Jul 11, 2014 at 7:04 AM, Jacek Anaszewski >>> wrote: &

Re: [PATCH/RFC v4 00/21] LED / flash API integration

2014-07-16 Thread Bryan Wu
On Wed, Jul 16, 2014 at 10:19 AM, Bryan Wu wrote: > On Fri, Jul 11, 2014 at 7:04 AM, Jacek Anaszewski > wrote: >> This is is the fourth version of the patch series being a follow up >> of the discussion on Media summit 2013-10-23, related to the >> LED / flash API integra

Re: [PATCH/RFC v4 00/21] LED / flash API integration

2014-07-16 Thread Bryan Wu
On Fri, Jul 11, 2014 at 7:04 AM, Jacek Anaszewski wrote: > This is is the fourth version of the patch series being a follow up > of the discussion on Media summit 2013-10-23, related to the > LED / flash API integration (the notes from the discussion were > enclosed in the message [1], paragraph 5

Re: [PATCH/RFC v3 1/5] leds: Add sysfs and kernel internal API for flash LEDs

2014-04-25 Thread Bryan Wu
e here. Looks like the LED flash class interface binds to V4L2 Flash sub-device, then why we need to export sysfs for user space if the only user is V4L2 which can talk through kernel internal API here. > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu &g

Re: [PATCH/RFC v3 0/5] LED / flash API integration

2014-04-18 Thread Bryan Wu
On Fri, Apr 11, 2014 at 7:56 AM, Jacek Anaszewski wrote: > This is is the third version of the patch series being a follow up > of the discussion on Media summit 2013-10-23, related to the > LED / flash API integration (the notes from the discussion were > enclosed in the message [1], paragraph 5)

Re: [v2] media: soc-camera: OF cameras

2014-04-17 Thread Bryan Wu
On Mon, Apr 14, 2014 at 10:38 AM, Ben Dooks wrote: > On 14/04/14 18:14, Bryan Wu wrote: >> >> On Thu, Apr 10, 2014 at 2:18 PM, Guennadi Liakhovetski >> wrote: >>> >>> Hi Bryan, >>> >>> On Tue, 8 Apr 2014, Bryan Wu wrote: >>> &

Re: [v2] media: soc-camera: OF cameras

2014-04-14 Thread Bryan Wu
On Thu, Apr 10, 2014 at 2:18 PM, Guennadi Liakhovetski wrote: > Hi Bryan, > > On Tue, 8 Apr 2014, Bryan Wu wrote: > >> Thanks Josh, I think I will take you point and rework my patch again. >> But I need Guennadi's review firstly, Guennadi, could you please help &g

Re: [v2] media: soc-camera: OF cameras

2014-04-08 Thread Bryan Wu
Thanks Josh, I think I will take you point and rework my patch again. But I need Guennadi's review firstly, Guennadi, could you please help to review it? -Bryan On Fri, Mar 14, 2014 at 3:48 AM, Josh Wu wrote: > Hi, Brayn > > Sorry for the format of my email. I subscribe the linux-media maillist

Re: [PATCH v2] media: soc-camera: OF cameras

2014-03-07 Thread Bryan Wu
On Fri, Mar 7, 2014 at 3:10 AM, Ben Dooks wrote: > On 06/03/14 23:12, Bryan Wu wrote: >> >> On Mon, Feb 24, 2014 at 10:19 PM, Guennadi Liakhovetski >> wrote: >>> >>> Hi Bryan, >>> >>> On Mon, 24 Feb 2014, Bryan Wu wrote: >>> >

Re: [PATCH v2] media: soc-camera: OF cameras

2014-03-06 Thread Bryan Wu
On Mon, Feb 24, 2014 at 10:19 PM, Guennadi Liakhovetski wrote: > Hi Bryan, > > On Mon, 24 Feb 2014, Bryan Wu wrote: > >> On Tue, Feb 18, 2014 at 10:40 AM, Bryan Wu wrote: >> > On Wed, Feb 12, 2014 at 12:05 PM, Bryan Wu wrote: >> >> From: Guennadi Liak

Re: [PATCH v2] media: soc-camera: OF cameras

2014-02-24 Thread Bryan Wu
On Tue, Feb 18, 2014 at 10:40 AM, Bryan Wu wrote: > On Wed, Feb 12, 2014 at 12:05 PM, Bryan Wu wrote: >> From: Guennadi Liakhovetski >> >> With OF we aren't getting platform data any more. To minimise changes we >> create all the missing data oursel

Re: [PATCH v2] media: soc-camera: OF cameras

2014-02-18 Thread Bryan Wu
On Wed, Feb 12, 2014 at 12:05 PM, Bryan Wu wrote: > From: Guennadi Liakhovetski > > With OF we aren't getting platform data any more. To minimise changes we > create all the missing data ourselves, including compulsory struct > soc_camera_link objects. Host-client linking i

[PATCH v2] media: soc-camera: OF cameras

2014-02-12 Thread Bryan Wu
igned dynamically. OF probing reuses the V4L2 Async API which is used by async non-OF probing. Signed-off-by: Guennadi Liakhovetski Signed-off-by: Bryan Wu --- v2: - move to use V4L2 Async API - cleanup some coding style issue - allocate struct soc_camera_desc sdesc on stack - cleanup unbalanced

Re: [PATCH] media: soc-camera: support deferred probing of clients and OF cameras

2014-02-11 Thread Bryan Wu
On Tue, Feb 11, 2014 at 12:53 PM, Guennadi Liakhovetski wrote: > On Tue, 11 Feb 2014, Bryan Wu wrote: > >> On Mon, Feb 10, 2014 at 10:37 PM, Guennadi Liakhovetski >> wrote: >> > Hi Bryan, >> > >> > On Mon, 10 Feb 2014, Bryan Wu wrote: >&g

Re: [PATCH] media: soc-camera: support deferred probing of clients and OF cameras

2014-02-11 Thread Bryan Wu
On Mon, Feb 10, 2014 at 10:37 PM, Guennadi Liakhovetski wrote: > Hi Bryan, > > On Mon, 10 Feb 2014, Bryan Wu wrote: > >> On Sun, Feb 9, 2014 at 2:20 PM, Guennadi Liakhovetski >> wrote: >> > Hi Bryan, >> > >> > Thanks for reiterating this patch!

Re: [PATCH] media: soc-camera: support deferred probing of clients and OF cameras

2014-02-10 Thread Bryan Wu
On Sun, Feb 9, 2014 at 2:20 PM, Guennadi Liakhovetski wrote: > Hi Bryan, > > Thanks for reiterating this patch! > Sure, my pleasure. I basically assembled your patches together and change them to use latest V4L2 soc_camera API. > On Fri, 7 Feb 2014, Bryan Wu wrote: >

[PATCH] media: soc-camera: support deferred probing of clients and OF cameras

2014-02-07 Thread Bryan Wu
e assigned dynamically. Signed-off-by: Guennadi Liakhovetski Signed-off-by: Bryan Wu --- drivers/media/platform/soc_camera/soc_camera.c | 396 - include/media/soc_camera.h | 9 + 2 files changed, 399 insertions(+), 6 deletions(-) diff --git a/drivers/medi

Re: A question about DT support for soc_camera

2014-01-21 Thread Bryan Wu
On Thu, Jan 16, 2014 at 3:04 PM, Guennadi Liakhovetski wrote: > Hi Bryan, > > On Wed, 15 Jan 2014, Bryan Wu wrote: > >> Hi Guennadi, >> >> I'm working on upstream our Tegra soc_camera host driver. But found >> the soc_camera framework is not fully supp

A question about DT support for soc_camera

2014-01-15 Thread Bryan Wu
Hi Guennadi, I'm working on upstream our Tegra soc_camera host driver. But found the soc_camera framework is not fully supporting Device Tree probing, am I wrong about that? While in upstream Tegra kernel, we only support DT probing and there is no board files. Current soc_camera framework needs

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-21 Thread Bryan Wu
On Sat, Oct 19, 2013 at 1:25 PM, Ricardo Ribalda Delgado wrote: > Please find the multi selection api proposal attached. > > See you in Edinburgh. > > > Thanks > > On Sat, Oct 19, 2013 at 2:17 AM, Bryan Wu wrote: >> On Wed, Oct 16, 2013 at 5:12 PM, Andy Walls wrote

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-18 Thread Bryan Wu
On Wed, Oct 16, 2013 at 5:12 PM, Andy Walls wrote: > On Thu, 2013-10-17 at 08:36 +0900, Milo Kim wrote: > >> > That's current solution, we plan to unify this two API since those >> > chip are basically LED. >> > >> >> On the other hands, LM3642 has an indicator mode with flash/torch. >> >> Then, i

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-16 Thread Bryan Wu
On Wed, Oct 16, 2013 at 4:54 PM, Bryan Wu wrote: > On Wed, Oct 16, 2013 at 4:36 PM, Milo Kim wrote: >> >> Hi Bryan, >> >> >> On 10/17/2013 02:17 AM, Bryan Wu wrote: >>> >>> On Tue, Oct 15, 2013 at 6:49 PM, Milo Kim wrote: >>>> >&

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-16 Thread Bryan Wu
On Wed, Oct 16, 2013 at 4:36 PM, Milo Kim wrote: > > Hi Bryan, > > > On 10/17/2013 02:17 AM, Bryan Wu wrote: >> >> On Tue, Oct 15, 2013 at 6:49 PM, Milo Kim wrote: >>> >>> Hi Bryan, >>> >>> >>> On 10/16/2013 03:37 AM,

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-16 Thread Bryan Wu
On Tue, Oct 15, 2013 at 6:49 PM, Milo Kim wrote: > Hi Bryan, > > > On 10/16/2013 03:37 AM, Bryan Wu wrote: >> >> On Fri, Oct 11, 2013 at 12:38 AM, Laurent Pinchart >> wrote: >>> >>> Hi Bryan, >>> >>> On Thursday 10 October 2013

Re: [media-workshop] V2: Agenda for the Edinburgh mini-summit

2013-10-15 Thread Bryan Wu
On Tue, Oct 15, 2013 at 11:50 AM, Laurent Pinchart wrote: > Hi Bryan, > > On Tuesday 15 October 2013 11:37:23 Bryan Wu wrote: >> On Fri, Oct 11, 2013 at 12:38 AM, Laurent Pinchart wrote: >> > On Thursday 10 October 2013 17:02:18 Bryan Wu wrote: >> >> On

  1   2   >