When TI CAL was introduce as another driver under platform/ti-vpe
adding a second entry into the ti-vpe directory in the platform
Makefile caused issues during parallel build.
Signed-off-by: Benoit Parrot
Signed-off-by: Jyri Sarha
---
drivers/media/platform/Makefile | 4 +---
1 file changed, 1
y.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 56f60dbea15c..0e9cb0319a92 100644
--- a/drivers/medi
A few NULL pointer checks were missing.
Add check with appropriate return code.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti
R (no poll): OK (Not Supported)
test USERPTR (select): OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total for vpe device /dev/video0: 51, Succeeded: 51, Failed: 0, Warnings: 2
======
Benoit Parrot (18):
media: ti-vpe: Fix
invalid or
not supported.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpe.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index
Because the driver fails to properly check the 'num_planes' values for
proper ranges it ends up accessing out of bound data causing the kernel
panic.
Since this driver only handle single or dual plane pixel format, make
sure the provided value does not exceed 2 planes.
Signed-off-by: Ben
ad of hard-coding an offset which might change over time we need
to use a lookup helper instead so we know the default will always be what
we intended.
Signed-off-by: Benoit Parrot
Reviewed-by: Tomi Valkeinen
---
drivers/media/platform/ti-vpe/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
explicit casts
>
For:
drivers/media/platform/am437x/am437x-vpfe_regs.h
drivers/media/platform/ti-vpe/vpe_regs.h
Reviewed-by: Benoit Parrot
-struct vpfe_pixel_format {
> - struct v4l2_fmtdesc fmtdesc;
> - /* bytes per pixel */
> - int bpp;
> -};
> -
Looks fine to me.
Acked-by: Benoit Parrot
> struct vpfe_std_info {
> int active_pixels;
> int active_lines;
tructures since those are
> no longer needed.
>
> Signed-off-by: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Prabhakar Lad
> Cc: Sylwester Nawrocki
> Cc: Jonathan Corbet
> Cc: Jacopo Mondi
> Cc: Benoit Parrot
For am437x-vpfe.c and ti-vpe/vpe.c
Acked-by: Benoit Parro
Acked-by: Benoit Parrot
Hans Verkuil wrote on Wed [2019-Jun-26 09:44:20
+0200]:
> Instead of filling in the struct v4l2_capability device_caps
> field, fill in the struct video_device device_caps field.
>
> That way the V4L2 core knows what the capabilities of the
> v
Sakari Ailus wrote on Tue [2019-Mar-05 22:48:44
+0200]:
> On Tue, Mar 05, 2019 at 11:38:42AM -0600, Benoit Parrot wrote:
> > Sakari Ailus wrote on Tue [2019-Mar-05
> > 18:32:40 +0200]:
> > > Hi Benoit,
> > >
> > > On Tue, Mar 05, 2019 at 08:34:09AM
Sakari Ailus wrote on Tue [2019-Mar-05 18:32:40
+0200]:
> Hi Benoit,
>
> On Tue, Mar 05, 2019 at 08:34:09AM -0600, Benoit Parrot wrote:
> > Sakari,
> >
> > Thank you for the patch.
> >
> > Sakari Ailus wrote on Tue [2019-Mar-05
> > 16:02:24
Sakari,
Thank you for the patch.
Sakari Ailus wrote on Tue [2019-Mar-05 16:02:24
+0200]:
> ti-vpe driver parsed the remote endpoints for properties but ignored the
> local ones. Fix this by parsing the local endpoint properties instead.
I am not sure I understand the logic here. For CSI2 sens
Maxime Ripard wrote on Fri [2019-Feb-22 15:39:59
+0100]:
> On Thu, Feb 21, 2019 at 10:20:20AM -0600, Benoit Parrot wrote:
> > Hi Maxime,
> >
> > A couple of questions,
> >
> > Maxime Ripard wrote on Thu [2018-Oct-11
> > 04:21:00 -0500]:
> > &g
Hi Maxime,
A couple of questions,
Maxime Ripard wrote on Thu [2018-Oct-11 04:21:00
-0500]:
> The clock rate, while hardcoded until now, is actually a function of the
> resolution, framerate and bytes per pixel. Now that we have an algorithm to
> adjust our clock rate, we can select it dynamical
Hi Rob,
For ti-vpe/cal.c,
Reviewed-by: Benoit Parrot
Regards,
Benoit
Rob Herring wrote on Wed [2018-Dec-05 13:50:29 -0600]:
> Convert string compares of DT node names to use of_node_name_eq helper
> instead. This removes direct access to the node name pointer.
>
> Cc: Kyungmi
Acked-by: Benoit Parrot
Maxime Ripard wrote on Tue [2018-Apr-24 14:26:59
+0200]:
> The Cadence MIPI-CSI2 TX controller is a CSI2 bridge that supports up to 4
> video streams and can output on up to 4 CSI-2 lanes, depending on the
> hardware implementation.
>
> It can operate w
Acked-by: Benoit Parrot
Maxime Ripard wrote on Tue [2018-Apr-24 14:27:00
+0200]:
> The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used
> as a bridge between pixel interfaces and a CSI-2 bus.
>
> It supports operating with an internal or external D-PHY,
ule will be
> + called cdns-csi2rx.
> +
> +endif
> diff --git a/drivers/media/platform/cadence/Makefile
> b/drivers/media/platform/cadence/Makefile
> new file mode 100644
> index ..99a4086b7448
> --- /dev/null
> +++ b/drivers/media/platform/cadence/Makefil
Maxime,
Thanks you for the patch,
Maxime Ripard wrote on Thu [2018-Mar-01 12:30:49
+0100]:
> The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used
> as a bridge between pixel interfaces and a CSI-2 bus.
>
> It supports operating with an internal or external D-PHY, with up t
Maxime,
Thank you for the patch.
Maxime Ripard wrote on Thu [2018-Feb-15 14:33:35
+0100]:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or external D-PHY, with up to 4 lanes,
Maxime,
Thank you for the patch.
Maxime Ripard wrote on Fri [2018-Jan-19
09:15:47 +0100]:
> The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used
> as a bridge between pixel interfaces and a CSI-2 bus.
>
> It supports operating with an internal or external D-PHY, with up to
Maxime,
Thank you for the patch.
Maxime Ripard wrote on Fri [2018-Jan-19
09:13:57 +0100]:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or external D-PHY, with up to 4 lanes,
For am437x/am437x-vpfe.c & ti-vpe/cal.c
Acked-by: Benoit Parrot
Mauro Carvalho Chehab wrote on Mon [2017-Dec-18
17:53:57 -0200]:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match crit
Rob Herring wrote on Tue [2017-Oct-17 16:00:51 -0500]:
> On Thu, Oct 12, 2017 at 02:27:17PM -0500, Benoit Parrot wrote:
> > Device Tree bindings for the Video Processing Engine (VPE) driver.
> >
> > Signed-off-by: Benoit Parrot
> > ---
> > Documentation/dev
Tony Lindgren wrote on Fri [2017-Oct-13 10:05:13 -0700]:
> * Benoit Parrot [171012 12:28]:
> > +static struct omap_hwmod_class_sysconfig dra7xx_vpe_sysc = {
> > + .sysc_offs = 0x0010,
> > + .sysc_flags = (SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE
Tony Lindgren wrote on Fri [2017-Oct-13 10:01:13 -0700]:
> * Benoit Parrot [171012 12:29]:
> > HWSUP on this domain is only working when VIP1 probes.
> > If only VIP2 on DRA74x or CAL on DRA72x probes the domain does
> > not get enabled. This might indicates an issue in
Tony Lindgren wrote on Fri [2017-Oct-13 09:56:54 -0700]:
> * Benoit Parrot [171012 12:28]:
> > This patch adds the required hwmod nodes to support the Camera
> > Adaptation Layer (CAL) for the DRA72 family of devices.
> ...
>
> > +static struct omap_hwmod_clas
Tony Lindgren wrote on Fri [2017-Oct-13 09:54:09 -0700]:
> * Benoit Parrot [171012 12:29]:
> > This patch adds the required dtsi node to support the Camera
> > Adaptation Layer (CAL) for the DRA72 family of devices.
> >
> > - Added CAL entry in dra72x.dtsi.
> >
Hans,
Just to confirm that I will be attending the media mini-summit.
Regards,
Benoit
Hans Verkuil wrote on Fri [2017-Oct-13 10:02:53 +0200]:
> Hi all,
>
> We are organizing a media mini-summit on Friday October 27 in Prague,
> co-located
> with the ELCE conference:
>
> http://events.linuxf
Device Tree bindings for the Video Processing Engine (VPE) driver.
Signed-off-by: Benoit Parrot
---
Documentation/devicetree/bindings/media/ti-vpe.txt | 41 ++
1 file changed, 41 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/ti-vpe.txt
diff --git
This patch series adds the needed HWMOD and DTSI nodes
for the CAL and VPE modules.
We also document the VPE DT bindings.
Benoit Parrot (6):
ARM: dts: DRA72: Add CAL dtsi node
ARM: DRA7: hwmod: Add CAL nodes
ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only
dt-bindings: media: ti-vpe
support standby mode per se hwmod would not
enabled the functional/interface clock if module is not a master.
Hence the SWSUP mode flags ifor SIDLE ans MSTANDBY are also enabled.
This ensure that i/f clocks are available when CAL is enabled.
Signed-off-by: Benoit Parrot
---
arch/arm/mach-omap2
Add the necessary node and configuration data for the VPE (Video
Processing Engine) hardware block on DRA7x.
The corresponding driver for this entry is in
drivers/media/platform/ti-vpe/vpe.c.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra7.dtsi | 26 ++
1 file
This patch adds the required dtsi node to support the Camera
Adaptation Layer (CAL) for the DRA72 family of devices.
- Added CAL entry in dra72x.dtsi.
Signed-off-by: Benoit Parrot
---
arch/arm/boot/dts/dra72x.dtsi | 31 +++
1 file changed, 31 insertions(+)
diff
HWSUP on this domain is only working when VIP1 probes.
If only VIP2 on DRA74x or CAL on DRA72x probes the domain does
not get enabled. This might indicates an issue in the HW Auto
state-machine for this domain.
Work around is to set the CAM domain to use SWSUP only.
Signed-off-by: Benoit Parrot
were set to reflect this fact and make sure that
both are software supervised (SWSUSP).
Signed-off-by: Benoit Parrot
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
b/arch
Hi Maxime,
Maxime Ripard wrote on Wed [2017-Oct-11
13:55:44 +0200]:
> Hi Benoit,
>
> On Fri, Sep 29, 2017 at 06:21:25PM +0000, Benoit Parrot wrote:
> > > +struct csi2tx_priv {
> > > + struct device *dev;
> > > + atomic_t
Hi Maxime,
Maxime Ripard wrote on Wed [2017-Oct-11
11:24:09 +0200]:
> Hi Benoit,
>
> On Fri, Sep 29, 2017 at 05:27:09PM +0000, Benoit Parrot wrote:
> > > +static int csi2rx_get_resources(struct csi2rx_priv *csi2rx,
> > > + s
Maxime,
Thank you for the patch.
Maxime Ripard wrote on Fri [2017-Sep-22
13:47:03 +0200]:
> The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used
> as a bridge between pixel interfaces and a CSI-2 bus.
>
> It supports operating with an internal or external D-PHY, with up to
Maxime Ripard wrote on Fri [2017-Sep-22
12:08:23 +0200]:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or external D-PHY, with up to 4 lanes,
> or without any D-PHY. The curren
Benoit Parrot wrote on Tue [2017-Sep-12 13:23:39 -0500]:
> > +static int csi2rx_start(struct csi2rx_priv *csi2rx)
> > +{
> > + unsigned int i;
> > + u32 reg;
> > + int ret;
> > +
> > + /*
> > +* We're not the first users, ther
Maxime,
Thanks for the patch.
Maxime Ripard wrote on Mon [2017-Sep-04
15:03:35 +0200]:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or external D-PHY, with up to 4 lanes,
>
indings/media/cdns-csi2rx.txt
>
Acked-by: Benoit Parrot
Maxime Ripard wrote on Thu [2017-Jul-20
11:23:02 +0200]:
> The Cadence CSI-2 RX Controller is an hardware block meant to be used as a
> bridge between a CSI-2 bus and pixel grabbers.
>
> It supports operating with internal or external D-PHY, with up to 4 lanes,
> or without any D-PHY. The curren
Acked-by: Benoit Parrot
Kuninori Morimoto wrote on Wed [2017-Jun-28
00:33:00 +]:
>
> From: Kuninori Morimoto
>
> Now, we can use of_graph_get_remote_endpoint(). Let's use it.
>
> Signed-off-by: Kuninori Morimoto
> ---
> based on 4c9c3d595f1bad021cc126d2
apture.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Acked-by: Benoit Parrot
Hans, Mauro,
Ping.
Regards,
Benoit
Tomi Valkeinen wrote on Fri [2017-Feb-17 11:45:41
+0200]:
> On 13/02/17 15:06, Benoit Parrot wrote:
> > This patch series enables user specified buffer stride to be used
> > instead of always forcing the stride from the driver side.
> >
For: ov2569.c, am437x/am437x-vpfe.c and ti-cal/cal.c:
Acked-by: Benoit Parrot
Sakari Ailus wrote on Tue [2017-Feb-14 09:12:32
+0200]:
> Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs.
>
> Existing OF matching continues to be supported. omap3isp and smiapp
Tomi Valkeinen wrote on Wed [2017-Feb-15 13:22:42
+0200]:
> Hi,
>
> On 13/02/17 15:06, Benoit Parrot wrote:
> > Bytesperline/stride was always overwritten by VPE to the most
> > adequate value based on needed alignment.
> >
> > However in order to make us
Sakari Ailus wrote on Mon [2017-Feb-13 15:28:13
+0200]:
> Switch users of the v4l2_of_ APIs to the more generic v4l2_fwnode_ APIs.
>
> Existing OF matching continues to be supported. omap3isp and smiapp
> drivers are converted to fwnode matching as well.
>
> Signed-off-by: Sakari Ailus
> ---
>
This patch series enables user specified buffer stride to be used
instead of always forcing the stride from the driver side.
Benoit Parrot (2):
media: ti-vpe: vpdma: add support for user specified stride
media: ti-vpe: vpe: allow use of user specified stride
drivers/media/platform/ti-vpe
This patch introduce the needed vpdma API changes to support
user space specified stride instead of forcing a driver calculated
one.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpdma.c | 14 --
drivers/media/platform/ti-vpe/vpdma.h | 6 +++---
drivers/media
provided one when it is larger than the calculated one.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
Laurent Pinchart wrote on Tue [2017-Feb-07
12:26:32 +0200]:
> Hi Steve,
>
> On Monday 06 Feb 2017 15:10:46 Steve Longerbeam wrote:
> > On 02/06/2017 02:33 PM, Laurent Pinchart wrote:
> > > On Monday 06 Feb 2017 10:50:22 Hans Verkuil wrote:
> > >> On 02/05/2017 04:48 PM, Laurent Pinchart wrote:
>
Dan,
Thanks for the patch.
Acked-by: Benoit Parrot
Dan Carpenter wrote on Sat [2016-Nov-26 00:28:34
+0300]:
> The check assumes that we end on zero but actually we end on -1. Change
> the post-op to a pre-op so that we do end on zero. Techinically now we
> only loop 499 times i
From: Harinarayan Bhatta
Increasing max buffer height and width to allow for padded buffers.
Signed-off-by: Harinarayan Bhatta
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 4 ++--
1 file changed, 2 insertions
line average de-interlacing for first 2 frames
Benoit Parrot (16):
media: ti-vpe: vpdma: Make vpdma library into its own module
media: ti-vpe: vpdma: Add multi-instance and multi-client support
media: ti-vpe: vpdma: Add helper to set a background color
media: ti-vpe: vpdma: Fix bus error
total of N frames.
Signed-off-by: Archit Taneja
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 33 +++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b
The VPDMA (Video Port DMA) as found in devices such as DRA7xx is
used for both the Video Processing Engine (VPE) and the Video Input
Port (VIP).
In preparation for this we need to turn vpdma into its own
kernel module.
Signed-off-by: Benoit Parrot
---
drivers/media/platform/Kconfig
post is also called from
interrupt context.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c | 4
drivers/media/platform/ti-vpe/vpdma.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/media/platfo
lists.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 125 +---
1 file changed, 103 insertions(+), 22 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media
support for multi instances and multiple
clients has been added to VPDMA. Needed modification to the existing
helper functions were then reflected to VPE.
Multi-clients registers offset have also been added in preparation.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media
configuration, it's better
to separate the config_mode setting and line_mode setting. Call the
new "set_line_modes" functions only when actually loading the mmrs.
This makes sure that no non-running job will write to the registers
directly.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoi
Add a helper to set the background color during vpdma transfer.
This is needed when VPDMA is generating 32 bits RGB format
to have the Alpha channel set to an appropriate value.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c | 10
From: Harinarayan Bhatta
Free vpdma buffers in vpe_release. Otherwise it was generating random
backtrace.
Signed-off-by: Harinarayan Bhatta
Signed-off-by: Somnath Mukherjee
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti
when the passed type is invalid.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/
On DRA7 since l3_noc event are being reported it was found that
when the write descriptor was being written it was consistently
causing bus error events.
The write address was improperly programmed.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe
list per client and let it use it. This way, the
list numbers need not be hard-coded into the driver.
Add support for allocating hwlist and maintain them with a priv data.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vp
x27;t need extra source buffers. Shift all the
source buffers after each iteration and remove the oldest buffer.
Also, with this removes the constraint of pre buffering 3 buffers before
call to STREAMON in case of de-interlacing.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit P
ld make
sure that the context is re-initialized before it is being used by
the driver.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/ti-vpe/v
.
Make use of different max width & height sets for different
of capture module (i.e. slices).
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c | 27
drivers/media/platform/ti-vpe/vpd
The VPDMA RGB data type definition have been updated
to match with Errata i839.
But some of the ARGB definition appeared to be wrong
in the document also. As they would yield RGBA instead.
They have been corrected based on experimentation.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
complete and also schedule next descriptor list.
Fix this by _actually_ handling the IRQ only when ListComplete IRQ
occurs.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 9 +
1 file changed, 9 insertions
ti_vpe module currently does not get loaded automatically.
Added MODULE_DEVICE_TABLE hint to the driver to assist.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
Reviewed-by: Javier Martinez Canillas
---
drivers/media/platform/ti-vpe/vpe.c | 1 +
1 file changed, 1 insertion(+)
diff
make alpha component full when the dst
format is of RGB color space.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers
). It was decided
to explicitly label them CR to remove any confusion.
Bear in mind that the type label refer to the memory
packed order (LSB - MSB).
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c | 18 ++
drivers/media/pla
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/sc.c | 9 -
drivers/media/platform/ti-vpe/sc.h | 3 ---
2 files changed, 12 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/sc.c
b/drivers/media/platform/ti-vpe/sc.c
index f82d1c7f667f
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 15e846b95719..608d11344147 100644
--- a/drivers/media/platform/ti-vpe/vpe.c
In preparation to add scaler support into VIP we need to
turn sc.c into its own kernel module.
Add support for multiple SC memory block as VIP contains
2 scaler instances.
This is done by passing the resource name to sc_create() and
modify the vpe invocation accordingly.
Signed-off-by: Benoit
e race condition
is avoided.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c | 17 +
drivers/media/platform/ti-vpe/vpdma.h | 2 +-
drivers/media/platform/ti-vpe/vpe.c | 8
3 files change
which
abort_channel descriptors should be posted. It is driver's responsibility
to post for all the channels or the channels which were used in the last
context.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c
Since there might be more then one instance it is better to
show the base address when dumping registers to help
with debugging.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/sc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media
apping the buffer, driver has to take care of
WriteBack and invalidation of the cache so that all the
coherency is maintained from both directions.
Use DMA_BIDIRECTIONAL to maintain coherency between CPU and VPDMA.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Ha
uffer back otherwise the vb2 framework
will issue kernel WARN messages.
In this case we also give an error message.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/sc.h | 6
drivers/media/platform/ti-vpe/vpe.c | 71
In preparation to add colorspace conversion support to VIP,
we need to turn csc.c into its own kernel module.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/Kconfig | 4
drivers/media/platform/ti-vpe/Makefile | 4 +++-
drivers/media/platform/ti
.
RAW16 handles from 9 to 16 bits.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpdma.c | 23 +++
drivers/media/platform/ti-vpe/vpdma.h | 6 ++
2 files changed, 29 insertions(+)
diff --git a/drivers/media/platform/ti-vpe/vpdma.c
b
: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 58 ++---
1 file changed, 48 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 1e4d614bd3b6..0626593a8b22
Since there might be more then one instance it is better to
show the base address when dumping registers to help
with debugging.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/csc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media
Allow VPE to be able to export DMA buffer.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/platform/ti-vpe/vpe.c
index 608d11344147..1d780ac7ff82
upon aborting a
conversion.
Make sure every vb2 buffers is properly handled in all cases.
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform/ti-vpe/vpe.c | 62 +++--
1 file changed, 60 insertions(+), 2 deletions(-)
diff --git a/drivers
From: Nikhil Devshatwar
VPDMA IRQs are registered for multiple lists
When clearing an IRQ for a list interrupt, all the
IRQs for the individual lists are to be cleared separately.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
Acked-by: Hans Verkuil
---
drivers/media/platform
Hans Verkuil wrote on Mon [2016-Oct-17 16:14:35 +0200]:
> On 09/28/2016 11:20 PM, Benoit Parrot wrote:
> > From: Archit Taneja
> >
> > For n input fields, the VPE de-interlacer creates n - 2 progressive frames.
>
> That's confusing. I think you mean '(n
Hans,
Thank you for taking the time to review my patches.
I'll update the patch set relating to your comments
and submit a v2 shortly.
Regards
Benoit
Hans Verkuil wrote on Mon [2016-Oct-17 16:35:01 +0200]:
> On 09/28/2016 11:16 PM, Benoit Parrot wrote:
> > This patch series i
Hans Verkuil wrote on Mon [2016-Oct-17 16:17:15 +0200]:
> On 09/28/2016 11:20 PM, Benoit Parrot wrote:
> > From: Nikhil Devshatwar
> >
> > Current VPE driver does not start the job until all the buffers for
> > a transaction are not queued. When running in multiple
Hans,
Thanks for the review.
Hans Verkuil wrote on Mon [2016-Oct-17 16:08:55 +0200]:
> On 09/28/2016 11:16 PM, Benoit Parrot wrote:
> > The VPDMA (Video Port DMA) as found in devices such as DRA7xx is
> > used for both the Video Processing Engine (VPE) and the Video Inpu
Acked-by: Benoit Parrot
Mauro Carvalho Chehab wrote on Fri [2016-Oct-14
17:20:17 -0300]:
> Due to the 80-cols checkpatch warnings, several strings
> were broken into multiple lines. This is not considered
> a good practice anymore, as it makes harder to grep for
> strings at the
ld make
sure that the context is re-initialized before it is being used by
the driver.
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b/drivers/media/
From: Harinarayan Bhatta
Free vpdma buffers in vpe_release. Otherwise it was generating random
backtrace.
Signed-off-by: Harinarayan Bhatta
Signed-off-by: Somnath Mukherjee
Signed-off-by: Nikhil Devshatwar
Signed-off-by: Benoit Parrot
---
drivers/media/platform/ti-vpe/vpe.c | 3 +++
1 file
1 - 100 of 182 matches
Mail list logo
