Re: [PATCH 1/7] media: aspeed: fix a kernel warning on clk control

2019-05-09 Thread Benjamin Herrenschmidt
On Thu, 2019-05-09 at 16:51 -0700, Jae Hyun Yoo wrote: > On 5/9/2019 4:19 PM, Benjamin Herrenschmidt wrote: > > On Thu, 2019-05-09 at 10:19 -0700, Jae Hyun Yoo wrote: > > > > > > Okay. Probably I need to add one another patch in this series to > > >

Re: [PATCH 1/7] media: aspeed: fix a kernel warning on clk control

2019-05-09 Thread Benjamin Herrenschmidt
On Thu, 2019-05-09 at 10:19 -0700, Jae Hyun Yoo wrote: > > Okay. Probably I need to add one another patch in this series to address > what you pointed out. > > I have one question. I reviewed again all bitops in this driver and > checked that some bitops are protected by a spinlock and some other

Re: [PATCH 1/7] media: aspeed: fix a kernel warning on clk control

2019-05-08 Thread Benjamin Herrenschmidt
On Wed, 2019-05-08 at 18:19 -0700, Jae Hyun Yoo wrote: > I changed that from a bool because the maintainer of this code, Eddie > doesn't like adding of an additional flag. I'll change it back with > codes in the first submit: > https://www.spinics.net/lists/linux-media/msg148955.html > > Eddie, >

Re: [PATCH 1/7] media: aspeed: fix a kernel warning on clk control

2019-05-08 Thread Benjamin Herrenschmidt
On Wed, 2019-05-08 at 15:19 -0700, Jae Hyun Yoo wrote: > On 5/7/2019 11:31 PM, Benjamin Herrenschmidt wrote: > > On Thu, 2019-05-02 at 12:13 -0700, Jae Hyun Yoo wrote: > > > Video engine clock control functions in the Aspeed video engine > > > driver are being called fr

Re: [PATCH 1/7] media: aspeed: fix a kernel warning on clk control

2019-05-07 Thread Benjamin Herrenschmidt
On Thu, 2019-05-02 at 12:13 -0700, Jae Hyun Yoo wrote: > Video engine clock control functions in the Aspeed video engine > driver are being called from multiple context without any > protection so video clocks can be double disabled and eventually > it causes a kernel warning with stack dump printi