Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

2017-03-07 Thread Arend Van Spriel
On 7-3-2017 10:44, Kalle Valo wrote: > Arnd Bergmann writes: > >> On Mon, Mar 6, 2017 at 5:19 PM, Kalle Valo wrote: >>> Arend Van Spriel writes: >>> >>>> On 2-3-2017 17:38, Arnd Bergmann wrote: >>>>> With KASAN and a couple of o

Re: [PATCH 07/26] brcmsmac: reduce stack size with KASAN

2017-03-06 Thread Arend Van Spriel
On 6-3-2017 11:38, Arnd Bergmann wrote: > On Mon, Mar 6, 2017 at 10:16 AM, Arend Van Spriel > wrote: >> On 2-3-2017 17:38, Arnd Bergmann wrote: >>> The wlc_phy_table_write_nphy/wlc_phy_table_read_nphy functions always put >>> an object >>> on the stack,

Re: [PATCH 10/26] brcmsmac: reindent split functions

2017-03-06 Thread Arend Van Spriel
tespace are intended here. Acked-by: Arend van Spriel > Signed-off-by: Arnd Bergmann > --- > .../broadcom/brcm80211/brcmsmac/phy/phy_n.c| 1507 > +--- > 1 file changed, 697 insertions(+), 810 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/b

Re: [PATCH 08/26] brcmsmac: make some local variables 'static const' to reduce stack size

2017-03-06 Thread Arend Van Spriel
brcmsmac/phy/phy_n.c:17138:1: warning: the frame size of > 2864 bytes is larger than 2048 bytes [-Wframe-larger-than=] > > Here, I'm reducing the stack size by marking as many local variables as > 'static const' as I can without changing the actual code. Acked-by: A

Re: [PATCH 09/26] brcmsmac: split up wlc_phy_workarounds_nphy

2017-03-06 Thread Arend Van Spriel
me. > > I'm leaving the original indentation to make the review easier. Thanks ;-) Acked-by: Arend van Spriel > Signed-off-by: Arnd Bergmann > --- > .../broadcom/brcm80211/brcmsmac/phy/phy_n.c| 178 > - > 1 file changed, 104 insertions

Re: [PATCH 07/26] brcmsmac: reduce stack size with KASAN

2017-03-06 Thread Arend Van Spriel
On 2-3-2017 17:38, Arnd Bergmann wrote: > The wlc_phy_table_write_nphy/wlc_phy_table_read_nphy functions always put an > object > on the stack, which will each require a redzone with KASAN and lead to > possible > stack overflow: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:

[PATCH] media: uvc: add support for Toshiba FHD Webcam

2014-10-28 Thread Arend van Spriel
The webcam is identified as Toshiba webcam although it seems a module from Chicony Electronics. Not sure about the model so just refering to it as Toshiba webcam that is in Portege z30 laptop. Signed-off-by: Arend van Spriel --- drivers/media/usb/uvc/uvc_driver.c | 8 1 file changed, 8

Re: [PATCH v2 1/9] dma-buf: move to drivers/dma-buf

2014-07-01 Thread Arend van Spriel
On 01-07-14 12:57, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst It would help to use '-M' option with format-patch for this kind of rework. Regards, Arend > --- > Documentation/DocBook/device-drivers.tmpl |3 > MAINTAINERS |4 > drivers/Ma

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Arend van Spriel
On 11/30/2012 09:25 PM, Luis R. Rodriguez wrote: > On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez > wrote: >> On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel >> wrote: >>> So what is the rationale here. During mainlining our drivers we had to >>> re

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Arend van Spriel
On 11/29/2012 09:45 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Turns out a few drivers have strayed away from using the > spinlock_t typedef and decided to use struct spinlock > directly. This series converts these drivers to use > spinlock_t. Each change has been compile tested