Re: hdpvr.ko kernel 5.3-rc6

2019-09-04 Thread Scott Doty
On 9/4/19 11:13 AM, Scott Doty wrote: > > On 9/3/19 1:34 AM, Hans Verkuil wrote: >> >> Never mind, hdpvr uses read(), not streaming I/O. Of course this >> doesn't work... >> >> Just plain 'cat /dev/videoX >x.mpg' will do. >> >> > > Okay, tried that, it produces data that vlc can then play back. >

cron job: media_tree daily build: WARNINGS

2019-09-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Sep 5 05:00:13 CEST 2019 media-tree git hash:20a438d53fd9d12a894161bc56cbeab7a9993c39 media_build gi

Re: [PATCH 7/8] media: cedrus: Add support for holding capture buffer

2019-09-04 Thread Jernej Škrabec
Dne četrtek, 29. avgust 2019 ob 13:23:29 CEST je Hans Verkuil napisal(a): > On 8/22/19 9:44 PM, Jernej Skrabec wrote: > > When frame contains multiple slices and driver works in slice mode, it's > > more efficient to hold capture buffer in queue until all slices of a > > same frame are decoded. > >

Re: [PATCH] media: meson: Add NULL check after the call to kmalloc()

2019-09-04 Thread Austin Kim
2019년 9월 4일 (수) 오후 5:43, Rasmus Villemoes 님이 작성: > > On 04/09/2019 10.22, Austin Kim wrote: > > If the kmalloc() return NULL, the NULL pointer dereference will occur. > > new_ts->ts = ts; > > > > Add exception check after the call to kmalloc() is made. > > > > Signed-off-by: Austin Kim > > -

Re: [PATCH] media: meson: Add NULL check after the call to kmalloc()

2019-09-04 Thread Austin Kim
2019년 9월 4일 (수) 오후 5:45, Greg KH 님이 작성: > > On Wed, Sep 04, 2019 at 05:22:32PM +0900, Austin Kim wrote: > > If the kmalloc() return NULL, the NULL pointer dereference will occur. > > new_ts->ts = ts; > > > > Add exception check after the call to kmalloc() is made. > > > > Signed-off-by: Austi

[PATCH v3 1/6] rcar-vin: Fix incorrect return statement in rvin_try_format()

2019-09-04 Thread Niklas Söderlund
While refactoring code the return statement became corrupted, fix it by returning the correct return code. Reported-by: Kieran Bingham Fixes: 897e371389e77514 ("media: rcar-vin: simplify how formats are set and reset" Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- * Change

[PATCH v3 0/6] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

2019-09-04 Thread Niklas Söderlund
Hi, This series adds support for V4L2_FIELD_ALTERNATE to rcar-vin. This removes a limitation in the driver where a video sources delivering video using the alternating field format was forced to use the rcar-vin interlacer and V4L2_FIELD_INTERLACED was delivers to the user. After this series the u

[PATCH v3 2/6] rcar-vin: Make use of V4L2_FIELD_IS_INTERLACED() macro

2019-09-04 Thread Niklas Söderlund
The V4L2_FIELD_IS_INTERLACED() can be used to make the code more readable, use it. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- drivers/media/platform/rcar-vin/rcar-dma.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/

[PATCH v3 3/6] rcar-vin: Rename rectangle holding the video source information

2019-09-04 Thread Niklas Söderlund
The variable to hold the video source information dimensions was poorly named 'source'. This is confusing as a lot of other members of structs share the same name with different purposes, rename it src_rect in preparation of refactoring code. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bi

[PATCH v3 4/6] rcar-vin: Do not reset the crop and compose rectangles in s_fmt

2019-09-04 Thread Niklas Söderlund
The crop and compose rectangles are reset when s_fmt is called resulting in potentially valid rectangles being lost when updating the format. Fix this by mapping the rectangles inside the new format. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham --- drivers/media/platform/rcar-vin

[PATCH v3 5/6] rcar-vin: Add support for V4L2_FIELD_ALTERNATE

2019-09-04 Thread Niklas Söderlund
The hardware is capable to passing V4L2_FIELD_ALTERNATE to user-space. Allow users to request this field format but still default to using the hardware interlacer if alternating is not explicitly requested. Before this change a sensor providing data using alternate would be always combined to an i

[PATCH v3 6/6] rcar-vin: Clean up how format is set on subdevice

2019-09-04 Thread Niklas Söderlund
With support for V4L2_FIELD_ALTERNATE added it's possible to clean up how formats are set on the subdevice. This makes the code easier to read as variable names now more clearly express their intent. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 42 ++-

Re: hdpvr.ko kernel 5.3-rc6

2019-09-04 Thread Mauro Carvalho Chehab
Em Wed, 4 Sep 2019 11:13:36 -0700 Scott Doty escreveu: > On 9/3/19 1:34 AM, Hans Verkuil wrote: > > > > Never mind, hdpvr uses read(), not streaming I/O. Of course this > > doesn't work... > > > > Just plain 'cat /dev/videoX >x.mpg' will do. > > > > > > Okay, tried that, it produces data that

Re: hdpvr.ko kernel 5.3-rc6

2019-09-04 Thread Scott Doty
On 9/3/19 1:34 AM, Hans Verkuil wrote: Never mind, hdpvr uses read(), not streaming I/O. Of course this doesn't work... Just plain 'cat /dev/videoX >x.mpg' will do. Okay, tried that, it produces data that vlc can then play back. So I think I'm running into a problem with vlc instead of h

Re: [PATCH 2/2] media: i2c: dw9768: Add DW9768 VCM driver

2019-09-04 Thread Andy Shevchenko
On Mon, Jul 8, 2019 at 5:13 PM wrote: > > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for DW9768 lens voice coil, > and provides control to set the desired focus. > > The DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > +// SPDX-Licen

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Jerry-ch Chen
On Wed, 2019-09-04 at 21:12 +0800, Tomasz Figa wrote: > On Wed, Sep 4, 2019 at 6:26 PM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-09-04 at 17:03 +0800, Tomasz Figa wrote: > > > On Wed, Sep 4, 2019 at 6:02 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, > > > > > > >

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Tomasz Figa
On Wed, Sep 4, 2019 at 6:26 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Wed, 2019-09-04 at 17:03 +0800, Tomasz Figa wrote: > > On Wed, Sep 4, 2019 at 6:02 PM Jerry-ch Chen > > wrote: > > > > > > Hi Tomasz, > > > > > > On Wed, 2019-09-04 at 16:25 +0800, Tomasz Figa wrote: > > > > On Wed, Sep 4,

Re: [PATCH v2 3/6] rcar-vin: Rename rectangle holding the video source information

2019-09-04 Thread Niklas Söderlund
Hi Laurent, Thanks for your feedback. On 2019-08-08 11:30:45 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Thu, Aug 08, 2019 at 03:18:47AM +0200, Niklas Söderlund wrote: > > The variable to hold the video source information dimensions was poorly > > named 'sour

Re: [PATCH 3/4] media: hantro: Add helper for the H264 motion vectors allocation

2019-09-04 Thread Ezequiel Garcia
On Wed, 2019-09-04 at 12:17 +0200, Philipp Zabel wrote: > On Tue, 2019-09-03 at 15:17 -0300, Ezequiel Garcia wrote: > > Introduce a helper to allow easier enablement of the post-processing > > feature. No functional changes intended. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/sta

Re: [PATCH 2/4] media: hantro: Simplify buffer helpers

2019-09-04 Thread Philipp Zabel
On Tue, 2019-09-03 at 15:17 -0300, Ezequiel Garcia wrote: > Modify hantro_get_ref() and hantro_h264_get_ref_buf() helpers > to return the buffer DMA address, this makes the code simpler > and at the same time will allow easier enablement of the > post-processing feature. > > Signed-off-by: Ezequie

Re: [PATCH 1/4] media: hantro: Simplify macroblock macros

2019-09-04 Thread Philipp Zabel
On Tue, 2019-09-03 at 15:17 -0300, Ezequiel Garcia wrote: > It seems all codecs are using a 16x16 size macroblock, > and so it's possible to have just one set of macroblock macros. > > Signed-off-by: Ezequiel Garcia Reviewed-by: Philipp Zabel regards Philipp

Re: [PATCH 3/4] media: hantro: Add helper for the H264 motion vectors allocation

2019-09-04 Thread Philipp Zabel
On Tue, 2019-09-03 at 15:17 -0300, Ezequiel Garcia wrote: > Introduce a helper to allow easier enablement of the post-processing > feature. No functional changes intended. > > Signed-off-by: Ezequiel Garcia > --- > drivers/staging/media/hantro/hantro.h | 6 ++ > drivers/staging/media/ha

[PATCH v4l-utils] keytable: ensure we have enough memlock pages

2019-09-04 Thread Sean Young
Since kernel v5.2, BPF maps and programs are charged against RLIMT_MEMLOCK. By default this limit is 64KB however all of these are already taken (16 patges) by the time we've booted on Fedora. This results in a permission denied. The error message is confusing since error happens when running as r

[PATCH] media: venus: core: Fix msm8996 frequency table

2019-09-04 Thread Loic Poulain
In downstream driver, there are two frequency tables defined, one for the encoder and one for the decoder: /* Encoders / <972000 49000 0x>, / 4k UHD @ 30 / <489600 32000 0x>, / 1080p @ 60 / <244800 15000 0x>, / 1080p @ 30 / <108000 7500 0x>, / 720p @

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Jerry-ch Chen
Hi Tomasz, On Wed, 2019-09-04 at 17:03 +0800, Tomasz Figa wrote: > On Wed, Sep 4, 2019 at 6:02 PM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-09-04 at 16:25 +0800, Tomasz Figa wrote: > > > On Wed, Sep 4, 2019 at 5:09 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, >

[PATCH for v5.3] videobuf-core.c: poll_wait needs a non-NULL buf pointer

2019-09-04 Thread Hans Verkuil
poll_wait uses &buf->done, but buf is NULL. Move the poll_wait to later in the function once buf is correctly set and only call it if it is non-NULL. Signed-off-by: Hans Verkuil Reported-by: Dan Carpenter Fixes: bb436cbeb918 ("media: videobuf: fix epoll() by calling poll_wait first") Cc: #

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Tomasz Figa
On Wed, Sep 4, 2019 at 6:02 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Wed, 2019-09-04 at 16:25 +0800, Tomasz Figa wrote: > > On Wed, Sep 4, 2019 at 5:09 PM Jerry-ch Chen > > wrote: > > > > > > Hi Tomasz, > > > > > > On Wed, 2019-09-04 at 14:34 +0800, Tomasz Figa wrote: > > > > On Wed, Sep 4,

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Jerry-ch Chen
Hi Tomasz, On Wed, 2019-09-04 at 16:25 +0800, Tomasz Figa wrote: > On Wed, Sep 4, 2019 at 5:09 PM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-09-04 at 14:34 +0800, Tomasz Figa wrote: > > > On Wed, Sep 4, 2019 at 3:09 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, >

Re: [PATCH v2] media: mc-device.c: fix memleak in media_device_register_entity

2019-09-04 Thread zhengbin (A)
ping On 2019/8/19 9:51, zhengbin wrote: > In media_device_register_entity, if media_graph_walk_init fails, > need to free the previously memory. > > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > drivers/media/mc/mc-device.c | 65 > ++-- > 1 f

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Tomasz Figa
On Wed, Sep 4, 2019 at 5:09 PM Jerry-ch Chen wrote: > > Hi Tomasz, > > On Wed, 2019-09-04 at 14:34 +0800, Tomasz Figa wrote: > > On Wed, Sep 4, 2019 at 3:09 PM Jerry-ch Chen > > wrote: > > > > > > Hi Tomasz, > > > > > > On Wed, 2019-09-04 at 12:15 +0800, Tomasz Figa wrote: > > > > On Wed, Sep 4,

Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver

2019-09-04 Thread Jerry-ch Chen
Hi Tomasz, On Wed, 2019-09-04 at 14:34 +0800, Tomasz Figa wrote: > On Wed, Sep 4, 2019 at 3:09 PM Jerry-ch Chen > wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-09-04 at 12:15 +0800, Tomasz Figa wrote: > > > On Wed, Sep 4, 2019 at 12:38 PM Jerry-ch Chen > > > wrote: > > > > > > > > Hi Tomasz, >

[bug report] media: videobuf: fix epoll() by calling poll_wait first

2019-09-04 Thread Dan Carpenter
Hello Hans Verkuil, The patch bb436cbeb918: "media: videobuf: fix epoll() by calling poll_wait first" from Feb 7, 2019, leads to the following static checker warning: drivers/media/v4l2-core/videobuf-core.c:1126 videobuf_poll_stream() warn: passing bogus address: '&buf->done' dri