On 6/7/19 8:11 AM, Tomasz Figa wrote:
> On Wed, May 22, 2019 at 7:56 PM Hans Verkuil wrote:
>>> I share the same experience. Bitstream buffers are usually so small that
>>> you can always find a physically contiguous memory region for them and a
>>> memcpy() will be faster than the overhead of get
On 6/7/19 6:32 AM, Tomasz Figa wrote:
> Hi Hans, Lucas,
>
> On Fri, May 3, 2019 at 9:38 PM Hans Verkuil wrote:
>>
>> Hi Lucas,
>>
>> As you mentioned there hasn't been any further review comments, so
>> it is fair not to postpone this.
>>
>
> Sorry for being late to the party. I didn't notice th
On Wed, May 22, 2019 at 7:56 PM Hans Verkuil wrote:
>
> On 5/22/19 12:42 PM, Thierry Reding wrote:
> > On Wed, May 22, 2019 at 10:26:28AM +0200, Paul Kocialkowski wrote:
> >> Hi,
> >>
> >> Le mercredi 22 mai 2019 à 15:48 +0900, Tomasz Figa a écrit :
> >>> On Sat, May 18, 2019 at 11:09 PM Nicolas D
Hi Hans, Lucas,
On Fri, May 3, 2019 at 9:38 PM Hans Verkuil wrote:
>
> Hi Lucas,
>
> As you mentioned there hasn't been any further review comments, so
> it is fair not to postpone this.
>
Sorry for being late to the party. I didn't notice this patch before.
(Perhaps it could be worth adding me
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Jun 7 05:00:11 CEST 2019
media-tree git hash:edadd68031e5b7c1ba0c413a9549dce62a02844c
media_build gi
Hi Sean,
Thanks again for reviewing my patch submission.
This patch updates mceusb RX and TX HALT error handling and recovery reporting,
and provides placeholder for a later patch.
The possible later patch would have mceusb call usb_reset_device() in place of
the
new "... requires USB Reset ...
On Thu, 06 Jun 2019 15:13:00 -0300
Ezequiel Garcia wrote:
> On Thu, 2019-06-06 at 19:43 +0200, Boris Brezillon wrote:
> > On Thu, 6 Jun 2019 12:44:21 -0300
> > Ezequiel Garcia wrote:
> >
> > > Hi,
> > >
> > > This patchset introduces a new vb2_get_buffer accessor and then
> > > uses it on a
Hi Sakari,
On Thursday, June 6, 2019 3:56:42 PM CEST Sakari Ailus wrote:
> Hi Janusz,
>
> On Wed, Jun 05, 2019 at 09:33:41PM +0200, Janusz Krzysztofik wrote:
> > Hi Sakari,
> >
> > On Tuesday, June 4, 2019 7:57:31 PM CEST Sakari Ailus wrote:
> > > Rework the macros for accessing subdev try forma
On Thu, 2019-06-06 at 19:43 +0200, Boris Brezillon wrote:
> On Thu, 6 Jun 2019 12:44:21 -0300
> Ezequiel Garcia wrote:
>
> > Hi,
> >
> > This patchset introduces a new vb2_get_buffer accessor and then
> > uses it on all the drivers that are accessing videobuf2
> > private buffer array directly.
On Thu, 6 Jun 2019 12:44:21 -0300
Ezequiel Garcia wrote:
> Hi,
>
> This patchset introduces a new vb2_get_buffer accessor and then
> uses it on all the drivers that are accessing videobuf2
> private buffer array directly.
Just curious, how did you find all occurrences of direct q->bufs[]
acces
On Thu, 6 Jun 2019 12:44:22 -0300
Ezequiel Garcia wrote:
> Some drivers need to access a vb2 buffer from its
> queue index. Introduce an accessor to abstract this,
> and avoid drivers from accessing private members.
>
> Signed-off-by: Ezequiel Garcia
> ---
> include/media/videobuf2-core.h | 1
On Thu, 6 Jun 2019 13:12:54 -0300
Ezequiel Garcia wrote:
> Rework std_init adding an explicit initialization for
> compound controls.
>
> While here, make sure the control is initialized to zero,
> before providing default values for all its fields.
>
> Signed-off-by: Ezequiel Garcia
Reviewe
On Thu, 6 Jun 2019 13:12:53 -0300
Ezequiel Garcia wrote:
> These two control types don't really need a default value,
> as they are not expected to carry any value.
>
> However, it's slightly clearer to initialize them explicitly
> instead of falling back to the switch default.
>
> Signed-off-
The following changes since commit edadd68031e5b7c1ba0c413a9549dce62a02844c:
media: MAINTAINERS: update email address (2019-06-05 15:58:40 -0400)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3o
for you to fetch changes up to ddfad6971e54f423ea
These two control types don't really need a default value,
as they are not expected to carry any value.
However, it's slightly clearer to initialize them explicitly
instead of falling back to the switch default.
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Initialize the controls to zer
Rework std_init adding an explicit initialization for
compound controls.
While here, make sure the control is initialized to zero,
before providing default values for all its fields.
Signed-off-by: Ezequiel Garcia
---
Changes from v2:
* Align parameters to parenthesis
* Drop unneeded zero initia
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rockchip/vpu/rockchip_vpu_drv.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/rockchip/vpu/
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Jean-Christophe Trotin
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/sti/hva/hva-v4l2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/st
Some drivers need to access a vb2 buffer from its
queue index. Introduce an accessor to abstract this,
and avoid drivers from accessing private members.
Signed-off-by: Ezequiel Garcia
---
include/media/videobuf2-core.h | 18 ++
1 file changed, 18 insertions(+)
diff --git a/inclu
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Tiffany Lin
Cc: Andrew-CT Chen
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git
Use the newly introduced vb2_get_buffer API and avoid
accessing buffers in the queue directly.
Cc: Rick Chang
Cc: Bin Liu
Signed-off-by: Ezequiel Garcia
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platfor
Hi,
This patchset introduces a new vb2_get_buffer accessor and then
uses it on all the drivers that are accessing videobuf2
private buffer array directly.
I'm skipping Intel IPU3 driver here, since the code goes beyond
just accessing the buffer. It also modifies the buffer queue
directly. I belie
On Wed, 5 Jun 2019 13:22:42 +0200
Boris Brezillon wrote:
> On Fri, 31 May 2019 10:55:14 +0200
> Philipp Zabel wrote:
>
> > Rename the driver and all relevant identifiers from Rockchip to Hantro,
> > as other Hantro IP based VPU implementations can be supported by the
> > same driver.
> > The RK
Hi Mauro,
A change to use rc-core for the av7110 IR receiver, which removes a procfs
file. Also some tiny steps changes towards moving away from dvb_attach.
Thanks,
Sean
The following changes since commit edadd68031e5b7c1ba0c413a9549dce62a02844c:
media: MAINTAINERS: update email address (2019
Le jeudi 06 juin 2019 à 08:51 +0200, Boris Brezillon a écrit :
> On Thu, 6 Jun 2019 12:53:57 +0900
> Tomasz Figa wrote:
>
> > On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon
> > wrote:
> > > CAP_M2M_MPLANE means the device supports _MPLANE formats for both
> > > capture and output. Adjust the che
Hi Janusz,
On Wed, Jun 05, 2019 at 09:33:41PM +0200, Janusz Krzysztofik wrote:
> Hi Sakari,
>
> On Tuesday, June 4, 2019 7:57:31 PM CEST Sakari Ailus wrote:
> > Rework the macros for accessing subdev try formats to work meaningfully
> > and relatively safely without V4L2 sub-device uAPI (and with
On Wed, Jun 5, 2019 at 10:32 PM Robin Gong wrote:
>
> So that's another issue that I can't reproduce. How do you switch between
> sdma ROM/RAM firmware load? Just keep or remove
> sdma-imx6q.bin in your ramfs(seems you used)?
I add the sdma firmware to the kernel image, by adding the following t
Instead of using the convenience function
v4l2_async_notifier_parse_fwnode_endpoints(), parse the endpoints and set
up the async sub-devices without using callbacks. While this adds a little
bit of code, it makes parsing the endpoints quite a bit more simple and
gives more control to the driver ove
The notifier must be cleaned up whenever parsing endpoints fails. Do that
to avoid a memory leak in that case.
Signed-off-by: Sakari Ailus
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pci/intel/ipu3/ipu3-ci
Hi folks,
This patchset reworks V4L2 fwnode endpoint parsing. It enables the use of
endpoint configuration defaults that is available sensors and other
drivers that only use a single endpoint. Well, the functionality was
available already but no driver used it likely because of two reasons:
lack o
Rework OF endpoint parsing for the omap3isp driver. This does add some
lines of code. The benefits are still clear:
- the great complication related to callbacks in endpoint parsing is gone;
instead endpoints are obtained port by port and
- endpoints may now have a default bus configuration whi
v4l2_async_notifier_add_fwnode_remote_subdev is a convenience function for
parsing information on V4L2 fwnode subdevs.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-async.c | 23 +++
include/media/v4l2-async.h | 25 +
2 files c
The davinci-vpif driver dereferences its local endpoints after releasing
the reference to them.
The driver also puts its endpoints explicitly while the
of_graph_get_next_endpoint() does that, too, leading to obtaining a
reference once and releasing it twice.
Both are fixed by this patch.
Signed-
Make the V4L2 async framework a bit more robust by allowing to clean up an
uninitialised notifier. Otherwise the result would be a (close to) NULL
pointer dereference.
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-async.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The v4l2_async_notifier_add_fwnode_subdev() did not take a reference of
the added fwnode, relying on the caller to handle that instead, in essence
putting the fwnode to be added if there was an error.
As the reference is eventually released during the notifier cleanup, this
is not intuitive nor lo
V4L2 async framework can use both device's fwnode and endpoints's fwnode
for matching the async sub-device with the sub-device. In order to proceed
moving towards endpoint matching assign the endpoint to the async
sub-device.
As most async sub-device drivers (and the related hardware) only support
The notifier may be registered even if there are no subdevs. Do that to
simplify the code.
Signed-off-by: Sakari Ailus
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/pci/intel/ipu3/ipu3-cio2.c
b/drivers/m
Correctly handle stopping and restarting the encoder, keeping
track of the stop and drain states.
In addition it adds correct handling of corner cases, allowing
v4l2-compliance to pass.
Unfortunately, the code is getting to be quite complicated, so
we need to work on better codec support in v4l2-
The stateful encoder requires the presence of this control.
Since a single buffer is sufficient for vicodec, we just
set this control to 1.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vicodec/vicodec-core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/driver
Return an error when attempting to subscribe to those events
for a stateless codec.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vicodec/vicodec-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/
Setting the encoder output format to e.g. 1920x1080 will set the
crop rectangle to 1920x1088, the coded resolution to 1920x1088 and
the capture coded resolution and sizeimage to 1920x1088 as well.
Note that this might change, since the encoder spec is still in
flux with respect to how this should
Set V4L2_BUF_FLAG_P/KEYFRAME after decoding a frame.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vicodec/vicodec-core.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/vicodec-co
After a resolution change is detected, q_data->sizeimage is updated
to the new format, but buf_prepare is still draining buffers that
need to use the old pre-resolution-change value. So store the sizeimage
value in q_data->vb2_sizeimage in queue_setup and use that in
buf_prepare.
Signed-off-by: Ha
v4l2_ctrl_request_complete can sleep, so can't be called while
a spinlock is held.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vicodec/vicodec-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/
This series fixes a number of bugs and compliance failures in the
vicodec driver. Combined with new/fixed tests in v4l2-compliance
(see https://git.linuxtv.org/hverkuil/v4l-utils.git/log/?h=vicodec)
vicodec can now be used in regression testing.
There will probably be a few more changes once the c
The initial sizeimage value was wrong for the stateless decoder.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vicodec/vicodec-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/vi
Rather than returning width/height values of 0, just default to
a format. Formats in V4L2 are always supposed to be valid, there
is no concept of an invalid format.
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vicodec/vicodec-core.c | 26 ++-
1 file changed, 14 insertio
On 6/5/19 10:53 PM, Fabio Estevam wrote:
> Commit 020bc7354a6e ("media: staging/imx: Allow driver to build
> if COMPILE_TEST is enabled") incorrectly assumed that the imx media
> driver had no build time dependency with IMX_IPUV3_CORE.
>
> Building on x86_64 without IMX_IPUV3_CORE causes lots of b
Hi Jerry,
On Tue, Apr 23, 2019 at 06:45:05PM +0800, Jerry-ch Chen wrote:
> From: Jerry-ch Chen
>
> This patch adds the driver of Face Detection (FD) unit in
> Mediatek camera system, providing face detection function.
>
> The mtk-isp directory will contain drivers for multiple IP
> blocks found
On 06/06/2019 11:47, Anders Roxell wrote:
> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> fs/coda/coda.ko
> drivers/media/platform/coda/coda.ko
>
> Rework so media coda matches the
This patch adds Mediat:ek's sensor interface driver. Sensor interface
driver
is a MIPI-CSI2 host driver, namely, a HW camera interface controller.
It support a widely adopted, simple, high-speed protocol primarily
intended
for point-to-point image and video transmission between cameras and host
dev
Hello,
This is the RFC patch adding Sensor Inferface(seninf) driver on
Mediatek mt8183 SoC, which will be used in camera features on CrOS application.
It belongs to the first Mediatek's camera driver series based on V4L2 and media
controller framework.
I posted the main part of the seninf driver
Add nodes for Mediatek's sensor interface device. Sensor interface module
embedded in Mediatek SOCs, works as a HW camera interface controller
intended for image and data transmission between cameras and host devices.
Signed-off-by: Louis Kuo
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 15 +++
This patch adds the DT binding documentation for the sensor interface
module in Mediatek SoCs.
Signed-off-by: Louis Kuo
---
.../devicetree/bindings/media/mediatek-seninf.txt | 31 ++
1 file changed, 31 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media
This patch adds KConfig for sensor interface driver. Sensor interface
driver
is a MIPI-CSI2 host driver, namely, a HW camera interface controller.
It support a widely adopted, simple, high-speed protocol primarily
intended
for point-to-point image and video transmission between cameras and host
dev
On Sat, Jun 01, 2019 at 07:35:09PM -0400, A Sun wrote:
> Update dev_err() messages to report status (including success) for each
> step of USB RX HALT and TX HALT error recovery. If error recovery fails,
> show the message:
> stuck RX HALT state requires USB Reset Device to clear
> or
>
This PR fixes two regressions.
The _MPLANE fix wasn't found by the test-media script since it vim2m doesn't
support multiplanar formats, so it didn't hit this bug. In addition, the
vicodec driver that DOES have multiplanar support isn't tested yet by the
test-media script.
I'm working on a patch
On Thu, Jun 6, 2019 at 4:09 PM Hans Verkuil wrote:
>
> On 6/6/19 8:51 AM, Boris Brezillon wrote:
> > On Thu, 6 Jun 2019 12:53:57 +0900
> > Tomasz Figa wrote:
> >
> >> On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon
> >> wrote:
> >>>
> >>> CAP_M2M_MPLANE means the device supports _MPLANE formats f
On 6/6/19 9:09 AM, Boris Brezillon wrote:
> On Thu, 6 Jun 2019 08:51:59 +0200
> Boris Brezillon wrote:
>
>> On Thu, 6 Jun 2019 12:53:57 +0900
>> Tomasz Figa wrote:
>>
>>> On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon
>>> wrote:
CAP_M2M_MPLANE means the device supports _MPLANE forma
On 6/6/19 8:51 AM, Boris Brezillon wrote:
> On Thu, 6 Jun 2019 12:53:57 +0900
> Tomasz Figa wrote:
>
>> On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon
>> wrote:
>>>
>>> CAP_M2M_MPLANE means the device supports _MPLANE formats for both
>>> capture and output. Adjust the check to avoid EINVAL erro
On Thu, 6 Jun 2019 08:51:59 +0200
Boris Brezillon wrote:
> On Thu, 6 Jun 2019 12:53:57 +0900
> Tomasz Figa wrote:
>
> > On Thu, Jun 6, 2019 at 1:46 AM Boris Brezillon
> > wrote:
> > >
> > > CAP_M2M_MPLANE means the device supports _MPLANE formats for both
> > > capture and output. Adjust the
61 matches
Mail list logo
