Re: media/master v4l2-compliance on vivid: 236 tests, 0 regressions (media_v5.1-2-16-gfc8670d1f72b)

2019-05-15 Thread Hans Verkuil
Hi Guillaume, I have a few questions/suggestions: On 5/15/19 9:04 PM, kernelci.org bot wrote: > media/master v4l2-compliance on vivid: 236 tests, 0 regressions > (media_v5.1-2-16-gfc8670d1f72b) > > Test results summary > > > V4L2 Compliance on the vivid driver. > > This t

Re: [RFC PATCH V1 1/6] dt-bindings: mt8183: Add binding for DIP shared memory

2019-05-15 Thread Tomasz Figa
On Wed, May 15, 2019 at 1:19 AM Rob Herring wrote: > > On Tue, May 7, 2019 at 9:22 AM Frederic Chen > wrote: > > > > Dear Rob, > > > > I appreciate your comments. > > > > On Mon, 2019-04-29 at 20:15 -0500, Rob Herring wrote: > > > On Wed, Apr 17, 2019 at 06:45:06PM +0800, Frederic Chen wrote: >

Re: [RFC,V2,03/11] dt-bindings: mt8183: Added camera ISP Pass 1

2019-05-15 Thread Jungo Lin
Hi, Rob: Thanks for your comments. On Tue, 2019-05-14 at 14:54 -0500, Rob Herring wrote: > On Fri, May 10, 2019 at 09:57:52AM +0800, Jungo Lin wrote: > > This patch adds DT binding document for the Pass 1 (P1) unit in > > Mediatek's camera ISP system. The Pass 1 unit grabs the sensor data > > out

cron job: media_tree daily build: OK

2019-05-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 16 05:00:12 CEST 2019 media-tree git hash:fc8670d1f72b746ff3a5fe441f1fca4c4dba0e6f media_build gi

[RFC v2 2/4] dts: arm64: mt8183: Add Mediatek MDP3 nodes

2019-05-15 Thread Daoyuan Huang
From: daoyuan huang Add device nodes for Media Data Path 3 (MDP3) modules. Signed-off-by: Ping-Hsun Wu Signed-off-by: daoyuan huang --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 173 +++ 1 file changed, 173 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.d

[RFC v2 0/4] media: mediatek: support mdp3 on mt8183 platform

2019-05-15 Thread Daoyuan Huang
Hi, This is the first version of RFC patch for Media Data Path 3 (MDP3), MDP3 is used for scaling and color format conversion. support using GCE to write register in critical time limitation. support V4L2 m2m device control. Changes since v1: - modify code for CMDQ v3 API support - EC ipi cmd mig

[RFC v2 1/4] dt-binding: mt8183: Add Mediatek MDP3 dt-bindings

2019-05-15 Thread Daoyuan Huang
From: daoyuan huang This patch adds DT binding document for Media Data Path 3 (MDP3) a unit in multimedia system used for scaling and color format convert. Signed-off-by: Ping-Hsun Wu Signed-off-by: daoyuan huang --- .../bindings/media/mediatek,mt8183-mdp3.txt | 217 ++ 1 fi

[RFC v2 3/4] media: platform: Add Mediatek MDP3 driver KConfig

2019-05-15 Thread Daoyuan Huang
From: daoyuan huang This patch adds Kconfig for Mediatek Media Data Path 3 (MDP3) driver. MDP3 is used to do scaling and color format conversion. Signed-off-by: Ping-Hsun Wu Signed-off-by: daoyuan huang --- drivers/media/platform/Kconfig | 18 ++ drivers/media/platform/Makefi

[PATCH v2 5/8] rcar-vin: Move pm_runtime_{get,put} out of helpers

2019-05-15 Thread Niklas Söderlund
The helpers rvin_power_{on,off} deal with both VIN and the parallel subdevice power. This makes it hard to merge the Gen2 and Gen3 open/release functions. Move the VIN power handling directly to the open/release functions to prepare for the merge. Signed-off-by: Niklas Söderlund Reviewed-by: Ulri

[PATCH v2 0/8] rcar-vin: Merge Gen2 and Gen3 file operations

2019-05-15 Thread Niklas Söderlund
Hi, This series aims to merge the two different set of file operations used in the rcar-vin driver. One set was used on Renesas Gen2 boards while the other set was used on Gen3. Main difference between the two is that Gen2 uses a device node centric world view while Gen3 subscribes to the media co

[PATCH v2 4/8] rcar-vin: Do not sync subdevice format when opening the video device

2019-05-15 Thread Niklas Söderlund
The format is already synced when the subdevice is bound, there is no need to do do it every time the video device is opened. Signed-off-by: Niklas Söderlund Reviewed-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 25 - 1 file changed, 25 deletions(-) di

[PATCH v2 3/8] rcar-vin: Allow interrupting lock when trying to open the video device

2019-05-15 Thread Niklas Söderlund
The user should be allowed to break waiting for the lock when opening the video device. Signed-off-by: Niklas Söderlund Reviewed-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vi

[PATCH 3/3] rcar-vin: Add support for RGB formats with alpha component

2019-05-15 Thread Niklas Söderlund
The R-Car VIN module supports V4L2_PIX_FMT_ARGB555 and V4L2_PIX_FMT_ABGR32 pixel formats. Add the hardware register setup and allow the alpha component to be changed while streaming using the V4L2_CID_ALPHA_COMPONENT control. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rc

[PATCH] rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()

2019-05-15 Thread Niklas Söderlund
Use the PTR_ERR_OR_ZERO() macro instead of construct: if (IS_ERR(foo)) return PTR_ERR(foo); return 0; Reported-by: kbuild test robot Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting") Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rca

[PATCH] dt-bindings: rcar-{csi2,vin}: Rename bindings documentation files

2019-05-15 Thread Niklas Söderlund
Renesas media binding documentation files uses a naming schema of 'renesas,.txt'. Rename VIN and CSI-2 files to match this pattern. Signed-off-by: Niklas Söderlund --- .../media/{renesas,rcar-csi2.txt => renesas,csi2.txt} | 0 .../bindings/media/{rcar_vin.txt => renesas,vin.txt}

[PATCH v2 8/8] rcar-vin: Merge Gen2 and Gen3 file operations

2019-05-15 Thread Niklas Söderlund
After the rework of the Gen2 file operations it's now trivial to merge the Gen2 and Gen3 versions. Signed-off-by: Niklas Söderlund Reviewed-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 96 - 1 file changed, 16 insertions(+), 80 deletions(-) diff --git

[PATCH 1/3] rcar-vin: Rename VNDMR_DTMD_ARGB1555 to VNDMR_DTMD_ARGB

2019-05-15 Thread Niklas Söderlund
The value have nothing to do with ARGB1555, it controls if the alpha component should be filled in for ARGB1555 or ARGB888. Rename it to reflect this. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 2/3] rcar-vin: Add control for alpha component

2019-05-15 Thread Niklas Söderlund
In preparation to adding support for RGB pixel formats with an alpha component add a control to allow the user to control which alpha value should be used. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-core.c | 53 - drivers/media/platform/rcar-vin/

[PATCH v2 6/8] rcar-vin: Merge helpers dealing with powering the parallel subdevice

2019-05-15 Thread Niklas Söderlund
The two power helpers are now only dealing with the parallel subdevice, merge them into a single rvin_power_parallel() helper to reduce code duplication. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 20 +--- 1 file changed, 5 insertions(+), 15

[PATCH 0/3] rcar-vin: Add support for RGB formats with alpha component

2019-05-15 Thread Niklas Söderlund
Hi, This small series adds support for two new pixel formats for the rcar-vin driver; V4L2_PIX_FMT_ARGB555 and V4L2_PIX_FMT_ABGR32. Both formats have an alpha component so a new standard control is also added to control its value, V4L2_CID_ALPHA_COMPONENT. The series is based on the latest medi

[PATCH v2 7/8] rcar-vin: Fold rvin_initialize_device() into rvin_open()

2019-05-15 Thread Niklas Söderlund
The function no longer serve a purpose as most tasks it performed have been refactored, fold what remains of it into the only caller. Signed-off-by: Niklas Söderlund Reviewed-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 21 - 1 file changed, 4 insertion

[PATCH v2 1/8] rcar-vin: Do not call pm_runtime_{resume,suspend}()

2019-05-15 Thread Niklas Söderlund
The driver does not implement runtime resume and suspend function so there is little point in trying to call them. This is a leftover from the drivers soc_camera beginnings. Signed-off-by: Niklas Söderlund Reviewed-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 5 - 1 fi

[PATCH v2 2/8] rcar-vin: Remove unneeded calls to pm_runtime_{enable,disable}

2019-05-15 Thread Niklas Söderlund
Runtime PM is already enabled unconditionally when the driver is probed and disabled when it's removed. There is no point in doing it again for Gen2 when opening and closing the video device. Signed-off-by: Niklas Söderlund Reviewed-by: Ulrich Hecht --- drivers/media/platform/rcar-vin/rcar-v4l2

Re: Proposed updates and guidelines for MPEG-2, H.264 and H.265 stateless support

2019-05-15 Thread Paul Kocialkowski
Hi, Le mercredi 15 mai 2019 à 14:54 -0400, Nicolas Dufresne a écrit : > Le mercredi 15 mai 2019 à 19:42 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > Le mercredi 15 mai 2019 à 10:42 -0400, Nicolas Dufresne a écrit : > > > Le mercredi 15 mai 2019 à 12:09 +0200, Paul Kocialkowski a écrit : > >

media/master v4l2-compliance on vivid: 236 tests, 0 regressions (media_v5.1-2-16-gfc8670d1f72b)

2019-05-15 Thread kernelci.org bot
media/master v4l2-compliance on vivid: 236 tests, 0 regressions (media_v5.1-2-16-gfc8670d1f72b) Test results summary V4L2 Compliance on the vivid driver. This test ran "v4l2-compliance -s" from v4l-utils: https://www.linuxtv.org/wiki/index.php/V4l2-utils See each deta

media/master v4l2-compliance on uvcvideo: 104 tests, 0 regressions (media_v5.1-2-16-gfc8670d1f72b)

2019-05-15 Thread kernelci.org bot
media/master v4l2-compliance on uvcvideo: 104 tests, 0 regressions (media_v5.1-2-16-gfc8670d1f72b) Test results summary V4L2 Compliance on the uvcvideo driver. This test ran "v4l2-compliance -s" from v4l-utils: https://www.linuxtv.org/wiki/index.php/V4l2-utils See eac

Re: Proposed updates and guidelines for MPEG-2, H.264 and H.265 stateless support

2019-05-15 Thread Nicolas Dufresne
Le mercredi 15 mai 2019 à 19:42 +0200, Paul Kocialkowski a écrit : > Hi, > > Le mercredi 15 mai 2019 à 10:42 -0400, Nicolas Dufresne a écrit : > > Le mercredi 15 mai 2019 à 12:09 +0200, Paul Kocialkowski a écrit : > > > Hi, > > > > > > With the Rockchip stateless VPU driver in the works, we now h

Re: Proposed updates and guidelines for MPEG-2, H.264 and H.265 stateless support

2019-05-15 Thread Paul Kocialkowski
Hi, Le mercredi 15 mai 2019 à 10:42 -0400, Nicolas Dufresne a écrit : > Le mercredi 15 mai 2019 à 12:09 +0200, Paul Kocialkowski a écrit : > > Hi, > > > > With the Rockchip stateless VPU driver in the works, we now have a > > better idea of what the situation is like on platforms other than > > A

Re: [RFCv2 PATCH] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

2019-05-15 Thread Boris Brezillon
On Wed, 15 May 2019 14:32:20 +0200 Hans Verkuil wrote: > This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. > It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and > a v4l2_m2m_release_capture_buf() helper function. > > Drivers should set vb2_queu

[PATCH] media: fdp1: Support M3N and E3 platforms

2019-05-15 Thread Kieran Bingham
New Gen3 R-Car platforms incorporate the FDP1 with an updated version register. No code change is required to support these targets, but they will currently report an error stating that the device can not be identified. Update the driver to match against the new device types. Signed-off-by: Kiera

Re: Proposed updates and guidelines for MPEG-2, H.264 and H.265 stateless support

2019-05-15 Thread Nicolas Dufresne
Le mercredi 15 mai 2019 à 12:09 +0200, Paul Kocialkowski a écrit : > Hi, > > With the Rockchip stateless VPU driver in the works, we now have a > better idea of what the situation is like on platforms other than > Allwinner. This email shares my conclusions about the situation and how > we should

Re: [RFC,V2,01/11] dt-bindings: mt8183: Add binding for ISP Pass 1 reserved memory

2019-05-15 Thread Jungo Lin
Hi Rob: Thanks for your comments. On Tue, 2019-05-14 at 14:50 -0500, Rob Herring wrote: > On Fri, May 10, 2019 at 09:57:47AM +0800, Jungo Lin wrote: > > This patch adds the binding for describing the reserved > > shared memory used to exchange ISP configuration and tuning > > data between the co-

Re: [RFC, V2, 06/11] media: platform: Add Mediatek ISP P1 image & meta formats

2019-05-15 Thread Jungo Lin
Hi, Hans: Thanks for your comments. On Mon, 2019-05-13 at 10:35 +0200, Hans Verkuil wrote: > On 5/10/19 3:57 AM, Jungo Lin wrote: > > Add packed/unpacked/full-g bayer format with 8/10/12/14 bit > > for image output. Add Pass 1 (P1) specific meta formats for > > parameter processing and 3A/other s

[RFCv2 PATCH] vb2: add V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF

2019-05-15 Thread Hans Verkuil
This RFC patch adds support for the V4L2_BUF_FLAG_M2M_HOLD_CAPTURE_BUF flag. It also adds a new V4L2_BUF_CAP_SUPPORTS_M2M_HOLD_CAPTURE_BUF capability and a v4l2_m2m_release_capture_buf() helper function. Drivers should set vb2_queue->subsystem_flags to VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF to

Proposed updates and guidelines for MPEG-2, H.264 and H.265 stateless support

2019-05-15 Thread Paul Kocialkowski
Hi, With the Rockchip stateless VPU driver in the works, we now have a better idea of what the situation is like on platforms other than Allwinner. This email shares my conclusions about the situation and how we should update the MPEG-2, H.264 and H.265 controls accordingly. - Per-slice decoding

[PATCH 4/6] cec: add CEC_MSG_FL_RAW flag and msg_is_raw helper function

2019-05-15 Thread Hans Verkuil
This adds the userspace API to send raw unchecked CEC messages. This will require root permissions. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-priv.h | 5 + include/uapi/linux/cec.h | 1 + 2 files changed, 6 insertions(+) diff --git a/drivers/media/cec/cec-priv.h b/drivers/me

[PATCH 5/6] cec: support CEC_MSG_FL_RAW

2019-05-15 Thread Hans Verkuil
If this flag is set, then check for root permissions and skip all message checks except for the core checks (i.e. validate the length etc.). Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 107 --- 1 file changed, 62 insertions(+), 45 deletions(-)

[PATCH 2/6] cec: move check from cec_transmit to cec_transmit_msg_fh

2019-05-15 Thread Hans Verkuil
This ensures all the cec_msg checks are done in the same place. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 5 + drivers/media/cec/cec-api.c | 8 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/media/cec/cec-adap.c b/drivers/media/cec/cec-a

[PATCH 6/6] cec: allow any initiator for Ping and Image/Text View On

2019-05-15 Thread Hans Verkuil
Some displays pull down the HPD when in standby, but CEC is still active and the display can be woken up by sending an Image View On or Text View On CEC command. The CEC specification doesn't tell you what the initiator should be for such a command (without a HPD it's unclear if the CEC adapter can

[PATCH 1/6] cec: cec_transmit_msg_fh: do sanity checks first

2019-05-15 Thread Hans Verkuil
The code that fills in the CEC_MSG_CDC_MESSAGE physical address is now done after the sanity checks. It also only does this if the message length is >= 4 (i.e. there is room for the physical address). Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 11 ++- 1 file changed,

[PATCH 3/6] cec-ioc-receive.rst: document CEC_MSG_FL_RAW

2019-05-15 Thread Hans Verkuil
Document this new cec_msg flag. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/cec/cec-ioc-receive.rst | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/Documentation/media/uapi/cec/cec-ioc-receive.rst b/Documentation/media/uapi/cec/cec-ioc-receive.rst

[PATCH 0/6] cec: various improvements

2019-05-15 Thread Hans Verkuil
This series adds a new CEC_MSG_FL_RAW flag to skip all CEC message checks and transmit the raw message (if called as root). This is useful when debugging issues with other dubious CEC implementations. The last patch relaxes an initiator check for Ping and Image/Text View On messages when there is