This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Apr 25 05:00:11 CEST 2019
media-tree git hash:a4dfc8a24796ff312d1d307e11f26f8ca466e938
media_build gi
On 4/24/19 8:03 PM, André Almeida wrote:
> Hello Helen,
>
> Thanks for your review!
>
> On 4/24/19 6:32 PM, Helen Koike wrote:
>> Hi André,
>>
>> Thanks for the patch, please see my comments below.
>>
>> On 4/24/19 10:56 AM, André Almeida wrote:
>>> Create multiplanar kernel module parameter t
Hello Helen,
Thanks for your review!
On 4/24/19 6:32 PM, Helen Koike wrote:
> Hi André,
>
> Thanks for the patch, please see my comments below.
>
> On 4/24/19 10:56 AM, André Almeida wrote:
>> Create multiplanar kernel module parameter to define if the driver is
>> running in single planar or in
On 4/24/19 10:56 AM, André Almeida wrote:
> Since multiplanar is a superset of single planar formats, instead of
> having different implementations for them, treat all formats as
> multiplanar. If we need to work with single planar formats, convert them to
> multiplanar (with num_planes = 1), re
Hi André,
Thanks for the patch, please see my comments below.
On 4/24/19 10:56 AM, André Almeida wrote:
> Create multiplanar kernel module parameter to define if the driver is
> running in single planar or in multiplanar mode. Define the device
> capabilities and format ioctls according to the mu
Hi André,
On 4/24/19 10:56 AM, André Almeida wrote:
> Adapt vimc-capture to support multiplanar formats, copying
> each plane to the correct buffer.
>
> Signed-off-by: André Almeida
> ---
> Change in v3:
> - Adapt to new vimc_frame
>
> Change in v2: none
>
> drivers/media/platform/vimc/vimc-c
Hi André,
Thanks for the patch, please see my comments below.
On 4/24/19 10:56 AM, André Almeida wrote:
> Change the scaling functions in order to scale planes. This change makes
> easier to support multiplanar pixel formats.
>
> Signed-off-by: André Almeida
> ---
> Change in v3:
> - Adapt to n
Hi André,
On 4/24/19 10:56 AM, André Almeida wrote:
> This commit adapts vimc-sensor to handle multiplanar pixel formats,
> adapting the memory allocation and TPG configuration.
>
> Signed-off-by: André Almeida
> ---
> Changes in v3:
> - Adapt to new vimc_frame
>
> Changes in v2:
> - Fix alignm
Hi André
On 4/24/19 10:56 AM, André Almeida wrote:
> Struct vimc_frame is intended to hold metadata about a frame,
> such as memory address of a plane, number of planes and size
> of each plane, to better integrated with the multiplanar operations.
> The struct can be also used with singleplanar f
Hi André, thanks for the patch.
On 4/24/19 10:56 AM, André Almeida wrote:
> Add a multiplanar flag in vimc_stream in order to propagate the
> state (singleplanar/multiplanar) to subdevices at the stream.
This shouldn't be required as you are using multiplanar only between the
subdevices :)
Helen
Changes since the previous pull request: rebased and some sparse warnings fixed.
Regards,
Hans
The following changes since commit a4dfc8a24796ff312d1d307e11f26f8ca466e938:
media: MAINTAINERS: Update AO CEC with ao-cec-g12a driver (2019-04-22
13:16:35 -0400)
are available in the Git
Struct vimc_frame is intended to hold metadata about a frame,
such as memory address of a plane, number of planes and size
of each plane, to better integrated with the multiplanar operations.
The struct can be also used with singleplanar formats, making the
implementation of frame manipulation gene
Create multiplanar kernel module parameter to define if the driver is
running in single planar or in multiplanar mode. Define the device
capabilities and format ioctls according to the multiplanar kernel
parameter. A device can't support both CAP_VIDEO_CAPTURE and
CAP_VIDEO_CAPTURE_MPLANAR at the s
Adapt vimc-capture to support multiplanar formats, copying
each plane to the correct buffer.
Signed-off-by: André Almeida
---
Change in v3:
- Adapt to new vimc_frame
Change in v2: none
drivers/media/platform/vimc/vimc-capture.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletio
Change the scaling functions in order to scale planes. This change makes
easier to support multiplanar pixel formats.
Signed-off-by: André Almeida
---
Change in v3:
- Adapt to new vimc_frame
Changes in v2:
- Move the TODO comment to vimc-capture
- Reuse and share the code to free the memory of p
This commit adapts vimc-sensor to handle multiplanar pixel formats,
adapting the memory allocation and TPG configuration.
Signed-off-by: André Almeida
---
Changes in v3:
- Adapt to new vimc_frame
Changes in v2:
- Fix alignment issues
- Remove unnecessary variable assignment
- Reuse and share the
If the driver is in multiplanar mode, fill the vb2 structures
with the planes sizes and verify it the sizes allocated to the
planes are enough.
Signed-off-by: André Almeida
Acked-by: Helen Koike
---
Change in v3: none
Change in v2:
- Use IS_MULTIPLANAR macro
drivers/media/platform/vimc/vimc-c
Add a multiplanar flag in vimc_stream in order to propagate the
state (singleplanar/multiplanar) to subdevices at the stream.
Signed-off-by: André Almeida
---
Change in v3:
- Use ternary operator to get code more simple
Change in v2:
- New commit
drivers/media/platform/vimc/vimc-capture.c | 4
vimc already have a default single planar format.
Add a multiplanar default pixel format to perform those
same actions. Change where the default pixelformat is set to make sure
that the vcap is with the right capabilities.
Signed-off-by: André Almeida
---
Change in v3:
- Fix typo on commit messag
Add multiplanar formats to be exposed to the userspace as
supported formats. Since we don't want to support multiplanar
formats when the driver is in singleplanar mode, we only access
the multiplanar formats array if the multiplanar mode is enabled.
Signed-off-by: André Almeida
Acked-by: Helen Ko
Since multiplanar is a superset of single planar formats, instead of
having different implementations for them, treat all formats as
multiplanar. If we need to work with single planar formats, convert them to
multiplanar (with num_planes = 1), re-use the multiplanar code, and
transform them back to
Define the pixelformat of the streamer depending to the
mode (single/multiplanar). Add a macro to help checking if the device is
in multilplanar mode.
Signed-off-by: André Almeida
Acked-by: Helen Koike
---
Change in v3:
- Replace if with triaste operator
Change in v2:
- Add a macro to check if
vimc_cap_device.format field was defined as v4l2_pix_format,
a struct to handle single planar pixel formats. It turns out that
if v4l2_format is used, we can reuse functions for both
v4l2_pix_format and v4l2_pix_format_mplane. This change will
help at future commits implementing multiplanar pixel
f
Move sp2mp functions from vivid code to v4l2-common as it will be reused
by vimc driver for multiplanar support.
Signed-off-by: André Almeida
---
Changes in v3:
- Change commit order
- Reword comments
Changes in v2:
- Fix indentation
- Change the style of comments. Functions now have a shorter t
Hello,
This series implements support for multiplane pixel formats at Vimc.
A lot of changes were required since vimc support for singleplane
was "hardcoded". The code has been adapted in order to support both
formats. When was possible, the functions were written generically,
avoiding functions f
Change the way subdevices check if the stream is running. Verify the stream
pointer instead of src_frame. This makes easier to get rid of the void* and
u8* in the subdevices structs. Also, remove redundant checks for stream.
Signed-off-by: André Almeida
Acked-by: Helen Koike
---
Changes in v3:
-
The following changes since commit a4dfc8a24796ff312d1d307e11f26f8ca466e938:
media: MAINTAINERS: Update AO CEC with ao-cec-g12a driver (2019-04-22
13:16:35 -0400)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.2g2
for you to fetch changes up to
Add MPEG-2 CID definitions for profiles and levels defined in ITU-T Rec.
H.262.
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Moved CIDs up to V4L2_CID_MPEG_BASE+270
---
.../media/uapi/v4l/ext-ctrls-codec.rst| 56 +++
drivers/media/v4l2-core/v4l2-ctrls.c
cec_notifier_parse_hdmi_phandle returns an error pointer, not a NULL
pointer on error.
Fixes: 4d34c9267db7: ("media: tegra_cec: use new
cec_notifier_parse_hdmi_phandle helper")
Signed-off-by: Hans Verkuil
Reported-by: Dan Carpenter
---
diff --git a/drivers/media/platform/tegra-cec/tegra_cec.c
On 4/16/19 14:03, Boris Brezillon wrote:
> This is needed if we want the core to be able to check _MPLANE support
> without having to call the ->vdioc_querycap() hook.
>
> Signed-off-by: Boris Brezillon
> ---
> Changes in v4:
> - Add a hack in fimc-lite and fimc-isp-video ->querycap()
> impleme
In vpbe_enum_outputs() we check if (temp_index >= cfg->num_outputs) but
the problem is that "temp_index" can be negative. This patch changes
the types to unsigned to address this array underflow bug.
Fixes: 66715cdc3224 ("[media] davinci vpbe: VPBE display driver")
Signed-off-by: Dan Carpenter
A
These two slice modes used by the V4L2_CID_MPEG_VIDEO_MULTI_SLICE_MODE
control had a silly typo:
V4L2_MPEG_VIDEO_MULTI_SICE_MODE_MAX_MB
V4L2_MPEG_VIDEO_MULTI_SICE_MODE_MAX_BYTES
SICE should be SLICE.
Rename these enum values, keeping the old ones (under #ifndef __KERNEL__)
for backwards compatib
On 4/12/19 5:51 PM, Philipp Zabel wrote:
> Add MPEG-2 CID definitions for profiles and levels defined in ITU-T Rec.
> H.262.
>
> Signed-off-by: Philipp Zabel
> ---
> .../media/uapi/v4l/ext-ctrls-codec.rst| 56 +++
> drivers/media/v4l2-core/v4l2-ctrls.c | 23 +
33 matches
Mail list logo
