[PATCH] [media] wl128x: prevent two potential buffer overflows

Smatch marks skb->data as untrusted so it warns that "evt_hdr->dlen" can copy up to 255 bytes and we only have room for two bytes. Even if this comes from the firmware and we trust it, the new policy generally is just to fix it as kernel hardenning. I can't test this code so I tried to be very co

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Mar 26 05:00:11 CET 2019 media-tree git hash:149e31e90b505ae0cc909bd0d92b2ba4826574d6 media_build git

Re: [PATCH] media:staging/intel-ipu3: parameter buffer refactoring

On Mon, Mar 25, 2019 at 6:52 PM Bingbu Cao wrote: > > > > On 3/25/19 12:20 PM, Tomasz Figa wrote: > > On Mon, Mar 25, 2019 at 1:12 PM Bingbu Cao > > wrote: > >> > >> > >> > >> On 3/25/19 11:16 AM, Tomasz Figa wrote: > >>> Hi Bingbu, > >>> > >>> On Wed, Mar 13, 2019 at 1:25 PM Bingbu Cao > >>>

Re: [PATCH] media: rc: xbox_remote: add protocol and set timeout

Nice! With this applied the remote feels a lot more snugly. In the forum thread you talked about a toggle bit to distiguish new button presses from held down buttons. The packet send by the Xbox Remote includes how much time has passed since the last packet was sent. u16 last_press_ms = le16_to_c

[PATCH 5/5] media: hfi_parser: don't trick gcc with a wrong expected size

Smatch warns about small size on two structs: drivers/media/platform/qcom/venus/hfi_parser.c:103 parse_profile_level() error: memcpy() 'proflevel' too small (8 vs 128) drivers/media/platform/qcom/venus/hfi_parser.c: drivers/media/platform/qcom/venus/hfi_parser.c:129 parse_caps()

[PATCH 2/5] media: pwc-ctl: pChoose can't be NULL

The way the code works, compression will be a valid value (less or equal to 3) on both set_video_mode_foo() calls at the beginning of the while() loop. So, the value for pChoose can't be NULL. Solves those smatch warnings: drivers/media/usb/pwc/pwc-ctrl.c: drivers/media/usb/pwc/pwc-ctrl.

[PATCH 0/5] Fix smatch warnings

Fix smatch warnings on media subsystem. Mauro Carvalho Chehab (5): media: cx2341x: replace badly designed macros media: pwc-ctl: pChoose can't be NULL media: sti/delta: remove uneeded check media: rcar-dma: p_set can't be NULL media: hfi_parser: don't trick gcc with a wrong expected size

[PATCH 3/5] media: sti/delta: remove uneeded check

At the error logic, ipc_buf was already asigned to &ctx->ipc_buf_struct, with can't be null, as warned by smatch: drivers/media/platform/sti/delta/delta-ipc.c:223 delta_ipc_open() warn: variable dereferenced before check 'ctx->ipc_buf' (see line 183) So, remove the uneeded check. Signed

[PATCH 1/5] media: cx2341x: replace badly designed macros

There are some macros at cx2341x_update() with seemed to be introduced in order to ensure that lines would be less than 80 columns. Well, the thing is that they make the code harder to be analized, not only by humans, but also for static code analyzers: drivers/media/common/cx2341x.c:1116

Re: [RFC PATCH V0 5/7] dts: arm64: mt8183: Add FD nodes

On Wed, Feb 20, 2019 at 03:48:11PM +0800, Jerry-ch Chen wrote: > This patch adds nodes for Face Detection (FD) unit. FD is embedded > in Mediatek SoCs and works with the co-processor to perform face > detection on the input data and image and output detected face result. > > Signed-off-by: Jerry-c

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

Em Mon, 25 Mar 2019 17:33:30 +0100 Samuel CHEMLA escreveu: > Hi guys, > > I'm afraid I'm coming with sad news. > I just tried both stable-1.12 and stable-1.16 on a raspberry pi 2, and > random hangs are back (see https://bugs.launchpad.net/raspbian/+bug/1819650 > ). > I previously test both bran

Re: [PATCH v2 02/11] media: Introduce helpers to fill pixel format structs

Hi Ezequiel, On 2019/03/04, Ezequiel Garcia wrote: > + > +/* Pixel format and FourCC helpers */ > + > +/** > + * struct v4l2_format_info - information about a V4L2 format > + * @format: 4CC format identifier (V4L2_PIX_FMT_*) > + * @mem_planes: Number of memory planes, which includes the alpha pla

Attention Dear,

-- Attention Dear, I am personal representative to my late client, a national of your country, and the CEO of his own Construction Company here in Benin Republic West Africa. On the 27th of May 2015, my client, His wife and their only daughter were involved in a car accident Along express-high wa

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

On 3/25/19 4:11 PM, Jacopo Mondi wrote: > Hi Laurent, Bingbu > > On Mon, Mar 25, 2019 at 06:06:30AM +0200, Laurent Pinchart wrote: >> Hi Bingbu, >> > [snip] > Thank you for the information. This will need to be captured in the documentation, along with information re

Re: [PATCH] media:staging/intel-ipu3: parameter buffer refactoring

On 3/25/19 12:20 PM, Tomasz Figa wrote: > On Mon, Mar 25, 2019 at 1:12 PM Bingbu Cao wrote: >> >> >> >> On 3/25/19 11:16 AM, Tomasz Figa wrote: >>> Hi Bingbu, >>> >>> On Wed, Mar 13, 2019 at 1:25 PM Bingbu Cao >>> wrote: On 03/12/2019 04:54 PM, Tomasz Figa wrote: > On

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

On Mon, Mar 18, 2019 at 1:10 AM Laurent Pinchart wrote: > > Hi Tomasz, > > On Fri, Mar 15, 2019 at 01:18:17PM +0900, Tomasz Figa wrote: > > On Fri, Oct 26, 2018 at 10:42 PM Laurent Pinchart wrote: > > > On Friday, 26 October 2018 14:41:26 EEST Tomasz Figa wrote: > > >> On Thu, Sep 20, 2018 at 11:4

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

Hi Laurent, Bingbu On Mon, Mar 25, 2019 at 06:06:30AM +0200, Laurent Pinchart wrote: > Hi Bingbu, > [snip] > > > > > > Thank you for the information. This will need to be captured in the > > > documentation, along with information related to how each block in the > > > hardware pi