cron job: media_tree daily build: ERRORS

2019-03-20 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Mar 21 05:00:13 CET 2019 media-tree git hash:8a3946cad244e8453e26f3ded5fe40bf2627bb30 media_build git

[PATCH -next] media: si2165: fix platform_no_drv_owner.cocci warnings

2019-03-20 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- drivers/media/dvb-frontends/si2165.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/dvb-frontends/si2165.c b/drivers/

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

2019-03-20 Thread Gregor Jasny
Hello Mauro, On 19.03.19 20:45, Mauro Carvalho Chehab wrote: Hi Gregor, Samuel reported in priv that the issues he had with user after free were solved by the patchsets merged at 1.12 and 1.16 stable branches. Could you please generate a new staging release for them? Sure, I can create a new

Re: [RFC PATCH 3/3] media: v4l2: Add extended buffer operations

2019-03-20 Thread Nicolas Dufresne
Le mardi 19 mars 2019 à 15:52 +0100, Boris Brezillon a écrit : > From: Hans Verkuil > > Those extended buffer ops have several purpose: > 1/ Fix y2038 issues by converting the timestamp into an u64 counting >the number of ns elapsed since 1970 > 2/ Unify single/multiplanar handling > 3/ Add a

Re: [RFC 3/8] v4l2-fwnode: Use v4l2_async_notifier_add_fwnode_remote_subdev

2019-03-20 Thread Niklas Söderlund
Hi Sakari, Thanks for your work. On 2019-03-18 21:16:48 +0200, Sakari Ailus wrote: > Shorten v4l2_async_notifier_fwnode_parse_endpoint by using > v4l2_async_notifier_add_fwnode_remote_subdev. > > Signed-off-by: Sakari Ailus > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 12 ++-- > 1 f

Re: [RFC v1.1 1/8] v4l2-async: Use endpoint node, not device node, for fwnode match

2019-03-20 Thread Niklas Söderlund
Hi Sakari, Thanks for your work. On 2019-03-19 15:02:00 +0200, Sakari Ailus wrote: [snip] > diff --git a/drivers/media/platform/rcar_drif.c > b/drivers/media/platform/rcar_drif.c > index c417ff8f6fe5..39da118f882a 100644 > --- a/drivers/media/platform/rcar_drif.c > +++ b/drivers/media/platform/r

Re: [PATCH] media: Kconfig files: use the right help coding style

2019-03-20 Thread Hans Verkuil
On 3/20/19 2:41 PM, Mauro Carvalho Chehab wrote: > Checkpatch wants to use 'help' instead of '---help---': > > WARNING: prefer 'help' over '---help---' for new help texts > > Let's change it globally at the media subsystem, as otherwise people > would keep using the old way. Acked-by: Hans

[GIT PULL FOR v5.2] vicodec: support the stateless decoder

2019-03-20 Thread Hans Verkuil
Hi Mauro, This series adds support for a stateless decoder to vicodec. Patches 1-3 add support for the vb2 requires_requests flag and return EBADR instead of EACCES when requests are used when they shouldn't or vice versa. Patches 4-17 fix bugs and prepare vicodec for adding the stateless decode

Re: [PATCH v5.1 3/2] media requests: return EBADR instead of EACCES

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 15:23:07 +0100 Hans Verkuil escreveu: > If requests are used when they shouldn't, or not used when they should, then > return EBADR (Invalid request descriptor) instead of EACCES. > > The reason for this change is that EACCES has more to do with permissions > (not being the o

[PATCH v5.1 3/2] media requests: return EBADR instead of EACCES

2019-03-20 Thread Hans Verkuil
If requests are used when they shouldn't, or not used when they should, then return EBADR (Invalid request descriptor) instead of EACCES. The reason for this change is that EACCES has more to do with permissions (not being the owner of the resource), but in this case the request file descriptor is

[PATCH] media: Kconfig files: use the right help coding style

2019-03-20 Thread Mauro Carvalho Chehab
Checkpatch wants to use 'help' instead of '---help---': WARNING: prefer 'help' over '---help---' for new help texts Let's change it globally at the media subsystem, as otherwise people would keep using the old way. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/Kconfig

Re: [PATCH v5.1 1/2] vb2: add requires_requests bit for stateless codecs

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 14:06:51 +0100 Hans Verkuil escreveu: > On 3/20/19 1:55 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 20 Mar 2019 13:33:04 +0100 > > hverkuil-ci...@xs4all.nl escreveu: > > > >> From: Hans Verkuil > >> > >> Stateless codecs require the use of the Request API as opposed of it

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 13:41:42 +0100 Hans Verkuil escreveu: > On 3/20/19 1:37 PM, Mauro Carvalho Chehab wrote: > > Em Wed, 20 Mar 2019 13:20:07 +0100 > > Hans Verkuil escreveu: > > > The only affected driver is the staging cedrus driver. And that will > actually crash if you try to us

Re: [PATCH v5.1 1/2] vb2: add requires_requests bit for stateless codecs

2019-03-20 Thread Hans Verkuil
On 3/20/19 1:55 PM, Mauro Carvalho Chehab wrote: > Em Wed, 20 Mar 2019 13:33:04 +0100 > hverkuil-ci...@xs4all.nl escreveu: > >> From: Hans Verkuil >> >> Stateless codecs require the use of the Request API as opposed of it >> being optional. >> >> So add a bit to indicate this and let vb2 check fo

Re: [PATCH v5.1 2/2] cedrus: set requires_requests

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 13:33:05 +0100 hverkuil-ci...@xs4all.nl escreveu: > From: Hans Verkuil > > The cedrus stateless decoder requires the use of request, so > indicate this by setting requires_requests to 1. > > Note that the cedrus driver never checked for this, and as far > as I can tell would

Re: [PATCH v5.1 1/2] vb2: add requires_requests bit for stateless codecs

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 13:33:04 +0100 hverkuil-ci...@xs4all.nl escreveu: > From: Hans Verkuil > > Stateless codecs require the use of the Request API as opposed of it > being optional. > > So add a bit to indicate this and let vb2 check for this. > > If an attempt is made to queue a buffer withou

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Hans Verkuil
On 3/20/19 1:37 PM, Mauro Carvalho Chehab wrote: > Em Wed, 20 Mar 2019 13:20:07 +0100 > Hans Verkuil escreveu: > The only affected driver is the staging cedrus driver. And that will actually crash if you try to use it without requests. If you look at patch 3 you'll see that it

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 13:20:07 +0100 Hans Verkuil escreveu: > >> The only affected driver is the staging cedrus driver. And that will > >> actually crash if you try to use it without requests. > >> > >> If you look at patch 3 you'll see that it just sets the flag and doesn't > >> remove any code th

[PATCH v5.1 0/2] add requires_requests bit for stateless codecs

2019-03-20 Thread hverkuil-cisco
From: Hans Verkuil These two patches replace patches 1-3 of the vicodec v5 patch series: https://www.spinics.net/lists/linux-media/msg147923.html The original patch 2/23 (videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS) was dropped. This needs a bit more thought. Patch 1 now returns EBADR if an

[PATCH v5.1 1/2] vb2: add requires_requests bit for stateless codecs

2019-03-20 Thread hverkuil-cisco
From: Hans Verkuil Stateless codecs require the use of the Request API as opposed of it being optional. So add a bit to indicate this and let vb2 check for this. If an attempt is made to queue a buffer without an associated request, then the EBADR error is returned to userspace. Doing this che

[PATCH v5.1 2/2] cedrus: set requires_requests

2019-03-20 Thread hverkuil-cisco
From: Hans Verkuil The cedrus stateless decoder requires the use of request, so indicate this by setting requires_requests to 1. Note that the cedrus driver never checked for this, and as far as I can tell would just crash if an attempt was made to queue a buffer without a request. Signed-off-b

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Hans Verkuil
On 3/20/19 12:42 PM, Mauro Carvalho Chehab wrote: > Em Wed, 20 Mar 2019 11:39:47 +0100 > Hans Verkuil escreveu: > >> On 3/20/19 11:11 AM, Mauro Carvalho Chehab wrote: >>> Em Wed, 6 Mar 2019 13:13:22 -0800 >>> Dafna Hirschfeld escreveu: >>> From: Hans Verkuil Add capability to

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 20 Mar 2019 11:39:47 +0100 Hans Verkuil escreveu: > On 3/20/19 11:11 AM, Mauro Carvalho Chehab wrote: > > Em Wed, 6 Mar 2019 13:13:22 -0800 > > Dafna Hirschfeld escreveu: > > > >> From: Hans Verkuil > >> > >> Add capability to indicate that requests are required instead of > >> mere

Re: [PATCH v5 01/23] vb2: add requires_requests bit for stateless codecs

2019-03-20 Thread Hans Verkuil
On 3/20/19 11:21 AM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Mar 2019 13:13:21 -0800 > Dafna Hirschfeld escreveu: > >> From: Hans Verkuil >> >> Stateless codecs require the use of the Request API as opposed of it >> being optional. >> >> So add a bit to indicate this and let vb2 check for this

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Hans Verkuil
On 3/20/19 11:11 AM, Mauro Carvalho Chehab wrote: > Em Wed, 6 Mar 2019 13:13:22 -0800 > Dafna Hirschfeld escreveu: > >> From: Hans Verkuil >> >> Add capability to indicate that requests are required instead of >> merely supported. > > Not sure if I liked this patch, and for sure it lacks a lot

Re: [GIT PULL FOR v5.2] vicodec: support the stateless decoder

2019-03-20 Thread Mauro Carvalho Chehab
Em Thu, 14 Mar 2019 09:04:24 +0100 Hans Verkuil escreveu: > Hi Mauro, > > This series adds support for a stateless decoder to vicodec. > > The first two patches are to vicodec bug fixes. I applied those. > Patches 3-5 add the V4L2_BUF_CAP_REQUIRES_REQUESTS flag: this will be used > for statel

Re: [PATCH v5 01/23] vb2: add requires_requests bit for stateless codecs

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 6 Mar 2019 13:13:21 -0800 Dafna Hirschfeld escreveu: > From: Hans Verkuil > > Stateless codecs require the use of the Request API as opposed of it > being optional. > > So add a bit to indicate this and let vb2 check for this. > > Signed-off-by: Hans Verkuil > --- > drivers/media/c

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-20 Thread Mauro Carvalho Chehab
Em Wed, 6 Mar 2019 13:13:22 -0800 Dafna Hirschfeld escreveu: > From: Hans Verkuil > > Add capability to indicate that requests are required instead of > merely supported. Not sure if I liked this patch, and for sure it lacks a lot of documentation: First of all, the patch description doesn't

Re: ir-keytable known bug -- fails to work when device specified

2019-03-20 Thread Sean Young
On Tue, Mar 19, 2019 at 08:14:45PM -0400, Adam Di Carlo wrote: > Sean Young writes: > > Adam wrote: > >> Rather than document all this, isn't better to clean it up in the > >> source? I can probably come up with a patch for this issue in fairly > >> short order, if that's welcome. > > > > You're