cron job: media_tree daily build: WARNINGS

2019-03-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 13 05:00:13 CET 2019 media-tree git hash:15d90a6ae98e6d2c68497b44a491cb9efbb98ab1 media_build git

Re: [PATCH] media:staging/intel-ipu3: parameter buffer refactoring

2019-03-12 Thread Bingbu Cao
On 03/12/2019 04:54 PM, Tomasz Figa wrote: On Tue, Mar 12, 2019 at 5:48 PM Bingbu Cao wrote: On 03/12/2019 03:43 PM, Tomasz Figa wrote: On Tue, Mar 12, 2019 at 3:48 PM Bingbu Cao wrote: On 03/12/2019 01:33 PM, Tomasz Figa wrote: Hi Bingbu, On Fri, Feb 15, 2019 at 6:02 PM wrote: Fro

Re: [linux-uvc-devel] HD Camera (4e45:5501) support

2019-03-12 Thread Laurent Pinchart
Hello Amila, On Tue, Mar 05, 2019 at 04:50:47PM +0100, Amila Manoj wrote: > Hi Laurent, > > Thank you very much for the reply. > > I tried it on a Windows 10 computer and it worked fine without > installing any additional software. > > Also managed to capture USB traffic on Linux (didn't captur

[PATCH v4l-utils] lircd2toml: toggle_bit is offset from bits including pre-data

2019-03-12 Thread Sean Young
This causes the following lircd.conf to be converted incorrectly. http://lirc.sourceforge.net/remotes/cambridge_audio/X40A Signed-off-by: Sean Young --- contrib/lircd2toml.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/contrib/lircd2toml.py b/contrib

Re: [PATCH 0/2] media: ov7670: fix regressions caused by "hook s_power onto v4l2 core"

2019-03-12 Thread Lubomir Rintel
On Tue, 2019-03-12 at 00:36 +0900, Akinobu Mita wrote: > This patchset fixes the problems introduced by recent change to ov7670. > > Akinobu Mita (2): > media: ov7670: restore default settings after power-up > media: ov7670: don't access registers when the device is powered off > > drivers/m

Re: [PATCH v5 06/23] media: v4l2-ctrl: v4l2_ctrl_request_setup returns with error upon failure

2019-03-12 Thread Paul Kocialkowski
Hi Dafna, On Wed, 2019-03-06 at 13:13 -0800, Dafna Hirschfeld wrote: > If one of the controls fails to set, > then 'v4l2_ctrl_request_setup' > immediately returns with the error code. Very neat idea, the error should definitely be propagated! We should update the cedrus driver to take this into

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2019-03-12 Thread Rui Miguel Silva
Hi Laurent, On Tue 12 Mar 2019 at 15:10, Laurent Pinchart wrote: Hi Rui, On Tue, Mar 12, 2019 at 02:07:02PM +, Rui Miguel Silva wrote: On Sun 10 Mar 2019 at 21:48, Laurent Pinchart wrote: > On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva > wrote: >> On Fri 18 May 2018 at 06:58

Re: [PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2019-03-12 Thread Rui Miguel Silva
Hi Laurent, On Tue 12 Mar 2019 at 14:10, Laurent Pinchart wrote: Hi Rui, On Tue, Mar 12, 2019 at 02:05:24PM +, Rui Miguel Silva wrote: On Sun 10 Mar 2019 at 21:41, Laurent Pinchart wrote: > Hi Rui, > > Thank you for the patch. Where have you been for the latest 14 versions? :) Elsewhere

Re: [PATCH v5 03/23] cedrus: set requires_requests

2019-03-12 Thread Paul Kocialkowski
Hi, On Wed, 2019-03-06 at 13:13 -0800, Dafna Hirschfeld wrote: > From: Hans Verkuil > > The cedrus stateless decoder requires the use of request, so > indicate this by setting requires_requests to 1. > > Signed-off-by: Hans Verkuil Note that this is true for now, but we might need to get rid

Re: [PATCH v5 02/23] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-03-12 Thread Paul Kocialkowski
Hi, On Wed, 2019-03-06 at 13:13 -0800, Dafna Hirschfeld wrote: > From: Hans Verkuil > > Add capability to indicate that requests are required instead of > merely supported. > > Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Cheers, Paul > --- > Documentation/media/uapi/v4l/vi

Re: [PATCH v5 01/23] vb2: add requires_requests bit for stateless codecs

2019-03-12 Thread Paul Kocialkowski
Hi, On Wed, 2019-03-06 at 13:13 -0800, Dafna Hirschfeld wrote: > From: Hans Verkuil > > Stateless codecs require the use of the Request API as opposed of it > being optional. > > So add a bit to indicate this and let vb2 check for this. > > Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocia

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2019-03-12 Thread Laurent Pinchart
Hi Rui, On Tue, Mar 12, 2019 at 02:07:02PM +, Rui Miguel Silva wrote: > On Sun 10 Mar 2019 at 21:48, Laurent Pinchart wrote: > > On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: > >> On Fri 18 May 2018 at 06:58, Sakari Ailus wrote: > >>> On Thu, May 17, 2018 at 01:50:27PM +010

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

2019-03-12 Thread Gregor Jasny
Hello Mauro, below you find a bug report about an use-after-free in dvbv5-zap. On 12.03.19 13:37, CHEMLA Samuel wrote: please find a bug report that seems to concern ARMHF builds of dvbv5-zap (dvb-tool package) : https://bugs.launchpad.net/raspbian/+bug/1819650 I filed it against raspbian becau

Re: [PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2019-03-12 Thread Laurent Pinchart
Hi Rui, On Tue, Mar 12, 2019 at 02:05:24PM +, Rui Miguel Silva wrote: > On Sun 10 Mar 2019 at 21:41, Laurent Pinchart wrote: > > Hi Rui, > > > > Thank you for the patch. > > Where have you been for the latest 14 versions? :) Elsewhere I suppose :-) > This is already merged, but... follow up

Re: [PATCH v4 06/12] media: dt-bindings: add bindings for i.MX7 media driver

2019-03-12 Thread Rui Miguel Silva
Hi Laurent, On Sun 10 Mar 2019 at 21:48, Laurent Pinchart wrote: Hi Rui, On Fri, May 18, 2018 at 09:27:58AM +0100, Rui Miguel Silva wrote: Hi Sakari, Thanks for the review. On Fri 18 May 2018 at 06:58, Sakari Ailus wrote: > On Thu, May 17, 2018 at 01:50:27PM +0100, Rui Miguel Silva > wrote:

Re: [PATCH v14 08/13] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2019-03-12 Thread Rui Miguel Silva
Hi Laurent, On Sun 10 Mar 2019 at 21:41, Laurent Pinchart wrote: Hi Rui, Thank you for the patch. Where have you been for the latest 14 versions? :) This is already merged, but... follow up patches can address your issues bellow. On Wed, Feb 06, 2019 at 03:13:23PM +, Rui Miguel Silva

Re: media: rockchip: the memory layout of multiplanes buffer for DMA address

2019-03-12 Thread ayaka
On 3/12/19 4:22 PM, Tomasz Figa wrote: On Thu, Feb 28, 2019 at 12:13 AM Ayaka wrote: Hello all I am writing the v4l2 decoder driver for rockchip. Although I hear the suggest from the Hans before, it is ok for decoder to use single plane buffer format, but I still decide to the multi planes

Re: [PATCH] media: vb2-dc: skip CPU sync in map/unmap dma_buf

2019-03-12 Thread Lucas Stach
Hi Hans, Am Dienstag, den 12.03.2019, 08:57 +0100 schrieb Hans Verkuil: > Pawel and/or Marek, can you take a look at this? > > It looks sane to me, but I'd like to have a second opinion as well before > merging this. > > On 2/28/19 8:19 AM, Lucas Stach wrote: > > This is rougly equivalent to ca0

[GIT PULL FOR v5.2] Various fixes/enhancements part 3

2019-03-12 Thread Hans Verkuil
Helen, I dropped patches 4 and 8 from your series. I've asked Ezequiel to make changes to the format info helper patch and patch 4 depends on that, and patch 8 because it introduces a bug. I've merged the other 6 patches of your series. Regards, Hans The following changes since commit

Re: [PATCH] media:staging/intel-ipu3: parameter buffer refactoring

2019-03-12 Thread Tomasz Figa
On Tue, Mar 12, 2019 at 5:48 PM Bingbu Cao wrote: > > > > On 03/12/2019 03:43 PM, Tomasz Figa wrote: > > On Tue, Mar 12, 2019 at 3:48 PM Bingbu Cao > > wrote: > >> > >> > >> On 03/12/2019 01:33 PM, Tomasz Figa wrote: > >>> Hi Bingbu, > >>> > >>> On Fri, Feb 15, 2019 at 6:02 PM wrote: > Fro

Re: [PATCH] media:staging/intel-ipu3: parameter buffer refactoring

2019-03-12 Thread Bingbu Cao
On 03/12/2019 03:43 PM, Tomasz Figa wrote: On Tue, Mar 12, 2019 at 3:48 PM Bingbu Cao wrote: On 03/12/2019 01:33 PM, Tomasz Figa wrote: Hi Bingbu, On Fri, Feb 15, 2019 at 6:02 PM wrote: From: Bingbu Cao Current ImgU driver processes and releases the parameter buffer immediately after

Re: [PATCH v2 02/11] media: Introduce helpers to fill pixel format structs

2019-03-12 Thread Hans Verkuil
On 3/4/19 8:25 PM, Ezequiel Garcia wrote: > Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, > to be used by drivers to calculate plane sizes and bytes per lines. > > Note that driver-specific padding and alignment are not > taken into account, and must be done by drivers using t

Re: media: rockchip: the memory layout of multiplanes buffer for DMA address

2019-03-12 Thread Tomasz Figa
On Thu, Feb 28, 2019 at 12:13 AM Ayaka wrote: > > Hello all > > I am writing the v4l2 decoder driver for rockchip. Although I hear the > suggest from the Hans before, it is ok for decoder to use single plane buffer > format, but I still decide to the multi planes format. > > There is not a regis

Re: [PATCH] media: Drop superfluous PCM preallocation error checks

2019-03-12 Thread Hans Verkuil
Hi Takashi, On 2/6/19 6:32 PM, Takashi Iwai wrote: > snd_pcm_lib_preallocate_pages() and co always succeed, so the error > check is simply redundant. Drop it. > > Signed-off-by: Takashi Iwai Acked-by: Hans Verkuil I can take it as for 5.2, but you can as well with my Ack. If you want me to t

Re: [PATCH] media: vb2-dc: skip CPU sync in map/unmap dma_buf

2019-03-12 Thread Hans Verkuil
Pawel and/or Marek, can you take a look at this? It looks sane to me, but I'd like to have a second opinion as well before merging this. On 2/28/19 8:19 AM, Lucas Stach wrote: > This is rougly equivalent to ca0e68e21aae (drm/prime: skip CPU sync > in map/unmap dma_buf). The contig memory allocate

Re: [PATCH] media:staging/intel-ipu3: parameter buffer refactoring

2019-03-12 Thread Tomasz Figa
On Tue, Mar 12, 2019 at 3:48 PM Bingbu Cao wrote: > > > > On 03/12/2019 01:33 PM, Tomasz Figa wrote: > > Hi Bingbu, > > > > On Fri, Feb 15, 2019 at 6:02 PM wrote: > >> From: Bingbu Cao > >> > >> Current ImgU driver processes and releases the parameter buffer > >> immediately after queued from us