On Thu, Mar 07, 2019 at 12:00:59PM +0900, Tomasz Figa wrote:
> On Thu, Mar 7, 2019 at 12:00 PM Tomasz Figa wrote:
> >
> > Hi Sakari,
> >
> > On Wed, Feb 20, 2019 at 8:21 PM Sakari Ailus
> > wrote:
> > >
> > > __aligned() is preferred. The patch has been generated using the following
> > > command
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Mar 7 05:00:15 CET 2019
media-tree git hash:15d90a6ae98e6d2c68497b44a491cb9efbb98ab1
media_build git
On Thu, Mar 7, 2019 at 12:00 PM Tomasz Figa wrote:
>
> Hi Sakari,
>
> On Wed, Feb 20, 2019 at 8:21 PM Sakari Ailus
> wrote:
> >
> > __aligned() is preferred. The patch has been generated using the following
> > command in the drivers/staging/media/ipu3 directory:
> >
> > $ git grep -l 'aligned(32
Hi Sakari,
On Wed, Feb 20, 2019 at 8:21 PM Sakari Ailus
wrote:
>
> __aligned() is preferred. The patch has been generated using the following
> command in the drivers/staging/media/ipu3 directory:
>
> $ git grep -l 'aligned(32)' | \
> xargs perl -i -pe \
>
> 's/__attribute__\s*\(
Hi Hans, Laurent,
On 2019-03-01 15:06:13 +0200, Laurent Pinchart wrote:
> Hi Hans,
>
> On Fri, Mar 01, 2019 at 01:55:53PM +0100, Hans Verkuil wrote:
> > Hi Fabrizio,
> >
> > It looks like this series fell through the cracks.
> >
> > I looked at it and the main problem is that it is missing a Re
Hi Laurent,
On 2019-03-07 02:26:45 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> On Thu, Mar 07, 2019 at 01:22:36AM +0100, Niklas Söderlund wrote:
> > On 2019-03-07 02:13:18 +0200, Laurent Pinchart wrote:
> > > On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> > >> Allow the h
Hi Kieran,
Thanks for your feedback.
On 2019-02-18 11:19:50 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 18/02/2019 10:03, Niklas Söderlund wrote:
> > Latest datasheet (rev 1.50) clarifies that the FLD register should be
> > set after LINKCNT.
> >
> > Signed-off-by: Niklas Söderlund
> > --
Hi Kieran,
Thanks for your feedback.
On 2019-02-18 11:01:51 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 18/02/2019 10:03, Niklas Söderlund wrote:
> > Latest information from hardware engineers reveals that H3 ES2 and ES3
> > of behaves differently when working with link speeds bellow 250 Mp
Hi Ulrich,
Thanks for your feedback.
On 2019-02-18 12:12:19 +0100, Ulrich Hecht wrote:
>
> > On February 18, 2019 at 11:03 AM Niklas Söderlund
> > wrote:
> >
> >
> > Latest information from hardware engineers reveals that H3 ES2 and ES3
> > of behaves differently when working with link speed
Hi Niklas,
On Thu, Mar 07, 2019 at 01:22:36AM +0100, Niklas Söderlund wrote:
> On 2019-03-07 02:13:18 +0200, Laurent Pinchart wrote:
> > On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> >> Allow the hardware to to do proper field detection for interlaced field
> >> formats by im
Hi Laurent,
Thanks for your feedback.
On 2019-03-07 02:13:18 +0200, Laurent Pinchart wrote:
> Hi Niklas,
>
> Thank you for the patch.
>
> On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> > Allow the hardware to to do proper field detection for interlaced field
> > formats by
Hi Niklas,
Thank you for the patch.
On Sat, Feb 16, 2019 at 11:57:58PM +0100, Niklas Söderlund wrote:
> Allow the hardware to to do proper field detection for interlaced field
> formats by implementing s_std() and g_std(). Depending on which video
> standard is selected the driver needs to setup
Hi Geert,
Thanks for your feedback.
On 2019-02-18 10:07:04 +0100, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Sun, Feb 17, 2019 at 8:54 AM Niklas Söderlund
> wrote:
> > Later versions of the datasheet updates the reset procedure to more
> > closely resemble the standby mode. Update the driver
Hi Sergei,
Thanks for your feedback.
On 2019-02-17 11:47:28 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 17.02.2019 1:57, Niklas Söderlund wrote:
>
> > Allow the hardware to to do proper field detection for interlaced field
> > formats by implementing s_std() and g_std(). Depending on which vi
Hi Jacopo,
Thanks for your feedback.
On 2019-02-17 19:41:40 +0100, Jacopo Mondi wrote:
> Hi Niklas,
> where is this patch supposed to be applied on?
>
> I tried master, media master, renesas-drivers and your rcar-csi2 and
> v4l2/mux branches, but it fails on all of them :(
>
> What am I doi
Hi Jacopo,
Thanks for your feedback.
On 2019-02-17 20:41:24 +0100, Jacopo Mondi wrote:
> Hi Niklas,
>ah, ups, this was maybe the patch the other one I just reviewed was
>based on... sorry, I missed this one :)
:-)
>
> On Sat, Feb 16, 2019 at 11:56:38PM +0100, Niklas Söderlund wrote:
>
The s_stream callback was not being called for the first entity in the
stream pipeline array.
Instead of verifying the type of the node (video or subdevice) and
calling s_stream from the second entity in the pipeline, do this process
for all the entities in the pipeline for consistency.
The previo
Media bus codes were being mapped to pixelformats, which causes a
limitation on vimc because not all pixelformats can be mapped to media
bus codes.
Also, media bus codes are an internal configuration from the device.
Userspace only assures media bus codes matches between pads and expects
the image
There is no need to have the frame field in the vimc_stream struct.
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-streamer.c | 10 --
drivers/media/platform/vimc/vimc-streamer.h | 1 -
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/media/platfo
Add missing documentation for struct vimc_stream
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-streamer.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/media/platform/vimc/vimc-streamer.h
b/drivers/media/platform/vimc/vimc-streamer.h
index dc1d0
Add bayer format information in struct v4l2_format_info table.
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-common.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-common.c
b/drivers/media/v4l2-core/v4l2-common.c
index 11
The type V4L2_FRMSIZE_TYPE_CONTINUOUS expects a step of 1.
This fixes v4l2-compliance test error:
fail: v4l2-test-formats.cpp(184): invalid step_width/height for
continuous framesize
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL
Signed-off-by: Helen Koike
---
drivers/media/plat
The format of the sink pad should be a bayer mbus format.
This fixes a kernel NULL pointer dereference error that was caused when
the stream starts because the configured format was not found in the
pixelmap table.
Reported-by: Hans Verkuil
Signed-off-by: Helen Koike
---
drivers/media/platfor
The state TASK_UNINTERRUPTIBLE should be set just before
schedule_timeout() call, so it knows the sleep mode it should enter.
There is no point in setting TASK_UNINTERRUPTIBLE at the initialization
of the thread as schedule_timeout() will set the state back to
TASK_RUNNING.
This fixes a warning in
Hello,
This patch series has several vimc fixes (that I am sending in the same
series only for convenience, let me know if you prefer them to be
sent separately from the series).
The last commit removes the vimc_pix_map_list[] that was mapping
pixelformats with media bus formats, but it turns out
Am 05.03.19 um 22:17 schrieb Sean Young:
> On Fri, Dec 21, 2018 at 09:24:46AM +0100, Matthias Schwarzott wrote:
>> Am 21.12.18 um 05:54 schrieb Kangjie Lu:
>>> si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find
>>> that "val_tmp" will be an uninitialized value when regmap_read
'read_write_padded_frame' should check that the
expected size to read/write is not larger than
the size of the buffer.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 41 ---
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/utils
In streaming_set_m2m, make sure to close all file pointers
and file descriptors before returning.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
b/utils/v4
set the in/out fmt variables in streaming_set_m2m
This is needed later to check for stateless
fwht pixel format.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-
Add code to support the stateless decoder
and the function 'stateless_m2m' that implements it.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 218 +-
1 file changed, 210 insertions(+), 8 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-strea
copy fwht-ctrls.h from the kernel dir when
running 'sync' and add typedef for u64
in codec-fwht.h
Signed-off-by: Dafna Hirschfeld
---
Makefile.am | 1 +
utils/common/codec-fwht.patch | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makef
Add the variable 'last_fwht_bf_ts' and the array 'fwht_reqs' to
allow the fwht stateless decoder to maintain the requests.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 138 ++
1 file changed, 138 insertions(+)
diff --git a/utils/v4l2-ctl/v4
Add stateless decoder instance field to the dev struct and
register another node for the statelsess decoder.
The stateless API for the node will be implemented in further patches.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 46 +--
1 file c
Add structs and definitions needed to implement stateless
decoder for fwht and add I/P-frames QP controls to the
public api.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 41 ++-
drivers/media/v4l2-core/v4l2-ctrls.c | 12 ++
incl
for stateless decoder, set the output pixelformat
to V4L2_PIX_FMT_FWHT_STATELESS and the pix info to
pixfmt_stateless_fwht
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 47 ++-
1 file changed, 35 insertions(+), 12 deletions(-)
diff --git a/d
add documentation to V4L2_PIX_FMT_FWHT_STATELESS
in pixfmt-compressed.rst
Signed-off-by: Dafna Hirschfeld
---
Documentation/media/uapi/v4l/pixfmt-compressed.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst
b/Documentation/media/uap
Implement a stateless decoder for the new node.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 286 --
2 files changed, 263 insertions(+), 24 deletions(-)
diff --git a/drivers/media/platf
Rename 'v4l2_fwht_default_fmt' to 'v4l2_fwht_find_nth_fmt'
and add a function 'v4l2_fwht_validate_fmt' to check if
a format info matches the parameters.
This function will also be used to validate the stateless
params when adding support for stateless codecs.
Signed-off-by: Dafna Hirschfeld
---
add documentation to V4L2_CID_FWHT_I/P_FRAME_QP
controls in ext-ctrls-codec.rst
Signed-off-by: Dafna Hirschfeld
---
Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
b/Documentation/
In the decoder, save the inner reference frame in the same
format as the capture buffer.
The decoder writes directly to the capture buffer and then
the capture buffer is copied to the reference buffer.
This will simplify the stateless decoder.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/pl
add documentation to V4L2_CID_MPEG_VIDEO_FWHT_PARAMS
control and its related 'v4l2_ctrl_fwht_params' struct
Signed-off-by: Dafna Hirschfeld
---
.../media/uapi/v4l/ext-ctrls-codec.rst| 119 ++
1 file changed, 119 insertions(+)
diff --git a/Documentation/media/uapi/v4l/ext
Add struct 'vicodec_dev_instance' for the fields in vicodec_dev
that have have both decoder and encoder versions.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 194 +-
1 file changed, 92 insertions(+), 102 deletions(-)
diff --git a/drivers/m
Introduce 'prepare_raw_frame' function that fills the values
of a raw frame struct according to the format.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 143 ++
1 file changed, 78 insertions(+), 65 deletions(-)
diff --git a/drivers/media/pl
Add the field 'buf' to fwht_raw_frame to indicate
the start of the raw frame buffer.
This field will be used to copy the capture buffer
to the reference buffer in the next patch.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 1 +
drivers/media/platform/vicod
In the stateless decoder the reference buffer is null if the
frame is an I-frame (flagged with FWHT_FL_I_FRAME).
Make sure not to dereference it in that case.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.c | 9 +
drivers/media/platform/vicodec/codec
Move the code that validates version dependent header
values to a separate function 'validate_by_version'
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 31 ---
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/media/plat
Free compressed_frame buffer upon device release.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/vicodec-core.c
index 8205a602bb3
'v4l2_m2m_ctx_release' calls request complete
so it should be called before 'v4l2_ctrl_handler_free'.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/vicodec/vicodec
The function 'v4l2_m2m_buf_copy_metadata' should
be called even if decoding/encoding ends with
status VB2_BUF_STATE_ERROR, so that the metadata
is copied from the source buffer to the dest buffer.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 17 +---
v4l2_fwht_encode returns either an error code on
failure or the size of the compressed frame on
success. So change the var assigned to it from
'ret' to 'comp_sz_or_errcode' to clarify that.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 9 +
1 file ch
If one of the controls fails to set,
then 'v4l2_ctrl_request_setup'
immediately returns with the error code.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +++---
include/media/v4l2-ctrls.h | 2 +-
2 files changed, 12 insertions(+), 8 deleti
From: Hans Verkuil
Add capability to indicate that requests are required instead of
merely supported.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4
include/uapi/linux/videodev2.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/
The selection api should check only single buffer types
because multiplanar types are converted to
single in drivers/media/v4l2-core/v4l2-ioctl.c
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 20 +++
1 file changed, 3 insertions(+), 17 deleti
From: Hans Verkuil
Stateless codecs require the use of the Request API as opposed of it
being optional.
So add a bit to indicate this and let vb2 check for this.
Signed-off-by: Hans Verkuil
---
drivers/media/common/videobuf2/videobuf2-core.c | 5 -
drivers/media/common/videobuf2/videobuf2
Main Changes from v4:
1. fixes according to the review
2. two new patches:
0015-media-vicodec-Handle-the-case-that-the-reference-buf.patch
0023-media-vicodec-set-pixelformat-to-V4L2_PIX_FMT_FWHT_S.patch
Dafna Hirschfeld (20):
media: vicodec: selection api should only check single buffer type
From: Hans Verkuil
The cedrus stateless decoder requires the use of request, so
indicate this by setting requires_requests to 1.
Signed-off-by: Hans Verkuil
---
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/sunxi/ced
Hi Jacopo,
On Wed, Mar 06, 2019 at 12:26:59PM +0100, Jacopo Mondi wrote:
> When both the media links between AFE and HDMI and the two TX CSI-2 outputs
> gets disabled, the routing register ADV748X_IO_10 gets zeroed causing both
> TXA and TXB output to get disabled.
>
> This causes some HDMI trans
Dne sreda, 06. marec 2019 ob 11:57:08 CET je Maxime Ripard napisal(a):
> Hi,
>
> On Tue, Mar 05, 2019 at 06:05:08PM +0100, Jernej Škrabec wrote:
> > Dne torek, 05. marec 2019 ob 11:17:32 CET je Maxime Ripard napisal(a):
> > > Hi Jernej,
> > >
> > > On Wed, Feb 20, 2019 at 06:50:54PM +0100, Jernej
Dear Brian,
I appreciate your comments.
On Wed, 2019-02-27 at 19:24 -0800, Brian Norris wrote:
> Hi Frederic,
>
> On Sat, Feb 23, 2019 at 02:18:54PM +0800, Frederic Chen wrote:
> > Dear Brian,
> >
> > I appreciate your comments. I'm really sorry for the delay in responding
> > to the comments
On Fri, Mar 01, 2019 at 10:38:31AM +0100, Geert Uytterhoeven wrote:
> devm_ioremap_resource() already prints an error message on failure, so
> there is no need to repeat that.
>
> Signed-off-by: Geert Uytterhoeven
> ---
> v2:
> - Drop assignment to ret.
Reviewed-by: Simon Horman
From: YueHaibing
Syzkaller report this:
BUG: KASAN: use-after-free in sysfs_remove_file_ns+0x5f/0x70 fs/sysfs/file.c:468
Read of size 8 at addr 8881f59a6b70 by task syz-executor.0/8363
CPU: 0 PID: 8363 Comm: syz-executor.0 Not tainted 5.0.0-rc8+ #3
Hardware name: QEMU Standard PC (i440FX +
When both the media links between AFE and HDMI and the two TX CSI-2 outputs
gets disabled, the routing register ADV748X_IO_10 gets zeroed causing both
TXA and TXB output to get disabled.
This causes some HDMI transmitters to stop working after both AFE and
HDMI links are disabled. Fix this by prev
Hi,
On Tue, Mar 05, 2019 at 06:05:08PM +0100, Jernej Škrabec wrote:
> Dne torek, 05. marec 2019 ob 11:17:32 CET je Maxime Ripard napisal(a):
> > Hi Jernej,
> >
> > On Wed, Feb 20, 2019 at 06:50:54PM +0100, Jernej Škrabec wrote:
> > > I really wanted to do another review on previous series but got
Здравейте,
Ваучерите за храна се нареждат сред любимите социални придобивки на работещите
хора и сред най-предпочитаните начини за стимулиране от работодателите. Те
подобряват ефективността и производителността на Вашите служители.
Благодарение на ваучерите за храна реализирате спестявания –
HI Laurent,
On Tue, Mar 05, 2019 at 10:04:58PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Mon, Mar 04, 2019 at 01:35:36PM +0100, Jacopo Mondi wrote:
> > On Fri, Feb 22, 2019 at 02:18:11PM +0200, Laurent Pinchart wrote:
> > > On Mon, Feb 18, 2019 at 10:21:07AM +0100, Jacopo Mondi wrote:
> >
Documents the protocol that user-space should follow when
communicating with stateless video decoders.
The stateless video decoding API makes use of the new request and tags
APIs. While it has been implemented with the Cedrus driver so far, it
should probably still be considered staging for a shor
66 matches
Mail list logo