On Fri, Feb 15, 2019 at 9:06 AM Ezequiel Garcia wrote:
>
> On Wed, 2019-02-13 at 21:35 -0500, Nicolas Dufresne wrote:
> > Le mer. 13 févr. 2019 à 16:23, Ezequiel Garcia
> > a écrit :
> > > Hi,
> > >
> > > On Wed, 2019-02-13 at 18:15 -0300, Ezequiel Garcia wrote:
[snip]
> > > > + __u8 version;
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Mon Feb 25 05:00:11 CET 2019
media-tree git hash:9fabe1d108ca4755a880de43f751f1c054f8894d
media_build git
Hi Michael,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v5.0-rc4 next-20190222]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-
main changes from v2:
- fixes according to the review.
- changes in 'copy_cap_to_ref' and to support NV24/42 types
- changes in the codec-fwht.c functions to support
reference frame which is not internal so stride and chroma_stride
for the refernce frame should be function parameters.
- patches 1,2
Add structs and definitions needed to implement stateless
decoder for fwht.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 15 +---
drivers/media/v4l2-core/v4l2-ctrls.c | 10 ++
include/media/fwht-ctrls.h| 35 +
Add stateless decoder instance field to the dev struct and
register another node for the statelsess decoder.
The stateless API for the node will be implemented in further patches.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 46 +--
1 file c
The function 'v4l2_m2m_buf_copy_metadata' should
be called even if decoding/encoding ends with
status VB2_BUF_STATE_ERROR, so that the metadata
is copied from the source buffer to the dest buffer.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 17 +---
Free compressed_frame buffer upon device release.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vicodec/vicodec-core.c
b/drivers/media/platform/vicodec/vicodec-core.c
index cd08f0cd4cf
Add struct 'vicodec_dev_instance' for the fields in vicodec_dev
that have have both decoder and encoder versions.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 194 +-
1 file changed, 92 insertions(+), 102 deletions(-)
diff --git a/drivers/m
Move the code that validates version dependent header
values to a separate function 'validate_by_version'
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 31 ---
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/media/plat
Rename 'v4l2_fwht_default_fmt' to 'v4l2_fwht_find_nth_fmt'
and add a function 'v4l2_fwht_validate_fmt' to check if
a format info matches the parameters.
This function will also be used to validate the stateless
params when adding support for stateless codecs.
Signed-off-by: Dafna Hirschfeld
---
Introduce 'prepare_raw_frame' function that fills the values
of a raw frame struct according to the format.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.c | 143 ++
1 file changed, 78 insertions(+), 65 deletions(-)
diff --git a/drivers/media/pl
In the decoder, save the inner reference frame in the same
format as the capture buffer.
The decoder writes directly to the capture buffer and then
the capture buffer is copied to the reference buffer.
This will simplify the stateless decoder.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/pl
Implement a stateless decoder for the new node.
Signed-off-by: Dafna Hirschfeld
---
.../media/platform/vicodec/codec-v4l2-fwht.h | 1 +
drivers/media/platform/vicodec/vicodec-core.c | 286 --
2 files changed, 263 insertions(+), 24 deletions(-)
diff --git a/drivers/media/platf
Add the field 'buf' to fwht_raw_frame to indicate
the start of the raw frame buffer.
This field will be used to copy the capture buffer
to the reference buffer in the next patch.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/codec-fwht.h | 1 +
drivers/media/platform/vicod
main changes from v2:
- fixes according to the review.
- changes in 'copy_cap_to_ref' and to support NV24/42 types
- changes in the codec-fwht.c functions to support
reference frame which is not internal so stride and chroma_stride
for the refernce frame should be function parameters.
- patches 1,2
If one of the controls fails to set,
then 'v4l2_ctrl_request_setup'
immediately returns with the error code.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/v4l2-core/v4l2-ctrls.c | 18 +++---
include/media/v4l2-ctrls.h | 2 +-
2 files changed, 12 insertions(+), 8 deleti
From: Hans Verkuil
Add capability to indicate that requests are required instead of
merely supported.
Signed-off-by: Hans Verkuil
---
Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4
include/uapi/linux/videodev2.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/
From: Hans Verkuil
Stateless codecs require the use of the Request API as opposed of it
being optional.
So add a bit to indicate this and let vb2 check for this.
Signed-off-by: Hans Verkuil
---
drivers/media/common/videobuf2/videobuf2-core.c | 5 -
drivers/media/common/videobuf2/videobuf2
v4l2_fwht_encode returns either an error code on
failure or the size of the compressed frame on
success. So change the var assigned to it from
'ret' to 'comp_sz_or_errcode' to clarify that.
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 9 +
1 file ch
The selection api should check only signal buffer types
because multiplanar types are converted to
signal in drivers/media/v4l2-core/v4l2-ioctl.c
Signed-off-by: Dafna Hirschfeld
---
drivers/media/platform/vicodec/vicodec-core.c | 20 +++
1 file changed, 3 insertions(+), 17 deleti
From: Hans Verkuil
The cedrus stateless decoder requires the use of request, so
indicate this by setting requires_requests to 1.
Signed-off-by: Hans Verkuil
---
drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/sunxi/ced
Add code to support the stateless decoder
and the function 'stateless_m2m' that implements it.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 236 +-
1 file changed, 233 insertions(+), 3 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-strea
This is a better name for
'v4l2_fwht_pixfmt_info' type and it is not
confused with 'cv4l_fmt' type.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-streaming.cpp
copy fwht-ctrls.h from the kernel dir when
running 'sync' and add typedef for u64
in codec-fwht.h
Signed-off-by: Dafna Hirschfeld
---
Makefile.am | 1 +
utils/common/codec-fwht.patch | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makef
If 'do_setup_out_buffers' returns -2 it means that
it finished queuing all output stream buffers and
the program should not terminate in that case.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/
Add an array of request file descriptors to v4l_queue
and add methods to allocate and get them.
Signed-off-by: Dafna Hirschfeld
---
utils/common/cv4l-helpers.h | 5 +
utils/common/v4l-helpers.h | 22 ++
2 files changed, 27 insertions(+)
diff --git a/utils/common/cv4l-h
For V4L2_PIX_FMT_NV24/42 types the chroma stride is twice the
luma stride. Add support for it in 'read_write_padded_frame'
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/utils/v4l2-
Add the function stateful_m2m that implements the stateful
codec api.
This is a preparation for having both stateful and stateless
implementations
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 95 ++-
1 file changed, 50 insertions(+), 45 dele
Add the variable 'last_fwht_bf_ts' and the array 'fwht_reqs' to
allow the fwht stateless decoder to maintain the requests.
Signed-off-by: Dafna Hirschfeld
---
utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 121 ++
1 file changed, 121 insertions(+)
diff --git a/utils/v4l2-ctl/v4
Changes from v2:
patches 1,2,3,6 are new
Dafna Hirschfeld (8):
v4l2-ctl: rename variable 'vic_fmt' to 'info'
v4l2-ctl: bugfix: correctly read/write V4L2_PIX_FMT_NV24 padded buffer
v4l2-ctl: test if do_setup_out_buffers returns -1 instead of non zero
v4l2-ctl: move stateful m2m decode code
31 matches
Mail list logo
