Re: [RFC PATCH V0 7/7] [media] platform: mtk-isp: Add Mediatek DIP driver

2019-02-22 Thread Frederic Chen
Dear Brian, I appreciate your comments. I'm really sorry for the delay in responding to the comments due to some mail subscribing failed issue inside my company. On Thu, 2019-02-21 at 21:36 +0800, Jungo Lin wrote: > Re-sent to Frederic due to company Mail system issue. > > On Thu, 2019-02-07 at

cron job: media_tree daily build: OK

2019-02-22 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Feb 23 05:00:22 CET 2019 media-tree git hash:9fabe1d108ca4755a880de43f751f1c054f8894d media_build git

Re: [PATCH] au0828: minor fix to a misleading comment in _close()

2019-02-22 Thread Niklas Söderlund
Hi Shuah, Thanks for your patch. On 2019-02-22 10:45:59 -0700, Shuah Khan wrote: > Fix misleading comment in _close() > > Signed-off-by: Shuah Khan > --- > drivers/media/usb/au0828/au0828-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/au0828

[PATCH] media: replace WARN_ON in __media_pipeline_start()

2019-02-22 Thread Shuah Khan
__media_pipeline_start() does WARN_ON() when active pipe doesn't match the input arg entity's pipe. Replace WARN_ON with a conditional and error message that includes names of both entities. Signed-off-by: Shuah Khan --- drivers/media/media-entity.c | 5 - 1 file changed, 4 insertions(+), 1

Re: v4l2 mem2mem compose support?

2019-02-22 Thread Tim Harvey
On Sat, Feb 16, 2019 at 1:14 PM Nicolas Dufresne wrote: > > Le sam. 16 févr. 2019 à 13:40, Hans Verkuil a écrit : > > > > On 2/16/19 4:42 PM, Nicolas Dufresne wrote: > > > Le sam. 16 févr. 2019 à 04:48, Hans Verkuil a écrit : > > >> > > >> On 2/16/19 10:42 AM, Hans Verkuil wrote: > > >>> On 2/16

[PATCH] au0828: minor fix to a misleading comment in _close()

2019-02-22 Thread Shuah Khan
Fix misleading comment in _close() Signed-off-by: Shuah Khan --- drivers/media/usb/au0828/au0828-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 7876c897cc1d..08f566006a1f 100644

[PATCH v11 1/5] media: Media Device Allocator API

2019-02-22 Thread Shuah Khan
Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Video class, two or m

[PATCH v11 2/5] media: change au0828 to use Media Device Allocator API

2019-02-22 Thread Shuah Khan
Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Video class, two or m

[PATCH v11 4/5] sound/usb: Use Media Controller API to share media resources

2019-02-22 Thread Shuah Khan
Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Video class, two or m

[PATCH v11 3/5] media: media.h: Enable ALSA MEDIA_INTF_T* interface types

2019-02-22 Thread Shuah Khan
Move PCM_CAPTURE, PCM_PLAYBACK, and CONTROL ALSA MEDIA_INTF_T* interface types back into __KERNEL__ scope to get ready for adding ALSA support for these to the media controller. Signed-off-by: Shuah Khan --- include/uapi/linux/media.h | 25 +++-- 1 file changed, 15 insertions

[PATCH v11 5/5] au0828: fix enable and disable source audio and video inconsistencies

2019-02-22 Thread Shuah Khan
Enable and disable source interfaces aren't consistent in enforcing how video and audio share the tuner resource. Fix these issues to enforce the following rules and allow sharing between audio and video applications. - When DVB is streaming, audio/video/vbi/s-video/composite should find the re

[PATCH v11 0/5] Media Device Allocator API

2019-02-22 Thread Shuah Khan
Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Video class, two or m

Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-22 Thread Ezequiel Garcia
On Fri, 2019-02-22 at 16:46 +0900, Tomasz Figa wrote: > Hi Maxime, > > On Wed, Feb 20, 2019 at 11:17 PM Maxime Ripard > wrote: > > From: Pawel Osciak > > > > Stateless video codecs will require both the H264 metadata and slices in > > order to be able to decode frames. > > > > This introduces

Re: [PATCH v4 05/12] media: ov5640: Compute the clock rate at runtime

2019-02-22 Thread Maxime Ripard
On Fri, Feb 22, 2019 at 08:54:56AM -0600, Benoit Parrot wrote: > Maxime Ripard wrote on Fri [2019-Feb-22 15:39:59 > +0100]: > > On Thu, Feb 21, 2019 at 10:20:20AM -0600, Benoit Parrot wrote: > > > Hi Maxime, > > > > > > A couple of questions, > > > > > > Maxime Ripard wrote on Thu [2018-Oct-11

Re: [PATCH 1/3] [media] rc/keymaps: add keytable for Pine64 IR Remote Controller

2019-02-22 Thread Jonas Karlman
On 2019-02-20 10:57, Sean Young wrote: > On Mon, Feb 18, 2019 at 09:59:36PM +, Jonas Karlman wrote: >> This RC map is based on remote key schema at [1], the mouse button key >> did not have an obvious target and was mapped to KEY_CONTEXT_MENU. > How about BTN_LEFT ? That should work, I only lo

Re: [PATCH v4 05/12] media: ov5640: Compute the clock rate at runtime

2019-02-22 Thread Benoit Parrot
Maxime Ripard wrote on Fri [2019-Feb-22 15:39:59 +0100]: > On Thu, Feb 21, 2019 at 10:20:20AM -0600, Benoit Parrot wrote: > > Hi Maxime, > > > > A couple of questions, > > > > Maxime Ripard wrote on Thu [2018-Oct-11 > > 04:21:00 -0500]: > > > The clock rate, while hardcoded until now, is actu

[PATCH v2] media: vicodec: avoic clang frame size warning

2019-02-22 Thread Arnd Bergmann
Clang-9 makes some different inlining decisions compared to gcc, which leads to a warning about a possible stack overflow problem when building with CONFIG_KASAN, including when setting asan-stack=0, which avoids most other frame overflow warnings: drivers/media/platform/vicodec/codec-fwht.c:673:1

Re: [PATCH v4 05/12] media: ov5640: Compute the clock rate at runtime

2019-02-22 Thread Maxime Ripard
On Thu, Feb 21, 2019 at 10:20:20AM -0600, Benoit Parrot wrote: > Hi Maxime, > > A couple of questions, > > Maxime Ripard wrote on Thu [2018-Oct-11 04:21:00 > -0500]: > > The clock rate, while hardcoded until now, is actually a function of the > > resolution, framerate and bytes per pixel. Now t

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Geert Uytterhoeven
Hi Sakari, On Fri, Feb 22, 2019 at 12:30 PM Sakari Ailus wrote: > On Fri, Feb 22, 2019 at 12:17:47PM +0100, Jacopo Mondi wrote: > > On Fri, Feb 22, 2019 at 01:04:29PM +0200, Sakari Ailus wrote: > > > You can btw. zero the struct memory by assigning { 0 } to it in > > > declaration. memset() in ge

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Ian Arkver
Hi, On 22/02/2019 11:29, Sakari Ailus wrote: Hi Jacopo, On Fri, Feb 22, 2019 at 12:17:47PM +0100, Jacopo Mondi wrote: Hi Sakari, thanks for your suggestions. On Fri, Feb 22, 2019 at 01:04:29PM +0200, Sakari Ailus wrote: Hi Jacopo, [snip] On the previous example, I thought about GMSL

Re: [PATCH yavta 6/7] Support setting control from values stored in a file

2019-02-22 Thread Sakari Ailus
Hi Laurent, On Fri, Feb 22, 2019 at 01:47:39PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Wed, Feb 20, 2019 at 11:26:52PM +0200, Sakari Ailus wrote: > > On Wed, Feb 20, 2019 at 02:51:22PM +0200, Laurent Pinchart wrote: > > > Signed-off-by: Laurent Pinchart > > > --- > > > yavta.c | 25 +

Re: [RFCv2 PATCH] videodev2.h: introduce VIDIOC_DQ_EXT_EVENT

2019-02-22 Thread Laurent Pinchart
Hello, On Wed, Feb 20, 2019 at 03:34:44PM +0200, Sakari Ailus wrote: > On Tue, Feb 05, 2019 at 02:49:45PM +0100, Hans Verkuil wrote: > > This patch adds an extended version of VIDIOC_DQEVENT that: > > > > 1) is Y2038 safe by using a __u64 for the timestamp > > 2) needs no compat32 conversion code

Re: [PATCH v2 09/30] media: entity: Swap pads if route is checked from source to sink

2019-02-22 Thread Laurent Pinchart
Hi Jacopo, On Mon, Feb 18, 2019 at 10:21:07AM +0100, Jacopo Mondi wrote: > On Tue, Jan 22, 2019 at 05:20:30PM +0200, Laurent Pinchart wrote: > > On Tue, Jan 22, 2019 at 05:15:06PM +0200, Sakari Ailus wrote: > >> On Wed, Jan 16, 2019 at 12:57:43AM +0200, Laurent Pinchart wrote: > > This w

RE: [PATCH v3 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-02-22 Thread Vishal Sagar
Hi Luca, Apologies for the delayed response. > -Original Message- > From: Luca Ceresoli [mailto:l...@lucaceresoli.net] > Sent: Monday, February 11, 2019 8:01 PM > To: Vishal Sagar ; Vishal Sagar ; > Hyun Kwon ; laurent.pinch...@ideasonboard.com; > mche...@kernel.org; robh...@kernel.org;

RE: [v3,2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-02-22 Thread Vishal Sagar
Hi Hyun, Thanks for reviewing. Apologies for the delayed response. > -Original Message- > From: Hyun Kwon [mailto:hyun.k...@xilinx.com] > Sent: Thursday, February 14, 2019 1:16 AM > To: Vishal Sagar > Cc: laurent.pinch...@ideasonboard.com; mche...@kernel.org; > robh...@kernel.org; mark.r

Re: [PATCH yavta 6/7] Support setting control from values stored in a file

2019-02-22 Thread Laurent Pinchart
Hi Sakari, On Wed, Feb 20, 2019 at 11:26:52PM +0200, Sakari Ailus wrote: > On Wed, Feb 20, 2019 at 02:51:22PM +0200, Laurent Pinchart wrote: > > Signed-off-by: Laurent Pinchart > > --- > > yavta.c | 25 + > > 1 file changed, 25 insertions(+) > > > > diff --git a/yavta.c

Re: Never checked NULL pointer in drivers/media/v4l2-core/videobuf-core.c

2019-02-22 Thread Laurent Pinchart
Hi Shaodo, On Thu, Feb 21, 2019 at 05:47:52PM -0700, Shaobo He wrote: > Hello everyone, > > I found that macro `CALLPTR` in drivers/media/v4l2-core/videobuf-core.c can > evaluate to NULL yet all its usages (__videobuf_copy_to_user, > __videobuf_copy_stream) are never NULL checked. I doubt but a

[GIT FIXES FOR v5.1] RC fix

2019-02-22 Thread Sean Young
Hi Mauro, A revert of a commit which caused problems. Thanks Sean The following changes since commit 9fabe1d108ca4755a880de43f751f1c054f8894d: media: ipu3-mmu: fix some kernel-doc macros (2019-02-19 09:00:42 -0500) are available in the Git repository at: git://linuxtv.org/syoung/media_tre

Re: [PATCH 7/7] vimc: free vimc_cap_device when the last user disappears

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:48PM +0100, Hans Verkuil wrote: > Don't free vimc_cap_device immediately, instead do this > in the video_device release function which is called when the > last user closes the video device. Only then is it safe to > free the memory.

[PATCH] Revert "media: rc: some events are dropped by userspace"

2019-02-22 Thread Sean Young
When an rc device is created, we do not know what key codes it will support, since a new keymap might be loaded at some later point. So, we set all keybit in the input device. The uevent for the input device includes all the key codes, of which there are now 768. This overflows the size of the uev

Re: [PATCH 6/7] v4l2-device: v4l2_device_release_subdev_node can't reference sd

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:47PM +0100, Hans Verkuil wrote: > When the v4l-subdev device node is released it calls the > v4l2_device_release_subdev_node() function which sets sd->devnode > to NULL. > > However, the v4l2_subdev struct may already be released ca

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Sakari Ailus
Hi Jacopo, On Fri, Feb 22, 2019 at 12:17:47PM +0100, Jacopo Mondi wrote: > Hi Sakari, > thanks for your suggestions. > > On Fri, Feb 22, 2019 at 01:04:29PM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > [snip] > > > > On the previous example, I thought about GMSL-like devices, that can > > >

Re: [PATCH 5/7] vim2m: replace devm_kzalloc by kzalloc

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:46PM +0100, Hans Verkuil wrote: > It is not possible to use devm_kzalloc since that memory is > freed immediately when the device instance is unbound. > > Various objects like the video device may still be in use > since someone has

Re: [PATCH 4/7] media-entity: set ent_enum->bmap to NULL after freeing it

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:45PM +0100, Hans Verkuil wrote: > Ensure that this pointer is set to NULL after it is freed. > The vimc driver has a static media_entity and after > unbinding and rebinding the vimc device the media code will > try to free this point

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Jacopo Mondi
Hi Sakari, thanks for your suggestions. On Fri, Feb 22, 2019 at 01:04:29PM +0200, Sakari Ailus wrote: > Hi Jacopo, [snip] > > On the previous example, I thought about GMSL-like devices, that can > > output the video streams received from different remotes in a > > separate virtual channel, a

Re: [PATCH 1/7] cec: fill in cec chardev kobject to ease debugging

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:42PM +0100, Hans Verkuil wrote: > The cec chardev kobject has no name, which made it hard to > debug when kobject debugging is turned on. > > Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart > --- > drivers/media/cec/c

Re: [PATCH 3/7] vivid: use vzalloc for dev->bitmap_out

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:44PM +0100, Hans Verkuil wrote: > When vivid is unloaded it used vfree to free dev->bitmap_out, > but it was actually allocated using kmalloc. Use vzalloc > instead, conform what vivid-vid-cap.c does. > > Signed-off-by: Hans Verkuil

Re: [PATCH 2/7] media-devnode: fill in media chardev kobject to ease debugging

2019-02-22 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Thu, Feb 21, 2019 at 03:21:43PM +0100, Hans Verkuil wrote: > The media chardev kobject has no name, which made it hard to > debug when kobject debugging is turned on. > > Signed-off-by: Hans Verkuil Reviewed-by: Laurent Pinchart > --- > drivers/media/med

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Sakari Ailus
Hi Jacopo, On Fri, Feb 22, 2019 at 09:40:19AM +0100, Jacopo Mondi wrote: > Hi Sakari, > > On Fri, Feb 22, 2019 at 12:31:32AM +0200, Sakari Ailus wrote: > > Hi Jacopo, > > > > On Thu, Feb 21, 2019 at 03:39:40PM +0100, Jacopo Mondi wrote: > > > Hi Sakari, > > >one quick question > > > > > > On

[PATCH] media: imx7-media-csi: don't store a floating pointer

2019-02-22 Thread Rui Miguel Silva
if imx7_csi_try_fmt() fails, cc variable won't be initialized and csi->cc[sdformat->pad] would be pointing to a random location. Reported-by: Dan Carpenter Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/imx7-media-csi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

Re: [PATCH yavta 0/3] Fixes for compound control support

2019-02-22 Thread Laurent Pinchart
On Wed, Feb 20, 2019 at 11:34:28PM +0200, Sakari Ailus wrote: > On Wed, Feb 20, 2019 at 05:19:49PM +0200, Laurent Pinchart wrote: > > Hello, > > > > This small series fixes issues in yavta reported during the review of > > the compound control support patches. > > > > Laurent Pinchart (3): > >

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Jacopo Mondi
Hi Sakari, On Fri, Feb 22, 2019 at 01:49:36AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Thu, Feb 21, 2019 at 03:59:20PM +0100, Jacopo Mondi wrote: > > Hi Sakari, Laurent, Niklas, > >(another) quick question, but a different one :) > > > > On Wed, Jan 16, 2019 at 01:51:45AM +0200, Laurent

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-02-22 Thread Jacopo Mondi
Hi Sakari, On Fri, Feb 22, 2019 at 12:31:32AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Thu, Feb 21, 2019 at 03:39:40PM +0100, Jacopo Mondi wrote: > > Hi Sakari, > >one quick question > > > > On Fri, Nov 02, 2018 at 12:31:30AM +0100, Niklas Söderlund wrote: > > > From: Laurent Pinchart >