Re: [PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-12 Thread Alexandre Courbot
On Wed, Feb 13, 2019 at 2:53 PM Alexandre Courbot wrote: > [snip] > +Buffers used as reference frames can be queued back to the ``CAPTURE`` queue > as > +soon as all the frames they are affecting have been queued to the ``OUTPUT`` > +queue. The driver will refrain from using the reference buffer

[PATCH v3] media: docs-rst: Document m2m stateless video decoder interface

2019-02-12 Thread Alexandre Courbot
Documents the protocol that user-space should follow when communicating with stateless video decoders. The stateless video decoding API makes use of the new request and tags APIs. While it has been implemented with the Cedrus driver so far, it should probably still be considered staging for a shor

cron job: media_tree daily build: OK

2019-02-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Feb 13 05:00:13 CET 2019 media-tree git hash:6fd369dd1cb65a032f1ab9227033ecb7b759656d media_build git

Re: [RFC PATCH V0 1/7] [media] dt-bindings: mt8183: Add binding for DIP shared memory

2019-02-12 Thread Tomasz Figa
On Tue, Feb 12, 2019 at 6:37 PM Frederic Chen wrote: > > Dear Laurent and Sakari, > > I appreciate your messages. > > On Sat, 2019-02-09 at 20:17 +0200, Laurent Pinchart wrote: > > On Sat, Feb 09, 2019 at 05:59:07PM +0200, Sakari Ailus wrote: > > > Hi Frederic, > > > > > > Could you cc the devicet

Re: [PATCH v3 0/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Tomasz Figa
On Wed, Feb 13, 2019 at 6:22 AM Ezequiel Garcia wrote: > > Hey Tomasz, > > On Tue, 2019-02-12 at 21:50 +0900, Tomasz Figa wrote: > > Hi Maxime, > > > > On Mon, Feb 11, 2019 at 11:39 PM Maxime Ripard > > wrote: > > > Hi, > > > > > > Here is a new version of the H264 decoding support in the cedrus

Regression in 4.20 - still present in 5.0-rc6

2019-02-12 Thread Mark Zimmerman
Greetings: This is to call your attention to a regression that showed up in kernel 4.20; the behavior is still present in 5.0-rc6. Please look at https://bugzilla.kernel.org/show_bug.cgi?id=202565 for details. Also, the forum post https://bbs.archlinux.org/viewtopic.php?id=244097 has further d

[PATCH v2 4/4] media: platform: sti: fix possible object reference leak

2019-02-12 Thread Wen Yang
The call to of_parse_phandle() returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. The of_find_device_by_node() takes a reference to the underlying device structure, we also should release that reference. Hans Verkuil says: The cec dri

[PATCH v2 3/4] media: s5p-cec: fix possible object reference leak

2019-02-12 Thread Wen Yang
The call to of_parse_phandle() returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. The of_find_device_by_node() takes a reference to the underlying device structure, we also should release that reference. This patch fixes those two issu

[PATCH v2 2/4] media: tegra-cec: fix possible object reference leak

2019-02-12 Thread Wen Yang
The call to of_parse_phandle() returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. The of_find_device_by_node() takes a reference to the underlying device structure, we also should release that reference. Hans Verkuil says: The cec dri

[PATCH v2 1/4] media: platform: meson-ao-cec: fix possible object reference leak

2019-02-12 Thread Wen Yang
The call to of_parse_phandle() returns a node pointer with refcount incremented thus it must be explicitly decremented here after the last usage. The of_find_device_by_node() takes a reference to the underlying device structure, we also should release that reference. Hans Verkuil says: The cec dri

PO20190212

2019-02-12 Thread angelo . demitri
FYI, Please find the Attached and send proforma invoice Thank you <>

Re: [PATCH v3 0/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Ezequiel Garcia
Hey Tomasz, On Tue, 2019-02-12 at 21:50 +0900, Tomasz Figa wrote: > Hi Maxime, > > On Mon, Feb 11, 2019 at 11:39 PM Maxime Ripard > wrote: > > Hi, > > > > Here is a new version of the H264 decoding support in the cedrus > > driver. > > Thanks for working on this. Please see my comments below.

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-12 Thread Ezequiel Garcia
On Tue, 2019-02-12 at 14:05 +0100, Maxime Ripard wrote: > Hi, > > On Mon, Feb 11, 2019 at 04:21:47PM +0100, Hans Verkuil wrote: > > > I think the API should be designed with 4k video in mind. So if some of > > > these constants would be too small when dealing with 4k (even if the > > > current HW

Re: [PATCH v7] media: imx: add mem2mem device

2019-02-12 Thread Tim Harvey
On Thu, Jan 17, 2019 at 7:50 AM Philipp Zabel wrote: > > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The hardware on

Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-12 Thread Steve Longerbeam
On 2/12/19 3:34 AM, Philipp Zabel wrote: Hi Steve, On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote: [...] Should we support YUV BT.601 <-> YUV REC.709 conversions? That would require separate encodings for input and output. How about if we pass the input and output encodings to th

Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Jernej Škrabec
Dne torek, 12. februar 2019 ob 11:43:14 CET je Maxime Ripard napisal(a): > Hi, > > On Mon, Feb 11, 2019 at 08:21:31PM +0100, Jernej Škrabec wrote: > > > + reg = 0; > > > + /* > > > + * FIXME: This bit tells the video engine to use the default > > > + * quantization matrices. This will obviously

Re: [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-12 Thread Steve Longerbeam
On 2/12/19 2:17 AM, Philipp Zabel wrote: Hi Steve, On Mon, 2019-02-11 at 10:24 -0800, Steve Longerbeam wrote: [...] Looking more closely at these coefficients now, I see you are right, they are the BT.601 YUV full-range coefficients (Y range 0 to 1, U and V range -0.5 to 0.5). Well, not even

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Jernej Škrabec
Dne torek, 12. februar 2019 ob 13:47:13 CET je Maxime Ripard napisal(a): > On Mon, Feb 11, 2019 at 04:48:17PM -0300, Ezequiel Garcia wrote: > > On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > > > Introduce some basic H264 decoding support in cedrus. So far, only the > > > baseline profile

Re: [PATCH 4/6] vsp1: fix smatch warning

2019-02-12 Thread Laurent Pinchart
On Tue, Feb 12, 2019 at 01:48:00PM +, Kieran Bingham wrote: > On 07/02/2019 09:13, Hans Verkuil wrote: > > drivers/media/platform/vsp1/vsp1_drm.c: > > drivers/media/platform/vsp1/vsp1_drm.c:336 vsp1_du_pipeline_setup_brx() > > error: we previously assumed 'pipe->brx' could be null (see line 2

Re: [PATCH 0/3] media: add Toshiba TC358746 Bridge support

2019-02-12 Thread Marco Felsch
Hi, gentle ping.. On 19-01-23 13:54, Marco Felsch wrote: > Hi, > > Just a ping. > > The kbuilder reports some warning which I will fix in a v2 but I still > waiting for feedback from you. > > Regards, > Marco > > On 18-12-18 15:12, Marco Felsch wrote: > > Hi, > > > > this patch set adds the

Re: [PATCH v4 0/7] TVP5150 new features

2019-02-12 Thread Marco Felsch
Hi Mauro, gentle ping.. On 19-01-29 17:07, Marco Felsch wrote: > Hi, > > this is the v4 of my TVP5150 series which adds the of_graph support. > Basically this series was just rebased on top of the media-tree/master > as mentioned by Mauro [1]. > > I dropped commit ("media: tvp5150: fix irq_requ

[GIT PULL FOR v5.1] Various fixes/enhancements

2019-02-12 Thread Hans Verkuil (hansverk)
Main addition is adding proper packed 32-bit YUV support. Also fixes a long-standing vsp1 smatch warning and reorganizes the extended control part of the documentation. Regards, Hans The following changes since commit 6fd369dd1cb65a032f1ab9227033ecb7b759656d: media: vimc: fill in bus

Re: [PATCH 4/6] vsp1: fix smatch warning

2019-02-12 Thread Kieran Bingham
Hi Hans, On 07/02/2019 09:13, Hans Verkuil wrote: > drivers/media/platform/vsp1/vsp1_drm.c: > drivers/media/platform/vsp1/vsp1_drm.c:336 vsp1_du_pipeline_setup_brx() > error: we previously assumed 'pipe->brx' could be null (see line 244) > > smatch missed that if pipe->brx was NULL, then later

Re: 答复: [PATCH 1/4] media: cec-notifier: fix possible object reference leak

2019-02-12 Thread Hans Verkuil (hansverk)
Hi Wen, On 2/12/19 2:04 PM, Wen Yang wrote: > Hi Hans, thank you for your comments. > I will use my company's mailbox and submit a v2 patch to fix these problems > tomorrow. I made a bunch of patches fixing this yesterday. It's available here: https://git.linuxtv.org/hverkuil/media_tree.git/log

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-12 Thread Maxime Ripard
Hi, On Mon, Feb 11, 2019 at 04:21:47PM +0100, Hans Verkuil wrote: > > I think the API should be designed with 4k video in mind. So if some of > > these constants would be too small when dealing with 4k (even if the > > current HW doesn't support this yet), then these constants would have to > > be

Re: [PATCH v3 0/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Tomasz Figa
Hi Maxime, On Mon, Feb 11, 2019 at 11:39 PM Maxime Ripard wrote: > > Hi, > > Here is a new version of the H264 decoding support in the cedrus > driver. Thanks for working on this. Please see my comments below. > > As you might already know, the cedrus driver relies on the Request > API, and is

[bug report] [media] dib8000: potential off by one

2019-02-12 Thread Dan Carpenter
Hello Patrick Boettcher, The patch 173a64cb3fcf: "[media] dib8000: enhancement" from Apr 22, 2013, leads to the following static checker warning: drivers/media/dvb-frontends/dib8000.c:2132 dib8000_get_init_prbs() error: buffer overflow 'lut_prbs_2k' 14 <= 14 drivers/media/dvb-fro

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Maxime Ripard
On Mon, Feb 11, 2019 at 04:48:17PM -0300, Ezequiel Garcia wrote: > On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > > Introduce some basic H264 decoding support in cedrus. So far, only the > > baseline profile videos have been tested, and some more advanced features > > used in higher prof

Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-12 Thread Philipp Zabel
Hi Steve, On Mon, 2019-02-11 at 17:20 -0800, Steve Longerbeam wrote: [...] > > Should we support YUV BT.601 <-> YUV REC.709 conversions? That would > > require separate encodings for input and output. > > How about if we pass the input and output encodings to the init ic task > functions, but fo

Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-12 Thread Maxime Ripard
Hi, On Mon, Feb 11, 2019 at 08:21:31PM +0100, Jernej Škrabec wrote: > > + reg = 0; > > + /* > > +* FIXME: This bit tells the video engine to use the default > > +* quantization matrices. This will obviously need to be > > +* changed to support the profiles supporting custom > > +

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-12 Thread Maxime Ripard
On Mon, Feb 11, 2019 at 02:12:25PM -0300, Ezequiel Garcia wrote: > On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > > > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > > index d6eed479c3a6..6fc955926bdb 100644 > > --- a/include/uapi/linux/videodev2.h > > +

Re: [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-12 Thread Philipp Zabel
Hi Steve, On Mon, 2019-02-11 at 10:24 -0800, Steve Longerbeam wrote: [...] > Looking more closely at these coefficients now, I see you are right, > they are the BT.601 YUV full-range coefficients (Y range 0 to 1, U and V > range -0.5 to 0.5). Well, not even that -- the coefficients are not > be

Re: [RFC PATCH V0 3/7] [media] dt-bindings: mt8183: Added DIP-SMEM dt-bindings

2019-02-12 Thread Frederic Chen
Dear Laurent and Sakari, On Sat, 2019-02-09 at 20:20 +0200, Laurent Pinchart wrote: > Hello Frederic, > > On Sat, Feb 09, 2019 at 05:59:35PM +0200, Sakari Ailus wrote: > > Hi Frederic, > > > > Thanks for the patchset. > > > > Could you also cc the devicetree list, please? > > > > On Fri, Feb

Re: [RFC PATCH V0 1/7] [media] dt-bindings: mt8183: Add binding for DIP shared memory

2019-02-12 Thread Frederic Chen
Dear Laurent and Sakari, I appreciate your messages. On Sat, 2019-02-09 at 20:17 +0200, Laurent Pinchart wrote: > On Sat, Feb 09, 2019 at 05:59:07PM +0200, Sakari Ailus wrote: > > Hi Frederic, > > > > Could you cc the devicetree list, please? > > > > On Fri, Feb 01, 2019 at 07:21:25PM +0800, Fr

Re: [PATCH v3] [media] v4l: add I / P frame min max QP definitions

2019-02-12 Thread Fish Lin
Got it, I'll submit another patch after your patch merged. Thanks, Fish Hans Verkuil 於 2019年2月8日 週五 下午5:58寫道: > > On 1/30/19 10:11 AM, Fish Lin wrote: > > Add following V4L2 QP parameters for H.264: > > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MIN_QP > > * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_MAX_QP >