cron job: media_tree daily build: OK

2019-02-11 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Feb 12 05:00:11 CET 2019 media-tree git hash:6fd369dd1cb65a032f1ab9227033ecb7b759656d media_build git

Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-11 Thread Steve Longerbeam
On 2/11/19 2:12 AM, Philipp Zabel wrote: On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: Pass v4l2 encoding enum to the ipu_ic task init functions, and add support for the BT.709 encoding and inverse encoding matrices. Reported-by: Tim Harvey Signed-off-by: Steve Longerbeam ---

Re: [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-11 Thread Steve Longerbeam
On 2/11/19 1:58 AM, Philipp Zabel wrote: On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: The ycbcr2rgb and inverse rgb2ycbcr matrices define the BT.601 encoding coefficients, so rename them to indicate that. And add some comments to make clear these are BT.601 coefficients encoding

Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

2019-02-11 Thread Jason Gunthorpe
On Thu, Feb 07, 2019 at 10:26:52PM +, Jason Gunthorpe wrote: > Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists w/o > backing pages") introduced the sg_page_iter_dma_address() function without > providing a way to use it in the general case. If the sg_dma_len() is not > equ

[PATCH] Add suport for Avermedia TD310

2019-02-11 Thread Jose Alberto Reguero
This patch add support for Avermedia TD310 usb stik. This patch must be aplied after this one: https://patchwork.linuxtv.org/patch/40087/ Signed-off-by: Jose Alberto Reguero diff -upr linux/drivers/media/usb/dvb-usb-v2/af9035.c linux.new/drivers/media/usb/dvb-usb-v2/af9035.c --- linux/drivers/m

[v4l-utils PATCH 3/4] v4l2-ctl: Add functions and variables to support fwht stateless decoder

2019-02-11 Thread Dafna Hirschfeld
Add the variable 'last_fwht_bf_ts' and the array 'fwht_reqs' to allow the fwht stateless decoder to maintain the requests. Signed-off-by: Dafna Hirschfeld --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 103 ++ 1 file changed, 103 insertions(+) diff --git a/utils/v4l2-ctl/v4

[v4l-utils PATCH 4/4] v4l2-ctl: Add implementation for the stateless fwht decoder.

2019-02-11 Thread Dafna Hirschfeld
Add code to support the stateless decoder and the function 'stateless_m2m' that implements it. Signed-off-by: Dafna Hirschfeld --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 224 +- 1 file changed, 221 insertions(+), 3 deletions(-) diff --git a/utils/v4l2-ctl/v4l2-ctl-strea

[v4l-utils PATCH 2/4] (c)v4l-helpers.h: Add support for the request api

2019-02-11 Thread Dafna Hirschfeld
Add an array of request file descriptors to v4l_queue and add methods to allocate and get them. Signed-off-by: Dafna Hirschfeld --- utils/common/cv4l-helpers.h | 5 + utils/common/v4l-helpers.h | 22 ++ 2 files changed, 27 insertions(+) diff --git a/utils/common/cv4l-h

[v4l-utils PATCH 1/4] v4l2-ctl: move stateful m2m decode code to a separate function

2019-02-11 Thread Dafna Hirschfeld
Add the function stateful_m2m that implements the stateful codec api. This is a preparation for having both stateful and stateless implementations Signed-off-by: Dafna Hirschfeld --- utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 95 ++- 1 file changed, 50 insertions(+), 45 dele

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Ezequiel Garcia
On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > From: Pawel Osciak > > Stateless video codecs will require both the H264 metadata and slices in > order to be able to decode frames. > > This introduces the definitions for a new pixel format for H264 slices that > have been parsed, as we

Re: [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Ezequiel Garcia
On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have been tested, and some more advanced features > used in higher profiles are not even implemented. > > Signed-off-by: Maxime Ripard [..]

Re: [PATCH v2 2/2] media: Introduce helpers to fill pixel format structs

2019-02-11 Thread Ezequiel Garcia
Hello André, On Mon, 2019-02-11 at 17:11 -0200, André Almeida wrote: > On 2/6/19 7:29 PM, Ezequiel Garcia wrote: > > Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, > > to be used by drivers to calculate plane sizes and bytes per lines. > > > > Note that driver-specific padding

Fwd: Re: [PATCH v2 2/2] media: Introduce helpers to fill pixel format structs

2019-02-11 Thread André Almeida
On 2/6/19 7:29 PM, Ezequiel Garcia wrote: Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, to be used by drivers to calculate plane sizes and bytes per lines. Note that driver-specific padding and alignment are not taken into account, and must be done by drivers using this API.

Re: [linux-sunxi] [PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Jernej Škrabec
Hi Maxime, I spotted few minor issues, but otherwise it looks very well. I'll do detailed review at a later time. Dne ponedeljek, 11. februar 2019 ob 15:39:03 CET je Maxime Ripard napisal(a): > Introduce some basic H264 decoding support in cedrus. So far, only the > baseline profile videos have

Re: [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-11 Thread Steve Longerbeam
Hi Philipp, On 2/11/19 1:58 AM, Philipp Zabel wrote: On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: The ycbcr2rgb and inverse rgb2ycbcr matrices define the BT.601 encoding coefficients, so rename them to indicate that. And add some comments to make clear these are BT.601 coefficient

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Nicolas Dufresne
Le lundi 11 février 2019 à 16:16 +0100, Hans Verkuil a écrit : > Hi Maxime, > > A quick review below. Note that I am no expert on the codec details, so > I leave that to others. I'm mainly concentrating on the structs, flags, etc. > > On 2/11/19 3:39 PM, Maxime Ripard wrote: > > From: Pawel Oscia

Re: IMX CSI capture issues with tda1997x HDMI receiver

2019-02-11 Thread Tim Harvey
On Fri, Feb 8, 2019 at 3:22 PM Steve Longerbeam wrote: > > > > On 2/8/19 1:23 PM, Tim Harvey wrote: > > On Thu, Feb 7, 2019 at 5:54 PM Steve Longerbeam > > wrote: > >> > > > >>> Ok there is definitely something wrong when using the IC with > >>> UYVY8_1X16 (passthrough) which works with UYVY8_2

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Ezequiel Garcia
On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote: > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index d6eed479c3a6..6fc955926bdb 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -645,6 +645,7 @@ struct v4l2_pix_for

Re: [PATCHv2 1/9] mm: Introduce new vm_insert_range and vm_insert_range_buggy API

2019-02-11 Thread Souptick Joarder
On Fri, Feb 8, 2019 at 10:52 AM Souptick Joarder wrote: > > On Thu, Feb 7, 2019 at 10:17 PM Matthew Wilcox wrote: > > > > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote: > > > Just thought to take opinion for documentation before placing it in v3. > > > Does it looks fine ? > >

Re: [PATCH v3 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-02-11 Thread Luca Ceresoli
Hi, thanks for the quick reply. On 11/02/19 13:43, Vishal Sagar wrote: >>> +static int xcsi2rxss_start_stream(struct xcsi2rxss_state *state) >>> +{ >>> + struct xcsi2rxss_core *core = &state->core; >>> + int ret = 0; >>> + >>> + xcsi2rxss_enable(core); >>> + >>> + ret = xcsi2rxss_

[PATCH v3 0/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Maxime Ripard
Hi, Here is a new version of the H264 decoding support in the cedrus driver. As you might already know, the cedrus driver relies on the Request API, and is a reverse engineered driver for the video decoding engine found on the Allwinner SoCs. This work has been possible thanks to the work done b

[PATCH v3 2/2] media: cedrus: Add H264 decoding support

2019-02-11 Thread Maxime Ripard
Introduce some basic H264 decoding support in cedrus. So far, only the baseline profile videos have been tested, and some more advanced features used in higher profiles are not even implemented. Signed-off-by: Maxime Ripard --- drivers/staging/media/sunxi/cedrus/Makefile | 3 +- drivers/

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Hans Verkuil
On 2/11/19 4:16 PM, Hans Verkuil wrote: > Hi Maxime, > > A quick review below. Note that I am no expert on the codec details, so > I leave that to others. I'm mainly concentrating on the structs, flags, etc. > > On 2/11/19 3:39 PM, Maxime Ripard wrote: >> From: Pawel Osciak >> >> Stateless video

Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Hans Verkuil
Hi Maxime, A quick review below. Note that I am no expert on the codec details, so I leave that to others. I'm mainly concentrating on the structs, flags, etc. On 2/11/19 3:39 PM, Maxime Ripard wrote: > From: Pawel Osciak > > Stateless video codecs will require both the H264 metadata and slices

[PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

2019-02-11 Thread Maxime Ripard
From: Pawel Osciak Stateless video codecs will require both the H264 metadata and slices in order to be able to decode frames. This introduces the definitions for a new pixel format for H264 slices that have been parsed, as well as the structures used to pass the metadata from the userspace to t

Re: [PATCHv2 4/6] videodev2.h: add V4L2_CTRL_FLAG_REQUIRES_REQUESTS

2019-02-11 Thread Hans Verkuil
On 2/11/19 11:13 AM, Hans Verkuil wrote: > Indicate if a control can only be set through a request, as opposed > to being set directly. This is necessary for stateless codecs where > it makes no sense to set the state controls directly. Kwiboo on irc pointed out that this clashes with this line th

RE: [PATCH v3 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-02-11 Thread Vishal Sagar
Hi Luca, Thanks for reviewing this. > -Original Message- > From: Luca Ceresoli [mailto:l...@lucaceresoli.net] > Sent: Monday, February 11, 2019 4:12 PM > To: Vishal Sagar ; Hyun Kwon ; > laurent.pinch...@ideasonboard.com; mche...@kernel.org; > robh...@kernel.org; mark.rutl...@arm.com; Mi

Re: [PATCH 1/4] media: cec-notifier: fix possible object reference leak

2019-02-11 Thread Hans Verkuil (hansverk)
On 11/02/2019 11:38, Hans Verkuil (hansverk) wrote: > On 09/02/2019 03:48, Wen Yang wrote: >> put_device() should be called in cec_notifier_release(), >> since the dev is being passed down to cec_notifier_get_conn(), >> which holds reference. On cec_notifier destruction, it >> should drop the refer

Re: [PATCH 4/4] media: tegra-cec: fix possible object reference leak

2019-02-11 Thread Hans Verkuil (hansverk)
On 09/02/2019 03:55, Wen Yang wrote: > The call to of_parse_phandle() returns a node pointer with refcount > incremented thus it must be explicitly decremented here after the last > usage. > The of_find_device_by_node() takes a reference to the underlying device > structure, we also should release

Re: [PATCH 1/4] media: cec-notifier: fix possible object reference leak

2019-02-11 Thread Hans Verkuil (hansverk)
On 09/02/2019 03:48, Wen Yang wrote: > put_device() should be called in cec_notifier_release(), > since the dev is being passed down to cec_notifier_get_conn(), > which holds reference. On cec_notifier destruction, it > should drop the reference to the device. > > Fixes: 6917a7b77413 ("[media] med

Re: [PATCH v3 2/2] media: v4l: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-02-11 Thread Luca Ceresoli
Hi Vishal, On 01/02/19 13:56, Vishal Sagar wrote: > The Xilinx MIPI CSI-2 Rx Subsystem soft IP is used to capture images > from MIPI CSI-2 camera sensors and output AXI4-Stream video data ready > for image processing. Please refer to PG232 for details. For those unused to Xilinx documentation I'd

Re: [PATCH v3 1/2] media: dt-bindings: media: xilinx: Add Xilinx MIPI CSI-2 Rx Subsystem

2019-02-11 Thread Luca Ceresoli
Hi Vishal, sorry for joining late in reviewing your patches. I have a few small comments. On 01/02/19 13:56, Vishal Sagar wrote: > Add bindings documentation for Xilinx MIPI CSI-2 Rx Subsystem. > > The Xilinx MIPI CSI-2 Rx Subsystem consists of a CSI-2 Rx controller, a > DPHY in Rx mode, an opti

Re: [PATCH v2 4/4] media: imx-pxp: Start using the format VUYA32 instead of YUV32 (v2)

2019-02-11 Thread Philipp Zabel
On Fri, 2019-02-08 at 17:38 -0800, Vivek Kasireddy wrote: > Buffers generated with YUV32 format seems to be incorrect, hence use > VUYA32 instead. > > Changes from v1: > Add both formats VUYA32 and VUYX32 but associate only VUYX32 to the > output queue as the alpha channel of buffers is ignored on

[PATCHv2 4/6] videodev2.h: add V4L2_CTRL_FLAG_REQUIRES_REQUESTS

2019-02-11 Thread Hans Verkuil
Indicate if a control can only be set through a request, as opposed to being set directly. This is necessary for stateless codecs where it makes no sense to set the state controls directly. Signed-off-by: Hans Verkuil --- .../media/uapi/v4l/vidioc-queryctrl.rst | 4 .../media/videode

[PATCHv2 6/6] v4l2-ctrls: mark MPEG2 stateless controls as REQUIRES_REQUESTS

2019-02-11 Thread Hans Verkuil
These stateless codec controls can only be used in combination with a request. So mark them as such. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctr

[PATCHv2 5/6] v4l2-ctrls: check for REQUIRES_REQUESTS flag

2019-02-11 Thread Hans Verkuil
Attempts to get/try/set controls that require requests without actually specifying a request are now rejected. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-co

[PATCHv2 2/6] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-02-11 Thread Hans Verkuil
Add capability to indicate that requests are required instead of merely supported. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4 include/uapi/linux/videodev2.h | 1 + 2 files changed, 5 insertions(+) diff --git a/Documentation/media/u

[PATCHv2 3/6] cedrus: set requires_requests

2019-02-11 Thread Hans Verkuil
The cedrus stateless decoder requires the use of request, so indicate this by setting requires_requests to 1. Signed-off-by: Hans Verkuil --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b

[PATCHv2 0/6] vb2/v4l2-ctrls: check if requests are required

2019-02-11 Thread Hans Verkuil
Currently the vb2 supports_requests bitfield only indicates if the Request API is supported by the vb2_queue. But for stateless codecs the use of the Request API is actually a requirement. So add a requires_requests bitfield and corresponding capability to indicate that userspace has to use reques

[PATCHv2 1/6] vb2: add requires_requests bit for stateless codecs

2019-02-11 Thread Hans Verkuil
Stateless codecs require the use of the Request API as opposed of it being optional. So add a bit to indicate this and let vb2 check for this. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-core.c | 5 - drivers/media/common/videobuf2/videobuf2-v4l2.c | 6 ++ i

Re: [PATCH v4 3/4] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-11 Thread Philipp Zabel
On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: > Pass v4l2 encoding enum to the ipu_ic task init functions, and add > support for the BT.709 encoding and inverse encoding matrices. > > Reported-by: Tim Harvey > Signed-off-by: Steve Longerbeam > --- > Changes in v4: > - fix compile er

Re: [PATCH 7/9] media: vb2: Add func that return buffer by timestamp

2019-02-11 Thread Hans Verkuil
On 2/9/19 2:54 PM, Dafna Hirschfeld wrote: > Add the function 'vb2_find_timestamp_buf' that returns > the vb2 buffer that matches the given timestamp > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/common/videobuf2/videobuf2-v4l2.c | 14 ++ > include/media/videobuf2-v4l2.h

Re: [PATCH 9/9] media: vicodec: Add support for stateless decoder.

2019-02-11 Thread Hans Verkuil
On 2/9/19 2:54 PM, Dafna Hirschfeld wrote: > Implement a stateless decoder for the new node. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/platform/vicodec/vicodec-core.c | 202 -- > 1 file changed, 190 insertions(+), 12 deletions(-) > > diff --git a/drivers/media/pl

Re: [PATCH v4 2/4] gpu: ipu-v3: ipu-ic: Simplify selection of encoding matrix

2019-02-11 Thread Philipp Zabel
On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: > Simplify the selection of the Y'CbCr encoding matrices in init_csc(). > A side-effect of this change is that init_csc() now allows YUV->YUV > using the identity matrix, intead of returning error. > > Signed-off-by: Steve Longerbeam Not

Re: [PATCH v4 1/4] gpu: ipu-v3: ipu-ic: Rename yuv2rgb encoding matrices

2019-02-11 Thread Philipp Zabel
On Fri, 2019-02-08 at 17:47 -0800, Steve Longerbeam wrote: > The ycbcr2rgb and inverse rgb2ycbcr matrices define the BT.601 encoding > coefficients, so rename them to indicate that. And add some comments > to make clear these are BT.601 coefficients encoding between YUV limited > range and RGB full

[PATCH 1/3] vb2: add requires_requests bit for stateless codecs

2019-02-11 Thread Hans Verkuil
Stateless codecs require the use of the Request API as opposed of it being optional. So add a bit to indicate this and let vb2 check for this. Signed-off-by: Hans Verkuil --- drivers/media/common/videobuf2/videobuf2-core.c | 5 - drivers/media/common/videobuf2/videobuf2-v4l2.c | 6 ++ i

[PATCH 3/3] cedrus: set requires_requests

2019-02-11 Thread Hans Verkuil
The cedrus stateless decoder requires the use of request, so indicate this by setting requires_requests to 1. Signed-off-by: Hans Verkuil --- drivers/staging/media/sunxi/cedrus/cedrus_video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b

[PATCH 2/3] videodev2.h: add V4L2_BUF_CAP_REQUIRES_REQUESTS

2019-02-11 Thread Hans Verkuil
Add capability to indicate that requests are required instead of merely supported. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/vidioc-reqbufs.rst | 4 include/uapi/linux/videodev2.h | 1 + 2 files changed, 5 insertions(+) diff --git a/Documentation/media/u

[PATCH 0/3] vb2: add requires_requests bitfield

2019-02-11 Thread Hans Verkuil
Currently the supports_requests bitfield only indicates if the Request API is supported by the vb2_queue. But for stateless codecs the use of the Request API is actually a requirement. So add a requires_requests bitfield and corresponding capability to indicate that userspace has to use requests.

Re: [PATCH 6/9] media: vicodec: Register another node for stateless decoder

2019-02-11 Thread Hans Verkuil
On 2/9/19 2:54 PM, Dafna Hirschfeld wrote: > Add stateless decoder instance field to the dev struct and > register another node for the statelsess decoder. > The stateless API for the node will be implemented in further patches. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/platform/

Re: [PATCH 4/9] media: vicodec: add struct for encoder/decoder instance

2019-02-11 Thread Hans Verkuil
On 2/9/19 2:54 PM, Dafna Hirschfeld wrote: > Add struct 'vicodec_dev_instance' for the fields in vicodec_dev > that have have both decoder and encoder versions. > > Signed-off-by: Dafna Hirschfeld > --- > drivers/media/platform/vicodec/vicodec-core.c | 194 +- > 1 file changed, 9

Re: [PATCH v8 0/5] media/sun6i: Allwinner A64 CSI support

2019-02-11 Thread Jagan Teki
Mauro and Maxime, On Mon, Jan 28, 2019 at 2:29 PM Jagan Teki wrote: > > Add CSI support for Allwinner A64. Here is previous series[1] > > Changes for v8: > - update proper enable and disable sequnce for clk_mod > - fix warning for patch "media: sun6i: Add A64 CSI block support" > - collect Maxime