On Thu, 2019-02-07 at 22:26 +, Jason Gunthorpe wrote:
> Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists
> w/o
> backing pages") introduced the sg_page_iter_dma_address() function
> without
> providing a way to use it in the general case. If the sg_dma_len() is
> not
> equa
On Thu, Feb 7, 2019 at 10:17 PM Matthew Wilcox wrote:
>
> On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote:
> > Just thought to take opinion for documentation before placing it in v3.
> > Does it looks fine ?
> >
> > +/**
> > + * __vm_insert_range - insert range of kernel pages int
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Feb 8 05:00:11 CET 2019
media-tree git hash:6fd369dd1cb65a032f1ab9227033ecb7b759656d
media_build git
On Thu, Feb 7, 2019 at 11:28 PM Jason Gunthorpe wrote:
>
> Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists w/o
> backing pages") introduced the sg_page_iter_dma_address() function without
> providing a way to use it in the general case. If the sg_dma_len() is not
> equal to t
Add support for the following formats to tpg:
V4L2_PIX_FMT_AYUV32
V4L2_PIX_FMT_XYUV32
V4L2_PIX_FMT_VUYA32
V4L2_PIX_FMT_VUYX32
Cc: Hans Verkuil
Signed-off-by: Vivek Kasireddy
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/
The formats added in this patch include:
V4L2_PIX_FMT_AYUV32
V4L2_PIX_FMT_XYUV32
V4L2_PIX_FMT_VUYA32
V4L2_PIX_FMT_VUYX32
These formats enable the trasmission of alpha channel data to other
drivers and userspace applications in addition to YUV data. For
example, buffers generated by drivers in
This patch series adds support for formats that can be used directly
by other drivers such as i915 drm driver. Also, the buffers generated
by vivid in one of these formats using tpg can be used by the Weston
compositor as textures.
Vivek Kasireddy (4):
media: v4l: Add 32-bit packed YUV formats
Enable vivid to make use of the following formats:
V4L2_PIX_FMT_AYUV32
V4L2_PIX_FMT_XYUV32
V4L2_PIX_FMT_VUYA32
V4L2_PIX_FMT_VUYX32
Cc: Hans Verkuil
Signed-off-by: Vivek Kasireddy
---
drivers/media/platform/vivid/vivid-vid-common.c | 30 +
1 file changed, 30 insertion
Buffers generated with YUV32 format seems to be incorrect, hence use
VUYA32 instead.
Cc: Philipp Zabel
Signed-off-by: Vivek Kasireddy
---
drivers/media/platform/imx-pxp.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media
On 2/7/19 5:15 PM, Tim Harvey wrote:
On Wed, Feb 6, 2019 at 8:31 AM Tim Harvey wrote:
On Tue, Feb 5, 2019 at 3:54 PM Steve Longerbeam wrote:
On 2/5/19 11:16 AM, Tim Harvey wrote:
On Sat, Feb 2, 2019 at 11:10 AM Steve Longerbeam wrote:
The *real* way to fix this would be to allow pro
Hi Tim,
On 2/6/19 8:31 AM, Tim Harvey wrote:
On Tue, Feb 5, 2019 at 3:54 PM Steve Longerbeam wrote:
On 2/5/19 11:16 AM, Tim Harvey wrote:
On Sat, Feb 2, 2019 at 11:10 AM Steve Longerbeam wrote:
The *real* way to fix this would be to allow programmable encodings in
ipu-ic.c. But unfortun
On Wed, Feb 6, 2019 at 8:31 AM Tim Harvey wrote:
>
> On Tue, Feb 5, 2019 at 3:54 PM Steve Longerbeam wrote:
> >
> >
> >
> > On 2/5/19 11:16 AM, Tim Harvey wrote:
> > > On Sat, Feb 2, 2019 at 11:10 AM Steve Longerbeam
> > > wrote:
> > >
> > >
> > >> The *real* way to fix this would be to allow
Remove unused but set variables to clean up the code and avoid
warning.
Signed-off-by: Lucas A. M. Magalhães
---
drivers/media/platform/vimc/vimc-sensor.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/platform/vimc/vimc-sensor.c
b/drivers/media/platform/vimc/vimc-senso
From: Steve Longerbeam
The capture compose rectangle was not getting updated when setting
the source subdevice's source pad format. This causes the compose window
to be zero (or not updated) at stream start unless the capture device
format was set explicitly at the capture device node.
Fix by mo
On Fri, Jan 04, 2019 at 10:35:43PM +, Jason Gunthorpe wrote:
> Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists w/o
> backing pages") introduced the sg_page_iter_dma_address() function without
> providing a way to use it in the general case. If the sg_dma_len is not
> equal
Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists w/o
backing pages") introduced the sg_page_iter_dma_address() function without
providing a way to use it in the general case. If the sg_dma_len() is not
equal to the sg length callers cannot safely use the
for_each_sg_page/sg_pag
Hi Lucas,
On 2/7/19 9:48 PM, Lucas A. M. Magalhaes wrote:
> Add a linear pipeline logic for the stream control. It's created by
> walking backwards on the entity graph. When the stream starts it will
> simply loop through the pipeline calling the respective process_frame
> function of each entity.
Hi Hans,
>
> frame_size is set, but not used:
>
> vimc-sensor.c:208:15: warning: variable 'frame_size' set but not used
> [-Wunused-but-set-variable]
>
> Can you make a patch fixing this?
>
> I'm not sure how I missed this sparse warning, weird.
Sorry about that. I will be more careful next time
Add a linear pipeline logic for the stream control. It's created by
walking backwards on the entity graph. When the stream starts it will
simply loop through the pipeline calling the respective process_frame
function of each entity.
Fixes: f2fe89061d797 ("vimc: Virtual Media Controller core, captu
Hi,
On Fri, Feb 01, 2019 at 07:21:31PM +0800, Frederic Chen wrote:
> This patch adds the driver of Digital Image Processing (DIP)
> unit in Mediatek ISP system, providing image format conversion,
> resizing, and rotation features.
>
> The mtk-isp directory will contain drivers for multiple IP
> b
Hi Lucas,
On 1/22/19 2:05 AM, Lucas A. M. Magalhaes wrote:
> Add a linear pipeline logic for the stream control. It's created by
> walking backwards on the entity graph. When the stream starts it will
> simply loop through the pipeline calling the respective process_frame
> function of each entity
It seems that it is possible that dev to be null, as there's
a warning printing:
"Instance released before the end of transaction"
Solves this warning:
drivers/media/platform/vim2m.c: drivers/media/platform/vim2m.c:525
device_work() warn: variable dereferenced before check 'curr_c
On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote:
> Just thought to take opinion for documentation before placing it in v3.
> Does it looks fine ?
>
> +/**
> + * __vm_insert_range - insert range of kernel pages into user vma
> + * @vma: user vma to map to
> + * @pages: pointer to a
On 2/7/19 4:41 PM, Laurent Pinchart wrote:
> Hello,
>
> On Thu, Feb 07, 2019 at 03:57:26PM +0100, Kieran Bingham wrote:
>> On 07/02/2019 10:13, Hans Overkill wrote:
>>> drivers/media/usb/uvc/uvc_video.c: drivers/media/usb/uvc/uvc_video.c:1893
>>> uvc_video_start_transfer() warn: argument 2 to %u
On Thu, Feb 07, 2019 at 09:37:08PM +0530, Souptick Joarder wrote:
> On Thu, Feb 7, 2019 at 9:27 PM Mike Rapoport wrote:
> >
> > Hi Souptick,
> >
> > On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote:
> > > Hi Mike,
> > >
> > > Just thought to take opinion for documentation before pl
On Thu, Feb 7, 2019 at 9:27 PM Mike Rapoport wrote:
>
> Hi Souptick,
>
> On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote:
> > Hi Mike,
> >
> > Just thought to take opinion for documentation before placing it in v3.
> > Does it looks fine ?
>
> Overall looks good to me. Several min
Hi Souptick,
On Thu, Feb 07, 2019 at 09:19:47PM +0530, Souptick Joarder wrote:
> Hi Mike,
>
> Just thought to take opinion for documentation before placing it in v3.
> Does it looks fine ?
Overall looks good to me. Several minor points below.
> +/**
> + * __vm_insert_range - insert range of ke
On 2019-01-28 15:47:37 +0100, Jacopo Mondi wrote:
> Hi Niklas,
>sorry for replying late
>
> On Wed, Jan 16, 2019 at 02:44:25PM +0100, Niklas Söderlund wrote:
> > Hi (again) Jacopo,
> >
> > I found something else in this patch unfortunately :-(
> >
> > On 2019-01-14 15:55:33 +0100, Niklas Söder
Hi Hans,
Thank you for the patch.
On Thu, Feb 07, 2019 at 03:38:02PM +0100, Hans Verkuil wrote:
> drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
> drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
> drivers/staging/media/omap4iss/iss.c:
Hi Hans,
Thank you for the patch.
On Thu, Feb 07, 2019 at 10:13:37AM +0100, Hans Verkuil wrote:
> drivers/media/platform/omap3isp/ispvideo.c:1013:15: warning: unknown
> expression (4 0)
>
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/platform/omap3isp/ispvideo.c | 5 +++--
> 1 file chan
Hi Mike,
On Thu, Jan 31, 2019 at 2:09 PM Mike Rapoport wrote:
>
> On Thu, Jan 31, 2019 at 08:38:12AM +0530, Souptick Joarder wrote:
> > Previouly drivers have their own way of mapping range of
> > kernel pages/memory into user vma and this was done by
> > invoking vm_insert_page() within a loop.
Hello,
On Thu, Feb 07, 2019 at 03:57:26PM +0100, Kieran Bingham wrote:
> On 07/02/2019 10:13, Hans Overkill wrote:
> > drivers/media/usb/uvc/uvc_video.c: drivers/media/usb/uvc/uvc_video.c:1893
> > uvc_video_start_transfer() warn: argument 2 to %u specifier is cast from
> > pointer
> >
> > Signe
Hi Hans,
Sorry about my delay.
On 1/14/19 3:05 PM, Hans Verkuil wrote:
> On 1/14/19 6:04 PM, Helen Koike wrote:
>> Hi Hans,
>>
>> Thanks for the patch.
>>
>> On 1/14/19 12:58 PM, Hans Verkuil wrote:
>>> Add VB2_USERPTR to the vimc capture device.
>>>
>>> Signed-off-by: Hans Verkuil
Acked-by: He
The following changes since commit f0ef022c85a899bcc7a1b3a0955c78a3d7109106:
media: vim2m: allow setting the default transaction time via parameter
(2019-01-31 17:17:08 -0200)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.1m
for you to fetch c
On 1/30/19 11:43 AM, Hans Verkuil wrote:
> It is good practice to fill in bus_info.
>
> Also just use 'platform:vimc' when filling in the bus_info in querycap:
> the bus_info has nothing to do with the video device name.
>
> Signed-off-by: Hans Verkuil
Acked-by: Helen Koike
Thanks
Helen
>
Hi Hans,
On 07/02/2019 10:13, Hans Overkill wrote:
> drivers/media/usb/uvc/uvc_video.c: drivers/media/usb/uvc/uvc_video.c:1893
> uvc_video_start_transfer() warn: argument 2 to %u specifier is cast from
> pointer
>
> Signed-off-by: Hans Verkuil
This look fine to me.
Reviewed-by: Kieran Bingha
On Thu, Feb 07, 2019 at 03:38:02PM +0100, Hans Verkuil wrote:
> drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
> drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
> drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression
drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown expression (4 0)
drivers/staging/media/omap4iss/iss.c:141:15: warning: unknown
Hi Steve,
It turns out that the daily build never compiled the staging media drivers,
which included imx. Now that I enabled it I get these three errors:
drivers/staging/media/imx/imx-media-vdic.c:236 prepare_vdi_in_buffers() error:
uninitialized symbol 'prev_phys'.
drivers/staging/media/imx/imx
On Thu, Feb 07, 2019 at 10:13:37AM +0100, Hans Verkuil wrote:
> drivers/media/platform/omap3isp/ispvideo.c:1013:15: warning: unknown
> expression (4 0)
>
> Signed-off-by: Hans Verkuil
Acked-by: Sakari Ailus
--
Sakari Ailus
sakari.ai...@linux.intel.com
On Thu, Feb 07, 2019 at 10:13:38AM +0100, Hans Verkuil wrote:
> drivers/media/platform/pxa_camera.c:2400 pxa_camera_probe() error: we
> previously assumed 'pcdev->pdata' could be null (see line 2397)
>
> First check if platform data is provided, then check if DT data is provided,
> and if neither
On 2/4/19 4:42 PM, Sakari Ailus wrote:
> Hi folks,
>
> This set removes two additional SoC camera sensor drivers that have
> corresponding V4L2 sub-device drivers.
>
> Sakari Ailus (2):
> soc_camera: Remove the mt9m001 SoC camera sensor driver
> soc_camera: Remove the rj45n1 SoC camera sensor
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in vb2_core_poll() and vb2_poll(). Fix this,
otherwise epoll() would timeout when it shouldn't.
Signed-off-by: Hans Verkuil
Reported-by: Yi Qi
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in media_request_poll(). Fix this, otherwise
epoll() would timeout when it shouldn't.
Signed-off-by: Hans Verkuil
---
drivers/media/media-req
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in videobuf_poll_stream(). Fix this, otherwise
epoll() would timeout when it shouldn't.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-co
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in cec_poll(). Fix this, otherwise epoll()
would timeout when it shouldn't.
Signed-off-by: Hans Verkuil
---
drivers/media/cec/cec-api.c | 2 +
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in v4l2_m2m_poll(). Fix this, otherwise
epoll() would timeout when it shouldn't.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in dvb_demux_poll(), dvb_dvr_poll() and
dvb_ca_en50221_io_poll(). Fix this, otherwise epoll()
can timeout when it shouldn't.
Signed-off-by: Han
From: Hans Verkuil
As was reported by Yi Qingliang
(http://lkml.iu.edu/hypermail/linux/kernel/1812.3/02144.html)
the epoll support in v4l2 is broken.
After researching this some more it turns out that we never
really understood when poll_wait() should be called, and that in
fact it is broken in
From: Hans Verkuil
The v4l2_m2m_poll function didn't check whether q->error
was set for either of the two queues. Add support for this.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l2-mem2mem.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media
From: Hans Verkuil
The epoll function expects that whenever the poll file op is
called, the poll_wait function is also called. That didn't
always happen in v4l2_ctrl_poll(). Fix this, otherwise epoll()
would timeout when it shouldn't.
Signed-off-by: Hans Verkuil
---
drivers/media/v4l2-core/v4l
Hi,
On 14/01/2019 17:36, Ayan Halder wrote:
> On Thu, Jan 10, 2019 at 03:57:09AM +0800, Randy Li wrote:
>> P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits per
>> channel video format.
>>
>> P012 is a planar 4:2:0 YUV 12 bits per channel
>>
>> P016 is a planar 4:2:0 YUV with interleav
The Zotac RC2604323/01G and RC2604329/02BG remotes use the 32-bit
rc6 protocol and toggle bit 15 (0x8000) on repeated button presses,
like MCE remotes.
Add the customer code 0x8034 to the 32-bit rc6 toggle
handling code to get proper scancodes and toggle reports.
Signed-off-by: Matthias Reich
On 2/7/19 10:13 AM, Hans Verkuil wrote:
> drivers/media/platform/omap3isp/ispvideo.c:1013:15: warning: unknown
> expression (4 0)
I should add this text to the commit log:
The combination of the v4l2_subdev_call and media_entity_to_v4l2_subdev macros
became too complex for sparse. So first assig
Hi Kishon,
On Wed, Feb 06, 2019 at 06:00:19PM +0530, Kishon Vijay Abraham I wrote:
> On 06/02/19 5:55 PM, Maxime Ripard wrote:
> > On Wed, Feb 06, 2019 at 05:43:12PM +0530, Kishon Vijay Abraham I wrote:
> >> On 05/02/19 2:16 PM, Daniel Vetter wrote:
> >>> On Mon, Feb 04, 2019 at 03:33:31PM +0530,
On Thu, Feb 07, 2019 at 09:44:46AM +0100, Paul Kocialkowski wrote:
> Hi,
>
> On Mon, 2019-01-21 at 16:45 +0100, Maxime Ripard wrote:
> > The current configuration of the DSI bridge and its associated D-PHY is
> > intertwined. In order to ease the future conversion to the phy framework
> > for the
drivers/media/platform/omap3isp/ispvideo.c:1013:15: warning: unknown expression
(4 0)
Signed-off-by: Hans Verkuil
---
drivers/media/platform/omap3isp/ispvideo.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/omap3isp/ispvideo.c
b/drivers/media/p
drivers/media/usb/uvc/uvc_video.c: drivers/media/usb/uvc/uvc_video.c:1893
uvc_video_start_transfer() warn: argument 2 to %u specifier is cast from pointer
Signed-off-by: Hans Verkuil
---
drivers/media/usb/uvc/uvcvideo.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/d
drivers/media/platform/vsp1/vsp1_drm.c:
drivers/media/platform/vsp1/vsp1_drm.c:336 vsp1_du_pipeline_setup_brx() error:
we previously assumed 'pipe->brx' could be null (see line 244)
smatch missed that if pipe->brx was NULL, then later on it will be
set with a non-NULL value. But it is easier to
drivers/media/platform/vim2m.c: drivers/media/platform/vim2m.c:525
device_work() warn: variable dereferenced before check 'curr_ctx' (see line 523)
Signed-off-by: Hans Verkuil
---
drivers/media/platform/vim2m.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pl
drivers/media/usb/hdpvr/hdpvr-i2c.c: drivers/media/usb/hdpvr/hdpvr-i2c.c:78
hdpvr_i2c_read() warn: 'dev->i2c_buf' 4216624615462223872 can't fit into 127
'*data'
dev->i2c_buf is a char array, so you can just use dev->i2c_buf to get the
start address, no need to do &dev->i2c_buf, even though it is
drivers/media/platform/pxa_camera.c:2400 pxa_camera_probe() error: we
previously assumed 'pcdev->pdata' could be null (see line 2397)
First check if platform data is provided, then check if DT data is provided,
and if neither is provided just return with -ENODEV.
Signed-off-by: Hans Verkuil
---
Various sparse and smatch fixes.
Together with https://patchwork.linuxtv.org/patch/53375/ and
https://patchwork.linuxtv.org/patch/54237/ we have a clean bill
of health. The vsp1 patch supersedes this by now outdated old patch:
https://patchwork.linuxtv.org/patch/49263/
Kieran, Laurent, please rev
I am waiting to hear from you about the message I sent you.
Mr. Joseph
On Thu, Jan 31, 2019 at 10:19 PM Hans Verkuil wrote:
>
> On 1/31/19 1:44 PM, Philipp Zabel wrote:
> > On Thu, 2019-01-31 at 13:30 +0100, Hans Verkuil wrote:
> >> On 1/31/19 11:45 AM, Hans Verkuil wrote:
> >>> On 1/24/19 11:04 AM, Tomasz Figa wrote:
> Due to complexity of the video decoding pr
Hi,
On Mon, 2019-01-21 at 16:45 +0100, Maxime Ripard wrote:
> The current configuration of the DSI bridge and its associated D-PHY is
> intertwined. In order to ease the future conversion to the phy framework
> for the D-PHY part, let's split the configuration in two.
See below about a silly mist
Hi,
On Mon, 2019-01-21 at 16:45 +0100, Maxime Ripard wrote:
> Now that our MIPI D-PHY driver has been converted to the phy framework,
> let's move it into the drivers/phy directory.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Paul Kocialkowski
Cheers,
Paul
> ---
> drivers/gpu/drm/sun4i/K
Hi,
On Wed, 2019-01-09 at 10:33 +0100, Maxime Ripard wrote:
> Now that we have everything in place in the PHY framework to deal in a
> generic way with MIPI D-PHY phys, let's convert our PHY driver and its
> associated DSI driver to that new API.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Pa
Hi,
On Mon, 2019-01-21 at 16:45 +0100, Maxime Ripard wrote:
> Now that we have everything in place in the PHY framework to deal in a
> generic way with MIPI D-PHY phys, let's convert our PHY driver and its
> associated DSI driver to that new API.
>
> Signed-off-by: Maxime Ripard
Reviewed-by: Pa
69 matches
Mail list logo
