Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Koenig, Christian
Am 16.01.19 um 08:09 schrieb Thomas Hellstrom: > On Tue, 2019-01-15 at 21:58 +0100, h...@lst.de wrote: >> On Tue, Jan 15, 2019 at 07:13:11PM +, Koenig, Christian wrote: >>> Thomas is correct that the interface you propose here doesn't work >>> at >>> all for GPUs. >>> >>> The kernel driver is n

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Thomas Hellstrom
On Tue, 2019-01-15 at 21:58 +0100, h...@lst.de wrote: > On Tue, Jan 15, 2019 at 07:13:11PM +, Koenig, Christian wrote: > > Thomas is correct that the interface you propose here doesn't work > > at > > all for GPUs. > > > > The kernel driver is not informed of flush/sync, but rather just > > s

Re: [PATCH] media: Documentation: staging/ipu3-imgu: Miscellaneous improvements

2019-01-15 Thread Tomasz Figa
Hi Laurent, On Thu, Jan 10, 2019 at 9:09 PM Laurent Pinchart wrote: > > Implement miscellaneous changes that have been proposed in review > comments but not captured, rephrase and clarify parts of the > documentation, and mark shell code blocks appropriately. > > Major changes are still required,

[PATCH zbar 1/1] v4l2: add fallback for systems without V4L2_CTRL_WHICH_CUR_VAL

2019-01-15 Thread james . hilliard1
From: James Hilliard Some older systems don't seem to have V4L2_CTRL_WHICH_CUR_VAL so add a fallback. Signed-off-by: James Hilliard --- zbar/video/v4l2.c | 8 1 file changed, 8 insertions(+) diff --git a/zbar/video/v4l2.c b/zbar/video/v4l2.c index 0147cb1..b883ecc 100644 --- a/zbar/v

cron job: media_tree daily build: OK

2019-01-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Jan 16 05:00:13 CET 2019 media-tree git hash:1e0d0a5fd38192f23304ea2fc2b531fea7c74247 media_build git

Re: [PATCH 2/2] media: ipu3-imgu: Remove dead code for NULL check

2019-01-15 Thread Tomasz Figa
On Wed, Jan 16, 2019 at 1:38 AM Laurent Pinchart wrote: > > Hi Tomasz, > > On Tuesday, 15 January 2019 07:38:01 EET Tomasz Figa wrote: > > On Tue, Jan 15, 2019 at 12:38 PM Yong Zhi wrote: > > > Since ipu3_css_buf_dequeue() never returns NULL, remove the > > > dead code to fix static checker warni

Re: [PATCH v8 11/11] media: imx.rst: Update doc to reflect fixes to interlaced capture

2019-01-15 Thread Steve Longerbeam
On 1/15/19 3:54 PM, Steve Longerbeam wrote: media-ctl -V "'ipu1_csi0':0 [fmt:AYUV32/720x480]" This is the reason. The adv7180 is only allowing to configure alternate field mode, and thus it reports the field height on the mbus, not the full frame height. Imx deals with alternate field

Re: [PATCH v8 11/11] media: imx.rst: Update doc to reflect fixes to interlaced capture

2019-01-15 Thread Steve Longerbeam
Hi Tim, On 1/15/19 1:58 PM, Tim Harvey wrote: On Wed, Jan 9, 2019 at 10:30 AM Steve Longerbeam wrote: Also add an example pipeline for unconverted capture with interweave on SabreAuto. Cleanup some language in various places in the process. Signed-off-by: Steve Longerbeam Reviewed-by: Phili

Re: [PATCH v2 17/30] v4l: subdev: compat: Implement handling for VIDIOC_SUBDEV_[GS]_ROUTING

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:31AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Implement compat IOCTL handling for VIDIOC_SUBDEV_G_ROUTING and > VIDIOC_SUBDEV_S_ROUTING IOCTLs. Let's instead design the ioctl in a way that doesn't require compat h

Re: [PATCH v2 16/30] v4l: subdev: Add [GS]_ROUTING subdev ioctls and operations

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:30AM +0100, Niklas Söderlund wrote: > From: Laurent Pinchart > > Signed-off-by: Laurent Pinchart > Signed-off-by: Michal Simek > > - Add sink and source streams for multiplexed links > - Copy the argument back in case of an er

Re: [PATCH v2 15/30] media: entity: Look for indirect routes

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:29AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Two pads are considered having an active route for the purpose of > has_route() if an indirect active route can be found between the two pads. > An simple example of th

Re: [PATCH v2 14/30] media: entity: Add debug information in graph walk route check

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:28AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Signed-off-by: Sakari Ailus > Reviewed-by: Niklas Söderlund > --- > drivers/media/media-entity.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers

Re: [PATCH v2 13/30] media: entity: Add only connected pads to the pipeline

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:27AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > A single entity may contain multiple pipelines. Only add pads that were > connected to the pad through which the entity was reached to the pipeline. > > Signed-off-by:

Re: [PATCH v2 03/30] media: entity: Walk the graph based on pads

2019-01-15 Thread Laurent Pinchart
Hi Sakari, On Wed, Jan 16, 2019 at 12:34:07AM +0200, Sakari Ailus wrote: > On Wed, Jan 16, 2019 at 12:21:36AM +0200, Laurent Pinchart wrote: > > On Fri, Nov 02, 2018 at 12:31:17AM +0100, Niklas Söderlund wrote: > >> From: Sakari Ailus > >> > >> Instead of iterating over graph entities during the

Re: [PATCH v2 12/30] media: entity: Add an iterator helper for connected pads

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:26AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Add a helper macro for iterating over pads that are connected through > enabled routes. This can be used to find all the connected pads within an > entity, for instance

Re: [PATCH v2 11/30] media: entity: Skip link validation for pads to which there is no route to

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:25AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Links are validated along the pipeline which is about to start streaming. > Not all the pads in entities that are traversed along that pipeline are > part of the pipeli

Re: [PATCH v2 09/30] media: entity: Swap pads if route is checked from source to sink

2019-01-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:23AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > This way the pads are always passed to the has_route() op sink pad first. > Makes sense. Is there anything in the API that mandates one pad to be a sink and the other

Re: [PATCH v2 06/30] media: entity: Use pad as the starting point for a pipeline

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:20AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > The pipeline will be moved from the entity to the pads; reflect this in > the media pipeline function API. Will be moved, or has been moved ? > Signed-off-by: Sakari

Re: [PATCH v2 05/30] media: entity: Move the pipeline from entity to pads

2019-01-15 Thread Sakari Ailus
On Wed, Jan 16, 2019 at 12:38:42AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thanks you for the patch. > > On Fri, Nov 02, 2018 at 12:31:19AM +0100, Niklas Söderlund wrote: > > From: Sakari Ailus > > > > This moves the pipe and stream_count fields from struct media_entity to > > struct me

Re: [PATCH v2 05/30] media: entity: Move the pipeline from entity to pads

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thanks you for the patch. On Fri, Nov 02, 2018 at 12:31:19AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > This moves the pipe and stream_count fields from struct media_entity to > struct media_pad. Effectively streams become pad-specific rather than > being stream specific

Re: [PATCH v2 04/30] v4l: mc: Start walk from a specific pad in use count calculation

2019-01-15 Thread Sakari Ailus
On Wed, Jan 16, 2019 at 12:24:32AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Fri, Nov 02, 2018 at 12:31:18AM +0100, Niklas Söderlund wrote: > > From: Sakari Ailus > > > > With the addition of the recent has_route() media entity op, the pads of a > > media e

Re: [PATCH v2 04/30] v4l: mc: Start walk from a specific pad in use count calculation

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:18AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > With the addition of the recent has_route() media entity op, the pads of a > media entity are no longer all interconnected. This has to be taken into > account in power

Re: [PATCH v2 03/30] media: entity: Walk the graph based on pads

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:17AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Instead of iterating over graph entities during the walk, iterate the pads > through which the entity was first reached. This is required in order to > make the entity

Re: [PATCH v2 02/30] media: entity: Use pads instead of entities in the media graph walk stack

2019-01-15 Thread Sakari Ailus
Hi Laurent, On Wed, Jan 16, 2019 at 12:03:13AM +0200, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Fri, Nov 02, 2018 at 12:31:16AM +0100, Niklas Söderlund wrote: > > From: Sakari Ailus > > > > Change the media graph walk stack structure to use media pads instead of

Re: [PATCH v2 02/30] media: entity: Use pads instead of entities in the media graph walk stack

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Another small comment. On Fri, Nov 02, 2018 at 12:31:16AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Change the media graph walk stack structure to use media pads instead of > using media entities. In addition to the entity, the pad contains the > information which pad i

Re: [PATCH v2 02/30] media: entity: Use pads instead of entities in the media graph walk stack

2019-01-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:16AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > Change the media graph walk stack structure to use media pads instead of > using media entities. In addition to the entity, the pad contains the > information which pad

Re: [PATCH v8 11/11] media: imx.rst: Update doc to reflect fixes to interlaced capture

2019-01-15 Thread Tim Harvey
On Wed, Jan 9, 2019 at 10:30 AM Steve Longerbeam wrote: > > Also add an example pipeline for unconverted capture with interweave > on SabreAuto. > > Cleanup some language in various places in the process. > > Signed-off-by: Steve Longerbeam > Reviewed-by: Philipp Zabel > --- > Changes since v4:

Re: [PATCH v2 01/30] media: entity: Use pad as a starting point for graph walk

2019-01-15 Thread Laurent Pinchart
Hello Niklas, Thank you for the patch. On Fri, Nov 02, 2018 at 12:31:15AM +0100, Niklas Söderlund wrote: > From: Sakari Ailus > > With the upcoming use of the recently added has_route() media entity op, all > the pads in an entity will no longer be considered interconnected. This has > an effec

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Jason Gunthorpe
On Tue, Jan 15, 2019 at 02:17:26PM +, Thomas Hellstrom wrote: > Hi, Christoph, > > On Mon, 2019-01-14 at 10:48 +0100, Christoph Hellwig wrote: > > On Thu, Jan 10, 2019 at 04:42:18PM -0700, Jason Gunthorpe wrote: > > > > Changes since the RFC: > > > > - Rework vmwgfx too [CH] > > > > - Use a di

Re: [PATCH v2 02/13] media: i2c: mt9m001: dt: add binding for mt9m001

2019-01-15 Thread Rob Herring
On Tue, 8 Jan 2019 23:51:39 +0900, Akinobu Mita wrote: > Add device tree binding documentation for the MT9M001 CMOS image sensor. > > Cc: Rob Herring > Cc: Guennadi Liakhovetski > Cc: Sakari Ailus > Cc: Mauro Carvalho Chehab > Signed-off-by: Akinobu Mita > --- > * v2 > - Update binding doc s

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread h...@lst.de
On Tue, Jan 15, 2019 at 07:13:11PM +, Koenig, Christian wrote: > Thomas is correct that the interface you propose here doesn't work at > all for GPUs. > > The kernel driver is not informed of flush/sync, but rather just setups > coherent mappings between system memory and devices. > > In ot

[PATCH] media: s5k4ecgx: delete a bogus error message

2019-01-15 Thread Dan Carpenter
This function prints an error message on success. I don't have the hardware, I just noticed this while reading the code. Fixes: 8b99312b7214 ("[media] Add v4l2 subdev driver for S5K4ECGX sensor") Signed-off-by: Dan Carpenter --- drivers/media/i2c/s5k4ecgx.c | 2 -- 1 file changed, 2 deletions(-

[PATCH] media: imx: capture: Allow event subscribe/unsubscribe

2019-01-15 Thread Steve Longerbeam
Implement the vidioc_(un)subscribe_event operations. Imx will allow subscribing to the imx-specific frame interval error events, events from subdevices (V4L2_EVENT_SOURCE_CHANGE), and control events. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-capture.c | 18 +

[PATCH v2] media: imx: queue subdev events to reachable video devices

2019-01-15 Thread Steve Longerbeam
In order to receive events generated by subdevices on the video capture nodes, those events need to be forwarded to the subdevice's list of reachable video capture devices. Note this will queue the event to a video device even if there is no actual _enabled_ media path from the sub-device to the v

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Koenig, Christian
Am 15.01.19 um 19:31 schrieb h...@lst.de: > On Tue, Jan 15, 2019 at 06:03:39PM +, Thomas Hellstrom wrote: >> In the graphics case, it's probably because it doesn't fit the graphics >> use-cases: >> >> 1) Memory typically needs to be mappable by another device. (the "dma- >> buf" interface) > An

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread h...@lst.de
On Tue, Jan 15, 2019 at 06:03:39PM +, Thomas Hellstrom wrote: > In the graphics case, it's probably because it doesn't fit the graphics > use-cases: > > 1) Memory typically needs to be mappable by another device. (the "dma- > buf" interface) And there is nothing preventing dma-buf sharing of

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Thomas Hellstrom
On Tue, 2019-01-15 at 16:20 +0100, h...@lst.de wrote: > On Tue, Jan 15, 2019 at 03:24:55PM +0100, Christian König wrote: > > Yeah, indeed. Bounce buffers are an absolute no-go for GPUs. > > > > If the DMA API finds that a piece of memory is not directly > > accessible by > > the GPU we need to re

Re: [PATCH 02/13] si2157: Check error status bit on cmd execute

2019-01-15 Thread Brad Love
Hi Antti, On 09/01/2019 12.01, Antti Palosaari wrote: > On 12/29/18 7:51 PM, Brad Love wrote: >> Check error status bit on command execute, if error bit is >> set return -EAGAIN. Ignore -EAGAIN in probe during device check. >> >> Signed-off-by: Brad Love >> --- >>   drivers/media/tuners/si2157.c

Re: [PATCH 1/4] si2157: add detection of si2177 tuner

2019-01-15 Thread Mauro Carvalho Chehab
Em Tue, 15 Jan 2019 10:32:01 -0600 Brad Love escreveu: > Hi Antti, > > > On 09/01/2019 11.36, Antti Palosaari wrote: > > On 12/20/18 11:57 PM, Brad Love wrote: > >> Works in ATSC and QAM as is, DVB is completely untested. > >> > >> Firmware required. > >> > >> Signed-off-by: Brad Love > >> -

Want editing?

2019-01-15 Thread Nancy
Want editing your photos? We can help. No matter you need photos background cutting out , or adding clipping path, or even retouching. We are the right studio that who can help you for your photo editing with the quality you need. Let me know if interested. Thanks, Nancy

Re: [PATCH] media: imx-csi: Input connections to CSI should be optional

2019-01-15 Thread Tim Harvey
On Wed, Jan 9, 2019 at 10:34 AM Steve Longerbeam wrote: > > Some imx platforms do not have fwnode connections to all CSI input > ports, and should not be treated as an error. This includes the > imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. > Return -ENOTCONN in imx_csi_par

Re: [PATCH v2] media: vimc: Add vimc-streamer for stream control

2019-01-15 Thread Helen Koike
Hi Lucas, Thank you for this patch, please see my comments below. On 1/14/19 10:19 PM, Lucas A. M. Magalhaes wrote: > Add a linear pipeline logic for the stream control. It's created by > walking backwards on the entity graph. When the stream starts it will > simply loop through the pipeline call

Re: [PATCH 2/2] media: ipu3-imgu: Remove dead code for NULL check

2019-01-15 Thread Laurent Pinchart
Hi Tomasz, On Tuesday, 15 January 2019 07:38:01 EET Tomasz Figa wrote: > On Tue, Jan 15, 2019 at 12:38 PM Yong Zhi wrote: > > Since ipu3_css_buf_dequeue() never returns NULL, remove the > > dead code to fix static checker warning: > > > > drivers/staging/media/ipu3/ipu3.c:493 imgu_isr_threaded()

Want help?

2019-01-15 Thread Nancy
Want editing your photos? We can help. No matter you need photos background cutting out , or adding clipping path, or even retouching. We are the right studio that who can help you for your photo editing with the quality you need. Let me know if interested. Thanks, Nancy

Re: [PATCH 1/4] si2157: add detection of si2177 tuner

2019-01-15 Thread Brad Love
Hi Antti, On 09/01/2019 11.36, Antti Palosaari wrote: > On 12/20/18 11:57 PM, Brad Love wrote: >> Works in ATSC and QAM as is, DVB is completely untested. >> >> Firmware required. >> >> Signed-off-by: Brad Love >> --- >>   drivers/media/tuners/si2157.c  | 6 ++ >>   drivers/media/tuners/s

Re: [PATCH 3/4] media: vicodec: add support for CROP and COMPOSE selection

2019-01-15 Thread kbuild test robot
Hi Dafna, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v5.0-rc2 next-20190115] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Help you to edit the photos

2019-01-15 Thread Nancy
Want editing your photos? We can help. No matter you need photos background cutting out , or adding clipping path, or even retouching. We are the right studio that who can help you for your photo editing with the quality you need. Let me know if interested. Thanks, Nancy

RE: [PATCH 2/2] media: ipu3-imgu: Remove dead code for NULL check

2019-01-15 Thread Zhi, Yong
Hi, Tomasz, > -Original Message- > From: Tomasz Figa [mailto:tf...@chromium.org] > Sent: Monday, January 14, 2019 11:38 PM > To: Zhi, Yong > Cc: Linux Media Mailing List ; Sakari Ailus > ; Mani, Rajmohan > ; Qiu, Tian Shu ; > Laurent Pinchart ; Hans Verkuil > ; Mauro Carvalho Chehab ; > C

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread h...@lst.de
On Tue, Jan 15, 2019 at 03:24:55PM +0100, Christian König wrote: > Yeah, indeed. Bounce buffers are an absolute no-go for GPUs. > > If the DMA API finds that a piece of memory is not directly accessible by > the GPU we need to return an error and not try to use bounce buffers behind > the surface

Re: [Xen-devel][PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Oleksandr Andrushchenko
On 1/15/19 4:44 PM, Hans Verkuil wrote: > Hi Oleksandr, Hello, Hans! > Just two remaining comments: > > On 1/15/19 10:38 AM, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko >> >> This is the ABI for the two halves of a para-virtualized >> camera driver which extends Xen's reach mul

Re: [Xen-devel][PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Hans Verkuil
Hi Oleksandr, Just two remaining comments: On 1/15/19 10:38 AM, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > This is the ABI for the two halves of a para-virtualized > camera driver which extends Xen's reach multimedia capabilities even > farther enabling it for video conf

[GIT PULL FOR v5.1] Two fixes

2019-01-15 Thread Hans Verkuil
The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247: media: s5p-mfc: fix incorrect bus assignment in virtual child device (2019-01-07 14:39:36 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.1e for you to fetch cha

Re: [GIT PULL FOR v5.1] add buf_out_validate callback to vb2 + two fixes

2019-01-15 Thread Hans Verkuil
On 1/11/19 2:32 PM, Hans Verkuil wrote: > The first three patches add the buf_out_validate callback to vb2 so video > output devices can validate the v4l2_buffer struct (specifically, validating > the field). > > This fixes a v4l2-compliance failure. > > The last two patches fix a vim2m bug and f

[PATCH v2] media: i2c: adv748x: Remove PAGE_WAIT

2019-01-15 Thread Kieran Bingham
The ADV748X_PAGE_WAIT is a fake page to insert arbitrary delays in the register tables. Its only usage was removed, so we can remove the handling and simplify the code. Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund Signed-off-by: Kieran Bingham --- v2: - Use for loop with regs

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Christian König
Am 15.01.19 um 15:17 schrieb Thomas Hellstrom: Hi, Christoph, On Mon, 2019-01-14 at 10:48 +0100, Christoph Hellwig wrote: On Thu, Jan 10, 2019 at 04:42:18PM -0700, Jason Gunthorpe wrote: Changes since the RFC: - Rework vmwgfx too [CH] - Use a distinct type for the DMA page iterator [CH] - Do n

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

2019-01-15 Thread Thomas Hellstrom
Hi, Christoph, On Mon, 2019-01-14 at 10:48 +0100, Christoph Hellwig wrote: > On Thu, Jan 10, 2019 at 04:42:18PM -0700, Jason Gunthorpe wrote: > > > Changes since the RFC: > > > - Rework vmwgfx too [CH] > > > - Use a distinct type for the DMA page iterator [CH] > > > - Do not have a #ifdef [CH] > >

[PATCH v3 3/3] media: mt9m111: set initial frame size other than 0x0

2019-01-15 Thread Akinobu Mita
This driver sets initial frame width and height to 0x0, which is invalid. So set it to selection rectangle bounds instead. This is detected by v4l2-compliance detected. Cc: Enrico Scholz Cc: Michael Grzeschik Cc: Marco Felsch Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu

[PATCH v3 2/3] media: mt9m111: set all mbus format field when G_FMT and S_FMT ioctls

2019-01-15 Thread Akinobu Mita
This driver doesn't set all members of mbus format field when the VIDIOC_SUBDEV_{S,G}_FMT ioctls are called. This is detected by v4l2-compliance. Cc: Enrico Scholz Cc: Michael Grzeschik Cc: Marco Felsch Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * No changes

[PATCH v3 0/3] media: bugfixes for mt9m111 driver

2019-01-15 Thread Akinobu Mita
This patch series contains four bugfixes for mt9m111 driver. * v3 - Set initial try format with default configuration instead of current one. * v2 - Drop patch 1/4 in v1 ("fix setting pixclk polarit") since it was wrong. - Use format->pad for the argument of v4l2_subdev_get_try_format(). Akino

[PATCH v3 1/3] media: mt9m111: make VIDIOC_SUBDEV_G_FMT ioctl work with V4L2_SUBDEV_FORMAT_TRY

2019-01-15 Thread Akinobu Mita
The VIDIOC_SUBDEV_G_FMT ioctl for this driver doesn't recognize V4L2_SUBDEV_FORMAT_TRY and always works as if V4L2_SUBDEV_FORMAT_ACTIVE is specified. Cc: Enrico Scholz Cc: Michael Grzeschik Cc: Marco Felsch Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * v3 - Set

Re: [PATCH 4/4] media: vicodec: Add support for dynamic resolution change

2019-01-15 Thread Hans Verkuil
Hi Dafna, This patch is quite large and complex, which makes it hard to review. I think it can easily be split into three patches: one that adds the pixfmt_family code, one that refactors job_ready by introducing get_next_header(), and finally the remainder. This will make the patches much easie

Re: i.MX6 RAW8 format

2019-01-15 Thread Jean-Michel Hautbois
Hi Steve ! Thanks for answering ! Le mar. 15 janv. 2019 à 01:54, Steve Longerbeam a écrit : > > Hi JM, > > On 1/14/19 1:52 AM, Jean-Michel Hautbois wrote: > > Hi, > > > > I am currently using an upstream kernel on a i.MX6 Quad board, and I > > have a strange issue. > > The device I am using is a

Re: [PATCH v5 1/1] media: rc: rcmm decoder

2019-01-15 Thread Patrick Lerda
Hi Sean,     I have a new release adding all the features, but not really tested. I will update the mailing list soon. Finding some time is not so easy. Best Regards, Patrick Lerda. Sean Young wrote: Hi Patrick, On Sat, Dec 08, 2018 at 02:18:05AM +0100, Patrick Lerda wrote: media: add sup

Re: [PATCH v4 0/5] ov7670 fixes

2019-01-15 Thread Sakari Ailus
On Tue, Jan 15, 2019 at 12:12:56PM +0100, Lubomir Rintel wrote: > On Tue, 2019-01-15 at 12:40 +0200, Sakari Ailus wrote: > > On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote: > > > Hi, > > > > > > here are the ov7670 patches originally from the "media: make Marvell > > > camera > >

Re: [PATCH v4 0/5] ov7670 fixes

2019-01-15 Thread Lubomir Rintel
On Tue, 2019-01-15 at 12:40 +0200, Sakari Ailus wrote: > On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote: > > Hi, > > > > here are the ov7670 patches originally from the "media: make Marvell camera > > work on DT-based OLPC XO-1.75" updated to apply cleanly on top of > > master as

Re: [PATCH v4 0/5] ov7670 fixes

2019-01-15 Thread Sakari Ailus
On Tue, Jan 15, 2019 at 09:54:43AM +0100, Lubomir Rintel wrote: > Hi, > > here are the ov7670 patches originally from the "media: make Marvell camera > work on DT-based OLPC XO-1.75" updated to apply cleanly on top of > master as requested. > > I've also added "ov7670: Remove useless use of a re

Re: [PATCH RFC 2/4] media: v4l2-mem2mem: Add an optional job_done operation

2019-01-15 Thread Ezequiel Garcia
On Mon, 2019-01-14 at 14:38 +0100, Paul Kocialkowski wrote: > Introduce a new optional job_done operation, which allows calling back > to the driver when a job is done. Since the job might be completed > from interrupt context where some operations are not available, having > a callback from non-at

[Xen-devel][PATCH v4 0/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Hello! At the moment Xen [1] already supports some virtual multimedia features [2] such as virtual display, sound. It supports keyboards, pointers and multi-touch devices all allowing Xen to be used in automotive appliances, In-Vehicle Infotainment (IVI) systems and

[Xen-devel][PATCH v4 1/1] cameraif: add ABI for para-virtual camera

2019-01-15 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach multimedia capabilities even farther enabling it for video conferencing, In-Vehicle Infotainment, high definition maps etc. The initial goal is to support most needed fu

[PATCH] media: ov8856: Modify ov8856 register reading function to be simplified

2019-01-15 Thread Ben Kao
We use put_unaligned_be16() to be simplified for setting register address in ov8856_read_reg() and use sizeof() to be better suited for bytes copying. Signed-off-by: Ben Kao --- drivers/media/i2c/ov8856.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2

[PATCH 4/4] media: vicodec: Add support for dynamic resolution change

2019-01-15 Thread Dafna Hirschfeld
The decoder gets the resolution information from the headers of the compressed frames and starts a 'Dynamic Resolution Change' according to the decoder spec Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.h | 5 + .../media/platform/vicodec/codec-v4l2-fwht.c |

[PATCH 2/4] media: vicodec: Add num_planes field to v4l2_fwht_pixfmt_info

2019-01-15 Thread Dafna Hirschfeld
Add the field 'num_planes' to 'v4l2_fwht_pixfmt_info' struct. Signed-off-by: Dafna Hirschfeld --- .../media/platform/vicodec/codec-v4l2-fwht.c | 48 +-- .../media/platform/vicodec/codec-v4l2-fwht.h | 1 + drivers/media/platform/vicodec/vicodec-core.c | 2 +- 3 files changed,

[PATCH 3/4] media: vicodec: add support for CROP and COMPOSE selection

2019-01-15 Thread Dafna Hirschfeld
Add support for the selection api for the crop and compose targets. The driver rounds up the coded width and height such that all planes dimensions are multiple of 8. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.c | 80 +++-- drivers/media/platform/vicodec/cod

[PATCH 1/4] media: vicodec: bugfix - replace '=' with '|='

2019-01-15 Thread Dafna Hirschfeld
In the fwht_encode_frame, 'encoding = encode_plane' should be replaced with 'encoding |= encode_plane' so existing flags won't be overwrriten. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/codec-fwht.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 2/6] media: ov7740: get rid of extra ifdefs

2019-01-15 Thread Sakari Ailus
On Wed, Nov 28, 2018 at 06:19:14PM +0100, Lubomir Rintel wrote: > Stubbed v4l2_subdev_get_try_format() will return a correct error when > configured without CONFIG_VIDEO_V4L2_SUBDEV_API. > > Signed-off-by: Lubomir Rintel I'm marking these as rejected for now; let's see if we'll get rid of the sa

Re: [PATCH v4 5/5] media: ov7670: split register setting from set_framerate() logic

2019-01-15 Thread Sakari Ailus
On Tue, Jan 15, 2019 at 09:54:48AM +0100, Lubomir Rintel wrote: > This will allow us to restore the last set frame rate after the device > returns from a power off. > > Signed-off-by: Lubomir Rintel Thanks! I've applied them, and hopefully all is well now. > --- > drivers/media/i2c/ov7670.c |

[PATCH v4 1/5] ov7670: Remove useless use of a ret variable

2019-01-15 Thread Lubomir Rintel
From: Sakari Ailus Instead of assigning the return value to ret and then checking and returning it, just return the value to the caller directly. The success value is always 0. Signed-off-by: Sakari Ailus Acked-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 6 +- 1 file changed, 1 i

[PATCH v4 4/5] media: ov7670: split register setting from set_fmt() logic

2019-01-15 Thread Lubomir Rintel
This will allow us to restore the last set format after the device returns from a power off. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 80 ++ 1 file changed, 46 insertions(+), 34 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/driv

[PATCH v4 2/5] media: ov7670: hook s_power onto v4l2 core

2019-01-15 Thread Lubomir Rintel
The commit 71862f63f351 ("media: ov7670: Add the ov7670_s_power function") added a power control routing. However, it was not good enough to use as a s_power() callback: it merely flipped on the power GPIOs without restoring the register settings. Fix this now and register an actual power callback

[PATCH v4 0/5] ov7670 fixes

2019-01-15 Thread Lubomir Rintel
Hi, here are the ov7670 patches originally from the "media: make Marvell camera work on DT-based OLPC XO-1.75" updated to apply cleanly on top of master as requested. I've also added "ov7670: Remove useless use of a ret variable" with my Ack slapped on it. Lubo

[PATCH v4 5/5] media: ov7670: split register setting from set_framerate() logic

2019-01-15 Thread Lubomir Rintel
This will allow us to restore the last set frame rate after the device returns from a power off. Signed-off-by: Lubomir Rintel --- drivers/media/i2c/ov7670.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/medi

[PATCH v4 3/5] media: ov7670: control clock along with power

2019-01-15 Thread Lubomir Rintel
This provides more power saving when the sensor is off. While at that, do the delay on power/clock enable even if the sensor driver itself doesn't control the GPIOs. This is required for the OLPC XO-1 platform, that lacks the proper power/reset properties in its DT, but needs the delay after the s

Re: [PATCH v3 02/14] media: ov7670: split register setting from set_framerate() logic

2019-01-15 Thread Sakari Ailus
On Tue, Jan 15, 2019 at 09:30:31AM +0100, Lubomir Rintel wrote: > On Tue, 2019-01-15 at 01:03 +0200, Sakari Ailus wrote: > > On Tue, Nov 20, 2018 at 11:03:07AM +0100, Lubomir Rintel wrote: > > > This will allow us to restore the last set frame rate after the device > > > returns from a power off. >

Re: [PATCH v3] media: ov8856: Add support for OV8856 sensor

2019-01-15 Thread Sakari Ailus
Hi Ben, Thanks for the update! I've applied the patch, but please see the comments below. On Tue, Jan 15, 2019 at 04:30:29PM +0800, Ben Kao wrote: ... > +static int ov8856_read_reg(struct ov8856 *ov8856, u16 reg, u16 len, u32 *val) > +{ > + struct i2c_client *client = v4l2_get_subdevdata(&ov8

Re: [PATCH v3 02/14] media: ov7670: split register setting from set_framerate() logic

2019-01-15 Thread Lubomir Rintel
On Tue, 2019-01-15 at 01:03 +0200, Sakari Ailus wrote: > On Tue, Nov 20, 2018 at 11:03:07AM +0100, Lubomir Rintel wrote: > > This will allow us to restore the last set frame rate after the device > > returns from a power off. > > > > Signed-off-by: Lubomir Rintel > > > > --- > > Changes since v2

[GIT PULL FOR v5.1] Various fixes

2019-01-15 Thread Hans Verkuil
Most notably Sakari's patch which adds V4L2_BUF_TYPE_META_OUTPUT to the V4L2_TYPE_IS_OUTPUT define. The other two are vivid fixes to make it pass the media regression test I'm working on. Regards, Hans The following changes since commit 1e0d0a5fd38192f23304ea2fc2b531fea7c74247: media