[PATCH] media: lgdt3306a: fix a missing check of return value

2018-12-19 Thread Kangjie Lu
If lgdt3306a_read_reg() fails, the read data in "val" is incorrect, thus shouldn't be further used. The fix inserts a check for the return value of lgdt3306a_read_reg(). If it fails, goto fail. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/lgdt3306a.c | 4 +++- 1 file changed, 3 inse

[PATCH] media: drx: fix a missing check of return value

2018-12-19 Thread Kangjie Lu
Function drxj_dap_write_reg16(), which writes data to buffer, may fail. We need to check if it fails, and if so, we should goto error. Otherwise, the buffer will have incorrect data. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/drx39xyj/drxj.c | 6 +- 1 file changed, 5 insertion

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2018-12-19 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 6:18 PM Jonas Karlman wrote: > > On 2018-12-19 08:16, Tomasz Figa wrote: > > On Wed, Dec 19, 2018 at 4:04 PM Jonas Karlman wrote: > >> On 2018-12-19 06:10, Tomasz Figa wrote: > >>> On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil > >>> wrote: > On 12/12/18 7:28 PM, Jona

cron job: media_tree daily build: OK

2018-12-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Dec 20 05:00:11 CET 2018 media-tree git hash:daad52c8aa4fcf27d2e8b69daf851d82c141fd2f media_build git

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-19 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 11:51 PM Christoph Hellwig wrote: > > On Wed, Dec 19, 2018 at 05:18:35PM +0900, Tomasz Figa wrote: > > The existing code that deals with dma_alloc_attrs() without > > DMA_ATTR_NON_CONSISTENT would just call dma_get_sgtable_attrs() like > > here: > > I know. And dma_get_sgt

Re: [PATCH 5/5] media: dt-bindings: si470x: Document new reset-gpios property

2018-12-19 Thread Rob Herring
On Wed, 5 Dec 2018 16:47:50 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote: > Add information about new reset-gpios property to driver documentation > > Signed-off-by: Paweł Chmiel > --- > Documentation/devicetree/bindings/media/si470x.txt | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

2018-12-19 Thread Alex Deucher
On Tue, Dec 18, 2018 at 7:08 PM Brad Love wrote: > > > On 18/12/2018 18.05, Brad Love wrote: > > On 18/12/2018 17.46, Alex Deucher wrote: > >> On Tue, Dec 18, 2018 at 7:45 AM Mauro Carvalho Chehab > >> wrote: > >>> Em Mon, 17 Dec 2018 21:05:11 -0500 > >>> Alex Deucher escreveu: > >>> > On S

Re: [PATCH v2] cx23885: only reset DMA on problematic CPUs

2018-12-19 Thread Brad Love
Hi Alex, On 19/12/2018 11.26, Brad Love wrote: > Hi Alex, > > > On 18/12/2018 17.49, Alex Deucher wrote: >> On Tue, Dec 18, 2018 at 5:59 PM Brad Love wrote: >>> It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA >>> related RiSC engine stall fixes") caused regresssions with othe

Re: [PATCH v2] cx23885: only reset DMA on problematic CPUs

2018-12-19 Thread Brad Love
Hi Alex, On 18/12/2018 17.49, Alex Deucher wrote: > On Tue, Dec 18, 2018 at 5:59 PM Brad Love wrote: >> It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA >> related RiSC engine stall fixes") caused regresssions with other CPUs. >> >> Ensure that the quirk will be applied only f

Re: [PATCH v2] cx23885: only reset DMA on problematic CPUs

2018-12-19 Thread Brad Love
On 19/12/2018 05.08, Matthias Schwarzott wrote: > Am 18.12.18 um 23:59 schrieb Brad Love: >> It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA >> related RiSC engine stall fixes") caused regresssions with other CPUs. >> >> Ensure that the quirk will be applied only for the CPUs

[PATCH v3] cx23885: only reset DMA on problematic CPUs

2018-12-19 Thread Brad Love
It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA related RiSC engine stall fixes") caused regresssions with other CPUs. Ensure that the quirk will be applied only for the CPUs that are known to cause problems. A module option is added for explicit control of the behaviour. Fix

Re: [PATCH 2/5] dt-bindings: media: sun6i: Add vcc-csi supply property

2018-12-19 Thread Rob Herring
On Mon, Dec 03, 2018 at 06:11:35PM +0800, Chen-Yu Tsai wrote: > On Mon, Dec 3, 2018 at 6:08 PM Jagan Teki wrote: > > > > Most of the Allwinner A64 CSI controllers are supply with > > VCC-PE pin. which need to supply for some of the boards to > > trigger the power. > > > > So, document the supply p

Re: [PATCH 5/5] arm64: dts: allwinner: a64-amarula-relic: Add OV5640 camera node

2018-12-19 Thread Rob Herring
On Thu, Dec 06, 2018 at 04:43:33PM +0530, Jagan Teki wrote: > On Mon, Dec 3, 2018 at 3:55 PM Chen-Yu Tsai wrote: > > > > On Mon, Dec 3, 2018 at 6:08 PM Jagan Teki > > wrote: > > > > > > Amarula A64-Relic board by default bound with OV5640 camera, > > > so add support for it with below pin inform

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-19 Thread Maxime Ripard
On Mon, Dec 17, 2018 at 10:20:39PM +0200, sakari.ai...@iki.fi wrote: > Hi Maxime, > > On Mon, Dec 17, 2018 at 04:49:21PM +0100, Maxime Ripard wrote: > > Hi Sakari, > > > > Thanks for your feedback. > > > > On Thu, Dec 13, 2018 at 10:49:28PM +0200, sakari.ai...@iki.fi wrote: > > > > + /** >

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

2018-12-19 Thread Maxime Ripard
65;5402;1c On Wed, Dec 19, 2018 at 04:11:50PM +0530, Jagan Teki wrote: > On Wed, Dec 19, 2018 at 3:55 PM Maxime Ripard > wrote: > > > > On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > > > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard > > > wrote: > > > > > > > > On Tue, Dec 18, 20

Re: [PATCH v2] media: uvcvideo: Fix 'type' check leading to overflow

2018-12-19 Thread Alistair Strachan
On Wed, Dec 19, 2018 at 12:16 AM Laurent Pinchart wrote: > > Hi Alistair, > > Thank you for the patch. > > On Wednesday, 19 December 2018 03:32:48 EET Alistair Strachan wrote: > > From: Laurent Pinchart > > Are you sure you don't want to keep authorship ? I've merely reviewed v1 and > proposed an

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-19 Thread Christoph Hellwig
On Wed, Dec 19, 2018 at 05:18:35PM +0900, Tomasz Figa wrote: > The existing code that deals with dma_alloc_attrs() without > DMA_ATTR_NON_CONSISTENT would just call dma_get_sgtable_attrs() like > here: I know. And dma_get_sgtable_attrs is fundamentally flawed and we need to kill this interface as

Re: SYS_DVBS vs. SYS_DVBS2

2018-12-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Dec 2018 13:16:49 +0100 Josef Wolf escreveu: > Thanks for your response, Mauro! > > On Wed, Dec 19, 2018 at 09:22:11AM -0200, Mauro Carvalho Chehab wrote: > > Em Wed, 19 Dec 2018 11:28:46 +0100 > > Josef Wolf escreveu: > > > > I would like to know how to know whether for a specifi

Re: [alsa-devel] [PATCH v9 4/4] sound/usb: Use Media Controller API to share media resources

2018-12-19 Thread Takashi Iwai
On Tue, 18 Dec 2018 18:59:39 +0100, sh...@kernel.org wrote: > > From: Shuah Khan > > Media Device Allocator API to allows multiple drivers share a media device. > This API solves a very common use-case for media devices where one physical > device (an USB stick) provides both audio and video. Wh

Re: [PATCH v4l-utils] v4l2-ctl: Add support for CROP selection in m2m streaming

2018-12-19 Thread Dafna Hirschfeld
On Wed, Dec 19, 2018 at 12:03 PM Hans Verkuil wrote: > > On 12/19/18 9:34 AM, Dafna Hirschfeld wrote: > >>> +bool is_m2m_enc = false; > >> > >> This should be static. > >> > >> I'm assuming that in a future patch we'll get a is_m2m_dec as well? > > > > I forgot that there can be more options other

Re: SYS_DVBS vs. SYS_DVBS2

2018-12-19 Thread Josef Wolf
Thanks for your response, Mauro! On Wed, Dec 19, 2018 at 09:22:11AM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 19 Dec 2018 11:28:46 +0100 > Josef Wolf escreveu: > > I would like to know how to know whether for a specific program SYS_DVBS or > > SYS_DVBS2 should be specified to the FE_SET_PROP

[PATCH v2] media: vicodec: add support for CROP selection in the encoder

2018-12-19 Thread Dafna Hirschfeld
Add support for the selection api for the crop target in the encoder. The driver rounds up the coded width and height such that all planes dimensions are multiple of 8. Signed-off-by: Dafna Hirschfeld --- Changes from v1: Renaming fields to be more descriptive. Setting default values to g_selecti

Re: SYS_DVBS vs. SYS_DVBS2

2018-12-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Dec 2018 11:28:46 +0100 Josef Wolf escreveu: > Hello experts, > > hope I'm on the correct list for my question. Plese give me a pointer to the > correct list if I'm off-topic here. > > I would like to know how to know whether for a specific program SYS_DVBS or > SYS_DVBS2 should be s

Re: [PATCH v2] cx23885: only reset DMA on problematic CPUs

2018-12-19 Thread Matthias Schwarzott
Am 18.12.18 um 23:59 schrieb Brad Love: > It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA > related RiSC engine stall fixes") caused regresssions with other CPUs. > > Ensure that the quirk will be applied only for the CPUs that > are known to cause problems. > > A module optio

SYS_DVBS vs. SYS_DVBS2

2018-12-19 Thread Josef Wolf
Hello experts, hope I'm on the correct list for my question. Plese give me a pointer to the correct list if I'm off-topic here. I would like to know how to know whether for a specific program SYS_DVBS or SYS_DVBS2 should be specified to the FE_SET_PROPERTY ioctl() call. Is this somehow broadcast

Re: [PATCH v4 3/6] media: sun6i: Update default CSI_SCLK for A64

2018-12-19 Thread Jagan Teki
On Wed, Dec 19, 2018 at 3:37 PM Maxime Ripard wrote: > > On Tue, Dec 18, 2018 at 09:08:17PM +0530, Jagan Teki wrote: > > On Tue, Dec 18, 2018 at 8:53 PM Maxime Ripard > > wrote: > > > > > > On Tue, Dec 18, 2018 at 05:03:17PM +0530, Jagan Teki wrote: > > > > Unfortunately A64 CSI cannot work with

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

2018-12-19 Thread Jagan Teki
On Wed, Dec 19, 2018 at 3:55 PM Maxime Ripard wrote: > > On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard > > wrote: > > > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > > This series support CSI on Allwinner A

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

2018-12-19 Thread Michael Nazzareno Trimarchi
Hi Maxime On Wed, Dec 19, 2018 at 11:25 AM Maxime Ripard wrote: > > On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard > > wrote: > > > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > > This series support CSI on

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

2018-12-19 Thread Maxime Ripard
On Tue, Dec 18, 2018 at 08:58:22PM +0530, Jagan Teki wrote: > On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard > wrote: > > > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > > This series support CSI on Allwinner A64. > > > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYV

Re: [PATCH v4 3/6] media: sun6i: Update default CSI_SCLK for A64

2018-12-19 Thread Maxime Ripard
On Tue, Dec 18, 2018 at 09:08:17PM +0530, Jagan Teki wrote: > On Tue, Dec 18, 2018 at 8:53 PM Maxime Ripard > wrote: > > > > On Tue, Dec 18, 2018 at 05:03:17PM +0530, Jagan Teki wrote: > > > Unfortunately A64 CSI cannot work with default CSI_SCLK rate. > > > > > > A64 BSP is using 300MHz clock ra

Re: [PATCH v4l-utils] v4l2-ctl: Add support for CROP selection in m2m streaming

2018-12-19 Thread Hans Verkuil
On 12/19/18 9:34 AM, Dafna Hirschfeld wrote: >>> +bool is_m2m_enc = false; >> >> This should be static. >> >> I'm assuming that in a future patch we'll get a is_m2m_dec as well? > > I forgot that there can be more options other than m2m_enc/_dec. > So actually adding is_m2m_dec is needed. Or I can

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2018-12-19 Thread Jonas Karlman
On 2018-12-19 08:16, Tomasz Figa wrote: > On Wed, Dec 19, 2018 at 4:04 PM Jonas Karlman wrote: >> On 2018-12-19 06:10, Tomasz Figa wrote: >>> On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil >>> wrote: On 12/12/18 7:28 PM, Jonas Karlman wrote: > Hi Hans, > > Since this function only

Re: [PATCH v4l-utils] v4l2-ctl: Add support for CROP selection in m2m streaming

2018-12-19 Thread Dafna Hirschfeld
On Tue, Dec 18, 2018 at 2:43 PM Hans Verkuil wrote: > > On 12/18/18 12:11 PM, Dafna Hirschfeld wrote: > > Add support for crop in the selection api for m2m encoder. > > This includes reading and writing raw frames with padding. > > > > Signed-off-by: Dafna Hirschfeld > > --- > > Tested with the j

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-19 Thread Tomasz Figa
On Wed, Dec 19, 2018 at 4:51 PM Christoph Hellwig wrote: > > On Tue, Dec 18, 2018 at 06:48:03PM +0900, Tomasz Figa wrote: > > > So as I said you can call dma_alloc_attrs with DMA_ATTR_NON_CONSISTENT > > > in a loop with a suitably small chunk size, then stuff the results into > > > a scatterlist a

Re: [PATCH v2] media: uvcvideo: Fix 'type' check leading to overflow

2018-12-19 Thread Laurent Pinchart
Hi Alistair, Thank you for the patch. On Wednesday, 19 December 2018 03:32:48 EET Alistair Strachan wrote: > From: Laurent Pinchart Are you sure you don't want to keep authorship ? I've merely reviewed v1 and proposed an alternative implementation :-) Let me know what you would prefer and I'l