Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

On Tue, Dec 18, 2018 at 06:48:03PM +0900, Tomasz Figa wrote: > > So as I said you can call dma_alloc_attrs with DMA_ATTR_NON_CONSISTENT > > in a loop with a suitably small chunk size, then stuff the results into > > a scatterlist and map that again for the device share with if you don't > > want a

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

On Wed, Dec 19, 2018 at 4:04 PM Jonas Karlman wrote: > > On 2018-12-19 06:10, Tomasz Figa wrote: > > On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil > > wrote: > >> On 12/12/18 7:28 PM, Jonas Karlman wrote: > >>> Hi Hans, > >>> > >>> Since this function only return DEQUEUED and DONE buffers, > >>>

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

On 2018-12-19 06:10, Tomasz Figa wrote: > On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil wrote: >> On 12/12/18 7:28 PM, Jonas Karlman wrote: >>> Hi Hans, >>> >>> Since this function only return DEQUEUED and DONE buffers, >>> it cannot be used to find a capture buffer that is both used for >>> frame

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

On Thu, Dec 13, 2018 at 9:28 PM Hans Verkuil wrote: > > On 12/12/18 7:28 PM, Jonas Karlman wrote: > > Hi Hans, > > > > Since this function only return DEQUEUED and DONE buffers, > > it cannot be used to find a capture buffer that is both used for > > frame output and is part of the frame reference

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Dec 19 05:00:10 CET 2018 media-tree git hash:daad52c8aa4fcf27d2e8b69daf851d82c141fd2f media_build git

[PATCH v2] media: uvcvideo: Fix 'type' check leading to overflow

From: Laurent Pinchart When initially testing the Camera Terminal Descriptor wTerminalType field (buffer[4]), no mask is used. Later in the function, the MSB is overloaded to store the descriptor subtype, and so a mask of 0x7fff is used to check the type. If a descriptor is specially crafted to

Re: [PATCH] media: uvcvideo: Fix 'type' check leading to overflow

Hi Laurent, On Tue, Dec 18, 2018 at 1:42 AM Laurent Pinchart wrote: > > Hi Alistair, > > Thank you for the patch. > > On Monday, 17 December 2018 23:02:22 EET Alistair Strachan wrote: > > When initially testing the Camera Terminal Descriptor wTerminalType > > field (buffer[4]), no mask is used. L

Re: [PATCH 2/3] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver

Hi Marco, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [cannot apply to v4.20-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mar

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

On 18/12/2018 18.05, Brad Love wrote: > On 18/12/2018 17.46, Alex Deucher wrote: >> On Tue, Dec 18, 2018 at 7:45 AM Mauro Carvalho Chehab >> wrote: >>> Em Mon, 17 Dec 2018 21:05:11 -0500 >>> Alex Deucher escreveu: >>> On Sun, Dec 16, 2018 at 9:23 AM Mauro Carvalho Chehab wrote: >

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

On 18/12/2018 17.46, Alex Deucher wrote: > On Tue, Dec 18, 2018 at 7:45 AM Mauro Carvalho Chehab > wrote: >> Em Mon, 17 Dec 2018 21:05:11 -0500 >> Alex Deucher escreveu: >> >>> On Sun, Dec 16, 2018 at 9:23 AM Mauro Carvalho Chehab >>> wrote: Em Sun, 16 Dec 2018 11:37:02 +0100 Markus

Re: [PATCH v2] cx23885: only reset DMA on problematic CPUs

On Tue, Dec 18, 2018 at 5:59 PM Brad Love wrote: > > It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA > related RiSC engine stall fixes") caused regresssions with other CPUs. > > Ensure that the quirk will be applied only for the CPUs that > are known to cause problems. > > A mo

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

On Tue, Dec 18, 2018 at 7:45 AM Mauro Carvalho Chehab wrote: > > Em Mon, 17 Dec 2018 21:05:11 -0500 > Alex Deucher escreveu: > > > On Sun, Dec 16, 2018 at 9:23 AM Mauro Carvalho Chehab > > wrote: > > > > > > Em Sun, 16 Dec 2018 11:37:02 +0100 > > > Markus Dobel escreveu: > > > > > > > On 06.12.

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

Hi everyone, On 18/12/2018 06.45, Mauro Carvalho Chehab wrote: > Em Mon, 17 Dec 2018 21:05:11 -0500 > Alex Deucher escreveu: > >> On Sun, Dec 16, 2018 at 9:23 AM Mauro Carvalho Chehab >> wrote: >>> Em Sun, 16 Dec 2018 11:37:02 +0100 >>> Markus Dobel escreveu: >>> On 06.12.2018 19:01, Ma

[PATCH v2] cx23885: only reset DMA on problematic CPUs

It is reported that commit 95f408bbc4e4 ("media: cx23885: Ryzen DMA related RiSC engine stall fixes") caused regresssions with other CPUs. Ensure that the quirk will be applied only for the CPUs that are known to cause problems. A module option is added for explicit control of the behaviour. Fix

Re: [PATCH] v4l2-ctrls.c/uvc: zero v4l2_event

Hi Hans, Thank you for the patch. On Tuesday, 18 December 2018 15:37:08 EET Hans Verkuil wrote: > Control events can leak kernel memory since they do not fully zero the > event. The same code is present in both v4l2-ctrls.c and uvc_ctrl.c, so > fix both. > > It appears that all other event code

Re: [PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

On Tue, Dec 18, 2018 at 10:42:30AM -0600, Rob Herring wrote: > On Tue, Dec 11, 2018 at 10:48:39AM +0100, Thierry Reding wrote: > > From: Thierry Reding > > > > The Tegra186 and Tegra194 contain a CEC controller that is identical to > > that found in earlier generations. Document the compatible st

[PATCH v9 0/4] Media Device Allocator API

From: Shuah Khan Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Vi

[PATCH v9 2/4] media: change au0828 to use Media Device Allocator API

From: Shuah Khan Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Vi

[PATCH v9 1/4] media: Media Device Allocator API

From: Shuah Khan Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Vi

[PATCH v9 4/4] sound/usb: Use Media Controller API to share media resources

From: Shuah Khan Media Device Allocator API to allows multiple drivers share a media device. This API solves a very common use-case for media devices where one physical device (an USB stick) provides both audio and video. When such media device exposes a standard USB Audio class, a proprietary Vi

[PATCH v9 3/4] media: media.h: Enable ALSA MEDIA_INTF_T* interface types

From: Shuah Khan Move PCM_CAPTURE, PCM_PLAYBACK, and CONTROL ALSA MEDIA_INTF_T* interface types back into __KERNEL__ scope to get ready for adding ALSA support for these to the media controller. Signed-off-by: Shuah Khan --- include/uapi/linux/media.h | 25 +++-- 1 file cha

Re: Test results (v4l2) for media/master - v4.20-rc5-281-gd2b4387f3bdf

Em Tue, 18 Dec 2018 07:31:23 -0800 (PST) "kernelci.org bot" escreveu: > Test results for: > Tree:media > Branch: master > Kernel: v4.20-rc5-281-gd2b4387f3bdf > URL: https://git.linuxtv.org/media_tree.git > Commit: d2b4387f3bdf016e266d23cf657465f557721488 > Test plans: v4l2

Re: media/master build: 227 builds: 2 failed, 225 passed, 2 errors, 90 warnings (v4.20-rc5-281-gd2b4387f3bdf)

Hi Ezequiel, Thanks for setting this. I have a few comments. See below: Em Tue, 18 Dec 2018 07:29:28 -0800 (PST) "kernelci.org bot" escreveu: > media/master build: 227 builds: 2 failed, 225 passed, 2 errors, 90 warnings > (v4.20-rc5-281-gd2b4387f3bdf) This looked a lot uglier than it should b

Re: [PATCH v2 1/3] dt-bindings: media: tegra-cec: Document Tegra186 and Tegra194

On Tue, Dec 11, 2018 at 10:48:39AM +0100, Thierry Reding wrote: > From: Thierry Reding > > The Tegra186 and Tegra194 contain a CEC controller that is identical to > that found in earlier generations. Document the compatible strings for > these newer chips. If identical, why don't you have a fall

Re: [PATCH v2 4/4] media: dt-bindings: Add binding for si470x radio

On Fri, 7 Dec 2018 14:58:12 +0100, =?UTF-8?q?Pawe=C5=82=20Chmiel?= wrote: > Add device tree bindings for si470x family radio receiver driver. > > Signed-off-by: Paweł Chmiel > --- > Changes from v1: > - squashed with patch adding reset-gpio documentation > --- > .../devicetree/bindings/me

Re: [PATCH v4 3/6] media: sun6i: Update default CSI_SCLK for A64

On Tue, Dec 18, 2018 at 8:53 PM Maxime Ripard wrote: > > On Tue, Dec 18, 2018 at 05:03:17PM +0530, Jagan Teki wrote: > > Unfortunately A64 CSI cannot work with default CSI_SCLK rate. > > > > A64 BSP is using 300MHz clock rate as default csi clock, > > so sun6i_csi require explicit change to update

Test results (v4l2) for media/master - v4.20-rc5-281-gd2b4387f3bdf

Test results for: Tree:media Branch: master Kernel: v4.20-rc5-281-gd2b4387f3bdf URL: https://git.linuxtv.org/media_tree.git Commit: d2b4387f3bdf016e266d23cf657465f557721488 Test plans: v4l2 Summary --- 4 test groups results 1 | v4l2 | rk3399-gru-kevin | arm

media/master build: 227 builds: 2 failed, 225 passed, 2 errors, 90 warnings (v4.20-rc5-281-gd2b4387f3bdf)

media/master build: 227 builds: 2 failed, 225 passed, 2 errors, 90 warnings (v4.20-rc5-281-gd2b4387f3bdf) Full Build Summary: https://kernelci.org/build/media/branch/master/kernel/v4.20-rc5-281-gd2b4387f3bdf/ Tree: media Branch: master Git Describe: v4.20-rc5-281-gd2b4387f3bdf Git Commit: d2b43

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

On Tue, Dec 18, 2018 at 8:51 PM Maxime Ripard wrote: > > On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > > This series support CSI on Allwinner A64. > > > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > > > Changes for v4: > > - update the compatible string o

Re: [PATCH v4 3/6] media: sun6i: Update default CSI_SCLK for A64

On Tue, Dec 18, 2018 at 05:03:17PM +0530, Jagan Teki wrote: > Unfortunately A64 CSI cannot work with default CSI_SCLK rate. > > A64 BSP is using 300MHz clock rate as default csi clock, > so sun6i_csi require explicit change to update CSI_SCLK > rate to 300MHZ for A64 SoC's. > > So, set the clk_mo

Re: [PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

On Tue, Dec 18, 2018 at 05:03:14PM +0530, Jagan Teki wrote: > This series support CSI on Allwinner A64. > > Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. > > Changes for v4: > - update the compatible string order > - add proper commit message > - included BPI-M64 patch > - sk

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

On 12/18/18 3:21 PM, Paul Kocialkowski wrote: > Hi, > > On Thu, 2018-12-13 at 13:28 +0100, Hans Verkuil wrote: >> On 12/12/18 7:28 PM, Jonas Karlman wrote: >>> Hi Hans, >>> >>> Since this function only return DEQUEUED and DONE buffers, >>> it cannot be used to find a capture buffer that is both us

Re: [PATCHv5 0/8] vb2/cedrus: use timestamps to identify buffers

Hi, On Wed, 2018-12-12 at 13:38 +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. > > Instead, after a

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

Hi, On Thu, 2018-12-13 at 13:28 +0100, Hans Verkuil wrote: > On 12/12/18 7:28 PM, Jonas Karlman wrote: > > Hi Hans, > > > > Since this function only return DEQUEUED and DONE buffers, > > it cannot be used to find a capture buffer that is both used for > > frame output and is part of the frame ref

[PATCH 2/3] media: tc358746: add Toshiba TC358746 Parallel to CSI-2 bridge driver

Adding support for the TC358746 bridge. The Bridge can receive images on the parallel input port and send it to the host using the CSI-TX unit. Furthermore the Bridge can receive images from the host using the CSI-RX unit and send it to the parallel output port. Currently the only the first case i

[PATCH 0/3] media: add Toshiba TC358746 Bridge support

Hi, this patch set adds the support for the Toshiba TC358746 Parallel MIPI-CSI2 bridge device. The last patch ("media: tc358746: update MAINTAINERS file") is optional, due to Hans answer to Michael [1]. We can drop this patch if it isn't needed. I added the v4l2-compliance test in relation to [1

[PATCH 3/3] media: tc358746: update MAINTAINERS file

Add me as partial maintainer, others are welcome too. Signed-off-by: Marco Felsch --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 546f8d936589..f97dedbe545c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15230,6 +15230,13 @@ S: Maint

[PATCH 1/3] media: dt-bindings: add bindings for Toshiba TC358746

Add corresponding dt-bindings for the Toshiba tc358746 device. Signed-off-by: Marco Felsch --- .../bindings/media/i2c/toshiba,tc358746.txt | 80 +++ 1 file changed, 80 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,tc358746.txt diff --gi

Re: [PATCH v6 09/12] media: ov5640: Make the return rate type more explicit

On Mon, Dec 3, 2018 at 2:14 PM Maxime Ripard wrote: > > In the ov5640_try_frame_interval function, the ret variable actually holds > the frame rate index to use, which is represented by the enum > ov5640_frame_rate in the driver. > > Make it more obvious. > > Signed-off-by: Maxime Ripard > Tested

[PATCH] v4l2-ctrls.c/uvc: zero v4l2_event

Control events can leak kernel memory since they do not fully zero the event. The same code is present in both v4l2-ctrls.c and uvc_ctrl.c, so fix both. It appears that all other event code is properly zeroing the structure, it's these two places. Signed-off-by: Hans Verkuil Reported-by: syzbot+

Re: [PATCH] Revert 95f408bb Ryzen DMA related RiSC engine stall fixes

Em Mon, 17 Dec 2018 21:05:11 -0500 Alex Deucher escreveu: > On Sun, Dec 16, 2018 at 9:23 AM Mauro Carvalho Chehab > wrote: > > > > Em Sun, 16 Dec 2018 11:37:02 +0100 > > Markus Dobel escreveu: > > > > > On 06.12.2018 19:01, Mauro Carvalho Chehab wrote: > > > > Em Thu, 06 Dec 2018 18:18:23 +

Re: [PATCH v4l-utils] v4l2-ctl: Add support for CROP selection in m2m streaming

On 12/18/18 12:11 PM, Dafna Hirschfeld wrote: > Add support for crop in the selection api for m2m encoder. > This includes reading and writing raw frames with padding. > > Signed-off-by: Dafna Hirschfeld > --- > Tested with the jellyfish video, with this script: > https://github.com/kamomil/outre

KMSAN: kernel-infoleak in video_usercopy

Hello, syzbot found the following crash on: HEAD commit:0a602458c72c kmsan: random: another take at unpoisoning CR.. git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=12f2cd5d40 kernel config: https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 dashb

[PATCH v4 0/6] media/sun6i: Allwinner A64 CSI support

This series support CSI on Allwinner A64. Tested 640x480, 320x240, 720p, 1080p resolutions UYVY8_2X8 format. Changes for v4: - update the compatible string order - add proper commit message - included BPI-M64 patch - skipped amarula-a64 patch Changes for v3: - update dt-bindings for A64 - set mod

[PATCH v4 3/6] media: sun6i: Update default CSI_SCLK for A64

Unfortunately A64 CSI cannot work with default CSI_SCLK rate. A64 BSP is using 300MHz clock rate as default csi clock, so sun6i_csi require explicit change to update CSI_SCLK rate to 300MHZ for A64 SoC's. So, set the clk_mod to 300MHz only for A64. Signed-off-by: Jagan Teki --- drivers/media/p

[PATCH v4 4/6] arm64: dts: allwinner: a64: Add A64 CSI controller

Add dts node details for Allwinner A64 CSI controller. A64 CSI has similar features as like in H3, but the CSI_SCLK need to update it to 300MHz than default clock rate. Signed-off-by: Jagan Teki --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 20 +++ 1 file changed, 20 inser

[PATCH v4 1/6] dt-bindings: media: sun6i: Add A64 CSI compatible

Allwinner A64 CSI is a single channel time-multiplexed BT.656 protocol interface. Add separate compatible string for A64 since it require explicit change in sun6i_csi driver to update default CSI_SCLK rate. Reviewed-by: Rob Herring Signed-off-by: Jagan Teki --- Documentation/devicetree/binding

[PATCH v4 2/6] media: sun6i: Add A64 compatible support

Add compatible string for Allwinner A64 CSI. A64 CSI has similar features as like in H3, but the CSI_SCLK need to update it to 300MHz than default clock rate. A64 BSP is also operating same rate as default csi clock. Signed-off-by: Jagan Teki --- drivers/media/platform/sunxi/sun6i-csi/sun6i_cs

[PATCH v4 5/6] arm64: dts: allwinner: a64: Add pinmux setting for CSI MCLK on PE1

Some camera modules have the SoC feeding a master clock to the sensor instead of having a standalone crystal. This clock signal is generated from the clock control unit and output from the CSI MCLK function of pin PE1. Add a pinmux setting for it for camera sensors to reference. Signed-off-by: Ja

[DO NOT MERGE] [PATCH v4 6/6] arm64: dts: allwinner: bananapi-m64: Add HDF5640 camera module

Bananapi M64 comes with an optional sensor based on the ov5640, add support for it with below pin information. - PE13, PE12 via i2c-gpio bitbanging - CLK_CSI_MCLK as external clock - PE1 as external clock pin muxing - DLDO3 as AVDD supply - ALDO1 as DOVDD supply - ELDO3 as DVDD supply - PE16 gpio

[PATCH v4l-utils] v4l2-ctl: Add support for CROP selection in m2m streaming

Add support for crop in the selection api for m2m encoder. This includes reading and writing raw frames with padding. Signed-off-by: Dafna Hirschfeld --- Tested with the jellyfish video, with this script: https://github.com/kamomil/outreachy/blob/master/test-v4l2-utils-with-jelly.sh Tested on for

Re: [PATCH] media: vicodec: add support for CROP selection

On 12/17/18 6:23 PM, Dafna Hirschfeld wrote: > > > On Sun, Dec 16, 2018 at 2:24 PM Hans Verkuil > wrote: > > On 12/15/18 12:54 PM, Dafna Hirschfeld wrote: > > Add support for the selection api for the crop target. > > Mention that this is added for the en

[PATCH V3 0/2] Replace all open encodings for NUMA_NO_NODE

Changes in V3: - Dropped all references to NUMA_NO_NODE as per Lubomir Rinetl - Split the patch into two creating a new one specifically for tools - Folded Stephen's linux-next build fix into the second patch Changes in V2: (https://patchwork.kernel.org/patch/10698089/) - Added inclusion of 'num

[PATCH V3 1/2] mm: Replace all open encodings for NUMA_NO_NODE

At present there are multiple places where invalid node number is encoded as -1. Even though implicitly understood it is always better to have macros in there. Replace these open encodings for an invalid node number with the global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like

[PATCH V3 2/2] Tools: Replace open encodings for NUMA_NO_NODE

From: Stephen Rothwell This replaces all open encodings in tools with NUMA_NO_NODE. Also linux/numa.h is now needed for the perf build. Signed-off-by: Anshuman Khandual Signed-off-by: Stephen Rothwell --- tools/include/linux/numa.h | 16 tools/perf/bench/numa.c| 6 +++---

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

On Tue, Dec 18, 2018 at 4:38 PM Christoph Hellwig wrote: > > On Tue, Dec 18, 2018 at 04:22:43PM +0900, Tomasz Figa wrote: > > It kind of limits the usability of this API, since it enforces > > contiguous allocations even for big sizes even for devices behind > > IOMMU (contrary to the case when DM

Re: [PATCH] media: uvcvideo: Fix 'type' check leading to overflow

Hi Alistair, Thank you for the patch. On Monday, 17 December 2018 23:02:22 EET Alistair Strachan wrote: > When initially testing the Camera Terminal Descriptor wTerminalType > field (buffer[4]), no mask is used. Later in the function, the MSB is > overloaded to store the descriptor subtype, and s