Re: [Xen-devel][PATCH v3 1/1] cameraif: add ABI for para-virtual camera

2018-12-13 Thread Oleksandr Andrushchenko
PFA the diff between v2 and v3 for your convenience On 12/12/18 11:49 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized camera driver which extends Xen's reach multimedia capabilities even farther enabling it for video con

[PATCH 1/4] rcar-vin: fix wrong return value in rvin_set_channel_routing()

2018-12-13 Thread Niklas Söderlund
If the operation in rvin_set_channel_routing() is successful the 'ret' variable contains the runtime PM use count for the VIN master device. The intention is not to return the use count to the caller but to return 0 on success else none zero. Fix this by always returning 0 if the operation is succ

[PATCH 3/4] rcar-vin: make rvin_{start,stop}_streaming() available for internal use

2018-12-13 Thread Niklas Söderlund
To support suspend/resume rvin_{start,stop}_streaming() needs to be accessible from the suspend and resume callbacks. Up until now the only users of these functions have been the callbacks in struct vb2_ops so the arguments to the functions are not suitable for use by the driver it self. Fix this

[PATCH 4/4] rcar-vin: add support for suspend and resume

2018-12-13 Thread Niklas Söderlund
To be able to properly support suspend and resume the VIN and all subdevices involved in a running capture needs to be stopped before the system is suspended. Likewise the whole pipeline needs to be started once the system is resumed if it was running. Achieve this by using the existing rvin_{star

[PATCH 0/4] rcar-vin: add support for suspend and resume

2018-12-13 Thread Niklas Söderlund
Hi, This series add suspend and resume support for rcar-vin pipelines. It suspends all active pipelines and implicitly adds support for suspend/resume to rcar-csi2. It is tested on Gen3 and Gen2 and based on-top of latest media-tree. Patch 1/4 fixes a bug in the driver which prevents suspend/r

[PATCH 2/4] rcar-vin: cache the CSI-2 channel selection value

2018-12-13 Thread Niklas Söderlund
In preparation of suspend/resume support cache the chsel value when we write it to the register so it can be restored on resume if needed. Signed-off-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-dma.c | 2 ++ drivers/media/platform/rcar-vin/rcar-vin.h | 2 ++ 2 files changed, 4

cron job: media_tree daily build: OK

2018-12-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Dec 14 05:00:17 CET 2018 media-tree git hash:d2b4387f3bdf016e266d23cf657465f557721488 media_build git

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-13 Thread Tomasz Figa
On Thu, Dec 13, 2018 at 11:03 PM Christoph Hellwig wrote: > > On Thu, Dec 13, 2018 at 12:13:29PM +0900, Tomasz Figa wrote: > > Putting aside the problem of memory without struct page, one thing to > > note here that what is a contiguous DMA range for device X, may not be > > mappable contiguously

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-13 Thread Bingbu Cao
On 12/14/2018 06:24 AM, Laurent Pinchart wrote: Hello Bingbu, On Wednesday, 12 December 2018 06:55:53 EET Bingbu Cao wrote: On 12/11/2018 09:43 PM, Laurent Pinchart wrote: On Tuesday, 11 December 2018 15:34:49 EET Laurent Pinchart wrote: On Wednesday, 5 December 2018 02:30:46 EET Mani, Raj

Re: [PATCH 0/6] media: sun6i: Separate H3 compatible from A31

2018-12-13 Thread Chen-Yu Tsai
On Fri, Dec 14, 2018 at 6:10 AM wrote: > > Hi Chen-Yu, > > On Fri, Nov 30, 2018 at 03:58:43PM +0800, Chen-Yu Tsai wrote: > > The CSI (camera sensor interface) controller found on the H3 (and H5) > > is a reduced version of the one found on the A31. It only has 1 channel, > > instead of 4 channels

Re: [PATCH v8 2/2] media: platform: Add Aspeed Video Engine driver

2018-12-13 Thread Joel Stanley
On Wed, 12 Dec 2018 at 04:09, Eddie James wrote: > > The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs > can capture and compress video data from digital or analog sources. With > the Aspeed chip acting a service processor, the Video Engine can capture > the host processor grap

Re: [PATCH v5 1/1] media: rc: rcmm decoder

2018-12-13 Thread Patrick Lerda
Hi Sean,    Is the v5 OK?    Thanks, Patrick. Patrick Lerda wrote: media: add support for RCMM infrared remote controls. Signed-off-by: Patrick Lerda --- MAINTAINERS| 5 + drivers/media/rc/Kconfig | 7 ++ drivers/media/rc/Makefile | 1 +

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-13 Thread Laurent Pinchart
Hello Bingbu, On Wednesday, 12 December 2018 06:55:53 EET Bingbu Cao wrote: > On 12/11/2018 09:43 PM, Laurent Pinchart wrote: > > On Tuesday, 11 December 2018 15:34:49 EET Laurent Pinchart wrote: > >> On Wednesday, 5 December 2018 02:30:46 EET Mani, Rajmohan wrote: > >> > >> [snip] > >> > >>> I

Re: [PATCH 0/6] media: sun6i: Separate H3 compatible from A31

2018-12-13 Thread sakari . ailus
Hi Chen-Yu, On Fri, Nov 30, 2018 at 03:58:43PM +0800, Chen-Yu Tsai wrote: > The CSI (camera sensor interface) controller found on the H3 (and H5) > is a reduced version of the one found on the A31. It only has 1 channel, > instead of 4 channels supporting time-multiplexed BT.656 on the A31. > Sinc

Re: [PATCH] [media] v4l: vsp1: Add RZ/G support

2018-12-13 Thread Laurent Pinchart
Hi Fabrizio, Thank you for the patch. On Thursday, 13 December 2018 22:20:24 EET Fabrizio Castro wrote: > Document RZ/G1 and RZ/G2 support. > > Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart And applied to my tree. > --- > Documentation/devicetree/bindings/media/renesas,vsp1.

Re: [PATCH] dt-bindings: media: renesas-fcp: Add RZ/G2 support

2018-12-13 Thread Laurent Pinchart
Hi Fabrizio, Thank you for the patch. On Thursday, 13 December 2018 22:20:33 EET Fabrizio Castro wrote: > Document RZ/G2 support. > > Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart And applied to my tree. > --- > Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 +++

Re: [GIT PULL for v4.20-rc7] media fixes

2018-12-13 Thread pr-tracker-bot
The pull request you sent on Wed, 12 Dec 2018 13:54:03 -0200: > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media > tags/media/v4.20-5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/14a996c383129525e55bab07e4857d08f6b61dda Thank you! -- Deet-doot-do

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
On Thu, Dec 13, 2018 at 10:54:28PM +0200, sakari.ai...@iki.fi wrote: > Hi Maxime, > > One more small note. > > On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: > > ... > > > + /** > > +* @wakeup: > > +* > > +* Time, in picoseconds, that a transmitter drives a Mark-1

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
Hi Maxime, One more small note. On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: ... > + /** > + * @wakeup: > + * > + * Time, in picoseconds, that a transmitter drives a Mark-1 > + * state prior to a Stop state in order to initiate an exit > + * from U

Re: [PATCH v3 03/10] phy: Add MIPI D-PHY configuration options

2018-12-13 Thread sakari . ailus
Hi Maxime, On Fri, Dec 07, 2018 at 02:55:30PM +0100, Maxime Ripard wrote: > Now that we have some infrastructure for it, allow the MIPI D-PHY phy's to > be configured through the generic functions through a custom structure > added to the generic union. > > The parameters added here are the ones

Re: [PATCH v3 02/10] phy: Add configuration interface

2018-12-13 Thread sakari . ailus
Hi Maxime, On Fri, Dec 07, 2018 at 02:55:29PM +0100, Maxime Ripard wrote: > The phy framework is only allowing to configure the power state of the PHY > using the init and power_on hooks, and their power_off and exit > counterparts. > > While it works for most, simple, PHYs supported so far, some

[PATCH 1/1] ov9640: Wrap long and unwrap short lines, align wrapped lines correctly

2018-12-13 Thread Sakari Ailus
Some little style fixup work. Signed-off-by: Sakari Ailus --- drivers/media/i2c/ov9640.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/ov9640.c b/drivers/media/i2c/ov9640.c index c183273fd332..295dcc5992c9 100644 --- a/drivers/media/i2c/ov9640.

[PATCH] media: rcar-csi2: Add support for RZ/G2E

2018-12-13 Thread Fabrizio Castro
According to the RZ/G2 User's manual, RZ/G2E and R-Car E3 CSI-2 blocks are identical, therefore use R-Car E3 definitions to add RZ/G2E support. Signed-off-by: Fabrizio Castro --- drivers/media/platform/rcar-vin/rcar-csi2.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/pla

[PATCH] media: dt-bindings: rcar-vin: Add R8A774C0 support

2018-12-13 Thread Fabrizio Castro
Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the list of SoCs supported by rcar-vin driver. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/media/rcar_vin.txt | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/b

[PATCH] [media] v4l: vsp1: Add RZ/G support

2018-12-13 Thread Fabrizio Castro
Document RZ/G1 and RZ/G2 support. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/media/renesas,vsp1.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,vsp1.txt b/Documentation/devicetree/bindings/me

[PATCH] media: rcar-vin: Add support for RZ/G2E

2018-12-13 Thread Fabrizio Castro
According to the RZ/G2 User's manual, RZ/G2E and R-Car E3 VIN blocks are identical, therefore use R-Car E3 definitions to add RZ/G2E support. Signed-off-by: Fabrizio Castro --- drivers/media/platform/rcar-vin/rcar-core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/platf

[PATCH] media: dt-bindings: rcar-csi2: Add r8a774c0

2018-12-13 Thread Fabrizio Castro
Add the compatible string for RZ/G2E (a.k.a. R8A774C0) to the list of supported SoCs. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/media/renesas,rcar-csi2.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/media/ren

[PATCH] dt-bindings: media: renesas-fcp: Add RZ/G2 support

2018-12-13 Thread Fabrizio Castro
Document RZ/G2 support. Signed-off-by: Fabrizio Castro --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,f

Re: [RFCv5 PATCH 2/4] media controller: add properties support

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 18:35:15 +0100 Hans Verkuil escreveu: > On 12/13/18 6:14 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 13 Dec 2018 14:41:11 +0100 > > hverkuil-ci...@xs4all.nl escreveu: > > > >> From: Hans Verkuil > >> > >> Add support for properties. In this initial implementation properti

Re: [RFCv5 PATCH 1/4] uapi/linux/media.h: add property support

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 18:13:03 +0100 Hans Verkuil escreveu: > On 12/13/18 5:41 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 13 Dec 2018 14:41:10 +0100 > > hverkuil-ci...@xs4all.nl escreveu: > > > >> From: Hans Verkuil > >> > >> Extend the topology struct with a properties array. > >> > >> Add a

Re: [RFCv5 PATCH 2/4] media controller: add properties support

2018-12-13 Thread Hans Verkuil
On 12/13/18 6:14 PM, Mauro Carvalho Chehab wrote: > Em Thu, 13 Dec 2018 14:41:11 +0100 > hverkuil-ci...@xs4all.nl escreveu: > >> From: Hans Verkuil >> >> Add support for properties. In this initial implementation properties >> can be added to entities and pads. In addition, properties can be >> n

Re: [RFCv5 PATCH 4/4] vimc: add property test code

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 14:41:13 +0100 hverkuil-ci...@xs4all.nl escreveu: > From: Hans Verkuil > > Add properties to entities and pads to be able to test the > properties API. Looks OK to me. > > Signed-off-by: Hans Verkuil > --- > drivers/media/platform/vimc/vimc-common.c | 50

Re: [RFCv5 PATCH 3/4] media: add functions to add properties to objects

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 14:41:12 +0100 hverkuil-ci...@xs4all.nl escreveu: > From: Hans Verkuil > > Add functions to add properties to entities, pads and other > properties. This can be extended to include interfaces and links > in the future when needed. > > Signed-off-by: Hans Verkuil > --- > dr

Re: [RFCv5 PATCH 1/4] uapi/linux/media.h: add property support

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 14:41:13 -0200 Mauro Carvalho Chehab escreveu: > Em Thu, 13 Dec 2018 14:41:10 +0100 > hverkuil-ci...@xs4all.nl escreveu: > > > From: Hans Verkuil > > > > Extend the topology struct with a properties array. > > > > Add a new media_v2_prop structure to store property informa

Re: [RFCv5 PATCH 2/4] media controller: add properties support

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 14:41:11 +0100 hverkuil-ci...@xs4all.nl escreveu: > From: Hans Verkuil > > Add support for properties. In this initial implementation properties > can be added to entities and pads. In addition, properties can be > nested. > > Most of the changes are straightforward, but I h

Re: [RFCv5 PATCH 1/4] uapi/linux/media.h: add property support

2018-12-13 Thread Hans Verkuil
On 12/13/18 5:41 PM, Mauro Carvalho Chehab wrote: > Em Thu, 13 Dec 2018 14:41:10 +0100 > hverkuil-ci...@xs4all.nl escreveu: > >> From: Hans Verkuil >> >> Extend the topology struct with a properties array. >> >> Add a new media_v2_prop structure to store property information. >> >> Signed-off-by:

Re: [RFCv5 PATCH 1/4] uapi/linux/media.h: add property support

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 14:41:10 +0100 hverkuil-ci...@xs4all.nl escreveu: > From: Hans Verkuil > > Extend the topology struct with a properties array. > > Add a new media_v2_prop structure to store property information. > > Signed-off-by: Hans Verkuil > --- > include/uapi/linux/media.h | 56

[PATCH v3 2/8] media: i2c: ov9640: drop soc_camera code and switch to v4l2_async

2018-12-13 Thread petrcvekcz
From: Petr Cvek This patch removes the dependency on an obsoleted soc_camera from ov9640 driver and changes the code to be a standalone v4l2 async subdevice. It also adds GPIO allocations for power and reset signals (as they are not handled by soc_camera now). The values for waiting on GPIOs (re

[PATCH v3 8/8] media: i2c: ov9640: fix missing error handling in probe

2018-12-13 Thread petrcvekcz
From: Petr Cvek Control handlers registration lacked error path with v4l2_ctrl_handler_free() call. Fix it by using goto to alread existing v4l2_ctrl_handler_free() call. Signed-off-by: Petr Cvek --- drivers/media/i2c/ov9640.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

[PATCH v3 5/8] media: i2c: ov9640: change array index or length variables to unsigned

2018-12-13 Thread petrcvekcz
From: Petr Cvek The driver uses variables to store frame resolutions and to indexing various arrays. These should be unsigned. Signed-off-by: Petr Cvek --- drivers/media/i2c/ov9640.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/ov9640.c b

[PATCH v3 1/8] media: soc_camera: ov9640: move ov9640 out of soc_camera

2018-12-13 Thread petrcvekcz
From: Petr Cvek Initial part of ov9640 transition from soc_camera subsystem to a standalone v4l2 subdevice. The soc_camera version seems to be used only in Palm Zire72 and in (the future) HTC Magician. On these two devices the support is broken as pxa_camera driver doesn't use soc_camera anymore.

[PATCH v3 4/8] media: i2c: ov9640: add missing SPDX identifiers

2018-12-13 Thread petrcvekcz
From: Petr Cvek Add missing SPDX identifiers to .c and .h files of the sensor driver. Signed-off-by: Petr Cvek --- drivers/media/i2c/ov9640.c | 5 + drivers/media/i2c/ov9640.h | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov9640.c b/drivers/med

[PATCH v3 6/8] media: i2c: ov9640: add space before return for better clarity

2018-12-13 Thread petrcvekcz
From: Petr Cvek Some returns were adjoined to unrelated code blocks. This patch adds a space inbetween. Signed-off-by: Petr Cvek --- drivers/media/i2c/ov9640.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/ov9640.c b/drivers/media/i2c/ov9640.c index 08f3f8247759..2

[PATCH v3 0/8] media: soc_camera: ov9640: switch driver to v4l2_async

2018-12-13 Thread petrcvekcz
From: Petr Cvek This patch series transfer the ov9640 driver from the soc_camera subsystem into a standalone v4l2 driver. There is no changes except the required v4l2_async calls, GPIO allocation, deletion of now unused variables, a change from mdelay() to msleep() and an addition of SPDX identif

[PATCH v3 7/8] media: i2c: ov9640: make array of supported formats constant

2018-12-13 Thread petrcvekcz
From: Petr Cvek An array which defines sensor's supported formats is not written anywhere, so it can be constant. Signed-off-by: Petr Cvek --- drivers/media/i2c/ov9640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov9640.c b/drivers/media/i2c/ov9640.c

[PATCH v3 3/8] MAINTAINERS: add Petr Cvek as a maintainer for the ov9640 driver

2018-12-13 Thread petrcvekcz
From: Petr Cvek The soc_camera drivers are marked as orphaned. Add Petr Cvek as a new maintainer for ov9640 driver after its switch from the soc_camera. Signed-off-by: Petr Cvek --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a2e686819e

Re: [PATCH v5 2/2] media: usb: pwc: Don't use coherent DMA buffers for ISO transfer

2018-12-13 Thread Christoph Hellwig
On Thu, Dec 13, 2018 at 12:13:29PM +0900, Tomasz Figa wrote: > Putting aside the problem of memory without struct page, one thing to > note here that what is a contiguous DMA range for device X, may not be > mappable contiguously for device Y and it would still need something > like a scatter list

[RFCv5 PATCH 3/4] media: add functions to add properties to objects

2018-12-13 Thread hverkuil-cisco
From: Hans Verkuil Add functions to add properties to entities, pads and other properties. This can be extended to include interfaces and links in the future when needed. Signed-off-by: Hans Verkuil --- drivers/media/media-entity.c | 64 + include/media/media-entity.h | 264 ++

[RFCv5 PATCH 0/4] Add properties support to the media controller

2018-12-13 Thread hverkuil-cisco
From: Hans Verkuil The main changes since RFCv4 are: - Dropped all the indexing code that I added to make it easier to traverse the topology. I still think that's a good idea, but that can be done in a future patch. - Split the second patch into two: the first part adds the core support, t

[RFCv5 PATCH 2/4] media controller: add properties support

2018-12-13 Thread hverkuil-cisco
From: Hans Verkuil Add support for properties. In this initial implementation properties can be added to entities and pads. In addition, properties can be nested. Most of the changes are straightforward, but I had to make some changes to the way entities are initialized, since the struct has to

[RFCv5 PATCH 4/4] vimc: add property test code

2018-12-13 Thread hverkuil-cisco
From: Hans Verkuil Add properties to entities and pads to be able to test the properties API. Signed-off-by: Hans Verkuil --- drivers/media/platform/vimc/vimc-common.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/media/platform/vimc/vimc-common.c b/driv

[RFCv5 PATCH 1/4] uapi/linux/media.h: add property support

2018-12-13 Thread hverkuil-cisco
From: Hans Verkuil Extend the topology struct with a properties array. Add a new media_v2_prop structure to store property information. Signed-off-by: Hans Verkuil --- include/uapi/linux/media.h | 56 ++ 1 file changed, 56 insertions(+) diff --git a/includ

[PATCH] MAINTAINERS: Change s5p-jpeg maintainer information.

2018-12-13 Thread Andrzej Pietrasiewicz
My @samusung.com address is going to cease existing soon, so change it to an address which can actually be used to contact me. Adding Sylwester Nawrocki, who still has access to a wide spectrum of Exynos-based hardware. Signed-off-by: Andrzej Pietrasiewicz --- MAINTAINERS | 3 ++- 1 file change

[PATCH] media: Change Andrzej Pietrasiewicz's e-mail address

2018-12-13 Thread Andrzej Pietrasiewicz
My @samusung.com address is going to cease existing soon, so change it to an address which can actually be used to contact me. Signed-off-by: Andrzej Pietrasiewicz --- drivers/media/common/videobuf2/videobuf2-dma-sg.c | 2 +- drivers/media/platform/s5p-jpeg/jpeg-core.c | 4 ++-- drivers/me

Re: [PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned

2018-12-13 Thread Laurent Pinchart
Hi Sakari, On Thursday, 13 December 2018 15:02:03 EET Sakari Ailus wrote: > On Thu, Dec 13, 2018 at 02:59:50PM +0200, Laurent Pinchart wrote: > > On Thursday, 13 December 2018 12:40:06 EET Sakari Ailus wrote: > > > The size argument of the alloc memop, which allocates buffer memory, is > > > page

Re: [PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing

2018-12-13 Thread Sakari Ailus
On Thu, Dec 13, 2018 at 03:03:47PM +0200, Laurent Pinchart wrote: > On Thursday, 13 December 2018 15:00:23 EET Sakari Ailus wrote: > > Hi Laurent, > > > > On Thu, Dec 13, 2018 at 02:57:46PM +0200, Laurent Pinchart wrote: > > > Hi Sakari, > > > > > > Thank you for the patch. > > > > > > On Thursd

Re: [PATCH 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2018-12-13 Thread Sakari Ailus
On Thu, Dec 13, 2018 at 02:49:44PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday, 13 December 2018 12:40:04 EET Sakari Ailus wrote: > > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > > checking that the aligned value is not smaller

Re: [PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing

2018-12-13 Thread Laurent Pinchart
On Thursday, 13 December 2018 15:00:23 EET Sakari Ailus wrote: > Hi Laurent, > > On Thu, Dec 13, 2018 at 02:57:46PM +0200, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patch. > > > > On Thursday, 13 December 2018 12:40:05 EET Sakari Ailus wrote: > > > buf->size is an unsigned

Re: [PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned

2018-12-13 Thread Sakari Ailus
On Thu, Dec 13, 2018 at 02:59:50PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday, 13 December 2018 12:40:06 EET Sakari Ailus wrote: > > The size argument of the alloc memop, which allocates buffer memory, is > > page aligned. Document it as such, as code

Re: [PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing

2018-12-13 Thread Sakari Ailus
Hi Laurent, On Thu, Dec 13, 2018 at 02:57:46PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday, 13 December 2018 12:40:05 EET Sakari Ailus wrote: > > buf->size is an unsigned long; casting that to int will lead to an > > overflow if buf->size exceeds INT_

Re: [PATCH v5 02/12] gpu: ipu-csi: Swap fields according to input/output field types

2018-12-13 Thread Philipp Zabel
Hi Steve, On Tue, 2018-10-16 at 17:00 -0700, Steve Longerbeam wrote: > The function ipu_csi_init_interface() was inverting the F-bit for > NTSC case, in the CCIR_CODE_1/2 registers. The result being that > for NTSC bottom-top field order, the CSI would swap fields and > capture in top-bottom order

Re: [PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned

2018-12-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Thursday, 13 December 2018 12:40:06 EET Sakari Ailus wrote: > The size argument of the alloc memop, which allocates buffer memory, is > page aligned. Document it as such, as code elsewhere has not taken this > into account. > > Signed-off-by: Sakari Ailus

Re: [PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing

2018-12-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Thursday, 13 December 2018 12:40:05 EET Sakari Ailus wrote: > buf->size is an unsigned long; casting that to int will lead to an > overflow if buf->size exceeds INT_MAX. > > Fix this by changing the type to unsigned long instead. This is possible > as the b

Re: [RFCv4 PATCH 1/3] uapi/linux/media.h: add property support

2018-12-13 Thread Hans Verkuil
On 12/12/18 9:43 AM, Hans Verkuil wrote: > On 12/12/18 9:18 AM, Mauro Carvalho Chehab wrote: >>> /* ioctls */ >>> @@ -368,6 +446,8 @@ struct media_v2_topology { >>> #define MEDIA_IOC_ENUM_ENTITIES_IOWR('|', 0x01, struct >>> media_entity_desc) >>> #define MEDIA_IOC_ENUM_LINKS _IOWR('|'

Re: [PATCH 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2018-12-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Thursday, 13 December 2018 12:40:04 EET Sakari Ailus wrote: > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > checking that the aligned value is not smaller than the unaligned one. > > Note on backporting to stable: the file used to be

strscpy() vs strlcpy() and WARN_ONCE()

2018-12-13 Thread Hans Petter Selasky
commit c0decac19da3906d9b66291e57b7759489e1170f Author: Mauro Carvalho Chehab Date: Mon Sep 10 08:19:14 2018 -0400 media: use strscpy() instead of strlcpy() The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated str

Re: [RFC 1/1] doc-rst: Add Intel IPU3 documentation

2018-12-13 Thread Laurent Pinchart
Hi Sakari, On Thursday, 13 December 2018 13:45:43 EET Sakari Ailus wrote: > From: Rajmohan Mani > > This patch adds the details about the IPU3 Imaging Unit driver (both CIO2 > and IMGU). > > Signed-off-by: Rajmohan Mani > Signed-off-by: Sakari Ailus > --- > Hi Laurent, > > Here's the origina

Re: [PATCHv5 6/8] vb2: add vb2_find_timestamp()

2018-12-13 Thread Hans Verkuil
On 12/12/18 7:28 PM, Jonas Karlman wrote: > Hi Hans, > > Since this function only return DEQUEUED and DONE buffers, > it cannot be used to find a capture buffer that is both used for > frame output and is part of the frame reference list. > E.g. a bottom field referencing a top field that is alrea

Re: [GIT PULL v4 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2018-12-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Dec 2018 14:03:40 +0200 sakari.ai...@iki.fi escreveu: > Hi Mauro, > > Here's the ipu3 staging driver plus the META_OUTPUT buffer type needed to > pass the parameters for the device. If you think this there's still time to > get this to 4.21, then please pull. The non-staging patches ha

Re: [PATCH 1/1] ipu3-cio2: Use MEDIA_ENT_F_VID_IF_BRIDGE as receiver entity function

2018-12-13 Thread Sakari Ailus
Hi Bingbu, On Thu, Dec 13, 2018 at 01:35:08PM +0800, Bingbu Cao wrote: > > > On 12/12/2018 07:49 PM, Sakari Ailus wrote: > > Address the following warnings by setting the entity's function to an > > appropriate value. > > > > [5.043377] ipu3-cio2 :00:14.3: Entity type for entity ipu3-cs

[GIT PULL v4 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2018-12-13 Thread sakari . ailus
Hi Mauro, Here's the ipu3 staging driver plus the META_OUTPUT buffer type needed to pass the parameters for the device. If you think this there's still time to get this to 4.21, then please pull. The non-staging patches have been around for more than half a year and they're relatively simple. Not

[RFC 1/1] doc-rst: Add Intel IPU3 documentation

2018-12-13 Thread Sakari Ailus
From: Rajmohan Mani This patch adds the details about the IPU3 Imaging Unit driver (both CIO2 and IMGU). Signed-off-by: Rajmohan Mani Signed-off-by: Sakari Ailus --- Hi Laurent, Here's the original documentation patch with my changes folded into it. The metadata format patch is needed before

Re: [PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned

2018-12-13 Thread Hans Verkuil
On 12/13/18 11:40 AM, Sakari Ailus wrote: > The size argument of the alloc memop, which allocates buffer memory, is > page aligned. Document it as such, as code elsewhere has not taken this > into account. > > Signed-off-by: Sakari Ailus Reviewed-by: Hans Verkuil Regards, Hans > ---

Re: [PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing

2018-12-13 Thread Hans Verkuil
On 12/13/18 11:40 AM, Sakari Ailus wrote: > buf->size is an unsigned long; casting that to int will lead to an > overflow if buf->size exceeds INT_MAX. > > Fix this by changing the type to unsigned long instead. This is possible > as the buf->size is always aligned to PAGE_SIZE, and therefore the

Re: [PATCH 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2018-12-13 Thread Hans Verkuil
On 12/13/18 11:40 AM, Sakari Ailus wrote: > PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by > checking that the aligned value is not smaller than the unaligned one. > > Note on backporting to stable: the file used to be under > drivers/media/v4l2-core, it was moved to the curren

[GIT PULL v3 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2018-12-13 Thread sakari . ailus
Hi Mauro, Here's the ipu3 staging driver plus the META_OUTPUT buffer type needed to pass the parameters for the device. If you think this there's still time to get this to 4.21, then please pull. The non-staging patches have been around for more than half a year and they're relatively simple. Not

[GIT PULL v2 for 4.21] META_OUTPUT buffer type and the ipu3 staging driver

2018-12-13 Thread sakari . ailus
Hi Mauro, Here's the ipu3 staging driver plus the META_OUTPUT buffer type needed to pass the parameters for the device. If you think this there's still time to get this to 4.21, then please pull. The non-staging patches have been around for more than half a year and they're relatively simple. Not

Re: [PATCH v9 22/22] staging/ipu3-imgu: Add MAINTAINERS entry

2018-12-13 Thread Sakari Ailus
Hi Laurent, On Thu, Dec 13, 2018 at 01:01:55PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday, 13 December 2018 11:51:07 EET Sakari Ailus wrote: > > Add a MAINTAINERS entry for the ImgU driver. > > > > Signed-off-by: Sakari Ailus > > --- > > MAINTAINE

Re: [PATCH v9 22/22] staging/ipu3-imgu: Add MAINTAINERS entry

2018-12-13 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Thursday, 13 December 2018 11:51:07 EET Sakari Ailus wrote: > Add a MAINTAINERS entry for the ImgU driver. > > Signed-off-by: Sakari Ailus > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > in

[PATCH v9.1 21/22] staging/ipu3-imgu: Address documentation comments

2018-12-13 Thread Sakari Ailus
Address comments on the documentation after Yong's original patch. Signed-off-by: Sakari Ailus --- .../media/uapi/v4l/pixfmt-meta-intel-ipu3.rst | 2 +- Documentation/media/v4l-drivers/ipu3.rst | 343 - drivers/staging/media/ipu3/TODO| 11

Re: [PATCH v7 02/16] doc-rst: Add Intel IPU3 documentation

2018-12-13 Thread Sakari Ailus
Hi Laurent, Thanks for the review. On Thu, Dec 13, 2018 at 12:41:36PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday, 13 December 2018 11:38:26 EET Sakari Ailus wrote: > > Hi Laurent, > > > > I'm sending a separate patch to address the comments. > > > > On Fri, Nov 30, 2018 at 12:

Re: [PATCH v7 02/16] doc-rst: Add Intel IPU3 documentation

2018-12-13 Thread Laurent Pinchart
Hi Sakari, On Thursday, 13 December 2018 11:38:26 EET Sakari Ailus wrote: > Hi Laurent, > > I'm sending a separate patch to address the comments. > > On Fri, Nov 30, 2018 at 12:50:36AM +0200, Laurent Pinchart wrote: > > On Tuesday, 30 October 2018 00:22:56 EET Yong Zhi wrote: > >> From: Rajmohan

[PATCH 3/3] videobuf2-core.h: Document the alloc memop size argument as page aligned

2018-12-13 Thread Sakari Ailus
The size argument of the alloc memop, which allocates buffer memory, is page aligned. Document it as such, as code elsewhere has not taken this into account. Signed-off-by: Sakari Ailus --- include/media/videobuf2-core.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/inclu

[PATCH 0/3] Videobuf2 corner case fixes

2018-12-13 Thread Sakari Ailus
Hi folks, Most drivers already have limits to size such that you don't hit these, but if you do, then mayhem will follow. The two first are cc'd to stable. Sakari Ailus (3): videobuf2-core: Prevent size alignment wrapping buffer size to 0 videobuf2-dma-sg: Prevent size from overflowing vide

[PATCH 1/3] videobuf2-core: Prevent size alignment wrapping buffer size to 0

2018-12-13 Thread Sakari Ailus
PAGE_ALIGN() may wrap the buffer size around to 0. Prevent this by checking that the aligned value is not smaller than the unaligned one. Note on backporting to stable: the file used to be under drivers/media/v4l2-core, it was moved to the current location after 4.14. Signed-off-by: Sakari Ailus

[PATCH 2/3] videobuf2-dma-sg: Prevent size from overflowing

2018-12-13 Thread Sakari Ailus
buf->size is an unsigned long; casting that to int will lead to an overflow if buf->size exceeds INT_MAX. Fix this by changing the type to unsigned long instead. This is possible as the buf->size is always aligned to PAGE_SIZE, and therefore the size will never have values lesser than 0. Note on

cron job: media_tree daily build: OK

2018-12-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Dec 13 10:12:56 CET 2018 media-tree git hash:d2b4387f3bdf016e266d23cf657465f557721488 media_build git

[PATCH v9 15/22] media: staging/intel-ipu3: Add Intel IPU3 meta data uAPI

2018-12-13 Thread Sakari Ailus
From: Yong Zhi These meta formats are used on Intel IPU3 ImgU video queues to carry 3A statistics and ISP pipeline parameters. V4L2_META_FMT_IPU3_3A V4L2_META_FMT_IPU3_PARAMS Signed-off-by: Yong Zhi Signed-off-by: Chao C Li Signed-off-by: Rajmohan Mani Signed-off-by: Sakari Ailus --- drive

[PATCH v9 08/22] media: staging/intel-ipu3: css: Add support for firmware management

2018-12-13 Thread Sakari Ailus
From: Yong Zhi Introduce functions to load and install ImgU FW blobs. Signed-off-by: Yong Zhi Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-css-fw.c | 264 +++ drivers/staging/media/ipu3/ipu3-css-fw.h | 188 ++ 2 files changed,

[PATCH v9 17/22] ipu3-imgu: Fix compiler warnings

2018-12-13 Thread Sakari Ailus
Address a few false positive compiler warnings related to uninitialised variables. While at it, use bool where bool is needed and %u to print an unsigned integer. Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v9 20/22] media: v4l: Add Intel IPU3 meta buffer formats

2018-12-13 Thread Sakari Ailus
From: Yong Zhi Add IPU3-specific meta formats for processing parameters and 3A statistics. V4L2_META_FMT_IPU3_PARAMS V4L2_META_FMT_IPU3_STAT_3A Signed-off-by: Yong Zhi Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/meta-formats.rst | 1 + .../media/uapi/v4l/pixfmt-me

[PATCH v9 13/22] media: staging/intel-ipu3: Add v4l2 driver based on media framework

2018-12-13 Thread Sakari Ailus
From: Yong Zhi Implement video driver that utilizes v4l2, vb2 queue support and media controller APIs. The driver exposes single subdevice and six nodes. Signed-off-by: Yong Zhi Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-v4l2.c | 1086 1 f

[PATCH v9 00/22] ImgU driver

2018-12-13 Thread Sakari Ailus
Hi folks, This is effectively Yong's v8 patchset, with a few changes since: - Addressed most of Laurent's comments on the driver documentation. Some have been postponed and added to TODO. - Added a MAINTAINERS entry. - Removed uAPI definitions (formats etc.) added by the patches originally

[PATCH v9 02/22] docs-rst: v4l: Document V4L2_BUF_TYPE_META_OUTPUT interface

2018-12-13 Thread Sakari Ailus
Document the interface for metadata output, including V4L2_BUF_TYPE_META_OUTPUT buffer type and V4L2_CAP_META_OUTPUT capability bits. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Reviewed-by: Tomasz Figa Tested-by: Tian Shu Qiu --- Documentation/media/uapi/v4l/buffer.rst | 3 +

[PATCH v9 11/22] media: staging/intel-ipu3: css: Initialize css hardware

2018-12-13 Thread Sakari Ailus
From: Yong Zhi This patch implements the functions to initialize and configure IPU3 h/w such as clock, irq and power. Signed-off-by: Yong Zhi Signed-off-by: Tomasz Figa Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-css.c | 537 ++ drivers/sta

[PATCH v9 10/22] media: staging/intel-ipu3: css: Compute and program ccs

2018-12-13 Thread Sakari Ailus
From: Yong Zhi A collection of routines that are mainly used to calculate the parameters for accelerator cluster. Signed-off-by: Yong Zhi Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-css-params.c | 2915 ++ drivers/staging/media/ipu3/ipu3-css-params.

[PATCH v9 22/22] staging/ipu3-imgu: Add MAINTAINERS entry

2018-12-13 Thread Sakari Ailus
Add a MAINTAINERS entry for the ImgU driver. Signed-off-by: Sakari Ailus --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3e9f1710ed13e..9ed5cff35e075 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7587,6 +7587,14 @@ S: Maintained

[PATCH v9 18/22] ipu3-imgu: Fix firmware binary location

2018-12-13 Thread Sakari Ailus
The firmware binary is located under "intel" directory in the linux-firmware repository. Reflect this in the driver. Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-css-fw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu3/ipu3-css-fw

[PATCH v9 03/22] media: staging/intel-ipu3: abi: Add register definitions and enum

2018-12-13 Thread Sakari Ailus
From: Yong Zhi Add macros and enums used for IPU3 firmware interface. Signed-off-by: Yong Zhi Signed-off-by: Rajmohan Mani Reviewed-by: Laurent Pinchart Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-abi.h | 661 ++ 1 file changed, 661 insert

[PATCH v9 12/22] media: staging/intel-ipu3: Add css pipeline programming

2018-12-13 Thread Sakari Ailus
From: Yong Zhi This provides helper library to be used by v4l2 level to program imaging pipelines and control the streaming. Signed-off-by: Yong Zhi Signed-off-by: Sakari Ailus --- drivers/staging/media/ipu3/ipu3-css.c | 1740 + 1 file changed, 1740 insertions(

  1   2   >