This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Oct 6 05:00:13 CEST 2018
media-tree git hash:557c97b5133669297be561e6091da9ab6e488e65
media_build gi
Going above 3184 changes the frame-rate of the sensor. Without this
patch there is no way to change the exposure without affecting the
frame-rate.
With the proper documentation we should be able the change the
frame-rate at wish, but until that happens we just cap what the sensor
can do.
Signed-o
Add a V4L2 sub-device driver for the Sony IMX214 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera.
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Jacopo Mondi
---
Changelog from
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v10:
Sakari Ailus:
-Re-introduce clock-frequency property
.../bindings/media/i2c/sony,imx214.txt| 53 +++
1
On Sat, Oct 06, 2018 at 12:18:28AM +0200, Ricardo Ribalda Delgado wrote:
> Hi Sakari
> On Sat, Oct 6, 2018 at 12:02 AM Sakari Ailus wrote:
> >
> > Hi Ricardo,
> >
> > On Fri, Oct 05, 2018 at 11:57:50PM +0200, Ricardo Ribalda Delgado wrote:
> > > Document bindings for imx214 camera sensor
> > >
> >
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v10:
Sakari Ailus:
-remove clock name
.../bindings/media/i2c/sony,imx214.txt| 51 +++
1 file changed, 51 in
Hi Sakari
On Sat, Oct 6, 2018 at 12:02 AM Sakari Ailus wrote:
>
> Hi Ricardo,
>
> On Fri, Oct 05, 2018 at 11:57:50PM +0200, Ricardo Ribalda Delgado wrote:
> > Document bindings for imx214 camera sensor
> >
> > Cc: devicet...@vger.kernel.org
> > Reviewed-by: Laurent Pinchart
> > Signed-off-by: Ric
Hi Ricardo,
On Fri, Oct 05, 2018 at 11:57:50PM +0200, Ricardo Ribalda Delgado wrote:
> Document bindings for imx214 camera sensor
>
> Cc: devicet...@vger.kernel.org
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Ricardo Ribalda Delgado
> ---
> Changelog from v8:
>
> Rob Herring:
> -rename fi
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v8:
Rob Herring:
-rename file
-Move address to reg
-rename name on example
-Patch author
Sakari Ailus:
-should->shall
.../bindings
Hi Ricardo,
On Fri, Oct 05, 2018 at 02:49:37PM +0200, Ricardo Ribalda Delgado wrote:
> From: Ricardo Ribalda
>
> Document bindings for imx214 camera sensor
>
> Cc: devicet...@vger.kernel.org
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Ricardo Ribalda Delgado
> ---
> .../devicetree/bindi
If probe fails, the kernel will print the error code. There's no need to
driver to do that.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/dw9714.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c
index 3dc2100470a1..2
Hi Raj, others,
One fix and one cleanup for the dw9807 and dw9714 drivers. The dw9807
driver had the same issue than what you fixed in dw9714.
Sakari Ailus (2):
dw9714: Remove useless error message
dw9807: Fix probe error handling
drivers/media/i2c/dw9714.c | 2 +-
drivers/media/i2c/dw9
v4l2_async_unregister_subdev() may not be called without
v4l2_async_register_subdev() being called first. Fix this.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/dw9807-vcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/dw9807-vcm.c b/drivers/media/
On Tue, 2 Oct 2018 13:13:56 +0200, Ricardo Ribalda Delgado wrote:
> Document new enable-gpio field. It can be used to disable the part
> without turning down its regulator.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Ricardo Ribalda Delgado
> Acked-by: Pavel Machek
> ---
> Documentatio
On Fri, Oct 05, 2018 at 02:49:37PM +0200, Ricardo Ribalda Delgado wrote:
> From: Ricardo Ribalda
>
> Document bindings for imx214 camera sensor
>
> Cc: devicet...@vger.kernel.org
> Reviewed-by: Laurent Pinchart
> Signed-off-by: Ricardo Ribalda Delgado
checkpatch.pl complains that the author a
On 10/04/2018 08:12 AM, Hans Verkuil wrote:
On 10/03/18 22:43, Eddie James wrote:
On 09/28/2018 06:30 AM, Hans Verkuil wrote:
On 09/25/2018 09:27 PM, Eddie James wrote:
The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
can capture and compress video data from digital or
Document the bindings.
Signed-off-by: Eddie James
Reviewed-by: Rob Herring
---
.../devicetree/bindings/media/aspeed-video.txt | 26 ++
1 file changed, 26 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/aspeed-video.txt
diff --git a/Documentatio
The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
can capture and compress video data from digital or analog sources. With
the Aspeed chip acting a service processor, the Video Engine can capture
the host processor graphics output.
Add a V4L2 driver to capture video data and co
The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs
can capture and compress video data from digital or analog sources. With
the Aspeed chip acting as a service processor, the Video Engine can
capture the host processor graphics output.
This series adds a V4L2 driver for the VE,
Em Thu, 04 Oct 2018 23:06:02 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote:
> > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu:
> > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote:
On Fri, 2018-10-05 at 13:49 -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 05 Oct 2018 12:37:43 -0300
> Ezequiel Garcia escreveu:
>
> > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> > > Em Thu, 04 Oct 2018 20:39:31 -0300
> > > Ezequiel Garcia escreveu:
> > >
> > > > On Mon,
From: Ettore Chimenti
Introduce support for Consumer-IR into seco-cec driver, as it shares the
same interrupt for receiving messages.
The device decodes RC5 signals only, defaults to hauppauge mapping.
It will spawn an input interface using the RC framework (like CEC
device).
Signed-off-by: Etto
From: Ettore Chimenti
This patch adds support to the CEC device implemented with a STM32
microcontroller in X86 SECO Boards, including UDOO X86.
The communication is achieved via Braswell integrated SMBus
(i2c-i801). The driver use direct access to the PCI addresses, due to
the limitations of th
This series of patches aims to add CEC functionalities to SECO
devices, in particular UDOO X86.
The communication is achieved via Braswell SMBus (i2c-i801) to the
onboard STM32 microcontroller that handles the CEC signals. The driver
use direct access to the PCI addresses, due to the limitations o
Hi,
Le jeudi 04 octobre 2018 à 14:10 -0400, Nicolas Dufresne a écrit :
> Le jeudi 04 octobre 2018 à 14:47 +0200, Paul Kocialkowski a écrit :
> > > +Instance of struct v4l2_ctrl_h264_scaling_matrix, containing the
> > > scaling
> > > +matrix to use when decoding the next queued frame. Appl
Em Fri, 05 Oct 2018 12:37:43 -0300
Ezequiel Garcia escreveu:
> On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 04 Oct 2018 20:39:31 -0300
> > Ezequiel Garcia escreveu:
> >
> > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > > > On Fri, 2018-09-28
Fixed the case where v4l2_async_unregister_subdev()
is called unnecessarily in the error handling path
in probe function.
Signed-off-by: Rajmohan Mani
---
drivers/media/i2c/dw9714.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i
On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 04 Oct 2018 20:39:31 -0300
> Ezequiel Garcia escreveu:
>
> > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote:
> > > > On 09/17/2018 07:30 PM, Ezequiel
On Mon, Sep 24, 2018 at 01:34:46AM +0900, Akinobu Mita wrote:
> This patchset adds support for changing frame interval and runtime PM for
> video-i2c driver. This also adds an helper macro to v4l2 common
> internal API that is used to to find a suitable frame interval.
>
> There are a couple of u
Em Fri, 5 Oct 2018 16:34:28 +0200
Oliver Freyermuth escreveu:
> Dear Mauro,
>
> thanks! Just to clarify, the issue I described in
> https://bugzilla.kernel.org/show_bug.cgi?id=199323
> was on an Intel x86_64 system, with an onboard USB Controller handled by the
> standard xhci driver,
> so thi
Hi Vikash,
please, increment the version of the patch next time. This one must be v2.
On 10/03/2018 02:30 PM, Vikash Garodia wrote:
> Exisiting code returns the max of the decoded size and buffer size.
s/Exisiting/Existing
> It turns out that buffer size is always greater due to hardware
> alig
The three following Hauppauge USB DVB devices have IR receivers, but
lacked the support in mceusb to enable it:
- WinTV-HVR-935C
- WinTV-HVR-955Q
- WinTV-HVR-975
Tested HVR-955Q and HVR-975 plus RC5 remote and irw, works as intended.
Signed-off-by: Brad Love
---
drivers/media/rc/mceusb.c | 9 ++
Hi Mita-san,
On Fri, Oct 05, 2018 at 11:59:20PM +0900, Akinobu Mita wrote:
> 2018年10月5日(金) 18:36 Sakari Ailus :
> >
> > Hi Hans,
> >
> > On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> > > On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > > > The video_i2c_data is allocated by kzallo
2018年10月5日(金) 18:36 Sakari Ailus :
>
> Hi Hans,
>
> On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> > On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > > The video_i2c_data is allocated by kzalloc and released by the video
> > > device's release callback. The release callback is call
Dear Mauro,
thanks! Just to clarify, the issue I described in
https://bugzilla.kernel.org/show_bug.cgi?id=199323
was on an Intel x86_64 system, with an onboard USB Controller handled by the
standard xhci driver,
so this does not affect RPi alone.
Cheers and thanks,
Oliver
Am 05.10.18
As pointed at:
https://bugzilla.kernel.org/show_bug.cgi?id=199323
This patch causes a bad effect on RPi. I suspect that the root
cause is at the USB RPi driver, with uses high priority
interrupts instead of normal ones. Anyway, as this patch
is mostly a cleanup, better to revert it.
This
As pointed at:
https://bugzilla.kernel.org/show_bug.cgi?id=199323
This patch causes a bad effect on RPi. I suspect that the root
cause is at the USB RPi driver, with uses high priority
interrupts instead of normal ones. Anyway, as this patch
is mostly a cleanup, better to revert it.
This
Function alignments are off by 1 space, as reported by
checkpatch.pl --strict.
Fix those.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/imx355.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/imx355.c b/drive
Tomi,
Can you review this patch and the next? They should go to 4.20.
This patch in particular is a nasty one, hard to reproduce.
This patch should also be Cc-ed to stable for 4.15 and up.
Tracking down randomly disappearing CEC transmits was no fun :-(
Regards,
Hans
On 10/04/18 11:08
Function alignments are off by 1 space, as reported by
checkpatch.pl --strict.
Fix those.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/imx319.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/imx319.c b/drive
This pull request fixes various CEC bugs. The following patches are also
CCed to stable for 4.18:
cec: add new tx/rx status bits to detect aborts/timeouts
adv7604: when the EDID is cleared, unconfigure CEC as well
adv7842: when the EDID is cleared, unconfigure CEC as well
c
From: Hans Verkuil
If the HDMI cable is disconnected or the CEC adapter is manually
unconfigured, then all pending transmits and wait-for-replies are
aborted. Signal this with new status bits (CEC_RX/TX_STATUS_ABORTED).
If due to (usually) a driver bug a transmit never ends (i.e. the
transmit_do
From: Hans Verkuil
The calculation of the Signal Free Time in the framework was not
correct. If a message was received, then the next transmit should be
considered a New Initiator and use a shorter SFT value.
This was not done with the result that if both sides where continually
sending messages
From: Hans Verkuil
When there is no EDID the CEC adapter should be unconfigured as
well. So call cec_phys_addr_invalidate() when this happens.
Signed-off-by: Hans Verkuil
---
drivers/media/i2c/adv7842.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ad
From: Hans Verkuil
Clarify that calling cec_transmit_done can start a new transmit and
that you should put the hardware in a state that allows for a new
transmit before calling this function.
Signed-off-by: Hans Verkuil
---
Documentation/media/kapi/cec-core.rst | 4
1 file changed, 4 inse
From: Hans Verkuil
When there is no EDID the CEC adapter should be unconfigured as
well. So call cec_phys_addr_invalidate() when this happens.
Signed-off-by: Hans Verkuil
---
drivers/media/i2c/adv7604.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ad
From: Hans Verkuil
This patch series replaces patches 1-3 of:
https://www.spinics.net/lists/linux-media/msg141216.html
Patches 4 & 5 of that series remain as-is and are omap4 bug fixes.
This patch series can be applied to the media subsystem since it
has no drm changes.
Changes since the prev
From: Hans Verkuil
If a receive is in progress or starts before the transmit has
a chance, then lower the Signal Free Time of the upcoming transmit
to no more than CEC_SIGNAL_FREE_TIME_NEW_INITIATOR.
This is per the specification requirements.
Signed-off-by: Hans Verkuil
---
drivers/media/cec
Hi Mauro,
Here are fixes for the Omnivision sensor drivers. Please pull.
The following changes since commit f492fb4f5b41e8e62051e710369320e9ffa7a1ea:
media: MAINTAINERS: Fix entry for the renamed dw9807 driver (2018-10-05
08:40:00 -0400)
are available in the git repository at:
ssh://linu
Hi,
On 05-10-18 13:55, Mauro Carvalho Chehab wrote:
Em Mon, 1 Oct 2018 18:19:21 +0100
Dave Stevenson escreveu:
Hi All,
On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote:
Hi Hans,
Thanks for looking into. I remember MJPEG vs. JPEG being a source
of confusion for me a few years ago, so cl
Hi Mauro,
Here are drivers for Sony imx319 and imx355 sensors and an unlocked version
of v4l2_ctrl_grab() which is used by the driver.
Since v1, I've rebased this on the current master --- with the fwnode
patches.
Please pull.
The diff is here and effectively the same for both drivers:
diff --
Going above 3184 changes the frame-rate of the sensor. Without this
patch there is no way to change the exposure without affecting the
frame-rate.
With the proper documentation we should be able the change the
frame-rate at wish, but until that happens we just cap what the sensor
can do.
Signed-o
From: Ricardo Ribalda
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
.../devicetree/bindings/media/i2c/imx214.txt | 53 +++
1 file changed, 53 insertions(+)
create mode 100644
Add a V4L2 sub-device driver for the Sony IMX214 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera.
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Jacopo Mondi
---
Changelog from
Em Fri, 05 Oct 2018 08:53:14 -0300
Ezequiel Garcia escreveu:
> On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 4 Oct 2018 21:12:24 -0300
> > Ezequiel Garcia escreveu:
> >
> > > From: Shunqian Zheng
> > >
> > > Add V4L2_PIX_FMT_JPEG_RAW format that does not conta
Em Thu, 04 Oct 2018 20:39:31 -0300
Ezequiel Garcia escreveu:
> On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote:
> > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote:
> > > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote:
> > > > This series adds support for JPEG encoding via the V
Am Freitag, 5. Oktober 2018, 02:12:22 CEST schrieb Ezequiel Garcia:
> Add the Video Processing Unit node for RK3288 SoC.
>
> Fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia
applied for 4.20 (may possibly move to 4.21 though)
Am Freitag, 5. Oktober 2018, 02:12:23 CEST schrieb Ezequiel Garcia:
> Add the Video Processing Unit node for the RK3399 SoC.
>
> Also, fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia
applied for 4.20 (may possibly move to 4.
Em Mon, 1 Oct 2018 18:19:21 +0100
Dave Stevenson escreveu:
> Hi All,
>
> On Mon, 1 Oct 2018 at 17:32, Ezequiel Garcia wrote:
> >
> > Hi Hans,
> >
> > Thanks for looking into. I remember MJPEG vs. JPEG being a source
> > of confusion for me a few years ago, so clarification is greatly
> > welcom
On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 4 Oct 2018 21:12:24 -0300
> Ezequiel Garcia escreveu:
>
> > From: Shunqian Zheng
> >
> > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain
> > JPEG header in the output frame.
> >
> > Signed-off-by: Shunqian Zheng
Em Mon, 01 Oct 2018 08:42:56 -0400
Nicolas Dufresne escreveu:
> Hello Hans,
>
> Le lundi 01 octobre 2018 à 10:43 +0200, Hans Verkuil a écrit :
> > It turns out that we have both JPEG and Motion-JPEG pixel formats defined.
> >
> > Furthermore, some drivers support one, some the other and some bo
Hi Ricardo,
Thanks for the update.
On Thu, Oct 04, 2018 at 04:08:33PM +0200, Ricardo Ribalda Delgado wrote:
> Add a V4L2 sub-device driver for the Sony IMX214 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for data.
>
> Tested on a DB820c alike board wi
There is no need to have the 'resource_size_t res_len' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davi
There is no need to have the 'resource_size_t res_len' variable static
since new value always be assigned before use it.
Signed-off-by: YueHaibing
---
drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davi
Em Thu, 4 Oct 2018 21:12:24 -0300
Ezequiel Garcia escreveu:
> From: Shunqian Zheng
>
> Add V4L2_PIX_FMT_JPEG_RAW format that does not contain
> JPEG header in the output frame.
>
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Ezequiel Garcia
> ---
> Documentation/media/uapi/v4l/pixfmt-co
Hi Hans,
I like this series, nice work!
On 2018-10-05 09:49:00 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This patch series converts the last remaining drivers that use g/s_crop and
> cropcap to g/s_selection.
>
> The first two patches do some minor code cleanup.
>
> The third patch
Hi Steve,
On Thu, 2018-10-04 at 11:54 -0700, Steve Longerbeam wrote:
> Also add an example pipeline for unconverted capture with interweave
> on SabreAuto.
>
> Signed-off-by: Steve Longerbeam
> ---
> Changes since v3:
> - none.
> Changes since v2:
> - expand on idmac interweave behavior in CSI s
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:11 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now vidioc_cropcap is only used to return the pixelaspect, so
> rename it accordingly.
>
> Signed-off-by: Hans Verkuil
For the v4l2 and rcar-vin changes:
Reviewed-by: Niklas Söderlund
On 10/05/18 12:47, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your work.
>
> On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Now that all drivers have dropped vidioc_g/s_crop we can remove
>> support for them in the V4L2 core.
>>
>> Signed-off-by: Hans Verkui
Hi Hans,
Thanks for your work.
On 2018-10-05 09:49:10 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Now that all drivers have dropped vidioc_g/s_crop we can remove
> support for them in the V4L2 core.
>
> Signed-off-by: Hans Verkuil
If the quirk patch hurt my head this makes me smile!
Hi Niklas,
On Thu, Oct 04, 2018 at 10:41:38PM +0200, Niklas Söderlund wrote:
> From: Niklas Söderlund
>
> The driver fixed the TXA CSI-2 transmitter in 4-lane mode while it could
> operate using 1-, 2- and 4-lanes. Update the driver to support all modes
> the hardware does.
>
> The driver make us
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:03 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Some old Samsung drivers use the legacy crop API incorrectly:
> the crop and compose targets are swapped. Normally VIDIOC_G_CROP
> will return the CROP rectangle of a CAPTURE stream and th
Hi Steve,
On Thu, 2018-10-04 at 11:54 -0700, Steve Longerbeam wrote:
> Allow sequential->interlaced interweaving but with top/bottom
> lines swapped to the output buffer.
>
> This can be accomplished by adding one line length to IDMAC output
> channel address, with a negative line length for the
Hi Mauro,
On Fri, Oct 05, 2018 at 06:29:36AM -0400, Mauro Carvalho Chehab wrote:
> There are several coding style issues at those definitions,
> and the previous patchset added even more.
>
> Address the trivial ones by first calling:
>
> ./scripts/checkpatch.pl --strict --fix-inline
> in
Em Fri, 5 Oct 2018 13:08:25 +0300
Sakari Ailus escreveu:
> > > This is still over 80 here. I think we could think of abbreviating what's
> > > in the function name, not limiting to the endpoint. I think I'd prefer to
> > > leave that for 4.21 as there's not much time anymore.
> >
> > Yes, I kn
Em Fri, 5 Oct 2018 13:06:04 +0300
Sakari Ailus escreveu:
> > > > - unsigned int i;
> > >
> > > I'd like to keep this here.
> >
> > Why? IMHO, it makes harder to read (yet, if you insist, I'm ok with
> > both ways).
>
> Generally loop, temporary, return etc. variables are nice to
Hi Hans,
Thanks for your patch.
On 2018-10-05 09:49:02 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This ensures that they won't be used in kernel code.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Niklas Söderlund
> ---
> include/uapi/linux/v4l2-common.h | 28 +++--
There are several coding style issues at those definitions,
and the previous patchset added even more.
Address the trivial ones by first calling:
./scripts/checkpatch.pl --strict --fix-inline
include/media/v4l2-async.h include/media/v4l2-fwnode.h
include/media/v4l2-mediabus.h drivers/me
The v4l2_fwnode_reference_parse_int_props() has a big name, causing
it to cause coding style warnings. Also, it depends on a const
struct embedded indide a function.
Rearrange the logic in order to move the struct declaration out
of such function and use it inside this function.
That cleans up so
There is already a typedef for the parse endpoint function.
However, instead of using it, it is redefined at the C file
(and on one of the function headers).
Replace them by the function typedef, in order to cleanup
several related coding style warnings.
Signed-off-by: Mauro Carvalho Chehab
---
The fwnode patchset added a several new warnings, as identified by
checkpatch.pl --strict.
Those are at the core stuff, and makes harder to review patches there.
In order to fully address checkpatch.pl, we still need to:
- Add SPDX headers;
- Rename functions.
Let's do those on
Hi Mauro,
On Fri, Oct 05, 2018 at 07:12:02AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 10:55:58 +0300
> Sakari Ailus escreveu:
...
> > > @@ -436,8 +437,7 @@ static int __v4l2_fwnode_endpoint_parse(struct
> > > fwnode_handle *fwnode,
> > > if (mbus_type != V4L2_MBUS_UNKNO
Hi Marek,
On Fri, Oct 05, 2018 at 10:01:41AM +0200, Marek Szyprowski wrote:
> Commits 03fbdb2fc2b8 ("media: move videobuf2 to drivers/media/common")
> and 7952be9b6ece ("media: drivers/media/common/videobuf2: rename from
> videobuf") moved videobuf2 framework source code finally to
> drivers/media
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
> If caller passes un-initialized field type V4L2_FIELD_ANY to CSI
> sink pad, the reset CSI crop window would not be correct, because
> the crop window depends on a valid input field type. To fix move
> the reset of crop and compose window
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
> Skip writing U/V components to odd rows for YVU420 in addition to
> YUV420 and NV12.
>
> Signed-off-by: Steve Longerbeam
> Reviewed-by: Philipp Zabel
> ---
> drivers/staging/media/imx/imx-media-csi.c | 1 +
> 1 file changed, 1 inserti
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
> If IDMAC interweaving is enabled in a write channel, the channel must
> write the odd chroma rows for 4:2:0 formats. Skipping writing the odd
> chroma rows produces corrupted captured 4:2:0 images when interweave
> is enabled.
>
> Report
Hi Hans,
Thanks for your work.
On 2018-10-05 09:49:01 +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Drop the deprecated _ACTIVE part.
>
> Signed-off-by: Hans Verkuil
Reviewed-by: Niklas Söderlund
> ---
> drivers/media/v4l2-core/v4l2-ioctl.c | 8
> 1 file changed, 4 insertio
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
> If the incoming sink field type is alternate, the reset crop height
> and crop height bounds must be set to twice the incoming height,
> because in alternate field mode, upstream will report only the
> lines for a single field, and the CS
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
> IDMAC interlaced scan, a.k.a. interweave, should be enabled in the
> IDMAC output channels only if the IDMAC output pad field type is
> 'seq-bt' or 'seq-tb', and field type at the capture interface is
> 'interlaced*'.
>
> V4L2_FIELD_HAS_
Em Fri, 5 Oct 2018 10:55:58 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Oct 04, 2018 at 06:13:46PM -0400, Mauro Carvalho Chehab wrote:
> > There are several coding style issues at those definitions,
> > and the previous patchset added even more.
> >
> > Address the trivial ones by firs
On Fri, Oct 05, 2018 at 06:52:20AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 11:01:18 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > Feel free to ignore the comments on the first patch regarding the functions
> > below. There are other issues there though.
> >
> > On Thu,
On Fri, Oct 05, 2018 at 06:54:49AM -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 5 Oct 2018 11:03:10 +0300
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> > > The v4l2_fwnode_reference_parse_int_props() has a big name, cau
Hi Jacopo,
On Friday, 5 October 2018 11:49:45 EEST jacopo mondi wrote:
> On Fri, Oct 05, 2018 at 01:00:47AM +0300, Laurent Pinchart wrote:
> > On Friday, 5 October 2018 00:42:17 EEST Laurent Pinchart wrote:
> >> On Thursday, 4 October 2018 23:41:34 EEST Niklas Söderlund wrote:
> >>> From: Niklas S
Em Fri, 5 Oct 2018 11:03:10 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Oct 04, 2018 at 06:13:48PM -0400, Mauro Carvalho Chehab wrote:
> > The v4l2_fwnode_reference_parse_int_props() has a big name, causing
> > it to cause coding style warnings. Also, it depends on a const
> > struct em
Em Fri, 5 Oct 2018 11:01:18 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> Feel free to ignore the comments on the first patch regarding the functions
> below. There are other issues there though.
>
> On Thu, Oct 04, 2018 at 06:13:47PM -0400, Mauro Carvalho Chehab wrote:
> > There is already a ty
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
> To support interlaced scan with planar formats, cpmem SLUV must
> be programmed with the correct chroma line stride. For full and
> partial planar 4:2:2 (YUV422P, NV16), chroma line stride must
> be doubled. For full and partial planar 4:
Hi Steve,
On Thu, 2018-10-04 at 11:53 -0700, Steve Longerbeam wrote:
[...]
> int ipu_csi_init_interface(struct ipu_csi *csi,
> struct v4l2_mbus_config *mbus_cfg,
> -struct v4l2_mbus_framefmt *mbus_fmt)
> +struct v4l2_mbus_fr
Hi Hans,
On Mon, Oct 01, 2018 at 11:40:00AM +0200, Hans Verkuil wrote:
> On 09/23/2018 06:34 PM, Akinobu Mita wrote:
> > The video_i2c_data is allocated by kzalloc and released by the video
> > device's release callback. The release callback is called when
> > video_unregister_device() is called,
On Fri, Oct 05, 2018 at 09:37:11AM +0200, Hans Verkuil wrote:
> On 10/05/2018 12:21 AM, Sean Young wrote:
> > An RC device is does not need to be called 'RC for'. Simply the name
> > will suffice.
> >
> > Signed-off-by: Sean Young
>
> Reviewed-by: Hans Verkuil
>
> OK if I take this patch? I ha
On 10/03/18 09:08, Keiichi Watanabe wrote:
> I think 480p is a common frame size and it's worth supporting in vivid.
> But, my patch might be ad-hoc. Actually, I'm not sure which values are
> suitable for the intervals.
I can apply this ad-hoc patch as-is.
Or do you want to postpone this and work
1 - 100 of 123 matches
Mail list logo
