RE: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-16 Thread Chen, Ping-chung
Hi Sakari, Some of suggestions below has been added in to [PATCH v2] or [PATCH v3]. We will fix others in PATCH v4 soon. Thanks, PC -Original Message- From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] Sent: Monday, July 16, 2018 11:59 PM To: Chen, Ping-chung Cc: linux-media@vger

cron job: media_tree daily build: OK

2018-07-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jul 17 05:00:10 CEST 2018 media-tree git hash:39fbb88165b2bbbc77ea7acab5f10632a31526e6 media_build gi

images

2018-07-16 Thread Simon Dike
We can process 400+ images per day. If you need any image editing, please let us know. Photos cut out; Photos clipping path; Photos masking; Photo shadow creation; Photos retouching; Beauty Model retouching on skin, face, body; Glamour retouching; Products retouching. We can give you testing for

editing of your photos

2018-07-16 Thread Simon Dike
We can process 400+ images per day. If you need any image editing, please let us know. Photos cut out; Photos clipping path; Photos masking; Photo shadow creation; Photos retouching; Beauty Model retouching on skin, face, body; Glamour retouching; Products retouching. We can give you testing for

Re: [PATCH v2 0/2] media: i2c: ov5640: Re-work MIPI startup sequence

2018-07-16 Thread Steve Longerbeam
On 07/16/2018 01:29 AM, jacopo mondi wrote: Hi Steve, thanks for keep testing it On Sat, Jul 14, 2018 at 01:02:32PM -0700, Steve Longerbeam wrote: On 07/14/2018 12:41 PM, Steve Longerbeam wrote: Hi Jacopo, On 07/14/2018 11:57 AM, Steve Longerbeam wrote: Hi Jacopo, Pardon the late r

Re: [PATCH] media: coda: add SPS fixup code for frame sizes that are not multiples of 16

2018-07-16 Thread Philipp Zabel
On Mon, 2018-07-02 at 10:53 +0200, Hans Verkuil wrote: > On 28/06/18 18:47, Philipp Zabel wrote: > > The CODA firmware does not set the VUI frame cropping fields to properly > > describe coded h.264 streams with frame sizes that are not a multiple of > > the macroblock size. > > This adds RBSP pars

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-16 Thread sakari.ai...@linux.intel.com
On Tue, Jul 10, 2018 at 07:37:54AM +, Yeh, Andy wrote: > Hi PC, > > Thanks for the patch. > > Cc in Grant, and Intel Jim/Jason > > > -Original Message- > > From: Chen, Ping-chung > > Sent: Tuesday, July 10, 2018 3:16 PM > > To: linux-media@vger.kernel.org > > Cc: sakari.ai...@linux.i

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

2018-07-16 Thread Sakari Ailus
Hi Ping-chung, Thanks for the patch. Please see my comments below. On Tue, Jul 10, 2018 at 03:15:36PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI

[PATCH 1/1] v4l: i2c: Replace "sensor-level" by "sensor"

2018-07-16 Thread Sakari Ailus
A lot of sensor drivers are labelled as "sensor-level" drivers. That's odd and somewhat confusing as the term isn't used elsewhere: these are just sensor drivers. Call them such. Signed-off-by: Sakari Ailus --- drivers/media/i2c/Kconfig | 62 +++ 1 fil

editing

2018-07-16 Thread Simon Dike
We can process 400+ images per day. If you need any image editing, please let us know. Photos cut out; Photos clipping path; Photos masking; Photo shadow creation; Photos retouching; Beauty Model retouching on skin, face, body; Glamour retouching; Products retouching. We can give you testing for

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-16 Thread Philipp Zabel
Hi Steve, On Thu, 2018-07-05 at 15:09 -0700, Steve Longerbeam wrote: [...] > > +static int mem2mem_try_fmt(struct file *file, void *priv, > > + struct v4l2_format *f) > > +{ [...] > > + /* > > +* Horizontally/vertically chroma subsampled formats must have even > > +*

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-16 Thread Philipp Zabel
Hi Pavel, On Tue, 2018-07-10 at 14:07 +0200, Pavel Machek wrote: [...] > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * i.MX IPUv3 mem2mem Scaler/CSC driver > > + * > > + * Copyright (C) 2011 Pengutronix, Sascha Hauer > > + * Copyright (C) 2018 Pengutronix, Philipp Zabel > > + * > > + * Th

Re: [PATCH 00/16] i.MX media mem2mem scaler

2018-07-16 Thread Philipp Zabel
Hi Steve, On Thu, 2018-07-05 at 14:55 -0700, Steve Longerbeam wrote: > Hi Philipp, > > Thanks for this great patchset! Finally we have improved seams > with tiled conversions, and relaxed width alignment requirements. > > Unfortunately this patchset isn't working correctly yet. It breaks tiled >

Re: [PATCH] videobuf2-core: check for q->error in vb2_core_qbuf()

2018-07-16 Thread Sakari Ailus
Hi Hans, On Thu, Jul 05, 2018 at 10:25:19AM +0200, Hans Verkuil wrote: > The vb2_core_qbuf() function didn't check if q->error was set. It is checked > in > __buf_prepare(), but that function isn't called if the buffer was already > prepared before with VIDIOC_PREPARE_BUF. > > So check it at the

Re: [PATCH v2 0/2] media: i2c: ov5640: Re-work MIPI startup sequence

2018-07-16 Thread jacopo mondi
Hi Steve, thanks for keep testing it On Sat, Jul 14, 2018 at 01:02:32PM -0700, Steve Longerbeam wrote: > > > On 07/14/2018 12:41 PM, Steve Longerbeam wrote: > >Hi Jacopo, > > > > > >On 07/14/2018 11:57 AM, Steve Longerbeam wrote: > >>Hi Jacopo, > >> > >>Pardon the late reply, see below. > >> >