Re: [PATCH] media: dvb: get rid of VIDEO_SET_SPU_PALETTE

2018-05-28 Thread Christoph Hellwig
On Mon, May 28, 2018 at 11:32:41AM -0300, Mauro Carvalho Chehab wrote: > No upstream drivers use it. It doesn't make any sense to have > a compat32 code for something that nobody uses upstream. > > Reported-by: Alexander Viro > Signed-off-by: Mauro Carvalho Chehab Looks good, Reviewed-by: Chri

Re: [PATCH v2] media: staging: tegra-vde: Reset memory client

2018-05-28 Thread Hans Verkuil
Hi Dmitry, On 05/26/2018 04:27 PM, Dmitry Osipenko wrote: > DMA requests must be blocked before resetting VDE HW, otherwise it is > possible to get a memory corruption or a machine hang. Use the reset > control provided by the Memory Controller to block DMA before resetting > the VDE HW. > > Sign

Re: [PATCH v2] media: pxa_camera: avoid duplicate s_power calls

2018-05-28 Thread Hans Verkuil
Hi Akinobu, On 05/27/2018 05:30 PM, Akinobu Mita wrote: > The open() operation for the pxa_camera driver always calls s_power() > operation to put its subdevice sensor in normal operation mode, and the > release() operation always call s_power() operation to put the subdevice > in power saving mod

cron job: media_tree daily build: ERRORS

2018-05-28 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue May 29 05:00:15 CEST 2018 media-tree git hash:a00031c159748f322f771f3c1d5ed944cba4bd30 media_build gi

[RESEND PATCH v2] media: dvb-frontends: add Socionext SC1501A ISDB-S/T demodulator driver

2018-05-28 Thread Katsuhiro Suzuki
This patch adds a frontend driver for the Socionext SC1501A series and Socionext MN88443x ISDB-S/T demodulators. Signed-off-by: Katsuhiro Suzuki --- Changes since v1: - Fix sparse warning about type of constant - Use div_s64() instead of divide operator --- drivers/media/dvb-frontends/Kcon

[RESEND PATCH] media: helene: fix xtal frequency setting at power on

2018-05-28 Thread Katsuhiro Suzuki
This patch fixes crystal frequency setting when power on this device. Signed-off-by: Katsuhiro Suzuki Acked-by: Abylay Ospan --- Changes from before: - Add Abylay's Ack --- drivers/media/dvb-frontends/helene.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/

[RESEND PATCH] media: helene: fix tuning frequency of satellite

2018-05-28 Thread Katsuhiro Suzuki
This patch fixes tuning frequency of satellite to kHz. That as same as terrestrial one. Signed-off-by: Katsuhiro Suzuki --- drivers/media/dvb-frontends/helene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/helene.c b/drivers/media/dvb-frontends

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-28 Thread Dmitry Osipenko
On 29.05.2018 02:48, Dmitry Osipenko wrote: > inversion=true" if mask has form of 0x11000111, though this could be not For clarity: I meant s/0x11000111/0xFF000FFF/.

[PATCH v2] media: rcar-vin: enable support for r8a77965

2018-05-28 Thread Niklas Söderlund
Add the SoC specific information for Renesas r8a77965. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart --- * Changes since v1 - Fixed typo in variable name, s/_rcar_info_r8a77965_routes/rcar_info_r8a77965_routes/. - Collected Laurents tag. --- drivers/media/platform/rcar-vin/r

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-28 Thread Dmitry Osipenko
On 28.05.2018 16:15, Ville Syrjälä wrote: > On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: >> Color keying is the action of replacing pixels matching a given color >> (or range of colors) with transparent pixels in an overlay when >> performing blitting. Depending on the hardware

[PATCH v2] rcar-vin: sync which hardware buffer to start capture from

2018-05-28 Thread Niklas Söderlund
When starting the VIN capture procedure we are not guaranteed that the first buffer written to is VnMB1 to which we assigned the first buffer queued. This is problematic for two reasons. Buffers might not be dequeued in the same order they where queued for capture. Future features planed for the VI

[PATCH v2] dt-bindings: media: rcar_vin: fix style for ports and endpoints

2018-05-28 Thread Niklas Söderlund
The style for referring to ports and endpoint are wrong. Refer to them using lowercase and a unit address, port@x and endpoint@x. Signed-off-by: Niklas Söderlund Reported-by: Geert Uytterhoeven Reviewed-by: Rob Herring --- * Changes since v1. - Fixed spelling reported by Sergei, s/then/than/.

[ragnatech:media-tree] BUILD SUCCESS a00031c159748f322f771f3c1d5ed944cba4bd30

2018-05-28 Thread kbuild test robot
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: a00031c159748f322f771f3c1d5ed944cba4bd30 media: ddbridge: conditionally enable fast TS for stv0910-equipped bridges elapsed time: 31m configs tested: 107 The following configs have been built successfully. More configs may be t

Re: [PATCH v2] media: pxa_camera: avoid duplicate s_power calls

2018-05-28 Thread Sakari Ailus
On Mon, May 28, 2018 at 12:30:11AM +0900, Akinobu Mita wrote: > The open() operation for the pxa_camera driver always calls s_power() > operation to put its subdevice sensor in normal operation mode, and the > release() operation always call s_power() operation to put the subdevice > in power savin

Re: [PATCH] media: imx258: get rid of an unused var

2018-05-28 Thread Sakari Ailus
On Mon, May 28, 2018 at 01:57:11PM -0400, Mauro Carvalho Chehab wrote: > drivers/media/i2c/imx258.c: In function 'imx258_init_controls': > drivers/media/i2c/imx258.c:1117:6: warning: variable 'exposure_max' set but > not used [-Wunused-but-set-variable] > s64 exposure_max; > ^~~~ >

[PATCH] media: imx258: get rid of an unused var

2018-05-28 Thread Mauro Carvalho Chehab
drivers/media/i2c/imx258.c: In function 'imx258_init_controls': drivers/media/i2c/imx258.c:1117:6: warning: variable 'exposure_max' set but not used [-Wunused-but-set-variable] s64 exposure_max; ^~~~ Signed-off-by: Mauro Carvalho Chehab --- drivers/media/i2c/imx258.c | 2 -- 1 f

[PATCH 0/5] Remove sh_mobile_ceu_camera from arch/sh

2018-05-28 Thread Jacopo Mondi
Hello, this series removes dependencies on the soc_camera based sh_mobile_ceu_camera driver from 3 board files in arch/sh and from one sensor driver used by one of those boards. Hans, this means there are no more user of the soc_camera framework that I know of in Linux, and I guess we can now

[PATCH 3/5] arch: sh: kfr2r09: Use new renesas-ceu camera driver

2018-05-28 Thread Jacopo Mondi
Use the new renesas-ceu camera driver in kfr2r09 board file instead of the soc_camera based sh_mobile_ceu_camera driver. Get rid of soc_camera specific components, and move clk and gpio handling away from board file, registering the clock source and the enable gpios for driver consumption. Memory

[PATCH 4/5] arch: sh: ms7724se: Use new renesas-ceu camera driver

2018-05-28 Thread Jacopo Mondi
Use the new renesas-ceu camera driver is ms7724se board file instead of the soc_camera based sh_mobile_ceu_camera driver. Get rid of soc_camera specific components, and register CEU0 and CEU1 with no active video subdevices. Memory for the CEU video buffers is now reserved with membocks APIs and

[PATCH 5/5] arch: sh: ap325rxa: Use new renesas-ceu camera driver

2018-05-28 Thread Jacopo Mondi
Use the new renesas-ceu camera driver in ap325rxa board file instead of the soc_camera based sh_mobile_ceu_camera driver. Get rid of soc_camera specific components, and register CEU0 with a single video sensor (ov7725). Memory for the CEU video buffers is now reserved with membocks APIs and need

Re: [PATCH 4/6] media: imx-csi: Enable interlaced scan for field type alternate

2018-05-28 Thread Steve Longerbeam
On 05/28/2018 12:59 AM, Ian Arkver wrote: On 28/05/18 08:00, Philipp Zabel wrote: On Fri, 2018-05-25 at 16:53 -0700, Steve Longerbeam wrote: Interlaced scan, a.k.a. interweave, should be enabled at the CSI IDMAC output pad if the input field type is 'alternate' (in addition to field types 'se

[PATCH 2/5] media: i2c: rj54n1: Remove soc_camera dependencies

2018-05-28 Thread Jacopo Mondi
Remove soc_camera framework dependencies from rj54n1 sensor driver. - Handle clock - Handle GPIOs (named 'powerup' and 'enable') - Register the async subdevice - Remove g/s_mbus_config as they're deprecated. - Adjust build system - List the driver as maintained for 'Odd Fixes' as I don't have HW to

[PATCH 1/5] media: i2c: Copy rj54n1cb0c soc_camera sensor driver

2018-05-28 Thread Jacopo Mondi
Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi --- drivers/media/i2

[PATCH] media: marvel-ccic: mmp: select VIDEOBUF2_VMALLOC/DMA_CONTIG

2018-05-28 Thread Arnd Bergmann
Testing randconfig builds after the return of the mmp ccic driver shows a link error in some configurations: drivers/media/platform/marvell-ccic/mcam-core.o: In function `mccic_register': mcam-core.c:(.text+0x2e48): undefined reference to `vb2_dma_contig_memops' A closer look at the mcam-core.c f

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Sat, May 26, 2018 at 08:28:18AM -0300, Mauro Carvalho Chehab wrote: > Em Sat, 26 May 2018 03:24:00 +0300 > Laurent Pinchart escreveu: > > > Hi Mauro, > > > > On Saturday, 26 May 2018 02:39:16 EEST Laurent Pinchart wrote: > > > On Saturday, 26 May 2018 02:10:27 EEST Mauro Carvalho Chehab wrote

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Mauro Carvalho Chehab
Em Mon, 28 May 2018 11:31:01 +0300 Laurent Pinchart escreveu: > Hi Mauro and Dan, > > Dan, there's a question for you below. > > On Monday, 28 May 2018 11:28:41 EEST Laurent Pinchart wrote: > > On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: > > > Em Sat, 26 May 2018 03:24

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Mon, May 28, 2018 at 11:28:41AM +0300, Laurent Pinchart wrote: > and I still get the same warning. I had to write the following (which is > obviously not correct) to silence the warning. > > if (pipe->num_inputs > 2) > brx = &vsp1->bru->entity; > else if (pipe->

[PATCH 1/1] imx258: Check the rotation property has a value of 180

2018-05-28 Thread Sakari Ailus
The driver only supports streaming images flipped horizontally and vertically. In order to ensure that all current users will be fine if or when support for upright streaming is added, require the presence of the "rotation" control now. Signed-off-by: Sakari Ailus Tested-by: "Lai, Jim" --- driv

[PATCH] media: vsp1: Document vsp1_dl_body refcnt

2018-05-28 Thread Kieran Bingham
In commit 2d9445db0ee9 ("media: vsp1: Use reference counting for bodies"), a new field was introduced to the vsp1_dl_body structure to account for usage tracking of the body. Document the newly added field in the kerneldoc. Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Kieran Bingham
Hi Mauro, Laurent, On 26/05/18 00:39, Laurent Pinchart wrote: > Hi Mauro, > > (CC'ing Kieran) > > On Saturday, 26 May 2018 02:10:27 EEST Mauro Carvalho Chehab wrote: >> Em Sun, 20 May 2018 15:10:50 +0300 Laurent Pinchart escreveu: >>> Hi Mauro, >>> >>> The following changes since commit >>> 8ed8

[PATCH] media: dvb: get rid of VIDEO_SET_SPU_PALETTE

2018-05-28 Thread Mauro Carvalho Chehab
No upstream drivers use it. It doesn't make any sense to have a compat32 code for something that nobody uses upstream. Reported-by: Alexander Viro Signed-off-by: Mauro Carvalho Chehab --- .../media/uapi/dvb/video-set-spu-palette.rst | 82 --- .../media/uapi/dvb/video_function_c

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-28 Thread Niklas Söderlund
Hi Mauro, On 2018-05-28 10:43:51 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 17 May 2018 16:07:08 -0300 > Mauro Carvalho Chehab escreveu: > > > Hi all, > > > > The goal of this e-mail is to schedule a meeting in order to discuss > > improvements at the media subsystem in order to support comp

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Mon, May 28, 2018 at 11:31:01AM +0300, Laurent Pinchart wrote: > And that being said, I just tried > > if (pipe->num_inputs > 2) > brx = &vsp1->bru->entity; > else if (pipe->brx && !drm_pipe->force_brx_release) > brx = pipe->brx; > else if

Re: [PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

2018-05-28 Thread Niklas Söderlund
Hi Jacopo, On 2018-05-25 13:50:08 +0200, Jacopo Mondi wrote: > Hi Niklas, >I might have another question before sending v5. > > On Fri, May 25, 2018 at 12:29:44AM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your work. > > > > I really like what you did with this patch in

Re: [ANN] Meeting to discuss improvements to support MC-based cameras on generic apps

2018-05-28 Thread Mauro Carvalho Chehab
Em Thu, 17 May 2018 16:07:08 -0300 Mauro Carvalho Chehab escreveu: > Hi all, > > The goal of this e-mail is to schedule a meeting in order to discuss > improvements at the media subsystem in order to support complex camera > hardware by usual apps. > > The main focus here is to allow supporting

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Laurent Pinchart
Hi Mauro, On Monday, 28 May 2018 13:03:05 EEST Mauro Carvalho Chehab wrote: > Em Mon, 28 May 2018 11:28:41 +0300 Laurent Pinchart escreveu: > > On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: > >> Em Sat, 26 May 2018 03:24:00 +0300 Laurent Pinchart escreveu: > > [snip] > > > >

Re: [RFC PATCH v2 1/2] drm: Add generic colorkey properties

2018-05-28 Thread Ville Syrjälä
On Sat, May 26, 2018 at 06:56:22PM +0300, Dmitry Osipenko wrote: > Color keying is the action of replacing pixels matching a given color > (or range of colors) with transparent pixels in an overlay when > performing blitting. Depending on the hardware capabilities, the > matching pixel can either b

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Laurent Pinchart
Hi Dan, Thank you for your quick reply. On Monday, 28 May 2018 13:20:49 EEST Dan Carpenter wrote: > On Mon, May 28, 2018 at 11:28:41AM +0300, Laurent Pinchart wrote: > > and I still get the same warning. I had to write the following (which is > > obviously not correct) to silence the warning. > >

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Mon, May 28, 2018 at 07:03:05AM -0300, Mauro Carvalho Chehab wrote: > I can't see how brx can be NULL. At the sequence of ifs: > > if (pipe->num_inputs > 2) > brx = &vsp1->bru->entity; > else if (pipe->brx && !drm_pipe->force_brx_release) > brx = pi

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Laurent Pinchart
Hi Dan, On Monday, 28 May 2018 13:36:08 EEST Dan Carpenter wrote: > On Mon, May 28, 2018 at 11:31:01AM +0300, Laurent Pinchart wrote: > > And that being said, I just tried > > > > if (pipe->num_inputs > 2) > > brx = &vsp1->bru->entity; > > else if (pipe->brx && !dr

Re: [PATCH] media: v4l2-ctrl: Add control for VP9 profile

2018-05-28 Thread Tomasz Figa
Hi Hans, On Fri, May 25, 2018 at 6:09 PM Hans Verkuil wrote: > On 17/05/18 11:53, Keiichi Watanabe wrote: > > Add a new control V4L2_CID_MPEG_VIDEO_VP9_PROFILE for selecting desired > > profile for VP9 encoder and querying for supported profiles by VP9 encoder > > or decoder. > > > > An existing

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Mon, May 28, 2018 at 01:58:41PM +0300, Laurent Pinchart wrote: > It would indeed be useful to implement, but I share your concern that this > would be pretty difficult. > > However, there's still something that puzzles me. Let's add a bit more > context. > > if (pipe->num_inputs > 2)

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Mon, May 28, 2018 at 01:54:18PM +0300, Laurent Pinchart wrote: > Hi Dan, > > Thank you for your quick reply. > > On Monday, 28 May 2018 13:20:49 EEST Dan Carpenter wrote: > > On Mon, May 28, 2018 at 11:28:41AM +0300, Laurent Pinchart wrote: > > > and I still get the same warning. I had to writ

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Dan Carpenter
On Mon, May 28, 2018 at 07:17:54AM -0300, Mauro Carvalho Chehab wrote: > This (obviously wrong patch) shut up the warning: > > --- a/drivers/media/platform/vsp1/vsp1_drm.c > +++ b/drivers/media/platform/vsp1/vsp1_drm.c > @@ -248,6 +248,9 @@ static int vsp1_du_pipeline_setup_brx(struct vsp1_device

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Mauro Carvalho Chehab
Em Mon, 28 May 2018 11:28:41 +0300 Laurent Pinchart escreveu: > Hi Mauro, > > On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: > > Em Sat, 26 May 2018 03:24:00 +0300 Laurent Pinchart escreveu: > > [snip] > > > > I've reproduced the issue and created a minimal test case. >

Re: [PATCH v2 11/29] venus: venc,vdec: adds clocks needed for venus 4xx

2018-05-28 Thread Stanimir Varbanov
Hi Tomasz, On 05/24/2018 09:11 AM, Tomasz Figa wrote: > Hi Stanimir, > > On Tue, May 15, 2018 at 5:10 PM Stanimir Varbanov < > stanimir.varba...@linaro.org> wrote: > >> This extends the clocks number to support suspend and resume >> on Venus version 4xx. > >> Signed-off-by: Stanimir Varbanov >

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Laurent Pinchart
Hi Mauro and Dan, Dan, there's a question for you below. On Monday, 28 May 2018 11:28:41 EEST Laurent Pinchart wrote: > On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: > > Em Sat, 26 May 2018 03:24:00 +0300 Laurent Pinchart escreveu: > [snip] > > > > I've reproduced the issue

Re: [GIT PULL FOR v4.18] R-Car VSP1 TLB optimisation

2018-05-28 Thread Laurent Pinchart
Hi Mauro, On Saturday, 26 May 2018 14:28:18 EEST Mauro Carvalho Chehab wrote: > Em Sat, 26 May 2018 03:24:00 +0300 Laurent Pinchart escreveu: [snip] > > I've reproduced the issue and created a minimal test case. > > > > 1. struct vsp1_pipeline; > > 2. > > 3. struct vsp1_entity { > > 4.

Re: [PATCH 4/6] media: imx-csi: Enable interlaced scan for field type alternate

2018-05-28 Thread Ian Arkver
On 28/05/18 08:00, Philipp Zabel wrote: On Fri, 2018-05-25 at 16:53 -0700, Steve Longerbeam wrote: Interlaced scan, a.k.a. interweave, should be enabled at the CSI IDMAC output pad if the input field type is 'alternate' (in addition to field types 'seq-tb' and 'seq-bt'). Which brings up whether

Re: [PATCH 4/6] media: imx-csi: Enable interlaced scan for field type alternate

2018-05-28 Thread Philipp Zabel
On Fri, 2018-05-25 at 16:53 -0700, Steve Longerbeam wrote: > Interlaced scan, a.k.a. interweave, should be enabled at the CSI IDMAC > output pad if the input field type is 'alternate' (in addition to field > types 'seq-tb' and 'seq-bt'). > > Which brings up whether V4L2_FIELD_HAS_BOTH() macro shou