RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Zheng, Jian Xu
Hi Tomasz, > -Original Message- > From: linux-media-ow...@vger.kernel.org [mailto:linux-media- > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > Sent: Wednesday, May 9, 2018 6:05 PM > To: Chen, JasonX Z > Cc: Yeh, Andy ; Linux Media Mailing List me...@vger.kernel.org>; Sakari Ailus ;

RE: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-09 Thread Yasunari.Takiguchi
Dear Mauro > -Original Message- > > There was a recent discussion about the use/abuse of GFP_DMA flag when > allocating memories at LSF/MM 2018 (see Luis notes enclosed). > > The idea seems to be to remove it, using CMA instead. Before doing that, > better to check if what we have on med

cron job: media_tree daily build: ERRORS

2018-05-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu May 10 05:00:13 CEST 2018 media-tree git hash:e280edff3308602922d623e15bae473152869eba media_build gi

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Yunliang Ding
Hi Andy, A small catch which should be fixed along with your incremental patch. On 2018-05-02 at 23:46:08 +0800, Andy Yeh wrote: > From: Jason Chen > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for

Proposal

2018-05-09 Thread Zeliha Omer Faruk
-- Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: [PATCH v3 03/13] media: v4l2: async: Add v4l2_async_notifier_add_subdev

2018-05-09 Thread Steve Longerbeam
On 05/08/2018 03:12 AM, Sakari Ailus wrote: On Fri, Apr 20, 2018 at 10:12:33AM -0700, Steve Longerbeam wrote: Hi Sakari, On 04/20/2018 05:24 AM, Sakari Ailus wrote: Hi Steve, Thanks for the patchset. On Tue, Mar 20, 2018 at 05:37:19PM -0700, Steve Longerbeam wrote: v4l2_async_notifier_ad

[PATCH v4 13/14] media: staging/imx: Switch to v4l2_async_notifier_add_*_subdev

2018-05-09 Thread Steve Longerbeam
Switch to v4l2_async_notifier_add_*_subdev() when adding async subdevs to the imx-media root notifier. This removes the need to check for an already added asd, since v4l2_async_notifier_add_*_subdev() does this check. Also no need to allocate a subdevs array when registering the root notifier, or k

[PATCH v4 14/14] media: staging/imx: TODO: Remove one assumption about OF graph parsing

2018-05-09 Thread Steve Longerbeam
The move to subdev notifiers fixes one assumption of OF graph parsing. If a subdevice has non-video related ports, the subdev driver knows not to follow those ports when adding remote devices to its subdev notifier. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/TODO | 29 +++-

[PATCH v4 05/14] media: v4l2-fwnode: Switch to v4l2_async_notifier_add_subdev

2018-05-09 Thread Steve Longerbeam
The fwnode endpoint and reference parsing functions in v4l2-fwnode.c are modified to make use of v4l2_async_notifier_add_subdev(). As a result the notifier->subdevs array is no longer allocated or re-allocated, and by extension the max_subdevs value is also no longer needed. Since the notifier->su

[PATCH v4 11/14] media: staging/imx: Loop through all registered subdevs for media links

2018-05-09 Thread Steve Longerbeam
The root imx-media notifier no longer sees all bound subdevices because some of them will be bound to subdev notifiers. So imx_media_create_links() now needs to loop through all subdevices registered with the v4l2-device, not just the ones in the root notifier's done list. This should be safe becau

[PATCH v4 00/14] media: imx: Switch to subdev notifiers

2018-05-09 Thread Steve Longerbeam
This patchset converts the imx-media driver and its dependent subdevs to use subdev notifiers. There are a couple shortcomings in v4l2-core that prevented subdev notifiers from working correctly in imx-media: 1. v4l2_async_notifier_fwnode_parse_endpoint() treats a fwnode endpoint that is not c

[PATCH v4 01/14] media: v4l2-fwnode: ignore endpoints that have no remote port parent

2018-05-09 Thread Steve Longerbeam
Documentation/devicetree/bindings/media/video-interfaces.txt states that the 'remote-endpoint' property is optional. So v4l2_async_notifier_fwnode_parse_endpoint() should not return error if the endpoint has no remote port parent. Just ignore the endpoint, skip adding an asd to the notifier and re

[PATCH v4 06/14] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers

2018-05-09 Thread Steve Longerbeam
Adds v4l2_async_register_fwnode_subdev(), which is a convenience function for parsing a sub-device's fwnode port endpoints for connected remote sub-devices, registering a sub-device notifier, and then registering the sub-device itself. Signed-off-by: Steve Longerbeam --- Changes since v3: - remov

[PATCH v4 03/14] media: v4l2: async: Add v4l2_async_notifier_add_subdev

2018-05-09 Thread Steve Longerbeam
v4l2_async_notifier_add_subdev() adds an asd to the notifier. It checks that no other equivalent asd's have already been added to this notifier's asd list, or to other registered notifier's waiting or done lists, and increments num_subdevs. v4l2_async_notifier_add_subdev() does not make use of the

[PATCH v4 08/14] media: imx: csi: Register a subdev notifier

2018-05-09 Thread Steve Longerbeam
Parse neighbor remote devices on the CSI port, and add them to a subdev notifier, by calling v4l2_async_notifier_parse_fwnode_endpoints_by_port() using the CSI's port id. And register the subdev notifier for the CSI. Signed-off-by: Steve Longerbeam --- Changes since v3: - v4l2_async_register_fwno

[PATCH v4 12/14] media: staging/imx: Rename root notifier

2018-05-09 Thread Steve Longerbeam
Rename the imx-media root async notifier from "subdev_notifier" to simply "notifier", so as not to confuse it with true subdev notifiers. No functional changes. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/imx-media-dev.c | 14 +++--- drivers/staging/media/imx/imx-media.

[PATCH v4 02/14] media: v4l2: async: Allow searching for asd of any type

2018-05-09 Thread Steve Longerbeam
Generalize v4l2_async_notifier_fwnode_has_async_subdev() to allow searching for any type of async subdev, not just fwnodes. Rename to v4l2_async_notifier_has_async_subdev() and pass it an asd pointer. Signed-off-by: Steve Longerbeam --- Changes since v3: - removed TODO to support asd compare with

[PATCH v4 10/14] media: staging/imx: of: Remove recursive graph walk

2018-05-09 Thread Steve Longerbeam
After moving to subdev notifiers, it's no longer necessary to recursively walk the OF graph, because the subdev notifiers will discover and add devices from the graph for us. So the recursive of_parse_subdev() function is gone, replaced with of_add_csi() which adds only the CSI port fwnodes to the

[PATCH v4 07/14] media: platform: video-mux: Register a subdev notifier

2018-05-09 Thread Steve Longerbeam
Parse neighbor remote devices on the video muxes input ports, add them to a subdev notifier, and register the subdev notifier for the video mux, by calling v4l2_async_register_fwnode_subdev(). Signed-off-by: Steve Longerbeam --- Changes since v3: - pass num_pads - 1 (num_input_pads) to video_mux_

[PATCH v4 09/14] media: imx: mipi csi-2: Register a subdev notifier

2018-05-09 Thread Steve Longerbeam
Parse neighbor remote devices on the MIPI CSI-2 input port, add them to a subdev notifier, and register the subdev notifier for the MIPI CSI-2 receiver, by calling v4l2_async_register_fwnode_subdev(). csi2_parse_endpoints() is modified to be the parse_endpoint callback. Signed-off-by: Steve Longe

[PATCH v4 04/14] media: v4l2: async: Add convenience functions to allocate and add asd's

2018-05-09 Thread Steve Longerbeam
Add these convenience functions, which allocate an asd of match type fwnode, i2c, or device-name, of size asd_struct_size, and then adds them to the notifier asd_list. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-async.c | 76 include/medi

Re: [PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

2018-05-09 Thread Gustavo Padovan
Hi Ezequiel, On Wed, 2018-05-09 at 17:14 -0300, Ezequiel Garcia wrote: > Change how dma_fence_add_callback() behaves, when the fence > has error-signaled by the time it is being add. After this commit, > dma_fence_add_callback() returns the fence error, if it > has error-signaled before dma_fence_

Re: [PATCH v2 7/7] media: rc: mceusb: allow the timeout to be configurable

2018-05-09 Thread Sean Young
Hi Hias, On Mon, May 07, 2018 at 05:54:55PM +0200, Matthias Reichl wrote: > Hi Sean! > > [ I trimmed the Cc list, as this is mceusb specific ] > > On Sat, Apr 21, 2018 at 07:41:21PM +0200, Matthias Reichl wrote: > > On Sat, Apr 21, 2018 at 03:18:52PM +0200, Matthias Reichl wrote: > > > Another b

[PATCH 1/1] cadence: csi2rx: Fix csi2rx_start error handling

2018-05-09 Thread Sakari Ailus
The clocks enabled by csi2rx_start function are intended to be disabled in an error path but there are two issues: 1) the loop condition is always true and 2) the first clock disabled is the the one enabling of which failed. Fix these two bugs by changing the loop condition as well as only disab

[PATCH] dma-fence: Make dma_fence_add_callback() fail if signaled with error

2018-05-09 Thread Ezequiel Garcia
Change how dma_fence_add_callback() behaves, when the fence has error-signaled by the time it is being add. After this commit, dma_fence_add_callback() returns the fence error, if it has error-signaled before dma_fence_add_callback() is called. Signed-off-by: Ezequiel Garcia --- drivers/dma-buf/

Re: [PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

2018-05-09 Thread Daniel Scheller
Hi Colin, Am Tue, 8 May 2018 11:39:56 +0100 schrieb Colin Ian King : > On 08/05/18 11:38, Daniel Scheller wrote: > > Hi Colin, > > > > Am Tue, 8 May 2018 00:08:42 +0100 > > schrieb Colin King : > > > >> From: Colin Ian King > >> > >> In function stop there is a check to see if state->demod

[PATCH 4/4] [media] ddbridge: conditionally enable fast TS for stv0910-equipped bridges

2018-05-09 Thread Daniel Scheller
From: Daniel Scheller CineS2 V7(A) and Octopus CI S2 Pro/Advanced cards support faster TS speeds on the card's contained stv0910 demodulator when their FPGA was updated with a recent (>= 1.7, version number applies to all mentioned cards) vendor firmware. Enable this faster TS speed on card port

[PATCH 1/4] [media] ddbridge/mci: protect against out-of-bounds array access in stop()

2018-05-09 Thread Daniel Scheller
From: Daniel Scheller In stop(), an (unlikely) out-of-bounds write error can occur when setting the demod_in_use element indexed by state->demod to zero, as state->demod isn't checked for being in the range of the array size of demod_in_use, and state->demod maybe carrying the magic 0xff (demod u

[PATCH 3/4] [media] dvb-frontends/stv0910: make TS speed configurable

2018-05-09 Thread Daniel Scheller
From: Daniel Scheller Add a tsspeed config option to struct stv0910_cfg which can be used by users of the driver to set the (parallel) TS speed (higher speeds enable support for higher bitrate transponders). If tsspeed isn't set in the config, it'll default to a sane value. This commit also upda

[PATCH 2/4] [media] ddbridge/mci: add identifiers to function definition arguments

2018-05-09 Thread Daniel Scheller
From: Daniel Scheller Fixes two checkpatch warnings WARNING: function definition argument 'xxx' should also have an identifier name in the ddb_mci_attach() prototype definition. checkpatch keeps complaining on the "int (**fn_set_input)" as it seems to have issues with the ptr-to-ptr, though

[PATCH 0/4] ddbridge-0.9.33 fixes and improvements

2018-05-09 Thread Daniel Scheller
From: Daniel Scheller Four post-ddbridge-0.9.33 patches fixing and improving a few things: Patch 1 adds protection into the new ddbridge-mci code against an out-of-bounds array write access as reported by CoverityScan and brought to attention by Colin Ian King. Patch 2 adds missing function arg

[PATCH] [media] saa7146: fix error return from master_xfer

2018-05-09 Thread Peter Rosin
Returning -1 (-EPERM) is not appropriate here, go with -EIO. Signed-off-by: Peter Rosin --- drivers/media/common/saa7146/saa7146_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/common/saa7146/saa7146_i2c.c b/drivers/media/common/saa7146/saa7146_i2c.c

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 17:33 +0100, Brian Starkey wrote: > On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: > > On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > > > Hi Ezequiel, > > > > > > On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > > > > From: Gusta

Re: [GIT PULL for 4.18] Cadence CSI-2 TX and RX drivers

2018-05-09 Thread Mauro Carvalho Chehab
Em Mon, 7 May 2018 15:35:43 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Here are the drivers for Cadence CSI-2 TX and RX hardware blocks. > > Please pull. > > > The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef: > > media: include/video/omapfb_dss.h: use IS_ENABL

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 17:33 +0100, Brian Starkey wrote: > On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: > > On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > > > Hi Ezequiel, > > > > > > On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > > > > From: Gusta

Re: [RESEND PATCH v9 2/2] media: dw9807: Add dw9807 vcm driver

2018-05-09 Thread Mauro Carvalho Chehab
Em Wed, 2 May 2018 23:53:48 +0800 Andy Yeh escreveu: > From: Alan Chiang > > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > > This driver creates a V4L2 subdevice and > provides control to set the desired focus. > > Signed-off-by: Andy Yeh > Revie

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Mauro Carvalho Chehab
Em Wed, 2 May 2018 23:46:08 +0800 Andy Yeh escreveu: > From: Jason Chen > > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > Signed-off-by: Alan Chiang > Reviewe

[PATCH] media: rcar-vin: Drop unnecessary register properties from example vin port

2018-05-09 Thread Simon Horman
The example vin port node does not have an address and thus does not need address-cells or address size-properties. Signed-off-by: Simon Horman --- Documentation/devicetree/bindings/media/rcar_vin.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/r

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
On Wed, May 09, 2018 at 01:03:15PM -0300, Ezequiel Garcia wrote: On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, void *pb) >b->timestamp = ns_to_timeval(vb->timestamp); >b->timecode = vbuf->timeco

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Brian Starkey
On Wed, May 09, 2018 at 12:52:26PM -0300, Ezequiel Garcia wrote: On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: Hi Ezequiel, On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > From: Gustavo Padovan > > Turn the reserved2 field into fence_fd that we will use to send > a

[PATCH] em28xx: Demote several dev_err to dev_info

2018-05-09 Thread Brad Love
These two statements are not errors, reduce to appropriate level. Signed-off-by: Brad Love --- drivers/media/usb/em28xx/em28xx-cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c index

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:36 +0100, Brian Starkey wrote: [..] > > @@ -203,9 +215,14 @@ static void __fill_v4l2_buffer(struct vb2_buffer *vb, > > void *pb) > > b->timestamp = ns_to_timeval(vb->timestamp); > > b->timecode = vbuf->timecode; > > b->sequence = vbuf->sequence; > > - b->fen

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Ezequiel Garcia
On Wed, 2018-05-09 at 11:33 +0100, Brian Starkey wrote: > Hi Ezequiel, > > On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Turn the reserved2 field into fence_fd that we will use to send > > an in-fence to the kernel or return an out-fence from

[PATCH v6 2/2] media: ov2680: Add Omnivision OV2680 sensor driver

2018-05-09 Thread Rui Miguel Silva
This patch adds V4L2 sub-device driver for OV2680 image sensor. The OV2680 is a 1/5" CMOS color sensor from Omnivision. Supports output format: 10-bit Raw RGB. The OV2680 has a single lane MIPI interface. The driver exposes following V4L2 controls: - auto/manual exposure, - exposure, - auto/manual

[PATCH v6 0/2] media: Introduce Omnivision OV2680 driver

2018-05-09 Thread Rui Miguel Silva
Add driver and bindings for the OV2680 2 megapixel CMOS 1/5" sensor, which has a single MIPI lane interface and output format of 10-bit Raw RGB. Features supported are described in PATCH 2/2. v5->v6: Fabio Estevam: - add power supplies (code and bindings) - fix csi gpio polarity (code and

[PATCH v6 1/2] media: ov2680: dt: Add bindings for OV2680

2018-05-09 Thread Rui Miguel Silva
Add device tree binding documentation for the OV2680 camera sensor. CC: devicet...@vger.kernel.org Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/i2c/ov2680.txt | 46 +++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/me

Re: [RFC PATCH] media: i2c: add SCCB helpers

2018-05-09 Thread Akinobu Mita
2018-05-05 23:51 GMT+09:00 Mauro Carvalho Chehab : > Em Fri, 27 Apr 2018 01:13:32 +0900 > Akinobu Mita escreveu: > >> (This patch is in prototype stage) >> >> This adds SCCB helper functions (sccb_read_byte and sccb_write_byte) that >> are intended to be used by some of Omnivision sensor drivers.

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-05-09 Thread Stanimir Varbanov
Hi, On 05/09/2018 05:14 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-05-09 16:45, Stanimir Varbanov wrote: >> Hi Vikash, >> >> On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: >>> Hello Stanimir, >>> >>> On 2018-04-24 18:14, Stanimir Varbanov wrote: This adds suspend (power col

[RFC PATCH] i2c: add I2C_M_FORCE_STOP

2018-05-09 Thread Akinobu Mita
This adds a new I2C_M_FORCE_STOP flag that forces a stop condition after the message in a combined transaction. This flag is intended to be used by the devices that don't support repeated starts like SCCB (Serial Camera Control Bus) devices. Here is an example usage for ov772x driver that needs t

Re: [RFC PATCH] media: i2c: add SCCB helpers

2018-05-09 Thread Sakari Ailus
On Wed, May 09, 2018 at 12:57:19PM +0200, Sebastian Reichel wrote: > Hi, > > On Fri, Apr 27, 2018 at 01:13:32AM +0900, Akinobu Mita wrote: > > diff --git a/drivers/media/i2c/sccb.c b/drivers/media/i2c/sccb.c > > new file mode 100644 > > index 000..80a3fb7 > > --- /dev/null > > +++ b/drivers/me

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-05-09 Thread Vikash Garodia
Hi Stanimir, On 2018-05-09 16:45, Stanimir Varbanov wrote: Hi Vikash, On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: Hello Stanimir, On 2018-04-24 18:14, Stanimir Varbanov wrote: This adds suspend (power collapse) function with slightly different order of calls comparing with Venus 3

[GIT PULL v2 for 4.18] Omap3isp cleanups

2018-05-09 Thread Sakari Ailus
Hi Mauro, Here are some fixes for the omap3isp driver. Since v1, I've added a fix that was intended to be included in v1 (in Arnd's patch): https://patchwork.linuxtv.org/patch/49369/> Please pull. The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef: media: include/v

Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

2018-05-09 Thread Jan Kara
On Fri 04-05-18 08:33:55, Mauro Carvalho Chehab wrote: > Em Fri, 04 May 2018 13:58:39 +0300 > Jani Nikula escreveu: > > > On Fri, 04 May 2018, Mauro Carvalho Chehab > > wrote: > > > From now on, I'll start using my @kernel.org as my development e-mail. > > > > > > As such, let's remove the entr

[PATCH 3/3] media: v4l: fix broken video4linux docs locations

2018-05-09 Thread Mauro Carvalho Chehab
There are several places pointing to old documentation files: Documentation/video4linux/API.html Documentation/video4linux/bttv/ Documentation/video4linux/cx2341x/fw-encoder-api.txt Documentation/video4linux/m5602.txt Documentation/video4linux/v4l2-framework.txt Documentation/video4lin

[PATCH 2/3] media: dvb: point to the location of the old README.dvb-usb file

2018-05-09 Thread Mauro Carvalho Chehab
This file got renamed, but the references still point to the old place. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/dib3000.h| 2 +- drivers/media/dvb-frontends/dib3000mb.c | 2 +- drivers/media/dvb-frontends/eds1547.h| 2 +- drivers/media/dvb-fronte

[PATCH 1/3] media: dvb: fix location of get_dvb_firmware script

2018-05-09 Thread Mauro Carvalho Chehab
This script was moved out of Documentation/dvb, but the links weren't updated. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/Kconfig | 18 +- drivers/media/dvb-frontends/nxt200x.c| 4 ++-- drivers/media/dvb-frontends/or51211.c| 2

Re: [PATCH 08/28] venus: hfi_venus: add suspend function for 4xx version

2018-05-09 Thread Stanimir Varbanov
Hi Vikash, On 05/02/2018 09:07 AM, vgaro...@codeaurora.org wrote: > Hello Stanimir, > > On 2018-04-24 18:14, Stanimir Varbanov wrote: >> This adds suspend (power collapse) function with slightly >> different order of calls comparing with Venus 3xx. >> >> Signed-off-by: Stanimir Varbanov >> --- >

Re: [PATCH v3 10/14] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-09 Thread Rui Miguel Silva
Hi Philipp, Thanks. On Wed 09 May 2018 at 08:53, Philipp Zabel wrote: On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entitie

Re: [PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

2018-05-09 Thread Rui Miguel Silva
Hi Randy, On Tue 08 May 2018 at 17:24, Randy Dunlap wrote: Hi, I have a few editing suggestions below... Thank you very much for this. I will incorporate this in the next version. --- Cheers, Rui On 05/07/2018 09:21 AM, Rui Miguel Silva wrote: Add rst document to describe the i.M

Re: [PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

2018-05-09 Thread Rui Miguel Silva
Hi Philipp, Thanks for the review. On Tue 08 May 2018 at 14:30, Philipp Zabel wrote: On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: Add bindings documentation for i.MX7 media drivers. Signed-off-by: Rui Miguel Silva --- .../devicetree/bindings/media/imx7.txt| 152 ++

Re: [PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-05-09 Thread Rui Miguel Silva
Hi Fabio, On Tue 08 May 2018 at 13:28, Fabio Estevam wrote: Hi Rui, On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva wrote: + reg_peri_3p15v: regulator-peri-3p15v { + compatible = "regulator-fixed"; + regulator-name = "peri_3p15v_reg"; + regul

Re: [PATCH 0/4] media: ov2680: follow up from initial version

2018-05-09 Thread Rui Miguel Silva
Hi Sakari, On Tue 08 May 2018 at 20:03, Sakari Ailus wrote: Hi, On Mon, May 07, 2018 at 04:56:51PM +0100, Rui Miguel Silva wrote: Sorry I have Out-of-Office some part of last week, I had v6 of the original series ready but since I have received the notification from patchwork that the v5 was

Re: [RFC PATCH] media: i2c: add SCCB helpers

2018-05-09 Thread Sebastian Reichel
Hi, On Fri, Apr 27, 2018 at 01:13:32AM +0900, Akinobu Mita wrote: > diff --git a/drivers/media/i2c/sccb.c b/drivers/media/i2c/sccb.c > new file mode 100644 > index 000..80a3fb7 > --- /dev/null > +++ b/drivers/media/i2c/sccb.c > @@ -0,0 +1,35 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#in

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/09/18 12:36, Brian Starkey wrote: > Hi Ezequiel, > > On Fri, May 04, 2018 at 05:06:08PM -0300, Ezequiel Garcia wrote: >> From: Gustavo Padovan >> >> Receive in-fence from userspace and add support for waiting on them >> before queueing the buffer to the driver. Buffers can't be queued to th

[PATCH] media: lgdt330x: add inline to lgdt330x_attach function

2018-05-09 Thread Anders Roxell
When CONFIG_DVB_LGDT330X is disabled, we get a build warning: In file included from drivers/media/common/b2c2/flexcop-fe-tuner.c:21:0: drivers/media/dvb-frontends/lgdt330x.h:61:22: warning: ‘lgdt330x_attach’ defined but not used [-Wunused-function] struct dvb_frontend *lgdt330x_attach(const struc

Re: [PATCH v9 12/15] vb2: add out-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi, On Fri, May 04, 2018 at 05:06:09PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create an out_fence and send its fd to userspace in the fence_fd field as a return arg for the QBUF call. The fence is signaled on buffer_d

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi Ezequiel, On Fri, May 04, 2018 at 05:06:08PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers can't be queued to the driver before its fences signal. And a buffer can't b

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Brian Starkey
Hi, On Tue, May 08, 2018 at 08:18:06PM -0300, Gustavo Padovan wrote: Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: On 04/05/18 22:06, Ezequiel Garcia wrote: > From: Gustavo Padovan [snip] > diff --git a/include/media/videobuf2-core.h > b/include/media/videobuf2-core.h >

Re: [PATCH v9 10/15] vb2: add explicit fence user API

2018-05-09 Thread Brian Starkey
Hi Ezequiel, On Fri, May 04, 2018 at 05:06:07PM -0300, Ezequiel Garcia wrote: From: Gustavo Padovan Turn the reserved2 field into fence_fd that we will use to send an in-fence to the kernel or return an out-fence from the kernel to userspace. Two new flags were added, V4L2_BUF_FLAG_IN_FENCE,

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Tomasz Figa
Hi Jason, On Wed, May 9, 2018 at 6:28 PM Chen, JasonX Z wrote: > Hello Tomasz > >> +/* Test Pattern Control */ > >> +#define IMX258_REG_TEST_PATTERN0x0600 > >> +#define IMX258_TEST_PATTERN_DISABLE0 > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR1 > >> +#define IMX258_T

Re: [PATCH] media: video-i2c: get rid of two gcc warnings

2018-05-09 Thread Sakari Ailus
On Fri, May 04, 2018 at 10:19:34AM -0400, Mauro Carvalho Chehab wrote: > After adding this driver, gcc complains with: > > drivers/media/i2c/video-i2c.c:55:1: warning: 'static' is not at beginning of > declaration [-Wold-style-declaration] > const static struct v4l2_fmtdesc amg88xx_format = { >

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Sakari Ailus
Hi Jason, On Wed, May 09, 2018 at 09:28:30AM +, Chen, JasonX Z wrote: > Hello Tomasz > > >> +/* Test Pattern Control */ > >> +#define IMX258_REG_TEST_PATTERN0x0600 > >> +#define IMX258_TEST_PATTERN_DISABLE0 > >> +#define IMX258_TEST_PATTERN_SOLID_COLOR1 > >> +#defi

RE: [PATCH v11] media: imx258: Add imx258 camera sensor driver

2018-05-09 Thread Chen, JasonX Z
Hello Tomasz >> +/* Test Pattern Control */ >> +#define IMX258_REG_TEST_PATTERN0x0600 >> +#define IMX258_TEST_PATTERN_DISABLE0 >> +#define IMX258_TEST_PATTERN_SOLID_COLOR1 >> +#define IMX258_TEST_PATTERN_COLOR_BARS 2 #define >> +IMX258_TEST_PATTERN_GREY_COLOR 3 >> +#de

[PATCH] [media] cx231xx: Fix spelling mistake: "senario" -> "scenario"

2018-05-09 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in dev_err message. Signed-off-by: Colin Ian King --- drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c b/drivers/media/usb/cx231xx/cx

Re: [PATCH v3 09/14] ARM: dts: imx7s: add multiplexer controls

2018-05-09 Thread Philipp Zabel
On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: > The IOMUXC General Purpose Register has bitfield to control video bus > multiplexer to control the CSI input between the MIPI-CSI2 and parallel > interface. Add that register and mask. > > Signed-off-by: Rui Miguel Silva > --- > arch/a

Re: [PATCH v3 10/14] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-05-09 Thread Philipp Zabel
On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: > This patch adds the device tree nodes for csi, video multiplexer and mipi-csi > besides the graph connecting the necessary endpoints to make the media capture > entities to work in imx7 Warp board. > > Also add the pin control related wi

Re: [PATCH 10/28] venus: vdec: call session_continue in insufficient event

2018-05-09 Thread Stanimir Varbanov
Hi Vikash, On 05/04/2018 02:09 PM, Vikash Garodia wrote: > Hi Stanimir, > > On 2018-05-03 17:06, Stanimir Varbanov wrote: >> Hi Vikash, >> >> Thanks for the comments! >> >> On  2.05.2018 09:26, Vikash Garodia wrote: >>> Hello Stanimir, >>> >>> On 2018-04-24 18:14, Stanimir Varbanov wrote: Ca

Re: [PATCH v4] media: v4l2-ioctl: replace IOCTL_INFO_STD with stub functions

2018-05-09 Thread Hans Verkuil
On 05/08/2018 07:56 PM, Sami Tolvanen wrote: > This change removes IOCTL_INFO_STD and adds stub functions where > needed using the DEFINE_V4L_STUB_FUNC macro. This fixes indirect call > mismatches with Control-Flow Integrity, caused by calling standard > ioctls using a function pointer that doesn't

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

2018-05-09 Thread Hans Verkuil
On 05/08/2018 09:16 PM, Ezequiel Garcia wrote: > On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: >> On 04/05/18 22:06, Ezequiel Garcia wrote: >>> @@ -1421,15 +1505,40 @@ int vb2_core_qbuf(struct vb2_queue *q, unsigned int >>> index, void *pb) >>> trace_vb2_qbuf(q, vb); >>> >>> /*