This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Apr 13 05:00:14 CEST 2018
media-tree git hash:b284d4d5a6785f8cd07eda2646a95782373cd01e
media_build gi
From: Koji Matsuoka
In Video Pixel/Line Pre-Clip Register, the setting value can be
set in 1 line unit, but it can only be specified as a multiple of
4 by v4l_bound_align_image function().
So correct that it can be specified in 1 line unit with this patch.
Signed-off-by: Koji Matsuoka
Signed-o
On Fri, 30 Mar 2018, tpcl...@mklab.ph.rhul.ac.uk wrote:
Could anyone clarify what is supported on this stick for me? According to
https://www.linuxtv.org/wiki/index.php/Astrometa_DVB-T2 DVB-T2 has been
supported since kernel 4.6. I tried using a 4.9.9 kernel about a year ago
and again today
On Thu, Apr 12, 2018 at 11:24:07AM -0400, Mauro Carvalho Chehab wrote:
> As warned by smatch:
> drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop
> depends on readl() succeeding
>
> If something goes wrong at readl(), the logic will stay there
> inside an IRQ code forever. T
On Tue, Apr 10, 2018 at 09:24:19PM +0200, Matthias Reichl wrote:
> On Tue, Apr 10, 2018 at 07:39:43PM +0100, Sean Young wrote:
> > On Tue, Apr 10, 2018 at 07:53:43PM +0200, Matthias Reichl wrote:
> > > Hi Sean,
> > >
> > > On Sun, Apr 08, 2018 at 10:19:35PM +0100, Sean Young wrote:
> > > > The cur
On 04/12/2018 12:04 PM, Philipp Zabel wrote:
> On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote:
>> In VDIC direct mode, the VDIC applies combing filter during and
>> doubles the framerate, that is, after the first two half-frames
>> are received and the first frame is emitted by the VDIC, ever
The current probe function calls v4l2_ctrl_handler_setup() before
initializing the format info. This triggers call paths such as:
imx274_probe -> v4l2_ctrl_handler_setup -> imx274_s_ctrl ->
imx274_set_exposure, where priv->mode_index is accessed before being
assigned.
This is wrong but does not tr
Data about for the implemented readout modes is partially stored in
imx274_formats[], the rest is scattered in several arrays. The latter
are then accessed using the mode index, e.g.:
min_frame_len[priv->mode_index]
Consolidate all these data in imx274_formats[], and store a pointer to
the sele
IMX274_DEFAULT_MODE is defined but not used. Start using it, so the
default can be more easily changed without digging into the code.
Signed-off-by: Luca Ceresoli
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drive
Mark Brown writes:
> On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote:
>> As the pxa architecture switched towards the dmaengine slave map, the
>> old compatibility mechanism to acquire the dma requestor line number and
>> priority are not needed anymore.
>
> Acked-by: Mark Brown
>
After restructuring struct imx274_frmfmt, the mode_index field is
still in use only for two dev_dbg() calls in imx274_s_stream(). Let's
remove it and avoid duplicated information.
Replacing the first usage requires a rather annoying but trivial
computation. The other one can be removed entirely si
Document the unit to avoid having to look through the code to compute it.
Also clarify that these are min and max values.
Signed-off-by: Luca Ceresoli
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c
imx274_write_table() is a mere wrapper (and the only user) to
imx274_regmap_util_write_table_8(). Remove this useless indirection by
merging the two functions into one.
Also get rid of the wait_ms_addr and end_addr parameters since it does
not make any sense to give them any values other than
IMX2
Tables of struct reg_8 are used to simplify multi-byte register
assignment. However filling these snippets with values computed at
runtime is currently implemented by very similar functions doing the
needed shift & mask manipulation.
Replace all those functions with a unique helper function to fil
Currently this driver does not support cropping. The supported modes
are the following, all capturing the entire area:
- 3840x2160, 1:1 binning (native sensor resolution)
- 1920x1080, 2:1 binning
- 1280x720, 3:1 binning
The set_fmt callback chooses among these 3 configurations the one that
ma
mode_table[] has 3 members that are accessed based on their index, which
makes worth using an array.
The other members are always accessed with a constant index. This added
indirection gives no improvement and only makes code more verbose.
Remove these pointers from the array and access them dire
Hi,
this patchset introduces cropping support for the Sony IMX274 sensor
using the SELECTION API, after several cleanups and general code
improvements.
Patches 1-6 clean up and restructure code in various places and are
pretty much independent from the cropping feature.
Patches 7-11 are further
imx274_s_frame_interval() already has a direct pointer to the v4l2
exposure control, so reuse it to simplify code.
Signed-off-by: Luca Ceresoli
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274
struct imx274_frmfmt is instantiated only in the imx274_formats[]
array, where imx274_formats[N].mode always equals N (via enum
imx274_mode). So .mode carries no information, and unsurprisingly it
is never used.
mbus_code is never used because the 12 bit modes are not implemented.
The colorspace
Signed-off-by: Luca Ceresoli
---
drivers/media/i2c/imx274.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c
index 5e425db9204d..dfd04edcdd48 100644
--- a/drivers/media/i2c/imx274.c
+++ b/drivers/media/i2c/imx274.c
@@ -971
Most registers are defined using the name used in the datasheet.
E.g. the defines for the HMAX register are IMX274_HMAX_REG_*.
Rename the SHR and VMAX register accordingly. Also move them close to
related registers: SHR close to SVR, VMAX close to HMAX.
Signed-off-by: Luca Ceresoli
---
drivers/
On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote:
> As the pxa architecture switched towards the dmaengine slave map, the
> old compatibility mechanism to acquire the dma requestor line number and
> priority are not needed anymore.
Acked-by: Mark Brown
If there's no dependency I'm
As warned by smatch:
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:879
put_v4l2_ext_controls32() warn: check for integer overflow 'count'
The access_ok() logic should check for too big arrays too.
Cc: sta...@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-co
As warned by smatch:
drivers/media/dvb-core/dvb_frontend.c:314 dvb_frontend_get_event()
warn: inconsistent returns 'sem:&fepriv->sem'.
Locked on: line 288
line 295
line 306
line 314
Unlocked on: line
On smatch, this warning is trigged:
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c:324
__bo_take_off_handling() error: we previously assumed 'bo->prev' could be null
(see line 314)
Because it can't properly analize the truth table for the above
function. So, add an explicit che
smatch says that there's an issue with number
conversion:
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:4154
sh_css_params_write_to_ddr_internal() warn: '((-(1 << ((14 - 1)' 4294959104
can't fit into 32767 'converted_macc_table.data[idx]'
drivers/staging/media/atom
There are two functions used externally:
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:866:6:
warning: symbol 'atomisp_do_compat_ioctl' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:1110:6:
warnin
Smatch report several issues with bad __user annotations:
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect type
in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21:expected void
[noderef] *uptr
drivers/media/v4l2-core/v4
The __user annotations at the compat32 code is not right:
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:81:18:
warning: incorrect type in assignment (different address spaces)
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:81:18:
expected void
There are lots of troubles with atomisp __user annotations. Fix them.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_acc.c:357:49: warning:
incorrect type in argument 2 (different address spaces)
drivers/staging/media/atomisp/pci/atomisp2/atomisp_acc.c:357:49:expected
void *userptr
drive
Changeset dc9f65cf9aea ("media: staging: atomisp: avoid a warning if 32
bits build") was meant to solve an impossible condition when building
with 32 bits. It turns that this impossible condition also happens wit
64 bits:
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platfo
The omap/omap3 and viu drivers are for 32 bit platforms only.
There, a pointer has 32 bits. Now that those drivers build
for 64 bits with COMPILE_TEST, they produce the following
warnings:
drivers/media/platform/omap/omap_vout_vrfb.c: In function
'omap_vout_allocate_vrfb_buffers':
drivers/media/p
As warned by smatch:
drivers/media/pci/mantis/mantis_uart.c:105 mantis_uart_work() warn:
this loop depends on readl() succeeding
If something goes wrong at readl(), the logic will stay there
inside an IRQ code forever. This is not the nicest thing to
do :-)
So, add a timeout there, preve
As warned by smatch:
drivers/media/rc/st_rc.c:110 st_rc_rx_interrupt() warn: this loop
depends on readl() succeeding
If something goes wrong at readl(), the logic will stay there
inside an IRQ code forever. This is not the nicest thing to
do :-)
So, add a timeout there, preventing stayin
The logic at v4l2_fwnode_reference_parse_int_props() is somewhat
complex and violates Linux coding style, as it does multiple
statements on a single line. That makes static analyzers to
be confused, as warned by smatch:
drivers/media/v4l2-core/v4l2-fwnode.c:832
v4l2_fwnode_reference_parse
The logic at get_atomisp_parameters32() is broken, as pointed by
smatch:
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:737:21:
warning: dereference of noderef expression
drivers/staging/media/atomisp/pci/atomisp2/atomisp_compat_ioctl32.c:744:60:
warning: d
it makes no sense to use strncmp() with a size with is
bigger than the string we're comparing with.
Fix those warnings:
drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c:776
atomisp_open() error: strncmp() '"ATOMISP ISP ACC"' too small (16 vs 32)
drivers/staging/media/atomisp/pci
From: Hans Verkuil
drivers/media/cec/cec-pin-error-inj.c:231
cec_pin_error_inj_parse_line() error: uninitialized symbol 'pos'.
The tx-add-bytes command didn't check for the presence of an argument, and
also didn't check that it was > 0.
This should fix this error.
Signed-off-by: Hans Verkuil
The mmu_private.h header is included at mmu.c, with duplicates the
already existing definitions at mmu_public.h.
Fix this by removing the erroneous header file.
Solve those issues:
drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/mmu_private.h:24:26:
warning: fun
(changed subject and decoupling from udmabuf thread)
On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote:
> On 04/10/2018 08:26 PM, Dongwon Kim wrote:
> >On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote:
> >>On 04/06/2018 09:57 PM, Dongwon Kim wrote:
> >>
Greetings everyone,
I am using Linux 4.14.31 on an IMX6 platform, with an MT9P031 sensor
attached to the ipu1_csi0 (parallel).
My Gstreamer version is 1.14.0 and v4l-utils version is 1.14.2.
The problem is that I am unable to set up a capture pipeline.
Even the simplest capture pipeline such as:
Em Thu, 12 Apr 2018 09:02:34 -0400
Mauro Carvalho Chehab escreveu:
> Smatch report several issues with bad __user annotations:
Please ignore this one. Sent to early.
>
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect
> type in argument 1 (different address spaces)
On Thu, Apr 12, 2018 at 04:03:22PM +0300, Sakari Ailus wrote:
> A number of uAPI structs have pointers but some lack the __user modifier.
> Add this to the pointers that do not have it.
>
> Signed-off-by: Sakari Ailus
Please ignore these patches; the issue is not as trivially solved.
--
Sakari
Hi Hans,
I don't really have an opinion on the patch yet; a few trivial comments
below.
On Mon, Apr 09, 2018 at 04:20:07PM +0200, Hans Verkuil wrote:
...
> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
> index 5b445b5654f7..f8faa54b5e7e 100644
> --- a/include/media/v4l2-ctr
A number of uAPI structs have pointers but some lack the __user modifier.
Add this to the pointers that do not have it.
Signed-off-by: Sakari Ailus
---
since v1:
- Against the master branch (not Hans's reqv10)
include/uapi/linux/videodev2.h | 6 +++---
1 file changed, 3 insertions(+), 3 deleti
Smatch report several issues with bad __user annotations:
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect type
in argument 1 (different address spaces)
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21:expected void
[noderef] *uptr
drivers/media/v4l2-core/v4
On Di, Apr 10, 2018 at 05:22:39 -0300, Mauro Carvalho Chehab wrote:
> That's said, adding suport for DiSEqC with more than 6 bytes should
> likely be enabled driver per driver, after checking that the device
> supports it.
Do you know which length saa7146/stv0299 could do?
--
Josef Wolf
j...@rav
A number of uAPI structs have pointers but some lack the __user modifier.
Add this to the pointers that do not have it.
Signed-off-by: Sakari Ailus
---
Hi Mauro,
I wonder if this would fix some smatch errors or would allow also cleaning
up the casts in the compat code. Either way, this would st
Assigning subdev flags in probe() after v4l2_i2c_subdev_init() clears the
I2C flag set by that function. Fix this by using bitwise or instead.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/tda1997x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tda199
On Mon, Apr 09, 2018 at 04:20:05PM +0200, Hans Verkuil wrote:
> From: Alexandre Courbot
>
> If which is V4L2_CTRL_WHICH_REQUEST, then the request_fd field can be
> used to specify a request for the G/S/TRY_EXT_CTRLS ioctls.
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/media/v4l2-core/v
Hi Hans,
On Mon, Apr 09, 2018 at 04:20:04PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Add media_request_object_find to find a request object inside a
> request based on ops and/or priv values.
>
> Objects of the same type (vb2 buffer, control handler) will have
> the same ops value. A
Hi Hans,
On Mon, Apr 09, 2018 at 04:20:03PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Add media_request_find() to find a request based on the file
> descriptor.
>
> The caller has to call media_request_put() for the returned
> request since this function increments the refcount.
>
>
Hi Mauro,
On Tue, Apr 10, 2018 at 08:04:09AM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 9 Apr 2018 16:20:03 +0200
> Hans Verkuil escreveu:
>
> > From: Hans Verkuil
> >
> > Add media_request_find() to find a request based on the file
> > descriptor.
> >
> > The caller has to call media_req
Hi Mauro,
On Tue, Apr 10, 2018 at 07:57:56AM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 9 Apr 2018 16:20:02 +0200
> Hans Verkuil escreveu:
>
> > From: Hans Verkuil
> >
> > Implement the MEDIA_REQUEST_IOC_QUEUE and MEDIA_REQUEST_IOC_REINIT
> > ioctls.
> >
> > Signed-off-by: Hans Verkuil
>
Check that no error happened during adding controls to the driver's
control handler. Print an error message and bail out if there was one.
Signed-off-by: Sakari Ailus
---
since v1:
- Move error checking after clustering. While clustering won't cause an
error now, it's better to check for error
Check that no error happened during adding controls to the driver's
control handler. Print an error message and bail out if there was one.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ov7740.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ov7740.c b/drivers/me
The driver has event support implemented but fails to set the flag
enabling event support. Set the flag to enable control events.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ov7740.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov7740.c b/drivers/me
Hi folks,
I wrote these fixes to the ov7740 driver for the problems I saw. Mostly
error handling as well as setting the events flag to enable control
events.
Sakari Ailus (4):
ov7740: Fix number of controls hint
ov7740: Check for possible NULL return value in control creation
ov7740: Fix co
Check that creating the control actually succeeded before accessing it.
A failure would lead to NULL pointer reference. Fix this.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ov7740.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/ov7740.c
The driver has 12 controls, not 2.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/ov7740.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c
index 01f578785e79..c9b8bec6373f 100644
--- a/drivers/media/i2c/ov7740.c
+++ b
On Sat, 2018-04-07 at 15:04 +0200, Marek Vasut wrote:
> In VDIC direct mode, the VDIC applies combing filter during and
> doubles the framerate, that is, after the first two half-frames
> are received and the first frame is emitted by the VDIC, every
> subsequent half-frame is patched into the resu
Hi Jacopo,
On Thu, Apr 12, 2018 at 10:57:01AM +0200, jacopo mondi wrote:
...
> > + if (MAX_RETRY == ++retry) {
> > + dev_err(&client->dev,
> > + "Cannot do the write operation because VCM is
> > busy\n");
>
> Nit: this is over 80 cols, it's f
Hi Hans,
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Add support for requests to vim2m.
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/platform/vim2m.c | 25 +
> 1 file changed, 25 insertions(+)
> diff --git a/drivers/media/plat
Hi Hans,
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> v4l2_ctrl uses mutexes, so we can't setup a ctrl_handler in
> interrupt context. Switch to a workqueue instead.
Could it make more sense to just replace the old (non-hr) timer used in
this driver with delayed
HI Andy,
thanks for addressing my comments on v6.
Some more questions below.
On Tue, Apr 10, 2018 at 11:48:44PM +0800, Andy Yeh wrote:
> From: Alan Chiang
>
> DW9807 is a 10 bit DAC from Dongwoon, designed for linear
> control of voice coil motor.
>
> This driver creates a V4L2 subdevice and
>
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
> From: Alexandre Courbot
> Request API requires a media node. Add one to the vim2m driver so we can
> use requests with it.
> This probably needs a bit more work to correctly represent m2m
> hardware in the media topology.
[snip]
> @@ -1013,
Hi Hans,
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
[snip]
> @@ -514,6 +517,11 @@ Buffer Flags
> streaming may continue as normal and the buffer may be reused
> normally. Drivers set this flag when the ``VIDIOC_DQBUF`` ioctl is
> called.
> +* .. _`V4L2-BUF-
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Generic helper function that checks if there are buffers in
> the request and if so, prepares and queues all objects in the
> request.
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/common/videobuf2/videobuf2-v4
Hi Hans,
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote:
> From: Hans Verkuil
> Buffers can now be prepared or queued for a request.
> A buffer is unbound from the request at vb2_buffer_done time or
> when the queue is cancelled.
Please see my comments inline.
[snip]
> -int vb2_core_pre
Hi Tomasz,
On Tue, Apr 10, 2018 at 08:59:23AM +, Tomasz Figa wrote:
> Hi Hans,
>
> On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote:
>
> > From: Hans Verkuil
>
> > Implement the MEDIA_REQUEST_IOC_QUEUE and MEDIA_REQUEST_IOC_REINIT
> > ioctls.
>
> > Signed-off-by: Hans Verkuil
> > ---
Hi Hans,
On Mon, Apr 09, 2018 at 04:20:02PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Implement the MEDIA_REQUEST_IOC_QUEUE and MEDIA_REQUEST_IOC_REINIT
> ioctls.
>
> Signed-off-by: Hans Verkuil
> ---
> drivers/media/media-request.c | 80
> +-
On Wed, Apr 11, 2018 at 01:13:44PM -0300, Mauro Carvalho Chehab wrote:
> Em Wed, 11 Apr 2018 18:35:14 +0300
> Sakari Ailus escreveu:
>
> > On Wed, Apr 11, 2018 at 12:17:27PM -0300, Mauro Carvalho Chehab wrote:
> > > Em Wed, 11 Apr 2018 18:02:19 +0300
> > > Sakari Ailus escreveu:
> > >
> > > >
72 matches
Mail list logo
