Re: [RfC PATCH] Add udmabuf misc device

2018-04-10 Thread Oleksandr Andrushchenko
On 04/10/2018 08:26 PM, Dongwon Kim wrote: On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: On 04/06/2018 09:57 PM, Dongwon Kim wrote: On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote: On 04/06/2018 02:57 PM, Gerd Hoffmann wrote: Hi, I fail

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Tomasz Figa
On Wed, Apr 11, 2018 at 1:38 PM Tomasz Figa wrote: [snip] > > +static int dw9807_set_dac(struct i2c_client *client, u16 data) > > +{ > > + const char tx_data[3] = { > > + DW9807_MSB_ADDR, ((data >> 8) & 0x03), (data & 0xff) > > + }; > > + int ret, retry = 0; > > + >

Re: [RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Tomasz Figa
Hi Andy, Alan, On Wed, Apr 11, 2018 at 12:41 AM Andy Yeh wrote: > From: Alan Chiang > DW9807 is a 10 bit DAC from Dongwoon, designed for linear > control of voice coil motor. > This driver creates a V4L2 subdevice and > provides control to set the desired focus. Please see my comments inline

Re: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Tomasz Figa
Hi Andy, On Wed, Apr 11, 2018 at 12:54 AM Yeh, Andy wrote: > Hi Jacopo, > Excuse for late reply, we were busy in past weeks for major milestone. Please kindly check the revised V7 which has been uploaded. > https://patchwork.linuxtv.org/patch/48589/ > Responded to your comments as below. > Cc

cron job: media_tree daily build: OK

2018-04-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Apr 11 05:00:13 CEST 2018 media-tree git hash:17dec0a949153d9ac00760ba2f5b78cb583e995f media_build gi

[PATCH 3/3] media: dvb-usb: Replace GFP_ATOMIC with GFP_KERNEL in usb_isoc_urb_init

2018-04-10 Thread Jia-Ju Bai
usb_isoc_urb_init() is never called in atomic context. The call chains ending up at usb_isoc_urb_init() are: [1] usb_isoc_urb_init() <- usb_urb_init() <- dvb_usb_adapter_stream_init() <- dvb_usb_adapter_init <- dvb_usb_init() <- dvb_usb_device_init() <- xxx_probe() xxx_probe inclu

[PATCH 2/3] media: dvb-usb: Replace GFP_ATOMIC with GFP_KERNEL in usb_bulk_urb_init

2018-04-10 Thread Jia-Ju Bai
usb_bulk_urb_init() is never called in atomic context. The call chains ending up at usb_bulk_urb_init() are: [1] usb_bulk_urb_init() <- usb_urb_init() <- dvb_usb_adapter_stream_init() <- dvb_usb_adapter_init <- dvb_usb_init() <- dvb_usb_device_init() <- xxx_probe() xxx_probe inclu

[PATCH 1/3] media: dvb-usb: Replace GFP_ATOMIC with GFP_KERNEL in usb_allocate_stream_buffers

2018-04-10 Thread Jia-Ju Bai
usb_allocate_stream_buffers() is never called in atomic context. The call chains ending up at usb_allocate_stream_buffers() are: [1] usb_allocate_stream_buffers() <- usb_bulk_urb_init() <- usb_urb_init() <- dvb_usb_adapter_stream_init() <- dvb_usb_adapter_init <- dvb_usb_init() <-

Re: [PATCH v2 5/6] usbtv: Enforce standard for color decoding

2018-04-10 Thread kbuild test robot
Hi Hugo, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180410] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: Confusion about API: please clarify

2018-04-10 Thread Mauro Carvalho Chehab
Em Tue, 10 Apr 2018 21:14:23 +0200 Josef Wolf escreveu: > On Di, Apr 10, 2018 at 11:58:15 -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 10 Apr 2018 12:43:27 +0200 > > Josef Wolf escreveu: > > > > > > The linuxtv wiki pages state that the current v5 API (also called S2API) > > > is > > > ta

Re: [PATCH v2 0/7] Improve latency of IR decoding

2018-04-10 Thread Matthias Reichl
On Tue, Apr 10, 2018 at 07:39:43PM +0100, Sean Young wrote: > On Tue, Apr 10, 2018 at 07:53:43PM +0200, Matthias Reichl wrote: > > Hi Sean, > > > > On Sun, Apr 08, 2018 at 10:19:35PM +0100, Sean Young wrote: > > > The current IR decoding is much too slow. Many IR protocols rely on > > > a trailing

Re: Confusion about API: please clarify

2018-04-10 Thread Josef Wolf
On Di, Apr 10, 2018 at 11:58:15 -0300, Mauro Carvalho Chehab wrote: > Em Tue, 10 Apr 2018 12:43:27 +0200 > Josef Wolf escreveu: > > > > The linuxtv wiki pages state that the current v5 API (also called S2API) is > > tag/value based: > > > > > > https://www.linuxtv.org/wiki/index.php/Developme

Re: [PATCH v2 0/7] Improve latency of IR decoding

2018-04-10 Thread Sean Young
On Tue, Apr 10, 2018 at 07:53:43PM +0200, Matthias Reichl wrote: > Hi Sean, > > On Sun, Apr 08, 2018 at 10:19:35PM +0100, Sean Young wrote: > > The current IR decoding is much too slow. Many IR protocols rely on > > a trailing space for decoding (e.g. rc-6 needs to know when the bits > > end). The

Re: [PATCH v2 0/7] Improve latency of IR decoding

2018-04-10 Thread Matthias Reichl
Hi Sean, On Sun, Apr 08, 2018 at 10:19:35PM +0100, Sean Young wrote: > The current IR decoding is much too slow. Many IR protocols rely on > a trailing space for decoding (e.g. rc-6 needs to know when the bits > end). The trailing space is generated by the IR timeout, and if this > is longer than

Re: [RfC PATCH] Add udmabuf misc device

2018-04-10 Thread Dongwon Kim
On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: > On 04/06/2018 09:57 PM, Dongwon Kim wrote: > >On Fri, Apr 06, 2018 at 03:36:03PM +0300, Oleksandr Andrushchenko wrote: > >>On 04/06/2018 02:57 PM, Gerd Hoffmann wrote: > >>> Hi, > >>> > >I fail to see any common ground

Re: [PATCH 1/6] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

2018-04-10 Thread Akinobu Mita
2018-04-09 15:58 GMT+09:00 jacopo mondi : > Hello Akinobu, > thank you for the patch. > > On which platform have you tested the series (just curious) ? I use Zynq-7000 development board with Xilinx Video IP driver and custom video pipeline design based on the example reference project. > On S

Re: [PATCH 6/6] media: ov772x: support device tree probing

2018-04-10 Thread Akinobu Mita
2018-04-09 18:27 GMT+09:00 jacopo mondi : > Hi Akinobu, > > On Sun, Apr 08, 2018 at 12:48:10AM +0900, Akinobu Mita wrote: >> The ov772x driver currently only supports legacy platform data probe. >> This change enables device tree probing. >> >> Note that the platform data probe can select auto or m

Re: [PATCH 5/6] media: ov772x: add device tree binding

2018-04-10 Thread Akinobu Mita
2018-04-09 18:06 GMT+09:00 jacopo mondi : > Hi Akinobu, > > On Sun, Apr 08, 2018 at 12:48:09AM +0900, Akinobu Mita wrote: >> This adds a device tree binding documentation for OV7720/OV7725 sensor. > > Please use as patch subject > media: dt-bindings: OK. >> >> Cc: Jacopo Mondi >> Cc: Laurent Pin

Re: [PATCH 4/6] media: ov772x: add media controller support

2018-04-10 Thread Akinobu Mita
2018-04-09 17:32 GMT+09:00 jacopo mondi : > Hi Akinobu, > > On Sun, Apr 08, 2018 at 12:48:08AM +0900, Akinobu Mita wrote: >> Create a source pad and set the media controller type to the sensor. >> >> Cc: Jacopo Mondi >> Cc: Laurent Pinchart >> Cc: Hans Verkuil >> Cc: Sakari Ailus >> Cc: Mauro C

Re: [PATCH 2/6] media: ov772x: add checks for register read errors

2018-04-10 Thread Akinobu Mita
2018-04-09 16:36 GMT+09:00 jacopo mondi : > Hi Akinobu, > > On Sun, Apr 08, 2018 at 12:48:06AM +0900, Akinobu Mita wrote: >> This change adds checks for register read errors and returns correct >> error code. >> > > I feel like error conditions are anyway captured by the switch() > default case, bu

RE: RESEND[PATCH v6 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Yeh, Andy
Hi Jacopo, Excuse for late reply, we were busy in past weeks for major milestone. Please kindly check the revised V7 which has been uploaded. https://patchwork.linuxtv.org/patch/48589/ Responded to your comments as below. Cc in Tomasz for unintentionally missed. Regards, Andy -Original Me

[RESEND PATCH v7 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

2018-04-10 Thread Andy Yeh
From: Alan Chiang Dongwoon DW9807 is a voice coil lens driver. Signed-off-by: Andy Yeh --- Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt | 9 + 1 file changed, 9 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807.txt diff -

[RESEND PATCH v7 2/2] media: dw9807: Add dw9807 vcm driver

2018-04-10 Thread Andy Yeh
From: Alan Chiang DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus. Signed-off-by: Andy Yeh --- since v1: - changed author. since v2: - addressed outstanding comments. - ena

[RESEND PATCH v7 0/2] DW9807 DT binding and driver patches

2018-04-10 Thread Andy Yeh
Hi Sakari and Tomasz, The two patches are the DT binding and driver for DW9807 VCM controller. Alan Chiang (2): media: dw9807: Add dw9807 vcm driver media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil .../bindings/media/i2c/dongwoon,dw9807.txt | 9 + MAINTAINERS

Re: Confusion about API: please clarify

2018-04-10 Thread Mauro Carvalho Chehab
Em Tue, 10 Apr 2018 12:43:27 +0200 Josef Wolf escreveu: > Hello, > > The linuxtv wiki pages state that the current v5 API (also called S2API) is > tag/value based: > > > https://www.linuxtv.org/wiki/index.php/Development:_Linux_DVB_API_history_and_future > https://www.linuxtv.org/wiki/inde

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-10 Thread Mauro Carvalho Chehab
Em Tue, 10 Apr 2018 15:32:34 +0300 Sakari Ailus escreveu: > Hi Mauro and Hans, > > On Tue, Apr 10, 2018 at 07:32:06AM -0300, Mauro Carvalho Chehab wrote: > ... > > > +static void media_request_release(struct kref *kref) > > > +{ > > > + struct media_request *req = > > > + container_of(kr

Re: [RFCv11 PATCH 00/29] Request API

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:19:57 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Hi all, > > This is a cleaned up version of the v10 series (never posted to > the list since it was messy). Just reviewed the full series. I found v11 still a little messy, specially at the part that touches V

Re: [RfC PATCH] Add udmabuf misc device

2018-04-10 Thread Gerd Hoffmann
Hi, > Generally we try to cache mappings as much as possible. And wrt finding a > slot: Create a sufficiently sized BAR on the virgl device, just for that? Well. virtio has no concept of "bars" ... The most common virtio transport layer happens to be pci, which actually has bars. But we also

Re: [RFCv11 PATCH 24/29] Documentation: v4l: document request API

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:21 +0200 Hans Verkuil escreveu: > From: Alexandre Courbot > > Document the request API for V4L2 devices, and amend the documentation > of system calls influenced by it. As said before, I would be expecting this patch to be split, with the initial contents coming toget

Re: [RFCv11 PATCH 23/29] videobuf2-v4l2: export request_fd

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:20 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Requested by Sakari Huh? What kind of description is that? Why is it needed? It is even harder to analyze this as documentation for the new field is not there. > > Signed-off-by: Hans Verkuil > --- > drive

Re: [RFCv11 PATCH 12/29] v4l2-ctrls: alloc memory for p_req

2018-04-10 Thread Mauro Carvalho Chehab
Em Tue, 10 Apr 2018 09:32:00 + Tomasz Figa escreveu: > Hi Hans, > > On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > > > From: Hans Verkuil > > > To store request data the handler_new_ref() allocates memory > > for it if needed. > > > Signed-off-by: Hans Verkuil > > --- > >

Re: [RFCv11 PATCH 21/29] videobuf2-core: add vb2_core_request_has_buffers

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:18 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add a new helper function that returns true if a media_request > contains buffers. > > Signed-off-by: Hans Verkuil > --- > drivers/media/common/videobuf2/videobuf2-core.c | 12 > include/media/vid

Re: [RFCv11 PATCH 20/29] videobuf2-v4l2: integrate with media requests

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:17 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > This implements the V4L2 part of the request support. The main > change is that vb2_qbuf and vb2_prepare_buf now have a new > media_device pointer. This required changes to several drivers > that did not use the

Re: [RFCv11 PATCH 17/29] vb2: store userspace data in vb2_v4l2_buffer

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:14 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The userspace-provided plane data needs to be stored in > vb2_v4l2_buffer. Currently this information is applied by > __fill_vb2_buffer() which is called by the core prepare_buf > and qbuf functions, but when usi

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-10 Thread Sakari Ailus
Hi Tomasz and Hans, On Tue, Apr 10, 2018 at 08:21:27AM +, Tomasz Figa wrote: > > +void media_request_cancel(struct media_request *req) > > +{ > > + struct media_request_object *obj, *obj_safe; > > + > > + if (req->state != MEDIA_REQUEST_STATE_QUEUED) > > + return; >

Re: [RFCv11 PATCH 15/29] v4l2-ctrls: support g/s_ext_ctrls for requests

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:12 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The v4l2_g/s_ext_ctrls functions now support control handlers that > represent requests. > > The v4l2_ctrls_find_req_obj() function is responsible for finding the > request from the fd. > > Signed-off-by: Hans

Re: [RFCv11 PATCH 13/29] v4l2-ctrls: use ref in helper instead of ctrl

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:10 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The next patch needs the reference to a control instead of the > control itself, so change struct v4l2_ctrl_helper accordingly. > > Signed-off-by: Hans Verkuil > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 18

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-10 Thread Sakari Ailus
Hi Mauro and Hans, On Tue, Apr 10, 2018 at 07:32:06AM -0300, Mauro Carvalho Chehab wrote: ... > > +static void media_request_release(struct kref *kref) > > +{ > > + struct media_request *req = > > + container_of(kref, struct media_request, kref); > > + struct media_device *mdev = req

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-10 Thread Sakari Ailus
Hi Hans, Thanks for the update. On Mon, Apr 09, 2018 at 04:20:01PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Implement the core of the media request processing. > > Drivers can bind request objects to a request. These objects > can then be marked completed if the driver finished usin

Re: [RFCv11 PATCH 10/29] v4l2-ctrls: v4l2_ctrl_add_handler: add from_other_dev

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:07 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add a 'bool from_other_dev' argument: set to true if the two > handlers refer to different devices (e.g. it is true when > inheriting controls from a subdev into a main v4l2 bridge > driver). Hmm... wouldn't it

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

2018-04-10 Thread Guennadi Liakhovetski
Hi Laurent, First a couple of replies to your questions. On Fri, 23 Mar 2018, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > > From: Guennadi Liakhovetski > > > > UVC defines a method of handling asynchr

Re: [RFCv11 PATCH 03/29] media-request: allocate media requests

2018-04-10 Thread Sakari Ailus
Hi Mauro and Hans, On Tue, Apr 10, 2018 at 06:52:39AM -0300, Mauro Carvalho Chehab wrote: > > diff --git a/include/media/media-device.h b/include/media/media-device.h > > index bcc6ec434f1f..07e323c57202 100644 > > --- a/include/media/media-device.h > > +++ b/include/media/media-device.h > > @@ -1

Confusion about API: please clarify

2018-04-10 Thread Josef Wolf
Hello, The linuxtv wiki pages state that the current v5 API (also called S2API) is tag/value based: https://www.linuxtv.org/wiki/index.php/Development:_Linux_DVB_API_history_and_future https://www.linuxtv.org/wiki/index.php/S2API But in the API documentation (version 5.10), I can't find any

Re: [RFCv11 PATCH 08/29] videodev2.h: add request_fd field to v4l2_ext_controls

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:05 +0200 Hans Verkuil escreveu: > From: Alexandre Courbot > > If which is V4L2_CTRL_WHICH_REQUEST, then the request_fd field can be > used to specify a request for the G/S/TRY_EXT_CTRLS ioctls. That's a general comment that applies not only to this patch, but to all p

Re: [RFCv11 PATCH 07/29] media-request: add media_request_object_find

2018-04-10 Thread Hans Verkuil
On 04/10/18 13:07, Mauro Carvalho Chehab wrote: > Em Mon, 9 Apr 2018 16:20:04 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Add media_request_object_find to find a request object inside a >> request based on ops and/or priv values. >> >> Objects of the same type (vb2 buffer, cont

Re: [RFCv11 PATCH 07/29] media-request: add media_request_object_find

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:04 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add media_request_object_find to find a request object inside a > request based on ops and/or priv values. > > Objects of the same type (vb2 buffer, control handler) will have > the same ops value. And objects t

RE: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-04-10 Thread Fabrizio Castro
Hello Niklas, > Subject: Re: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree > support for r8a774[35] > > Hi Fabrizio, > > On 2018-04-10 09:55:29 +, Fabrizio Castro wrote: > > Dear All, > > > > this patch was originally sent on the 16/11/2017, and reposted a few times, > > do

Re: [RFCv11 PATCH 06/29] media-request: add media_request_find

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:03 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add media_request_find() to find a request based on the file > descriptor. > > The caller has to call media_request_put() for the returned > request since this function increments the refcount. > > Signed-off-b

Re: [RFCv11 PATCH 02/29] uapi/linux/media.h: add request API

2018-04-10 Thread Sakari Ailus
On Tue, Apr 10, 2018 at 06:38:56AM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 9 Apr 2018 16:19:59 +0200 > Hans Verkuil escreveu: > > > From: Hans Verkuil > > > > Define the public request API. > > > > This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request > > and two ioctls

Re: [RFCv11 PATCH 05/29] media-request: add request ioctls

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:02 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Implement the MEDIA_REQUEST_IOC_QUEUE and MEDIA_REQUEST_IOC_REINIT > ioctls. > > Signed-off-by: Hans Verkuil > --- > drivers/media/media-request.c | 80 > +-- > 1 file

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:01 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Implement the core of the media request processing. > > Drivers can bind request objects to a request. These objects > can then be marked completed if the driver finished using them, > or just be unbound if the

Re: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-04-10 Thread Niklas Söderlund
Hi Fabrizio, On 2018-04-10 09:55:29 +, Fabrizio Castro wrote: > Dear All, > > this patch was originally sent on the 16/11/2017, and reposted a few times, > does anybody know who is supposed to take it? Hans have indicated he will take this a respin of this whole patch-set sometime next wee

RE: [PATCH v13 02/33] dt-bindings: media: rcar_vin: add device tree support for r8a774[35]

2018-04-10 Thread Fabrizio Castro
Dear All, this patch was originally sent on the 16/11/2017, and reposted a few times, does anybody know who is supposed to take it? Thanks, Fab > -Original Message- > From: Niklas Söderlund [mailto:niklas.soderlund+rene...@ragnatech.se] > Sent: 26 March 2018 22:44 > To: Laurent Pinchart

Re: [RFCv11 PATCH 03/29] media-request: allocate media requests

2018-04-10 Thread Mauro Carvalho Chehab
Em Tue, 10 Apr 2018 05:35:37 + Tomasz Figa escreveu: > Hi Hans, > > On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > [snip] > > diff --git a/drivers/media/media-request.c b/drivers/media/media-request.c > > new file mode 100644 > > index ..ead78613fdbe > > --- /dev/null > >

Re: [RFCv11 PATCH 03/29] media-request: allocate media requests

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:20:00 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Add support for allocating a new request. This is only supported > if mdev->ops->req_queue is set, i.e. the driver indicates that it > supports queueing requests. > > Signed-off-by: Hans Verkuil > --- > driver

Re: [RFCv11 PATCH 02/29] uapi/linux/media.h: add request API

2018-04-10 Thread Mauro Carvalho Chehab
Em Mon, 9 Apr 2018 16:19:59 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Define the public request API. > > This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request > and two ioctls that operate on a request in order to queue the > contents of the request to the driver a

Re: [RFCv11 PATCH 12/29] v4l2-ctrls: alloc memory for p_req

2018-04-10 Thread Tomasz Figa
Hi Hans, On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > From: Hans Verkuil > To store request data the handler_new_ref() allocates memory > for it if needed. > Signed-off-by: Hans Verkuil > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 20 > 1 file changed, 16 i

Re: [RFCv11 PATCH 05/29] media-request: add request ioctls

2018-04-10 Thread Tomasz Figa
Hi Hans, On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > From: Hans Verkuil > Implement the MEDIA_REQUEST_IOC_QUEUE and MEDIA_REQUEST_IOC_REINIT > ioctls. > Signed-off-by: Hans Verkuil > --- > drivers/media/media-request.c | 80 +-- > 1 file c

Re: [RFC PATCH]: intel-ipu3: Add uAPI documentation

2018-04-10 Thread Sakari Ailus
Hi Yong, Thanks for the patch. On Tue, Apr 03, 2018 at 07:52:25PM -0500, Yong Zhi wrote: > This is a preliminary effort to add documentation for the > following BNR(bayer noise reduction) structs: > > ipu3_uapi_bnr_static_config_wb_gains_config > ipu3_uapi_bnr_static_config_wb_gains_thr_config >

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-10 Thread Tomasz Figa
Hi Hans, On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: [snip] > +static void media_request_clean(struct media_request *req) > +{ > + struct media_request_object *obj, *obj_safe; > + > + WARN_ON(req->state != MEDIA_REQUEST_STATE_CLEANING); > + > + list_for_each_entry_safe(o