This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Sat Mar 10 05:00:13 CET 2018
media-tree git hash:e68854a2588a923b31eebce348f8020374843f8e
media_build git
Hi,
This series reworks the R-Car VIN driver to only run using its continues
capture mode. This improves performance a lot when userspace struggles
to keep up and queue buffers as fast as the VIN driver consumes them.
The solution to always be able to run in continues is to introduce a
scratc
Instead of switching capture mode depending on how many buffers are
available use a scratch buffer and always run in continuous mode. By
using a scratch buffer the responsiveness of the capture loop is
increased as it can keep running even if there are no buffers available
from userspace.
As soon
This is an error from when the driver where converted from soc-camera.
There is absolutely no gain to check the state variable two times to be
extra sure if the hardware is stopped.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-dma.c | 6 --
1 file changed, 6 delet
Before starting capturing allocate a scratch buffer which can be used by
the driver to give to the hardware if no buffers are available from
userspace. The buffer is not used in this patch but prepares for future
refactoring where the scratch buffer can be used to avoid the need to
fallback on sing
From: Laurent Pinchart
The request API allows bundling media device parameters with request
objects and applying them atomically, either synchronously or
asynchronously.
Signed-off-by: Laurent Pinchart
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 366
Implement poll for events. POLLPRI is used to notify the user an event is
complete.
Signed-off-by: Sakari Ailus
---
drivers/media/media-device.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
index 41
Maintain a list of supported IOCTL argument sizes and allow only those in
the list.
As an additional bonus, IOCTL handlers will be able to check whether the
caller actually set (using the argument size) the field vs. assigning it
to zero. Separate macro can be provided for that.
This will be easi
From: Hans Verkuil
When queuing buffers allow for passing the request that should
be associated with this buffer.
Signed-off-by: Hans Verkuil
[acour...@chromium.org: make request ID 32-bit]
Signed-off-by: Alexandre Courbot
[Sakari Ailus: requests fds are int; use assign_in_user in get_v4l2_buf
Hi folks,
This preliminary RFC patchset prepares for the request API. What's new
here is support for binding arbitrary configuration or resources to
requests.
There are a few new concepts here:
Class --- a type of configuration or resource a driver (or e.g. the V4L2
framework) can attach to a re
Media requests may contain multiple objects (e.g. V4L2 format or video
buffers). The media request objects support managing these in a generic
way. The classes are effectively a helper for managing certain kinds of
objects.
Objects may be sticky (the previous configuration matters, e.g. V4L2
forma
From: Alexandre Courbot
Allow to specify a request to be used with the S_EXT_CTRLS and
G_EXT_CTRLS operations.
Signed-off-by: Alexandre Courbot
[Sakari Ailus: reserved no longer an array, add compat32 code]
Signed-off-by: Sakari Ailus
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 9
The atomisp driver used to use the reserved2 field in struct v4l2_buffer
for picking a particular ISP configuration for the buffer. As reserved2
field will have new use soon, remove this hack.
Signed-off-by: Sakari Ailus
---
.../staging/media/atomisp/pci/atomisp2/atomisp_ioctl.c | 17 +++---
Associate a buffer to a request when it is queued and disassociate when it
is done.
Signed-off-by: Sakari Ailus
---
drivers/media/common/videobuf2/videobuf2-core.c | 43 -
drivers/media/common/videobuf2/videobuf2-v4l2.c | 24 +-
include/media/videobuf2-core.h
The kernel provides a __packed definition to abstract away from the
compiler specific attributes tag.
Convert all packed structures in VSP1 to use it.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display
list chain referencing the nodes as children, when in reality they are
siblings.
Update the terminology to 'dl_next' to be consistent with the
vsp1_video_pipeline_run() usage.
Signed-off-by: Kieran Bingham
---
drivers/media/pl
The pixel format is 'unsupported'. Fix the small debug message which
incorrectly declares this.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_drm.c
b/drivers/media/pla
The VSP1 devices define their specific capabilities through features
marked in their device info structure. Various parts of the code read
this info structure to infer if the features are available.
Wrap this into a more readable vsp1_feature(vsp1, f) macro to ensure
that usage is consistent throu
Header mode display lists are now supported on all WPF outputs. To
support extended headers and auto-fld capabilities for interlaced mode
handling only header mode display lists can be used.
Disable the headerless display list configuration, and remove the dead
code.
Signed-off-by: Kieran Bingham
If there is an error allocating a display list within a DLM object
the existing display lists are not free'd, and neither is the DL body
pool.
Use the existing vsp1_dlm_destroy() function to clean up on error.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 4 +++-
1 f
The vsp1 reference in the vsp1_dl_body structure is not used.
Remove it.
Signed-off-by: Kieran Bingham
---
drivers/media/platform/vsp1/vsp1_dl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b/drivers/media/platform/vsp1/vsp1_dl.c
index 057f0f093222.
Extended display list headers allow pre and post command lists to be
executed by the VSP pipeline. This provides the base support for
features such as AUTO_FLD (for interlaced support) and AUTO_DISP (for
supporting continuous camera preview pipelines.
Signed-off-by: Kieran Bingham
---
drivers/me
Use the newly exposed VSP1 interface to enable interlaced frame support
through the VSP1 lif pipelines.
Signed-off-by: Kieran Bingham
---
drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 1 +
drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/r
VSPD and VSP-DL devices can provide extended display lists supporting
extended command display list objects.
These extended commands require their own dma memory areas for a header
and body specific to the command type.
Implement a command pool to allocate all necessary memory in a single
DMA all
Calculate the top and bottom fields for the interlaced frames and
utilise the extended display list command feature to implement the
auto-field operations. This allows the DU to update the VSP2 registers
dynamically based upon the currently processing field.
Signed-off-by: Kieran Bingham
---
dri
The Gen3 R-Car DU devices make use of the VSP to handle frame
processing.
In this series we implement support for handling interlaced pipelines
by using the auto-fld feature of the VSP hardware.
The implementation is preceded by some cleanup work and refactoring, through
patches 1 to 6. These are
From: Markus Elfring
Date: Fri, 9 Mar 2018 21:00:12 +0100
Adjust jump targets so that a bit of exception handling can be better
reused at the end of these functions.
This issue was partly detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
v3:
Laurent Pinchart and Tod
Each importer can now provide an invalidate_mappings callback.
This allows the exporter to provide the mappings without the need to pin
the backing store.
Signed-off-by: Christian König
---
drivers/dma-buf/dma-buf.c | 25 +
include/linux/dma-buf.h | 36
Instead of relying on the DRM functions just implement our own export
functions. This adds support for taking care of unpinned DMA-buf.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 1 -
drivers/gpu/drm/amd/a
Instead of relying on the DRM functions just implement our own import
functions. This adds support for taking care of unpinned DMA-buf.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 64 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 3
This set of patches adds an option invalidate_mappings callback to each DMA-buf
attachment which can be filled in by the importer.
This callback allows the exporter to provided the DMA-buf content without
pinning it. The reservation objects lock acts as synchronization point for
buffer moves an
Make sure the transfered BO is never destroy before the transfer BO.
Signed-off-by: Christian König
---
drivers/gpu/drm/ttm/ttm_bo_util.c | 50 +++
1 file changed, 30 insertions(+), 20 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c
b/drivers/gpu
Each importer can now provide an invalidate_mappings callback.
This allows the exporter to provide the mappings without the need to pin
the backing store.
Signed-off-by: Christian König
---
drivers/dma-buf/dma-buf.c | 25 +
include/linux/dma-buf.h | 36
Le vendredi 09 mars 2018 à 14:49 -0300, Gustavo Padovan a écrit :
> From: Gustavo Padovan
>
> In preparation to have full support to explicit fence we are
> marking codec as non-ordered preventively. It is easier and safer from an
The usage of "codec" is soso
> uAPI point of view to move f
On Fri, Mar 9, 2018 at 4:45 AM, Hans Verkuil wrote:
> Hi Matt,
>
> This is looking good. One request before I merge: please run the
> 'v4l2-compliance -s -f' utility and post the result here.
>
> I don't think I've asked you to do that before (or if I did, I couldn't
> find it in my mail archive).
From: Gustavo Padovan
Hi,
So v8 is finally out addressing the comments from the previous version[1].
For more info see v5 cover letter[2]. The most important points I address
here is the handling of fences that signal with error to follow Hans
suggestion. I also added V4L2_CAP_FENCES to all vb2
From: Gustavo Padovan
To better organize the code we concentrate the setting of
V4L2_CAP_STREAMING in one place.
Signed-off-by: Gustavo Padovan
---
drivers/media/platform/xilinx/xilinx-dma.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/xilin
From: Gustavo Padovan
Instead of putting V4L2_CAP_STREAMING everywhere, set device_caps
earlier with this value.
Signed-off-by: Gustavo Padovan
---
drivers/media/platform/omap3isp/ispvideo.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/oma
From: Gustavo Padovan
Explicit synchronization benefits a lot from ordered queues, they fit
better in a pipeline with DRM for example so create a opt-in way for
drivers notify videobuf2 that the queue is unordered.
Drivers don't need implement it if the queue is ordered.
v2: - improve comme
From: Gustavo Padovan
Instead of putting V4L2_CAP_STREAMING and V4L2_CAP_READWRITE
everywhere, set device_caps earlier with these values.
Signed-off-by: Gustavo Padovan
---
drivers/media/usb/hackrf/hackrf.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers
From: Gustavo Padovan
In preparation to have full support to explicit fence we are
marking codec as non-ordered preventively. It is easier and safer from an
uAPI point of view to move from unordered to ordered than the opposite.
Signed-off-by: Gustavo Padovan
---
drivers/media/platform/coda/co
From: Gustavo Padovan
For explicit synchronization it important for userspace to know if the
format being used by the driver can deliver the buffers back to userspace
in the same order they were queued with QBUF.
Ordered streams fits nicely in a pipeline with DRM for example, where
ordered buffe
From: Gustavo Padovan
Turn the reserved2 field into fence_fd that we will use to send
an in-fence to the kernel or return an out-fence from the kernel to
userspace.
Two new flags were added, V4L2_BUF_FLAG_IN_FENCE, that should be used
when sending a fence to the kernel to be waited on, and
V4L2_
From: Gustavo Padovan
Drivers capable of using fences (vb2 drivers) should report the
V4L2_CAP_FENCES to userspace, so add this flag to the uapi.
Signed-off-by: Gustavo Padovan
---
Documentation/media/uapi/v4l/vidioc-querycap.rst | 3 +++
include/uapi/linux/videodev2.h | 1 +
From: Gustavo Padovan
Receive in-fence from userspace and add support for waiting on them
before queueing the buffer to the driver. Buffers can't be queued to the
driver before its fences signal. And a buffer can't be queue to the driver
out of the order they were queued from userspace. That mean
From: Gustavo Padovan
Drivers that use videobuf2 are capable of using fences and
should report that to userspace.
The coding style is following what each drivers was already
doing.
Signed-off-by: Gustavo Padovan
---
drivers/media/pci/cobalt/cobalt-v4l2.c | 3 ++-
drivers/media/pci
From: Gustavo Padovan
If V4L2_BUF_FLAG_OUT_FENCE flag is present on the QBUF call we create
an out_fence and send its fd to userspace on the fence_fd field as a
return arg for the QBUF call.
The fence is signaled on buffer_done(), when the job on the buffer is
finished.
v9: - remove in-fenc
From: Gustavo Padovan
Add section to VIDIOC_QBUF and VIDIOC_QUERY_BUF about it
v6: - Close some gaps in the docs (Hans)
v5:
- Remove V4L2_CAP_ORDERED
- Add doc about V4L2_FMT_FLAG_UNORDERED
v4:
- Document ordering behavior for in-fences
- Document V4L2_CAP_O
From: Gustavo Padovan
The cobalt driver may reorder the capture buffers so we need to report
it as such.
v2: - use vb2_ops_set_unordered() helper
Signed-off-by: Gustavo Padovan
---
drivers/media/pci/cobalt/cobalt-v4l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/pci/cob
Hi Hans,
On 03/09/2018 04:57 AM, Hans Verkuil wrote:
Hi Steve,
I understand there will be a v2 of this series?
Yes. I'm mulling what to do about the empty endpoints issue.
My initial thought was to modify the i.mx6 DTS to remove the
empty endpoints in the video-mux input ports, which would a
On 09/03/18 18:07, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your feedback.
>
> On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote:
>> On 09/03/18 17:17, Niklas Söderlund wrote:
>>> Hi Hans,
>>>
>>> Thanks for your feedback, I don't think I can appreciate how happy I'm
>>> that you reviewe
Hi Hans,
Thanks for your feedback.
On 2018-03-09 17:28:39 +0100, Hans Verkuil wrote:
> On 09/03/18 17:17, Niklas Söderlund wrote:
> > Hi Hans,
> >
> > Thanks for your feedback, I don't think I can appreciate how happy I'm
> > that you reviewed this patch-set, Thank you!
>
> You're welcome!
>
The soc-camera framework is deprecated, patches for it are very rare
and only contain trivial clean up. Further I haven't got any more
soc-camera systems running modern kernels.
Signed-off-by: Guennadi Liakhovetski
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --g
On 09/03/18 17:17, Niklas Söderlund wrote:
> Hi Hans,
>
> Thanks for your feedback, I don't think I can appreciate how happy I'm
> that you reviewed this patch-set, Thank you!
You're welcome!
>
> On 2018-03-09 16:25:23 +0100, Hans Verkuil wrote:
>> On 07/03/18 23:04, Niklas Söderlund wrote:
>>
Hi Hans,
Thanks for your feedback, I don't think I can appreciate how happy I'm
that you reviewed this patch-set, Thank you!
On 2018-03-09 16:25:23 +0100, Hans Verkuil wrote:
> On 07/03/18 23:04, Niklas Söderlund wrote:
> > If the field is not supported by the driver it should not try to keep
>
Show the UCB error counts via DVBv5.
Please notice that there's no scale indication at the driver.
As we don't have the datasheet, let's assume that it is receiving
data at a rate of 10.000 packets per second. Ideally, this should
be read or estimated.
In order to avoid flooding I2C bus with data
The following changes since commit 3f127ce11353fd1071cae9b65bc13add6aec6b90:
media: em28xx-cards: fix em28xx_duplicate_dev() (2018-03-08 06:06:51 -0500)
are available in the Git repository at:
git://linuxtv.org/hverkuil/media_tree.git for-v4.17c
for you to fetch changes up to 579f4f639b7507
Hi Sean,
On Thu, Mar 08, 2018 at 04:43:27PM +, Sean Young wrote:
> On Tue, Mar 06, 2018 at 06:41:22PM +0100, Matthias Reichl wrote:
> > Meson doesn't seem to be able to generate timeout events
> > in hardware. So install a software timer to generate the
> > timeout events required by the decod
Change the logic at the driver to provide CNR stats via
DVBv5 API.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 47 +-
1 file changed, 40 insertions(+), 7 deletions(-)
diff --git a/drivers/media/dvb-frontends/lgdt330x.c
b/dri
In preparation to implement DVBv5 stats on this driver, move
the *read_status functions to happen after SNR and signal
strength routines.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 255 +
1 file changed, 128 insertions(+), 12
Cleanup the usecases of dprintk() by using pr_fmt() and replace
printk by pr_foo().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 64 ++
1 file changed, 34 insertions(+), 30 deletions(-)
diff --git a/drivers/media/dvb-frontends
It is useful to know if the driver load succeded. So,
add a printk info there.
While here, improve the .init debug printed message.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/med
Convert the driver to allow its usage with the new I2C
binding way.
Please notice that this patch doesn't convert the
callers to bind to it using the new way.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/common/b2c2/flexcop-fe-tuner.c | 4 +-
drivers/media/dvb-frontends/lgdt330x.c
Change the lgdt330x_config documentation to use kernel-doc
style.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.h | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/media/dvb-frontends/lg
Show the UCB error counts via DVBv5.
Please notice that there's no scale indication at the driver.
As we don't have the datasheet, let's assume that it is receiving
data at a rate of 10.000 packets per second. Ideally, this should
be read or estimated.
In order to avoid flooding I2C bus with data
Simplify a few ifs there.
While here, add debug messages for the 8-vsb and qam log status
flags.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/dvb-frontends/lgdt3
This routine does nothing. Remove it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/media/dvb-frontends/lgdt330x.c
b/drivers/media/dvb-frontends/lgdt330x.c
index 75b9ae6583e8..b430b0500f12 10064
As we're about to convert this driver to use the new i2c
binding way, let's first solve most coding style issues,
in order to avoid mixing coding style changes with code
changes.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/lgdt330x.c | 358 +++
There are several register init arrays there that can be
constified.
The change reduced a little bit the amount of initialized
data:
textdata bss dec hex filename
6372 360 467361a50
old/drivers/media/dvb-frontends/lgdt330x.o
6500 264 46768
On 07/03/18 23:05, Niklas Söderlund wrote:
> Add the SoC specific information for Renesas r8a77970.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 23 +
On 07/03/18 23:05, Niklas Söderlund wrote:
> Add the SoC specific information for Renesas r8a7796.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/rcar-core.c | 44
> +++
On 07/03/18 23:05, Niklas Söderlund wrote:
> Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/platform/rcar-vin/Kconfig | 2 +
On 07/03/18 23:05, Niklas Söderlund wrote:
> The procedure to start or stop streaming using the non-MC single
> subdevice and the MC graph and multiple subdevices are quite different.
> Create a new function to abstract which method is used based on which
> mode the driver is running in and add log
On 07/03/18 23:05, Niklas Söderlund wrote:
> Add the ability to process media device link change requests. Link
> enabling is a bit complicated on Gen3, whether or not it's possible to
> enable a link depends on what other links already are enabled. On Gen3
> the 8 VINs are split into two subgroup'
On 07/03/18 23:05, Niklas Söderlund wrote:
> The parsing and registering CSI-2 subdevices with the v4l2 async
> framework is a collaborative effort shared between the VIN instances
> which are part of the group. When the last VIN in the group is probed it
> asks all other VINs to parse its share of
On 07/03/18 23:04, Niklas Söderlund wrote:
> On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One
> feature of this register is that it's only present in the VIN0 and VIN4
> instances. The register in VIN0 controls the routing for VIN0-3 and the
> register in VIN4 controls routin
On 07/03/18 23:05, Niklas Söderlund wrote:
> Each Gen3 SoC has a limited set of predefined routing possibilities for
> which CSI-2 device and channel can be routed to which VIN instance.
> Prepare to store this information in the struct rvin_info.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by:
On 07/03/18 23:05, Niklas Söderlund wrote:
> The rcar-vin driver needs to be part of a media controller to support
> Gen3. Give each VIN instance a unique name so it can be referenced from
> userspace.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchart
Reviewed-by: Hans Verkuil
On 07/03/18 23:05, Niklas Söderlund wrote:
> In media controller mode all VIN instances needs to be part of the same
> media graph. There is also a need for each VIN instance to know about
> and in some cases be able to communicate with other VIN instances.
>
> Add an allocator framework where the
On 07/03/18 23:05, Niklas Söderlund wrote:
> The V4L2 specification clearly documents the colorspace fields as being
> set by drivers for capture devices. Using the values supplied by
> userspace thus wouldn't comply with the API. Until the API is updated to
> allow for userspace to set these Hans
On 07/03/18 23:04, Niklas Söderlund wrote:
> At stream on time the driver should not query the subdevice for which
> standard are used. Instead it should be cached when userspace sets the
> standard and used at stream on time.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Regar
On Thu, Feb 15, 2018 at 02:33:33PM +0100, Maxime Ripard wrote:
> Hi,
>
> Here is another attempt at supporting the MIPI-CSI2 RX block from
> Cadence.
>
> This IP block is able to receive CSI data over up to 4 lanes, and
> split it to over 4 streams. Those streams are basically the interfaces
> to
On 07/03/18 23:04, Niklas Söderlund wrote:
> With the recent cleanup of the format code to prepare for Gen3 it's
> possible to simplify the Gen2 format code path as well. Clean up the
> process by defining two functions to handle the set format and reset of
> format when the standard is changed.
>
On 07/03/18 23:04, Niklas Söderlund wrote:
> Part of the format alignment and checking can be shared with the Gen3
> format handling. Break that part out to a separate function.
>
> Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Hans
> ---
> drivers/media/platform/rcar-vin
On 07/03/18 23:04, Niklas Söderlund wrote:
> If the pixelformat is not supported it should not fail but be set to
> something that works. While we are at it move the two different
> checks of the pixelformat to the same statement.
>
> Signed-off-by: Niklas Söderlund
> Reviewed-by: Laurent Pinchar
On 07/03/18 23:04, Niklas Söderlund wrote:
> Remove over complicated logic to calculate the value for bytesperline
> and sizeimage that was carried over from the soc_camera port. There is
> no need to find the max value of bytesperline and sizeimage from
> user-space as they are set to 0 before the
On 07/03/18 23:04, Niklas Söderlund wrote:
> There was never proper support in the VIN driver to deliver ALTERNATING
> field format to user-space, remove this field option. The problem is
> that ALTERNATING field order requires the sequence numbers of buffers
> returned to userspace to reflect if f
On 07/03/18 23:04, Niklas Söderlund wrote:
> If the field is not supported by the driver it should not try to keep
> the current field. Instead it should set it to a default fallback. Since
> trying a format should always result in the same state regardless of the
> current state of the device.
>
On 07/03/18 23:04, Niklas Söderlund wrote:
> In preparation for Gen3 support move the subdevice initialization and
> clean up from rvin_v4l2_{register,unregister}() directly to the async
> callbacks. This simplifies the addition of Gen3 support as the
> rvin_v4l2_register() can be shared for both G
Hi,
On Thu, 2018-03-08 at 22:48 +0900, Alexandre Courbot wrote:
> Hi Paul!
>
> Thanks a lot for taking the time to try this! I am also working on
> getting it to work with an actual driver, but you apparently found
> rough edges that I missed.
>
> On Thu, Mar 8, 2018 at 1:37 AM, Paul Kocialkowsk
Hi,
On Fri, 2018-03-09 at 14:57 +0100, Maxime Ripard wrote:
> Hi,
>
> On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote:
> > +/*
> > + * mem2mem callbacks
> > + */
> > +
> > +void job_abort(void *priv)
> > +{}
>
> Is that still needed?
It looks like we need a dummy callback here
Hi Jacob,
This is getting very close. Besides this round of review comments the main
blocker is mbus_config. But Thomasz is looking at that, so I will wait until
that is resolved.
Also for your v7 include the patches from Sakari that add Meta Output support.
This patch series relies on those, so
On 08/03/18 10:47, Jacob Chen wrote:
> From: Jacob Chen
>
> This is the capture device interface driver that provides the v4l2
> user interface. Frames can be received from ISP1.
>
> Signed-off-by: Jacob Chen
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Yichong Zhong
> Signed-off-by: Jaco
On 08/03/18 10:47, Jacob Chen wrote:
> From: Jacob Chen
>
> Add the output video driver that accept params from userspace.
>
> Signed-off-by: Jacob Chen
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Yichong Zhong
> Signed-off-by: Jacob Chen
> Signed-off-by: Eddie Cai
> Signed-off-by: Jef
On 08/03/18 10:47, Jacob Chen wrote:
> From: Jacob Chen
>
> Add the capture video driver for rockchip isp1 statistics block.
>
> Signed-off-by: Jacob Chen
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Yichong Zhong
> Signed-off-by: Jacob Chen
> Signed-off-by: Eddie Cai
> Signed-off-by: J
On 08/03/18 10:47, Jacob Chen wrote:
> From: Jacob Chen
>
> Add the subdev driver for rockchip isp1.
>
> Signed-off-by: Jacob Chen
> Signed-off-by: Shunqian Zheng
> Signed-off-by: Yichong Zhong
> Signed-off-by: Jacob Chen
> Signed-off-by: Eddie Cai
> Signed-off-by: Jeffy Chen
> Signed-off-
Hi,
On Fri, Mar 09, 2018 at 11:14:41AM +0100, Paul Kocialkowski wrote:
> +/*
> + * mem2mem callbacks
> + */
> +
> +void job_abort(void *priv)
> +{}
Is that still needed?
> +/*
> + * device_run() - prepares and starts processing
> + */
> +void device_run(void *priv)
> +{
This function (and the o
On Fri, Mar 09, 2018 at 11:14:42AM +0100, Paul Kocialkowski wrote:
> From: Florent Revest
>
> Device Tree bindings for the Allwinner's video engine
>
> Signed-off-by: Florent Revest
> ---
> .../devicetree/bindings/media/sunxi-cedrus.txt | 44
> ++
> 1 file changed, 44
Hi,
Thanks for the review!
On Fri, 2018-03-09 at 15:38 +0200, Priit Laes wrote:
> On Fri, Mar 09, 2018 at 11:14:42AM +0100, Paul Kocialkowski wrote:
> > From: Florent Revest
> >
> > Device Tree bindings for the Allwinner's video engine
> >
> > Signed-off-by: Florent Revest
> > ---
> > .../de
On 08/03/18 10:47, Jacob Chen wrote:
> From: Jacob Chen
>
> This commit add docuemnt for rkisp1 meta buffer format
>
> Signed-off-by: Jacob Chen
> Acked-by: Hans Verkuil
> ---
> Documentation/media/uapi/v4l/meta-formats.rst| 2 ++
> .../media/uapi/v4l/pixfmt-meta-rkisp1-params.rst
1 - 100 of 136 matches
Mail list logo
