Hi Laurent,
Any update on this?
Thanks
Guennadi
On Wed, 13 Dec 2017, Guennadi Liakhovetski wrote:
> This is an update of the two patches, adding asynchronous control
> support to the uvcvideo driver. If a control is sent, while the camera
> is still processing an earlier control, it will genera
On 02/06/2018 08:16 AM, Tim Harvey wrote:
> On Sat, Feb 3, 2018 at 7:56 AM, Hans Verkuil wrote:
>> Hi Tim, Jacopo,
>>
>> I have now finished writing the v4l2-compliance tests for the various
>> v4l-subdev
>> ioctls. I managed to test some with the vimc driver, but that doesn't
>> implement all
>
On Sat, Feb 3, 2018 at 7:56 AM, Hans Verkuil wrote:
> Hi Tim, Jacopo,
>
> I have now finished writing the v4l2-compliance tests for the various
> v4l-subdev
> ioctls. I managed to test some with the vimc driver, but that doesn't
> implement all
> ioctls, so I could use some help testing my test
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Feb 6 05:00:24 CET 2018
media-tree git hash:273caa260035c03d89ad63d72d8cd3d9e5c5e3f1
media_build git
Adopt SPDX license headers and update year to 2018.
Signed-off-by: Yong Zhi
---
drivers/media/pci/intel/ipu3/ipu3-cio2.c | 12 ++--
drivers/media/pci/intel/ipu3/ipu3-cio2.h | 14 ++
2 files changed, 4 insertions(+), 22 deletions(-)
diff --git a/drivers/media/pci/intel/ipu3/i
Hi Hans,
Quoting Hans Verkuil :
On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote:
Add suffix ULL to constant 10 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
u64 (64 bits
Hi Mauro and Hans,
On Mon, Feb 05, 2018 at 02:32:28PM -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 5 Feb 2018 16:19:28 +0100
> Hans Verkuil escreveu:
>
> > On 02/05/2018 03:30 PM, Sakari Ailus wrote:
> > > Hi Hans,
> > >
> > > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote:
> >
Hi Hans,
On Mon, Feb 05, 2018 at 04:19:28PM +0100, Hans Verkuil wrote:
> On 02/05/2018 03:30 PM, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote:
> >> On 02/05/2018 12:59 PM, Sakari Ailus wrote:
> >>> Hi Hans,
> >>>
> >>> On Mon, Feb 05, 2018
On 02/05/2018 10:36 PM, Florian Echtler wrote:
> Hello Hans,
>
> On Mon, 5 Feb 2018, Hans Verkuil wrote:
>> On 02/05/2018 03:29 PM, Florian Echtler wrote:
>>> +
>>> +static int sur40_vidioc_queryctrl(struct file *file, void *fh,
>>> + struct v4l2_queryctrl *qc)
>>
>> Sorry
Hello Hans,
On Mon, 5 Feb 2018, Hans Verkuil wrote:
On 02/05/2018 03:29 PM, Florian Echtler wrote:
+
+static int sur40_vidioc_queryctrl(struct file *file, void *fh,
+ struct v4l2_queryctrl *qc)
Sorry, but this is very wrong. Use the control framework instead. See
On 02/05/2018 09:36 PM, Gustavo A. R. Silva wrote:
> Add suffix ULL to constant 10 in order to give the compiler complete
> information about the proper arithmetic to use. Notice that this
> constant is used in a context that expects an expression of type
> u64 (64 bits, unsigned).
>
> The express
Add suffix ULL to constant 10 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
u64 (64 bits, unsigned).
The expression len * 10 * CEC_TIM_DATA_BIT_TOTAL is currently being
evalua
Cast left and top to dma_addr_t in order to give the compiler complete
information about the proper arithmetic to use. Notice that these
variables are being used in contexts that expect expressions of
type dma_addr_t (64 bit, unsigned).
Such expressions are currently being evaluated using 32-bit a
Cast p to dma_addr_t in order to avoid a potential integer overflow.
This variable is being used in a context that expects an expression
of type dma_addr_t (u64).
The expression p << PAGE_SHIFT is currently being evaluated
using 32-bit arithmetic.
Addresses-Coverity-ID: 1458347
Signed-off-by: Gus
Add suffix ULL to constant 10 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
u64 (64 bits, unsigned).
The expression fpxin = state->config->xin * 10 is currently being
evaluate
Add suffix LL to constant 100 in order to give the compiler
complete information about the proper arithmetic to use. Notice
that this constant is used in a context that expects an expression
of type ktime_t (64 bits, signed).
The expression ir->polling * 100 is currently being evaluated
us
Due to a typo, the mask was destroyed by a comparison instead of a bit
shift.
Signed-off-by: Wolfram Sang
---
Only build tested. To be applied individually per subsystem.
drivers/media/dvb-frontends/stb0899_reg.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/driver
Due to a typo, the mask was destroyed by a comparison instead of a bit
shift. No regression since the mask has not been used yet.
Signed-off-by: Wolfram Sang
---
Only build tested. To be applied individually per subsystem.
drivers/media/platform/vsp1/vsp1_regs.h | 2 +-
1 file changed, 1 insert
In one Renesas driver, I found a typo which turned an intended bit shift ('<<')
into a comparison ('<'). Because this is a subtle issue, I looked tree wide for
similar patterns. This small patch series is the outcome.
Buildbot and checkpatch are happy. Only compile-tested. To be applied
individual
Add suffix ULL to constants 1 and 100 in order to give the
compiler complete information about the proper arithmetic to use.
Notice that these constants are used in contexts that expect
expressions of type u64 (64 bits, unsigned).
The following expressions:
(u64)(fi->interval.numerator *
Add suffix LL to constant 2 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
s64 (64 bits, signed).
The expression 2 * (clock_rate - abs_nco_freq) is currently being
evaluated us
Add suffix ULL to constant 7 in order to give the compiler complete
information about the proper arithmetic to use. Notice that this
constant is used in a context that expects an expression of type
u64 (64 bits, unsigned).
The expression dev->pdata->clk * 7 is currently being evaluated
using 32-bi
Add suffix LL and ULL to various constants in order to give the compiler
complete information about the proper arithmetic to use. Such constants
are used in contexts that expect expressions of type u64 (64 bits, unsigned)
and s64 (64 bits, signed).
The mentioned expressions are currently being eva
Em Mon, 5 Feb 2018 18:01:34 +0100
Hans Verkuil escreveu:
> On 02/05/2018 05:59 PM, Hans Verkuil wrote:
> > On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote:
> >> Em Mon, 5 Feb 2018 14:37:29 -0200
> >> Mauro Carvalho Chehab escreveu:
> >>
> >>> Em Mon, 5 Feb 2018 08:21:54 -0800
> >>> Tim H
On 02/05/2018 05:59 PM, Hans Verkuil wrote:
> On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote:
>> Em Mon, 5 Feb 2018 14:37:29 -0200
>> Mauro Carvalho Chehab escreveu:
>>
>>> Em Mon, 5 Feb 2018 08:21:54 -0800
>>> Tim Harvey escreveu:
>>>
Hans,
I'm failing compile (of master 4ee9
On 02/05/2018 05:55 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 5 Feb 2018 14:37:29 -0200
> Mauro Carvalho Chehab escreveu:
>
>> Em Mon, 5 Feb 2018 08:21:54 -0800
>> Tim Harvey escreveu:
>>
>>> Hans,
>>>
>>> I'm failing compile (of master 4ee9911) with:
>>>
>>> CXX v4l2_compliance-media-in
On 02/05/2018 05:37 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 5 Feb 2018 08:21:54 -0800
> Tim Harvey escreveu:
>
>> Hans,
>>
>> I'm failing compile (of master 4ee9911) with:
>>
>> CXX v4l2_compliance-media-info.o
>> media-info.cpp: In function ‘media_type media_detect_type(const char*)’:
Em Mon, 5 Feb 2018 14:37:29 -0200
Mauro Carvalho Chehab escreveu:
> Em Mon, 5 Feb 2018 08:21:54 -0800
> Tim Harvey escreveu:
>
> > Hans,
> >
> > I'm failing compile (of master 4ee9911) with:
> >
> > CXX v4l2_compliance-media-info.o
> > media-info.cpp: In function ‘media_type media_dete
On Mon, Feb 5, 2018 at 8:27 AM, Hans Verkuil wrote:
> On 02/05/2018 05:21 PM, Tim Harvey wrote:
>
>
>
>>
>> I ran a 'make distclean; ./bootstrap.sh && ./configure && make'
>>
>> last version I built successfully was '1bb8c70 v4l2-ctl: mention that
>> --set-subdev-fps is for testing only'
>
> That
Em Mon, 5 Feb 2018 08:21:54 -0800
Tim Harvey escreveu:
> Hans,
>
> I'm failing compile (of master 4ee9911) with:
>
> CXX v4l2_compliance-media-info.o
> media-info.cpp: In function ‘media_type media_detect_type(const char*)’:
> media-info.cpp:79:39: error: no matching function for call to
Em Mon, 5 Feb 2018 16:19:28 +0100
Hans Verkuil escreveu:
> On 02/05/2018 03:30 PM, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote:
> >> On 02/05/2018 12:59 PM, Sakari Ailus wrote:
> >>> Hi Hans,
> >>>
> >>> On Mon, Feb 05, 2018 at 11:26:
On 02/05/2018 05:21 PM, Tim Harvey wrote:
>
> I ran a 'make distclean; ./bootstrap.sh && ./configure && make'
>
> last version I built successfully was '1bb8c70 v4l2-ctl: mention that
> --set-subdev-fps is for testing only'
That's a lot of revisions ago. I've been busy last weekend :-)
Do a
On Sat, Feb 3, 2018 at 7:56 AM, Hans Verkuil wrote:
> Hi Tim, Jacopo,
>
> I have now finished writing the v4l2-compliance tests for the various
> v4l-subdev
> ioctls. I managed to test some with the vimc driver, but that doesn't
> implement all
> ioctls, so I could use some help testing my test
On 02/05/2018 03:30 PM, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote:
>> On 02/05/2018 12:59 PM, Sakari Ailus wrote:
>>> Hi Hans,
>>>
>>> On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote:
The function media_device_enum_entities()
On 02/05/2018 03:29 PM, Florian Echtler wrote:
> Signed-off-by: Florian Echtler
Please add a change log when you make a patch.
I for one would like to know why this has to be supplied as a module option.
Some documentation in the code would be helpful as well (e.g. I have no idea
what a 'vsvideo
On 02/05/2018 03:29 PM, Florian Echtler wrote:
> Signed-off-by: Florian Echtler
> ---
> drivers/input/touchscreen/sur40.c | 114
> ++
> 1 file changed, 114 insertions(+)
>
> diff --git a/drivers/input/touchscreen/sur40.c
> b/drivers/input/touchscreen/sur40.c
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 114 ++
1 file changed, 114 insertions(+)
diff --git a/drivers/input/touchscreen/sur40.c
b/drivers/input/touchscreen/sur40.c
index 63c7264b..c4b7cf1 100644
--- a/drivers/input/touchscreen/
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 70 +++
1 file changed, 70 insertions(+)
diff --git a/drivers/input/touchscreen/sur40.c
b/drivers/input/touchscreen/sur40.c
index 0dbb004..63c7264b 100644
--- a/drivers/input/touchscreen/s
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/input/touchscreen/sur40.c
b/drivers/input/touchscreen/sur40.c
index c4b7cf1..d612f3f 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/drivers/input/
The SUR40 (aka Pixelsense) has internal registers that expose sensor
parameters such as brightness, gain etc. This patch creates V4L2
control items and maps them to the appropriate parameters.
This is an initial submission for review, comments welcome!
Best regards, Florian
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/sur40.c
b/drivers/input/touchscreen/sur40.c
index f16f835..8375b06 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/drivers/i
Signed-off-by: Florian Echtler
---
drivers/input/touchscreen/sur40.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/input/touchscreen/sur40.c
b/drivers/input/touchscreen/sur40.c
index 8375b06..0dbb004 100644
--- a/drivers/input/touchscreen/sur40.c
+++ b/dri
Hi Sakari,
I tried this patch, and I no longer see the messages in dmesg output
when closing the V4L2 device node.
Tested-by: Devin Heitmueller
Thanks,
Devin
On Fri, Feb 2, 2018 at 8:57 AM, Devin Heitmueller
wrote:
> Hello Sakari,
>
> Thanks for proposing this patch. I'll give it a try this
Hi Hans,
On Mon, Feb 05, 2018 at 01:30:04PM +0100, Hans Verkuil wrote:
> On 02/05/2018 12:59 PM, Sakari Ailus wrote:
> > Hi Hans,
> >
> > On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote:
> >> The function media_device_enum_entities() has this workaround:
> >>
> >> /*
> >>
Em Mon, 5 Feb 2018 14:47:51 +0100
Hans Verkuil escreveu:
> On 02/05/2018 02:17 PM, Mauro Carvalho Chehab wrote:
> > Em Mon, 5 Feb 2018 12:55:21 +0100
> > Hans Verkuil escreveu:
> >
> >> On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote:
> >>> Hi Hans,
> >>>
> >>> Em Sun, 4 Feb 2018 14:06:
On Mon, Feb 05, 2018 at 11:42:11AM +, Fabrizio Castro wrote:
> Hello Maxime,
>
> thank you for your feedback.
>
> > > > +/*
> > > > + * configure parallel port control lines polarity
> > > > + *
> > > > + * POLARITY CTRL0
> > > > + * - [5]:PCLK polarity (0: active low, 1: active high)
> > > >
On Mon, 05 Feb 2018 09:47:46 +0100
Marek Szyprowski wrote:
> Hi Masami,
>
> On 2018-02-05 03:30, Masami Hiramatsu wrote:
> > Fixes vb2_vmalloc_get_userptr() to ioremap correct area.
> > Since the current code does ioremap the page address, if the offset > 0,
> > it does not do ioremap the last p
On 02/05/2018 02:17 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 5 Feb 2018 12:55:21 +0100
> Hans Verkuil escreveu:
>
>> On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote:
>>> Hi Hans,
>>>
>>> Em Sun, 4 Feb 2018 14:06:42 +0100
>>> Hans Verkuil escreveu:
>>>
Hi Mauro,
I'm workin
Em Mon, 5 Feb 2018 13:42:48 +0100
Hans Verkuil escreveu:
> On 02/05/2018 01:39 PM, Mauro Carvalho Chehab wrote:
> > Em Sun, 4 Feb 2018 14:53:31 +0100
> > Hans Verkuil escreveu:
> >
> >> Userspace has no way of knowing the pad index for the entity that
> >> owns the pad with the MEDIA_IOC_G_TO
Em Mon, 5 Feb 2018 12:38:29 +0100
Hans Verkuil escreveu:
> On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote:
> > Hi Hans,
> >
> > Em Sun, 4 Feb 2018 14:06:42 +0100
> > Hans Verkuil escreveu:
> >
> >> Hi Mauro,
> >>
> >> I'm working on adding proper compliance tests for the MC but I think
Em Mon, 5 Feb 2018 12:55:21 +0100
Hans Verkuil escreveu:
> On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote:
> > Hi Hans,
> >
> > Em Sun, 4 Feb 2018 14:06:42 +0100
> > Hans Verkuil escreveu:
> >
> >> Hi Mauro,
> >>
> >> I'm working on adding proper compliance tests for the MC but I think
From: Alona Solntseva
Misspelled words are fixed in several places.
Signed-off-by: Alona Solntseva
---
.../staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css240
On 02/05/2018 01:39 PM, Mauro Carvalho Chehab wrote:
> Em Sun, 4 Feb 2018 14:53:31 +0100
> Hans Verkuil escreveu:
>
>> Userspace has no way of knowing the pad index for the entity that
>> owns the pad with the MEDIA_IOC_G_TOPOLOGY ioctl. However, various
>> v4l-subdev ioctls need to pass this as
Em Sun, 4 Feb 2018 14:53:31 +0100
Hans Verkuil escreveu:
> Userspace has no way of knowing the pad index for the entity that
> owns the pad with the MEDIA_IOC_G_TOPOLOGY ioctl. However, various
> v4l-subdev ioctls need to pass this as an argument.
While I'm OK on adding a pad index, it still mis
On 02/05/2018 12:59 PM, Sakari Ailus wrote:
> Hi Hans,
>
> On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote:
>> The function media_device_enum_entities() has this workaround:
>>
>> /*
>> * Workaround for a bug at media-ctl <= v1.10 that makes it to
>> * do the
Em Sun, 04 Feb 2018 15:20:55 +0200
Laurent Pinchart escreveu:
> Hi Hans,
>
> On Sunday, 4 February 2018 15:16:26 EET Hans Verkuil wrote:
> > On 02/04/2018 02:13 PM, Laurent Pinchart wrote:
> > > On Sunday, 4 February 2018 15:06:42 EET Hans Verkuil wrote:
> > >> Hi Mauro,
> > >>
> > >> I'm w
Hi Andy,
On Thu, Feb 01, 2018 at 11:48:12PM +0800, Andy Yeh wrote:
> From: Alan Chiang
>
> Dongwoon DW9807 is a voice coil lens driver.
>
> Also add a vendor prefix for Dongwoon for one did not exist previously.
>
> Signed-off-by: Andy Yeh
Could you send DT binding patches to the devicetree
Hi Hans,
On Mon, Feb 05, 2018 at 11:26:47AM +0100, Hans Verkuil wrote:
> The function media_device_enum_entities() has this workaround:
>
> /*
> * Workaround for a bug at media-ctl <= v1.10 that makes it to
> * do the wrong thing if the entity function doesn't belong to
On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote:
> Hi Hans,
>
> Em Sun, 4 Feb 2018 14:06:42 +0100
> Hans Verkuil escreveu:
>
>> Hi Mauro,
>>
>> I'm working on adding proper compliance tests for the MC but I think
>> something
>> is missing in the G_TOPOLOGY ioctl w.r.t. pads.
>>
>> In sever
Hello Maxime,
thank you for your feedback.
> > > +/*
> > > + * configure parallel port control lines polarity
> > > + *
> > > + * POLARITY CTRL0
> > > + * - [5]:PCLK polarity (0: active low, 1: active high)
> > > + * - [1]:HREF polarity (0: active low, 1: active high)
> > > + * - [0]:VSYNC polari
On 02/05/2018 12:15 PM, Mauro Carvalho Chehab wrote:
> Hi Hans,
>
> Em Sun, 4 Feb 2018 14:06:42 +0100
> Hans Verkuil escreveu:
>
>> Hi Mauro,
>>
>> I'm working on adding proper compliance tests for the MC but I think
>> something
>> is missing in the G_TOPOLOGY ioctl w.r.t. pads.
>>
>> In sever
Hi Andy,
On Thu, Feb 01, 2018 at 11:47:46PM +0800, Andy Yeh wrote:
> From: Alan Chiang
>
> Hi Sakari and Tomasz,
>
> The two patches are the DT binding and driver for DW9807 VCM controller.
Thanks for the update.
Next time when you're sending a patchset, could you send the patches
together ra
Since this patch is hard to read, here is the 'post-patch' header:
cut here --
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
/*
* Multimedia device API
*
* Copyright (C) 2010 Nokia Corporation
*
* Contacts: Laurent Pinchart
*
The media.h public header is very messy. It mixes legacy and 'new' defines
and it is not easy to figure out what should and what shouldn't be used. It
also contains confusing comment that are either out of date or completely
uninteresting for anyone that needs to use this header.
The patch groups
Hi Hans,
Em Sun, 4 Feb 2018 14:06:42 +0100
Hans Verkuil escreveu:
> Hi Mauro,
>
> I'm working on adding proper compliance tests for the MC but I think something
> is missing in the G_TOPOLOGY ioctl w.r.t. pads.
>
> In several v4l-subdev ioctls you need to pass the pad. There the pad is an
> i
The function media_device_enum_entities() has this workaround:
/*
* Workaround for a bug at media-ctl <= v1.10 that makes it to
* do the wrong thing if the entity function doesn't belong to
* either MEDIA_ENT_F_OLD_BASE or MEDIA_ENT_F_OLD_SUBDEV_BASE
* R
Subdevs are initialized with MEDIA_ENT_F_V4L2_SUBDEV_UNKNOWN, not
MEDIA_ENT_T_V4L2_SUBDEV_UNKNOWN.
Signed-off-by: Hans Verkuil
---
diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index b9b9446095e9..573da38a21c3 100644
--- a/include/uapi/linux/media.h
+++ b/include/uapi/linux
Hi Hans,
On Sun, Feb 4, 2018 at 10:30 PM, Hans Verkuil wrote:
> Hi Gustavo, Alexandre,
>
> As you may have seen I have been extending the v4l2-compliance utility with
> tests
> for v4l-subdevX and mediaX devices. In the process of doing that I promptly
> found a bunch of bugs. Mostly little thin
Hi Masami,
On 2018-02-05 03:30, Masami Hiramatsu wrote:
Fixes vb2_vmalloc_get_userptr() to ioremap correct area.
Since the current code does ioremap the page address, if the offset > 0,
it does not do ioremap the last page and results in kernel panic.
This fixes to pass the page address + offse
69 matches
Mail list logo
