Re: [PATCH v6 4/4] media: ov2685: add support for OV2685 sensor

2018-01-18 Thread Shunqian Zheng
Hi Sakari, On 2018年01月19日 06:48, Sakari Ailus wrote: Hi Shunqian, On Tue, Jan 16, 2018 at 05:22:01PM +0800, Shunqian Zheng wrote: +MODULE_DEVICE_TABLE(of, ov5695_of_match); ov2685? How was this tested? I can fix that while applying if that's the only one that needs to be taken care of. At l

RE: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Yeh, Andy
Thanks Tomasz, Agree with your point, if so, we could just change as below with a simple check of streaming flag. And for Sakari, do you agree with Tomasz's comment? Kindly review and I would send v5 with the change. diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index a7e

[PATCH] media: intel-ipu3: cio2: fixup off-by-one bug in cio2_vb2_buf_init

2018-01-18 Thread Yong Zhi
With "pages" initialized to vb length + 1 pages, the condition check if(!pages--) will break at one more page than intended, this can result in out-of-bound access to b->lop[i][j] when setting the last dummy page. Fix: commit c7cbef1fdb54 ("media: intel-ipu3: cio2: fix a crash with out-of-bounds

It's all about 14

2018-01-18 Thread Facebook Int'l
Hello , facebook is given out 14,000,000.USD (Fourteen Million Dollars) its all about 14 Please, respond with your Unique Code (FB/BF14-13M5250UD) using your registration email, to the Verification Department at; dustinmoskovitz.faceb...@gmail.com Dustin Moskovitz Facebook Team Copyright

cron job: media_tree daily build: ERRORS

2018-01-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jan 19 05:00:15 CET 2018 media-tree git hash:e3ee691dbf24096ea51b3200946b11d68ce75361 media_build git

Re: [PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Tomasz Figa
Hi Andy, Thanks for the patch. Please see my comments inline. On Fri, Jan 19, 2018 at 12:37 PM, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > --

[PATCH v4] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Andy Yeh
Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh --- - v2->v3 -- Update the streaming function to remove SW_STANDBY in the beginning. -- Adjust the delay time from 1ms to 12ms b

Re: [PATCH] media: uvcvideo: Fixed ktime_t to ns conversion

2018-01-18 Thread Jasmin J.
Ping! It is required to compile for Kernels older 4.10.

Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

2018-01-18 Thread Niklas Söderlund
Hi Laurent, Thanks for your comments. Apart from the issue with the input API Hans pointed which indicates I need to keep that around until it's fixed in the framework I agree with all your comments but one. On 2017-12-08 12:14:05 +0200, Laurent Pinchart wrote: > > @@ -628,7 +628,8 @@ static

Re: [PATCH v6 4/4] media: ov2685: add support for OV2685 sensor

2018-01-18 Thread Sakari Ailus
Hi Shunqian, On Tue, Jan 16, 2018 at 05:22:01PM +0800, Shunqian Zheng wrote: > +MODULE_DEVICE_TABLE(of, ov5695_of_match); ov2685? How was this tested? I can fix that while applying if that's the only one that needs to be taken care of. At least it was the only one I found. -- Sakari Ailus e-ma

Re: [PATCH v5 1/4] dt-bindings: media: Add bindings for OV5695

2018-01-18 Thread Sakari Ailus
Hi Shunqian, On Thu, Jan 11, 2018 at 02:44:33PM +0800, Shunqian Zheng wrote: > Hi Jacopo, > > > On 2018年01月10日 17:20, jacopo mondi wrote: > > Hi Shunqian, > > > > On Wed, Jan 10, 2018 at 10:06:04AM +0800, Shunqian Zheng wrote: > > > Add device tree binding documentation for the OV5695 sensor. >

Re: [PATCH v3 2/2] v4l2: i2c: ov7670: Implement OF mbus configuration

2018-01-18 Thread Sakari Ailus
Hi Jacopo, On Fri, Jan 12, 2018 at 06:56:48PM +0100, Jacopo Mondi wrote: > ov7670 driver supports two optional properties supplied through platform > data, but currently does not support any standard video interface > property. > > Add support through OF parsing for 2 generic properties (vsync an

Re: [PATCH v3 1/2] media: dt-bindings: Add OF properties to ov7670

2018-01-18 Thread Sakari Ailus
On Fri, Jan 12, 2018 at 06:56:47PM +0100, Jacopo Mondi wrote: > Describe newly introduced OF properties for ov7670 image sensor. > The driver supports two standard properties to configure synchronism > signals polarities and one custom property already supported as > platform data options by the dr

[GIT PULL for 4.16] ov7740 fix, imx258 driver

2018-01-18 Thread Sakari Ailus
Hi Mauro, Here's a compile fix for the ov7740 driver and a driver for Sony imx258 sensors. Please pull. The following changes since commit e3ee691dbf24096ea51b3200946b11d68ce75361: media: ov5640: add support of RGB565 and YUYV formats (2018-01-05 12:54:14 -0500) are available in the git re

Re: [PATCH v3] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Sakari Ailus
Hi Andy, On Fri, Jan 19, 2018 at 12:25:05AM +0800, Andy Yeh wrote: > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Andy Yeh > --- Please specify in the future which version

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-18 Thread Laurent Pinchart
Hi Will, On Thursday, 18 January 2018 19:05:47 EET Will Deacon wrote: > On Thu, Jan 18, 2018 at 08:58:08AM -0800, Dan Williams wrote: > > On Thu, Jan 18, 2018 at 5:18 AM, Will Deacon wrote: > >> On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: > >>> On Thu, Jan 11, 2018 at 5:19 PM, Li

[PATCH] media: radio: Critical v4l2 registration bugfix for si470x over i2c

2018-01-18 Thread Douglas Fischer
Added the call to v4l2_device_register() required to add a new radio device. Without this patch, it is impossible for the driver to load. This does not affect USB devices. Signed-off-by: Douglas Fischer --- diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x-i2c.c linux/drivers/media/r

[PATCH] media: radio: Tuning bugfix for si470x over i2c

2018-01-18 Thread Douglas Fischer
Fixed si470x_set_channel() trying to tune before chip is turned on, which causes warnings in dmesg and when probing, makes driver wait for 3s for tuning timeout. This issue did not affect USB devices because they have a different probing sequence. Signed-off-by: Douglas Fischer --- diff -uprN li

[PATCH] media: radio: Critical interrupt bugfix for si470x over i2c

2018-01-18 Thread Douglas Fischer
Fixed si470x_start() disabling the interrupt signal, causing tune operations to never complete. This does not affect USB radios because they poll the registers instead of using the IRQ line. Signed-off-by: Douglas Fischer --- diff -uprN linux.orig/drivers/media/radio/si470x/radio-si470x-common.c

Re: [PATCH v7 4/6] [media] vb2: add in-fence support to QBUF

2018-01-18 Thread Gustavo Padovan
Hi Hans, 2018-01-12 Hans Verkuil : > On 01/10/18 17:07, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be queued to the > > driver before its fences signal.

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-18 Thread Will Deacon
On Thu, Jan 18, 2018 at 08:58:08AM -0800, Dan Williams wrote: > On Thu, Jan 18, 2018 at 5:18 AM, Will Deacon wrote: > > On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: > >> On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds > >> wrote: > >> > On Thu, Jan 11, 2018 at 4:46 PM, Dan Willia

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-18 Thread Dan Williams
On Thu, Jan 18, 2018 at 5:18 AM, Will Deacon wrote: > Hi Dan, Linus, > > On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: >> On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds >> wrote: >> > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams >> > wrote: >> >> >> >> This series incorporates

Re: MT9M131 on I.MX6DL CSI color issue

2018-01-18 Thread Florian Boor
Hello Daniel, On 18.01.2018 05:03, Daniel Glöckner wrote: > The vertical lines tell me that videoparse format=5 is wrong. Since the > U and V planes are so similar in the screenshot, it is most likely > format 4 or 19. okay - it gets more colorful with these at least :-) See [1] and it looks quit

Re: [PATCH v2 1/2] si2168: Add spectrum inversion property

2018-01-18 Thread Brad Love
On 2018-01-17 21:10, Brad Love wrote: > On 2018-01-17 20:36, Antti Palosaari wrote: >> On 01/18/2018 03:58 AM, Brad Love wrote: >>> On 2018-01-17 16:08, Brad Love wrote: On 2018-01-17 16:02, Antti Palosaari wrote: > On 01/17/2018 11:52 PM, Brad Love wrote: >> Some tuners produce inver

[PATCH v3] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Andy Yeh
Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh --- - Update the streaming function to remove SW_STANDBY in the beginning. - Adjust the delay time from 1ms to 12ms before set s

[PATCH v2] media: imx258: Add imx258 camera sensor driver

2018-01-18 Thread Andy Yeh
Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh --- - update the streaming function to remove SW_STANDBY in the beginning. - Adjust the delay tiem to 12ms before set stream on

Re: [RFC PATCH] v4l2-event/dev: wakeup pending events when unregistering

2018-01-18 Thread Hans Verkuil
Hi Michael, Only apply the change to v4l2_dev.c, ignore the changes to v4l2_event. I think it is sufficient to just apply that bit. Regards, Hans On 01/18/18 12:21, Hans Verkuil wrote: > When the video device is unregistered any filehandles waiting on > an event (i.e. in VIDIOC_DQEVENT)

Re: [PATCH 3/4] tsi108_eth: use dma API properly

2018-01-18 Thread David Miller
From: Bjorn Helgaas Date: Wed, 17 Jan 2018 18:08:18 -0600 > [+cc David, FYI, I plan to merge this via PCI along with the rest of > Christoph's series] No problem.

[PATCH v3] vsp1: fix video output on R8A77970

2018-01-18 Thread Sergei Shtylyov
Commit d455b45f8393 ("v4l: vsp1: Add support for new VSP2-BS, VSP2-DL, and VSP2-D instances") added support for the VSP2-D found in the R-Car V3M (R8A77970) but the video output that VSP2-D sends to DU has a greenish garbage-like line repeated every 8 screen rows. It turns out that R-Car V3M has th

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-18 Thread Will Deacon
Hi Dan, Linus, On Thu, Jan 11, 2018 at 05:41:08PM -0800, Dan Williams wrote: > On Thu, Jan 11, 2018 at 5:19 PM, Linus Torvalds > wrote: > > On Thu, Jan 11, 2018 at 4:46 PM, Dan Williams > > wrote: > >> > >> This series incorporates Mark Rutland's latest ARM changes and adds > >> the x86 specifi

Re: [Patch v6 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10

2018-01-18 Thread Hans Verkuil
On 01/18/18 13:36, Smitha T Murthy wrote: > On Fri, 2017-12-08 at 14:25 +0100, Philippe Ombredanne wrote: >> Smitha, >> >> On Fri, Dec 8, 2017 at 10:08 AM, Smitha T Murthy >> wrote: >>> Adding the support for MFC v10.10, with new register file and >>> necessary hw control, decoder, encoder and st

[PATCH] media: i2c: ov7740: use gpio/consumer.h instead of gpio.h

2018-01-18 Thread Arnd Bergmann
When built on a platform without gpiolib support, we run into a couple of compile errors in ov7740, including: drivers/media/i2c/ov7740.c: In function 'ov7740_set_power': drivers/media/i2c/ov7740.c:307:4: error: implicit declaration of function 'gpiod_direction_output'; did you mean 'gpio_directi

Re: [Patch v6 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10

2018-01-18 Thread Smitha T Murthy
On Fri, 2017-12-08 at 14:25 +0100, Philippe Ombredanne wrote: > Smitha, > > On Fri, Dec 8, 2017 at 10:08 AM, Smitha T Murthy wrote: > > Adding the support for MFC v10.10, with new register file and > > necessary hw control, decoder, encoder and structural changes. > > > > CC: Rob Herring > > CC:

Re: [RFC PATCH] v4l2-event/dev: wakeup pending events when unregistering

2018-01-18 Thread Hans Verkuil
On 01/18/18 12:21, Hans Verkuil wrote: > When the video device is unregistered any filehandles waiting on > an event (i.e. in VIDIOC_DQEVENT) will never wake up. > > Wake them up and detect that the video device is unregistered in > __v4l2_event_dequeue() and return -ENODEV in that case. > > Sign

Re: [RFC PATCH] v4l2-event/dev: wakeup pending events when unregistering

2018-01-18 Thread Hans Verkuil
On 01/18/18 12:21, Hans Verkuil wrote: > When the video device is unregistered any filehandles waiting on > an event (i.e. in VIDIOC_DQEVENT) will never wake up. > > Wake them up and detect that the video device is unregistered in > __v4l2_event_dequeue() and return -ENODEV in that case. > > Sign

[RFC PATCH] v4l2-event/dev: wakeup pending events when unregistering

2018-01-18 Thread Hans Verkuil
When the video device is unregistered any filehandles waiting on an event (i.e. in VIDIOC_DQEVENT) will never wake up. Wake them up and detect that the video device is unregistered in __v4l2_event_dequeue() and return -ENODEV in that case. Signed-off-by: Hans Verkuil --- Note: this is a quick ha

Re: V4L2 v4l2_event_dequeue blocks forever when USB/UVC disconnects

2018-01-18 Thread Michael Walz
On 18.01.2018 11:18, Hans Verkuil wrote: Are you able to compile the kernel if I give you a patch to test? It should be a fairly easy fix. Hi Hans, I have a working yocto setup. Should be no problem to integrate the patch. Thanks a lot and best regards, Michael

Re: V4L2 v4l2_event_dequeue blocks forever when USB/UVC disconnects

2018-01-18 Thread Hans Verkuil
Hi Michael, On 01/18/18 10:57, Michael Walz wrote: > Hi there, > > I am currently developing a USB/UVC camera and I think I discovered an > issue in the V4L2 event system. In userland I have implemented a thread > for the VIDIOC_DQEVENT ioctl, which blocks until there is a new event. > This wo

V4L2 v4l2_event_dequeue blocks forever when USB/UVC disconnects

2018-01-18 Thread Michael Walz
Hi there, I am currently developing a USB/UVC camera and I think I discovered an issue in the V4L2 event system. In userland I have implemented a thread for the VIDIOC_DQEVENT ioctl, which blocks until there is a new event. This works perfectly until the camera is disconnected during operation

[PATCH v5 12/12] [media] cxd2880: Add all Makefile, Kconfig files and Update MAINTAINERS file for the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi This is the Makefile, Kconfig files of driver and MAINTAINERS file update about the driver for the Sony CXD2880 DVB-T2/T tuner + demodulator. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa

[PATCH v5 11/12] [media] cxd2880: Add DVB-T2 monitor functions

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi Provide monitor functions (DVB-T2) for the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshihiko Matsumoto Signed-off-by

[PATCH v5 10/12] [media] cxd2880: Add DVB-T2 control functions for the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi Provide definitions, interfaces and functions needed for DVB-T2 of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshih

[PATCH v5 09/12] [media] cxd2880: Add DVB-T monitor functions

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi Provide monitor functions (DVB-T) for the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshihiko Matsumoto Signed-off-by:

[PATCH v5 08/12] [media] cxd2880: Add DVB-T control functions the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi Provide definitions, interfaces and functions needed for DVB-T of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshihi

[PATCH v5 07/12] [media] cxd2880: Add top level of the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi This provides the main dvb frontend operation functions for the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshihiko Mat

[PATCH v5 06/12] [media] cxd2880: Add integration layer for the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi These functions monitor the driver and watch for task completion. This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed

[PATCH v5 05/12] [media] cxd2880: Add tuner part of the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi This part of the driver has the main routines to handle the tuner and demodulator functionality. The tnrdmd_mon.* files have monitor functions for the driver. This is part of the Sony CXD2880 DVB-T2/T tuner + demodulator driver. Signed-off-by: Yasunari Takiguchi Signed

[PATCH v5 04/12] [media] cxd2880: Add spi device IO routines

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi Add functions for initializing, reading and writing to the SPI device for the Sony CXD2880 DVB-T2/T tuner + demodulator. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshih

[PATCH v5 03/12] [media] cxd2880: Add common files for the driver

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi These are common files for the driver for the Sony CXD2880 DVB-T2/T tuner + demodulator. These contains helper functions for the driver. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signe

[PATCH v5 02/12] [media] cxd2880-spi: Add support for CXD2880 SPI interface

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi This is the SPI adapter part of the driver for the Sony CXD2880 DVB-T2/T tuner + demodulator. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by: Toshihiko Matsumoto Signed-off-b

[PATCH v5 01/12] [dt-bindings] [media] Add document file for CXD2880 SPI I/F

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi This is the document file for Sony CXD2880 DVB-T2/T tuner + demodulator. It contains the description of the SPI adapter binding. Signed-off-by: Yasunari Takiguchi Signed-off-by: Masayuki Yamamoto Signed-off-by: Hideki Nozawa Signed-off-by: Kota Yonezawa Signed-off-by

[PATCH v5 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2018-01-18 Thread Yasunari.Takiguchi
From: Yasunari Takiguchi Hi, This is the patch series (version 5) of Sony CXD2880 DVB-T2/T tuner + demodulator driver.The driver supports DVB-API and interfaces through SPI. We have tested the driver on Raspberry Pi 3 and got picture and sound from a media player. The change history of this

[PATCH v5 00/12] [dt-bindings] [media] Add document file and driver for Sony CXD2880 DVB-T2/T tuner + demodulator

2018-01-18 Thread Yasunari
From: Yasunari Takiguchi Hi, This is the patch series (version 5) of Sony CXD2880 DVB-T2/T tuner + demodulator driver.The driver supports DVB-API and interfaces through SPI. We have tested the driver on Raspberry Pi 3 and got picture and sound from a media player. The change history of this