Dear Satendra,
On Tue, Dec 19, 2017 at 4:35 AM, Satendra Singh Thakur
wrote:
> --- /dev/null
> +++ b/drivers/media/dvb-core/dvb_vb2.c
> @@ -0,0 +1,422 @@
> +/*
> + * dvb-vb2.c - dvb-vb2
> + *
> + * Copyright (C) 2015 Samsung Electronics
> + *
> + * Author: jh1009.s...@samsung.com
> + *
> + * T
On Mon, 18 Dec 2017 01:28:44 +0100,
Joe Perches wrote:
>
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Tue Dec 19 05:00:16 CET 2017
media-tree git hash:8ea636dcecfa7b05d60309a50beabc5317a845bf
media_build git
-When the func vb2_core_reqbufs is called first time after
vb2_core_queue_init, the condition q->memory != memory
always gets satisfied since q->memory = 0 in
vb2_core_queue_init.
-After the condition is true,
unnecessary calls to __vb2_queue_cancel and
__vb2_queue_free are done
-In such case,
-Ported below mentioned patch to latest kernel:
commit ace52288edf0 ("Merge tag 'for-linus-20171218' of
git://git.infradead.org/linux-mtd")
-Fixed few bugs in the patch, enhanced it and added polling
--dvb_vb2.c:dvb_vb2_fill_buffer=>
Set the size of the outgoing
Joe,
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
SCSI bits look OK.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Follow-up...
Looking closer at that LKML item, that was a test involving fuzzing the
kernel (i.e. feeding it deliberate garbage). This is related to things
like producing a deliberately bogus USB configuration or sending
impossible data on endpoints that don't exist. The pvrusb2 driver was
It might be related. I have some digging to do, and it's been quite a
while since I've seen any issues in that area of logic.
However that said, one the hardest areas of that driver was implementing
a proper tear-down after a hot-unplug event. That sort of thing is
going to inherently be a r
Hi Sakari,
> -Original Message-
> From: Sakari Ailus [mailto:sakari.ai...@iki.fi]
> Sent: 2017年12月14日 4:06
> To: Wenyou Yang - A41535 ; Mauro Carvalho
> Chehab ; Rob Herring ;
> Mark Rutland
> Cc: linux-ker...@vger.kernel.org; Nicolas Ferre - M43238
> ; devicet...@vger.kernel.org; Jonatha
From: Fabio Estevam
The 'irq' member of the vdoa_data struct is only used inside probe,
so there is no need for it. Use a local variable 'ret' instead.
Signed-off-by: Fabio Estevam
---
drivers/media/platform/coda/imx-vdoa.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --
Hi Jacopo,
Thanks for your comments.
On 2017-12-15 15:15:31 +0100, jacopo mondi wrote:
> Hi Niklas,
>thanks for the patch!
>
> On Thu, Dec 14, 2017 at 08:08:27PM +0100, Niklas Söderlund wrote:
> > The driver now have access to frame descriptor information, use it. Only
> > enable the virtual
Hi Sakari,
Thanks for your comments.
On 2017-12-15 15:19:36 +0200, Sakari Ailus wrote:
> Hi Niklas,
>
> On Thu, Dec 14, 2017 at 08:08:26PM +0100, Niklas Söderlund wrote:
> > Use the frame description from the remote subdevice of the rcar-csi2's
> > sink pad to get the remote pad and stream pad n
Hi,
How are you?
We are professional Supplier for Android TV Box,from which you can
watch whatever on the internet.
Model No.: MXQ Pro(RK3229): 4K Ultra HD Android TV BoxRockchip
RK3229,Quad Core, 1.2GHz, Android 6.0 Mashmallow , RAM 1GB
Hi Sakari,
Tack för dina kommentarer.
On 2017-12-15 14:25:27 +0200, Sakari Ailus wrote:
> On Thu, Dec 14, 2017 at 08:08:25PM +0100, Niklas Söderlund wrote:
> > The R-Car CSI-2 hardware can output the same virtual channel
> > simultaneously to more then one R-Car VIN. For this reason we need to
>
Hej Sakari,
Tack för dina kommentarer.
On 2017-12-15 14:07:39 +0200, Sakari Ailus wrote:
> Hej,
>
> On Thu, Dec 14, 2017 at 08:08:23PM +0100, Niklas Söderlund wrote:
> > To work with multiplexed streams the pad and stream aware s_stream
> > operation needs to be used.
> >
> > Signed-off-by: Nik
Hej Sakari,
Tack för dina kommentarer.
On 2017-12-15 13:54:02 +0200, Sakari Ailus wrote:
> On Thu, Dec 14, 2017 at 08:08:22PM +0100, Niklas Söderlund wrote:
> > The pipeline will be moved from the entity to the pads; reflect this in
> > the media pipeline function API.
>
> I'll merge this to "me
Hej Sakari,
Tack för dina kommentarer.
On 2017-12-15 13:51:46 +0200, Sakari Ailus wrote:
> Hejssan Niklas,
>
> Tack för uppdaterade lappor!
>
> On Thu, Dec 14, 2017 at 08:08:21PM +0100, Niklas Söderlund wrote:
> > To be able to start and stop individual streams of a multiplexed pad the
> > s_st
Hi Kieran,
Thanks for your comments,
On 2017-12-14 23:27:57 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 14/12/17 19:08, Niklas Söderlund wrote:
> > To support multiplexed streams the internal routing between the
> > adv748x sink pad and its source pad needs to be described.
>
> The adv748x
Hi Kieran,
Thanks for your comments.
On 2017-12-14 22:19:59 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 14/12/17 19:08, Niklas Söderlund wrote:
> > The hardware can output on any of the 4 (0-3) Virtual Channels of the
> > CSI-2 bus. Add a module parameter each for TXA and TXB to allow the u
On 18/12/2017 at 17:53:57 -0200, Mauro Carvalho Chehab wrote:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match criteria requires just a device name.
>
> So, it doesn't make sense to enclose those into
HI Kieran,
Thanks for your comments.
On 2017-12-14 23:16:08 +, Kieran Bingham wrote:
> Hi Niklas,
>
> On 14/12/17 19:08, Niklas Söderlund wrote:
> > The driver is now pad and stream aware, only allow to get/set format on
> > sink pads.
>
> Ok - I can see the patch is doing this ...
>
> > A
On Sat, Dec 16, 2017 at 11:32 AM, Fabio Estevam wrote:
> Hi Tim,
>
> On Thu, Nov 9, 2017 at 4:45 PM, Tim Harvey wrote:
>
>> +static int tda1997x_set_power(struct tda1997x_state *state, bool on)
>> +{
>> + int ret = 0;
>> +
>> + if (on) {
>> + ret = regulator_bulk_enable(
Em Mon, 18 Dec 2017 17:32:11 +0200
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote:
> > Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu:
> > > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote:
On 17/12/2017 at 16:28:44 -0800, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifi
On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for the
On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for the
On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifie
On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifie
Hi Alex,
2017-12-15 Alexandre Courbot :
> Set the necessary ops for supporting requests in vim2m.
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/media/platform/vim2m.c | 22 ++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/media/platform/vim2m.c b/drive
The agreed format is to use /* */ comments inside header
files. Unfortunately, I ended by using // on a few ones.
Reported-by: Andi Shyti
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/rc/rc-core-priv.h| 10 ++
drivers/media/usb/tm6000/tm6000-regs.h | 10 ++--
For am437x/am437x-vpfe.c & ti-vpe/cal.c
Acked-by: Benoit Parrot
Mauro Carvalho Chehab wrote on Mon [2017-Dec-18
17:53:57 -0200]:
> The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
> struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
> match criteria requires j
On Tue, Nov 28, 2017 at 12:33 PM, Wolfgang Rohdewald
wrote:
> @@ -913,6 +913,14 @@ static int pctv452e_frontend_attach(struct
> dvb_usb_adapter *a)
> &a->dev->i2c_adap);
> if (!a->fe_adap[0].fe)
> return -ENODEV;
> +
> +
The V4L2_DEV_DEBUG_IOCTL macros actually define a bitmask,
but without using Kernel's modern standards. Also,
documentation looks akward.
So, convert them into an enum with valid bits, adding
the correspoinding kernel-doc documentation for it.
In order to avoid possible conflicts, rename them fro
Now that kernel-doc handles nested unions, better document the
match union at struct v4l2_async_subdev.
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-async.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/include/media/v4l2-as
Right now, those are documented together with the subdev struct,
instead of together with the definitions.
Convert the definitions to an enum, use BIT() macros and document
it at its right place.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 34 +++--
There is a mess with media bus flags: there are two sets of
flags, one used by parallel and ITU-R BT.656 outputs,
and another one for CSI2.
Depending on the type, the same bit has different meanings.
That's very confusing, and counter-intuitive. So, split them
into two sets of flags, inside an en
There are several undocumented v4l2-subdev functions that are
part of kAPI. Document them.
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-subdev.h | 69 +
1 file changed, 64 insertions(+), 5 deletions(-)
diff --git
There are several macros that aren't documented using kernel-docs
markups.
Document them.
While here, add cross-references to structs on this file.
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-device.h | 246 +---
1
The V4L2_ASYNC_MATCH_FWNODE match criteria requires just one
struct to be filled (struct fwnode_handle). The V4L2_ASYNC_MATCH_DEVNAME
match criteria requires just a device name.
So, it doesn't make sense to enclose those into structs,
as the criteria can go directly into the union.
That makes eas
The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
3 functions that have the same arguments. The code of those
functions is simple enough to just declare them, de-obfuscating
the code.
While here, replace BUG_ON() by WARN_ON() as there's no reason
why to panic the Kernel if this fails.
Signed
Em Mon, 9 Oct 2017 23:23:56 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Mon, Oct 09, 2017 at 07:19:21AM -0300, Mauro Carvalho Chehab wrote:
> > The __V4L2_SUBDEV_MK_GET_TRY() macro is used to define
> > 3 functions that have the same arguments. The code of those
> > functions is simple enoug
On 12/15/2017 12:59 PM, Sushmita Susheelendra wrote:
Use the direction argument passed into begin_cpu_access
and end_cpu_access when calling the dma_sync_sg_for_cpu/device.
The actual cache primitive called depends on the direction
passed in.
Acked-by: Laura Abbott
Signed-off-by: Sushmita S
Em Fri, 13 Oct 2017 15:49:25 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> Thank you for the patch.
>
> On Thursday, 28 September 2017 00:46:57 EEST Mauro Carvalho Chehab wrote:
> > Now that kernel-doc handles nested unions, better document the
> > match union at struct v4l2_async_subdev.
>
Em Sat, 30 Sep 2017 01:05:24 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> (Removing the non-list recipients.)
>
> On Fri, Sep 29, 2017 at 06:27:13AM -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 28 Sep 2017 15:09:21 +0300
> > Sakari Ailus escreveu:
> >
> > > Hi Mauro,
> > >
> > > On Wed,
Em Wed, 11 Oct 2017 23:26:44 +0200
Pavel Machek escreveu:
> On Mon 2017-10-09 07:19:10, Mauro Carvalho Chehab wrote:
> > There is a mess with media bus flags: there are two sets of
> > flags, one used by parallel and ITU-R BT.656 outputs,
> > and another one for CSI2.
> >
> > Depending on the ty
On Monday, December 18, 2017 1:28:44 AM CET Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for t
Fixes 2 warnings from Clang about extra parentheses in a conditional,
that might have been meant as assignment.
Signed-off-by: Nick Desaulniers
---
drivers/media/dvb-frontends/drx39xyj/drxj.c | 2 +-
drivers/media/dvb-frontends/drxk_hard.c | 2 +-
2 files changed, 2 insertions(+), 2 deletion
Em Mon, 9 Oct 2017 07:19:06 -0300
Mauro Carvalho Chehab escreveu:
> That's the second part of my V4L2 kAPI documentation improvements.
> It is meant to reduce the gap between the kAPI media headers
> and documentation, at least with regards to kernel-doc markups.
>
> We should likely write more
Em Tue, 10 Oct 2017 16:32:34 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Mon, Oct 09, 2017 at 07:19:25AM -0300, Mauro Carvalho Chehab wrote:
> > There are several issues on the current markups:
> > - lack of cross-references;
> > - wrong cross-references;
> > - lack of a period of the end of
These were leftover from:
commit 469ffe083665 ("[media] tda18271c2dd: Remove the CHK_ERROR macro")
and
commit 58d5eaec9f87 ("[media] drxd: Don't use a macro for CHK_ERROR ...")
that programmatically removed the CHK_ERROR macro, which left behind a
few self assignments that Clang warns about. These
Em Tue, 10 Oct 2017 21:47:04 +0100
Andrey Utkin escreveu:
> On Mon, Oct 09, 2017 at 07:19:11AM -0300, Mauro Carvalho Chehab wrote:
> > Using enums makes easier to document, as it can use kernel-doc
> > markups. It also allows cross-referencing, with increases the
> > kAPI readability.
> >
>
>
Hi Mauro,
On Monday, 18 December 2017 17:13:26 EET Mauro Carvalho Chehab wrote:
> Em Fri, 13 Oct 2017 15:38:11 +0300 Laurent Pinchart escreveu:
> > On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote:
> >> Currently, there's no way to document #define foo
> >> with kernel-doc
Hi Jacopo,
On Monday, 18 December 2017 14:25:12 EET jacopo mondi wrote:
> On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote:
> > Hi Jacopo,
> >
> > Thank you for the patch.
>
> [snip]
>
> >> +
> >> +/**
> >> + * ceu_buffer - Link vb2 buffer to the list of available buffers
> >
>
Em Wed, 4 Oct 2017 08:48:38 -0300
Mauro Carvalho Chehab escreveu:
> Right now, it is not possible to document nested struct and nested unions.
> kernel-doc simply ignore them.
>
> Add support to document them.
>
> Patches 1 to 6 improve kernel-doc documentation to reflect what
> kernel-doc cur
Em Fri, 13 Oct 2017 15:38:11 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> Thank you for the patch.
>
> On Thursday, 28 September 2017 00:46:51 EEST Mauro Carvalho Chehab wrote:
> > Currently, there's no way to document #define foo
> > with kernel-doc. So, convert it to an enum, and documen
Em Fri, 13 Oct 2017 15:33:01 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> Thank you for the patch.
>
> On Thursday, 28 September 2017 00:46:48 EEST Mauro Carvalho Chehab wrote:
> > There are several widely macros that aren't documented using kernel-docs
>
> What's a widely macro ? :-)
>
On Mon, Dec 18, 2017 at 12:11:13PM -0200, Mauro Carvalho Chehab wrote:
> Em Fri, 13 Oct 2017 15:24:34 +0200
> Hans Verkuil escreveu:
>
> > > ---
> > > include/media/v4l2-common.h | 14 +-
> > > 1 file changed, 5 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/include/media/v4
On Mon, Dec 18, 2017 at 03:11:43PM +0100, Philipp Rossak wrote:
> The CIR Pin of the A83T is located at PL12.
>
> Signed-off-by: Philipp Rossak
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi
> b/arch/arm
On Mon, Dec 18, 2017 at 03:11:42PM +0100, Philipp Rossak wrote:
> This patch updates documentation for Device-Tree bindings for sunxi IR
> controller and adds the new optional property for the base clock
> frequency.
>
> Signed-off-by: Philipp Rossak
> ---
> Documentation/devicetree/bindings/med
This patch updates the sunxi-ir driver to set the base clock frequency from
devicetree.
This is necessary since there are different ir receivers on the
market, that operate with different frequencies. So this value could be
set if the attached ir receiver needs a different base clock frequency,
th
This patch series adds support for the sunxi A83T ir module and enhances
the sunxi-ir driver. Right now the base clock frequency for the ir driver
is a hard coded define and is set to 8 MHz.
This works for the most common ir receivers. On the Sinovoip Bananapi M3
the ir receiver needs, a 3 MHz ba
The Bananapi M3 has an onboard IR receiver.
This enables the onboard IR receiver subnode.
Unlike the other IR receivers this one needs a base clock frequency
of 300 Hz (3 MHz), to be able to work.
Signed-off-by: Philipp Rossak
Acked-by: Chen-Yu Tsai
---
arch/arm/boot/dts/sun8i-a83t-bananapi
Hi Hans,
thanks for review comments
On Wed, Dec 13, 2017 at 01:03:03PM +0100, Hans Verkuil wrote:
> On 15/11/17 11:55, Jacopo Mondi wrote:
> > Add driver for Renesas Capture Engine Unit (CEU).
> > +
> > + /* Register the video device */
> > + strncpy(vdev->name, DRIVER_NAME, strlen(DRIVER_N
The size of the register should be the size of the whole memory block,
not just the registers, that are needed.
Signed-off-by: Philipp Rossak
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
b/arch/arm/
This patch updates documentation for Device-Tree bindings for sunxi IR
controller and adds the new optional property for the base clock
frequency.
Signed-off-by: Philipp Rossak
---
Documentation/devicetree/bindings/media/sunxi-ir.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documen
The CIR Pin of the A83T is located at PL12.
Signed-off-by: Philipp Rossak
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi
b/arch/arm/boot/dts/sun8i-a83t.dtsi
index de5119a2a91c..feffca8a9a24 100644
--- a/arch/arm/b
The cir interface is like on the H3 located at 0x01f02000 and is exactly
the same. This patch adds support for the ir interface on the A83T.
Signed-off-by: Philipp Rossak
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i
Em Fri, 13 Oct 2017 15:24:34 +0200
Hans Verkuil escreveu:
> > ---
> > include/media/v4l2-common.h | 14 +-
> > 1 file changed, 5 insertions(+), 9 deletions(-)
> >
> > diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
> > @@ -238,11 +239,6 @@ struct v4l2_priv_tun
Hey Andi,
thanks for the feedback. I will fix that in the next version of this
patch series!
On 18.12.2017 03:44, Andi Shyti wrote:
Hi Philipp,
just a couple of small nitpicks.
+ u32 b_clk_freq;
[...]
+ /* Base clock frequency (optional) */
+ if (of_property_read_u32(
Hi Laurent,
thanks for review comments...
On Mon, Dec 11, 2017 at 06:15:23PM +0200, Laurent Pinchart wrote:
> Hi Jacopo,
>
> Thank you for the patch.
>
[snip]
> > +
> > +/**
> > + * ceu_buffer - Link vb2 buffer to the list of available buffers
>
> If you use kerneldoc comments please make the
Add documentation about typedefs for function prototypes and
move it to happen earlier.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/Documentation/doc-guide/k
kernel-doc-nano-HOWTO.txt has a chapter about man pages
production. While we don't have a working "make manpages"
target, add it.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 34 ++
1 file changed, 34 insertions(+)
diff --git
There is a mess on this chapter: it suggests that even
enums and unions should be documented with "struct". That's
not the way it should be ;-)
Fix it and move it to happen earlier.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 48 +---
Right now, if kernel-doc is called without arguments, it
defaults to man pages. IMO, it makes more sense to
default to ReST, as this is the output that it is most
used nowadays, and it easier to check if everything got
parsed fine on an enriched text mode format.
Signed-off-by: Mauro Carvalho Cheh
The private members section can now be moved to be together
with the arguments section. Move it there and add an example
about the usage of public:
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 56 ++
1 file changed, 30 insertio
The check_sections() function has a $nested parameter, meant
to identify when a nested struct is present. As we now have
a logic that handles it, get rid of such parameter.
Suggested-by: Markus Heiser
Signed-off-by: Mauro Carvalho Chehab
---
scripts/kernel-doc | 19 ---
1 file c
Add a new section to describe kernel-doc arguments,
adding examples about how identation should happen, as failing
to do that causes Sphinx to do the wrong thing.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 44 +++---
1 file chang
It is possible to use nested structs like:
struct {
struct {
void *arg1;
} st1, st2, *st3, st4;
};
Handling it requires to split each parameter. Change the logic
to allow such definitions.
In order to test the new nested logic, the following file
was used to test
Sphinx has a hard time dealing with tabs, causing it to
misinterpret paragraph continuation.
As we're now mainly focused on supporting ReST output,
replace tabs by spaces, in order to avoid troubles when
the output is parsed by Sphinx.
Signed-off-by: Mauro Carvalho Chehab
---
scripts/kernel-doc
Right now, if one uses "--rst" instead of "-rst", it just
ignore the argument and produces a man page. Change the
logic to accept both "-cmd" and "--cmd". Also, if
"cmd" doesn't exist, print the usage information and exit.
Signed-off-by: Mauro Carvalho Chehab
---
scripts/kernel-doc | 36
Now that kernel-doc can hanle nested structs/unions, describe
such fields at w1_netlink_message_types.
Acked-by: Evgeniy Polyakov
Signed-off-by: Mauro Carvalho Chehab
---
drivers/w1/w1_netlink.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/w1/w1_netlink.h b/d
When kernel-doc is called with output selection filters,
it will be called lots of time for a single file. If
there is a warning present there, it means that it may
print hundreds of identical warnings.
Worse than that, the -function NAME actually filters only
functions. So, it makes no sense at a
On Mon, Dec 18, 2017 at 2:28 AM, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifie
Function arguments are different than usual ones. So, an
special logic is needed in order to handle such arguments
on nested structs.
Signed-off-by: Mauro Carvalho Chehab
---
scripts/kernel-doc | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff -
Everything there is already described at
Documentation/doc-guide/kernel-doc.rst. So, there's no reason why
to keep it anymore.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/00-INDEX | 2 -
Documentation/kernel-doc-nano-HOWTO.txt | 322
There are several places within the Kernel tree with nested
structs/unions, like this one:
struct ingenic_cgu_clk_info {
const char *name;
enum {
CGU_CLK_NONE = 0,
CGU_CLK_EXT = BIT(0),
CGU_CLK_PLL = BIT(1),
CGU_CLK_GATE = BIT(2),
CGU_CLK_MUX = BIT(3),
Hi Jon,
This is a rebased version of my patch series that add support for
nested structs on kernel-doc. With this version, it won't produce anymore
hundreds of identical warnings, as patch 17 removes the warning
duplication.
Excluding warnings about duplicated Note: section at hash.h, before
this
Move its contents to happen earlier and improve the description
of return values, adding a subsection to it. Most of the contents
there came from kernel-doc-nano-HOWTO.txt.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/kernel-doc.rst | 100 -
1
Since there isn't any docbook code anymore upstream,
we can get rid of several output formats:
- docbook/xml, html, html5 and list formats were used by
the old build system;
- As ReST is text, there's not much sense on outputting
on a different text format.
After this patch, only man and rst
The logic at create_parameterlist()'s ancillary push_parameter()
function has already a way to output the declaration name, with
would help to discover what declaration is missing.
However, currently, the logic is utterly broken, as it uses
the var $type with a wrong meaning. With the current code
From: Jacob Chen
Add the subdev driver for rockchip isp1.
Signed-off-by: Jacob Chen
Signed-off-by: Shunqian Zheng
Signed-off-by: Yichong Zhong
Signed-off-by: Jacob Chen
Signed-off-by: Eddie Cai
Signed-off-by: Jeffy Chen
Signed-off-by: Allon Huang
Signed-off-by: Tomasz Figa
---
drivers/m
From: Jacob Chen
This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver
Signed-off-by: Jacob Chen
Signed-off-by: Shunqian Zheng
Signed-off-by: Tomasz Figa
---
.../media/platform/rockchip/isp1/mipi_dphy_sy.c| 787 +
1 file changed, 787 insertions(+)
c
From: Jacob Chen
Add the capture video driver for rockchip isp1 statistics block.
Signed-off-by: Jacob Chen
Signed-off-by: Shunqian Zheng
Signed-off-by: Yichong Zhong
Signed-off-by: Jacob Chen
Signed-off-by: Eddie Cai
Signed-off-by: Jeffy Chen
Signed-off-by: Allon Huang
Signed-off-by: Tom
From: Jacob Chen
Add the core driver for rockchip isp1.
Signed-off-by: Jacob Chen
Signed-off-by: Shunqian Zheng
Signed-off-by: Yichong Zhong
Signed-off-by: Jacob Chen
Signed-off-by: Eddie Cai
Signed-off-by: Jeffy Chen
Signed-off-by: Allon Huang
Signed-off-by: Tomasz Figa
---
drivers/med
From: Jacob Chen
Add DT bindings documentation for Rockchip MIPI D-PHY RX
Signed-off-by: Jacob Chen
---
.../bindings/media/rockchip-mipi-dphy.txt | 88 ++
1 file changed, 88 insertions(+)
create mode 100644
Documentation/devicetree/bindings/media/rockchip-mipi-dp
From: Jacob Chen
This is the capture device interface driver that provides the v4l2
user interface. Frames can be received from ISP1.
Signed-off-by: Jacob Chen
Signed-off-by: Shunqian Zheng
Signed-off-by: Yichong Zhong
Signed-off-by: Jacob Chen
Signed-off-by: Eddie Cai
Signed-off-by: Jeffy
From: Jacob Chen
Add DT bindings documentation for Rockchip ISP1
Signed-off-by: Jacob Chen
---
.../devicetree/bindings/media/rockchip-isp1.txt| 69 ++
1 file changed, 69 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/rockchip-isp1.txt
diff --
From: Jacob Chen
rk3288 have a Embedded 13M ISP
Signed-off-by: Jacob Chen
---
arch/arm/boot/dts/rk3288.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index f3e7f98c2724..ed0b17d1b116 100644
--- a/arch/ar
From: Shunqian Zheng
rk3399 have two ISP, but we havn't test isp1, so just add isp0 at present.
Signed-off-by: Shunqian Zheng
Signed-off-by: Jacob Chen
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchi
From: Jacob Chen
It's a Designware MIPI D-PHY, used by ISP in rk3288.
Signed-off-by: Jacob Chen
---
arch/arm/boot/dts/rk3288.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
index ed0b17d1b116..aa9ad3a6e0a5 100644
---
1 - 100 of 122 matches
Mail list logo
