On Wed, 29 Nov 2017, Mauro Carvalho Chehab wrote:
> Remove this warning:
> drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot
> understand * @icd - soc-camera device
>on line 309 - I thought it was a doc line
>
> Signed-off-by: Mauro Carvalho Cheh
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Thu Nov 30 05:00:17 CET 2017
media-tree git hash:04226916d2360f56d57ad00bc48d2d1854d1e0b0
media_build git
On Wed, Nov 29, 2017 at 01:19:56PM -0800, Tim Harvey wrote:
> The GW54xx has a front-panel microHDMI connector routed to a TDA19971
> which is connected the the IPU CSI when using IMX6Q.
>
> Signed-off-by: Tim Harvey
> ---
> v2:
> - add HDMI audio input support
> ---
> arch/arm/boot/dts/imx6q-g
This is a v4l2 subdev driver supporting the TDA1997x HDMI video receiver.
I've tested this on a Gateworks GW54xx/GW551x with an IMX6Q which uses the
TDA19971 with 16bits connected to the IMX6 CSI. For this configuration I've
tested both 16bit YUV422 and 8bit BT656 parallel video bus modes.
While
Signed-off-by: Tim Harvey
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index aa71ab52f..502bc97 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13244,6 +13244,14 @@ T: git git://linuxtv.org/mkrufky/tuners.git
S: Maintained
F: d
Add support for the TDA1997x HDMI receivers.
Cc: Hans Verkuil
Signed-off-by: Tim Harvey
---
v4:
- move include/dt-bindings/media/tda1997x.h to bindings patch
- fix typos
- fix default quant range for VGA
- fix quant range handling and conv matrix
- add additional standards and capabilities
The GW54xx has a front-panel microHDMI connector routed to a TDA19971
which is connected the the IPU CSI when using IMX6Q.
Signed-off-by: Tim Harvey
---
v2:
- add HDMI audio input support
---
arch/arm/boot/dts/imx6q-gw54xx.dts| 102 ++
arch/arm/boot/dts/imx6q
Signed-off-by: Tim Harvey
---
arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 85 +++
1 file changed, 85 insertions(+)
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
index 30d4662..8ce0b15 100644
--- a/arch/arm/boot/dts/imx6qdl
Cc: Rob Herring
Cc: Sakari Ailus
Signed-off-by: Tim Harvey
---
v4:
- move include/dt-bindings/media/tda1997x.h to bindings patch
- clarify port node details
v3:
- fix typo
v2:
- add vendor prefix and remove _ from vidout-portcfg
- remove _ from labels
- remove max-pixel-rate property
-
A file with contents:
scancode sony12:0x100015
space 25000
scancode sony12:0x100015
Will produce bogus results.
Reported-by: Matthias Reichl
Signed-off-by: Sean Young
---
utils/ir-ctl/ir-ctl.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/utils/ir-ctl/ir-ctl.c b/u
When sending multiple scancodes, or pulse space files, by default there
is 125ms gap between them. Allow this to be specified.
Signed-off-by: Sean Young
---
utils/ir-ctl/ir-ctl.1.in | 5 +
utils/ir-ctl/ir-ctl.c| 18 +-
2 files changed, 18 insertions(+), 5 deletions(-)
d
Hi Matthias,
On Wed, Nov 29, 2017 at 03:44:00PM +0100, Matthias Reichl wrote:
> Hi Sean!
>
> According to the ir-ctl manpage it should be possible to send a file
> containing multiple scancodes, but when trying to do this I get
> a warning and an error message.
>
> I initially noticed that on ve
If the video device was registered by the complete() callback it should
be unregistered when the driver is removed. Protect from printing a
uninitialized video device node name by adding a checking in
rvin_v4l2_unregister() by checking that the video device is registered.
Signed-off-by: Niklas Söd
In preparation for Gen3 support move the subdevice initialization and
clean up from rvin_v4l2_{register,unregister}() directly to the async
callbacks. This simplifies the addition of Gen3 support as the
rvin_v4l2_register() can be shared for both Gen2 and Gen3 while direct
subdevice control are onl
The functions to initialize and cleanup the hardware and video device
where poorly named from the start. Rename them to better describe there
intended function.
Signed-off-by: Niklas Söderlund
---
drivers/media/platform/rcar-vin/rcar-core.c | 10 +-
drivers/media/platform/rcar-vin/rcar-d
On Gen3 the max supported width and height will be different from Gen2.
Move the limits to the struct rvin_info to prepare for Gen3 support.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-core.c | 6 ++
drivers
Document the devicetree bindings for the CSI-2 inputs available on Gen3.
There is a need to add a custom property 'renesas,id' and to define
which CSI-2 input is described in which endpoint under the port@1 node.
This information is needed since there are a set of predefined routes
between each VI
Instead of caching the subdevice format each time the video device
format is set read it directly when it's needed. As it turns out the
format is only needed when figuring out the max rectangle for cropping.
This simplifies the code and makes it clearer what the source format is
used for.
Signed-
It was a bad idea to reset the crop and compose settings when a new
format is set. This would overwrite any crop/compose set by s_select and
cause unexpected behaviors, remove it. Also fold the reset helper in to
the only remaining caller.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
Bus configuration will once the driver is extended to support Gen3
contain information not specific to only the directly connected parallel
subdevice. Move it to struct rvin_info to show it's not always coupled
to the parallel subdevice.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
It is possible on Gen2 to change the registers controlling composing and
scaling while the stream is running. It is however not a good idea to do
so and could result in trouble. There are also no good reasons to allow
this, remove immediate reflection in hardware registers from
vidioc_s_selection a
The rcar-vin driver needs to be part of a media controller to support
Gen3. Give each VIN instance a unique name so it can be referenced from
userspace.
Signed-off-by: Niklas Söderlund
Reviewed-by: Kieran Bingham
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-v4l2.c | 3 ++-
There was never proper support in the VIN driver to deliver ALTERNATING
field format to user-space, remove this field option. For sources using
this field format instead use the VIN hardware feature of combining the
fields to an interlaced format. This mode of operation was previously
the default b
On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One
feature of this register is that it's only present in the VIN0 and VIN4
instances. The register in VIN0 controls the routing for VIN0-3 and the
register in VIN4 controls routing for VIN4-7.
To be able to control routing from a
When Gen3 support is added to the driver more than chip ID will be
different for the different SoCs. To avoid a lot of if statements in the
code create a struct chip_info to store this information.
And while we are at it sort the compatible string entries and make use
of of_device_get_match_data()
Add the register needed to work with Gen3 hardware. This patch adds
the logic for how to work with the Gen3 hardware. More work is required
to enable the subdevice structure needed to configure capturing.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-
On Gen3 a media controller API needs to be used to allow userspace to
configure the subdevices in the pipeline instead of directly controlling
a single source subdevice, which is and will continue to be the mode of
operation on Gen2.
Prepare for these two modes of operation by adding a flag to str
Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/Kconfig | 2 +-
drivers/media/platform/rcar-vin/rcar-core.c | 150
2 files changed, 151 insertio
Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN
group common media device. Once all CSI-2 subdevices are added to the
common media device create links between them.
The parsing and registering CSI-2 subdevices with the v4l2 async
framework is a collaborative effort shared bet
When the driver runs in media controller mode it should not directly
control the subdevice instead userspace will be responsible for
configuring the pipeline. To be able to run in this mode a different set
of v4l2 operations needs to be used.
Add a new set of v4l2 operations to support the running
Add the SoC specific information for Renesas r8a7796.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
.../devicetree/bindings/media/rcar_vin.txt | 1 +
drivers/media/platform/rcar-vin/rcar-core.c| 64 ++
2 files changed, 65 insertions(+)
diff
Part of the format alignment and checking can be shared with the Gen3
format handling. Break that part out to its own function. While doing
this clean up the checking and add more checks.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-v4l2.c |
In media controller mode all VIN instances needs to be part of the same
media graph. There is also a need to each VIN instance to know and in
some cases be able to communicate with other VIN instances.
Add an allocator framework where the first VIN instance to be probed
creates a shared data struc
Each Gen3 SoC has a limited set of predefined routing possibilities for
which CSI-2 device and virtual channel can be routed to which VIN
instance. Prepare to store this information in the struct rvin_info.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rca
The procedure to start or stop streaming using the non-MC single
subdevice and the MC graph and multiple subdevices are quite different.
Create a new function to abstract which method is used based on which
mode the driver is running in and add logic to start the MC graph.
Signed-off-by: Niklas Sö
In preparation of refactoring the scaling code move the code regarding
scaling to to the top of the file to avoid the need to add forward
declarations. No code is changed in this commit only whole functions
moved inside the same file.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
Add the ability to process media device link change request. Link
enabling is a bit complicated on Gen3, whether or not it's possible to
enable a link depends on what other links already are enabled. On Gen3
the 8 VINs are split into two subgroup's (VIN0-3 and VIN4-7) and from a
routing perspective
Add the SoC specific information for Renesas r8a77970.
Signed-off-by: Niklas Söderlund
---
.../devicetree/bindings/media/rcar_vin.txt | 1 +
drivers/media/platform/rcar-vin/rcar-core.c| 40 ++
2 files changed, 41 insertions(+)
diff --git a/Documentation/devi
Hi,
This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795,
r8a7796 and r8a77970. It is based on the media-tree and depends on some
of Fabrizio Castro patches as they touches the order of the compatible
strings in the documentation to reduce merge conflicts. The dependencies
a
When running in media controller mode a media pad is needed, register
one. Also set the media bus format to CSI-2.
Signed-off-by: Niklas Söderlund
Reviewed-by: Hans Verkuil
---
drivers/media/platform/rcar-vin/rcar-core.c | 24 ++--
drivers/media/platform/rcar-vin/rcar-vin.h
The logic to preserve the requested format width and height are too
complex and come from a premature optimization for Gen3. All Gen2 SoC
can scale and the Gen3 implementation will not use these functions at
all so simply preserve the width and height when interacting with the
subdevice much like t
Documentation for Renesas R-Car MIPI CSI-2 receiver. The CSI-2 receivers
are located between the video sources (CSI-2 transmitters) and the video
grabbers (VIN) on Gen3 of Renesas R-Car SoC.
Each CSI-2 device is connected to more then one VIN device which
simultaneously can receive video from the
A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver
supports the rcar-vin driver on R-Car Gen3 SoCs where separate CSI-2
hardware blocks are connected between the video sources and the video
grabbers (VIN).
Driver is based on a prototype by Koji Matsuoka in the Renesas BSP.
Signed-off
Hi,
This is the latest incarnation of R-Car MIPI CSI-2 receiver driver. It's
based on top of the media-tree and are tested on Renesas Salvator-X
together with the out-of-tree patches for rcar-vin to add support for
Gen3 VIN.
I hope this is the last incarnation of this patch-set, I do think it is
drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter
'clock'
drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter
'clock_frequency'
drivers/media/i2c/s5k6a3.c:68: warning: No description found for parameter
'power_count'
Signed-off-by: Mauro Carvalho
As warned:
drivers/media/pci/sta2x11/sta2x11_vip.c:414: warning: No description found
for parameter 'priv'
drivers/media/pci/sta2x11/sta2x11_vip.c:442: warning: No description found
for parameter 'priv'
drivers/media/pci/sta2x11/sta2x11_vip.c:476: warning: No description found
for p
Solve those warnings:
drivers/media/radio/radio-wl1273.c:1337: warning: No description found
for parameter 'radio'
drivers/media/radio/radio-wl1273.c:1337: warning: Excess function
parameter 'core' description in 'wl1273_fm_set_tx_power'
Signed-off-by: Mauro Carvalho Chehab
---
Get rid of the following warnings:
drivers/media/platform/pxa_camera.c:247: warning: No description found for
parameter 'layout'
drivers/media/platform/pxa_camera.c:867: warning: No description found for
parameter 'buf'
drivers/media/platform/pxa_camera.c:867: warning: No description
Now, the Kernel checks for kernel_doc format issues.
Weird enough, it didn't get any of those troubles. Shssst!
Well, let's fix it, as a preventive way to avoid having
hundreds of new warnings on some next Linux version.
Tested by adding all files under dvb-frontends that have
"/**" on them.
Sig
Remove this warning:
drivers/media/platform/soc_camera/soc_scale_crop.c:309: warning: Cannot
understand * @icd - soc-camera device
on line 309 - I thought it was a doc line
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/soc_camera/soc_scale_crop.c
Fix this warning:
drivers/media/platform/vsp1/vsp1_dl.c:87: warning: No description found
for parameter 'has_chain'
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/vsp1/vsp1_dl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
b
There is a bad kernel-doc markup, producing the following warnings:
drivers/media/pci/netup_unidvb/netup_unidvb_core.c:85: warning: bad line:
Bits [0-7]: DMA packet size, 188 bytes
drivers/media/pci/netup_unidvb/netup_unidvb_core.c:86: warning: bad line:
Fix those warnings:
drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found
for parameter 'wdt'
drivers/media/platform/mtk-vpu/mtk_vpu.c:223: warning: No description found
for parameter 'wdt_refcnt'
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/mtk-vpu
Fix those warnings:
drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c:69: warning: No
description found for parameter 'reserved'
drivers/media/platform/mtk-vcodec/vdec/vdec_vp8_if.c:175: warning: Excess
struct member 'dev' description in 'vdec_vp8_inst'
Signed-off-by: Mauro Carvalho Cheh
For the dvb-frontends that are now part of the documentation,
complete the kernel-doc markups, in order for them to be
properly used at the driver's kAPI documentation.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/af9013.h | 24 +++--
drivers/media/dvb-frontends/as
Add to the media book the attachment kAPI for the DVB
frontend drivers that have already some kernel-doc markup.
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/media/dvb-drivers/frontends.rst | 30 +++
Documentation/media/dvb-drivers/index.rst | 1 +
2 files
Fix this warning:
drivers/media/platform/s3c-camif/camif-core.c:112: warning: No
description found for parameter 'vp'
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/s3c-camif/camif-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/s3c-cam
There are a few mistakes on the existing markups:
drivers/media/pci/tw68/tw68-risc.c:32: warning: Cannot understand * @rp
pointer to current risc program position
on line 32 - I thought it was a doc line
drivers/media/pci/tw68/tw68-risc.c:144: warning: No description found fo
Fix this warning:
drivers/media/i2c/lm3560.c:69: warning: No description found for
parameter 'dev'
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/lm3560.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
index 251a2a
As warned:
drivers/media/dvb-frontends/ix2505v.c:24: warning: cannot understand function
prototype: 'int ix2505v_debug; '
drivers/media/dvb-frontends/ix2505v.c:59: warning: No description found for
parameter 'state'
drivers/media/dvb-frontends/ix2505v.c:128: warning: No description found f
get rid of the following warnings:
drivers/media/radio/radio-si476x.c:317: warning: No description found for
parameter 'v4l2dev'
drivers/media/radio/radio-si476x.c:317: warning: No description found for
parameter 'ctrl_handler'
drivers/media/radio/radio-si476x.c:317: warning: No description
as warned:
drivers/media/i2c/s5k6aa.c:429: warning: No description found for parameter
's5k6aa'
drivers/media/i2c/s5k6aa.c:679: warning: No description found for parameter
's5k6aa'
drivers/media/i2c/s5k6aa.c:733: warning: No description found for parameter
's5k6aa'
drivers/media/i2c/s5k6
Several comments are wrongly tagged as kernel-doc, causing
those warnings:
drivers/media/rc/st_rc.c:98: warning: No description found for parameter 'irq'
drivers/media/rc/st_rc.c:98: warning: No description found for parameter
'data'
drivers/media/pci/solo6x10/solo6x10-enc.c:183: warning: N
On kernel-doc, struct declarations should be declared as "struct foo".
Fix the following warnings:
drivers/media/platform/rcar_jpu.c:265: warning: cannot understand
function prototype: 'struct jpu_q_data '
drivers/media/platform/rcar_jpu.c:281: warning: cannot understand
function
There are some struct fields that aren't documented, and some
consts whose comments start with /**, but they aren't kernel-doc
annotations. So, fix it:
drivers/media/i2c/tvp514x.c:127: warning: No description found for parameter
'hdl'
drivers/media/i2c/tvp514x.c:127: warning: No description f
Fix those warnings:
drivers/media/tuners/mt2063.c:1413: warning: No description found for
parameter 'f_ref'
drivers/media/tuners/mt2063.c:1413: warning: Excess function parameter
'f_Ref' description in 'MT2063_fLO_FractionalTerm'
drivers/media/tuners/mt2063.c:1476: warning
Changes since v2 [1]:
* Add a comment for the vma_is_fsdax() check in get_vaddr_frames() (Jan)
* Collect Jan's Reviewed-by.
* Rebased on v4.15-rc1
[1]: https://lists.01.org/pipermail/linux-nvdimm/2017-November/013295.html
The summary text below is unchanged from v2.
---
Andrew,
Here is a new g
Until there is a solution to the dma-to-dax vs truncate problem it is
not safe to allow V4L2, Exynos, and other frame vector users to create
long standing / irrevocable memory registrations against filesytem-dax
vmas.
Cc: Inki Dae
Cc: Seung-Woo Kim
Cc: Joonyoung Shim
Cc: Kyungmin Park
Cc: Maur
V4L2 memory registrations are incompatible with filesystem-dax that
needs the ability to revoke dma access to a mapping at will, or
otherwise allow the kernel to wait for completion of DMA. The
filesystem-dax implementation breaks the traditional solution of
truncate of active file backed mappings
Add support of DVP parallel mode in addition of
existing MIPI CSI mode. The choice between two modes
and configuration is made through device tree.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 101 +
1 file changed, 83 insertions(+),
Add RGB565 (LE & BE) and YUV422 YUYV format in addition
to existing YUV422 UYVY format.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 74 +-
1 file changed, 67 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/dr
Switch gpiod_set_value to gpiod_set_value_cansleep to avoid
warnings when powering sensor.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index c89ed6
Enhance OV5640 CSI driver to support also DVP parallel interface.
Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing
YUV422 UYVY format.
Some other improvements on chip identifier check and removal
of warnings in powering phase around gpio handling.
===
= history =
===
Verify that chip identifier is correct before starting streaming
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 61071f5..
Fix ptr_ret.cocci warnings:
drivers/media/platform/exynos4-is/fimc-lite.c:1465:1-3: WARNING:
PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych
---
drivers/media/platform/exyn
On Thu, Nov 23, 2017 at 12:25 AM, Sakari Ailus wrote:
> On Wed, Nov 22, 2017 at 08:37:04PM -0800, Tim Harvey wrote:
>> On Tue, Nov 21, 2017 at 11:36 PM, Sakari Ailus wrote:
>> > Hi Tim,
>> >
>> > On Thu, Nov 09, 2017 at 10:45:33AM -0800, Tim Harvey wrote:
>> >> Cc: Rob Herring
>> >> Signed-off-b
On Thu, Nov 23, 2017 at 12:08 AM, Hans Verkuil wrote:
> On 11/23/2017 05:27 AM, Tim Harvey wrote:
>> On Mon, Nov 20, 2017 at 7:39 AM, Hans Verkuil wrote:
>>> Hi Tim,
>>>
>>> Some more review comments:
>>>
>>> On 11/09/2017 07:45 PM, Tim Harvey wrote:
Add support for the TDA1997x HDMI receive
This patch fixes the remaining coding style warnings in the cxd2099
module. Instead of hard coding the function name the __func__ variable
should be used.
It fixes the following checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using 'i2c_read_reg', this
function's name, in a st
This patch fixes the remaining coding style warnings in the cxd2099
module. Instead of hard coding the function name the __func__ variable
should be used.
It fixes the following checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using 'i2c_read_reg', this
function's name, in a st
Hi Maxime,
>
> So there's a couple of issues with those patches (the pull request
> itself is fine though :))
>
> I'll try to break them down as much as possible.
>
> A) If you want to have proper commit logs, you will usually do two
>things: first create a commit title, which is what appear
This patch fixes the remaining coding style warnings in the lirc module.
Instead of hard coding the function name the __func__ variable
should be used.
It fixes the following checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using 'read', this
function's name, in a string
Sign
Hi Sean!
According to the ir-ctl manpage it should be possible to send a file
containing multiple scancodes, but when trying to do this I get
a warning and an error message.
I initially noticed that on version 1.12.3 but 1.12.5 and master
(rev 85f8e5a99) give the same error.
Sending a file with
Hi Mauro,
On 2017-11-29 11:46, Mauro Carvalho Chehab wrote:
While it would be very cool to have those functions using
kernel-doc markups, the reality right now is that they
don't follow kernel-doc rules, as parameters aren't documented.
So, stop abusing on "/**" markups.
Signed-off-by: Mauro C
> There are 35 defaults defined by macros like this, most of them much
> more complicated that IA_CSS_DEFAULT_ISP_MEM_PARAMS, and a few members
> are initialized to non-zero values. My plan, therefore, is to convert
> everything to use designated initializers, and then start removing the
> zeroes
This change fixes the calculation of B-frames and GOP size by
adopt v4l2 controls with the firmware interface expectations.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/venc.c | 15 ---
drivers/media/platform/qcom/venus/venc_ctrls.c | 60 ++
Move ptype (property type) initialization out of switch case
and save few lines of code.
Signed-off-by: Stanimir Varbanov
---
drivers/media/platform/qcom/venus/hfi_cmds.c | 73 +---
1 file changed, 2 insertions(+), 71 deletions(-)
diff --git a/drivers/media/platform/qcom
On Wed, Nov 29, 2017 at 10:28:26AM -0200, Mauro Carvalho Chehab wrote:
> Em Wed, 29 Nov 2017 10:24:57 -0200
> Mauro Carvalho Chehab escreveu:
>
> > Em Wed, 29 Nov 2017 14:14:54 +0200
> > Sakari Ailus escreveu:
> >
> > > Hi Mauro,
> > >
> > > Thanks for the patch.
> > >
> > > On Wed, Nov 29, 2
Hi Jacob,
On Mon, Nov 27, 2017 at 03:03:59PM +0800, Jacob Chen wrote:
> Hi,
>
> On 2017年11月25日星期六 CST 下午1:05:42 you wrote:
> > Hi,
> >
> > On 2017年11月24日星期五 CST 下午6:19:36 you wrote:
> > > On Fri, Nov 24, 2017 at 6:17 PM, Sakari Ailus
> > >
> > > wrote:
> > > > Hi Tomasz,
> > > >
> > > > On Fr
Em Wed, 29 Nov 2017 10:24:57 -0200
Mauro Carvalho Chehab escreveu:
> Em Wed, 29 Nov 2017 14:14:54 +0200
> Sakari Ailus escreveu:
>
> > Hi Mauro,
> >
> > Thanks for the patch.
> >
> > On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote:
> > > A recent change on Kernel 4.15-
Em Wed, 29 Nov 2017 14:14:54 +0200
Sakari Ailus escreveu:
> Hi Mauro,
>
> Thanks for the patch.
>
> On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote:
> > A recent change on Kernel 4.15-rc1 causes all tags with
> > /** to be handled as kernel-doc markups. Well, several
> > a
Hi Mauro,
Thanks for the patch.
On Wed, Nov 29, 2017 at 07:08:04AM -0500, Mauro Carvalho Chehab wrote:
> A recent change on Kernel 4.15-rc1 causes all tags with
> /** to be handled as kernel-doc markups. Well, several
> atomisp modules, it doesn't use kernel-doc, but some other
> documentation ma
There are some troubles on kernel-doc markups, as warned:
drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description
found for parameter 't1'
drivers/media/v4l2-core/v4l2-dv-timings.c:259: warning: No description
found for parameter 't2'
drivers/media/v4l2-cor
Fix those warnings:
drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description
found for parameter 'sd'
drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No description
found for parameter 'addr_num'
drivers/media/i2c/m5mols/m5mols_capture.c:42: warning: No
Fix those kernel-doc warnings:
drivers/media/platform/exynos4-is/mipi-csis.c:229: warning: No description
found for parameter 'clk_frequency'
drivers/media/platform/exynos4-is/mipi-csis.c:229: warning: Excess struct
member 'clock_frequency' description in 'csis_state'
drivers/media/p
There are no descriptions for some enums, with produces lots
of warnings:
drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warning: Enum
value 'VENC_VP8_VPU_WORK_BUF_LUMA' not described in enum 'venc_vp8_vpu_work_buf'
drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c:55: warnin
There are several parameters there that are named wrong, as
reported by those warnings:
drivers/media/rc/ir-sharp-decoder.c:47: warning: No description found
for parameter 'ev'
drivers/media/rc/ir-sharp-decoder.c:47: warning: Excess function
parameter 'duration' description in 'i
There are several of kernel-doc warnings:
drivers/media/platform/davinci/vpif_display.c:114: warning: No description
found for parameter 'sizes'
drivers/media/platform/davinci/vpif_display.c:165: warning: No description
found for parameter 'vq'
drivers/media/platform/davinci/vpif_dis
On Tue, Nov 28, 2017 at 06:47:08PM +0100, Martin Homuth wrote:
> This patch fixes the remaining coding style warnings in the lirc module.
> Instead of hard coding the function name the __func__ variable
> should be used.
>
> It fixes the following checkpatch.pl warning:
>
> WARNING: Prefer using
Hi Sakari,
thanks for the reply
On Wed, Nov 29, 2017 at 01:06:49PM +0200, Sakari Ailus wrote:
> On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote:
> > > ov7670 currently supports configuration of a f
On Wed, Nov 29, 2017 at 01:04:30PM +0200, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Mon, Nov 27, 2017 at 11:26:53AM +0100, Jacopo Mondi wrote:
> > ov7670 currently supports configuration of a few parameters only through
> > platform data. Implement media bus configuration by parsing DT properties
>
1 - 100 of 131 matches
Mail list logo