cron job: media_tree daily build: WARNINGS

2017-09-15 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Sep 16 05:00:21 CEST 2017 media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf media_build gi

Re: IMX6 ADV7180 no /dev/media

2017-09-15 Thread Steve Longerbeam
On 09/15/2017 04:46 PM, Fabio Estevam wrote: Hi Steve, On Fri, Sep 15, 2017 at 8:39 PM, Steve Longerbeam wrote: Agreed, but I notice now that CONFIG_MEDIA_CONTROLLER and CONFIG_VIDEO_V4L2_SUBDEV_API are not enabled there anymore. I do see them enabled in mainline with imx_v6_v7_defconfig.

Re: IMX6 ADV7180 no /dev/media

2017-09-15 Thread Fabio Estevam
Hi Steve, On Fri, Sep 15, 2017 at 8:39 PM, Steve Longerbeam wrote: > Agreed, but I notice now that CONFIG_MEDIA_CONTROLLER and > CONFIG_VIDEO_V4L2_SUBDEV_API are not enabled there anymore. I do see them enabled in mainline with imx_v6_v7_defconfig. Tim, Care to send the patch enabling CONFIG_

Re: IMX6 ADV7180 no /dev/media

2017-09-15 Thread Steve Longerbeam
On 09/15/2017 04:28 PM, Tim Harvey wrote: On Fri, Sep 15, 2017 at 3:26 PM, Steve Longerbeam wrote: Hi Tim, On 09/15/2017 02:26 PM, Tim Harvey wrote: Greetings, I'm testing Linux master built with imx_v6_v7_defconfig on a GW51xx which has an ADV7180 analog video decoder and am not seeing t

Re: [PATCH] [media] solo6x10: hide unused variable

2017-09-15 Thread Ismael Luceno
On 15/Sep/2017 21:52, Arnd Bergmann wrote: > When building without CONFIG_GPIOLIB, we get a harmless > warning about an unused variable: > > drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init': > drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable > 'ret'

Re: IMX6 ADV7180 no /dev/media

2017-09-15 Thread Tim Harvey
On Fri, Sep 15, 2017 at 3:26 PM, Steve Longerbeam wrote: > Hi Tim, > > > On 09/15/2017 02:26 PM, Tim Harvey wrote: >> >> Greetings, >> >> I'm testing Linux master built with imx_v6_v7_defconfig on a GW51xx which >> has an ADV7180 analog video decoder and am not seeing the imx6 /dev/media >> node g

Re: IMX6 ADV7180 no /dev/media

2017-09-15 Thread Steve Longerbeam
Hi Tim, On 09/15/2017 02:26 PM, Tim Harvey wrote: Greetings, I'm testing Linux master built with imx_v6_v7_defconfig on a GW51xx which has an ADV7180 analog video decoder and am not seeing the imx6 /dev/media node get created: [    0.00] OF: fdt: Machine model: Gateworks Ventana i.MX6

Re: [PATCH v2 00/10] media: rc: gpio-ir-recv: driver update

2017-09-15 Thread Ladislav Michl
On Mon, Sep 11, 2017 at 09:13:32AM +0200, Ladislav Michl wrote: > On Mon, Sep 11, 2017 at 11:58:43AM +0900, Andi Shyti wrote: > > Hi Ladislav, > > > > > > > Serie was rebased on top of current linux.git, but something > > > > > happened there and my userspace decoder no longer works: driver > > >

[PATCH 2/2] [media] ma901: Improve a size determination in usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:23:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 1/2] [media] ma901: Delete two error messages for a failed memory allocation in usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:20:04 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/radio/radio-ma901.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH 0/2] [media] MA901: Adjustments for usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:31:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve a size determination drivers/media/radio/radio-ma901.c | 4 +---

[PATCH] [media] exynos4-is: properly initialize frame format

2017-09-15 Thread Arnd Bergmann
We copy the subdev frame format from a partially initialized structure, which is not entirely well-defined. Older compilers like gcc-4.4 can copy uninitialized stack data here and warn about it: drivers/media/platform/exynos4-is/fimc-isp.c: In function 'fimc_isp_subdev_open': drivers/media/platfo

[PATCH] [media] solo6x10: hide unused variable

2017-09-15 Thread Arnd Bergmann
When building without CONFIG_GPIOLIB, we get a harmless warning about an unused variable: drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init': drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable 'ret' [-Werror=unused-variable] This adds another #ifdef ar

Re: [media] stm32-dcmi: Improve four size determinations

2017-09-15 Thread SF Markus Elfring
>> +memcpy(dcmi->sd_formats, sd_fmts, num_fmts * sizeof(*dcmi->sd_formats)); > > devm_kmemdup Are function variants provided which handle memory duplications for arrays explicitly? Regards, Markus

[PATCH 2/2] [media] ti-vpe: Adjust nine checks for null pointers

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:22:44 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code pl

[PATCH 1/2] [media] ti-vpe: Delete an error message for a failed memory allocation in two functions

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:15:17 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/platform/ti-vpe/csc.c | 4 +--- drivers/media/platform

[PATCH 0/2] [media] TI-VPE: Adjustments for five function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:30:40 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Adjust nine checks for null pointers drivers/media/platfor

Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers

2017-09-15 Thread Laurent Pinchart
Hi Kieran, On Friday, 15 September 2017 20:49:15 EEST Kieran Bingham wrote: > On 15/09/17 18:02, Laurent Pinchart wrote: > > On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote: > >> The pipeline needs to ensure that the hardware is idle for suspend and > >> resume operations. > > > >

Re: [PATCH 2/2] [media] stm32-dcmi: Improve four size determinations

2017-09-15 Thread Joe Perches
On Fri, 2017-09-15 at 19:29 +0200, SF Markus Elfring wrote: > diff --git a/drivers/media/platform/stm32/stm32-dcmi.c > b/drivers/media/platform/stm32/stm32-dcmi.c [] > @@ -1372,9 +1372,8 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi) > dcmi->sd_formats = devm_kcalloc(dcmi->dev, > -

Re: [PATCHv4 3/5] dt-bindings: document the CEC GPIO bindings

2017-09-15 Thread Rob Herring
On Fri, Sep 15, 2017 at 3:40 AM, Hans Verkuil wrote: > Hi Rob, > > On 09/13/17 10:21, Hans Verkuil wrote: >> On 09/12/2017 04:43 PM, Rob Herring wrote: >>> On Thu, Aug 31, 2017 at 01:01:54PM +0200, Hans Verkuil wrote: From: Hans Verkuil Document the bindings for the cec-gpio module

Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers

2017-09-15 Thread Kieran Bingham
Hi Laurent, Thanks for your speedy review! On 15/09/17 18:02, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote: >> The pipeline needs to ensure that the hardware is idle for suspend and >> resume operations. >

[PATCH 2/2] [media] stm32-dcmi: Improve four size determinations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 18:48:14 +0200 Replace the specification of data types by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elf

[PATCH 1/2] [media] stm32-dcmi: Delete an error message for a failed memory allocation in two functions

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 18:38:25 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/platform/stm32/stm32-dcmi.c | 8 ++-- 1 file chang

[PATCH 0/2] [media] STM32-DCMI: Adjustments for three function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 19:01:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Improve four size determinations drivers/media/platform/st

Re: [PATCH v1 3/3] drm: rcar-du: Remove unused CRTC suspend/resume functions

2017-09-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 15 September 2017 19:42:07 EEST Kieran Bingham wrote: > An early implementation of suspend-resume helpers are available in the > CRTC module, however they are unused and no longer needed. > > With suspend and resume handled by the core DRM atomic he

Re: [PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers

2017-09-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote: > The pipeline needs to ensure that the hardware is idle for suspend and > resume operations. I'm not sure to really understand this sentence. > Implement suspend and resume functions using the

Re: [PATCH v1 1/3] media: vsp1: Prevent resuming DRM pipelines

2017-09-15 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 15 September 2017 19:42:05 EEST Kieran Bingham wrote: > DRM pipelines utilising the VSP must stop all frame processing as part > of the suspend operation to ensure the hardware is idle. Upon resume, > the pipeline must not be started until the DU per

[PATCH v1 3/3] drm: rcar-du: Remove unused CRTC suspend/resume functions

2017-09-15 Thread Kieran Bingham
An early implementation of suspend-resume helpers are available in the CRTC module, however they are unused and no longer needed. With suspend and resume handled by the core DRM atomic helpers, we can remove the unused functions. CC: dri-de...@lists.freedesktop.org Signed-off-by: Kieran Bingham

[PATCH v1 0/3] drm/media: Implement DU Suspend and Resume on VSP pipelines

2017-09-15 Thread Kieran Bingham
This short series covers two subsystems and implements support for suspend and resume operations on the DU pipelines on Gen3 Rcar platforms. Patch 1: Prevent resuming DRM pipelines, - Ensures that the VSP does not incorrectly start DU pipelines. Patch 2: Add suspend resume helpers - Makes use

[PATCH v1 1/3] media: vsp1: Prevent resuming DRM pipelines

2017-09-15 Thread Kieran Bingham
DRM pipelines utilising the VSP must stop all frame processing as part of the suspend operation to ensure the hardware is idle. Upon resume, the pipeline must not be started until the DU performs an atomic flush to restore the hardware configuration and state. Therefore the vsp1_pipeline_resume()

[PATCH v1 2/3] drm: rcar-du: Add suspend resume helpers

2017-09-15 Thread Kieran Bingham
The pipeline needs to ensure that the hardware is idle for suspend and resume operations. Implement suspend and resume functions using the DRM atomic helper functions. CC: dri-de...@lists.freedesktop.org Signed-off-by: Kieran Bingham --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 18 +

[PATCH 2/2] [media] c8sectpfe: Improve two size determinations in c8sectpfe_frontend_attach()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 17:30:38 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Marku

[PATCH 1/2] [media] c8sectpfe: Delete an error message for a failed memory allocation in c8sectpfe_frontend_attach()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 17:20:48 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-dvb.c | 5 + 1 file

[PATCH 0/2] [media] C8SECTPFE: Adjustments for c8sectpfe_frontend_attach()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 17:55:43 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve two size determinations drivers/media/platform/sti/c8sectpfe/c8sect

[PATCH 2/2] vivid: add support for Y10 and Y12

2017-09-15 Thread Hans Verkuil
From: Hans Verkuil Add support for 10 and 12 bit luma formats. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-vid-common.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/platform/vivid/vivid-vid-common.c b/drivers/media/platform/vivid/v

[PATCH 1/2] v4l2-tpg: add Y10 and Y12 support

2017-09-15 Thread Hans Verkuil
From: Hans Verkuil Support the 10 and 12 bit luma formats. Signed-off-by: Hans Verkuil --- drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c b/drivers/media/common/v4l2-tpg/v4l2-tpg-cor

[PATCH] [media] sh_mobile_ceu_camera: Delete an error message for a failed memory allocation in sh_mobile_ceu_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 16:15:47 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/platform/soc_camera/sh_mobile_ceu_camera.c | 4 +--- 1 f

[PATCH v13 22/25] et8ek8: Add support for flash and lens devices

2017-09-15 Thread Sakari Ailus
From: Pavel Machek Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). These types devices aren't directly related to the sensor, but are nevertheless handled by the et8ek8 driver due to the relationship of these component to the main part of the camera module --

[PATCH v13 14/25] v4l: async: Allow binding notifiers to sub-devices

2017-09-15 Thread Sakari Ailus
Registering a notifier has required the knowledge of struct v4l2_device for the reason that sub-devices generally are registered to the v4l2_device (as well as the media device, also available through v4l2_device). This information is not available for sub-device drivers at probe time. What this

[PATCH v13 17/25] v4l: fwnode: Add a helper function for parsing generic references

2017-09-15 Thread Sakari Ailus
Add function v4l2_fwnode_reference_parse() for parsing them as async sub-devices. This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 69 +++

[PATCH v13 21/25] smiapp: Add support for flash and lens devices

2017-09-15 Thread Sakari Ailus
Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). These types devices aren't directly related to the sensor, but are nevertheless handled by the smiapp driver due to the relationship of these component to the main part of the camera module --- the sensor. This d

[PATCH v13 18/25] v4l: fwnode: Add a helper function to obtain device / integer references

2017-09-15 Thread Sakari Ailus
v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under the device's own fwnode, it will follow child fwnodes with the given property-value pair and return the resulting fwnode. Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 201 +++

[PATCH v13 16/25] dt: bindings: Add lens-focus binding for image sensors

2017-09-15 Thread Sakari Ailus
The lens-focus property contains a phandle to the lens voice coil driver that is associated to the sensor; typically both are contained in the same camera module. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Reviewed-by: Sebastian Reichel Acked-by: Rob Herring Acked-by: Hans Verkuil ---

[PATCH v13 24/25] ov13858: Add support for flash and lens devices

2017-09-15 Thread Sakari Ailus
Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/ov13858.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/ov13858.c b/d

[PATCH v13 25/25] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-09-15 Thread Sakari Ailus
Add flash and indicator LED phandles to the sensor node. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- arch/arm/boot/dts/omap3-n9.dts | 1 + arch/arm/boot/dts/omap3-n950-n9.dtsi | 4 ++-- arch/arm/boot/dts/omap3-n950.dts | 1 + 3 files changed, 4 inser

[PATCH v13 23/25] ov5670: Add support for flash and lens devices

2017-09-15 Thread Sakari Ailus
Parse async sub-devices by using v4l2_subdev_fwnode_reference_parse_sensor_common(). Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/i2c/ov5670.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/media/i2c/ov5670.

[PATCH v13 15/25] dt: bindings: Add a binding for flash LED devices associated to a sensor

2017-09-15 Thread Sakari Ailus
Camera flash drivers (and LEDs) are separate from the sensor devices in DT. In order to make an association between the two, provide the association information to the software. Signed-off-by: Sakari Ailus Acked-by: Rob Herring Acked-by: Hans Verkuil Acked-by: Pavel Machek --- Documentation/d

[PATCH v13 20/25] dt: bindings: smiapp: Document lens-focus and flash-leds properties

2017-09-15 Thread Sakari Ailus
Document optional lens-focus and flash-leds properties for the smiapp driver. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- Documentation/devicetree/bindings/media/i2c/nokia,smia.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/

[PATCH v13 19/25] v4l: fwnode: Add convenience function for parsing common external refs

2017-09-15 Thread Sakari Ailus
Add v4l2_fwnode_parse_reference_sensor_common for parsing common sensor properties that refer to adjacent devices such as flash or lens driver chips. As this is an association only, there's little a regular driver needs to know about these devices as such. Signed-off-by: Sakari Ailus Acked-by: H

[PATCH v13 07/25] rcar-vin: Use generic parser for parsing fwnode endpoints

2017-09-15 Thread Sakari Ailus
Instead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 112 +--- drivers/media/platform/rca

[PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

2017-09-15 Thread Sakari Ailus
Instead of using driver implementation, use v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints of the device. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/platform/omap3isp/isp.c | 115 +++--- drivers/media/platform/oma

[PATCH v13 08/25] omap3isp: Fix check for our own sub-devices

2017-09-15 Thread Sakari Ailus
We only want to link sub-devices that were bound to the async notifier the isp driver registered but there may be other sub-devices in the v4l2_device as well. Check for the correct async notifier. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/plat

[PATCH v13 11/25] v4l: async: Introduce helpers for calling async ops callbacks

2017-09-15 Thread Sakari Ailus
Add three helper functions to call async operations callbacks. Besides simplifying callbacks, this allows async notifiers to have no ops set, i.e. it can be left NULL. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-async.c | 49 ++

[PATCH v13 10/25] v4l: async: Move async subdev notifier operations to a separate structure

2017-09-15 Thread Sakari Ailus
From: Laurent Pinchart The async subdev notifier .bound(), .unbind() and .complete() operations are function pointers stored directly in the v4l2_async_subdev structure. As the structure isn't immutable, this creates a potential security risk as the function pointers are mutable. To fix this, mo

[PATCH v13 13/25] v4l: async: Allow async notifier register call succeed with no subdevs

2017-09-15 Thread Sakari Ailus
The information on how many async sub-devices would be bindable to a notifier is typically dependent on information from platform firmware and it's not driver's business to be aware of that. Many V4L2 main drivers are perfectly usable (and useful) without async sub-devices and so if there aren't a

[PATCH v13 09/25] omap3isp: Print the name of the entity where no source pads could be found

2017-09-15 Thread Sakari Ailus
If no source pads are found in an entity, print the name of the entity. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Pavel Machek --- drivers/media/platform/omap3isp/isp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/is

[PATCH v13 12/25] v4l: async: Register sub-devices before calling bound callback

2017-09-15 Thread Sakari Ailus
Register the sub-device before calling the notifier's bound callback. Doing this the other way around is problematic as the struct v4l2_device has not assigned for the sub-device yet and may be required by the bound callback. Signed-off-by: Sakari Ailus Acked-by: Hans Verkuil --- drivers/media/

[PATCH v13 00/25] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-09-15 Thread Sakari Ailus
Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority o

[PATCH v13 04/25] v4l: async: Add V4L2 async documentation to the documentation build

2017-09-15 Thread Sakari Ailus
The V4L2 async wasn't part of the documentation build. Fix this. Signed-off-by: Sakari Ailus Reviewed-by: Niklas Söderlund Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart --- Documentation/media/kapi/v4l2-async.rst | 3 +++ Documentation/media/kapi/v4l2-core.rst | 1 + 2 files changed,

[PATCH v13 05/25] v4l: fwnode: Support generic parsing of graph endpoints in a device

2017-09-15 Thread Sakari Ailus
Add two functions for parsing devices graph endpoints: v4l2_async_notifier_parse_fwnode_endpoints and v4l2_async_notifier_parse_fwnode_endpoints_by_port. The former iterates over all endpoints whereas the latter only iterates over the endpoints in a given port. The former is mostly useful for exis

[PATCH v13 03/25] v4l: async: Use more intuitive names for internal functions

2017-09-15 Thread Sakari Ailus
Rename internal functions to make the names of the functions better describe what they do. Old nameNew name v4l2_async_test_notify v4l2_async_match_notify v4l2_async_belongs v4l2_async_find_match Signed-off-by: Sakari Ailus Acked-by: Hans Ver

[PATCH v13 01/25] v4l: fwnode: Move KernelDoc documentation to the header

2017-09-15 Thread Sakari Ailus
In V4L2 the practice is to have the KernelDoc documentation in the header and not in .c source code files. This consequently makes the V4L2 fwnode function documentation part of the Media documentation build. Also correct the link related function and argument naming in documentation. Signed-off-

[PATCH v13 02/25] v4l: async: Remove re-probing support

2017-09-15 Thread Sakari Ailus
Remove V4L2 async re-probing support. The re-probing support has been there to support cases where the sub-devices require resources provided by the main driver's hardware to function, such as clocks. Reprobing has allowed unbinding and again binding the main driver without explicilty unbinding th

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-15 Thread Sakari Ailus
Hi Hans, On Wed, Sep 13, 2017 at 12:32:17PM +0200, Hans Verkuil wrote: > On 09/13/17 12:07, Sakari Ailus wrote: > > Hi Hans, > > > > On Wed, Sep 13, 2017 at 11:28:44AM +0200, Hans Verkuil wrote: > >> On 09/13/17 11:24, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> Thanks for the review! > >>> >

Re: [PATCH v2] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

2017-09-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Sep 2017 06:18:20 -0400 Satendra Singh Thakur escreveu: > Hello Mr Chehab, > Thanks for the comments. > I have modified dtv_property_process_set and > also added documentation. > Please let me know if any further modifications required. That's a way better. Just a few minor things to

Re: [PATCH] [media] cec: GIVE_PHYSICAL_ADDR should respond to unregistered device

2017-09-15 Thread Jose Abreu
Hi Hans, On 14-09-2017 16:46, Hans Verkuil wrote: > On 09/14/2017 05:30 PM, Jose Abreu wrote: >> >> On 14-09-2017 16:09, Hans Verkuil wrote: >>> On 09/14/17 15:28, Jose Abreu wrote: >>> Actually, I have at least one more fix which I don't know if it's valid and I didn't manage to actuall

Re: [PATCH] util: qv4l2: fix discrete frame size selection.

2017-09-15 Thread Hans Verkuil
Hi Konstantin, On 09/15/17 11:28, Konstantin Oblaukhov wrote: > qv4l2 hasn't work correctly with discrete frame sizes. > In case of capture device with discrete frame sizes, size combo-box wasn't > shown. Apparently this is a device driver that uses both V4L2_IN_CAP_DV_TIMINGS and has discrete

[PATCH v2] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

2017-09-15 Thread Satendra Singh Thakur
Hello Mr Chehab, Thanks for the comments. I have modified dtv_property_process_set and also added documentation. Please let me know if any further modifications required. Signed-off-by: Satendra Singh Thakur --- .../media/uapi/dvb/fe-set-property-short.rst | 60 + Documentation/m

Re: [PATCH 5/5] media: dvb_frontend: get rid of set_property() callback

2017-09-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Sep 2017 06:11:01 -0300 Mauro Carvalho Chehab escreveu: > Now that all clients of set_property() were removed, get rid > of this callback. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-core/dvb_frontend.c | 7 --- > drivers/media/dvb-core/dvb_frontend.h | 2

[PATCH] dma-fence: fix dma_fence_get_rcu_safe v2

2017-09-15 Thread Christian König
From: Christian König When dma_fence_get_rcu() fails to acquire a reference it doesn't necessary mean that there is no fence at all. It usually mean that the fence was replaced by a new one and in this situation we certainly want to have the new one as result and *NOT* NULL. v2: Keep extra chec

Re: [PATCH 2/5] media: stv6110: get rid of a srate dead code

2017-09-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Sep 2017 11:30:11 +0200 Honza Petrouš escreveu: > Mauro, you are so speedy :) > > 2017-09-15 11:10 GMT+02:00 Mauro Carvalho Chehab : > > The stv6110 has a weird code that checks if get_property > > and set_property ioctls are defined. If they're, it initializes > > a "srate" var from

Re: [PATCH 2/5] media: stv6110: get rid of a srate dead code

2017-09-15 Thread Honza Petrouš
Mauro, you are so speedy :) 2017-09-15 11:10 GMT+02:00 Mauro Carvalho Chehab : > The stv6110 has a weird code that checks if get_property > and set_property ioctls are defined. If they're, it initializes > a "srate" var from properties cache. Otherwise, it sets to > 15MBaud, with won't make any se

[PATCH] util: qv4l2: fix discrete frame size selection.

2017-09-15 Thread Konstantin Oblaukhov
qv4l2 hasn't work correctly with discrete frame sizes. In case of capture device with discrete frame sizes, size combo-box wasn't shown. In case of output device with discrete frame sizes, qv4l2 was segfaulting. This patch fix discrete size combo-box both for capture and output devices. Also Qt'

[PATCH 4/5] media: dvb_frontend: get rid of get_property() callback

2017-09-15 Thread Mauro Carvalho Chehab
Only lg2160 implement gets_property, but there's no need for that, as no other driver calls this callback, as get_frontend() does the same, and set_frontend() also calls lg2160 get_frontend(). So, get rid of it. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Michael Ira Krufky --- drivers/m

[PATCH 1/5] media: stv0288: get rid of set_property boilerplate

2017-09-15 Thread Mauro Carvalho Chehab
This driver doesn't implement support for set_property(). Yet, it implements a boilerplate for it. Get rid of it. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/stv0288.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0288.c b/driv

[PATCH 3/5] media: friio-fe: get rid of set_property()

2017-09-15 Thread Mauro Carvalho Chehab
This callback is not actually doing anything but making it to return an error depending on the DTV frontend command. Well, that could break userspace for no good reason, and, if needed, should be implemented, instead, at set_frontend() callback. So, get rid of it. Signed-off-by: Mauro Carvalho Ch

[PATCH 2/5] media: stv6110: get rid of a srate dead code

2017-09-15 Thread Mauro Carvalho Chehab
The stv6110 has a weird code that checks if get_property and set_property ioctls are defined. If they're, it initializes a "srate" var from properties cache. Otherwise, it sets to 15MBaud, with won't make any sense. Thankfully, it seems that someone already noticed, as the "srate" is not used anyw

[PATCH 5/5] media: dvb_frontend: get rid of set_property() callback

2017-09-15 Thread Mauro Carvalho Chehab
Now that all clients of set_property() were removed, get rid of this callback. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-core/dvb_frontend.c | 7 --- drivers/media/dvb-core/dvb_frontend.h | 2 -- 2 files changed, 9 deletions(-) diff --git a/drivers/media/dvb-core/dvb_fronte

Re: [PATCH v1] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

2017-09-15 Thread Mauro Carvalho Chehab
Em Fri, 15 Sep 2017 01:50:29 -0400 Satendra Singh Thakur escreveu: > Hello Mr Chehab, > Thanks for reviewing the patch. > I have modified the patch as per your comments. > Please check if it looks fine now. Forgot to mention, but, for the patch series to be applied, you'll need to also patch Do

Re: [PATCH] dma-buf: remove redundant initialization of sg_table

2017-09-15 Thread Chris Wilson
Quoting Colin King (2017-09-15 00:05:16) > From: Colin Ian King > > sg_table is being initialized and is never read before it is updated > again later on, hence making the initialization redundant. Remove > the initialization. > > Detected by clang scan-build: > "warning: Value stored to 'sg_tab

Re: [PATCHv4 3/5] dt-bindings: document the CEC GPIO bindings

2017-09-15 Thread Hans Verkuil
Hi Rob, On 09/13/17 10:21, Hans Verkuil wrote: > On 09/12/2017 04:43 PM, Rob Herring wrote: >> On Thu, Aug 31, 2017 at 01:01:54PM +0200, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> Document the bindings for the cec-gpio module for hardware where the >>> CEC line and optionally the HPD line

Re: [RFC] [DVB][FRONTEND] Added a new ioctl for optimizing frontend property set operation

2017-09-15 Thread Honza Petrouš
2017-09-14 22:50 GMT+02:00 Mauro Carvalho Chehab : > Hi Satendra, > > Em Thu, 14 Sep 2017 05:59:27 -0400 > Satendra Singh Thakur escreveu: > >> -For setting one frontend property , one FE_SET_PROPERTY ioctl is called >> -Since, size of struct dtv_property is 72 bytes, this ioctl requires >> ---all

RE: [PATCH] [media] rcar_drif: fix potential uninitialized variable use

2017-09-15 Thread Ramesh Shanmugasundaram
Hi Arnd, Thank you for the patch. > Subject: [PATCH] [media] rcar_drif: fix potential uninitialized variable > use > > Older compilers like gcc-4.6 may run into a case that returns an > uninitialized variable from rcar_drif_enable_rx() if that function was > ever called with an empty cur_ch_mask

[GIT FIXES FOR v4.14] Two CEC fixes

2017-09-15 Thread Hans Verkuil
Hi Mauro, Two CEC fixes for 4.14. Both are also CC-ed to stable. These fixes fall in the category 'important but not urgent'. Regards, Hans The following changes since commit 1efdf1776e2253b77413c997bed862410e4b6aaf: media: leds: as3645a: add V4L2_FLASH_LED_CLASS dependency (2017-09-

[PATCH 9/9] [media] tm6000: Use common error handling code in tm6000_prepare_isoc()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 08:02:33 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/media/usb/tm6000/tm6000-video.c | 13 +++-- 1 file changed, 7 insertions(+), 6 de

[PATCH 8/9] [media] tm6000: Use common error handling code in tm6000_start_stream()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 07:47:41 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/media/usb/tm6000/tm6000-dvb.c | 11 +++ 1 file changed, 7 insertions(+), 4 deleti

[PATCH 7/9] [media] tm6000: Improve a size determination in dvb_init()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 07:33:24 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

[PATCH 6/9] [media] tm6000: Use common error handling code in tm6000_cards_setup()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:26:42 +0200 Add a jump target so that a bit of exception handling can be better reused in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/usb/tm6000/tm6000-cards.c | 7 +++--

[PATCH 5/9] [media] tm6000: Delete an unnecessary variable initialisation in tm6000_usb_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:13:56 +0200 The local variable "rc" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/media/usb/tm6000/tm6000-cards.c | 2 +- 1 file changed, 1 insert

[PATCH 4/9] [media] tm6000: One function call less in tm6000_usb_probe() after error detection

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:11:55 +0200 * Adjust jump targets so that the function "kfree" will be always called with a non-null pointer. * Delete an initialisation for the local variable "dev" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

[PATCH v5 1/2] media:imx274 device tree binding file

2017-09-15 Thread Leon Luo
The binding file for imx274 CMOS sensor V4l2 driver Signed-off-by: Leon Luo --- v5: - add 'port' and 'endpoint' information v4: - no changes v3: - remove redundant properties and references - document 'reg' property v2: - no changes --- .../devicetree/bindings/media/i2c/imx274.txt | 3

[PATCH v5 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

2017-09-15 Thread Leon Luo
The imx274 is a Sony CMOS image sensor that has 1/2.5 image size. It supports up to 3840x2160 (4K) 60fps, 1080p 120fps. The interface is 4-lane MIPI CSI-2 running at 1.44Gbps each. This driver has been tested on Xilinx ZCU102 platform with a Leopard LI-IMX274MIPI-FMC camera board. Support for the

[PATCH 3/9] [media] tm6000: Use common error handling code in tm6000_usb_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 16:00:47 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/media/usb/tm6000/tm6000-cards.c | 11 ++- 1 file changed, 6 insertions(+), 5 dele

[PATCH 2/9] [media] tm6000: Adjust seven checks for null pointers

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 14:51:15 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code pla

[PATCH 1/9] [media] tm6000: Delete seven error messages for a failed memory allocation

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 14 Sep 2017 14:34:39 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/usb/tm6000/tm6000-cards.c | 1 - drivers/media/usb/tm60

[PATCH 0/9] [media] TM6000: Adjustments for some function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 08:24:56 +0200 Some update suggestions were taken into account from static source code analysis. Markus Elfring (9): Delete seven error messages for a failed memory allocation Adjust seven checks for null pointers Use common error handling code i

Re: [PATCH v1] media: ov13858: Fix 4224x3136 video flickering at some vblanks

2017-09-15 Thread Tomasz Figa
Hi Chiranjeevi, On Thu, Sep 14, 2017 at 7:38 AM, Chiranjeevi Rapolu wrote: > Previously, the sensor was outputting blank every other frame at 4224x3136 > video when vblank was in the range [79, 86]. This resulted in video > flickering. > > Omni Vision recommends us to use their settings for crop