For bulk-based devices, when disabling the video stream,
in addition to issue CLEAR_FEATURE(HALT), it is better to set
alternate setting 0 as well or the sequnce number in host
side will probably not reset to zero.
Then in next time video stream start, the device will expect
host starts packet fro
Hello Mr Chehab,
Thanks for reviewing the patch.
I have modified the patch as per your comments.
Please check if it looks fine now.
Signed-off-by: Satendra Singh Thakur
---
drivers/media/dvb-core/dvb_frontend.c | 212 +-
include/uapi/linux/dvb/frontend.h | 2
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Sep 15 05:00:23 CEST 2017
media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf
media_build gi
Hi Ricardo,
Thank you for the patch.
On Wednesday, 13 September 2017 10:35:52 EEST Ricardo Ribalda Delgado wrote:
> max_width and max_height are swap with step_width and step_height.
>
> Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Laurent Pinchart
> ---
>
> Since that this bug has b
From: Colin Ian King
sg_table is being initialized and is never read before it is updated
again later on, hence making the initialization redundant. Remove
the initialization.
Detected by clang scan-build:
"warning: Value stored to 'sg_table' during its initialization is
never read"
Signed-off-
Hi Satendra,
Em Thu, 14 Sep 2017 05:59:27 -0400
Satendra Singh Thakur escreveu:
> -For setting one frontend property , one FE_SET_PROPERTY ioctl is called
> -Since, size of struct dtv_property is 72 bytes, this ioctl requires
> ---allocating 72 bytes of memory in user space
> ---allocating 72 by
<>
Hi Maxime,
Thank you for the patch.
On Monday, 4 September 2017 16:03:34 EEST Maxime Ripard wrote:
> The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to
> 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on
> the hardware implementation.
>
> It can ope
On 09/14/2017 05:30 PM, Jose Abreu wrote:
>
>
> On 14-09-2017 16:09, Hans Verkuil wrote:
>> On 09/14/17 15:28, Jose Abreu wrote:
>>
>>> Actually, I have at least one more fix which I don't know if it's
>>> valid and I didn't manage to actually write it in a nice way.
>>> This one is for CEC 2.0.
On 14-09-2017 16:09, Hans Verkuil wrote:
> On 09/14/17 15:28, Jose Abreu wrote:
>
>> Actually, I have at least one more fix which I don't know if it's
>> valid and I didn't manage to actually write it in a nice way.
>> This one is for CEC 2.0. My test equipment (which is certified)
>> in some tes
Running CEC 1.4 compliance test we get the following error on test
11.1.6.2: "ERROR: The DUT did not broadcast a
message to the unregistered device."
Fix this by letting GIVE_PHYSICAL_ADDR message respond to unregistered
device. Also, GIVE_DEVICE_VENDOR_ID and GIVE_FEATURES fall in the
same categ
On 09/14/17 15:28, Jose Abreu wrote:
> Hi Hans,
>
> On 14-09-2017 14:10, Hans Verkuil wrote:
>> On 09/14/17 13:33, Jose Abreu wrote:
>>> Running CEC 1.4 compliance test we get the following error on test
>>> 11.1.6.2: "ERROR: The DUT did not broadcast a
>>> message to the unregistered device."
>>
Hi Hans,
On 14-09-2017 14:10, Hans Verkuil wrote:
> On 09/14/17 13:33, Jose Abreu wrote:
>> Running CEC 1.4 compliance test we get the following error on test
>> 11.1.6.2: "ERROR: The DUT did not broadcast a
>> message to the unregistered device."
>>
>> Fix this by letting GIVE_PHYSICAL_ADDR mess
On 09/14/2017 01:53 PM, Pavel Machek wrote:
On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote:
On 09/14/2017 12:07 PM, Pavel Machek wrote:
Isn't the V4L2 subdev/Media Controller API supposed to provide means
for associating flash LEDs with camera sensors? You seem to be insisting
on using th
On 09/14/17 13:33, Jose Abreu wrote:
> Running CEC 1.4 compliance test we get the following error on test
> 11.1.6.2: "ERROR: The DUT did not broadcast a
> message to the unregistered device."
>
> Fix this by letting GIVE_PHYSICAL_ADDR message respond to unregistered
> device.
>
> With this fix
On Thu, Sep 14, 2017 at 7:44 AM, Mauro Carvalho Chehab
wrote:
> Only lg2160 implement gets_property, but there's no need for that,
> as no other driver calls this callback, as get_frontend() does the
> same, and set_frontend() also calls lg2160 get_frontend().
>
> So, get rid of it.
>
> Signed-off
On Tue, Sep 12, 2017 at 02:13:12PM -0500, Benoit Parrot wrote:
> > > + /*
> > > + * Create a static mapping between the CSI virtual channels
> > > + * and the output stream.
> > > + *
> > > + * This should be enhanced, but v4l2 lacks the support for
> > > + * changing that mapping dynamically.
Hi Benoit,
Thanks for your comments,
On Tue, Sep 12, 2017 at 01:23:39PM -0500, Benoit Parrot wrote:
> > +static int csi2rx_probe(struct platform_device *pdev)
> > +{
> > + struct v4l2_async_subdev **subdevs;
> > + struct csi2rx_priv *csi2rx;
> > + unsigned int i;
> > + int ret;
> > +
> >
On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote:
> On 09/14/2017 12:07 PM, Pavel Machek wrote:
> >>Isn't the V4L2 subdev/Media Controller API supposed to provide means
> >>for associating flash LEDs with camera sensors? You seem to be insisting
> >>on using the sysfs leds interface for that, w
This driver doesn't implement support for set_property(). Yet,
it implements a boilerplate for it. Get rid of it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/stv0288.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv0288.c
b/driv
This callback is not actually doing anything but making it to
return an error depending on the DTV frontend command. Well,
that could break userspace for no good reason, and, if needed,
should be implemented, instead, at set_frontend() callback.
So, get rid of it.
Signed-off-by: Mauro Carvalho Ch
There's no reason why it would hardcode symbol rate to 15MBaud
if get_property ops is not defined.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-frontends/stv6110.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/dvb-frontends/stv6110.c
b/dr
Now that all clients of set_property() were removed, get rid
of this callback.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 7 ---
drivers/media/dvb-core/dvb_frontend.h | 2 --
2 files changed, 9 deletions(-)
diff --git a/drivers/media/dvb-core/dvb_fronte
Only lg2160 implement gets_property, but there's no need for that,
as no other driver calls this callback, as get_frontend() does the
same, and set_frontend() also calls lg2160 get_frontend().
So, get rid of it.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/dvb-core/dvb_frontend.c | 9
Running CEC 1.4 compliance test we get the following error on test
11.1.6.2: "ERROR: The DUT did not broadcast a
message to the unregistered device."
Fix this by letting GIVE_PHYSICAL_ADDR message respond to unregistered
device.
With this fix we pass CEC 1.4 official compliance.
Signed-off-by:
Older compilers like gcc-4.6 may run into a case that returns
an uninitialized variable from rcar_drif_enable_rx() if that
function was ever called with an empty cur_ch_mask:
drivers/media/platform/rcar_drif.c:658:2: error: ‘ret’ may be used
uninitialized in this function [-Werror=uninitialized]
On 09/14/2017 12:07 PM, Pavel Machek wrote:
Isn't the V4L2 subdev/Media Controller API supposed to provide means
for associating flash LEDs with camera sensors? You seem to be insisting
on using the sysfs leds interface for that, which is not a primary
interface for camera flash AFAICT.
>
a) su
Ahoj,
Obsah tejto správy je ve?mi dôverný. moje meno je Yi Tan, pracujem s bankou tu
v Hongkongu.
Rozhodla som sa, ?e vás budem kontaktova? za mo?nos? investova? do akéhoko?vek
lukratívneho podnikania vo va?ej krajine, som ochotný ponúknu? 40% ako môj
obchodný partner.
Ak máte záujem, odpoved
From: Markus Elfring
Date: Wed, 13 Sep 2017 22:22:41 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: space prohibited after that open parenthesis '('
Thus fix affected source code places.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_
From: Markus Elfring
Date: Wed, 13 Sep 2017 22:12:07 +0200
The script "checkpatch.pl" pointed information out like the following.
ERROR: spaces required around that '=' (ctx:VxV)
Thus fix the affected source code places.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_dec
From: Markus Elfring
Date: Wed, 13 Sep 2017 21:23:29 +0200
* Move the definition for the local variables "b", "d" and "length" into
an if branch so that the corresponding setting will only be performed
if a memory allocation succeeded in this function.
* Adjust their data types.
Signed-off-
From: Markus Elfring
Date: Wed, 13 Sep 2017 20:32:25 +0200
Assign a pointer to a data structure member without using an intermediate
local variable.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_dec.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git
From: Markus Elfring
Date: Wed, 13 Sep 2017 20:10:39 +0200
Omit an extra message for a memory allocation failure in this function.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_dec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/usb/
From: Markus Elfring
Date: Wed, 13 Sep 2017 19:56:38 +0200
* The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix a few source code places.
* Replace the specification of data structures by pointer dereferences
as th
From: Markus Elfring
Date: Wed, 13 Sep 2017 18:22:35 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code pla
From: Markus Elfring
Date: Wed, 13 Sep 2017 18:08:19 +0200
Add jump targets so that a bit of exception handling can be better reused
at the end of this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/media/usb/ttusb-dec/ttusb_dec.c
From: Markus Elfring
Date: Thu, 14 Sep 2017 12:26:24 +0200
Some update suggestions were taken into account
from static source code analysis.
Markus Elfring (8):
Use common error handling code in ttusb_dec_init_dvb()
Adjust five checks for null pointers
Improve a size determination in three
Hi Pavel and others,
On 09/14/17 13:07, Pavel Machek wrote:
> Hi!
>
>> What directory are the flash controls in?
>>
>> /sys/class/leds/led-controller:flash ?
>>
>> Could we arrange for something less generic, like
>>
>> /sys/class/leds/main-camera:flash ?
>
> I
Use kcalloc instead of kzalloc to check for an overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma
---
drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_firmware.c | 4 +++-
1
Hi!
> What directory are the flash controls in?
>
> /sys/class/leds/led-controller:flash ?
>
> Could we arrange for something less generic, like
>
> /sys/class/leds/main-camera:flash ?
> >>>
> >>>I'd rather avoid overcomplicating this. LED class device name pattern
>
-For setting one frontend property , one FE_SET_PROPERTY ioctl is called
-Since, size of struct dtv_property is 72 bytes, this ioctl requires
---allocating 72 bytes of memory in user space
---allocating 72 bytes of memory in kernel space
---copying 72 bytes of data from user space to kernel space
-
Hi,
On 09/13/2017 07:53 PM, Jacek Anaszewski wrote:
On 09/12/2017 11:55 PM, Pavel Machek wrote:
On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote:
On 09/12/2017 12:36 PM, Pavel Machek wrote:
What directory are the flash controls in?
/sys/class/leds/led-controller:flash ?
Could we arrange
On Wed, Sep 13, 2017 at 10:50 AM, Geert Uytterhoeven
wrote:
> On Thu, Jul 20, 2017 at 12:54 PM, Mauro Carvalho Chehab
> wrote:
>> This is an automatic generated email to let you know that the following
>> patch were queued:
>>
>> Subject: media: adv7180: add missing adv7180cp, adv7180st i2c devi
43 matches
Mail list logo
