[PATCH v2 3/3] media: ov7670: Add the s_power operation

2017-09-13 Thread Wenyou Yang
Add the s_power operation which is responsible for manipulating the power dowm mode through the PWDN pin and the reset operation through the RESET pin. Signed-off-by: Wenyou Yang --- Changes in v2: - Add the patch to support the get_fmt ops. - Remove the redundant invoking ov7670_init_gpio().

[PATCH v2 2/3] media: ov7670: Add the get_fmt callback

2017-09-13 Thread Wenyou Yang
Add the get_fmt callback, also enable V4L2_SUBDEV_FL_HAS_DEVNODE flag to make this subdev has device node. Signed-off-by: Wenyou Yang --- Changes in v2: None drivers/media/i2c/ov7670.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/media/i2c/ov7670.c b/

[PATCH v2 1/3] media: ov7670: Add entity pads initialization

2017-09-13 Thread Wenyou Yang
Add the media entity pads initialization. Signed-off-by: Wenyou Yang --- Changes in v2: None drivers/media/i2c/ov7670.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index e88549f0e704..5c8460ee65c3 100

[PATCH v2 0/3] media: ov7670: Add entity init and power operation

2017-09-13 Thread Wenyou Yang
This patch set is to add the media entity pads initialization, the s_power operation and get_fmt callback support. Changes in v2: - Add the patch to support the get_fmt ops. - Remove the redundant invoking ov7670_init_gpio(). Wenyou Yang (3): media: ov7670: Add entity pads initialization me

cron job: media_tree daily build: WARNINGS

2017-09-13 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Sep 14 05:00:16 CEST 2017 media-tree git hash:1efdf1776e2253b77413c997bed862410e4b6aaf media_build gi

[PATCH v9 0/4] Add Rockchip RGA V4l2 support

2017-09-13 Thread Jacob Chen
This patch series add a v4l2 m2m drvier for rockchip RGA direct rendering based 2d graphics acceleration module. Recently I tried to add protduff support for gstreamer on rockchip platform, and i found that API were not very suitable for my purpose. It shouldn't go upstream until we can figure

[PATCH v9 4/4] dt-bindings: Document the Rockchip RGA bindings

2017-09-13 Thread Jacob Chen
Add DT bindings documentation for Rockchip RGA Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang Acked-by: Rob Herring --- .../devicetree/bindings/media/rockchip-rga.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/me

[PATCH v9 3/4] arm64: dts: rockchip: add RGA device node for RK3399

2017-09-13 Thread Jacob Chen
This patch add the RGA dt config of RK3399 SoC. Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi

[PATCH v9 2/4] ARM: dts: rockchip: add RGA device node for RK3288

2017-09-13 Thread Jacob Chen
This patch add the RGA dt config of rk3288 SoC. Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang --- arch/arm/boot/dts/rk3288.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 595d395..ca6c63a 100644 ---

Re: [PATCH v9 0/4] Add Rockchip RGA V4l2 support

2017-09-13 Thread Jacob Chen
Hi all, 2017-09-14 9:19 GMT+08:00 Jacob Chen : > This patch series add a v4l2 m2m drvier for rockchip RGA direct rendering > based 2d graphics acceleration module. > > Recently I tried to add protduff support for gstreamer on rockchip platform, > and i found that API > were not very suitable fo

[PATCH v9 1/4] rockchip/rga: v4l2 m2m support

2017-09-13 Thread Jacob Chen
Rockchip RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D graphics operations, such as point/line drawing, image scaling, rotation, BitBLT, alpha blending and image blur/sharpness The drvier is mostly based on s5p-g2d v4l2 m2m driver And supports various operations from the

Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
On 09/13/2017 09:13 PM, Sylwester Nawrocki wrote: On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) .num_clocks = 1, }; +static struct gsc_driverdata gsc_v_5250_drvdata = { +.variant = { +[0] = &gsc_

Investi?ná príležitos?

2017-09-13 Thread Yi Tan
Ahoj, Obsah tejto správy je ve?mi dôverný. moje meno je Yi Tan, pracujem s bankou tu v Hongkongu. Rozhodla som sa, ?e vás budem kontaktova? za mo?nos? investova? do akéhoko?vek lukratívneho podnikania vo va?ej krajine, som ochotný ponúknu? 40% ako môj obchodný partner. Ak máte záujem, odpoved

[PATCH v1] media: ov13858: Fix 4224x3136 video flickering at some vblanks

2017-09-13 Thread Chiranjeevi Rapolu
Previously, the sensor was outputting blank every other frame at 4224x3136 video when vblank was in the range [79, 86]. This resulted in video flickering. Omni Vision recommends us to use their settings for crop start/end for 4224x3136. Signed-off-by: Chiranjeevi Rapolu --- drivers/media/i2c/ov

Re: [PATCH 2/3] dt: bindings: as3645a: Use LED number to refer to LEDs

2017-09-13 Thread Rob Herring
On Fri, Sep 08, 2017 at 03:42:12PM +0300, Sakari Ailus wrote: > Use integers (reg property) to tell the number of the LED to the driver > instead of the node name. While both of these approaches are currently > used by the LED bindings, using integers will require less driver changes > for ACPI sup

[PATCH] [media] saa7146: make saa7146_use_ops const

2017-09-13 Thread Bhumika Goyal
Make these const as they are not modified in the file referencing them. They are only used when their function pointer fields invokes a function and therefore none of the structure fields are getting modified. Also, add a const to the declaration in the header. Signed-off-by: Bhumika Goyal --- d

Re: as3645a flash userland interface

2017-09-13 Thread Jacek Anaszewski
On 09/12/2017 11:55 PM, Pavel Machek wrote: > On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote: >> Hi Pavel, >> >> On 09/12/2017 12:36 PM, Pavel Machek wrote: >>> Hi! >>> >>> There were some changes to as3645a flash controller. Before we have >>> stable interface we have to keep forever I want to

Re: [PATCH] [media] s3c-camif: fix out-of-bounds array access

2017-09-13 Thread Sylwester Nawrocki
On 09/13/2017 04:03 PM, Arnd Bergmann wrote: On Wed, Sep 13, 2017 at 11:25 AM, Sylwester Nawrocki wrote: On 09/12/2017 10:09 PM, Arnd Bergmann wrote: { const struct s3c_camif_variant *variant = camif->variant; const struct vp_pix_limits *pix_lim; - int i = ARRAY_SIZE(cami

Re: [PATCH v2 0/4] BCM283x Camera Receiver driver

2017-09-13 Thread Dave Stevenson
(dropping to linux-media and linux-rpi-kernel mailing lists as the device tree folk aren't going to be bothered by v4l2-compliance results) v4l2-compliance results: TC358743 (having loaded an EDID config) v4l2-compliance SHA : f6ecbc90656815d91dc6ba90aac0ad8193a14b38 Driver Info: Driver n

Re: IR driver support for tango platforms

2017-09-13 Thread Mason
On 13/09/2017 16:57, Sean Young wrote: On Sep 13, 2017 at 16:03, Mason wrote: Changes from v1 to v2: o Rebase driver on top of linuxtv/master o Use ir_nec_bytes_to_scancode() in tango_ir_handle_nec() o Use devm_rc_allocate_device() in tango_ir_probe() o Use Use devm_rc_register_device() in ta

[PATCH v2 3/4] [media] bcm2835-unicam: Driver for CCP2/CSI2 camera interface

2017-09-13 Thread Dave Stevenson
Add driver for the Unicam camera receiver block on BCM283x processors. Signed-off-by: Dave Stevenson --- drivers/media/platform/Kconfig |1 + drivers/media/platform/Makefile |1 + drivers/media/platform/bcm2835/Kconfig | 14 + drivers/media/

[PATCH v2 4/4] MAINTAINERS: Add entry for BCM2835 camera driver

2017-09-13 Thread Dave Stevenson
Signed-off-by: Dave Stevenson --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb930eb..b47ddaa 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2713,6 +2713,13 @@ S: Maintained N: bcm2835 F: drivers/staging/vc04_services +

[PATCH v2 0/4] BCM283x Camera Receiver driver

2017-09-13 Thread Dave Stevenson
Hi All. This is v2 for adding a V4L2 subdevice driver for the CSI2/CCP2 camera receiver peripheral on BCM283x, as used on Raspberry Pi. Sorry for the delay since v1 - other tasks assigned, got sucked into investigating why some devices were misbehaving, and picking up on new features that had been

[PATCH v2 2/4] [media] dt-bindings: Document BCM283x CSI2/CCP2 receiver

2017-09-13 Thread Dave Stevenson
Document the DT bindings for the CSI2/CCP2 receiver peripheral (known as Unicam) on BCM283x SoCs. Signed-off-by: Dave Stevenson --- .../devicetree/bindings/media/bcm2835-unicam.txt | 107 + 1 file changed, 107 insertions(+) create mode 100644 Documentation/devicetree/bindi

[PATCH v2 1/4] [media] v4l2-common: Add helper function for fourcc to string

2017-09-13 Thread Dave Stevenson
New helper function char *v4l2_fourcc2s(u32 fourcc, char *buf) that converts a fourcc into a nice printable version. Signed-off-by: Dave Stevenson --- drivers/media/v4l2-core/v4l2-common.c | 18 ++ include/media/v4l2-common.h | 3 +++ 2 files changed, 21 insertions(+)

Re: IR driver support for tango platforms

2017-09-13 Thread Sean Young
Hi, On Wed, Sep 13, 2017 at 04:03:43PM +0200, Mason wrote: > On 12/09/2017 20:19, Sean Young wrote: > > > It looks great, thanks! I have made some minor points below. > > Thanks for having reviewed the driver! :-) > > I have now fixed all the points you mentioned. > > Changes from v1 to v2: >

Re: IR driver support for tango platforms

2017-09-13 Thread Mason
On 12/09/2017 20:19, Sean Young wrote: It looks great, thanks! I have made some minor points below. Thanks for having reviewed the driver! :-) I have now fixed all the points you mentioned. Changes from v1 to v2: o Rebase driver on top of linuxtv/master o Use ir_nec_bytes_to_scancode() in t

Re: [PATCH] [media] s3c-camif: fix out-of-bounds array access

2017-09-13 Thread Arnd Bergmann
On Wed, Sep 13, 2017 at 11:25 AM, Sylwester Nawrocki wrote: > On 09/12/2017 10:09 PM, Arnd Bergmann wrote: >> { >> const struct s3c_camif_variant *variant = camif->variant; >> const struct vp_pix_limits *pix_lim; >> - int i = ARRAY_SIZE(camif_mbus_formats); >> >> /* FIXME:

Re: [PATCH] s5p-cec: add NACK detection support

2017-09-13 Thread Sylwester Nawrocki
On 08/31/2017 06:56 PM, Hans Verkuil wrote: The s5p-cec driver returned CEC_TX_STATUS_ERROR for the NACK condition. Some digging into the datasheet uncovered the S5P_CEC_TX_STAT1 register where bit 0 indicates if the transmit was nacked or not. Use this to return the correct CEC_TX_STATUS_NACK

Re: [PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits

2017-09-13 Thread Sylwester Nawrocki
On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: Hoegeun Kwon (4): [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version ARM: dts: exynos: Add clean name of compatible. drm/exynos/gsc: Add hardware rotation limits [media] exynos-gsc: Add hardware rotation limits

Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Sylwester Nawrocki
On 09/13/2017 01:41 PM, Hoegeun Kwon wrote: @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) .num_clocks = 1, }; +static struct gsc_driverdata gsc_v_5250_drvdata = { + .variant = { + [0] = &gsc_v_5250_variant, + [1] =

[PATCH v4 0/4] Exynos-gsc: Support the hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
Hello all, Frist, thanks Krzysztof, Robin and Sylwester. The gscaler has hardware rotation limits. So this patch set support the rotate hardware limits of gsc. Changes for V4: - Fixed the most specific compatible come first in device tree. - Kept compatible("samsung,exynos5-gsc") in ther driver.

[PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
The hardware rotation limits of gsc depends on SOC (Exynos 5250/5420/5433). Distinguish them and add them to the driver data. Signed-off-by: Hoegeun Kwon --- drivers/media/platform/exynos-gsc/gsc-core.c | 127 +-- 1 file changed, 122 insertions(+), 5 deletions(-) diff --

[PATCH v4 3/4] drm/exynos/gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
The gscaler has hardware rotation limits that need to be hardcoded into driver. Distinguish them and add them to the property list. The hardware rotation limits are related to the cropped source size. When swap occurs, use rot_max size instead of crop_max size. Also the scaling limits are related

[PATCH v4 2/4] ARM: dts: exynos: Add clean name of compatible.

2017-09-13 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. However, currently it uses only one compatible - "exynos5-gsc". Since we have to distinguish between these two, we add different compatible. Signed-off-by: Hoegeun Kwon --- arch/arm/boot/dts/exynos5250.dtsi | 8 arch/arm/boot

[PATCH v4 1/4] [media] exynos-gsc: Add compatible for Exynos 5250 and 5420 specific version

2017-09-13 Thread Hoegeun Kwon
Exynos 5250 and 5420 have different hardware rotation limits. Since we have to distinguish between these two, we add different compatible(samsung,exynos5250-gsc and samsung,exynos5420-gsc). Signed-off-by: Hoegeun Kwon --- Documentation/devicetree/bindings/media/exynos5-gsc.txt | 9 ++--- 1 f

[PATCH v3 7/9] v4l: vsp1: Adapt entities to configure into a body

2017-09-13 Thread Kieran Bingham
Currently the entities store their configurations into a display list. Adapt this such that the code can be configured into a body directly, allowing greater flexibility and control of the content. All users of vsp1_dl_list_write() are removed in this process, thus it too is removed. A helper, vs

[PATCH v3 5/9] v4l: vsp1: Use reference counting for bodies

2017-09-13 Thread Kieran Bingham
Extend the display list body with a reference count, allowing bodies to be kept as long as a reference is maintained. This provides the ability to keep a cached copy of bodies which will not change, so that they can be re-applied to multiple display lists. Signed-off-by: Kieran Bingham --- This

[PATCH v3 6/9] v4l: vsp1: Refactor display list configure operations

2017-09-13 Thread Kieran Bingham
The entities provide a single .configure operation which configures the object into the target display list, based on the vsp1_entity_params selection. This restricts us to a single function prototype for both static configuration (the pre-stream INIT stage) and the dynamic runtime stages for both

[PATCH v3 3/9] v4l: vsp1: Provide a body pool

2017-09-13 Thread Kieran Bingham
Each display list allocates a body to store register values in a dma accessible buffer from a dma_alloc_wc() allocation. Each of these results in an entry in the TLB, and a large number of display list allocations adds pressure to this resource. Reduce TLB pressure on the IPMMUs by allocating mult

[PATCH v3 9/9] v4l: vsp1: Reduce display list body size

2017-09-13 Thread Kieran Bingham
The display list originally allocated a body of 256 entries to store all of the register lists required for each frame. This has now been separated into fragments for constant stream setup, and runtime updates. Empirical testing shows that the body0 now uses a maximum of 41 registers for each fra

[PATCH v3 8/9] v4l: vsp1: Move video configuration to a cached dlb

2017-09-13 Thread Kieran Bingham
We are now able to configure a pipeline directly into a local display list body. Take advantage of this fact, and create a cacheable body to store the configuration of the pipeline in the video object. vsp1_video_pipeline_run() is now the last user of the pipe->dl object. Convert this function to

[PATCH v3 1/9] v4l: vsp1: Reword uses of 'fragment' as 'body'

2017-09-13 Thread Kieran Bingham
Throughout the codebase, the term 'fragment' is used to represent a display list body. This term duplicates the 'body' which is already in use. The datasheet references these objects as a body, therefore replace all mentions of a fragment with a body, along with the corresponding pluralised terms.

[PATCH v3 2/9] v4l: vsp1: Protect bodies against overflow

2017-09-13 Thread Kieran Bingham
The body write function relies on the code never asking it to write more than the entries available in the list. Currently with each list body containing 256 entries, this is fine, but we can reduce this number greatly saving memory. In preparation of this add a level of protection to catch any bu

[PATCH v3 4/9] v4l: vsp1: Convert display lists to use new body pool

2017-09-13 Thread Kieran Bingham
Adapt the dl->body0 object to use an object from the body pool. This greatly reduces the pressure on the TLB for IPMMU use cases, as all of the lists use a single allocation for the main body. The CLU and LUT objects pre-allocate a pool containing three bodies, allowing a userspace update before t

[PATCH v3 0/9] vsp1: TLB optimisation and DL caching

2017-09-13 Thread Kieran Bingham
Each display list currently allocates an area of DMA memory to store register settings for the VSP1 to process. Each of these allocations adds pressure to the IPMMU TLB entries. We can reduce the pressure by pre-allocating larger areas and dividing the area across multiple bodies represented as a

Re: [PATCHv3 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-09-13 Thread Ville Syrjälä
On Wed, Sep 13, 2017 at 10:51:02AM +0200, Hans Verkuil wrote: > On 09/12/2017 07:39 PM, Ville Syrjälä wrote: > > On Mon, Sep 11, 2017 at 01:25:45PM +0200, Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> This adds support for the DisplayPort CEC-Tunneling-over-AUX > >> feature that is part of

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Hans Verkuil
On 09/13/17 12:07, Sakari Ailus wrote: > Hi Hans, > > On Wed, Sep 13, 2017 at 11:28:44AM +0200, Hans Verkuil wrote: >> On 09/13/17 11:24, Sakari Ailus wrote: >>> Hi Hans, >>> >>> Thanks for the review! >>> >>> On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: On 09/12/2017 03:41 P

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Sakari Ailus
Hi Hans, On Wed, Sep 13, 2017 at 11:28:44AM +0200, Hans Verkuil wrote: > On 09/13/17 11:24, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for the review! > > > > On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: > >> On 09/12/2017 03:41 PM, Sakari Ailus wrote: > >>> Add function v4

Re: [PATCH v8 1/4] rockchip/rga: v4l2 m2m support

2017-09-13 Thread kbuild test robot
Hi Jacob, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.13 next-20170913] [cannot apply to rockchip/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jacob

Re: [PATCH v12 19/26] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-13 Thread Sakari Ailus
Hi Hans, On Wed, Sep 13, 2017 at 09:57:52AM +0200, Hans Verkuil wrote: > The subject still has the 'interger' typo. > > On 09/12/2017 03:41 PM, Sakari Ailus wrote: > > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > > the device's own fwnode, it will follow child fwno

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Hans Verkuil
On 09/13/17 11:24, Sakari Ailus wrote: > Hi Hans, > > Thanks for the review! > > On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: >> On 09/12/2017 03:41 PM, Sakari Ailus wrote: >>> Add function v4l2_fwnode_reference_count() for counting external >> >> There is no function v4l2_f

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Hoegeun Kwon
On 09/13/2017 06:11 PM, Sylwester Nawrocki wrote: Hi Hoegeun, On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, void *priv) static const struct of_device_id exynos_gsc_match[] = { { -.compatible = "samsung,exynos

Re: [PATCH] [media] s3c-camif: fix out-of-bounds array access

2017-09-13 Thread Sylwester Nawrocki
On 09/12/2017 10:09 PM, Arnd Bergmann wrote: > While experimenting with older compiler versions, I ran > into a warning that no longer shows up on gcc-4.8 or newer: > > drivers/media/platform/s3c-camif/camif-capture.c: In function > '__camif_subdev_try_format': > drivers/media/platform/s3c-camif/

Re: [PATCH v12 15/26] v4l: async: Allow binding notifiers to sub-devices

2017-09-13 Thread Hans Verkuil
On 09/13/17 10:29, Sakari Ailus wrote: > Hi Hans, > > On Wed, Sep 13, 2017 at 09:17:08AM +0200, Hans Verkuil wrote: >> On 09/12/2017 03:41 PM, Sakari Ailus wrote: >>> Registering a notifier has required the knowledge of struct v4l2_device >>> for the reason that sub-devices generally are registere

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Sakari Ailus
Hi Hans, Thanks for the review! On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: > On 09/12/2017 03:41 PM, Sakari Ailus wrote: > > Add function v4l2_fwnode_reference_count() for counting external > > There is no function v4l2_fwnode_reference_count()?! It got removed during th

Re: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding.

2017-09-13 Thread Allen
> bad: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of > open coding. > good: [PATCH v4] [media] atomisp: use ARRAY_SIZE() instead of open coding. My bad. Fixed it in V4. Thanks. - Allen

[PATCH v4] [media]atomisp:use ARRAY_SIZE() instead of open coding.

2017-09-13 Thread Allen Pais
The array_length() macro just duplicates ARRAY_SIZE(), so we can delete it. v4: Update the commit message. Signed-off-by: Allen Pais --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/at

Re: [PATCH v3 4/6] [media] exynos-gsc: Add hardware rotation limits

2017-09-13 Thread Sylwester Nawrocki
Hi Hoegeun, On 09/13/2017 04:33 AM, Hoegeun Kwon wrote: >>> @@ -1017,8 +1083,12 @@ static irqreturn_t gsc_irq_handler(int irq, >>> void *priv) >>> static const struct of_device_id exynos_gsc_match[] = { >>>{ >>> -.compatible = "samsung,exynos5-gsc", >>> -.data = &gsc_v

Re: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding.

2017-09-13 Thread Dan Carpenter
On Wed, Sep 13, 2017 at 02:27:53PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais Sorry, the patch is right, but the commit is still totally messed up. bad: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding. good: [PATCH v4] [media] atomisp: use ARRAY_SIZE

Re: [PATCH v2] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Allen
> > This is going through linux-media and maybe they won't insist on some > kind of commit message, but I know Greg does. Okay. I sent out a V3. -- - Allen

[PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding.

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c index e882

Re: [PATCHv3 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

2017-09-13 Thread Hans Verkuil
On 09/12/2017 07:39 PM, Ville Syrjälä wrote: > On Mon, Sep 11, 2017 at 01:25:45PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> This adds support for the DisplayPort CEC-Tunneling-over-AUX >> feature that is part of the DisplayPort 1.3 standard. >> >> Unfortunately, not all DisplayPort/US

Re: [git:media_tree/master] media: adv7180: add missing adv7180cp, adv7180st i2c device IDs

2017-09-13 Thread Geert Uytterhoeven
On Thu, Jul 20, 2017 at 12:54 PM, Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch > were queued: > > Subject: media: adv7180: add missing adv7180cp, adv7180st i2c device IDs > Author: Ulrich Hecht > Date:Mon Jul 3 04:43:33 2017 -0

Re: [PATCH v2] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Dan Carpenter
On Wed, Sep 13, 2017 at 02:09:25PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais This is going through linux-media and maybe they won't insist on some kind of commit message, but I know Greg does. regards, dan carpenter

Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Dan Carpenter
Also change the subject prefix to: [media] atomisp: so it's: Subject: [PATCH v2] [media] atomisp: Use ARRAY_SIZE() instead of open coding it regards, dan carpenter

Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Allen
>> >> -#define array_length(array) (sizeof(array)/sizeof(array[0])) >> +#define array_length(array) (ARRAY_SIZE(array)) > > Just get rid of this array_length macro and use ARRAY_SIZE() directly. > Sure. - Allen

[PATCH v2] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c index e882

Re: [PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

2017-09-13 Thread Sakari Ailus
On Wed, Sep 13, 2017 at 09:35:52AM +0200, Ricardo Ribalda Delgado wrote: > max_width and max_height are swap with step_width and step_height. > > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Sakari Ailus > --- > > Since that this bug has been here for ever. I do not know if we should > no

Re: [PATCH v12 15/26] v4l: async: Allow binding notifiers to sub-devices

2017-09-13 Thread Sakari Ailus
Hi Hans, On Wed, Sep 13, 2017 at 09:17:08AM +0200, Hans Verkuil wrote: > On 09/12/2017 03:41 PM, Sakari Ailus wrote: > > Registering a notifier has required the knowledge of struct v4l2_device > > for the reason that sub-devices generally are registered to the > > v4l2_device (as well as the media

Re: [PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Dan Carpenter
You need a changelog. On Wed, Sep 13, 2017 at 01:34:39PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais > --- > drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/c

Re: [PATCHv4 3/5] dt-bindings: document the CEC GPIO bindings

2017-09-13 Thread Hans Verkuil
On 09/12/2017 04:43 PM, Rob Herring wrote: > On Thu, Aug 31, 2017 at 01:01:54PM +0200, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Document the bindings for the cec-gpio module for hardware where the >> CEC line and optionally the HPD line are connected to GPIO lines. >> >> Signed-off-by: Hans

Re: [PATCH v12 06/26] v4l: fwnode: Support generic parsing of graph endpoints, per port

2017-09-13 Thread Sakari Ailus
Hi Hans, Thanks for the review. On Wed, Sep 13, 2017 at 09:06:11AM +0200, Hans Verkuil wrote: > On 09/13/2017 09:01 AM, Hans Verkuil wrote: > > On 09/12/2017 03:41 PM, Sakari Ailus wrote: > >> This is just like like v4l2_async_notifier_parse_fwnode_endpoints but it > >> only parses endpoints on a

[PATCH] drivers:staging/media:Use ARRAY_SIZE() for the size calculation of the array

2017-09-13 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css.c index e882b55..d

Re: [PATCH v12 23/26] et8ek8: Add support for flash and lens devices

2017-09-13 Thread Hans Verkuil
On 09/12/2017 03:41 PM, Sakari Ailus wrote: > From: Pavel Machek > > Parse async sub-devices by using > v4l2_subdev_fwnode_reference_parse_sensor_common(). > > These types devices aren't directly related to the sensor, but are > nevertheless handled by the et8ek8 driver due to the relationship o

Re: [PATCH v12 19/26] v4l: fwnode: Add a helper function to obtain device / interger references

2017-09-13 Thread Hans Verkuil
The subject still has the 'interger' typo. On 09/12/2017 03:41 PM, Sakari Ailus wrote: > v4l2_fwnode_reference_parse_int_prop() will find an fwnode such that under > the device's own fwnode, it will follow child fwnodes with the given > property -- value pair and return the resulting fwnode. As s

[PATCH v2] v4l-ioctl: Fix typo on v4l_print_frmsizeenum

2017-09-13 Thread Ricardo Ribalda Delgado
max_width and max_height are swap with step_width and step_height. Signed-off-by: Ricardo Ribalda Delgado --- Since that this bug has been here for ever. I do not know if we should notify stable or not I have also cut the lines to respect the 80 char limit v2: Suggested by Laurent Pinchart -F

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Hans Verkuil
On 09/12/2017 03:41 PM, Sakari Ailus wrote: > Add function v4l2_fwnode_reference_count() for counting external There is no function v4l2_fwnode_reference_count()?! > references and v4l2_fwnode_reference_parse() for parsing them as async > sub-devices. > > This can be done on e.g. flash or l

Re: [PATCH v12 15/26] v4l: async: Allow binding notifiers to sub-devices

2017-09-13 Thread Hans Verkuil
On 09/12/2017 03:41 PM, Sakari Ailus wrote: > Registering a notifier has required the knowledge of struct v4l2_device > for the reason that sub-devices generally are registered to the > v4l2_device (as well as the media device, also available through > v4l2_device). > > This information is not ava

Re: [PATCH v12 06/26] v4l: fwnode: Support generic parsing of graph endpoints, per port

2017-09-13 Thread Hans Verkuil
On 09/13/2017 09:01 AM, Hans Verkuil wrote: > On 09/12/2017 03:41 PM, Sakari Ailus wrote: >> This is just like like v4l2_async_notifier_parse_fwnode_endpoints but it >> only parses endpoints on a single port. The behaviour is useful on devices >> that have both sinks and sources, in other words onl

Re: [PATCH v12 06/26] v4l: fwnode: Support generic parsing of graph endpoints, per port

2017-09-13 Thread Hans Verkuil
On 09/12/2017 03:41 PM, Sakari Ailus wrote: > This is just like like v4l2_async_notifier_parse_fwnode_endpoints but it > only parses endpoints on a single port. The behaviour is useful on devices > that have both sinks and sources, in other words only some of these should > be parsed. I think it w