Re: [PATCH 3/3] media: atmel-isc: Add more format configurations

2017-08-21 Thread Hans Verkuil
On 08/17/2017 09:16 AM, Wenyou Yang wrote: > Add the configuration of formats: GREY, ARGB444, ARGB555 and ARGB32. > > Signed-off-by: Wenyou Yang > --- > > drivers/media/platform/atmel/atmel-isc.c | 22 -- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/d

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-21 Thread Hans Verkuil
On 08/22/2017 05:01 AM, Yong wrote: > Hi Hans, > > On Mon, 21 Aug 2017 16:37:41 +0200 > Hans Verkuil wrote: > >> Hi Yong, >> >> First two high-level comments before I start the review: >> >> 1) Can you provide the v4l2-compliance output? I can't merge this unless I >>see that it passes the c

cron job: media_tree daily build: ERRORS

2017-08-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Aug 22 05:00:16 CEST 2017 media-tree git hash:0779b8855c746c90b85bfe6e16d5dfa2a6a46655 media_build gi

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-21 Thread Yong
Hi Hans, On Mon, 21 Aug 2017 16:37:41 +0200 Hans Verkuil wrote: > Hi Yong, > > First two high-level comments before I start the review: > > 1) Can you provide the v4l2-compliance output? I can't merge this unless I >see that it passes the compliance tests. Make sure you compile from the gi

Re: [PATCH 1/3] dt-bindings: Add bindings for Dongwoon DW9714 voice coil

2017-08-21 Thread Rob Herring
On Thu, Aug 17, 2017 at 04:42:54PM +0300, Sakari Ailus wrote: > Dongwoon DW9714 is a voice coil lens driver. > > Also add a vendor prefix for Dongwoon for one did not exist previously. > > Signed-off-by: Sakari Ailus > --- > Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt | 9 ++

Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor.

2017-08-21 Thread Yang, Wenyou
Hi Hans, On 2017/8/21 22:07, Hans Verkuil wrote: On 08/17/2017 09:16 AM, Wenyou Yang wrote: The 12-bit parallel interface supports the Raw Bayer, YCbCr, Monochrome and JPEG Compressed pixel formats from the external sensor, not support RBG pixel format. Signed-off-by: Wenyou Yang --- drive

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Mauro Carvalho Chehab
Em Tue, 22 Aug 2017 02:44:00 +0200 Niklas Söderlund escreveu: > On 2017-08-21 11:01:00 -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 21 Aug 2017 15:52:17 +0200 > > Hans Verkuil escreveu: > > > > > On 08/21/2017 02:07 PM, Mauro Carvalho Chehab wrote: > > > > Em Mon, 21 Aug 2017 12:14:18 +0200

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Niklas Söderlund
On 2017-08-21 11:01:00 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 21 Aug 2017 15:52:17 +0200 > Hans Verkuil escreveu: > > > On 08/21/2017 02:07 PM, Mauro Carvalho Chehab wrote: > > > Em Mon, 21 Aug 2017 12:14:18 +0200 > > > Hans Verkuil escreveu: > > > > > >> On 08/21/2017 11:08 AM, Mauro

[PATCH v2] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount by using of_get_parent() instead of of_get_next_parent() which don't decrement the usecount of the node passed to it. Fixes: 3b27d00e7b6d7c88 ("devi

[PATCH v4l-utils] configure.ac: drop --disable-libv4l, disable plugin support instead

2017-08-21 Thread Thomas Petazzoni
In commit 2e604dfbcd09b93f0808cedb2a0b324c5569a599 ("configure.ac: add --disable-libv4l option"), an option --disable-libv4l was added. As part of this, libv4l is no longer built at all in static linking configurations, just because libv4l uses dlopen() for plugin support. However, plugin support

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

2017-08-21 Thread Sakari Ailus
Hi Jacek, Jacek Anaszewski wrote: > Hi Sakari, > > On 08/21/2017 03:53 PM, Sakari Ailus wrote: >> Hi Jacek, >> >> Jacek Anaszewski wrote: >>> Hi Sakari, >>> >>> Thanks for the update. >>> I've noticed that you added node labels to the child device nodes >>> in [0]: >>> >>> "as3645a_flash : flash"

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Sakari Ailus
Hejssan Niklas, Niklas Söderlund wrote: Hi Sakari, On 2017-08-21 22:03:02 +0300, Sakari Ailus wrote: Hi Niklas, Niklas Söderlund wrote: Hi Sakari, On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: Hi Niklas, Niklas Söderlund wrote: Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Hi Sakari, On 2017-08-21 22:03:02 +0300, Sakari Ailus wrote: > Hi Niklas, > > Niklas Söderlund wrote: > > Hi Sakari, > > > > On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: > > > Hi Niklas, > > > > > > Niklas Söderlund wrote: > > > > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the use

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-21 Thread Maxime Ripard
Hi Baruch, On Sun, Jul 30, 2017 at 09:08:01AM +0300, Baruch Siach wrote: > On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > > Hi, > > > > Thanks for the second iteration! > > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > Allwinner V3s SoC have two CSI modu

Re: [PATCH 06/15] mtd: make device_type const

2017-08-21 Thread Boris Brezillon
Le Sat, 19 Aug 2017 13:52:17 +0530, Bhumika Goyal a écrit : > Make this const as it is only stored in the type field of a device > structure, which is const. > Done using Coccinelle. > Applied to l2-mtd/master. Thanks, Boris > Signed-off-by: Bhumika Goyal > --- > drivers/mtd/mtdcore.c | 2

[PATCH v2.1 3/3] arm: dts: omap3: N9/N950: Add AS3645A camera flash

2017-08-21 Thread Sakari Ailus
From: Sakari Ailus Add the as3645a flash controller to the DT source. Signed-off-by: Sakari Ailus Reviewed-by: Sebastian Reichel --- since v3: - Drop reference names from flash and indicator nodes. They were unused. arch/arm/boot/dts/omap3-n950-n9.dtsi | 14 ++ 1 file changed, 1

Re: [PATCH] keytable: ensure udev rule fires on rc input device

2017-08-21 Thread Matthias Reichl
Hi Sean! On Wed, Aug 16, 2017 at 05:56:25PM +0100, Sean Young wrote: > I've found a shorter way of doing this. That's a really clever trick of dealing with the RUN/$id issue, I like it a lot! > > From: Sean Young > Date: Wed, 16 Aug 2017 17:41:53 +0100 > Subject: [PATCH] keytable: ensure t

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

2017-08-21 Thread Jacek Anaszewski
Hi Sakari, On 08/21/2017 03:53 PM, Sakari Ailus wrote: > Hi Jacek, > > Jacek Anaszewski wrote: >> Hi Sakari, >> >> Thanks for the update. >> I've noticed that you added node labels to the child device nodes >> in [0]: >> >> "as3645a_flash : flash" and "as3645a_indicator : indicator" > > The phan

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Sakari Ailus
Hi Niklas, Niklas Söderlund wrote: Hi Sakari, On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: Hi Niklas, Niklas Söderlund wrote: Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount just like i

Re: DRM Format Modifiers in v4l2

2017-08-21 Thread Hans Verkuil
On 08/21/2017 06:01 PM, Daniel Vetter wrote: > On Mon, Aug 21, 2017 at 5:52 PM, Brian Starkey wrote: >> Hi all, >> >> I couldn't find this topic talked about elsewhere, but apologies if >> it's a duplicate - I'll be glad to be steered in the direction of a >> thread. >> >> We'd like to support DRM

Re: DRM Format Modifiers in v4l2

2017-08-21 Thread Brian Starkey
On Mon, Aug 21, 2017 at 06:01:24PM +0200, Daniel Vetter wrote: On Mon, Aug 21, 2017 at 5:52 PM, Brian Starkey wrote: Hi all, I couldn't find this topic talked about elsewhere, but apologies if it's a duplicate - I'll be glad to be steered in the direction of a thread. We'd like to support DRM

Re: [PATCHv2 0/3] drm/i915: add DisplayPort CEC-Tunneling-over-AUX support

2017-08-21 Thread Daniel Vetter
On Sat, Aug 19, 2017 at 02:05:16PM +0200, Hans Verkuil wrote: > On 08/12/2017 11:01 AM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > This patch series adds support for the DisplayPort CEC-Tunneling-over-AUX > > feature. This patch series is based on 4.13-rc4 which has all the needed cec > >

Re: DRM Format Modifiers in v4l2

2017-08-21 Thread Daniel Vetter
On Mon, Aug 21, 2017 at 5:52 PM, Brian Starkey wrote: > Hi all, > > I couldn't find this topic talked about elsewhere, but apologies if > it's a duplicate - I'll be glad to be steered in the direction of a > thread. > > We'd like to support DRM format modifiers in v4l2 in order to share > the desc

DRM Format Modifiers in v4l2

2017-08-21 Thread Brian Starkey
Hi all, I couldn't find this topic talked about elsewhere, but apologies if it's a duplicate - I'll be glad to be steered in the direction of a thread. We'd like to support DRM format modifiers in v4l2 in order to share the description of different (mostly proprietary) buffer formats between e.g

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-08-21 Thread Hans Verkuil
Hi Yong, First two high-level comments before I start the review: 1) Can you provide the v4l2-compliance output? I can't merge this unless I see that it passes the compliance tests. Make sure you compile from the git repo (https://git.linuxtv.org/v4l-utils.git/) so you are using the latest

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Geert Uytterhoeven
Hi Niklas, On Mon, Aug 21, 2017 at 2:51 PM, Niklas Söderlund wrote: > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the > node being passed to of_fwnode_graph_get_port_parent(). Preserve the > usecount just like it is done in of_graph_get_port_parent(). > > Fixes: 3b27d00e7b

Re: [PATCH v7] rockchip/rga: v4l2 m2m support

2017-08-21 Thread Hans Verkuil
Hi Jacob, On 08/03/2017 07:23 AM, Jacob Chen wrote: > Rockchip RGA is a separate 2D raster graphic acceleration unit. It > accelerates 2D graphics operations, such as point/line drawing, image > scaling, rotation, BitBLT, alpha blending and image blur/sharpness > > The drvier is mostly based on s

Re: [PATCH 1/7 v3] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Stanimir Varbanov
Hi Marek, On 08/21/2017 03:21 PM, Marek Szyprowski wrote: > Hi Stanimir, > > On 2017-08-21 13:34, Stanimir Varbanov wrote: >> This change is intended to give to the v4l2 drivers a choice to >> change the default behavior of the v4l2-core DMA mapping direction >> from DMA_TO/FROM_DEVICE (depending

Re: [PATCH 1/3] media: atmel-isc: Not support RBG format from sensor.

2017-08-21 Thread Hans Verkuil
On 08/17/2017 09:16 AM, Wenyou Yang wrote: > The 12-bit parallel interface supports the Raw Bayer, YCbCr, > Monochrome and JPEG Compressed pixel formats from the external > sensor, not support RBG pixel format. > > Signed-off-by: Wenyou Yang > --- > > drivers/media/platform/atmel/atmel-isc.c |

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Hi Sakari, On 2017-08-21 16:30:17 +0300, Sakari Ailus wrote: > Hi Niklas, > > Niklas Söderlund wrote: > > Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the > > node being passed to of_fwnode_graph_get_port_parent(). Preserve the > > usecount just like it is done in of_graph_

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Aug 2017 15:52:17 +0200 Hans Verkuil escreveu: > On 08/21/2017 02:07 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 21 Aug 2017 12:14:18 +0200 > > Hans Verkuil escreveu: > > > >> On 08/21/2017 11:08 AM, Mauro Carvalho Chehab wrote: > >>> Em Mon, 21 Aug 2017 09:36:49 +0300 > >>> Sak

Re: [PATCH v2.1 2/3] leds: as3645a: Add LED flash class driver

2017-08-21 Thread Sakari Ailus
Hi Jacek, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the update. > I've noticed that you added node labels to the child device nodes > in [0]: > > "as3645a_flash : flash" and "as3645a_indicator : indicator" The phandle references (as3645a_flash and as3645a_indicator) should actually be

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Hans Verkuil
On 08/21/2017 02:07 PM, Mauro Carvalho Chehab wrote: > Em Mon, 21 Aug 2017 12:14:18 +0200 > Hans Verkuil escreveu: > >> On 08/21/2017 11:08 AM, Mauro Carvalho Chehab wrote: >>> Em Mon, 21 Aug 2017 09:36:49 +0300 >>> Sakari Ailus escreveu: >>> Hi Mauro, Mauro Carvalho Chehab wro

[PATCH] [media] cx18: Make i2c_algo_bit_data const

2017-08-21 Thread Bhumika Goyal
Make this const as it is only used in a copy operation. Signed-off-by: Bhumika Goyal --- drivers/media/pci/cx18/cx18-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx18/cx18-i2c.c b/drivers/media/pci/cx18/cx18-i2c.c index eabdd4c..d94ba24 100644 ---

[PATCH] [media] bt8xx: Make i2c_algo_bit_data const

2017-08-21 Thread Bhumika Goyal
Make this const as it is only used in a copy operation. Signed-off-by: Bhumika Goyal --- drivers/media/pci/bt8xx/bttv-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/bt8xx/bttv-i2c.c b/drivers/media/pci/bt8xx/bttv-i2c.c index 274fd03..eccd1e3 100644 -

Re: [PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Sakari Ailus
Hi Niklas, Niklas Söderlund wrote: Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount just like it is done in of_graph_get_port_parent(). The of_fwnode_graph_get_port_parent() is called by fwnod

Re: [PATCH 5/5] [media] cxusb: add analog mode support for Medion MD95700

2017-08-21 Thread Hans Verkuil
Hi Maciej, On 08/10/2017 11:53 PM, Maciej S. Szmigiero wrote: > This patch adds support for analog part of Medion 95700 in the cxusb > driver. > > What works: > * Video capture at various sizes with sequential fields, > * Input switching (TV Tuner, Composite, S-Video), > * TV and radio tuning, >

Re: [PATCH 1/5] [media] cx25840: add pin to pad mapping and output format configuration

2017-08-21 Thread Hans Verkuil
Hi Maciej, On 08/10/2017 11:50 PM, Maciej S. Szmigiero wrote: > This commit adds pin to pad mapping and output format configuration support > in CX2584x-series chips to cx25840 driver. > > This functionality is then used to allow disabling ivtv-specific hacks > (called a "generic mode"), so cx258

[PATCH] device property: preserve usecount for node passed to of_fwnode_graph_get_port_parent()

2017-08-21 Thread Niklas Söderlund
Using CONFIG_OF_DYNAMIC=y uncovered an imbalance in the usecount of the node being passed to of_fwnode_graph_get_port_parent(). Preserve the usecount just like it is done in of_graph_get_port_parent(). Fixes: 3b27d00e7b6d7c88 ("device property: Move fwnode graph ops to firmware specific locations

Re: [PATCH 1/7 v3] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Marek Szyprowski
Hi Stanimir, On 2017-08-21 13:34, Stanimir Varbanov wrote: This change is intended to give to the v4l2 drivers a choice to change the default behavior of the v4l2-core DMA mapping direction from DMA_TO/FROM_DEVICE (depending on the buffer type CAPTURE or OUTPUT) to DMA_BIDIRECTIONAL during queue

Re: [PATCH 2/2] [media] solo6x10: make snd_kcontrol_new const

2017-08-21 Thread Ismael Luceno
On 16/Aug/2017 14:47, Bhumika Goyal wrote: > Make this const as it is only used during a copy operation. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal > --- > drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Aug 2017 12:14:18 +0200 Hans Verkuil escreveu: > On 08/21/2017 11:08 AM, Mauro Carvalho Chehab wrote: > > Em Mon, 21 Aug 2017 09:36:49 +0300 > > Sakari Ailus escreveu: > > > >> Hi Mauro, > >> > >> Mauro Carvalho Chehab wrote: > >>> Hi Sakari, > >>> > >>> Em Wed, 16 Aug 2017 15:20

[GIT PULL FOR v4.14] More constify & venus fixes

2017-08-21 Thread Hans Verkuil
The following changes since commit 0779b8855c746c90b85bfe6e16d5dfa2a6a46655: media: ddbridge: fix semicolon.cocci warnings (2017-08-20 10:25:22 -0400) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.14j for you to fetch changes up to b7573e3c684cb552

Re: [PATCH 1/7 v2] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Stanimir Varbanov
Hi, On 08/21/2017 01:21 PM, Hans Verkuil wrote: > On 08/21/2017 11:29 AM, Marek Szyprowski wrote: >> Hi Stanimir, >> >> On 2017-08-21 11:09, Stanimir Varbanov wrote: >>> This change is intended to give to the v4l2 drivers a choice to >>> change the default behavior of the v4l2-core DMA mapping dir

[PATCH 1/7 v3] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Stanimir Varbanov
This change is intended to give to the v4l2 drivers a choice to change the default behavior of the v4l2-core DMA mapping direction from DMA_TO/FROM_DEVICE (depending on the buffer type CAPTURE or OUTPUT) to DMA_BIDIRECTIONAL during queue_init time. Initially the issue with DMA mapping direction ha

Re: [PATCH] Staging: bcm2048: fix bare use of 'unsigned' in radio-bcm2048.c

2017-08-21 Thread Hans Verkuil
On 08/04/2017 04:58 PM, Branislav Radocaj wrote: > This is a patch to the radio-bcm2048.c file that fixes up > a warning found by the checkpatch.pl tool. > > Signed-off-by: Branislav Radocaj > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 50 > +-- > 1 file chang

Re: [PATCH 1/7 v2] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Hans Verkuil
On 08/21/2017 11:29 AM, Marek Szyprowski wrote: > Hi Stanimir, > > On 2017-08-21 11:09, Stanimir Varbanov wrote: >> This change is intended to give to the v4l2 drivers a choice to >> change the default behavior of the v4l2-core DMA mapping direction >> from DMA_TO/FROM_DEVICE (depending on the buf

Re: [PATCH v1 4/5] [media] stm32-dcmi: set default format at open()

2017-08-21 Thread Hugues FRUCHET
On 08/04/2017 02:00 PM, Hans Verkuil wrote: > On 28/07/17 12:05, Hugues Fruchet wrote: >> Ensure that we start with default pixel format and resolution >> when opening a new instance. > > Why? The format is persistent in V4L2 and (re)opening the video device > shouldn't change the format. > > S

Re: [PATCH v1 5/5] [media] stm32-dcmi: g_/s_selection crop support

2017-08-21 Thread Hugues FRUCHET
Hi Hans, thanks for reviewing On 08/04/2017 02:26 PM, Hans Verkuil wrote: > On 28/07/17 12:05, Hugues Fruchet wrote: >> Implements g_/s_selection crop support by using DCMI crop >> hardware feature. >> User can first get the maximum supported resolution of the sensor >> by calling g_selection(V4L2

Re: [PATCH v2 2/2] docs-rst: media: Document broken frame handling in stream stop for CSI-2

2017-08-21 Thread Hans Verkuil
On 08/16/2017 02:20 PM, Sakari Ailus wrote: > Some CSI-2 transmitters will finish an ongoing frame whereas others will > not. Document that receiver drivers should not assume a particular > behaviour but to work in both cases. > > Signed-off-by: Sakari Ailus > --- > Documentation/media/kapi/csi2

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Hans Verkuil
On 08/21/2017 11:08 AM, Mauro Carvalho Chehab wrote: > Em Mon, 21 Aug 2017 09:36:49 +0300 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> Mauro Carvalho Chehab wrote: >>> Hi Sakari, >>> >>> Em Wed, 16 Aug 2017 15:20:17 +0300 >>> Sakari Ailus escreveu: >>> As we begin to add support for syst

Re: [PATCH 3/3] [media] radio: constify usb_device_id

2017-08-21 Thread Alexey Klimov
Hi Arvind, thanks for the patch! On Sun, Aug 13, 2017 at 9:54 AM, Arvind Yadav wrote: > usb_device_id are not supposed to change at runtime. All functions > working with usb_device_id provided by work with > const usb_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind

Re: [PATCH 1/7 v2] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Marek Szyprowski
Hi Stanimir, On 2017-08-21 11:09, Stanimir Varbanov wrote: This change is intended to give to the v4l2 drivers a choice to change the default behavior of the v4l2-core DMA mapping direction from DMA_TO/FROM_DEVICE (depending on the buffer type CAPTURE or OUTPUT) to DMA_BIDIRECTIONAL during queue

Re: [PATCH v2] venus: fix copy/paste error in return_buf_error

2017-08-21 Thread Stanimir Varbanov
Thanks Gustavo! On 08/18/2017 07:07 PM, Gustavo A. R. Silva wrote: > Call function v4l2_m2m_dst_buf_remove_by_buf() instead of > v4l2_m2m_src_buf_remove_by_buf() > > Addresses-Coverity-ID: 1415317 > Cc: Stanimir Varbanov > Cc: Hans Verkuil > Signed-off-by: Gustavo A. R. Silva > --- > Changes i

[PATCH 1/7 v2] media: vb2: add bidirectional flag in vb2_queue

2017-08-21 Thread Stanimir Varbanov
This change is intended to give to the v4l2 drivers a choice to change the default behavior of the v4l2-core DMA mapping direction from DMA_TO/FROM_DEVICE (depending on the buffer type CAPTURE or OUTPUT) to DMA_BIDIRECTIONAL during queue_init time. Initially the issue with DMA mapping direction ha

Re: [PATCH v2 1/2] docs-rst: media: Document s_stream() video op usage for MC enabled devices

2017-08-21 Thread Mauro Carvalho Chehab
Em Mon, 21 Aug 2017 09:36:49 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Mauro Carvalho Chehab wrote: > > Hi Sakari, > > > > Em Wed, 16 Aug 2017 15:20:17 +0300 > > Sakari Ailus escreveu: > > > >> As we begin to add support for systems with Media controller pipelines > >> controlled by more t

[v4l-utils PATCH v3 2/2] v4l2-compliance: Add support for metadata output

2017-08-21 Thread Sakari Ailus
Add support for metadata output video nodes, in other words, V4L2_CAP_META_OUTPUT and V4L2_BUF_TYPE_META_OUTPUT. Signed-off-by: Sakari Ailus --- utils/v4l2-compliance/v4l2-compliance.cpp | 11 --- utils/v4l2-compliance/v4l2-compliance.h | 2 +- utils/v4l2-compliance/v4l2-test-form

[v4l-utils PATCH v3 1/2] Add metadata output definitions from metadata output patches

2017-08-21 Thread Sakari Ailus
Signed-off-by: Sakari Ailus --- include/linux/videodev2.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 49fe06c97..4db47dba4 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -142,6 +142,7 @@ enum v4l2_buf

[v4l-utils PATCH v3 0/2] v4l2-compliance: Support for metadata output buffers

2017-08-21 Thread Sakari Ailus
Hi, This set adds support for metadata output buffers in v4l2-compliance. It depends on this kernel patch: https://patchwork.linuxtv.org/patch/43308/> since v2: - Update V4L2_BUF_TYPE_LAST in v4l2-compliance.h Sakari Ailus (2): Add metadata output definitions from metadata output patches

Re: [v4l-utils PATCH 1/1] v4l2-compliance: Add support for metadata output

2017-08-21 Thread Sakari Ailus
Hans Verkuil wrote: Hi Sakari, Thanks for the patch, but it is not complete. Most importantly the V4L2_BUF_TYPE_LAST define in v4l2-compliance.h isn't updated to V4L2_BUF_TYPE_META_OUTPUT. It's best to just do a 'git grep META_CAPTURE' in v4l-utils and check each place it is used whether META

[v4l-utils PATCH v2 1/2] Add metadata output definitions from metadata output patches

2017-08-21 Thread Sakari Ailus
Signed-off-by: Sakari Ailus --- include/linux/videodev2.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 49fe06c97..4db47dba4 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -142,6 +142,7 @@ enum v4l2_buf

Re: [v4l-utils PATCH 1/1] v4l2-compliance: Add support for metadata output

2017-08-21 Thread Hans Verkuil
Hi Sakari, Thanks for the patch, but it is not complete. Most importantly the V4L2_BUF_TYPE_LAST define in v4l2-compliance.h isn't updated to V4L2_BUF_TYPE_META_OUTPUT. It's best to just do a 'git grep META_CAPTURE' in v4l-utils and check each place it is used whether META_OUTPUT support should

[v4l-utils PATCH v2 0/2] v4l2-compliance: Support for metadata output buffers

2017-08-21 Thread Sakari Ailus
Hi, This set adds support for metadata output buffers in v4l2-compliance. It depends on this kernel patch: https://patchwork.linuxtv.org/patch/43308/> Sakari Ailus (2): Add metadata output definitions from metadata output patches v4l2-compliance: Add support for metadata output include/li

[v4l-utils PATCH v2 2/2] v4l2-compliance: Add support for metadata output

2017-08-21 Thread Sakari Ailus
Add support for metadata output video nodes, in other words, V4L2_CAP_META_OUTPUT and V4L2_BUF_TYPE_META_OUTPUT. Signed-off-by: Sakari Ailus --- utils/v4l2-compliance/v4l2-compliance.cpp | 11 --- utils/v4l2-compliance/v4l2-test-formats.cpp | 8 +++- 2 files changed, 15 insertions

Re: [v4l-utils PATCH 1/1] v4l2-compliance: Add support for metadata output

2017-08-21 Thread Sakari Ailus
Sakari Ailus wrote: > Add support for metadata output video nodes, in other words, > V4L2_CAP_META_OUTPUT and V4L2_BUF_TYPE_META_OUTPUT. > > Signed-off-by: Sakari Ailus > --- > Hi all, > > This patch adds support for metadata output in v4l2-compliance. > > It depends on the metadata output patc

[GIT PULL FOR v4.14] cec/vivid fixes and enhancements

2017-08-21 Thread Hans Verkuil
The first patch is a bug fix: the CEC adapter was not explicitly disabled when cec_delete_adapter was called. Normally this does not cause any problems, but for the upcoming omap4 cec driver it does. The next two patches add support for CEC pin emulation in the vivid driver. The third fixes a kern

[v4l-utils PATCH 1/1] v4l2-compliance: Add support for metadata output

2017-08-21 Thread Sakari Ailus
Add support for metadata output video nodes, in other words, V4L2_CAP_META_OUTPUT and V4L2_BUF_TYPE_META_OUTPUT. Signed-off-by: Sakari Ailus --- Hi all, This patch adds support for metadata output in v4l2-compliance. It depends on the metadata output patch: https://patchwork.linuxtv.org/patch/