Stanimir, please review this! I suspect that this is the wrong fix and
that the first v4l2_m2m_src_buf_remove_by_buf should be
v4l2_m2m_dst_buf_remove_by_buf instead.
Regards,
Hans
On 08/18/2017 01:12 AM, Gustavo A. R. Silva wrote:
> Refactor code in order to avoid identical code for dif
Previously, vblank range given to user was too big, falling outside
of permissible range for a given resolution. Sometimes, too low vblank
resulted in errors.
Now, limit vblank to only permissible range for a given resolution.
This change limits lower-bounds of vblank, doesn't affect upper bounds.
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Aug 18 05:00:17 CEST 2017
media-tree git hash:ec0c3ec497cabbf3bfa03a9eb5edcc252190a4e0
media_build gi
Refactor code in order to avoid identical code for different branches.
This issue was detected with the help of Coccinelle.
Addresses-Coverity-ID: 1226795
Signed-off-by: Gustavo A. R. Silva
---
This code was tested by compilation only.
drivers/media/dvb-frontends/dib0090.c | 9 +
1 fil
Hi Javier,
(Resent to your new e-mail address)
Thank you for the patch.
On Tuesday 13 Dec 2016 12:39:19 Javier Martinez Canillas wrote:
> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> added input signals support for the tvp5150, but the approach was found
> to be inc
Hi Javier,
Thank you for the patch.
On Tuesday 13 Dec 2016 12:39:19 Javier Martinez Canillas wrote:
> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> added input signals support for the tvp5150, but the approach was found
> to be incorrect so the corresponding DT bindin
Refactor code in order to avoid identical code for different branches.
This issue was detected with the help of Coccinelle.
Addresses-Coverity-ID: 1415317
Signed-off-by: Gustavo A. R. Silva
---
This code was reported by Coverity and it was tested by compilation only.
Please, verify if this is an
Previously, vblank range given to user was too big, falling outside
of permissible range for a given resolution. Sometimes, too low vblank
resulted in errors.
Now, limit vblank to only permissible range for a given resolution.
This change limits lower-bounds of vblank, doesn't affect upper bounds.
On Wed 2017-08-16 10:33:45, Sakari Ailus wrote:
> The et8ek8 driver combines I²C register writes to a single array that it
> passes to i2c_transfer(). The maximum number of writes is 48 at once,
> decrease it to 8 and make more transfers if needed, thus avoiding a
> warning on stack usage.
>
> Sig
Hello!
On 08/17/2017 10:59 AM, Hans Verkuil wrote:
A quick review. I'm concentrating on the mesh ioctl, since that's what sets this
driver apart.
OK, waiting for the detailed review...
Index: media_tree/Documentation/media/v4l-drivers/rcar_imr.rst
From: Fabio Estevam
platform_get_irq() may fail, so we should better check its return
value and propagate it in the case of error.
Signed-off-by: Fabio Estevam
---
drivers/media/platform/mx2_emmaprp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/mx2_emmaprp.c
b
Hi Mauro,
These patches add functional CCP2 support for the omap3isp, as needed for
the Nokia N900.
since v1:
- Take further review comments into account, in particular store the entity
associated to a given PHY struct (omap3isp) and add a patch cleaning up
storing information on external su
On 16/08/17 10:42, Mauro Carvalho Chehab wrote:
I've just tested both your v2 patch and changes I'm suggesting above; both work
fine on my setup. Do you want me to send a v3?
Yeah, sure! I'm currently in travel, returning only on Friday, and I don't
have the hardware to test. So, if you can sen
This Kaffeine's BZ:
https://bugs.kde.org/show_bug.cgi?id=374693
affects SkyStar S2 PCI DVB-S/S2 rev 3.3 device. It could be due to
a Kernel bug.
While checking the Isil 6421, comparing with its manual, available at:
http://www.intersil.com/content/dam/Intersil/documents/isl6/isl6
Hi Sakari,
Thank you for the patch.
On Thursday 17 Aug 2017 16:27:38 Sakari Ailus wrote:
> struct v4l2_subdev.host_priv is intended to be used by another driver. This
> is hardly good design but back in the days of platform data was a quick
> hack to get things done.
>
> As the sub-device specif
On Thu, Aug 10, 2017 at 06:49:45PM +0300, Sakari Ailus wrote:
> From: Rui Miguel Silva
>
> We are allocating memory for the v4l2 flash configuration structure and
> leak it in the normal path. Just use the stack for this as we do not
> use it outside of this function.
>
> Also use IS_ERR() inste
On Tue, Aug 15, 2017 at 02:28:11PM +0300, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:28 Kieran Bingham wrote:
> The entities provide a single .configure operation which configures the
> object into the target display list, based on the vsp1_entity_params
> selection.
>
> This restricts us to a single function protot
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:30 Kieran Bingham wrote:
> We are now able to configure a pipeline directly into a local display
> list body. Take advantage of this fact, and create a cacheable body to
> store the configuration of the pipeline in the video object.
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:29 Kieran Bingham wrote:
> Currently the entities store their configurations into a display list.
> Adapt this such that the code can be configured into a body fragment
> directly, allowing greater flexibility and control of the cont
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:31 Kieran Bingham wrote:
> The display list originally allocated a body of 256 entries to store all
> of the register lists required for each frame.
>
> This has now been separated into fragments for constant stream setup, and
> run
On Thu, Aug 10, 2017 at 10:31:22AM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This documents the binding for the Tegra CEC module.
>
> Signed-off-by: Hans Verkuil
> ---
> .../devicetree/bindings/media/tegra-cec.txt| 27
> ++
> 1 file changed, 27 insertions
Hi,
On 07/17/2017 02:18 PM, Smitha T Murthy wrote:
> On Fri, 2017-07-07 at 17:59 +0300, Stanimir Varbanov wrote:
>> Hi,
>>
>> On 06/19/2017 08:10 AM, Smitha T Murthy wrote:
>>> Added V4l2 controls for HEVC encoder
>>>
>>> Signed-off-by: Smitha T Murthy
>>> ---
>>> Documentation/media/uapi/v4l/ex
--
I'd like you to be in custody of my late client's fortune.
My client died along with his family including his next-of-kin
The funds shall be used for investment under your management
Do reply for details.
Regards
Richard Williams
Email:rich19willi...@gmail.com
So, after revisiting old mail threads, taking part in a similar discussion on
the USB list, and implementing a not-convincing solution before, here is what I
cooked up to document and ease DMA handling for I2C within Linux. Please have a
look at the documentation introduced in patch 3 for details.
This ensures that we fall back to PIO if the message length is too small
for DMA being useful. Otherwise, we use DMA. A bounce buffer might be
applied by the helper if the original message buffer is not DMA safe.
Signed-off-by: Wolfram Sang
---
drivers/i2c/busses/i2c-sh_mobile.c | 8 ++--
1
Signed-off-by: Wolfram Sang
---
drivers/i2c/i2c-dev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
index 6f638bbc922db4..bbc7aadb4c899d 100644
--- a/drivers/i2c/i2c-dev.c
+++ b/drivers/i2c/i2c-dev.c
@@ -280,6 +280,8 @@ static noinline int i2c
This HW is prone to races, so it needs to setup new messages in irq
context. That means we can't alloc bounce buffers if a message buffer is
not DMA safe. So, in that case, simply fall back to PIO.
Signed-off-by: Wolfram Sang
---
drivers/i2c/busses/i2c-rcar.c | 2 +-
1 file changed, 1 insertion(
I2C has no requirement that the buffer of a message needs to be DMA
safe. In case it is, it can now be flagged, so drivers wishing to
do DMA can use the buffer directly.
Signed-off-by: Wolfram Sang
---
include/uapi/linux/i2c.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/l
One helper checks if DMA is suitable and optionally creates a bounce
buffer, if not. The other function returns the bounce buffer and makes
sure the data is properly copied back to the message.
Signed-off-by: Wolfram Sang
---
drivers/i2c/i2c-core-base.c | 45 +
Signed-off-by: Wolfram Sang
---
Documentation/i2c/DMA-considerations | 50
1 file changed, 50 insertions(+)
create mode 100644 Documentation/i2c/DMA-considerations
diff --git a/Documentation/i2c/DMA-considerations
b/Documentation/i2c/DMA-considerations
new
Hello,
On Thursday 17 Aug 2017 15:49:51 Javier Martinez Canillas wrote:
> On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel wrote:
> > On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote:
> >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> >> added input sign
Hello Philipp,
On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel wrote:
> Hi,
>
> On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote:
>> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
>> added input signals support for the tvp5150, but the approach was found
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/dw9714.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c
index 6a607d7..bcf64ef 100644
--- a/drivers/media/i2c/dw9714.c
+++ b/drivers/media/i2c/dw9714.c
@@ -264,6 +264,12 @@ static
Dongwoon DW9714 is a voice coil lens driver.
Also add a vendor prefix for Dongwoon for one did not exist previously.
Signed-off-by: Sakari Ailus
---
Documentation/devicetree/bindings/media/i2c/dongwoon,dw9714.txt | 9 +
Documentation/devicetree/bindings/vendor-prefixes.txt | 1
The ACPI match table is empty. Remove it.
Also convert the drive to use probe_new callback in struct i2c_driver.
Signed-off-by: Sakari Ailus
---
drivers/media/i2c/dw9714.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/media/i2c/dw9714.c b/drive
Hi all,
This patchset adds DT bindings as well as DT support for DW9714. The
unused ACPI match table is removed.
Sakari Ailus (3):
dt-bindings: Add bindings for Dongwoon DW9714 voice coil
dw9714: Add Devicetree support
dw9714: Remove ACPI match tables, convert to use probe_new
.../binding
struct v4l2_subdev.host_priv is intended to be used by another driver. This
is hardly good design but back in the days of platform data was a quick
hack to get things done.
As the sub-device specific bus information can be stored to the ISP driver
specific struct allocated along with v4l2_async_su
The CEC framework needs to know when the hotplug detect signal
disappears, since that means the CEC physical address has to be
invalidated (i.e. set to f.f.f.f).
Add a lost_hotplug op that is called when the HPD signal goes away.
Signed-off-by: Hans Verkuil
---
Change since v2: check that the lo
On Tue, Aug 15, 2017 at 12:23 PM, Arvind Yadav
wrote:
>
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav
Acked-b
Hi,
2017-08-17 20:11 GMT+08:00 Stanimir Varbanov :
> Hi Laurent,
>
> On 08/16/2017 03:28 PM, Laurent Pinchart wrote:
>> Hi Stan,
>>
>> On Wednesday 16 Aug 2017 14:46:50 Stanimir Varbanov wrote:
>>> On 08/15/2017 01:04 PM, Hans Verkuil wrote:
On 08/14/17 10:41, Stanimir Varbanov wrote:
> H
On 08/17/17 15:03, Tomi Valkeinen wrote:
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
> On 11/08/17 13:57, Tomi Valkeinen wrote:
>> Hi Hans,
>>
>> On 02/08/17 11:53, Hans Verkuil wrote:
>>> From: Hans Verku
Hi,
On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote:
> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> added input signals support for the tvp5150, but the approach was found
> to be incorrect so the corresponding DT binding commit 82c2ffeb217a
> ("[med
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
On 11/08/17 13:57, Tomi Valkeinen wrote:
> Hi Hans,
>
> On 02/08/17 11:53, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> This patch series adds CEC support for the
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:27 Kieran Bingham wrote:
> Extend the display list body with a reference count, allowing bodies to
> be kept as long as a reference is maintained. This provides the ability
> to keep a cached copy of bodies which will not change, so
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:26 Kieran Bingham wrote:
> Adapt the dl->body0 object to use an object from the fragment pool.
> This greatly reduces the pressure on the TLB for IPMMU use cases, as
> all of the lists use a single allocation for the main body.
>
>
Hi Kieran,
Thank you for the patch.
On Monday 14 Aug 2017 16:13:25 Kieran Bingham wrote:
> Each display list allocates a body to store register values in a dma
> accessible buffer from a dma_alloc_wc() allocation. Each of these
> results in an entry in the TLB, and a large number of display list
Hi Laurent,
On 08/16/2017 03:28 PM, Laurent Pinchart wrote:
> Hi Stan,
>
> On Wednesday 16 Aug 2017 14:46:50 Stanimir Varbanov wrote:
>> On 08/15/2017 01:04 PM, Hans Verkuil wrote:
>>> On 08/14/17 10:41, Stanimir Varbanov wrote:
Hi,
This RFC patch is intended to give to the drivers
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by work with
const serio_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/media/usb/rainshadow-cec/rainshadow-cec.c | 2 +-
1 file changed, 1 inse
serio_device_id are not supposed to change at runtime. All functions
working with serio_device_id provided by work with
const serio_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav
---
drivers/media/usb/pulse8-cec/pulse8-cec.c | 2 +-
1 file changed, 1 insertion(+)
On 08/17/17 09:59, Hans Verkuil wrote:
> Hi Sergei,
>
> A quick review. I'm concentrating on the mesh ioctl, since that's what sets
> this
> driver apart.
>
> On 08/04/2017 08:03 PM, Sergei Shtylyov wrote:
>
>
>
>> Index: media_tree/Documentation/media/v4l-drivers/rcar_imr.rst
>>
Hi Laurent,
Thanks for your review,
On 16/08/17 22:53, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
> How about
>
> if (WARN_ONCE(dlb->num_entries >= dlb->max_entries,
> "DLB size exceeded (max %u)", dlb->max_entries))
> return;
>
>
On Mon, Aug 14, 2017 at 05:34:41PM +0200, Geert Uytterhoeven wrote:
> On Sun, Jul 30, 2017 at 3:07 PM, Hans Verkuil wrote:
> > From: Hans Verkuil
>
> Probably the one-line summary should be
>
> ARM: dts: koelsch: Add CEC clock for HDMI transmitter
>
> > The adv7511 on the Koelsch board ha
Hi Sergei,
A quick review. I'm concentrating on the mesh ioctl, since that's what sets this
driver apart.
On 08/04/2017 08:03 PM, Sergei Shtylyov wrote:
> Index: media_tree/Documentation/media/v4l-drivers/rcar_imr.rst
> ===
> ---
Add the configuration of formats: GREY, ARGB444, ARGB555 and ARGB32.
Signed-off-by: Wenyou Yang
---
drivers/media/platform/atmel/atmel-isc.c | 22 --
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isc.c
b/drivers/media/plat
Remove the redundant assignment of members in the isc_formats array.
Signed-off-by: Wenyou Yang
---
drivers/media/platform/atmel/atmel-isc.c | 64
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/media/platform/atmel/atmel-isc.c
b/drivers
The 12-bit parallel interface supports the Raw Bayer, YCbCr,
Monochrome and JPEG Compressed pixel formats from the external
sensor, not support RBG pixel format.
Signed-off-by: Wenyou Yang
---
drivers/media/platform/atmel/atmel-isc.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/driv
The intention of the patch set is to add more configuration of
formats: GREY, ARGB444, ARGB555 and ARGB32, and add the checking
the format from the extern sensor which doesn't support RGB
formats from the external sensor.
Wenyou Yang (3):
media: atmel-isc: Not support RBG format from sensor.
Hi Sergei,
A few high level comments (I'll look at the patch itself later):
- There is no MAINTAINERS entry, please add one.
- Don't attach the patch, post it inline (ideally with 'git send-email')
- Split up the patch into 4 separate patches: bindings, doc changes,
driver and MAINTAINERS patch
59 matches
Mail list logo
