On 11/08/17 02:16, Mauro Carvalho Chehab wrote:
> In the past, only string controls were pointers. That changed when compounded
> types got added, but the compat32 code was not updated.
>
> We could just add those controls there, but maintaining it is flaw, as we
> often forget about the compat co
On 11/08/17 02:16, Mauro Carvalho Chehab wrote:
> The arguments for this function are pointers. Make it clear at
> its documentation.
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> include/media/v4l2-ctrls.h | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff -
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Fri Aug 11 05:00:17 CEST 2017
media-tree git hash:ec0c3ec497cabbf3bfa03a9eb5edcc252190a4e0
media_build gi
Right now, both v4l2_ctrl_fill() and compat32 code need to know
the type of the control. As new controls are added, this cause
troubles at compat32, as it won't be able to discover what
functions are pointers or not.
Change v4l2_ctrl_fill() function for it to be called with just
one argument: the
Em Fri, 4 Aug 2017 13:25:06 +0200
Hans Verkuil escreveu:
> The v4l2_input32 struct wasn't updated when this field was added.
> It didn't cause a failure in the compat code, but it is better to
> keep it in sync with v4l2_input to avoid confusion.
>
> Signed-off-by: Hans Verkuil
Looks good to m
In the past, only string controls were pointers. That changed when compounded
types got added, but the compat32 code was not updated.
We could just add those controls there, but maintaining it is flaw, as we
often forget about the compat code. So, instead, rely on the control type,
as this is alwa
The arguments for this function are pointers. Make it clear at
its documentation.
Signed-off-by: Mauro Carvalho Chehab
---
include/media/v4l2-ctrls.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h
ind
The current way that this function works is subject to problems
as new controls gets added. Move it to v4l2-ctrls and use the
knowledge that v4l2_ctrl_fill() has about controls, in order to
detect if a given control is a pointer.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v
A 0b1100 value in 4 LSBs of "General Status 1" register (AFD_FMT_STAT) has
known meaning for CX2584x-series chips - it means that a SECAM signal is
currently detected by the chip.
Use this opportunity to also fix wrong binary values that were present
as comments attached to some entries in an arra
This series adds support for analog part of Medion 95700 in the cxusb
driver.
What works:
* Video capture at various sizes with sequential fields,
* Input switching (TV Tuner, Composite, S-Video),
* TV and radio tuning,
* Video standard switching and auto detection,
* Radio mode switching (stereo
This patch adds support for analog part of Medion 95700 in the cxusb
driver.
What works:
* Video capture at various sizes with sequential fields,
* Input switching (TV Tuner, Composite, S-Video),
* TV and radio tuning,
* Video standard switching and auto detection,
* Radio mode switching (stereo /
This commit adds pin to pad mapping and output format configuration support
in CX2584x-series chips to cx25840 driver.
This functionality is then used to allow disabling ivtv-specific hacks
(called a "generic mode"), so cx25840 driver can be used for other devices
not needing them without risking
For some types of tuners (Philips FMD1216ME(X) MK3 currently) we know that
letting TDA9887 output port 1 remain high (inactive) will switch FM radio
to mono mode.
Let's make use of this functionality - nothing changes for the default
stereo radio mode.
Tested on a Medion 95700 board which has a FM
If set_fmt callback is called with format->width or format->height set to
zero and HACTIVE_CNT or VACTIVE_CNT bits (respectively) in chip are zero
we will divide by zero later in this callback when we try to calculate
HSC or VSC values.
Fix this by explicitly rejecting these values.
Signed-off-by
On Fri, Aug 04, 2017 at 09:51:38PM -0400, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
I'm afraid the exact same patch has already been submitte
On Tue, Jul 11, 2017 at 03:30:09PM +0200, Hans Verkuil wrote:
> From: Hans Verkuil
>
> This adds support for the DisplayPort CEC-Tunneling-over-AUX
> feature that is part of the DisplayPort 1.3 standard.
Hi Hans,
Thank you for the patch, it looks great, I just have a few minor nits below.
>
>
On 07/08/17 22:20, Sean Young wrote:
> RC_TYPE is confusing and it's just the protocol. So rename it.
>
> Suggested-by: Hans Verkuil
Acked-by: Hans Verkuil
Much better! It's a bit of a painful patch, but so be it. The old names
were really confusing.
> Signed-off-by: Sean Young
> ---
> driv
On 09/08/17 19:19, Sean Young wrote:
> CEC needs a keypress timeout of 550ms, which is too high for the IR
> protocols. Also fill in known repeat times, with 50ms error margin.
>
> Also, combine all protocol data into one structure.
>
> Signed-off-by: Sean Young
> Suggested-by: Hans Verkuil
Mu
On Thu, Aug 10, 2017 at 03:00:21PM +0100, Sean Young wrote:
> On Thu, Aug 10, 2017 at 12:45:42PM +0200, Hans Verkuil wrote:
> > On 09/08/17 23:17, Sean Young wrote:
> > > On Tue, Aug 08, 2017 at 10:11:13AM +0200, Hans Verkuil wrote:
> > >> On 07/08/17 22:58, Sean Young wrote:
> > >>> On Mon, Aug 07
The v4l2_flash_init() keeps a reference to the ops struct but not to the
config struct (nor anything it contains). Document this.
Signed-off-by: Sakari Ailus
Acked-by: Pavel Machek
Acked-by: Hans Verkuil
---
include/media/v4l2-flash-led-class.h | 6 ++
1 file changed, 6 insertions(+)
diff
The V4L2 flash interface allows controlling multiple LEDs through a single
sub-devices if, and only if, these LEDs are of different types. This
approach scales badly for flash controllers that drive multiple flash LEDs
or for LED specific associations. Essentially, the original assumption of a
LED
From: Rui Miguel Silva
We are allocating memory for the v4l2 flash configuration structure and
leak it in the normal path. Just use the stack for this as we do not
use it outside of this function.
Also use IS_ERR() instead of IS_ERR_OR_NULL() to check return value from
v4l2_flash_init() for it n
Hi folks,
The original design decision in the V4L2 flash API allows controlling a two
LEDs (an indicator and a flash) through a single sub-device. This covered
virtually all flash driver chips back then but this no longer holds as
there are many LED driver chips with multiple flash LED outputs. Th
On Wed, Aug 02, 2017 at 11:19:47AM +0800, Jacob Chen wrote:
> Add DT bindings documentation for Rockchip RGA
>
> Signed-off-by: Jacob Chen
> Signed-off-by: Yakir Yang
> ---
> .../devicetree/bindings/media/rockchip-rga.txt | 33
> ++
> 1 file changed, 33 insertions(+)
>
If dw2102_probe() fails on dvb_usb_device_init(), then memleak occurs.
The patch adds deallocation to the error path.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Anton Vasilyev
---
drivers/media/usb/dvb-usb/dw2102.c | 39 +-
code indent should use tabs where possible
change spaces to tabs
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/staging/media/atomisp/i2c/ap1302.c
Hi,
On Thu, Aug 10, 2017 at 04:56:50PM +0300, Sakari Ailus wrote:
> Hi Hans,
>
> On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote:
> > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct
> > > gb_light *light)
> > > {
> > > struct gb_connection *connection = get
change comment style to match codingstyle. Issue found by checkpatch
change four comments.
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 38 --
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/media/atomisp
On 08/08/2017 01:27 PM, Andrzej Pietrasiewicz wrote:
The value to be processed must be first masked and then shifted,
not the other way round.
Signed-off-by: Andrzej Pietrasiewicz
---
drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
This patch fixes the warning
WARNING: Block comments use * on subsequent lines
+/* When loading firmware, host writes firmware data from address
0x8000.
+ When the address reaches 0x9FFF, the next address should return to
0x8000.
WARNING: Block comments use a trailing */ on a separate line
+
On Thu, Aug 10, 2017 at 12:45:42PM +0200, Hans Verkuil wrote:
> On 09/08/17 23:17, Sean Young wrote:
> > On Tue, Aug 08, 2017 at 10:11:13AM +0200, Hans Verkuil wrote:
> >> On 07/08/17 22:58, Sean Young wrote:
> >>> On Mon, Aug 07, 2017 at 03:31:24PM +0200, Hans Verkuil wrote:
> From: Hans Verk
Hi Hans,
On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote:
> > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct
> > gb_light *light)
> > {
> > struct gb_connection *connection = get_conn_from_light(light);
> > struct device *dev = &connection->bundle->dev
This patch fixes the checkpatch.pl warning
WARNING: Missing a blank line after declarations
+ int i;
+ dev_dbg(&client->dev, "Dump registers for context[%d]:\n",
context)
WARNING: Missing a blank line after declarations
+ int ret;
+ ret = request_firmware(&dev->fw, "ap1302
On Sun, Aug 6, 2017 at 11:25 AM, Julia Lawall wrote:
> The v4l2_m2m_ops structures are only passed as the only
> argument to v4l2_m2m_init, which is declared as const.
> Thus the v4l2_m2m_ops structures themselves can be const.
>
> Done with the help of Coccinelle.
>
> //
> @r disable optional_qu
On 09/08/17 13:15, Sakari Ailus wrote:
> The V4L2 flash interface allows controlling multiple LEDs through a single
> sub-devices if, and only if, these LEDs are of different types. This
> approach scales badly for flash controllers that drive multiple flash LEDs
> or for LED specific associations.
On 09/08/17 13:15, Sakari Ailus wrote:
> The v4l2_flash_init() keeps a reference to the ops struct but not to the
> config struct (nor anything it contains). Document this.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Pavel Machek
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> include
On 10/08/17 15:02, Hans Verkuil wrote:
> On 09/08/17 13:15, Sakari Ailus wrote:
>> From: Rui Miguel Silva
>>
>> We are allocating memory for the v4l2 flash configuration structure and
>> leak it in the normal path. Just use the stack for this as we do not
>> use it outside of this function.
>
> I
Add a blank line after declarations
to avoid checkpatch.pl script warning
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/staging/media/atomisp/i2c/ap1302.c
index
On Thu, Aug 10, 2017 at 05:57:35PM +0530, Harold Gomez wrote:
> fix comment style Warning in ap1302.c
> fix WARNING on Block comments use * on subsequent lines
>
> Signed-off-by: Harold Gomez
If you're making a number of trivial cleanups to a single driver, please
submit them as a single patch i
On 09/08/17 13:15, Sakari Ailus wrote:
> From: Rui Miguel Silva
>
> We are allocating memory for the v4l2 flash configuration structure and
> leak it in the normal path. Just use the stack for this as we do not
> use it outside of this function.
I'm not sure why this is part of this patch series
fix comment style to avoid warning from
checkpatch.pl script
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/staging/media/atomisp/i2
Add blank line after declarations
to avoid warning from checkpatch.pl script
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/staging/media/atomisp/i2c/ap1302.c
ind
Hi Hans,
Thank you for your reply. All dongles that we used to work with in Samsung
convert CEC protocol to RCP which we get through MHL Sideband Channel.
All we can do in the driver is to report RCP messages to user-space.
On the RC subsystem: your point is right, which was confirmed
by Sean a
fix comment style Warning in ap1302.c
fix WARNING on Block comments use * on subsequent lines
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/st
These clamp_t() calls are no-ops because we don't save the results. It
leads to an array out of bounds bug.
Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2")
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c
b/drivers/staging/media/at
Hi Sakari,
My apologies, I should have reviewed this weeks ago. Please ping me next time,
this got buried under all the other patches, even though it was delegated to me.
Anyway, better late than never:
On 09/08/17 17:57, Mauro Carvalho Chehab wrote:
> Em Wed, 9 Aug 2017 12:29:17 -0300
> Mauro C
Hi Harold,
Please use a better subject line.
On Thu, Aug 10, 2017 at 03:08:26PM +0530, Harold Gomez wrote:
> Fix Warning from checkpatch.pl
> Block comments use * on subsequent lines
>
> Signed-off-by: Harold Gomez
> ---
> drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++--
> 1 file changed
On 09/08/17 23:17, Sean Young wrote:
> On Tue, Aug 08, 2017 at 10:11:13AM +0200, Hans Verkuil wrote:
>> On 07/08/17 22:58, Sean Young wrote:
>>> On Mon, Aug 07, 2017 at 03:31:24PM +0200, Hans Verkuil wrote:
From: Hans Verkuil
The 'Press and Hold' operation was not correctly implemen
On 10/08/17 11:08, Archit Taneja wrote:
>
>
> On 08/10/2017 02:26 PM, Hans Verkuil wrote:
>> On 10/08/17 10:49, Archit Taneja wrote:
>>> Hi Hans,
>>>
>>> On 07/30/2017 06:37 PM, Hans Verkuil wrote:
From: Hans Verkuil
This patch series adds CEC support to the drm adv7511/adv7533 dr
Fix Warning from checkpatch.pl
Block comments use * on subsequent lines
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/staging/media/atomisp
Add the s_power operation which is responsible for manipulating the
power dowm mode through the PWDN pin and the reset operation through
the RESET pin.
Signed-off-by: Wenyou Yang
---
drivers/media/i2c/ov7670.c | 30 +++---
1 file changed, 27 insertions(+), 3 deletions(-)
Add the media entity pads initialization.
Signed-off-by: Wenyou Yang
---
drivers/media/i2c/ov7670.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c
index e88549f0e704..5c8460ee65c3 100644
--- a/drivers/med
This patch set is to add the media entity pads initialization and add
the s_power operation.
Wenyou Yang (2):
media: ov7670: Add entity pads initialization
media: ov7670: Add the s_power operation
drivers/media/i2c/ov7670.c | 43 +++
1 file changed, 3
On 08/10/2017 02:26 PM, Hans Verkuil wrote:
On 10/08/17 10:49, Archit Taneja wrote:
Hi Hans,
On 07/30/2017 06:37 PM, Hans Verkuil wrote:
From: Hans Verkuil
This patch series adds CEC support to the drm adv7511/adv7533 drivers.
I have tested this with the Qualcomm Dragonboard C410 (adv7533
Fix Warning Block comments use * on subsequent lines
Signed-off-by: Harold Gomez
---
drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c
b/drivers/staging/media/atomisp/i2c/ap1302.c
index
On 10/08/17 10:49, Archit Taneja wrote:
> Hi Hans,
>
> On 07/30/2017 06:37 PM, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> This patch series adds CEC support to the drm adv7511/adv7533 drivers.
>>
>> I have tested this with the Qualcomm Dragonboard C410 (adv7533 based)
>> and the Renesas R-Ca
Hi Hans,
On 07/30/2017 06:37 PM, Hans Verkuil wrote:
From: Hans Verkuil
This patch series adds CEC support to the drm adv7511/adv7533 drivers.
I have tested this with the Qualcomm Dragonboard C410 (adv7533 based)
and the Renesas R-Car Koelsch board (adv7511 based).
Note: the Dragonboard need
On 07/30/2017 06:37 PM, Hans Verkuil wrote:
From: Hans Verkuil
Add support for HDMI CEC to the drm adv7511/adv7533 drivers.
The CEC registers that we need to use are identical for both drivers,
but they appear at different offsets in the register map.
Thanks for the patch. Some minor comme
Hi Harold,
On Thu, Aug 10, 2017 at 01:58:24PM +0530, Harold Gomez wrote:
> CHECK: Do not include the paragraph about writing to the Free Software
> Foundation's mailing address from the sample GPL notice.
> The FSF has changed addresses in the past, and may do so again.
> Linux already includes a
From: Hans Verkuil
Add a simple HDMI CEC GPIO driver that sits on top of the cec-pin framework.
While I have heard of SoCs that use the GPIO pin for CEC (apparently an
early RockChip SoC used that), the main use-case of this driver is to
function as a debugging tool.
By connecting the CEC line
From: Hans Verkuil
Add an entry for the CEC GPIO driver.
Signed-off-by: Hans Verkuil
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index aeb84877854b..d85959f82a09 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3199,6 +3199,15 @@ F:
From: Hans Verkuil
This driver adds support for CEC implementations that use a pull-up
GPIO pin. While SoCs exist that do this, the primary use-case is to
turn a single-board computer into a cheap CEC debugger.
Together with 'cec-ctl --monitor-pin' you can do low-level CEC bus
monitoring and do
From: Hans Verkuil
Document the bindings for the cec-gpio module for hardware where the
CEC pin is connected to a GPIO pin.
Signed-off-by: Hans Verkuil
---
Documentation/devicetree/bindings/media/cec-gpio.txt | 16
1 file changed, 16 insertions(+)
create mode 100644 Documenta
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice.
The FSF has changed addresses in the past, and may do so again.
Linux already includes a copy of the GPL.
remove the unnecessary paragraph
Signed-off-by: Harold Gomez
-
From: Hans Verkuil
This driver adds support for the Tegra CEC IP. It is based on the
NVIDIA drivers/misc/tegra-cec driver in their 3.10 kernel.
This has been converted to the CEC framework and cleaned up.
Tested with my Jetson TK1 board. It has also been tested with the
Tegra X1 in an embedded
From: Hans Verkuil
In order to support CEC the HDMI driver has to inform the CEC driver
whenever the physical address changes. So when the EDID is read the
CEC driver has to be informed and whenever the hotplug detect goes
away.
This is done through the cec-notifier framework.
The link between
From: Hans Verkuil
Add support for the Tegra CEC IP to tegra124.dtsi and enable it on the
Jetson TK1.
Signed-off-by: Hans Verkuil
---
arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4
arch/arm/boot/dts/tegra124.dtsi | 12 +++-
2 files changed, 15 insertions(+), 1 deletion(
From: Hans Verkuil
This documents the binding for the Tegra CEC module.
Signed-off-by: Hans Verkuil
---
.../devicetree/bindings/media/tegra-cec.txt| 27 ++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/tegra-cec.txt
di
From: Hans Verkuil
This patch series adds support for the Tegra CEC functionality.
It has this prerequisite: https://patchwork.linuxtv.org/patch/42521/
That patch has been merged in 4.13-rc4.
The first patch documents the CEC bindings, the second adds support
for this to tegra124.dtsi and enab
CHECK: Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice.
The FSF has changed addresses in the past, and may do so again.
Linux already includes a copy of the GPL.
remove the unnecessary paragraph
Signed-off-by: Harold Gomez
-
On 10/08/17 10:03, Hans Verkuil wrote:
> On 02/08/17 10:42, Hans Verkuil wrote:
>> From: Hans Verkuil
>>
>> Document the bindings for the cec-gpio module for hardware where the
>> CEC pin is connected to a GPIO pin.
>
> ping?
>
>>
>> Signed-off-by: Hans Verkuil
>> ---
>> Documentation/devicetr
On 02/08/17 10:42, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Document the bindings for the cec-gpio module for hardware where the
> CEC pin is connected to a GPIO pin.
ping?
>
> Signed-off-by: Hans Verkuil
> ---
> Documentation/devicetree/bindings/media/cec-gpio.txt | 18 +
Hi Mauro,
This reverts the change from pointer comparison to full OF node path
comparison. As per commit message:
The commit was flawed in that if the device_node pointers are different,
then in fact a different device is present and the device node could be
different in ways other th
On Thu, Aug 10, 2017 at 04:00:05PM +0900, Tomasz Figa wrote:
> Hi Chiranjeevi,
>
> On Thu, Aug 10, 2017 at 6:59 AM, Chiranjeevi Rapolu
> wrote:
> > Previously, pixel-rate/(pixels-per-line * lines-per-frame) was
> > yielding incorrect frame timing for the user.
> >
> > OV sensor is using internal
Hi Chiranjeevi,
On Thu, Aug 10, 2017 at 6:59 AM, Chiranjeevi Rapolu
wrote:
> Previously, pixel-rate/(pixels-per-line * lines-per-frame) was
> yielding incorrect frame timing for the user.
>
> OV sensor is using internal timing and this requires
> conversion (internal timing -> PPL) for correct HB
75 matches
Mail list logo
