Re: [PATCH 5/6 v5] uvcvideo: send a control event when a Control Change interrupt arrives

2017-07-29 Thread kbuild test robot
Hi Guennadi, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Guennadi-Liakhovetski/UVC-fix-q

[PATCH] uvcvideo: fix ifnullfree.cocci warnings

2017-07-29 Thread kbuild test robot
drivers/media/usb/uvc/uvc_ctrl.c:1327:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not ne

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-07-29 Thread Baruch Siach
Hi Maxime, Yong, On Fri, Jul 28, 2017 at 06:02:33PM +0200, Maxime Ripard wrote: > Hi, > > Thanks for the second iteration! > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > and CSI1 is used for parallel

Re: [PATCH v1 5/5] [media] stm32-dcmi: g_/s_selection crop support

2017-07-29 Thread kbuild test robot
Hi Hugues, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.13-rc2 next-20170728] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hugues-Fruchet/STM32-DCMI-camera-

cron job: media_tree daily build: ERRORS

2017-07-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Jul 30 05:00:14 CEST 2017 media-tree git hash:da48c948c263c9d87dfc64566b3373a858cc8aa2 media_build gi

[PATCH v3 4/4] drm: rcar-du: Repair vblank for DRM page flips using the VSP

2017-07-29 Thread Laurent Pinchart
From: Kieran Bingham The driver recently switched from handling page flip completion in the DU vertical blanking handler to the VSP frame end handler to fix a race condition. This unfortunately resulted in incorrect timestamps in the vertical blanking events sent to userspace as vertical blanking

[PATCH v3 1/4] drm: rcar-du: Use the VBK interrupt for vblank events

2017-07-29 Thread Laurent Pinchart
When implementing support for interlaced modes, the driver switched from reporting vblank events on the vertical blanking (VBK) interrupt to the frame end interrupt (FRM). This incorrectly divided the reported refresh rate by two. Fix it by moving back to the VBK interrupt. Fixes: 906eff7fcada ("d

[PATCH v3 0/4] drm: rcar-du: Repair vblank event handling

2017-07-29 Thread Laurent Pinchart
Hello, The recent changes to the rcar-du driver to fix a page flip handling race condition changed the order of which vblanks and page flips are handled, resulting in incorrect timestamps being reported in the vblan events. Correct this by handling vblank events in the same completion handler as p

[PATCH v3 3/4] drm: rcar-du: Fix race condition when disabling planes at CRTC stop

2017-07-29 Thread Laurent Pinchart
When stopping the CRTC the driver must disable all planes and wait for the change to take effect at the next vblank. Merely calling drm_crtc_wait_one_vblank() is not enough, as the function doesn't include any mechanism to handle the race with vblank interrupts. Replace the drm_crtc_wait_one_vblan

[PATCH v3 2/4] drm: rcar-du: Wait for flip completion instead of vblank in commit tail

2017-07-29 Thread Laurent Pinchart
Page flips can take more than one vertical blanking to complete if arming the page flips races with the vertical blanking interrupt. Waiting for one vblank to complete the atomic commit in the commit tail handler is thus incorrect, and can lead to framebuffers being released while still being scann

Re: Kworld 340U (1b80:a340) kernel 4.8.0 ERROR: i2c_transfer returned: -6

2017-07-29 Thread Kumar Vivek
On Fri, Jul 28, 2017 at 11:54 PM, Kumar Vivek wrote: > Thank you Frank! I appreciate your time. > This is what I have done so far - > > On Wed, Jul 19, 2017 at 2:44 PM, Frank Schäfer > wrote: >> >> Hi Kumar, >> >> I don't have time for the em28xx driver at the moment (and I also do not >> have ac

Re: ir-keytable question [Ubuntu 17.04]

2017-07-29 Thread Matthias Reichl
On Sat, Jul 29, 2017 at 11:23:22AM +0100, Sean Young wrote: > Hi, > > On Sun, Jul 16, 2017 at 10:26:14PM -0700, Szabolcs Andrasi wrote: > > Hi, > > > > I'm using Ubuntu 17.04 and I installed the ir-keytable tool. The > > output of the ir-keytable command is as follows: > > > > > > > > Found /s

[PATCH v2 13/14] [media] ddbridge: Kconfig option to control the MSI modparam default

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller It is known that MSI interrupts - while working quite well so far - can still cause issues on some hardware platforms (causing I2C timeouts due to unhandled interrupts). The msi variable/option is set to 1 by default. So, add a Kconfig option prefixed with "EXPERIMENTAL" tha

[PATCH v2 06/14] [media] ddbridge: split off hardware definitions and mappings

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Further cleanup of ddbridge-core and ddbridge-main, and moves all such hw definitions into one single place, making things easier to maintain. Signed-off-by: Daniel Scheller Tested-by: Richard Scobie Tested-by: Jasmin Jessich Tested-by: Dietmar Spingler Tested-by: Manfr

[PATCH v2 10/14] [media] ddbridge: remove unreachable code

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller >From smatch: drivers/media/pci/ddbridge/ddbridge-core.c:3490 snr_store() info: ignoring unreachable code. In fact, the function immediately returns zero, so remove it and update ddb_attrs_snr[] to not reference it anymore. Cc: Ralph Metzler Signed-off-by: Daniel Sche

[PATCH v2 08/14] [media] ddbridge: only register frontends in fe2 if fe is not NULL

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Smatch reported: drivers/media/pci/ddbridge/ddbridge-core.c:1602 dvb_input_attach() error: we previously assumed 'dvb->fe' could be null (see line 1595) dvb->fe2 will ever only be populated when dvb->fe is set. So only handle registration of dvb->fe2 when dvb->fe got se

[PATCH v2 09/14] [media] ddbridge: fix possible buffer overflow in ddb_ports_init()

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Report from smatch: drivers/media/pci/ddbridge/ddbridge-core.c:2659 ddb_ports_init() error: buffer overflow 'dev->port' 32 <= u32max Fix by making sure "p" is greater than zero before checking for "dev->port[].type == DDB_CI_EXTERNAL_XO2". Cc: Ralph Metzler Signed-off

[PATCH v2 12/14] [media] ddbridge: fix dereference before check

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Both ts_release() and ts_open() can use "output" before check (smatch): drivers/media/pci/ddbridge/ddbridge-core.c:816 ts_release() warn: variable dereferenced before check 'output' (see line 809) drivers/media/pci/ddbridge/ddbridge-core.c:836 ts_open() warn: variable

[PATCH v2 14/14] [media] MAINTAINERS: add entry for ddbridge

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Signed-off-by: Daniel Scheller --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9826a918d37a..f25f26b5d9f6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8428,6 +8428,14 @@ T: git git://linuxtv.org/media_tree

[PATCH v2 07/14] [media] ddbridge: check pointers before dereferencing

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Fixes two warnings reported by smatch: drivers/media/pci/ddbridge/ddbridge-core.c:240 ddb_redirect() warn: variable dereferenced before check 'idev' (see line 238) drivers/media/pci/ddbridge/ddbridge-core.c:240 ddb_redirect() warn: variable dereferenced before check '

[PATCH v2 11/14] [media] ddbridge: fix impossible condition warning

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Smatch and gcc complained: drivers/media/pci/ddbridge/ddbridge-core.c:3491 bpsnr_show() warn: impossible condition '(snr[0] == 255) => ((-128)-127 == 255)' drivers/media/pci/ddbridge/ddbridge-core.c: In function ‘bpsnr_show’: drivers/media/pci/ddbridge/ddbridge-core

[PATCH v2 05/14] [media] ddbridge: split off IRQ handling

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller This not only helps keep the ddbridge-core tidy, but also gets rid of defined-but-unused-function warnings which might be triggered depending of CONFIG_PCI_MSI, without having to clutter the code with #ifdef'ery. Signed-off-by: Daniel Scheller Tested-by: Richard Scobie Te

[PATCH v2 02/14] [media] ddbridge: split code into multiple files

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller As of 0.9.9b, the ddbridge code has been split from one single file (ddbridge-core.c) into multiple files, with the purpose of taking care of different topics, and to be able to reuse code in different kernel modules (ddbridge.ko and octonet.ko). This applies the same code s

[PATCH v2 04/14] [media] ddbridge: split I/O related functions off from ddbridge.h

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller While it seems valid that headers can carry simple oneline static inline annotated functions, move them into their own header file to have the overall code more readable. Also, keep them as header (and don't put in a separate object) and static inline to help the compiler av

[PATCH v2 00/14] ddbridge: bump to ddbridge-0.9.29

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller Still prefered for and made for Linux 4.14. Changes from v1 to v2: * I2C access functions (ie. i2c_read() et al) refactored from ddbridge-i2c.c into ddbridge-i2c.h and declared static, and needed include added to all .c files making use of them. This fixes symbol conf

[PATCH v2 01/14] [media] ddbridge: move/reorder functions

2017-07-29 Thread Daniel Scheller
From: Daniel Scheller The functions in ddbridge-core.c have been moved to different positions in newer versions of the dddvb vendor driver package (most notably in version 0.9.9b). Perform the same code move to keep the diff of the upcoming code bump simpler. Signed-off-by: Daniel Scheller Test

Re: ir-keytable question [Ubuntu 17.04]

2017-07-29 Thread Sean Young
Hi, On Sun, Jul 16, 2017 at 10:26:14PM -0700, Szabolcs Andrasi wrote: > Hi, > > I'm using Ubuntu 17.04 and I installed the ir-keytable tool. The > output of the ir-keytable command is as follows: > > > > Found /sys/class/rc/rc0/ (/dev/input/event5) with: > Driver ite-cir, table rc-rc6-mce > Su

Re: [PATCH 2/2] rc: add zx-irdec remote control driver

2017-07-29 Thread Sean Young
Hi Shawn, The driver looks great! Just a minor point, see below. On Sat, Jul 29, 2017 at 02:31:42PM +0800, Shawn Guo wrote: > From: Shawn Guo > > It adds the remote control driver and corresponding keymap file for > IRDEC block found on ZTE ZX family SoCs. > > Signed-off-by: Shawn Guo > --- >

[PATCH v2] media: ov13858: Correct link-frequency and pixel-rate

2017-07-29 Thread Chiranjeevi Rapolu
Previously both link-frequency and pixel-rate reported by the sensor was incorrect, resulting in incorrect FPS. Report link-frequency in Hz rather than link data rate in bps. Calculate pixel-rate from link-frequency. Signed-off-by: Chiranjeevi Rapolu --- Changes in v2: - Fix typo, from PL