Re: [PATCH 1/1] v4l2-flash-led-class: Document v4l2_flash_init() references

2017-07-19 Thread Pavel Machek
On Thu 2017-07-20 01:40:31, Sakari Ailus wrote: > The v4l2_flash_init() keeps a reference to the ops struct but not to the > config struct (nor anything it contains). Document this. > > Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Thanks!

cron job: media_tree daily build: ERRORS

2017-07-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jul 20 05:00:24 CEST 2017 media-tree git hash:8d935787d38f1c2bf689f64ecfe4581e05e5fe55 media_build gi

[PATCH] [media] ov5640: Remove unneeded gpiod NULL check

2017-07-19 Thread Fabio Estevam
From: Fabio Estevam The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam --- drivers/media/i2c/ov5640.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/

Re: [PATCH 2/2] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-07-19 Thread Sakari Ailus
On Wed, Jul 19, 2017 at 02:02:46PM +0200, Pavel Machek wrote: > On Tue 2017-07-18 21:41:07, Sakari Ailus wrote: > > The V4L2 flash interface allows controlling multiple LEDs through a single > > sub-devices if, and only if, these LEDs are of different types. This > > approach scales badly for flash

[PATCH 1/1] v4l2-flash-led-class: Document v4l2_flash_init() references

2017-07-19 Thread Sakari Ailus
The v4l2_flash_init() keeps a reference to the ops struct but not to the config struct (nor anything it contains). Document this. Signed-off-by: Sakari Ailus --- include/media/v4l2-flash-led-class.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/media/v4l2-flash-led-class.h b

[RFC 1/1] v4l2-subdev: Add a function to set sub-device notifier callbacks

2017-07-19 Thread Sakari Ailus
The sub-device's sub-notifier is hidded in the sub-device and not meant to be accessed directly by drivers. Still the driver may wish to set callbacks to the notifier. Add a function to do that: v4l2_subdev_notifier_set_callbacks(). Signed-off-by: Sakari Ailus --- Well, this appears to be quite s

Re: [RFC 18/19] v4l2-fwnode: Add abstracted sub-device notifiers

2017-07-19 Thread Sakari Ailus
Hi Niklas, Thanks for the review! On Tue, Jul 18, 2017 at 11:19:22PM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your hard work! > > On 2017-07-18 22:04:00 +0300, Sakari Ailus wrote: > > Add notifiers for sub-devices. The notifiers themselves are not visible for > > the sub-devic

Re: [RFC 05/19] leds: as3645a: Add LED flash class driver

2017-07-19 Thread Sakari Ailus
On Wed, Jul 19, 2017 at 10:17:26PM +0200, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the update. > > My remarks from [0] related to LED class device naming apply also > to this version of the patch. > > [0[ https://www.spinics.net/lists/linux-leds/msg08015.html Oops. I'll address this

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Frank Rowand
On 07/19/17 09:02, Rob Herring wrote: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: >> On 07/18/2017 11:43 PM, Rob Herring wrote: >>> Now that we have a custom printf format specifier, convert users of >>> full_name to use %pOF instead. This is preparation to remove storing >>> of

Re: [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses

2017-07-19 Thread Mauro Carvalho Chehab
Em Wed, 19 Jul 2017 23:53:30 +0300 Sakari Ailus escreveu: > On Wed, Jul 19, 2017 at 04:37:51PM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 6 Jul 2017 02:00:16 +0300 > > Sakari Ailus escreveu: > > > > > From: Sakari Ailus > > > > > > CCP2 and CSI-1, are older single data lane serial bus

Re: [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses

2017-07-19 Thread Sakari Ailus
On Wed, Jul 19, 2017 at 04:37:51PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 6 Jul 2017 02:00:16 +0300 > Sakari Ailus escreveu: > > > From: Sakari Ailus > > > > CCP2 and CSI-1, are older single data lane serial busses. > > > > Signed-off-by: Sakari Ailus > > Signed-off-by: Pavel Machek

Re: [RFC 05/19] leds: as3645a: Add LED flash class driver

2017-07-19 Thread Jacek Anaszewski
Hi Sakari, Thanks for the update. My remarks from [0] related to LED class device naming apply also to this version of the patch. [0[ https://www.spinics.net/lists/linux-leds/msg08015.html Best regards, Jacek Anaszewski On 07/18/2017 09:03 PM, Sakari Ailus wrote: > From: Sakari Ailus > > Add

Re: [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses

2017-07-19 Thread Mauro Carvalho Chehab
Em Thu, 6 Jul 2017 02:00:16 +0300 Sakari Ailus escreveu: > From: Sakari Ailus > > CCP2 and CSI-1, are older single data lane serial busses. > > Signed-off-by: Sakari Ailus > Signed-off-by: Pavel Machek > --- > drivers/media/platform/pxa_camera.c | 3 ++ > drivers/media/platfo

Re: [PATCH v2] [media] fix warning on v4l2_subdev_call() result interpreted as bool

2017-07-19 Thread Dan Carpenter
Looks good. regards, dan carpenter

[PATCH v2] [media] fix warning on v4l2_subdev_call() result interpreted as bool

2017-07-19 Thread Arnd Bergmann
v4l2_subdev_call is a macro returning whatever the callback return type is, usually 'int'. With gcc-7 and ccache, this can lead to many wanings like: media/platform/pxa_camera.c: In function 'pxa_mbus_build_fmts_xlate': media/platform/pxa_camera.c:766:27: error: ?: using integer constants in bool

Re: Kworld 340U (1b80:a340) kernel 4.8.0 ERROR: i2c_transfer returned: -6

2017-07-19 Thread Frank Schäfer
Hi Kumar, I don't have time for the em28xx driver at the moment (and I also do not have access to a device with tda18271 tuner). But... Am 08.07.2017 um 22:29 schrieb Kumar Vivek: > New subscriber and first time poster. I have tried to read most of the > instructions and etiquettes regarding the

Re: [PATCH v2] [media] imx: csi: enable double write reduction

2017-07-19 Thread Steve Longerbeam
Acked-by: Steve Longerbeam On 07/19/2017 09:34 AM, Philipp Zabel wrote: For 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by 25%. Signed-off-by: Philipp Zabel --- Changes since v1: - Move odd row skipping

[PATCH v2] [media] imx: csi: enable double write reduction

2017-07-19 Thread Philipp Zabel
For 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by 25%. Signed-off-by: Philipp Zabel --- Changes since v1: - Move odd row skipping setup into existing switch statement. --- drivers/staging/media/imx/imx-medi

Re: [PATCH] [media] imx: csi: enable double write reduction

2017-07-19 Thread Philipp Zabel
Hi Steve, On Wed, 2017-07-19 at 09:18 -0700, Steve Longerbeam wrote: > Hi Philipp, > > On 07/19/2017 05:22 AM, Philipp Zabel wrote: > > For 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing > > chroma for even lines. Reduces necessary write memory bandwidth by 25%. > > > > Sign

Re: [PATCH] [media] imx: csi: enable double write reduction

2017-07-19 Thread Steve Longerbeam
Hi Philipp, On 07/19/2017 05:22 AM, Philipp Zabel wrote: For 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by 25%. Signed-off-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-csi.c | 6 ++ 1 f

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Rob Herring
On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki wrote: > On 07/18/2017 11:43 PM, Rob Herring wrote: >> Now that we have a custom printf format specifier, convert users of >> full_name to use %pOF instead. This is preparation to remove storing >> of the full path string for each node. >> >> Sig

Re: [PATCH v3 22/23] camss: Use optimal clock frequency rates

2017-07-19 Thread kbuild test robot
Hi Todor, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.13-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Todor-Tomov/Qualcomm-8x16-Camera-Subsystem-driver/20

Re: [PATCH v3 03/12] intel-ipu3: Add DMA API implementation

2017-07-19 Thread Robin Murphy
On 19/07/17 04:12, Yong Zhi wrote: > From: Tomasz Figa > > This patch adds support for the IPU3 DMA mapping API. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/Kconfig | 8 + > drivers/media/pci/intel/ipu3/Makefile | 2 +- > driver

[ragnatech:media-tree] BUILD INCOMPLETE 0e6fd95802e25b2428749703f76ea9d54ea743a3

2017-07-19 Thread kbuild test robot
git://git.ragnatech.se/linux media-tree 0e6fd95802e25b2428749703f76ea9d54ea743a3 media: pulse8-cec/rainshadow-cec: make adapter name unique TIMEOUT after 1429m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or so

[PATCH 034/102] coda: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 035/102] st-rc: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 036/102] stm32-dcmi: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[PATCH 037/102] rc: sunxi-cir: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit A

[ragnatech:media-next] BUILD INCOMPLETE 474dfccf36850818214ce23a77fc2c7cdf8a57cb

2017-07-19 Thread kbuild test robot
git://git.ragnatech.se/linux media-next 474dfccf36850818214ce23a77fc2c7cdf8a57cb media: svg: avoid too long lines TIMEOUT after 1459m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some build server is down or some build worker is busy doi

Re: [PATCH v4l2-utils] v4l2-ctl: Print numerical control ID

2017-07-19 Thread Sören Brinkmann
On Wed, 2017-07-19 at 12:26:18 +0200, Hans Verkuil wrote: > On 23/06/17 15:56, Soren Brinkmann wrote: > > Print the numerical ID for each control in list commands. > > > > Signed-off-by: Soren Brinkmann > > --- > > I was trying to set controls from a userspace application and was hence > > looki

Re: [PATCH v3 02/12] intel-ipu3: mmu: implement driver

2017-07-19 Thread Robin Murphy
On 19/07/17 04:12, Yong Zhi wrote: > From: Tomasz Figa > > This driver translates Intel IPU3 internal virtual > address to physical address. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/Kconfig| 9 + > drivers/media/pci/intel/ipu3/Makefil

Re: [PATCH v3 13/23] media: camss: Enable building

2017-07-19 Thread kbuild test robot
Hi Todor, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.13-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Todor-Tomov/Qualcomm-8x16-Camera-Subsystem-driver/20

Re: [PATCH] [media] mtk-vcodec: fix vp9 decode error

2017-07-19 Thread 李務誠
Reviewed-by: Wu-Cheng Li Tested-by: Wu-Cheng Li On Wed, Jul 19, 2017 at 5:22 PM, Tiffany Lin wrote: > Fix The camera has a blurry screen phenomenon when > we video chat with apprtc using vp9 codec > > Signed-off-by: Tiffany Lin > --- > .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 37

Re: [PATCH v5 0/4] v4l2-async: add subnotifier registration for subdevices

2017-07-19 Thread Maxime Ripard
Hi Niklas, On Wed, Jul 19, 2017 at 12:49:42PM +0200, Niklas Söderlund wrote: > Hi, > > I know Sakari have posted a series '[RFC 00/19] Async sub-notifiers and > how to use them' which address similar problems as this series. This is > not intended to compete whit his work and Sakari includes on

[PATCH] [media] imx: csi: enable double write reduction

2017-07-19 Thread Philipp Zabel
For 4:2:0 subsampled YUV formats, avoid chroma overdraw by only writing chroma for even lines. Reduces necessary write memory bandwidth by 25%. Signed-off-by: Philipp Zabel --- drivers/staging/media/imx/imx-media-csi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/med

Re: [PATCH v5 0/4] v4l2-async: add subnotifier registration for subdevices

2017-07-19 Thread Hans Verkuil
On 19/07/17 13:54, Niklas Söderlund wrote: > Hi Hans, > > Thanks for your feedback. > > On 2017-07-19 13:02:14 +0200, Hans Verkuil wrote: >> On 19/07/17 12:49, Niklas Söderlund wrote: >>> * Changes since v4 >>> - Add patch which aborts v4l2_async_notifier_unregister() if the memory >>> allocat

Re: [PATCH 2/2] v4l2-flash-led-class: Create separate sub-devices for indicators

2017-07-19 Thread Pavel Machek
On Tue 2017-07-18 21:41:07, Sakari Ailus wrote: > The V4L2 flash interface allows controlling multiple LEDs through a single > sub-devices if, and only if, these LEDs are of different types. This > approach scales badly for flash controllers that drive multiple flash LEDs > or for LED specific asso

Re: [PATCH 1/2] staging: greybus: light: Don't leak memory for no gain

2017-07-19 Thread Pavel Machek
Hi! > Memory for struct v4l2_flash_config is allocated in > gb_lights_light_v4l2_register() for no gain and yet the allocated memory is > leaked; the struct isn't used outside the function. Fix this. > > Signed-off-by: Sakari Ailus > diff --git a/drivers/staging/greybus/light.c b/drivers/stagi

[PATCH v2] media: venus: don't abuse dma_alloc for non-DMA allocations

2017-07-19 Thread Stanimir Varbanov
In venus_boot(), we pass a pointer to a phys_addr_t into dmam_alloc_coherent, which the compiler warns about: platform/qcom/venus/firmware.c: In function 'venus_boot': platform/qcom/venus/firmware.c:63:49: error: passing argument 3 of 'dmam_alloc_coherent' from incompatible pointer type [-Werror

Re: [PATCH v5 0/4] v4l2-async: add subnotifier registration for subdevices

2017-07-19 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback. On 2017-07-19 13:02:14 +0200, Hans Verkuil wrote: > On 19/07/17 12:49, Niklas Söderlund wrote: > > * Changes since v4 > > - Add patch which aborts v4l2_async_notifier_unregister() if the memory > > allocation for the device cache fails instead of trying to do

Re: [PATCH v1.1 1/1] v4l2-flash: Flash ops aren't mandatory

2017-07-19 Thread Pavel Machek
On Tue 2017-07-18 20:36:23, Sakari Ailus wrote: > None of the flash operations are mandatory and therefore there should be > no need for the flash ops structure either. Accept NULL. Well, ok, but is not the flash without any operations kind of useless? Best regards,

Re: [RFC 00/19] Async sub-notifiers and how to use them

2017-07-19 Thread Hans Verkuil
On 18/07/17 21:03, Sakari Ailus wrote: > Hi folks, > > This RFC patchset achieves a number of things which I've put to the same > patchset for they need to be show together to demonstrate the use cases. > > I don't really intend this to compete with Niklas's patchset but much of > the problem are

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Nicolas Ferre
On 18/07/2017 at 23:43, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Kyungmin Park > Cc: Andrzej Hajda

Re: [RFC 11/19] v4l2-async: Register sub-devices before calling bound callback

2017-07-19 Thread Hans Verkuil
On 18/07/17 21:03, Sakari Ailus wrote: > The async notifier supports three callbacks to the notifier: bound, unbound > and complete. The complete callback has been traditionally used for > creating the sub-device nodes. > > This approach has an inherent weakness: if registration of a single > sub-

Re: [PATCH 3/8] dt: bindings: Add a binding for referencing EEPROM from camera sensors

2017-07-19 Thread Maxime Ripard
Hi Sakari, On Wed, Jul 19, 2017 at 12:21:06PM +0300, Sakari Ailus wrote: > On Wed, Jul 19, 2017 at 09:52:55AM +0200, Maxime Ripard wrote: > > Hi Sakari, > > > > On Wed, Jun 14, 2017 at 12:47:14PM +0300, Sakari Ailus wrote: > > > Many camera sensor devices contain EEPROM chips that describe the >

Re: [PATCH v5 0/4] v4l2-async: add subnotifier registration for subdevices

2017-07-19 Thread Hans Verkuil
On 19/07/17 12:49, Niklas Söderlund wrote: > * Changes since v4 > - Add patch which aborts v4l2_async_notifier_unregister() if the memory > allocation for the device cache fails instead of trying to do as much > as possible but still leave the system in a semi good state. Since you are worki

Re: [PATCH v3 00/23] Qualcomm 8x16 Camera Subsystem driver

2017-07-19 Thread Hans Verkuil
On 17/07/17 12:33, Todor Tomov wrote: > This patchset adds basic support for the Qualcomm Camera Subsystem found > on Qualcomm MSM8916 and APQ8016 processors. > > The driver implements V4L2, Media controller and V4L2 subdev interfaces. > Camera sensor using V4L2 subdev interface in the kernel is s

[PATCH v5 3/4] v4l: async: do not hold list_lock when re-probing devices

2017-07-19 Thread Niklas Söderlund
There is no good reason to hold the list_lock when re-probing the devices and it prevents a clean implementation of subdevice notifiers. Move the actual release of the devices outside of the loop which requires the lock to be held. Signed-off-by: Niklas Söderlund --- drivers/media/v4l2-core/v4l2

[PATCH v5 0/4] v4l2-async: add subnotifier registration for subdevices

2017-07-19 Thread Niklas Söderlund
Hi, I know Sakari have posted a series '[RFC 00/19] Async sub-notifiers and how to use them' which address similar problems as this series. This is not intended to compete whit his work and Sakari includes one of my v3 patches in his series. Never the less I post this updated series since it f

[PATCH v5 2/4] v4l: async: abort if memory allocation fails when unregistering notifiers

2017-07-19 Thread Niklas Söderlund
Instead of trying to cope with the failed memory allocation and still leaving the kernel in a semi-broken state (the subdevices will be released but never re-probed) simply abort. The kernel have already printed a warning about allocation failure but keep the error printout to ease pinpointing the

[PATCH v5 4/4] v4l: async: add subnotifier to subdevices

2017-07-19 Thread Niklas Söderlund
Add a subdevice specific notifier which can be used by a subdevice driver to complement the master device notifier to extend the subdevice discovery. The master device registers the subdevices closest to itself in its notifier while the subdevice(s) register notifiers for their closest neighboring

[PATCH v5 1/4] v4l: async: fix unbind error in v4l2_async_notifier_unregister()

2017-07-19 Thread Niklas Söderlund
The call to v4l2_async_cleanup() will set sd->asd to NULL so passing it to notifier->unbind() have no effect and leaves the notifier confused. Call the unbind() callback prior to cleaning up the subdevice to avoid this. Signed-off-by: Niklas Söderlund --- drivers/media/v4l2-core/v4l2-async.c | 6

Re: [PATCH] [media] coda: disable BWB only while decoding on CODA 960

2017-07-19 Thread Ian Arkver
On 19/07/17 11:06, Philipp Zabel wrote: Disabling the BWB works around hangups observed while decoding. Since no issues have been observed while encoding, and disabling BWB also reduces encoding performance, reenable it for encoding. Thanks for the speedy patch Philipp. I can only test encode,

Re: [PATCH v3 12/23] media: camms: Add core files

2017-07-19 Thread Hans Verkuil
Hi Todor, Just one comment: On 17/07/17 12:33, Todor Tomov wrote: > These files implement the platform driver code. > > Signed-off-by: Todor Tomov > --- > drivers/media/platform/qcom/camss-8x16/camss.c | 705 > + > drivers/media/platform/qcom/camss-8x16/camss.h | 97 +

Re: [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support

2017-07-19 Thread Jacob Chen
Hi, 2017-07-17 22:45 GMT+08:00 Nicolas Dufresne : > Le lundi 17 juillet 2017 à 05:37 +0300, Laurent Pinchart a écrit : >> Hi Nicolas, >> >> On Saturday 15 Jul 2017 12:49:13 Personnel wrote: >> >> You might want to fix your mailer to use your name :-) >> >> > Le samedi 15 juillet 2017 à 12:42 +0300

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Matthias Brugger
On 07/18/2017 11:43 PM, Rob Herring wrote: Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Cc: Kyungmin Park Cc: Andrzej Hajda Cc: Mauro

Re: [PATCH v4l2-utils] v4l2-ctl: Print numerical control ID

2017-07-19 Thread Hans Verkuil
On 23/06/17 15:56, Soren Brinkmann wrote: > Print the numerical ID for each control in list commands. > > Signed-off-by: Soren Brinkmann > --- > I was trying to set controls from a userspace application and was hence > looking > for an easy way to find the control IDs to use with VIDIOC_(G|S)_EX

[PATCH] [media] coda: disable BWB only while decoding on CODA 960

2017-07-19 Thread Philipp Zabel
Disabling the BWB works around hangups observed while decoding. Since no issues have been observed while encoding, and disabling BWB also reduces encoding performance, reenable it for encoding. Cc: Ian Arkver Reported-by: Ian Arkver Fixes: 89ed025d5c53 ("[media] coda: disable BWB for all codecs

[PATCH] [media] atomisp2: array underflow in ap1302_enum_frame_size()

2017-07-19 Thread Dan Carpenter
The problem is this code from ap1302_enum_frame_size(): 738 int index = fse->index; 739 740 mutex_lock(&dev->input_lock); 741 context = ap1302_get_context(sd); 742 if (index >= dev->cntx_res[context].res_num) { 743 mutex_unlo

[PATCH] [media] atomisp2: array underflow in imx_enum_frame_size()

2017-07-19 Thread Dan Carpenter
The code looks in imx_enum_frame_size() looks like this: 2066 int index = fse->index; 2067 struct imx_device *dev = to_imx_sensor(sd); 2068 2069 mutex_lock(&dev->input_lock); 2070 if (index >= dev->entries_curr_table) { 2071 mutex_

[PATCH] [media] atomisp2: Array underflow in atomisp_enum_input()

2017-07-19 Thread Dan Carpenter
The problem here is this code from atomisp_enum_input(): 581 int index = input->index; 582 583 if (index >= isp->input_cnt) 584 return -EINVAL; 585 586 if (!isp->inputs[index].camera) 587 return -EINVAL; "input-

Re: [PATCH v3 4/4] i2c: rcar: check for DMA-capable buffers

2017-07-19 Thread Niklas Söderlund
Hi Wolfram, On 2017-07-18 12:23:39 +0200, Wolfram Sang wrote: > Handling this is special for this driver. Because the hardware needs to > initialize the next message in interrupt context, we cannot use the > i2c_check_msg_for_dma() directly. This helper only works reliably in > process context. So

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Sylwester Nawrocki
On 07/18/2017 11:43 PM, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > --- > drivers/media/i2c/s5c73m3/s5c7

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

2017-07-19 Thread Ian Arkver
On 19/07/17 10:32, Philipp Zabel wrote: On Wed, 2017-07-19 at 10:15 +0100, Ian Arkver wrote: On 19/07/17 09:09, Philipp Zabel wrote: Hi Ian, On Wed, 2017-07-19 at 08:16 +0100, Ian Arkver wrote: Hi Philipp, On 02/03/17 10:19, Philipp Zabel wrote: Side effects are reduced burst lengths when w

Re: [PATCH v3 3/4] i2c: sh_mobile: use helper to decide if DMA is useful

2017-07-19 Thread Niklas Söderlund
Hi Wolfram, On 2017-07-18 12:23:38 +0200, Wolfram Sang wrote: > This ensures that we fall back to PIO if the buffer is too small for DMA > being useful. Otherwise, we use DMA. A bounce buffer might be applied if > the original message buffer is not DMA safe > > Signed-off-by: Wolfram Sang > ---

Re: [PATCH v2 1/2] media: platform: davinci: prepare for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

2017-07-19 Thread Hans Verkuil
On 19/07/17 10:21, Lad, Prabhakar wrote: > preparing for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl having > minimalistic code changes so as it can be applied for backports. The code is good (and can be applied from 3.7 onwards), but the commit log needs work. Since this patch is going to be bac

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

2017-07-19 Thread Philipp Zabel
On Wed, 2017-07-19 at 10:15 +0100, Ian Arkver wrote: > On 19/07/17 09:09, Philipp Zabel wrote: > > Hi Ian, > > > > On Wed, 2017-07-19 at 08:16 +0100, Ian Arkver wrote: > >> Hi Philipp, > >> > >> On 02/03/17 10:19, Philipp Zabel wrote: > >>> Side effects are reduced burst lengths when writing out d

Re: [PATCH v3 1/4] i2c: add helpers to ease DMA handling

2017-07-19 Thread Niklas Söderlund
Hi Wolfram, On 2017-07-18 12:23:36 +0200, Wolfram Sang wrote: > One helper checks if DMA is suitable and optionally creates a bounce > buffer, if not. The other function returns the bounce buffer and makes > sure the data is properly copied back to the message. > > Signed-off-by: Wolfram Sang R

Re: [PATCH v3 2/4] i2c: add docs to clarify DMA handling

2017-07-19 Thread Niklas Söderlund
Hi Wolfram, On 2017-07-18 12:23:37 +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang Reviewed-by: Niklas Söderlund > --- > Changes since v2: > > * documentation updates. Hopefully better wording now > > Documentation/i2c/DMA-considerations | 38 >

[PATCH] [media] mtk-vcodec: fix vp9 decode error

2017-07-19 Thread Tiffany Lin
Fix The camera has a blurry screen phenomenon when we video chat with apprtc using vp9 codec Signed-off-by: Tiffany Lin --- .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 37 -- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mtk-vc

Re: [PATCH 3/8] dt: bindings: Add a binding for referencing EEPROM from camera sensors

2017-07-19 Thread Sakari Ailus
Hi Maxime, On Wed, Jul 19, 2017 at 09:52:55AM +0200, Maxime Ripard wrote: > Hi Sakari, > > On Wed, Jun 14, 2017 at 12:47:14PM +0300, Sakari Ailus wrote: > > Many camera sensor devices contain EEPROM chips that describe the > > properties of a given unit --- the data is specific to a given unit ca

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

2017-07-19 Thread Ian Arkver
On 19/07/17 09:09, Philipp Zabel wrote: Hi Ian, On Wed, 2017-07-19 at 08:16 +0100, Ian Arkver wrote: Hi Philipp, On 02/03/17 10:19, Philipp Zabel wrote: Side effects are reduced burst lengths when writing out decoded frames to memory, so there is an "enable_bwb" module parameter to turn it ba

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Tuesday 18 Jul 2017 16:43:13 Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring

Re: [PATCH 00/11] drm/sun4i: add CEC support

2017-07-19 Thread Hans Verkuil
On 18/07/17 18:29, Maxime Ripard wrote: > Hi, > > On Tue, Jul 11, 2017 at 11:06:52PM +0200, Hans Verkuil wrote: >> On 11/07/17 22:39, Maxime Ripard wrote: >>> On Tue, Jul 11, 2017 at 08:30:33AM +0200, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support for the

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Niklas Söderlund
On 2017-07-18 16:43:13 -0500, Rob Herring wrote: > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring > Cc: Kyungmin Park > Cc: Andrzej

[PATCH v2 0/2] media: platform: davinci: remove VPFE_CMD_S_CCDC_RAW_PARAMS IOCTL

2017-07-19 Thread Lad, Prabhakar
This patch series drops VPFE_CMD_S_CCDC_RAW_PARAMS ioctl, from davicni vpfe_capture driver because of following reasons: - The function constantly mixes up pointers and phys_addr_t numbers - This is part of a 'VPFE_CMD_S_CCDC_RAW_PARAMS' ioctl command that is described as an 'experimental ioctl

[PATCH v2 1/2] media: platform: davinci: prepare for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

2017-07-19 Thread Lad, Prabhakar
preparing for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl having minimalistic code changes so as it can be applied for backports. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --

[PATCH v2 2/2] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

2017-07-19 Thread Lad, Prabhakar
For dm355 and dm644x the vpfe driver provided a ioctl to configure the raw bayer config using a IOCTL, but since the code was not properly implemented and aswell the IOCTL was marked as 'experimental ioctl that will change in future kernels', dropping this IOCTL. Signed-off-by: Lad, Prabhakar ---

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

2017-07-19 Thread Philipp Zabel
Hi Ian, On Wed, 2017-07-19 at 08:16 +0100, Ian Arkver wrote: > Hi Philipp, > > On 02/03/17 10:19, Philipp Zabel wrote: > > I don't know what the BWB unit is, I guess W is for write and one of the > > Bs is for burst. All I know is that there repeatedly have been issues > > with it hanging on cert

Re: [PATCH 3/8] dt: bindings: Add a binding for referencing EEPROM from camera sensors

2017-07-19 Thread Maxime Ripard
Hi Sakari, On Wed, Jun 14, 2017 at 12:47:14PM +0300, Sakari Ailus wrote: > Many camera sensor devices contain EEPROM chips that describe the > properties of a given unit --- the data is specific to a given unit can > thus is not stored e.g. in user space or the driver. > > Some sensors embed the

Re: [PATCH v3 03/12] intel-ipu3: Add DMA API implementation

2017-07-19 Thread Arnd Bergmann
On Wed, Jul 19, 2017 at 5:12 AM, Yong Zhi wrote: > From: Tomasz Figa > > This patch adds support for the IPU3 DMA mapping API. > > Signed-off-by: Tomasz Figa > Signed-off-by: Yong Zhi This needs some explanation on why you decided to go down the route of adding your own dma_map_ops. It's not o

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

2017-07-19 Thread Ian Arkver
Hi Philipp, On 02/03/17 10:19, Philipp Zabel wrote: I don't know what the BWB unit is, I guess W is for write and one of the Bs is for burst. All I know is that there repeatedly have been issues with it hanging on certain streams (ENGR00223231, ENGR00293425), with various firmware versions, some

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-07-19 Thread Yong
On Wed, 19 Jul 2017 08:50:19 +0200 Maxime Ripard wrote: > On Wed, Jul 19, 2017 at 09:33:49AM +0300, Baruch Siach wrote: > > Hi Yong, > > > > On Wed, Jul 19, 2017 at 02:21:20PM +0800, Yong wrote: > > > On Wed, 19 Jul 2017 07:49:23 +0300 > > > Baruch Siach wrote: > > > > On Wed, Jul 19, 2017 at 0