[PATCH v1 1/4] dt-bindings: media: mtk-cir: Add support for MT7622 SoC

2017-06-29 Thread sean.wang
From: Sean Wang Document the devicetree bindings for CIR on MediaTek MT7622 SoC. Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/media/mtk-cir.txt | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/media/mtk-cir.txt b/D

[PATCH v1 2/4] media: rc: mtk-cir: add platform data to adapt into various hardware

2017-06-29 Thread sean.wang
From: Sean Wang This patch is the preparation patch in order to adapt into various hardware through adding platform data which holds specific characteristics and differences among MediaTek supported CIR devices instead of the old way defining those data in the static way as macro has. And the exi

[PATCH v1 0/4] media: rc: add support for IR receiver on MT7622 SoC

2017-06-29 Thread sean.wang
From: Sean Wang This patchset introduces Consumer IR (CIR) support for MT7622 SoC implements raw mode for more compatibility with different protocols as previously SoC did. Before adding support to MT7622 SoC, extra code refactor is done since there're major differences in register and field defi

[PATCH v1 4/4] MAINTAINERS: add entry for MediaTek CIR driver

2017-06-29 Thread sean.wang
From: Sean Wang I work for MediaTek on maintaining the MediaTek CIR driver for the existing SoCs and adding support for the following SoCs. Signed-off-by: Sean Wang --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2a1290a..1bc1fb1 100644

[PATCH v1 3/4] media: rc: mtk-cir: add support for MediaTek MT7622 SoC

2017-06-29 Thread sean.wang
From: Sean Wang This patch adds driver for CIR controller on MT7622 SoC. It has similar handling logic as the previously MT7623 does, but there are some differences in the register and field definition. So for ease portability and maintenance, those differences all are being kept inside the platf

cron job: media_tree daily build: ERRORS

2017-06-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jun 30 05:00:20 CEST 2017 media-tree git hash:2748e76ddb2967c4030171342ebdd3faa6a5e8e8 media_build gi

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-06-29 Thread Chen-Yu Tsai
On Fri, Jun 30, 2017 at 5:19 AM, Rob Herring wrote: > On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: >> Add binding documentation for Allwinner CSI. > > For the subject: > > dt-bindings: media: Add Allwinner Camera Sensor Interface (CSI) > > "binding documentation" is redundant. > >> >

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-29 Thread Sakari Ailus
Hi Todor, On Thu, Jun 29, 2017 at 07:36:47PM +0300, Todor Tomov wrote: > >> +/* > >> + * csiphy_link_setup - Setup CSIPHY connections > >> + * @entity: Pointer to media entity structure > >> + * @local: Pointer to local pad > >> + * @remote: Pointer to remote pad > >> + * @flags: Link flags > >> +

[PATCH] staging: media: atomisp: Remove unnecessary return statement in void function

2017-06-29 Thread Amitoj Kaur Chawla
Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/media/atomisp/pci/atomisp2/h

Re: [PATCH v3] media: platform: rcar_imr: add IMR-LSX3 support

2017-06-29 Thread Rob Herring
On Wed, Jun 28, 2017 at 10:56:23PM +0300, Sergei Shtylyov wrote: > Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found > only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it > supports only planar video formats but can use the video capture data for > the

Re: [PATCH RFC 2/2] dt-bindings: add binding documentation for Allwinner CSI

2017-06-29 Thread Rob Herring
On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote: > Add binding documentation for Allwinner CSI. For the subject: dt-bindings: media: Add Allwinner Camera Sensor Interface (CSI) "binding documentation" is redundant. > > Signed-off-by: Yong Deng > --- > .../devicetree/bindings/media/

Re: [PATCH v3 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-29 Thread Jacek Anaszewski
Hi Thierry, For the whole series: Acked-by: Jacek Anaszewski Best regards, Jacek Anaszewski On 06/27/2017 06:08 PM, Thierry Escande wrote: > Hi, > > This series contains various fixes and improvements for the Samsung > s5p-jpeg driver. Most of these patches come from the Chromium v3.8 > kerne

Re: [PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-29 Thread Jacek Anaszewski
Hi Thierry, On 06/27/2017 06:08 PM, Thierry Escande wrote: > If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed > s5p_jpeg_q_data structure is not modify so there is no need to use a s/modify/modified/ > temporary structure and the field-by-field copy can be avoided. > > Signed-

Re: [linux-media] How to handle independent CA devices

2017-06-29 Thread Jasmin J.
Hello! It is now 6,5 years since this eMail ir reply to and a lot of things changed since then. As there is currently a lot of effort done to get the newest version of the DD (Digital Devices) drivers into the Kernel, I want to bring up this topic again. Yes, this eMail is long but it is necessar

Re: Trying to use IR driver for my SoC

2017-06-29 Thread Sean Young
On Thu, Jun 29, 2017 at 09:12:48PM +0200, Mason wrote: > On 29/06/2017 19:50, Sean Young wrote: > > > On Thu, Jun 29, 2017 at 06:25:55PM +0200, Mason wrote: > > > >> $ ir-keytable -v -t > >> Found device /sys/class/rc/rc0/ > >> Input sysfs node is /sys/class/rc/rc0/input0/ > >> Event sysfs node is

Re: [PATCH] [media] dvb-frontends/cxd2841er: require STATE_ACTIVE_* for agc readout

2017-06-29 Thread Abylay Ospan
Acked-by: Abylay Ospan 2017-06-25 6:02 GMT-04:00 Daniel Scheller : > From: Daniel Scheller > > When the demod driver puts the demod into sleep or shutdown state and it's > status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed > to the kernel log. If the last delsys was DVB-T/T2

Re: Trying to use IR driver for my SoC

2017-06-29 Thread Mason
On 29/06/2017 19:50, Sean Young wrote: > On Thu, Jun 29, 2017 at 06:25:55PM +0200, Mason wrote: > >> $ ir-keytable -v -t >> Found device /sys/class/rc/rc0/ >> Input sysfs node is /sys/class/rc/rc0/input0/ >> Event sysfs node is /sys/class/rc/rc0/input0/event0/ >> Parsing uevent /sys/class/rc/rc0/i

[PATCH] Added support for the TerraTec T1 DVB-T USB tuner [IT9135 chipset]

2017-06-29 Thread Nuno Henriques
Signed-off-by: Nuno Henriques --- drivers/media/dvb-core/dvb-usb-ids.h | 1 + drivers/media/usb/dvb-usb-v2/af9035.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/media/dvb-core/dvb-usb-ids.h b/drivers/media/dvb-core/dvb-usb-ids.h index e200aa6f2d2f..5b6041d462bc 100644 --- a/dr

Re: Trying to use IR driver for my SoC

2017-06-29 Thread Sean Young
On Thu, Jun 29, 2017 at 06:25:55PM +0200, Mason wrote: > On 29/06/2017 17:55, Sean Young wrote: > > > On Thu, Jun 29, 2017 at 05:29:01PM +0200, Mason wrote: > > > >> I'm trying to use an IR driver written for my SoC: > >> https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-i

Re: Null Pointer Dereference in mceusb

2017-06-29 Thread Sebastian
Sorry for the long delay, Johan. 2017-06-01 9:20 GMT+02:00 Johan Hovold : > [ +CC: media list ] > > On Wed, May 31, 2017 at 08:25:42PM +0200, Sebastian wrote: > > What is the lsusb -v output for your device? And have you successfully > used this device with this driver before? > No, the device wa

[PATCH] hdmi: audio infoframe log: corrected channel count

2017-06-29 Thread Martin Bugge
Audio channel count should start from 2. Reference: CEA-861-F Table 27. Cc: Hans Verkuil Reported-by: Ahung Cheng Signed-off-by: Martin Bugge --- drivers/video/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index 1cf907e.

Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

2017-06-29 Thread Stephen Hemminger
On Thu, 29 Jun 2017 11:42:59 +0200 Johannes Thumshirn wrote: > On Sat, Jun 24, 2017 at 05:15:07PM -0300, Mauro Carvalho Chehab wrote: > > Sorry, but I can't see any advantage on it. On the downside, it > > includes the media controller header file (media.h) where it > > is not needed. > > My r

Re: [PATCH v2 04/19] media: camss: Add CSIPHY files

2017-06-29 Thread Todor Tomov
Hi Sakari, On 06/29/2017 12:34 AM, Sakari Ailus wrote: > Hi Todor, > > It's been a while --- how do you do? > > Thanks for the patchset! Thank you for the review. I'll focus more on this now, so let's see :) > > On Mon, Jun 19, 2017 at 05:48:24PM +0300, Todor Tomov wrote: >> These files contr

Re: Trying to use IR driver for my SoC

2017-06-29 Thread Mason
Hello, On 29/06/2017 17:55, Sean Young wrote: > On Thu, Jun 29, 2017 at 05:29:01PM +0200, Mason wrote: > >> I'm trying to use an IR driver written for my SoC: >> https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-ir.c >> >> I added these options to my defconfig: >> >> +CON

[PATCH v1.1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1

2017-06-29 Thread Kieran Bingham
A recent change to the frame completion handling has changed the order in which the vblank timestamps are updated. To fix this requires handling the vblank events on the frame end event which comes from the VSP1 driver on Gen3 instead. Prevent the CRTC IRQ from being enabled on Gen3 hardware and

Re: Trying to use IR driver for my SoC

2017-06-29 Thread Sean Young
Hello, On Thu, Jun 29, 2017 at 05:29:01PM +0200, Mason wrote: > I'm trying to use an IR driver written for my SoC: > https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-ir.c > > I added these options to my defconfig: > > +CONFIG_MEDIA_SUPPORT=y > +CONFIG_MEDIA_RC_SUPPORT=y

Re: Trying to use IR driver for my SoC

2017-06-29 Thread Mason
On 29/06/2017 17:29, Mason wrote: > I suppose I am missing some important piece of the puzzle? > I hope someone can point me in the right direction. FWIW, $ ir-keytable -v Found device /sys/class/rc/rc0/ Input sysfs node is /sys/class/rc/rc0/input0/ Couldn't find any node at /sys/class/rc/rc0/in

Trying to use IR driver for my SoC

2017-06-29 Thread Mason
Hello, I'm trying to use an IR driver written for my SoC: https://github.com/mansr/linux-tangox/blob/master/drivers/media/rc/tangox-ir.c I added these options to my defconfig: +CONFIG_MEDIA_SUPPORT=y +CONFIG_MEDIA_RC_SUPPORT=y +CONFIG_RC_DEVICES=y +CONFIG_IR_TANGO=y (I don't think I need the RC

Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1

2017-06-29 Thread Kieran Bingham
> @@ -658,10 +660,14 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg) > rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK); > > if (status & DSSR_FRM) { > - drm_crtc_handle_vblank(&rcrtc->crtc); > - > - if (rcdu->info->gen < 3) > + /* >

[PATCH v1 0/2] drm: rcar-du: Repair vblank event handling

2017-06-29 Thread Kieran Bingham
The recent changes to the rcar-du driver to fix a race condition inadvertently change the order of which vblanks are reported. Correct this by handling vblank events in the same completion handler. This removes the need for the IRQ handler on DU instances which are sourced by a VSP1. For other pl

[PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1

2017-06-29 Thread Kieran Bingham
A recent change to the frame completion handling has changed the order in which the vblank timestamps are updated. To fix this requires handling the vblank events on the frame end event which comes from the VSP1 driver on Gen3 instead. Prevent the CRTC IRQ from being enabled on Gen3 hardware and

[PATCH v1 1/2] drm: rcar-du: Enable the FRM interrupt for vblank

2017-06-29 Thread Kieran Bingham
The rcar_du_crtc_{enable,disable}_vblank functions are configured to control the VBE interrupt event. The implementation of interlaced support in the rcar-du changes the required behavior such that vblanks are handled on frame end events, but does not update the enable register to reflect this. E

Re: [PATCH v1 4/6] [media] ov9650: use write_array() for resolution sequences

2017-06-29 Thread Hugues FRUCHET
On 06/26/2017 06:33 PM, Sakari Ailus wrote: > Hi Hugues, > > On Thu, Jun 22, 2017 at 05:05:40PM +0200, Hugues Fruchet wrote: >> Align resolution sequences on initialization sequence using >> i2c_rv structure NULL terminated .This add flexibility >> on resolution sequence size. >> Document resolu

Re: [PATCH] drivers/staging/media: Prefer using __func__ instead

2017-06-29 Thread Joe Perches
On Thu, 2017-06-29 at 16:59 +0530, Pushkar Jambhlekar wrote: > Function name is hardcoded. replacing with __func__ Please run your proposed patches through checkpatch before you send them. > diff --git a/drivers/staging/media/cxd2099/cxd2099.c > b/drivers/staging/media/cxd2099/cxd2099.c [] > @@

Re: [PATCH v7 2/2] media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2017-06-29 Thread Niklas Söderlund
Hi Hans, Thanks for your feedback. On 2017-06-19 13:44:22 +0200, Hans Verkuil wrote: > On 06/12/2017 04:48 PM, Niklas Söderlund wrote: > > Hi Hans, > > > > Thanks for your comments. > > > > On 2017-05-29 13:16:23 +0200, Hans Verkuil wrote: > > > On 05/24/2017 02:13 AM, Niklas Söderlund wrote: >

Re: [PATCH v2 01/19] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

2017-06-29 Thread Todor Tomov
Thank you for review, Rob. On 06/23/2017 11:41 PM, Rob Herring wrote: > On Mon, Jun 19, 2017 at 05:48:21PM +0300, Todor Tomov wrote: >> Add DT binding document for Qualcomm Camera subsystem driver. > > "dt-bindings: media: ..." for the subject please. I'll change it in the next version. > >> >

Re: [PATCH v3 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when ERR_INT_EN is set to 1. Fix this case and report BUF_STATE_ERROR to videobuf2. Si

Re: [PATCH v3 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/pla

Re: [PATCH v3 7/8] [media] s5p-jpeg: Add support for resolution change event

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: henryhsu This patch adds support for resolution change event to notify clients so they can prepare correct output buffer. When resolution change happened, G_FMT for CAPTURE should return old resolution and format before CAPTURE queues stre

Re: [PATCH v3 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: This patch moves the subsampling value decoding read from the jpeg header into its own function. This new function is called s5p_jpeg_subsampling_decode() and returns true if it successfully decodes the subsampling value, false otherwise. Signed-

Re: [PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed s5p_jpeg_q_data structure is not modify so there is no need to use a temporary structure and the field-by-field copy can be avoided. Signed-off-by: Thierry Escande Acked-by: An

Re: [PATCH v3 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/plat

Re: [PATCH v3 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: Tony K Nadackal Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/

Re: [PATCH v3 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-29 Thread Andrzej Pietrasiewicz
W dniu 27.06.2017 o 18:08, Thierry Escande pisze: From: Tony K Nadackal When queuing an OUTPUT buffer for decoder, s5p_jpeg_parse_hdr() function parses the input jpeg file and takes the width and height parameters from its header. These new width/height values will be used for the calculation o

Re: [PATCH v3 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-29 Thread Andrzej Pietrasiewicz
Hi Thierry, W dniu 27.06.2017 o 18:08, Thierry Escande pisze: Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. Most of these patches come from the Chromium v3.8 kernel tree. Thank you for the series. It looks good to me. Andrzej

[PATCH] drivers/staging/media: Prefer using __func__ instead

2017-06-29 Thread Pushkar Jambhlekar
Function name is hardcoded. replacing with __func__ Signed-off-by: Pushkar Jambhlekar --- drivers/staging/media/cxd2099/cxd2099.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c index f2891

[bug report] media: v4l: omap_vout: vrfb: Convert to dmaengine

2017-06-29 Thread Dan Carpenter
Hello Peter Ujfalusi, The patch 6a1560ecaa8c: "media: v4l: omap_vout: vrfb: Convert to dmaengine" from May 3, 2017, leads to the following static checker warning: drivers/media/platform/omap/omap_vout_vrfb.c:273 omap_vout_prepare_vrfb() error: uninitialized symbol 'flags'. drive

[PATCH v5 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-29 Thread Jose Abreu
This adds support for the Synopsys Designware HDMI RX PHY e405. This phy receives and decodes HDMI video that is delivered to a controller. Main features included in this driver are: - Equalizer algorithm that chooses the phy best settings according to the detected HDMI cable chara

[PATCH v5 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-29 Thread Jose Abreu
This is an initial submission for the Synopsys Designware HDMI RX Controller Driver. This driver interacts with a phy driver so that a communication between them is created and a video pipeline is configured. The controller + phy pipeline can then be integrated into a fully featured system that ca

[PATCH v5 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX

2017-06-29 Thread Jose Abreu
Document the bindings for the Synopsys Designware HDMI RX. Signed-off-by: Jose Abreu Cc: Carlos Palminha Cc: Rob Herring Cc: Mark Rutland Cc: Mauro Carvalho Chehab Cc: Hans Verkuil Cc: Sylwester Nawrocki Cc: devicet...@vger.kernel.org Changes from v4: - Use "cfg" instead of "cfg-cl

[PATCH v5 0/4] Synopsys Designware HDMI Video Capture Controller + PHY

2017-06-29 Thread Jose Abreu
The Synopsys Designware HDMI RX controller is an HDMI receiver controller that is responsible to process digital data that comes from a phy. The final result is a stream of raw video data that can then be connected to a video DMA, for example, and transfered into RAM so that it can be displayed. T

[PATCH v5 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers

2017-06-29 Thread Jose Abreu
Add a entry for Synopsys Designware HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu Cc: Carlos Palminha --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c4be6d4..7ebc6dd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11354,6 +

Re: [PATCH 2/2] v4l: fwnode: Support generic parsing of graph endpoints in V4L2

2017-06-29 Thread Sakari Ailus
On Thu, Jun 29, 2017 at 12:18:44PM +0200, Niklas Söderlund wrote: > On 2017-06-29 12:57:55 +0300, Sakari Ailus wrote: > > On Thu, Jun 29, 2017 at 11:02:03AM +0200, Niklas Söderlund wrote: > > > Hi Sakari, > > > > > > Thanks for your patch. > > > > > > On 2017-06-29 10:30:10 +0300, Sakari Ailus wr

Re: [PATCH 2/2] v4l: fwnode: Support generic parsing of graph endpoints in V4L2

2017-06-29 Thread Niklas Söderlund
On 2017-06-29 12:57:55 +0300, Sakari Ailus wrote: > On Thu, Jun 29, 2017 at 11:02:03AM +0200, Niklas Söderlund wrote: > > Hi Sakari, > > > > Thanks for your patch. > > > > On 2017-06-29 10:30:10 +0300, Sakari Ailus wrote: > > > The current practice is that drivers iterate over their endpoints and

Re: [PATCH 2/2] v4l: fwnode: Support generic parsing of graph endpoints in V4L2

2017-06-29 Thread Sakari Ailus
On Thu, Jun 29, 2017 at 11:02:03AM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your patch. > > On 2017-06-29 10:30:10 +0300, Sakari Ailus wrote: > > The current practice is that drivers iterate over their endpoints and > > parse each endpoint separately. This is very similar in a n

[PATCH v6.1 1/3] media: adv748x: Add adv7481, adv7482 bindings

2017-06-29 Thread Kieran Bingham
From: Kieran Bingham Create device tree bindings documentation for the ADV748x. The ADV748x supports both the ADV7481 and ADV7482 chips which provide analogue decoding and HDMI receiving capabilities Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v6: - Clean up description an

Re: [PATCH v6 1/3] media: adv748x: Add adv7181, adv7182 bindings

2017-06-29 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday 27 Jun 2017 16:03:32 Kieran Bingham wrote: > From: Kieran Bingham > > Create device tree bindings documentation for the ADV748x. > The ADV748x supports both the ADV7481 and ADV7482 chips which > provide analogue decoding and HDMI receiving capabili

Re: [PATCH v6 3/3] MAINTAINERS: Add ADV748x driver

2017-06-29 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Tuesday 27 Jun 2017 16:03:34 Kieran Bingham wrote: > From: Kieran Bingham > > The ADV7481 is an integrated video decoder and combined HDMI/MHL > receiver. > > Signed-off-by: Kieran Bingham Acked-by: Laurent Pinchart > --- > MAINTAINERS | 6 ++ >

Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

2017-06-29 Thread Johannes Thumshirn
On Sat, Jun 24, 2017 at 05:15:07PM -0300, Mauro Carvalho Chehab wrote: > Sorry, but I can't see any advantage on it. On the downside, it > includes the media controller header file (media.h) where it > is not needed. My reasoning was the differences in semantics. KERNEL_VERSION() is for encoding t

Re: [PATCH v6 1/3] media: adv748x: Add adv7181, adv7182 bindings

2017-06-29 Thread Kieran Bingham
On 29/06/17 10:37, Geert Uytterhoeven wrote: > On Tue, Jun 27, 2017 at 5:03 PM, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Create device tree bindings documentation for the ADV748x. >> The ADV748x supports both the ADV7481 and ADV7482 chips which >> provide analogue decoding and HDMI r

Re: [PATCH v6 1/3] media: adv748x: Add adv7181, adv7182 bindings

2017-06-29 Thread Geert Uytterhoeven
On Tue, Jun 27, 2017 at 5:03 PM, Kieran Bingham wrote: > From: Kieran Bingham > > Create device tree bindings documentation for the ADV748x. > The ADV748x supports both the ADV7481 and ADV7482 chips which > provide analogue decoding and HDMI receiving capabilities The subject says adv7*1*81, adv

Re: [PATCH] [media] staging/imx: remove confusing IS_ERR_OR_NULL usage

2017-06-29 Thread Philipp Zabel
Hi Arnd, thank you for the cleanup. I see two issues below: On Wed, 2017-06-28 at 22:13 +0200, Arnd Bergmann wrote: > While looking at a compiler warning, I noticed the use of > IS_ERR_OR_NULL, which is generally a sign of a bad API design > and should be avoided. > > In this driver, this is fai

Re: [PATCH 2/2] v4l: fwnode: Support generic parsing of graph endpoints in V4L2

2017-06-29 Thread Niklas Söderlund
On 2017-06-29 11:02:03 +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your patch. > > On 2017-06-29 10:30:10 +0300, Sakari Ailus wrote: > > The current practice is that drivers iterate over their endpoints and > > parse each endpoint separately. This is very similar in a number of > >

Re: [PATCH 2/2] v4l: fwnode: Support generic parsing of graph endpoints in V4L2

2017-06-29 Thread Niklas Söderlund
Hi Sakari, Thanks for your patch. On 2017-06-29 10:30:10 +0300, Sakari Ailus wrote: > The current practice is that drivers iterate over their endpoints and > parse each endpoint separately. This is very similar in a number of > drivers, implement a generic function for the job. Driver specific ma

[PATCH] [media] cx23885: add const to v4l2_file_operations structure

2017-06-29 Thread Bhumika Goyal
Declare v4l2_file_operations structure as const as it is only stored in the fops field of video_device structure. This field is of type const, so declare v4l2_file_operations structures with similar properties as const. Signed-off-by: Bhumika Goyal --- drivers/media/pci/cx23885/cx23885-417.c | 2

[PATCH] [media] media/platform: add const to v4l2_file_operations structures

2017-06-29 Thread Bhumika Goyal
Declare v4l2_file_operations structures as const as they are only stored in the fops field of video_device structures. This field is of type const, so declare v4l2_file_operations structures with similar properties as const. Cross compiled bfin_capture.o for blackfin arch. vpbe_display.o file did

Re: [PATCH 1/2] v4l: fwnode: link_frequency is an optional property

2017-06-29 Thread Niklas Söderlund
Hi Sakari, Thanks for your patch. On 2017-06-29 10:30:09 +0300, Sakari Ailus wrote: > v4l2_fwnode_endpoint_alloc_parse() is intended as a replacement for > v4l2_fwnode_endpoint_parse(). It parses the "link-frequency" property and > if the property isn't found, it returns an error. However, > "lin

[PATCH] media: exynos4-is: fimc-is-i2c: constify dev_pm_ops structures.

2017-06-29 Thread Arvind Yadav
dev_pm_ops are not supposed to change at runtime. All functions working with dev_pm_ops provided by work with const dev_pm_ops. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1195 376 01571 623 drivers/media/platfor

Re: [PATCH 1/1] docs-rst: media: Document s_stream() core op usage

2017-06-29 Thread Sakari Ailus
Hejssan! On Thu, Jun 29, 2017 at 09:21:53AM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your patch. > > On 2017-06-29 09:38:53 +0300, Sakari Ailus wrote: > > As we begin to add support for systems with media pipelines controlled by > > more than one device driver, it is essential

[PATCH 2/2] v4l: fwnode: Support generic parsing of graph endpoints in V4L2

2017-06-29 Thread Sakari Ailus
The current practice is that drivers iterate over their endpoints and parse each endpoint separately. This is very similar in a number of drivers, implement a generic function for the job. Driver specific matters can be taken into account in the driver specific callback. Convert the omap3isp as an

[PATCH 0/2] Unified fwnode endpoint parser

2017-06-29 Thread Sakari Ailus
Hi folks, We have a large influx of new, unmerged, drivers that are now parsing fwnode endpoints and each one of them is doing this a little bit differently. The needs are still exactly the same for the graph data structure is device independent. This is still a non-trivial task and the majority o

[PATCH 1/2] v4l: fwnode: link_frequency is an optional property

2017-06-29 Thread Sakari Ailus
v4l2_fwnode_endpoint_alloc_parse() is intended as a replacement for v4l2_fwnode_endpoint_parse(). It parses the "link-frequency" property and if the property isn't found, it returns an error. However, "link-frequency" is an optional property and if it does not exist is not an error. Instead, the nu

Re: [PATCH 1/1] docs-rst: media: Document s_stream() core op usage

2017-06-29 Thread Niklas Söderlund
Hi Sakari, Thanks for your patch. On 2017-06-29 09:38:53 +0300, Sakari Ailus wrote: > As we begin to add support for systems with media pipelines controlled by > more than one device driver, it is essential that we precisely define the > responsibilities of each component in the stream control an