Re: omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-25 Thread H. Nikolaus Schaller
Hi Pavel, > Am 25.06.2017 um 11:18 schrieb Pavel Machek : > > Hi! > >> * unfortunately we still get no image :( >> >> The latter is likely a setup issue of our camera interface (OMAP3 ISP = >> Image Signal Processor) which >> we were not yet able to solve. Oscilloscoping signals on the interfa

Re: [PATCH v1 1/6] DT bindings: add bindings for ov965x camera module

2017-06-25 Thread H. Nikolaus Schaller
> Am 24.06.2017 um 00:24 schrieb Suman Anna : > > On 06/23/2017 01:59 PM, H. Nikolaus Schaller wrote: >> Hi Suman, >> >>> Am 23.06.2017 um 20:05 schrieb Suman Anna : >>> >> >> Or does it just mean that it defines the property name? > > Please read the documentation link I sent

Re: [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant

2017-06-25 Thread H. Nikolaus Schaller
> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : > > Add a first support of OV9655 variant. > Because of register set slightly different from OV9650/9652, > not all of the driver features are supported (controls). > Supported resolutions are limited to VGA, QVGA, QQVGA. > Supported format is lim

Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-25 Thread H. Nikolaus Schaller
Hi Hugues, > Am 23.06.2017 um 12:25 schrieb H. Nikolaus Schaller : > > Hi Hugues, > >> Am 22.06.2017 um 17:41 schrieb H. Nikolaus Schaller : >> >> >>> Am 22.06.2017 um 17:05 schrieb Hugues Fruchet : >>> >>> This patchset enables OV9655 camera support. >>> >>> OV9655 support has been tested u

cron job: media_tree daily build: ERRORS

2017-06-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Mon Jun 26 05:00:18 CEST 2017 media-tree git hash:430e29d9c0f65d9653a0b7f7a56f1c6cd374b84b media_build gi

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

2017-06-25 Thread Mauro Carvalho Chehab
Em Sun, 25 Jun 2017 09:15:06 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 23 Jun 2017 10:02:39 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Mon, 19 Jun 2017 16:56:13 +0900 > > "Takiguchi, Yasunari" escreveu: > > > > > >> +static int cxd2880_get_frontend_t(struct dvb_frontend *fe, > >

[PATCH v2 1/7] [media] dvb-core/dvb_ca_en50221.c: State UNINITIALISED instead of INVALID

2017-06-25 Thread Jasmin J.
From: Ralph Metzler In case of a linkinit failure change to state UNINITIALISED to re-init the CAM. Original code change by Ralph Metzler, modified by Jasmin Jessich to match Kernel code style. Signed-off-by: Ralph Metzler Signed-off-by: Jasmin Jessich --- drivers/media/dvb-core/dvb_ca_en502

[PATCH v2 5/7] [staging] cxd2099/cxd2099.c: Removed useless printing in cxd2099 driver

2017-06-25 Thread Jasmin J.
From: Ralph Metzler campoll and read_data are called very often and the printouts are very annoying and make the driver unusable. They seem to be left over from developing the buffer mode. Original code change by Ralph Metzler, modified by Jasmin Jessich to match current Kernel code. Signed-off

[PATCH v2 3/7] [media] dvb-core/dvb_ca_en50221.c: Add block read/write functions

2017-06-25 Thread Jasmin J.
From: Ralph Metzler Some lower level drivers may work better when sending blocks of data instead byte per byte. For this we need new function pointers in the dvb_ca_en50221 protocol structure (read_data, write_data) and the protocol needs to execute them, if they are defined. Block data transmiss

[PATCH v2 0/7] Add block read/write to en50221 CAM functions

2017-06-25 Thread Jasmin J.
From: Jasmin Jessich This is now the V2 version of the patch series with preserved author and little checkpatch fixes. I also combined some patches which needs to be applied at once to. Changes from v1 to v2: - Preserved authorship of original author. - All patches tested with checkpatch.pl (n

[PATCH v2 2/7] [media] dvb-core/dvb_ca_en50221.c: Increase timeout for link init

2017-06-25 Thread Jasmin J.
From: Ralph Metzler Some CAMs do a really slow initialization, which requires a longer timeout for the first response. Original code change by Ralph Metzler, modified by Jasmin Jessich to match Kernel code style. Signed-off-by: Ralph Metzler Signed-off-by: Jasmin Jessich --- drivers/media/dv

[PATCH v2 6/7] [staging] cxd2099/cxd2099.c: Removed printing in write_block

2017-06-25 Thread Jasmin J.
From: Jasmin Jessich There were remaining debug prints which haven't been found earlier due to the disabled buffer mode (see commit "Removed useless printing in cxd2099 driver" for the already removed printings. Signed-off-by: Jasmin Jessich --- drivers/staging/media/cxd2099/cxd2099.c | 3 ---

[PATCH v2 7/7] [staging] cxd2099/cxd2099.c: Activate cxd2099 buffer mode

2017-06-25 Thread Jasmin J.
From: Jasmin Jessich Activate the cxd2099 buffer mode. Signed-off-by: Jasmin Jessich --- drivers/staging/media/cxd2099/cxd2099.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/cxd2099/cxd2099.c b/drivers/staging/media/cxd2099/cxd2099.c index 3431cf

[PATCH v2 4/7] [staging] cxd2099/cxd2099.c/.h: Fixed buffer mode

2017-06-25 Thread Jasmin J.
From: Ralph Metzler The buffer mode was already implemented in this driver, but it did not work as expected. This has been fixed now, but it is still deactivated and can be activated by removing a comment at the begin of the file. Original code change by Ralph Metzler, modified by Jasmin Jessich

Re: [PATCH v3 2/2] v4l: async: add subnotifier registration for subdevices

2017-06-25 Thread Sylwester Nawrocki
On 06/13/2017 04:30 PM, Niklas Söderlund wrote: When the registered() callback of v4l2_subdev_internal_ops is called the subdevice has access to the master devices v4l2_dev and it's called with the async frameworks list_lock held. In this context the subdevice can register its own notifiers to al

Re: [PATCH v3 1/2] v4l: async: check for v4l2_dev in v4l2_async_notifier_register()

2017-06-25 Thread Sylwester Nawrocki
On 06/13/2017 04:30 PM, Niklas Söderlund wrote: Add a check for v4l2_dev to v4l2_async_notifier_register() as to fail as early as possible since this will fail later in v4l2_async_test_notify(). Signed-off-by: Niklas Söderlund Acked-by: Sakari Ailus Acked-by: Hans Verkuil Acked-by: Sylwester N

Re: [PATCH v4 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver

2017-06-25 Thread Sylwester Nawrocki
On 06/20/2017 07:26 PM, Jose Abreu wrote: > This is an initial submission for the Synopsys Designware HDMI RX > Controller Driver. This driver interacts with a phy driver so that > a communication between them is created and a video pipeline is > configured. > Signed-off-by: Jose Abreu > Cc: Carl

Re: [PATCH v4 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver

2017-06-25 Thread Sylwester Nawrocki
Hi Jose, Thank you for addressing my review comments. Couple more suggestions below. On 06/20/2017 07:26 PM, Jose Abreu wrote: > This adds support for the Synopsys Designware HDMI RX PHY e405. This > phy receives and decodes HDMI video that is delivered to a controller. > +static int dw_phy_conf

Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support (fwd)

2017-06-25 Thread Julia Lawall
test WARNING on linuxtv-media/master] [also build test WARNING on v4.12-rc6 next-20170623] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hugues-Fruchet/Add-support-of-OV9655-camera/20170625-201153

Re: DD support improvements (was: Re: [PATCH v3 00/13] stv0367/ddbridge: support CTv6/FlexCT hardware)

2017-06-25 Thread Daniel Scheller
Am Sat, 24 Jun 2017 13:50:01 -0300 schrieb Mauro Carvalho Chehab : > Em Thu, 22 Jun 2017 23:35:27 +0200 > Ralph Metzler escreveu: > > Would it be possible to change things at the dddvb tree to make > it to use our coding style (for example, replacing CamelCase by the > kernel_style), in order to

[PATCH] ov9650: fix semicolon.cocci warnings

2017-06-25 Thread kbuild test robot
drivers/media/i2c/ov9650.c:2034:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 5ffa34fa8f2e ("ov9650: add support of OV9655 variant") CC: Hugues Fruchet Signed-off-by: Fengguang Wu --- ov9650.c |2 +- 1 file changed, 1 in

Re: [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant

2017-06-25 Thread kbuild test robot
-OV9655-camera/20170625-201153 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/i2c/ov9650.c:2034:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure

[PATCH 1/2] media: dtv-core.rst: add an introduction to FE kAPI

2017-06-25 Thread Mauro Carvalho Chehab
Instead of just start describing the kAPI functions, add an introduction giving a general line about a DVB driver's structure. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/dtv-core.rst | 33 + 1 file changed, 29 insertions(+), 4 deletions(-)

[PATCH 2/2] media: dtv-core.rst: complete description of a demod driver

2017-06-25 Thread Mauro Carvalho Chehab
A section talking about demod statistics implementation was recently added, but it seemed to start from nowere, without a previous description about how a demod driver would look like. Add such description, for completeness. Signed-off-by: Mauro Carvalho Chehab --- Documentation/media/kapi/dtv-

Re: [PATCH v1 3/5] [media] stm32-dcmi: crop sensor image to match user resolution

2017-06-25 Thread kbuild test robot
/Camera-support-on-STM32F746G-DISCO-board/20170625-204425 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/platform/stm32/stm32-dcmi.c:808:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:562:2

[PATCH] stm32-dcmi: fix semicolon.cocci warnings

2017-06-25 Thread kbuild test robot
drivers/media/platform/stm32/stm32-dcmi.c:808:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:562:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:762:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fix

Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support

2017-06-25 Thread kbuild test robot
-OV9655-camera/20170625-201153 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x079-06251032 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones

[PATCH 18/19] ir-lirc-codec: move the remaining fops over from lirc_dev

2017-06-25 Thread David Härdeman
ir-lirc-codec is the only user of these functions, so instead of exporting them from lirc_dev, move all of them over to ir-lirc-codec. This means that all ir-lirc-codec fops can be found next to each other in ir-lirc-codec. Signed-off-by: David Härdeman --- drivers/media/rc/ir-lirc-codec.c | 1

[PATCH 19/19] lirc_dev: consistent device registration printk

2017-06-25 Thread David Härdeman
This patch changes the message that is printed on lirc device registration to make it more consistent with the input and rc subsystems. Before: rc rc0: rc-core loopback device as /devices/virtual/rc/rc0 input: rc-core loopback device as /devices/virtual/rc/rc0/input43 lirc lirc0: lirc_dev: d

[PATCH 17/19] ir-lirc-codec: merge lirc_dev_fop_ioctl into ir_lirc_ioctl

2017-06-25 Thread David Härdeman
ir_lirc_ioctl() is the only caller of lirc_dev_fop_ioctl() so merging the latter into the former makes the code more readable. At the same time, this allows the locking situation in ir_lirc_ioctl() to be fixed by holding the lirc_dev mutex during the whole ioctl call. Signed-off-by: David Härdeman

[PATCH 16/19] lirc_dev: merge struct irctl into struct lirc_dev

2017-06-25 Thread David Härdeman
The use of two separate structs (lirc_dev aka lirc_driver and irctl) makes it much harder to follow the proper lifetime of the various structs and necessitates hacks such as keeping a copy of struct lirc_dev inside struct irctl. Merging the two structs means that lirc_dev can properly manage the l

[PATCH 15/19] lirc_zilog: use a dynamically allocated lirc_dev

2017-06-25 Thread David Härdeman
lirc_zilog currently embeds a struct lirc_dev in its own struct IR, but subsequent patches will make the lifetime of struct lirc_dev dynamic (i.e. it will be free():d once lirc_dev is sure there are no users of the struct). Therefore, change lirc_zilog to use a pointer to a dynamically allocated s

[PATCH 12/19] lirc_dev: introduce lirc_allocate_device and lirc_free_device

2017-06-25 Thread David Härdeman
Introduce two new functions so that the API for lirc_dev matches that of the rc-core and input subsystems. This means that lirc_dev structs are managed using the usual four functions: lirc_allocate_device lirc_free_device lirc_register_device lirc_unregister_device The functions are pretty simpli

[PATCH 13/19] lirc_dev: remove the BUFLEN define

2017-06-25 Thread David Härdeman
The define is only used in the lirc_zilog driver and once in lirc_dev. In lirc_dev it rather serves to make the limits on d->code_length less clear, so move the define to lirc_zilog. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c |5 ++--- drivers/staging/media/li

[PATCH 10/19] lirc_dev: use an IDA instead of an array to keep track of registered devices

2017-06-25 Thread David Härdeman
Using the kernel-provided IDA simplifies the code and makes it possible to remove the lirc_dev_lock mutex. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c | 36 include/media/lirc_dev.h|1 - 2 files changed, 12 insertions(+), 25 deleti

[PATCH 14/19] lirc_zilog: add a pointer to the parent device to struct IR

2017-06-25 Thread David Härdeman
lirc_zilog stashes a pointer to the parent device in struct lirc_dev and uses it for logging. It makes more sense to let lirc_zilog keep track of that pointer in its own struct (this is in preparation for subsequent patches which will remodel struct lirc_dev). Signed-off-by: David Härdeman --- d

[PATCH 11/19] lirc_dev: rename struct lirc_driver to struct lirc_dev

2017-06-25 Thread David Härdeman
This is in preparation for the later patches which do away with struct irctl entirely. Signed-off-by: David Härdeman --- drivers/media/rc/ir-lirc-codec.c| 50 --- drivers/media/rc/lirc_dev.c | 12 --- drivers/media/rc/rc-core-priv.h

[PATCH 09/19] lirc_dev: sanitize locking

2017-06-25 Thread David Härdeman
Use the irctl mutex for all device operations and only use lirc_dev_lock to protect the irctls array. Also, make sure that the device is alive early in each fops function before doing anything else. Since this patch touches nearly every line where the irctl mutex is taken/released, it also renames

[PATCH 08/19] lirc_dev: change irctl->attached to be a boolean

2017-06-25 Thread David Härdeman
The "attached" member of struct irctl is a boolean value, so let the code reflect that. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index 92048

[PATCH 05/19] lirc_dev: make better use of file->private_data

2017-06-25 Thread David Härdeman
By making better use of file->private_data in lirc_dev we can avoid digging around in the irctls[] array, thereby simplifying the code. External drivers need to use lirc_get_pdata() instead of mucking around in file->private_data. The newly introduced lirc_init_pdata() function isn't very elegant

[PATCH 04/19] lirc_dev: use cdev_device_add() helper function

2017-06-25 Thread David Härdeman
Replace calls to cdev_add() and device_add() with the cdev_device_add() helper function. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.

[PATCH 06/19] lirc_dev: make chunk_size and buffer_size mandatory

2017-06-25 Thread David Härdeman
Make setting chunk_size and buffer_size mandatory for drivers which expect lirc_dev to allocate the lirc_buffer (i.e. ir-lirc-codec) and don't set them in lirc-zilog (which creates its own buffer). Also remove an unnecessary copy of chunk_size in struct irctl (the same information is already avail

[PATCH 07/19] lirc_dev: remove kmalloc in lirc_dev_fop_read()

2017-06-25 Thread David Härdeman
lirc_zilog uses a chunk_size of 2 and ir-lirc-codec uses sizeof(int). Therefore, using stack memory should be perfectly fine. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b

[PATCH 01/19] lirc_dev: clarify error handling

2017-06-25 Thread David Härdeman
If an error is generated, it is more logical to error out ASAP. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index db1e7b70c998..9c1d55e41e34 10

[PATCH 03/19] lirc_dev: remove min_timeout and max_timeout

2017-06-25 Thread David Härdeman
There are no users of this functionality (ir-lirc-codec.c has its own implementation and lirc_zilog.c doesn't use it) so remove it. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c | 18 -- include/media/lirc_dev.h|8 2 files changed, 26 deletions(

[PATCH 02/19] lirc_dev: remove support for manually specifying minor number

2017-06-25 Thread David Härdeman
All users of lirc_register_driver() uses dynamic minor allocation, therefore we can remove the ability to explicitly request a given number. This changes the function prototype of lirc_unregister_driver() to also take a struct lirc_driver pointer as the sole argument. Signed-off-by: David Härdema

[PATCH 00/19] lirc_dev modernisation

2017-06-25 Thread David Härdeman
This patch series reworks lirc_dev to use a single struct lirc_dev to keep track of registered lirc devices rather than the current situation where a combination of a struct lirc_driver and a struct irctl are used. The fact that two structs are currently used per device makes the current code harde

Re: [PATCH v2 08/15] [media] cxd2880: Add top level of the driver

2017-06-25 Thread Mauro Carvalho Chehab
Em Fri, 23 Jun 2017 10:02:39 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 19 Jun 2017 16:56:13 +0900 > "Takiguchi, Yasunari" escreveu: > > > >> +static int cxd2880_get_frontend_t(struct dvb_frontend *fe, > > >> +struct dtv_frontend_properties *c) > > >> +{ > >

[PATCH v3 3/4] [media] dvb-frontends/stv0367: DVB-C signal strength statistics

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Provide QAM/DVB-C signal strength in decibel scale. Values returned from stv0367cab_get_rf_lvl() are good but need to be multiplied as they're in 1dBm precision. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 21 + 1 file ch

[PATCH v3 4/4] [media] dvb-frontends/stv0367: update UCB readout condition logic

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Since the other statistics are read when fe_status conditions are TRUE, change the ucblocks readout logic to match this aswell. Signed-off-by: Daniel Scheller --- drivers/media/dvb-frontends/stv0367.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff

[PATCH v3 2/4] [media] dvb-frontends/stv0367: SNR DVBv5 statistics for DVB-C and T

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Add signal-to-noise-ratio as provided by the demodulator in decibel scale. QAM/DVB-C needs some intlog calculation to have usable dB values, OFDM/ DVB-T values from the demod look alright already and are provided as-is. Signed-off-by: Daniel Scheller --- drivers/media/dvb

[PATCH v3 0/4] STV0367/DDB DVBv5 signal statistics

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller This series adds DVBv5 statistics support to the new DDB codepath of the stv0367 demodulator driver. The changes utilise already existing functionality (in form of register readouts), but wraps the reads in separate functions so the existing relative scale reporting can be

[PATCH v3 1/4] [media] dvb-frontends/stv0367: Improve DVB-C/T frontend status

2017-06-25 Thread Daniel Scheller
From: Mauro Carvalho Chehab The stv0367 driver provide a lot of status on its state machine. Change the logic to provide more information about frontend locking status. Also, while any detailed status isn't available, provide a more complete FE_STATUS for DVB-T. Signed-off-by: Mauro Carvalho Che

[PATCH] [media] dvb-frontends/cxd2841er: require STATE_ACTIVE_* for agc readout

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller When the demod driver puts the demod into sleep or shutdown state and it's status is then polled e.g. via "dvb-fe-tool -m", i2c errors are printed to the kernel log. If the last delsys was DVB-T/T2: cxd2841er: i2c wr failed=-5 addr=6c reg=00 len=1 cxd2841er: i2c rd fail

[PATCH] [media] ddbridge: dev_* logging fixup

2017-06-25 Thread Daniel Scheller
From: Daniel Scheller Fixup commit d52786ddd2d5 ("media: ddbridge: make (ddb)readl in while-loops fail-safe") after/wrt commit 11e358bf37e8 ("media: ddbridge: use dev_* macros in favor of printk") Signed-off-by: Daniel Scheller --- drivers/media/pci/ddbridge/ddbridge-core.c | 2 +- 1 f

omap3isp camera was Re: [PATCH v1 0/6] Add support of OV9655 camera

2017-06-25 Thread Pavel Machek
Hi! > * unfortunately we still get no image :( > > The latter is likely a setup issue of our camera interface (OMAP3 ISP = Image > Signal Processor) which > we were not yet able to solve. Oscilloscoping signals on the interface > indicated that signals and > sync are correct. But we do not know