[PATCH] staging: media/platform/bcm2835: remove gstreamer workaround

2017-04-01 Thread Kevin Wern
Gstreamer's v4l2src reacted poorly to certain outputs from the bcm2835 video driver's ioctl ops function vidioc_enum_framesizes, so a workaround was created that could be activated by user input. This workaround would replace the driver's ioctl ops struct with another, similar struct--only with no

cron job: media_tree daily build: ERRORS

2017-04-01 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sun Apr 2 05:00:15 CEST 2017 media-tree git hash:c3d4fb0fb41f4b5eafeee51173c14e50be12f839 media_build gi

Re: [PATCH v2] staging: radio-bcm2048: fixed bare use of unsigned int

2017-04-01 Thread kbuild test robot
Hi Eddie, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.11-rc4 next-20170331] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Eddie-Youseph/staging-radio-bcm2048-fi

Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.

2017-04-01 Thread Daniel Cashman
My apologies; I did not review the TODO. Consider this withdrawn. Dan On 03/29/2017 10:30 AM, Alan Cox wrote: > On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote: >> From: Dan Cashman >> >> Signed-off-by: Dan Cashman > > > As the TODO asks - please no whitespace cleanups yet. They make

[PATCH 4/4] dw2102: limit messages to buffer size

2017-04-01 Thread Alyssa Milburn
Otherwise the i2c transfer functions can read or write beyond the end of stack or heap buffers. Signed-off-by: Alyssa Milburn --- drivers/media/usb/dvb-usb/dw2102.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/drivers/media/usb/dvb-usb/dw2102.c b/d

[PATCH 3/4] ttusb2: limit messages to buffer size

2017-04-01 Thread Alyssa Milburn
Otherwise ttusb2_i2c_xfer can read or write beyond the end of static and heap buffers. Signed-off-by: Alyssa Milburn --- drivers/media/usb/dvb-usb/ttusb2.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/media/usb/dvb-usb/ttusb2.c b/drivers/media/usb/dvb-usb/ttu

[PATCH 2/4] zr364xx: enforce minimum size when reading header

2017-04-01 Thread Alyssa Milburn
This code copies actual_length-128 bytes from the header, which will underflow if the received buffer is too small. Signed-off-by: Alyssa Milburn --- drivers/media/usb/zr364xx/zr364xx.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/med

[PATCH 1/4] digitv: limit messages to buffer size

2017-04-01 Thread Alyssa Milburn
Return an error rather than memcpy()ing beyond the end of the buffer. Internal callers use appropriate sizes, but digitv_i2c_xfer may not. Signed-off-by: Alyssa Milburn --- drivers/media/usb/dvb-usb/digitv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/usb/dvb-usb/digitv.

[PATCH 0/4] media: fix some potential buffer overruns

2017-04-01 Thread Alyssa Milburn
I don't own any of this hardware, so I can't test these patches; I'd appreciate it if someone with the hardware could do so, but in theory they shouldn't break anything. Most of the patches below fix overruns which can be induced by local users, but only if they can read or write to i2c devices. T

[PATCH] libdvbv5: T2 delivery descriptor: fix wrong size of bandwidth field

2017-04-01 Thread Clemens Ladisch
ETSI EN 300 468 V1.11.1 ยง 6.4.4.2 defines the bandwith field as having four bits. Signed-off-by: Clemens Ladisch --- v4l-utils/lib/include/libdvbv5/desc_t2_delivery.h.orig +++ v4l-utils/lib/include/libdvbv5/desc_t2_delivery.h @@ -86,7 +86,7 @@ struct dvb_desc_t2_delivery {

Re: [PATCHv6 01/10] media: add CEC notifier support

2017-04-01 Thread Hans Verkuil
On 01/04/17 11:39, Russell King - ARM Linux wrote: > On Sat, Apr 01, 2017 at 11:22:03AM +0200, Hans Verkuil wrote: >> On 31/03/17 22:46, Russell King - ARM Linux wrote: >>> On Fri, Mar 31, 2017 at 02:20:27PM +0200, Hans Verkuil wrote: +struct cec_notifier *cec_notifier_get(struct device *dev)

Re: [PATCHv6 01/10] media: add CEC notifier support

2017-04-01 Thread Russell King - ARM Linux
On Sat, Apr 01, 2017 at 11:22:03AM +0200, Hans Verkuil wrote: > On 31/03/17 22:46, Russell King - ARM Linux wrote: > > On Fri, Mar 31, 2017 at 02:20:27PM +0200, Hans Verkuil wrote: > >> +struct cec_notifier *cec_notifier_get(struct device *dev) > >> +{ > >> + struct cec_notifier *n; > >> + > >> +

Re: [PATCHv6 01/10] media: add CEC notifier support

2017-04-01 Thread Hans Verkuil
On 31/03/17 22:46, Russell King - ARM Linux wrote: > On Fri, Mar 31, 2017 at 02:20:27PM +0200, Hans Verkuil wrote: >> +struct cec_notifier *cec_notifier_get(struct device *dev) >> +{ >> +struct cec_notifier *n; >> + >> +mutex_lock(&cec_notifiers_lock); >> +list_for_each_entry(n, &cec_no